November 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/5] max9867 driver update
by Ladislav Michl 28 Nov '18

28 Nov '18

Hi Mark, this is yet another round of driver update. Tested on AT91SAM9G20 based board with codec in master mode. All implemeted controls do work now. Ladislav Michl (5): ASoC: max9867: Fix whitespace ASoC: max9867: Fix power management ASoC: max9867: Calculate LRCLK divider ASoC: max9867: Fix signal paths ASoC: max9867: Add copyright and module author sound/soc/codecs/max9867.c | 479 ++++++++++++++++++------------------- sound/soc/codecs/max9867.h | 41 ++-- 2 files changed, 247 insertions(+), 273 deletions(-) -- 2.19.1

2 9

[alsa-devel] [PATCH v7 0/3] Huawei laptops
by Ayman Bagabas 28 Nov '18

28 Nov '18

This patch set is based on new audio LED triggers in branch topic/leds-trigger from git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git Changes from v6: * Use audio LED triggers patch set * Use KEY_CONFIG (XF86Tools) instead of KEY_PROG1. In Windows, the key is used to launch Huawei PC manager. XF86Tools is used by default on most desktop environments i.e. Gnome. Ayman Bagabas (3): ALSA: hda: fix front speakers on Huawei MBXP. x86: add support for Huawei WMI hotkeys. ALSA: hda: add support for Huawei WMI micmute LED drivers/platform/x86/Kconfig | 15 ++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/huawei-wmi.c | 247 ++++++++++++++++++++++++++++++ sound/pci/hda/patch_realtek.c | 22 +++ 4 files changed, 285 insertions(+) create mode 100644 drivers/platform/x86/huawei-wmi.c -- 2.19.1

4 9

[alsa-devel] [PATCH] ALSA: usb-audio: Add vendor and product name for Dell WD19 Dock
by Hui Wang 28 Nov '18

28 Nov '18

Like the Dell WD15 Dock, the WD19 Dock (0bda:402e) doens't provide useful string for the vendor and product names too, and WD19 has a headset Jack and a Speaker out Jack. In order to support UCM for this Dock in the alsa-lib, here we add profile_name too. Signed-off-by: Hui Wang <hui.wang(a)canonical.com> --- sound/usb/quirks-table.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h index 849953e5775c..4c10015cc0ca 100644 --- a/sound/usb/quirks-table.h +++ b/sound/usb/quirks-table.h @@ -3382,5 +3382,15 @@ AU0828_DEVICE(0x2040, 0x7270, "Hauppauge", "HVR-950Q"), .ifnum = QUIRK_NO_INTERFACE } }, +/* Dell WD19 Dock */ +{ + USB_DEVICE(0x0bda, 0x402e), + .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { + .vendor_name = "Dell", + .product_name = "WD19 Dock", + .profile_name = "Dell-WD19-Dock", + .ifnum = QUIRK_NO_INTERFACE + } +}, #undef USB_DEVICE_VENDOR_SPEC -- 2.17.1

2 2

[alsa-devel] [sound:for-linus 18/18] drivers/net//ethernet/via/via-rhine.c:1118:2: error: implicit declaration of function 'pci_iounmap'; did you mean 'pcim_iounmap'?
by kbuild test robot 27 Nov '18

27 Nov '18

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-linus head: 22449df3017d056abde1a1366abe6bb6a3e87751 commit: 22449df3017d056abde1a1366abe6bb6a3e87751 [18/18] sh: Always enable CONFIG_GENERIC_PCI_IOMAP config: sh-allyesconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 22449df3017d056abde1a1366abe6bb6a3e87751 # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=sh All errors (new ones prefixed by >>): drivers/net//ethernet/via/via-rhine.c: In function 'rhine_init_one_pci': >> drivers/net//ethernet/via/via-rhine.c:1118:2: error: implicit declaration of function 'pci_iounmap'; did you mean 'pcim_iounmap'? [-Werror=implicit-function-declaration] pci_iounmap(pdev, ioaddr); ^~~~~~~~~~~ pcim_iounmap drivers/net//ethernet/via/via-rhine.c: In function 'rhine_remove_one_platform': drivers/net//ethernet/via/via-rhine.c:2467:24: warning: unused variable 'rp' [-Wunused-variable] struct rhine_private *rp = netdev_priv(dev); ^~ cc1: some warnings being treated as errors vim +1118 drivers/net//ethernet/via/via-rhine.c 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1060 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1061 rc = pci_enable_device(pdev); 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1062 if (rc) 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1063 goto err_out; 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1064 ca8b6e04b drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-30 1065 if (pdev->revision < VTunknown0) { 5b579e212 drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-05-03 1066 quirks |= rqRhineI; ca8b6e04b drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-30 1067 } else if (pdev->revision >= VT6102) { 5b579e212 drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-05-03 1068 quirks |= rqWOL | rqForceReset; ca8b6e04b drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-30 1069 if (pdev->revision < VT6105) { ca8b6e04b drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-30 1070 quirks |= rqStatusWBRace; ca8b6e04b drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-30 1071 } else { ca8b6e04b drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-30 1072 quirks |= rqIntPHY; ca8b6e04b drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-30 1073 if (pdev->revision >= VT6105_B0) ca8b6e04b drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-30 1074 quirks |= rq6patterns; ca8b6e04b drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-30 1075 if (pdev->revision >= VT6105M) ca8b6e04b drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-30 1076 quirks |= rqMgmt; ca8b6e04b drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-30 1077 } ca8b6e04b drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-30 1078 } ca8b6e04b drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-30 1079 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1080 /* sanity check */ 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1081 if ((pci_resource_len(pdev, 0) < io_size) || 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1082 (pci_resource_len(pdev, 1) < io_size)) { 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1083 rc = -EIO; 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1084 dev_err(hwdev, "Insufficient PCI resources, aborting\n"); 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1085 goto err_out_pci_disable; 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1086 } 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1087 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1088 pioaddr = pci_resource_start(pdev, 0); 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1089 memaddr = pci_resource_start(pdev, 1); 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1090 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1091 pci_set_master(pdev); 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1092 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1093 rc = pci_request_regions(pdev, DRV_NAME); 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1094 if (rc) 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1095 goto err_out_pci_disable; 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1096 5b579e212 drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-05-03 1097 ioaddr = pci_iomap(pdev, (quirks & rqNeedEnMMIO ? 1 : 0), io_size); 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1098 if (!ioaddr) { 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1099 rc = -EIO; 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1100 dev_err(hwdev, 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1101 "ioremap failed for device %s, region 0x%X @ 0x%lX\n", 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1102 dev_name(hwdev), io_size, memaddr); 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1103 goto err_out_free_res; 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1104 } 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1105 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1106 enable_mmio(pioaddr, quirks); 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1107 5b579e212 drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-05-03 1108 rc = verify_mmio(hwdev, pioaddr, ioaddr, quirks); 5b579e212 drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-05-03 1109 if (rc) 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1110 goto err_out_unmap; 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1111 ca8b6e04b drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-30 1112 rc = rhine_init_one_common(&pdev->dev, quirks, 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1113 pioaddr, ioaddr, pdev->irq); 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1114 if (!rc) 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1115 return 0; 2d283862d drivers/net/ethernet/via/via-rhine.c Alexey Charkov 2014-04-22 1116 ^1da177e4 drivers/net/via-rhine.c Linus Torvalds 2005-04-16 1117 err_out_unmap: ^1da177e4 drivers/net/via-rhine.c Linus Torvalds 2005-04-16 @1118 pci_iounmap(pdev, ioaddr); ^1da177e4 drivers/net/via-rhine.c Linus Torvalds 2005-04-16 1119 err_out_free_res: ^1da177e4 drivers/net/via-rhine.c Linus Torvalds 2005-04-16 1120 pci_release_regions(pdev); ae996154f drivers/net/ethernet/via/via-rhine.c Roger Luethi 2014-03-18 1121 err_out_pci_disable: ae996154f drivers/net/ethernet/via/via-rhine.c Roger Luethi 2014-03-18 1122 pci_disable_device(pdev); ^1da177e4 drivers/net/via-rhine.c Linus Torvalds 2005-04-16 1123 err_out: ^1da177e4 drivers/net/via-rhine.c Linus Torvalds 2005-04-16 1124 return rc; ^1da177e4 drivers/net/via-rhine.c Linus Torvalds 2005-04-16 1125 } ^1da177e4 drivers/net/via-rhine.c Linus Torvalds 2005-04-16 1126 :::::: The code at line 1118 was first introduced by commit :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 :::::: TO: Linus Torvalds <torvalds(a)ppc970.osdl.org> :::::: CC: Linus Torvalds <torvalds(a)ppc970.osdl.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset
by Ryan Lee 27 Nov '18

27 Nov '18

Signed-off-by: Ryan Lee <ryans.lee(a)maximintegrated.com> --- Changes : Created max98373_reset function to minimize code duplication. Changed regmap_write to regmap_update_bits. Other bits except LSB need to be masked. Added reset verification step to make sure software reset is completed well. Software reset is done in 10ms in normal case. Revision ID is available when the amp is in the idle state which means software reset is completed. Software reset will be performed maximum 3 times to avoid amp reset failure. Generally it is done in the first trial. sleep time after software reset is increased + 30ms for every retrial. Maximum possible msleep time is 100 ms (initial 10 ms + 30 ms * 3 times). sound/soc/codecs/max98373.c | 41 +++++++++++++++++++++++++++++++++++------ 1 file changed, 35 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/max98373.c b/sound/soc/codecs/max98373.c index a09d013..55af7f02 100644 --- a/sound/soc/codecs/max98373.c +++ b/sound/soc/codecs/max98373.c @@ -724,14 +724,45 @@ static struct snd_soc_dai_driver max98373_dai[] = { } }; +static void max98373_reset(struct max98373_priv *max98373, struct device *dev) +{ + int ret, reg, count, delay; + + count = 0; + while (true) { + /* Software Reset */ + ret = regmap_update_bits(max98373->regmap, + MAX98373_R2000_SW_RESET, + MAX98373_SOFT_RESET, + MAX98373_SOFT_RESET); + if (ret) + dev_err(dev, "Reset command failed. (ret:%d)\n", ret); + + delay = 10000 + (count * 30000); + usleep_range(delay, delay + 1000); + + /* Software Reset Verification */ + ret = regmap_read(max98373->regmap, + MAX98373_R21FF_REV_ID, &reg); + if (!ret) { + dev_info(dev, "Reset completed (retry:%d)\n", count); + break; + } + + if (++count > 3) { + dev_err(dev, "Reset failed. (ret:%d)\n", ret); + break; + } + usleep_range(10000, 11000); + } +} + static int max98373_probe(struct snd_soc_component *component) { struct max98373_priv *max98373 = snd_soc_component_get_drvdata(component); /* Software Reset */ - regmap_write(max98373->regmap, - MAX98373_R2000_SW_RESET, MAX98373_SOFT_RESET); - usleep_range(10000, 11000); + max98373_reset(max98373, component->dev); /* IV default slot configuration */ regmap_write(max98373->regmap, @@ -818,9 +849,7 @@ static int max98373_resume(struct device *dev) { struct max98373_priv *max98373 = dev_get_drvdata(dev); - regmap_write(max98373->regmap, - MAX98373_R2000_SW_RESET, MAX98373_SOFT_RESET); - usleep_range(10000, 11000); + max98373_reset(max98373, dev); regcache_cache_only(max98373->regmap, false); regcache_sync(max98373->regmap); return 0; -- 2.7.4

3 6

[alsa-devel] [PATCH] slimbus: ngd: fix spelling mistake "exeeds" -> "exceeds"
by Colin King 27 Nov '18

27 Nov '18

From: Colin Ian King <colin.king(a)canonical.com> There is a spelling mistake in a dev_err message, fix this. Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/slimbus/qcom-ngd-ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index ccf33217236c..71f094c9ec68 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -787,7 +787,7 @@ static int qcom_slim_ngd_xfer_msg(struct slim_controller *sctrl, if (txn->msg->num_bytes > SLIM_MSGQ_BUF_LEN || txn->rl > SLIM_MSGQ_BUF_LEN) { - dev_err(ctrl->dev, "msg exeeds HW limit\n"); + dev_err(ctrl->dev, "msg exceeds HW limit\n"); return -EINVAL; } -- 2.19.1

2 1

[alsa-devel] [GIT PULL] ASoC fixes for v4.20
by Mark Brown 27 Nov '18

27 Nov '18

The following changes since commit 6be0f96d799f487f05eb412d362d5a1747d665c2: ASoC: stm32: sai: fix master clock naming (2018-10-23 10:51:45 +0100) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-v4.20-rc4 for you to fetch changes up to ffdcc3638c58d55a6fa68b6e5dfd4fb4109652eb: ASoC: omap-dmic: Add pm_qos handling to avoid overruns with CPU_IDLE (2018-11-23 14:05:30 +0000) ---------------------------------------------------------------- ASoC: Fixes for v4.20 Lots of fixes here, the majority of which are driver specific but there's a couple of core things and one notable driver specific one: - A core fix for a DAPM regression introduced during the component refactoring, we'd lost the code that forced a reevaluation of the DAPM graph after probe (which we suppress during init to save lots of recalcuation) and have now restored it. - A core fix for error handling using the newly added for_each_rtd_codec_dai_rollback() macro. - A fix for the names of widgets in the newly introduced pcm3060 driver, merged as a fix so we don't have a release with legacy names. ---------------------------------------------------------------- Andreas Dannenberg (1): ASoC: pcm186x: Fix device reset-registers trigger value Clément Péron (1): MAINTAINERS: add ASoC maintainers for sound dt-bindings Hans de Goede (1): ASoC: intel: cht_bsw_max98090_ti: Add quirk for boards using pmc_plt_clk_0 Katsuhiro Suzuki (1): ASoC: rockchip: add missing slave_config setting for I2S Keyon Jie (1): ASoC: acpi: fix: continue searching when machine is ignored Kirill Marinushkin (1): ASoC: pcm3060: Rename output widgets Kuninori Morimoto (1): ASoC: rsnd: fixup clock start checker Peter Ujfalusi (4): ASoC: omap-abe-twl6040: Fix missing audio card caused by deferred probing ASoC: omap-mcbsp: Fix latency value calculation for pm_qos ASoC: omap-mcpdm: Add pm_qos handling to avoid under/overruns with CPU_IDLE ASoC: omap-dmic: Add pm_qos handling to avoid overruns with CPU_IDLE Pierre-Louis Bossart (3): ASoC: fix oops w/ for_each_rtd_codec_dai_rollback() macro ASoC: Intel: Power down links before turning off display audio power ASoC: Intel: Skylake: fix Kconfigs, make HDaudio codec optional Richard Fitzgerald (1): ASoC: wm_adsp: Fix dma-unsafe read of scratch registers Rohit kumar (2): ASoC: qdsp6: q6afe: Fix wrong MI2S SD line mask ASoC: qcom: Set dai_link id to each dai_link Srinivas Kandagatla (2): ASoC: qdsp6: q6asm-dai: Only add routing once. ASoC: qdsp6: q6afe-dai: Fix the dai widgets Tzung-Bi Shih (1): ASoC: dapm: Recalculate audio map forcely when card instantiated Vasily Khoruzhick (3): ASoC: sunxi: rename SND_SUNXI_ADDA_PR_REGMAP to SND_SUN8I_ADDA_PR_REGMAP ASoC: sun8i-codec: fix crash on module removal ASoC: sun8i-codec: add missing route for ADC kbuild test robot (1): ASoC: stm32: sai: fix noderef.cocci warnings MAINTAINERS | 1 + include/sound/soc.h | 2 +- sound/soc/codecs/hdac_hdmi.c | 11 +- sound/soc/codecs/pcm186x.h | 2 +- sound/soc/codecs/pcm3060.c | 12 +- sound/soc/codecs/wm_adsp.c | 37 ++--- sound/soc/intel/Kconfig | 26 +++- sound/soc/intel/boards/Kconfig | 24 ++-- sound/soc/intel/boards/cht_bsw_max98090_ti.c | 32 ++++- sound/soc/intel/skylake/skl.c | 32 +++-- sound/soc/omap/omap-abe-twl6040.c | 67 ++++----- sound/soc/omap/omap-dmic.c | 9 ++ sound/soc/omap/omap-mcbsp.c | 6 +- sound/soc/omap/omap-mcpdm.c | 43 +++++- sound/soc/qcom/common.c | 9 +- sound/soc/qcom/qdsp6/q6afe-dai.c | 208 +++++++++++++-------------- sound/soc/qcom/qdsp6/q6afe.c | 16 +-- sound/soc/qcom/qdsp6/q6asm-dai.c | 33 ----- sound/soc/qcom/qdsp6/q6routing.c | 19 +++ sound/soc/rockchip/rockchip_pcm.c | 1 + sound/soc/sh/rcar/ssi.c | 2 +- sound/soc/soc-acpi.c | 10 +- sound/soc/soc-core.c | 1 + sound/soc/stm/stm32_sai_sub.c | 2 +- sound/soc/sunxi/Kconfig | 2 +- sound/soc/sunxi/sun8i-codec.c | 12 +- 26 files changed, 360 insertions(+), 259 deletions(-)

2 1

[alsa-devel] ALC300 enable
by Kailang 27 Nov '18

27 Nov '18

Hi Takashi, Attach patch will enable new codec ALC300. Thanks. BR, Kailang

2 1

[alsa-devel] [PATCH] ALSA: hda/realtek - Add disable auto-mute quirk for HP Spectre x360 laptop
by Girija Kumar Kasinadhuni 27 Nov '18

27 Nov '18

This device makes a loud buzzing sound when a headphone is inserted while playing audio at full volume through the speaker. Signed-off-by: Girija Kumar Kasinadhuni <gkumar(a)neverware.com> --- sound/pci/hda/patch_realtek.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index fa61674..eeff2ff 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5495,6 +5495,7 @@ enum { ALC255_FIXUP_DELL_HEADSET_MIC, ALC295_FIXUP_HP_X360, ALC221_FIXUP_HP_HEADSET_MIC, + ALC295_FIXUP_HP_DISABLE_AUTOMUTE, }; static const struct hda_fixup alc269_fixups[] = { @@ -6362,6 +6363,10 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HEADSET_MIC }, + [ALC295_FIXUP_HP_DISABLE_AUTOMUTE] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc_fixup_auto_mute_via_amp, + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -6486,6 +6491,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x82bf, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x82c0, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre x360", ALC269_FIXUP_HP_MUTE_LED_MIC3), + SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre X360 ", ALC295_FIXUP_HP_DISABLE_AUTOMUTE), SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300), SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), -- 2.7.4

2 5

Re: [alsa-devel] CS8409 Macbook Pro 2016 2017
by Takashi Iwai 27 Nov '18

27 Nov '18

Please don't drop Cc to ML. Also avoid top-posting. On Sat, 04 Aug 2018 19:02:53 +0200, David Ulricht wrote: > > How can I do that ? > I tried verifying if /proc/asound/card0/codec#0 changes when i put > handphone jack in and out with "diff ver1 ver2" and it is exactly the same. Just do for each bit as you tried for GPIO output. In this case, the direction bit should be different (set 0), and you need to read. > > One strange thing I note is hda-jack-retask.fw contains: > [pincfg] > 0x24 0x90100080 > 0x25 0x90100082 > I have 0x90100080 for 0x24 but in /proc/asound/card0/codec#0 : > Node 0x24 [Pin Complex] wcaps 0x400101: Stereo > Pincap 0x00000010: OUT > Pin Default 0x90100110: [Fixed] Speaker at Int N/A > Conn = Unknown, Color = Unknown > DefAssociation = 0x1, Sequence = 0x0 > Misc = NO_PRESENCE > Pin-ctls: 0x40: OUT > Connection: 1 > 0x02 > > Shouldn't "Pin Default 0x90100110" be 0x90100080 after applying the patch ? No, the codec config value itself won't change, the driver uses the given value only internally. Takashi > I can see that Applying patch firmware 'hda-jack-retask.fw' is before > hdaudioC0D0: autoconfig for Generic: line_outs=2 (0x24/0x25/0x0/0x0/0x0) > type:speaker > in dmesg and this worries me, maybe the pins are overriden by generic > cirrus logic ? > > > On Sat, Aug 4, 2018 at 7:26 PM, Takashi Iwai <tiwai(a)suse.de> wrote: > > > On Sat, 04 Aug 2018 17:44:59 +0200, > > David Ulricht wrote: > > > > > > I used the following script running as root to verify the 8 GPIOs while > > > playing long youtube video, > > > I have running pulseaudio meanwhile and not restarting it, i think its > > okay > > > like that people on the ubuntu forums say that after using > > > hda-verb and setting a gpio active immediately sound appears, so i guess > > > there is no need to restart pulseaudio. > > > I have done the same test with headphones in. > > > No sound in both scenarios, no input no output detected (i'm watching > > > pavucontrol for input detection). > > > > This codec is fairly unique and doesn't provide the standard jack > > detection on each pin. Maybe it's via either GPIO or any other > > method. You can try to read GPIO pins (set as input) to see whether > > any of them corresponds to the jack detection, for example. > > > > > > Takashi > > > > > > > > #!/usr/bin/env python3 > > > import os,time > > > for x in range(0,256): > > > mhex=("0x%0.2X" % x) > > > os.system("hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_MASK "+mhex) > > > os.system("hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DIRECTION "+mhex) > > > os.system("hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DATA "+mhex) > > > time.sleep(3) > > > > > > Meanwhile script is running I'm watching /proc/asound/card0/codec#0 and > > > IO[0-7] changes its configuration, > > > in comparison Joel Krahemann in his scripts is changing the hex right > > after > > > /dev/snd/hwC0D0 (0x01) e.g. i dont think he is modifiying the GPIOs > > > correctly. > > > > > > I found the following post: > > > https://forum.manjaro.org/t/sound-not-working-on-a-2017- > > imac-27-5k-retina/43638 > > > According to https://bugzilla.kernel.org/show_bug.cgi?id=195671 iMac27 > > has > > > a similar soundcard. > > > How can i setup with command line or any other utility: > > > """select “off” in the top menu that propose to setup the Digital > > > Surround""" > > > this is some setting in xfce4-mixer package which is not available for > > > ubuntu since 2 LTS versions behind. I tried current Manjaro and couldn't > > > find this setting in audio mixer of xfce4 either. > > > > > > On Sat, Aug 4, 2018 at 9:48 AM, Takashi Iwai <tiwai(a)suse.de> wrote: > > > > > > > On Sat, 04 Aug 2018 04:07:43 +0200, > > > > David Ulricht wrote: > > > > > > > > > > Hello, > > > > > > > > > > Macbook pro models containing CS8409 for sure are: > > > > > MBP131 MBP141.I own MBP 14,1 e.g. 2017 model. > > > > > > > > > > I'm attaching working sound configuration from Windows 10 registry > > (note > > > > > that the cs420x might need to be ignored or might be important i > > don't > > > > > really know). I believe what is really used is in the > > PinConfigOverride > > > > > section. > > > > > > > > Comparing between BIOS default (init_pin_cfg in alsa-info.sh output) > > > > and your override (user_pin_cfg), there aren't so many changes. > > > > All changes are pretty minor, and I guess it won't influence on the > > > > driver behavior. > > > > > > > > > Interesting thing to note is that sound in MacOS is much louder than > > > > > Bootcamp Windows, would be nice to hear how loud is on linux. > > > > > > > > This is possibly with some vendor-specific GPIO or COEF verbs. > > > > Or it's some direct I2C control. The INI file mentions it. > > > > And that's above HD-audio driver's responsibility. > > > > > > > > > I did convert PinConfigOverride HEX strings to [pincfg] format in the > > > > > attached hda-jack-retask.fw thanks to Takashi's guidance. > > > > > > > > > > I'm attaching also alsamixer ASCII. Only PCM, no Master ? > > > > > > > > It's because the codec chip has no output amplifier at all. > > > > So there can be neither output volume nor mute control on this chip. > > > > > > > > > What I have tried is execute: > > > > > hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_MASK 0x@@ > > > > > hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DIRECTION 0x@@ > > > > > hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DATA 0x@@ > > > > > putting @@ from 0x00 to 0x50 > > > > > > > > There are eight GPIOs, so you'd need to test each bit, i.e. 0x01, > > > > 0x02, 0x04, 0x08, ... 0x80. > > > > > > > > And how is the current situation? You can't play *and* record > > > > anything from any inputs / outputs? > > > > > > > > > > > > Takashi > > > > > > > [2 <text/html; UTF-8 (quoted-printable)>] > > > > > > [2 <text/html; UTF-8 (quoted-printable)>] >

3 12