November 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] Undefined behaviour in ac97_codec.c - shift exponent 68 is too large for 32-bit type 'int'
by Meelis Roos 23 Nov '18

23 Nov '18

I updated one of my old laptops (ECS Desknote 532 with Transmeta CPU) to newest kernel (4.20.0-rc3-00145-gedeca3a769ad) and turned on UBSAN checks. Got the following UBSAN warning multiple times per boot. The soundcard: 00:04.0 Multimedia audio controller [0401]: ULi Electronics Inc. M5455 PCI AC-Link Controller Audio Device [10b9:5455] (rev 10) Subsystem: Elitegroup Computer Systems M5455 PCI AC-Link Controller Audio Device [1019:0f56] Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 64 (16000ns min), Cache Line Size: 128 bytes Interrupt: pin A routed to IRQ 5 Region 0: I/O ports at e400 [size=256] Region 1: Memory at febfe000 (32-bit, non-prefetchable) [size=4K] Capabilities: <access denied> Kernel driver in use: snd_intel8x0 Kernel modules: snd_intel8x0 /proc/asound/cards: 0 [M5455 ]: ICH - ALi M5455 ALi M5455 with ALC655 at irq 5 gcc version 8.2.0 (Debian 8.2.0-9) [ 15.688683] snd_intel8x0 0000:00:04.0: intel8x0_measure_ac97_clock: measured 58318 usecs (2808 samples) [ 15.689033] snd_intel8x0 0000:00:04.0: clocking to 48000 ... [ 19.667746] ================================================================================ [ 19.668078] UBSAN: Undefined behaviour in sound/pci/ac97/ac97_codec.c:836:7 [ 19.668268] shift exponent 68 is too large for 32-bit type 'int' [ 19.668465] CPU: 0 PID: 199 Comm: alsactl Not tainted 4.20.0-rc3-00145-gedeca3a769ad #2 [ 19.668602] Hardware name: Elitegroup Co. 532/532, BIOS 080010 02/22/2005 [ 19.668602] Call Trace: [ 19.668602] dump_stack+0x16/0x19 [ 19.668602] ubsan_epilogue+0xb/0x29 [ 19.668602] __ubsan_handle_shift_out_of_bounds.cold.15+0x26/0x78 [ 19.668602] snd_ac97_put_spsa.cold.50+0xf/0x24 [snd_ac97_codec] [ 19.668602] ? _copy_from_user+0x33/0xd0 [ 19.668602] snd_ctl_ioctl+0x69e/0x820 [ 19.668602] ? __seccomp_filter+0x60/0x320 [ 19.668602] ? snd_ctl_elem_add_user+0x8a0/0x8a0 [ 19.668602] do_vfs_ioctl+0x90/0x6c0 [ 19.668602] ? __switch_to_asm+0x26/0x4c [ 19.668602] ? __switch_to_asm+0x32/0x4c [ 19.668602] ? __switch_to_asm+0x26/0x4c [ 19.668602] ? __switch_to_asm+0x32/0x4c [ 19.668602] ? __switch_to_asm+0x26/0x4c [ 19.668602] ? __switch_to_asm+0x32/0x4c [ 19.668602] ? __switch_to_asm+0x26/0x4c [ 19.668602] ? __switch_to_asm+0x32/0x4c [ 19.668602] ? __switch_to_asm+0x26/0x4c [ 19.668602] ? __switch_to_asm+0x26/0x4c [ 19.668602] ? __secure_computing+0x2b/0x80 [ 19.668602] ? syscall_trace_enter+0x141/0x1b0 [ 19.668602] ? __switch_to_asm+0x26/0x4c [ 19.668602] ksys_ioctl+0x39/0x70 [ 19.668602] sys_ioctl+0x11/0x13 [ 19.668602] do_fast_syscall_32+0x90/0x1c0 [ 19.668602] entry_SYSENTER_32+0x6b/0xbd [ 19.668602] EIP: 0xb7fd69ad [ 19.668602] Code: 54 cd ff ff 85 d2 8b 98 58 cd ff ff 89 c8 74 02 89 0a 5b 5d c3 8b 04 24 c3 8b 14 24 c3 8b 3c 24 c3 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d 76 00 58 b8 77 00 00 00 cd 80 90 8d 76 [ 19.668602] EAX: ffffffda EBX: 00000003 ECX: c2c45513 EDX: bffff670 [ 19.668602] ESI: 00000000 EDI: 00000001 EBP: bffff9c8 ESP: bffff508 [ 19.668602] DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b EFLAGS: 00000292 [ 19.668602] ================================================================================ -- Meelis Roos <mroos(a)linux.ee>

2 3

[alsa-devel] [PATCH] ALSA: hda/realtek - fix headset mic detection for MSI MS-B171
by Anisse Astier 23 Nov '18

23 Nov '18

MSI Cubi N 8GL (MS-B171) needs the same fixup as its older model, the MS-B120, in order for the headset mic to be properly detected. They both use a single 3-way jack for both mic and headset with an ALC283 codec, with the same pins used. Cc: stable(a)vger.kernel.org Signed-off-by: Anisse Astier <anisse(a)astier.eu> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index fa61674a5605..1e789e43a5f4 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6531,6 +6531,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x144d, 0xc740, "Samsung Ativ book 8 (NP870Z5G)", ALC269_FIXUP_ATIV_BOOK_8), SND_PCI_QUIRK(0x1458, 0xfa53, "Gigabyte BXBT-2807", ALC283_FIXUP_HEADSET_MIC), SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC), + SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC), SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS), SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE), SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE), -- 2.11.0

2 1

[alsa-devel] [PATCH] ALSA: hda: Add ASRock N68C-S UCC the power_save blacklist
by Hans de Goede 23 Nov '18

23 Nov '18

Power-saving is causing plops on audio start/stop on the built-in audio of the nForce 430 based ASRock N68C-S UCC motherboard, add this model to the power_save blacklist. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1525104 Cc: <stable(a)vger.kernel.org> Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- sound/pci/hda/hda_intel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index d8eb2b5f51ae..0bbdf1a01e76 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2169,6 +2169,8 @@ static struct snd_pci_quirk power_save_blacklist[] = { /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ SND_PCI_QUIRK(0x1849, 0xc892, "Asrock B85M-ITX", 0), /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ + SND_PCI_QUIRK(0x1849, 0x0397, "Asrock N68C-S UCC", 0), + /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ SND_PCI_QUIRK(0x1849, 0x7662, "Asrock H81M-HDS", 0), /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0), -- 2.19.1

2 1

[alsa-devel] [PATCH 0/5] ALSA: firewire-tascam: support notification of
by Takashi Sakamoto 23 Nov '18

23 Nov '18

Hi, Units of TASCAM FireWire series transfer its state in tx isochronous packets. The way to handle change of the state is a longstanding issue since I firstly reveal the mechanism in this list[1]. In this time, Scott Bahling dedicates for further investigation to seek better implementation[2][3][4]. Finally, we identified meaning of the most of bits in the image of state, and decided which changes are worth for userspace applications to handle as events. This commit adds support notification of the events. Userspace applications can handle the notification via ALSA hwdep interface. Furthermore, they can retrieve image of the latest states via the interface. Changes from the initial proposal[5]: - obsolete usage of mmap(2) due to several disadvantages. Instead, use event queue for change notification, and add ioctl command to retrieve image of states. Changes from the latest work[6]: - To reduce time in an interrupt context in which tx isochronous packets are handled, data in the event and the image is passed to userspace in big-endian order. Additionally, image of the states are passed to userspace in big-endian order as well. Userspace applications are responsible to convert the data in host-endianness order. - improve efficiency to copy batch of events to userspace in hwdep interface - rename structure and macro name. This patchset is also available in my remote branch for backport purpose to Linux v4.17 or later[7]. I've already prepare userspace implementation; libhinwa. A 'topic/firewire-tascam-pr' remote branch includes patchset for the additional feature[8]. This library produces GObject class to handle the event notification and emits GObject signal, and has a method 'HinawaSndTscm.get_state()', with enough consideration to endianness. Developers can process change of state with these two APIs. > Scott As the above, I changed method name from 'HinawaSndTscm.get_status()'. I'd like you to change your local implementation for 'hinawa-utils'. Sorry to add further work to you. [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2015-July/094817.html [2] http://mailman.alsa-project.org/pipermail/alsa-devel/2018-September/140051.… [3] http://mailman.alsa-project.org/pipermail/alsa-devel/2018-October/140593.ht… [4] http://mailman.alsa-project.org/pipermail/alsa-devel/2018-November/141395.h… [5] https://github.com/takaswie/snd-firewire-improve/tree/topic/tascam-userspace [6] https://github.com/takaswie/snd-firewire-improve/tree/topic/tascam-userspac… [7] https://github.com/takaswie/snd-firewire-improve/tree/topic/tascam-userspac… [8] https://github.com/takaswie/libhinawa/tree/topic/tascam-userspace-pr Regards Takashi Sakamoto (5): ALSA: firewire-tascam: pick up data of state from tx isochronous pakcets ALSA: firewire-tascam: add new hwdep ioctl command to get state image ALSA: firewire-tascam: queue events for change of control surface ALSA: firewire-tascam: apply small refactoring to handle several type of event for hwdep interface ALSA: firewire-tascam: notify events of change of state for userspace applications include/uapi/sound/firewire.h | 20 +++++ sound/firewire/tascam/amdtp-tascam.c | 51 +++++++++++- sound/firewire/tascam/tascam-hwdep.c | 115 +++++++++++++++++++++++---- sound/firewire/tascam/tascam.h | 9 +++ 4 files changed, 180 insertions(+), 15 deletions(-) -- 2.19.1

2 7

[alsa-devel] Applied "ASoC: dt-bindings: add regulator property to simple amplifier" to the asoc tree
by Mark Brown 23 Nov '18

23 Nov '18

The patch ASoC: dt-bindings: add regulator property to simple amplifier has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 8e84de031a11c4240f3654fd4c380542e358f5f6 Mon Sep 17 00:00:00 2001 From: Vasily Khoruzhick <anarsoul(a)gmail.com> Date: Thu, 22 Nov 2018 18:23:20 +0800 Subject: [PATCH] ASoC: dt-bindings: add regulator property to simple amplifier Amplifier may have associated regulator, so add a property for it. Signed-off-by: Vasily Khoruzhick <anarsoul(a)gmail.com> Signed-off-by: Chen-Yu Tsai <wens(a)csie.org> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- Documentation/devicetree/bindings/sound/simple-amplifier.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/simple-amplifier.txt b/Documentation/devicetree/bindings/sound/simple-amplifier.txt index 8647edae7af0..7182ac4f1e65 100644 --- a/Documentation/devicetree/bindings/sound/simple-amplifier.txt +++ b/Documentation/devicetree/bindings/sound/simple-amplifier.txt @@ -4,9 +4,14 @@ Required properties: - compatible : "dioo,dio2125" or "simple-audio-amplifier" - enable-gpios : the gpio connected to the enable pin of the simple amplifier +Optional properties: +- VCC-supply : power supply for the device, as covered + in Documentation/devicetree/bindings/regulator/regulator.txt + Example: amp: analog-amplifier { compatible = "simple-audio-amplifier"; + VCC-supply = <&regulator>; enable-gpios = <&gpio GPIOH_3 0>; }; -- 2.19.1

1 0

[alsa-devel] Applied "ASoC: simple-amplifier: add VCC regulator widget" to the asoc tree
by Mark Brown 23 Nov '18

23 Nov '18

The patch ASoC: simple-amplifier: add VCC regulator widget has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 6debd01a74b8c15ab3f2a6f7ff4a7dcbada101cb Mon Sep 17 00:00:00 2001 From: Vasily Khoruzhick <anarsoul(a)gmail.com> Date: Thu, 22 Nov 2018 18:23:21 +0800 Subject: [PATCH] ASoC: simple-amplifier: add VCC regulator widget Amplifier may have assosicated regulator, so add a widget for it and appropriate route. Signed-off-by: Vasily Khoruzhick <anarsoul(a)gmail.com> Signed-off-by: Chen-Yu Tsai <wens(a)csie.org> Acked-by: Maxime Ripard <maxime.ripard(a)bootlin.com> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/codecs/simple-amplifier.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/codecs/simple-amplifier.c b/sound/soc/codecs/simple-amplifier.c index 85524acf3e9c..c07e8a80b4b7 100644 --- a/sound/soc/codecs/simple-amplifier.c +++ b/sound/soc/codecs/simple-amplifier.c @@ -19,6 +19,7 @@ #include <linux/gpio/consumer.h> #include <linux/module.h> +#include <linux/regulator/consumer.h> #include <sound/soc.h> #define DRV_NAME "simple-amplifier" @@ -58,11 +59,14 @@ static const struct snd_soc_dapm_widget simple_amp_dapm_widgets[] = { (SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_PRE_PMD)), SND_SOC_DAPM_OUTPUT("OUTL"), SND_SOC_DAPM_OUTPUT("OUTR"), + SND_SOC_DAPM_REGULATOR_SUPPLY("VCC", 20, 0), }; static const struct snd_soc_dapm_route simple_amp_dapm_routes[] = { { "DRV", NULL, "INL" }, { "DRV", NULL, "INR" }, + { "OUTL", NULL, "VCC" }, + { "OUTR", NULL, "VCC" }, { "OUTL", NULL, "DRV" }, { "OUTR", NULL, "DRV" }, }; -- 2.19.1

1 0

[alsa-devel] [PATCH 0/3] ASoC: omap: Fix and add pm_qos configuration
by Peter Ujfalusi 23 Nov '18

23 Nov '18

Hi, The defconfig for OMAP2+ now have the CPU_IDLE enabled which can cause audio artifacts because we try to enter too low power state from where the wakeup takes longer than the FIFO can tolerate on the dai side. While adding pm_qos to McPDM and DMIC I have noticed that the McBSP calculation was not correct as we need usec for the latency value. Regards, Peter --- Peter Ujfalusi (3): ASoC: omap-mcbsp: Fix latency value calculation for pm_qos ASoC: omap-mcpdm: Add pm_qos handling to avoid under/overruns with CPU_IDLE ASoC: omap-dmic: Add pm_qos handling to avoid overruns with CPU_IDLE sound/soc/omap/omap-dmic.c | 9 ++++++++ sound/soc/omap/omap-mcbsp.c | 6 +++--- sound/soc/omap/omap-mcpdm.c | 43 ++++++++++++++++++++++++++++++++++++- 3 files changed, 54 insertions(+), 4 deletions(-) -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

4 14

[alsa-devel] [PATCH] ASoC: sunxi: rename SND_SUN8I_ADDA_PR_REGMAP
by Arnd Bergmann 22 Nov '18

22 Nov '18

The newly added SND_SUN50I_CODEC_ANALOG driver selects a nonexisting symbol SND_SUNXI_ADDA_PR_REGMAP, which was evidently intended to replace SND_SUN8I_ADDA_PR_REGMAP, but since they are now mismatched, we can run into link errors for some configurations: sound/soc/sunxi/sun50i-codec-analog.o: In function `sun50i_codec_analog_probe': sun50i-codec-analog.c:(.text+0x62): undefined reference to `sun8i_adda_pr_regmap_init' The new name appears to be more sensible, and as the symbol is hidden, there are no downsides in the rename, so use that consistently now. Fixes: 42371f327df0 ("ASoC: sunxi: Add new driver for Allwinner A64 codec's analog path controls") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- sound/soc/sunxi/Kconfig | 4 ++-- sound/soc/sunxi/Makefile | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig index 66aad0d3f9c7..0f992bdf1a10 100644 --- a/sound/soc/sunxi/Kconfig +++ b/sound/soc/sunxi/Kconfig @@ -23,7 +23,7 @@ config SND_SUN8I_CODEC config SND_SUN8I_CODEC_ANALOG tristate "Allwinner sun8i Codec Analog Controls Support" depends on MACH_SUN8I || (ARM64 && ARCH_SUNXI) || COMPILE_TEST - select SND_SUN8I_ADDA_PR_REGMAP + select SND_SUNXI_ADDA_PR_REGMAP help Say Y or M if you want to add support for the analog controls for the codec embedded in newer Allwinner SoCs. @@ -54,7 +54,7 @@ config SND_SUN4I_SPDIF Say Y or M to add support for the S/PDIF audio block in the Allwinner A10 and affiliated SoCs. -config SND_SUN8I_ADDA_PR_REGMAP +config SND_SUNXI_ADDA_PR_REGMAP tristate select REGMAP diff --git a/sound/soc/sunxi/Makefile b/sound/soc/sunxi/Makefile index a86be340a076..c4dd2803a011 100644 --- a/sound/soc/sunxi/Makefile +++ b/sound/soc/sunxi/Makefile @@ -5,4 +5,4 @@ obj-$(CONFIG_SND_SUN4I_SPDIF) += sun4i-spdif.o obj-$(CONFIG_SND_SUN8I_CODEC_ANALOG) += sun8i-codec-analog.o obj-$(CONFIG_SND_SUN50I_CODEC_ANALOG) += sun50i-codec-analog.o obj-$(CONFIG_SND_SUN8I_CODEC) += sun8i-codec.o -obj-$(CONFIG_SND_SUN8I_ADDA_PR_REGMAP) += sun8i-adda-pr-regmap.o +obj-$(CONFIG_SND_SUNXI_ADDA_PR_REGMAP) += sun8i-adda-pr-regmap.o -- 2.18.0

4 5

[alsa-devel] [PATCH 0/2] ALSA: control: Race fix and cleanup for user ctls
by Takashi Iwai 22 Nov '18

22 Nov '18

Hi, there seems a possible race between addition and removal of a user ctl element as spotted by syzkaller. This patchset addresses it and also provides a cleanup thereafter. The first one should go to 4.20 while the second one should go for 4.21. Takashi === Takashi Iwai (2): ALSA: control: Fix race between adding and removing a user element ALSA: control: Consolidate helpers for adding and replacing ctl elements sound/core/control.c | 171 ++++++++++++++++++++----------------------- 1 file changed, 81 insertions(+), 90 deletions(-) -- 2.19.1

1 2

[alsa-devel] [PATCH 0/2] ASoC: SDM845: Update MI2S and TDM configuration
by Rohit kumar 21 Nov '18

21 Nov '18

Update bit clock rate, slot width for TDM and MI2S interfaces. Also add support for secondary MI2S TX interface in SDM845 machine driver. Rohit kumar (2): ASoC: sdm845: Update slot_width for Quaternary TDM port ASoC: sdm845: Add support for Secondary MI2S interface sound/soc/qcom/sdm845.c | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.

3 6