November 2018 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] [LKP] [ALSA] 3a6d1980fe: kernel_BUG_at_mm/page_alloc.c
by Takashi Iwai 26 Nov '18

26 Nov '18

On Mon, 26 Nov 2018 01:28:05 +0100, kernel test robot wrote: > > FYI, we noticed the following commit (built with gcc-7): > > commit: 3a6d1980fe96dbbfe3ae58db0048867f5319cdbf ("ALSA: Replace snd_malloc_pages() and snd_free_pages() with standard helpers") > https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git for-next .... > [ 174.830284] kernel BUG at mm/page_alloc.c:2850! OK, this seem to be an issue about using __GFP_COMP and alloc_pages_exact(). I didn't hit this while testing locally maybe just because I used the buffer size in power-of-two casually. I dropped the patch until we sort this out. thanks, Takashi

1 0

[alsa-devel] [PATCH 00/10] ASoC: merge audio-graph-scu into audio-graph - step2
by Kuninori Morimoto 26 Nov '18

26 Nov '18

Hi Mark audio-graph card can handle normal sound card, and audio-graph-scu card can handle DPCM sound card. But, we can't use these feature in same time now. So, this is the time to merge audio-graph and audio-graph-scu. The patch-set are a little bit huge (and few patches are depend on posted OF patch. I'm now waiting...), thus, I separated these into few steps. These are step2 patches Kuninori Morimoto (10): ASoC: soc-core: add snd_soc_of_parse_node_prefix() ASoC: simple-scu-card: tidyup "prefix" parsing on Doc ASoC: simple-scu-card: tidyup "prefix" parsing ASoC: audio-graph-scu-card: tidyup "prefix" parsing on Doc ASoC: audio-graph-scu-card: tidyup "prefix" parsing ASoC: audio-graph-scu-card: tidyup "convert-rate/channels" parsing on Doc ASoC: audio-graph-scu-card: tidyup "convert-rate/channels" parsing ASoC: audio-graph-scu-card: tidyup asoc_simple_card_parse_daifmt() timing ASoC: audio-graph-card: tidyup typo SND_AUDIO_GRAPH_CARD ASoC: audio-graph-card: tidyup define position .../bindings/sound/audio-graph-scu-card.txt | 4 +- .../devicetree/bindings/sound/simple-scu-card.txt | 2 +- include/sound/soc.h | 6 +- sound/soc/generic/Kconfig | 2 +- sound/soc/generic/audio-graph-card.c | 10 +-- sound/soc/generic/audio-graph-scu-card.c | 71 ++++++++++------------ sound/soc/generic/simple-scu-card.c | 7 +++ sound/soc/soc-core.c | 11 ++-- 8 files changed, 59 insertions(+), 54 deletions(-) -- 2.7.4

2 22

[alsa-devel] [PATCH] ALSA: pcm: Fix starvation on down_write_nonblock()
by Chanho Min 25 Nov '18

25 Nov '18

Commit 67ec1072b053 (ALSA: pcm: Fix rwsem deadlock for non-atomic PCM stream) fixes deadlock for non-atomic PCM stream. But, This patch causes antother stuck. If writer is RT thread and reader is a normal thread, the reader thread will be difficult to get scheduled. It may not give chance to release read locks and writer gets stuck for a long time or forever if they are pinned to single cpu. To fix this, The writer gives reader a chance to be scheduled by using the minimum msleep() instaed of spinning. This is for concept, We may need to change the function name and comments or suggest another approach. Signed-off-by: Chanho Min <chanho.min(a)lge.com> --- sound/core/pcm_native.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index 66c90f4..88d4aab 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -96,7 +96,7 @@ static DECLARE_RWSEM(snd_pcm_link_rwsem); static inline void down_write_nonblock(struct rw_semaphore *lock) { while (!down_write_trylock(lock)) - cond_resched(); + msleep(1); } #define PCM_LOCK_DEFAULT 0 -- 2.1.4

2 2

[alsa-devel] Fwd: [PATCH v2 01/13] conf/ucm: bytcr-rt5645: Use the generic bytcr/PlatformEnableSeq.conf
by youling 257 25 Nov '18

25 Nov '18

---------- Forwarded message --------- From: youling 257 <youling257(a)gmail.com> Date: 2018年11月24日周六下午6:42 Subject: Re: [PATCH v2 01/13] conf/ucm: bytcr-rt5645: Use the generic bytcr/PlatformEnableSeq.conf To: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com>, Takashi Iwai <tiwai(a)suse.de>, Hans de Goede <hdegoede(a)redhat.com>, <alsa-devel(a)vger.kernel.org> alsaucm -c chtrt5645 set _verb HiFi set _enadev Speaker ALSA lib conf.c:823:(get_char_skip_comments) Cannot access file bytcr/PlatformEnableSeq.conf ALSA lib conf.c:1877:(snd_config_load1) _toplevel_:17:18:Unexpected char ALSA lib utils.c:67:(uc_mgr_config_load) could not open configuration file /usr/share/alsa/ucm/ASUSTeKCOMPUTERINC.-X205TA-1.0-X205TA/ASUSTeKCOMPUTERINC.-X205TA-1.0-X205TA.conf ALSA lib parser.c:1427:(load_master_config) error: could not parse configuration for card ASUSTeKCOMPUTERINC.-X205TA-1.0-X205TA ALSA lib conf.c:823:(get_char_skip_comments) Cannot access file bytcr/PlatformEnableSeq.conf ALSA lib conf.c:1877:(snd_config_load1) _toplevel_:17:18:Unexpected char ALSA lib utils.c:75:(uc_mgr_config_load) could not load configuration file /usr/share/alsa/ucm/chtrt5645/HiFi.conf ALSA lib parser.c:1101:(parse_verb_file) error: failed to open verb file /usr/share/alsa/ucm/chtrt5645/HiFi.conf : -2 ALSA lib main.c:946:(snd_use_case_mgr_open) error: failed to import chtrt5645 use case configuration -22 alsaucm: error failed to open sound card chtrt5645: Invalid argument

1 0

[alsa-devel] [PATCH] ALSA: Replace snd_malloc_pages() and snd_free_pages() with standard helpers
by Takashi Iwai 24 Nov '18

24 Nov '18

snd_malloc_pages() and snd_free_pages() are merely thin wrappers of the standard page allocator / free functions. Even the arguments are compatible with some standard helpers, so there is little merit of keeping these wrappers. This patch replaces the all existing callers of snd_malloc_pages() and snd_free_pages() with the direct calls of the standard helper functions. In this version, we use a recently introduced one, alloc_pages_exact(), which suits better than the old snd_malloc_pages() implementation. Then we can avoid the waste of pages by alignment to power-of-two. Also, the __GFP_COMP flag that has been always added in the old implementation is dropped for most of callers now. The only one that may still need it is the PCM buffer allocation which can be quite large. The rest are single page allocations, so no sense to keep that flag. With these conversions, snd_malloc_pages() and snd_free_pages() are dropped altogether from the whole tree. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- include/sound/memalloc.h | 4 --- sound/core/memalloc.c | 54 +++------------------------------ sound/core/pcm.c | 14 ++++----- sound/usb/usx2y/usX2Yhwdep.c | 3 +- sound/usb/usx2y/usbusx2y.c | 3 +- sound/usb/usx2y/usx2yhwdeppcm.c | 6 ++-- 6 files changed, 19 insertions(+), 65 deletions(-) diff --git a/include/sound/memalloc.h b/include/sound/memalloc.h index af3fa577fa06..c56cb2871368 100644 --- a/include/sound/memalloc.h +++ b/include/sound/memalloc.h @@ -152,9 +152,5 @@ int snd_dma_alloc_pages_fallback(int type, struct device *dev, size_t size, struct snd_dma_buffer *dmab); void snd_dma_free_pages(struct snd_dma_buffer *dmab); -/* basic memory allocation functions */ -void *snd_malloc_pages(size_t size, gfp_t gfp_flags); -void snd_free_pages(void *ptr, size_t size); - #endif /* __SOUND_MEMALLOC_H */ diff --git a/sound/core/memalloc.c b/sound/core/memalloc.c index 59a4adc286ed..d12bf811e751 100644 --- a/sound/core/memalloc.c +++ b/sound/core/memalloc.c @@ -30,53 +30,6 @@ #endif #include <sound/memalloc.h> -/* - * - * Generic memory allocators - * - */ - -/** - * snd_malloc_pages - allocate pages with the given size - * @size: the size to allocate in bytes - * @gfp_flags: the allocation conditions, GFP_XXX - * - * Allocates the physically contiguous pages with the given size. - * - * Return: The pointer of the buffer, or %NULL if no enough memory. - */ -void *snd_malloc_pages(size_t size, gfp_t gfp_flags) -{ - int pg; - - if (WARN_ON(!size)) - return NULL; - if (WARN_ON(!gfp_flags)) - return NULL; - gfp_flags |= __GFP_COMP; /* compound page lets parts be mapped */ - pg = get_order(size); - return (void *) __get_free_pages(gfp_flags, pg); -} -EXPORT_SYMBOL(snd_malloc_pages); - -/** - * snd_free_pages - release the pages - * @ptr: the buffer pointer to release - * @size: the allocated buffer size - * - * Releases the buffer allocated via snd_malloc_pages(). - */ -void snd_free_pages(void *ptr, size_t size) -{ - int pg; - - if (ptr == NULL) - return; - pg = get_order(size); - free_pages((unsigned long) ptr, pg); -} -EXPORT_SYMBOL(snd_free_pages); - /* * * Bus-specific memory allocators @@ -188,8 +141,9 @@ int snd_dma_alloc_pages(int type, struct device *device, size_t size, dmab->bytes = 0; switch (type) { case SNDRV_DMA_TYPE_CONTINUOUS: - dmab->area = snd_malloc_pages(size, - (__force gfp_t)(unsigned long)device); + dmab->area = alloc_pages_exact(size, + (__force gfp_t)(unsigned long)device | + __GFP_COMP); dmab->addr = 0; break; #ifdef CONFIG_HAS_DMA @@ -273,7 +227,7 @@ void snd_dma_free_pages(struct snd_dma_buffer *dmab) { switch (dmab->dev.type) { case SNDRV_DMA_TYPE_CONTINUOUS: - snd_free_pages(dmab->area, dmab->bytes); + free_pages_exact(dmab->area, dmab->bytes); break; #ifdef CONFIG_HAS_DMA #ifdef CONFIG_GENERIC_ALLOCATOR diff --git a/sound/core/pcm.c b/sound/core/pcm.c index fdb9b92fc8d6..1c0ecb22b1f4 100644 --- a/sound/core/pcm.c +++ b/sound/core/pcm.c @@ -1004,22 +1004,22 @@ int snd_pcm_attach_substream(struct snd_pcm *pcm, int stream, return -ENOMEM; size = PAGE_ALIGN(sizeof(struct snd_pcm_mmap_status)); - runtime->status = snd_malloc_pages(size, GFP_KERNEL); + runtime->status = alloc_pages_exact(size, GFP_KERNEL); if (runtime->status == NULL) { kfree(runtime); return -ENOMEM; } - memset((void*)runtime->status, 0, size); + memset(runtime->status, 0, size); size = PAGE_ALIGN(sizeof(struct snd_pcm_mmap_control)); - runtime->control = snd_malloc_pages(size, GFP_KERNEL); + runtime->control = alloc_pages_exact(size, GFP_KERNEL); if (runtime->control == NULL) { - snd_free_pages((void*)runtime->status, + free_pages_exact(runtime->status, PAGE_ALIGN(sizeof(struct snd_pcm_mmap_status))); kfree(runtime); return -ENOMEM; } - memset((void*)runtime->control, 0, size); + memset(runtime->control, 0, size); init_waitqueue_head(&runtime->sleep); init_waitqueue_head(&runtime->tsleep); @@ -1045,9 +1045,9 @@ void snd_pcm_detach_substream(struct snd_pcm_substream *substream) runtime = substream->runtime; if (runtime->private_free != NULL) runtime->private_free(runtime); - snd_free_pages((void*)runtime->status, + free_pages_exact(runtime->status, PAGE_ALIGN(sizeof(struct snd_pcm_mmap_status))); - snd_free_pages((void*)runtime->control, + free_pages_exact(runtime->control, PAGE_ALIGN(sizeof(struct snd_pcm_mmap_control))); kfree(runtime->hw_constraints.rules); /* Avoid concurrent access to runtime via PCM timer interface */ diff --git a/sound/usb/usx2y/usX2Yhwdep.c b/sound/usb/usx2y/usX2Yhwdep.c index c1dd9a7b48df..bfe1108416cf 100644 --- a/sound/usb/usx2y/usX2Yhwdep.c +++ b/sound/usb/usx2y/usX2Yhwdep.c @@ -75,7 +75,8 @@ static int snd_us428ctls_mmap(struct snd_hwdep * hw, struct file *filp, struct v if (!us428->us428ctls_sharedmem) { init_waitqueue_head(&us428->us428ctls_wait_queue_head); - if(!(us428->us428ctls_sharedmem = snd_malloc_pages(sizeof(struct us428ctls_sharedmem), GFP_KERNEL))) + us428->us428ctls_sharedmem = alloc_pages_exact(sizeof(struct us428ctls_sharedmem), GFP_KERNEL); + if (!us428->us428ctls_sharedmem) return -ENOMEM; memset(us428->us428ctls_sharedmem, -1, sizeof(struct us428ctls_sharedmem)); us428->us428ctls_sharedmem->CtlSnapShotLast = -2; diff --git a/sound/usb/usx2y/usbusx2y.c b/sound/usb/usx2y/usbusx2y.c index da4a5a541512..9f7bbed2c0f0 100644 --- a/sound/usb/usx2y/usbusx2y.c +++ b/sound/usb/usx2y/usbusx2y.c @@ -437,7 +437,8 @@ static void snd_usX2Y_card_private_free(struct snd_card *card) kfree(usX2Y(card)->In04Buf); usb_free_urb(usX2Y(card)->In04urb); if (usX2Y(card)->us428ctls_sharedmem) - snd_free_pages(usX2Y(card)->us428ctls_sharedmem, sizeof(*usX2Y(card)->us428ctls_sharedmem)); + free_pages_exact(usX2Y(card)->us428ctls_sharedmem, + sizeof(*usX2Y(card)->us428ctls_sharedmem)); if (usX2Y(card)->card_index >= 0 && usX2Y(card)->card_index < SNDRV_CARDS) snd_usX2Y_card_used[usX2Y(card)->card_index] = 0; } diff --git a/sound/usb/usx2y/usx2yhwdeppcm.c b/sound/usb/usx2y/usx2yhwdeppcm.c index 4fd9276b8e50..4453c2b911d0 100644 --- a/sound/usb/usx2y/usx2yhwdeppcm.c +++ b/sound/usb/usx2y/usx2yhwdeppcm.c @@ -488,7 +488,9 @@ static int snd_usX2Y_usbpcm_prepare(struct snd_pcm_substream *substream) snd_printdd("snd_usX2Y_pcm_prepare(%p)\n", substream); if (NULL == usX2Y->hwdep_pcm_shm) { - if (NULL == (usX2Y->hwdep_pcm_shm = snd_malloc_pages(sizeof(struct snd_usX2Y_hwdep_pcm_shm), GFP_KERNEL))) + usX2Y->hwdep_pcm_shm = alloc_pages_exact(sizeof(struct snd_usX2Y_hwdep_pcm_shm), + GFP_KERNEL); + if (!usX2Y->hwdep_pcm_shm) return -ENOMEM; memset(usX2Y->hwdep_pcm_shm, 0, sizeof(struct snd_usX2Y_hwdep_pcm_shm)); } @@ -700,7 +702,7 @@ static void snd_usX2Y_hwdep_pcm_private_free(struct snd_hwdep *hwdep) { struct usX2Ydev *usX2Y = hwdep->private_data; if (NULL != usX2Y->hwdep_pcm_shm) - snd_free_pages(usX2Y->hwdep_pcm_shm, sizeof(struct snd_usX2Y_hwdep_pcm_shm)); + free_pages_exact(usX2Y->hwdep_pcm_shm, sizeof(struct snd_usX2Y_hwdep_pcm_shm)); } -- 2.19.1

3 3

[alsa-devel] [PATCH 1/2] ALSA: wss: Fix invalid snd_free_pages() at error path
by Takashi Iwai 24 Nov '18

24 Nov '18

Some spurious calls of snd_free_pages() have been overlooked and remain in the error paths of wss driver code. Since runtime->dma_area is managed by the PCM core helper, we shouldn't release manually. Drop the superfluous calls. Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/isa/wss/wss_lib.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/isa/wss/wss_lib.c b/sound/isa/wss/wss_lib.c index 32453f81b95a..3a5008837576 100644 --- a/sound/isa/wss/wss_lib.c +++ b/sound/isa/wss/wss_lib.c @@ -1531,7 +1531,6 @@ static int snd_wss_playback_open(struct snd_pcm_substream *substream) if (err < 0) { if (chip->release_dma) chip->release_dma(chip, chip->dma_private_data, chip->dma1); - snd_free_pages(runtime->dma_area, runtime->dma_bytes); return err; } chip->playback_substream = substream; @@ -1572,7 +1571,6 @@ static int snd_wss_capture_open(struct snd_pcm_substream *substream) if (err < 0) { if (chip->release_dma) chip->release_dma(chip, chip->dma_private_data, chip->dma2); - snd_free_pages(runtime->dma_area, runtime->dma_bytes); return err; } chip->capture_substream = substream; -- 2.19.1

2 3

[alsa-devel] [PATCH v3 0/3] Huawei laptops
by Ayman Bagabas 24 Nov '18

24 Nov '18

Changes from v2: * Support for Huawei MBX * Style and formating issues [PATCH v3 1/3] The first patch adds support for missing hotkeys on some models. [PATCH v3 2/3] This one enables the front speakers on the Huawei Matebook X Pro (MBXP). This solves bug 200501 https://bugzilla.kernel.org/show_bug.cgi?id=200501 It simply uses the pins configurations generated by hdajackretast using the settings posted on the bug page https://imgur.com/a/N1xsCVZ [PATCH v3 3/3] This enables the micmute LED on Huawei laptops using ACPI calls. Ayman Bagabas (3): x86: add support for Huawei WMI hotkeys. ALSA: hda: fix front speakers on Huawei MBXP. ALSA: hda: add support for Huawei WMI micmute LED drivers/platform/x86/Kconfig | 11 + drivers/platform/x86/Makefile | 1 + drivers/platform/x86/huawei_wmi.c | 236 +++++++++++++++++++ include/linux/platform_data/x86/huawei_wmi.h | 9 + sound/pci/hda/huawei_wmi_helper.c | 47 ++++ sound/pci/hda/patch_realtek.c | 29 +++ 6 files changed, 333 insertions(+) create mode 100644 drivers/platform/x86/huawei_wmi.c create mode 100644 include/linux/platform_data/x86/huawei_wmi.h create mode 100644 sound/pci/hda/huawei_wmi_helper.c -- 2.17.2

5 30

[alsa-devel] Undefined behaviour in ac97_codec.c - shift exponent 68 is too large for 32-bit type 'int'
by Meelis Roos 23 Nov '18

23 Nov '18

I updated one of my old laptops (ECS Desknote 532 with Transmeta CPU) to newest kernel (4.20.0-rc3-00145-gedeca3a769ad) and turned on UBSAN checks. Got the following UBSAN warning multiple times per boot. The soundcard: 00:04.0 Multimedia audio controller [0401]: ULi Electronics Inc. M5455 PCI AC-Link Controller Audio Device [10b9:5455] (rev 10) Subsystem: Elitegroup Computer Systems M5455 PCI AC-Link Controller Audio Device [1019:0f56] Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 64 (16000ns min), Cache Line Size: 128 bytes Interrupt: pin A routed to IRQ 5 Region 0: I/O ports at e400 [size=256] Region 1: Memory at febfe000 (32-bit, non-prefetchable) [size=4K] Capabilities: <access denied> Kernel driver in use: snd_intel8x0 Kernel modules: snd_intel8x0 /proc/asound/cards: 0 [M5455 ]: ICH - ALi M5455 ALi M5455 with ALC655 at irq 5 gcc version 8.2.0 (Debian 8.2.0-9) [ 15.688683] snd_intel8x0 0000:00:04.0: intel8x0_measure_ac97_clock: measured 58318 usecs (2808 samples) [ 15.689033] snd_intel8x0 0000:00:04.0: clocking to 48000 ... [ 19.667746] ================================================================================ [ 19.668078] UBSAN: Undefined behaviour in sound/pci/ac97/ac97_codec.c:836:7 [ 19.668268] shift exponent 68 is too large for 32-bit type 'int' [ 19.668465] CPU: 0 PID: 199 Comm: alsactl Not tainted 4.20.0-rc3-00145-gedeca3a769ad #2 [ 19.668602] Hardware name: Elitegroup Co. 532/532, BIOS 080010 02/22/2005 [ 19.668602] Call Trace: [ 19.668602] dump_stack+0x16/0x19 [ 19.668602] ubsan_epilogue+0xb/0x29 [ 19.668602] __ubsan_handle_shift_out_of_bounds.cold.15+0x26/0x78 [ 19.668602] snd_ac97_put_spsa.cold.50+0xf/0x24 [snd_ac97_codec] [ 19.668602] ? _copy_from_user+0x33/0xd0 [ 19.668602] snd_ctl_ioctl+0x69e/0x820 [ 19.668602] ? __seccomp_filter+0x60/0x320 [ 19.668602] ? snd_ctl_elem_add_user+0x8a0/0x8a0 [ 19.668602] do_vfs_ioctl+0x90/0x6c0 [ 19.668602] ? __switch_to_asm+0x26/0x4c [ 19.668602] ? __switch_to_asm+0x32/0x4c [ 19.668602] ? __switch_to_asm+0x26/0x4c [ 19.668602] ? __switch_to_asm+0x32/0x4c [ 19.668602] ? __switch_to_asm+0x26/0x4c [ 19.668602] ? __switch_to_asm+0x32/0x4c [ 19.668602] ? __switch_to_asm+0x26/0x4c [ 19.668602] ? __switch_to_asm+0x32/0x4c [ 19.668602] ? __switch_to_asm+0x26/0x4c [ 19.668602] ? __switch_to_asm+0x26/0x4c [ 19.668602] ? __secure_computing+0x2b/0x80 [ 19.668602] ? syscall_trace_enter+0x141/0x1b0 [ 19.668602] ? __switch_to_asm+0x26/0x4c [ 19.668602] ksys_ioctl+0x39/0x70 [ 19.668602] sys_ioctl+0x11/0x13 [ 19.668602] do_fast_syscall_32+0x90/0x1c0 [ 19.668602] entry_SYSENTER_32+0x6b/0xbd [ 19.668602] EIP: 0xb7fd69ad [ 19.668602] Code: 54 cd ff ff 85 d2 8b 98 58 cd ff ff 89 c8 74 02 89 0a 5b 5d c3 8b 04 24 c3 8b 14 24 c3 8b 3c 24 c3 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d 76 00 58 b8 77 00 00 00 cd 80 90 8d 76 [ 19.668602] EAX: ffffffda EBX: 00000003 ECX: c2c45513 EDX: bffff670 [ 19.668602] ESI: 00000000 EDI: 00000001 EBP: bffff9c8 ESP: bffff508 [ 19.668602] DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b EFLAGS: 00000292 [ 19.668602] ================================================================================ -- Meelis Roos <mroos(a)linux.ee>

2 3

[alsa-devel] [PATCH] ALSA: hda/realtek - fix headset mic detection for MSI MS-B171
by Anisse Astier 23 Nov '18

23 Nov '18

MSI Cubi N 8GL (MS-B171) needs the same fixup as its older model, the MS-B120, in order for the headset mic to be properly detected. They both use a single 3-way jack for both mic and headset with an ALC283 codec, with the same pins used. Cc: stable(a)vger.kernel.org Signed-off-by: Anisse Astier <anisse(a)astier.eu> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index fa61674a5605..1e789e43a5f4 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6531,6 +6531,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x144d, 0xc740, "Samsung Ativ book 8 (NP870Z5G)", ALC269_FIXUP_ATIV_BOOK_8), SND_PCI_QUIRK(0x1458, 0xfa53, "Gigabyte BXBT-2807", ALC283_FIXUP_HEADSET_MIC), SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC), + SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC), SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS), SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE), SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE), -- 2.11.0

2 1

[alsa-devel] [PATCH] ALSA: hda: Add ASRock N68C-S UCC the power_save blacklist
by Hans de Goede 23 Nov '18

23 Nov '18

Power-saving is causing plops on audio start/stop on the built-in audio of the nForce 430 based ASRock N68C-S UCC motherboard, add this model to the power_save blacklist. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1525104 Cc: <stable(a)vger.kernel.org> Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- sound/pci/hda/hda_intel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index d8eb2b5f51ae..0bbdf1a01e76 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2169,6 +2169,8 @@ static struct snd_pci_quirk power_save_blacklist[] = { /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ SND_PCI_QUIRK(0x1849, 0xc892, "Asrock B85M-ITX", 0), /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ + SND_PCI_QUIRK(0x1849, 0x0397, "Asrock N68C-S UCC", 0), + /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ SND_PCI_QUIRK(0x1849, 0x7662, "Asrock H81M-HDS", 0), /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0), -- 2.19.1

2 1