November 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] ALC300 enable
by Kailang 27 Nov '18

27 Nov '18

Hi Takashi, Attach patch will enable new codec ALC300. Thanks. BR, Kailang

2 1

[alsa-devel] [PATCH] ALSA: hda/realtek - Add disable auto-mute quirk for HP Spectre x360 laptop
by Girija Kumar Kasinadhuni 27 Nov '18

27 Nov '18

This device makes a loud buzzing sound when a headphone is inserted while playing audio at full volume through the speaker. Signed-off-by: Girija Kumar Kasinadhuni <gkumar(a)neverware.com> --- sound/pci/hda/patch_realtek.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index fa61674..eeff2ff 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5495,6 +5495,7 @@ enum { ALC255_FIXUP_DELL_HEADSET_MIC, ALC295_FIXUP_HP_X360, ALC221_FIXUP_HP_HEADSET_MIC, + ALC295_FIXUP_HP_DISABLE_AUTOMUTE, }; static const struct hda_fixup alc269_fixups[] = { @@ -6362,6 +6363,10 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HEADSET_MIC }, + [ALC295_FIXUP_HP_DISABLE_AUTOMUTE] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc_fixup_auto_mute_via_amp, + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -6486,6 +6491,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x82bf, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x82c0, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre x360", ALC269_FIXUP_HP_MUTE_LED_MIC3), + SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre X360 ", ALC295_FIXUP_HP_DISABLE_AUTOMUTE), SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300), SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), -- 2.7.4

2 5

Re: [alsa-devel] CS8409 Macbook Pro 2016 2017
by Takashi Iwai 27 Nov '18

27 Nov '18

Please don't drop Cc to ML. Also avoid top-posting. On Sat, 04 Aug 2018 19:02:53 +0200, David Ulricht wrote: > > How can I do that ? > I tried verifying if /proc/asound/card0/codec#0 changes when i put > handphone jack in and out with "diff ver1 ver2" and it is exactly the same. Just do for each bit as you tried for GPIO output. In this case, the direction bit should be different (set 0), and you need to read. > > One strange thing I note is hda-jack-retask.fw contains: > [pincfg] > 0x24 0x90100080 > 0x25 0x90100082 > I have 0x90100080 for 0x24 but in /proc/asound/card0/codec#0 : > Node 0x24 [Pin Complex] wcaps 0x400101: Stereo > Pincap 0x00000010: OUT > Pin Default 0x90100110: [Fixed] Speaker at Int N/A > Conn = Unknown, Color = Unknown > DefAssociation = 0x1, Sequence = 0x0 > Misc = NO_PRESENCE > Pin-ctls: 0x40: OUT > Connection: 1 > 0x02 > > Shouldn't "Pin Default 0x90100110" be 0x90100080 after applying the patch ? No, the codec config value itself won't change, the driver uses the given value only internally. Takashi > I can see that Applying patch firmware 'hda-jack-retask.fw' is before > hdaudioC0D0: autoconfig for Generic: line_outs=2 (0x24/0x25/0x0/0x0/0x0) > type:speaker > in dmesg and this worries me, maybe the pins are overriden by generic > cirrus logic ? > > > On Sat, Aug 4, 2018 at 7:26 PM, Takashi Iwai <tiwai(a)suse.de> wrote: > > > On Sat, 04 Aug 2018 17:44:59 +0200, > > David Ulricht wrote: > > > > > > I used the following script running as root to verify the 8 GPIOs while > > > playing long youtube video, > > > I have running pulseaudio meanwhile and not restarting it, i think its > > okay > > > like that people on the ubuntu forums say that after using > > > hda-verb and setting a gpio active immediately sound appears, so i guess > > > there is no need to restart pulseaudio. > > > I have done the same test with headphones in. > > > No sound in both scenarios, no input no output detected (i'm watching > > > pavucontrol for input detection). > > > > This codec is fairly unique and doesn't provide the standard jack > > detection on each pin. Maybe it's via either GPIO or any other > > method. You can try to read GPIO pins (set as input) to see whether > > any of them corresponds to the jack detection, for example. > > > > > > Takashi > > > > > > > > #!/usr/bin/env python3 > > > import os,time > > > for x in range(0,256): > > > mhex=("0x%0.2X" % x) > > > os.system("hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_MASK "+mhex) > > > os.system("hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DIRECTION "+mhex) > > > os.system("hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DATA "+mhex) > > > time.sleep(3) > > > > > > Meanwhile script is running I'm watching /proc/asound/card0/codec#0 and > > > IO[0-7] changes its configuration, > > > in comparison Joel Krahemann in his scripts is changing the hex right > > after > > > /dev/snd/hwC0D0 (0x01) e.g. i dont think he is modifiying the GPIOs > > > correctly. > > > > > > I found the following post: > > > https://forum.manjaro.org/t/sound-not-working-on-a-2017- > > imac-27-5k-retina/43638 > > > According to https://bugzilla.kernel.org/show_bug.cgi?id=195671 iMac27 > > has > > > a similar soundcard. > > > How can i setup with command line or any other utility: > > > """select “off” in the top menu that propose to setup the Digital > > > Surround""" > > > this is some setting in xfce4-mixer package which is not available for > > > ubuntu since 2 LTS versions behind. I tried current Manjaro and couldn't > > > find this setting in audio mixer of xfce4 either. > > > > > > On Sat, Aug 4, 2018 at 9:48 AM, Takashi Iwai <tiwai(a)suse.de> wrote: > > > > > > > On Sat, 04 Aug 2018 04:07:43 +0200, > > > > David Ulricht wrote: > > > > > > > > > > Hello, > > > > > > > > > > Macbook pro models containing CS8409 for sure are: > > > > > MBP131 MBP141.I own MBP 14,1 e.g. 2017 model. > > > > > > > > > > I'm attaching working sound configuration from Windows 10 registry > > (note > > > > > that the cs420x might need to be ignored or might be important i > > don't > > > > > really know). I believe what is really used is in the > > PinConfigOverride > > > > > section. > > > > > > > > Comparing between BIOS default (init_pin_cfg in alsa-info.sh output) > > > > and your override (user_pin_cfg), there aren't so many changes. > > > > All changes are pretty minor, and I guess it won't influence on the > > > > driver behavior. > > > > > > > > > Interesting thing to note is that sound in MacOS is much louder than > > > > > Bootcamp Windows, would be nice to hear how loud is on linux. > > > > > > > > This is possibly with some vendor-specific GPIO or COEF verbs. > > > > Or it's some direct I2C control. The INI file mentions it. > > > > And that's above HD-audio driver's responsibility. > > > > > > > > > I did convert PinConfigOverride HEX strings to [pincfg] format in the > > > > > attached hda-jack-retask.fw thanks to Takashi's guidance. > > > > > > > > > > I'm attaching also alsamixer ASCII. Only PCM, no Master ? > > > > > > > > It's because the codec chip has no output amplifier at all. > > > > So there can be neither output volume nor mute control on this chip. > > > > > > > > > What I have tried is execute: > > > > > hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_MASK 0x@@ > > > > > hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DIRECTION 0x@@ > > > > > hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DATA 0x@@ > > > > > putting @@ from 0x00 to 0x50 > > > > > > > > There are eight GPIOs, so you'd need to test each bit, i.e. 0x01, > > > > 0x02, 0x04, 0x08, ... 0x80. > > > > > > > > And how is the current situation? You can't play *and* record > > > > anything from any inputs / outputs? > > > > > > > > > > > > Takashi > > > > > > > [2 <text/html; UTF-8 (quoted-printable)>] > > > > > > [2 <text/html; UTF-8 (quoted-printable)>] >

3 12

[alsa-devel] [alsa-lib][PATCH 1/2] conf/ucm: Add a UCM profile for Dell WD19 Dock USB-audio
by Hui Wang 27 Nov '18

27 Nov '18

USB-audio device on Dell WD19 docking station provides two individual output PCM streams, one for headphone Jack and another for speaker out Jack. A UCM profile gives the proper roles for these. Signed-off-by: Hui Wang <hui.wang(a)canonical.com> --- .../ucm/Dell-WD19-Dock/Dell-WD19-Dock.conf | 5 ++++ src/conf/ucm/Dell-WD19-Dock/HiFi.conf | 26 +++++++++++++++++++ src/conf/ucm/Dell-WD19-Dock/Makefile.am | 4 +++ 3 files changed, 35 insertions(+) create mode 100644 src/conf/ucm/Dell-WD19-Dock/Dell-WD19-Dock.conf create mode 100644 src/conf/ucm/Dell-WD19-Dock/HiFi.conf create mode 100644 src/conf/ucm/Dell-WD19-Dock/Makefile.am diff --git a/src/conf/ucm/Dell-WD19-Dock/Dell-WD19-Dock.conf b/src/conf/ucm/Dell-WD19-Dock/Dell-WD19-Dock.conf new file mode 100644 index 00000000..465ff550 --- /dev/null +++ b/src/conf/ucm/Dell-WD19-Dock/Dell-WD19-Dock.conf @@ -0,0 +1,5 @@ +Comment "USB-audio on Dell WD19 docking station" +SectionUseCase."HiFi" { + File "HiFi.conf" + Comment "Default" +} diff --git a/src/conf/ucm/Dell-WD19-Dock/HiFi.conf b/src/conf/ucm/Dell-WD19-Dock/HiFi.conf new file mode 100644 index 00000000..e1427a79 --- /dev/null +++ b/src/conf/ucm/Dell-WD19-Dock/HiFi.conf @@ -0,0 +1,26 @@ +SectionDevice."Headphone" { + Comment "Headphone" + + Value { + PlaybackChannels "2" + PlaybackPCM "hw:Dock,0" + } +} + +SectionDevice."Speaker" { + Comment "Speaker" + + Value { + PlaybackChannels "2" + PlaybackPCM "hw:Dock,1" + } +} + +SectionDevice."Mic" { + Comment "Microphone" + + Value { + CaptureChannels "2" + CapturePCM "hw:Dock,0" + } +} diff --git a/src/conf/ucm/Dell-WD19-Dock/Makefile.am b/src/conf/ucm/Dell-WD19-Dock/Makefile.am new file mode 100644 index 00000000..6549ae1b --- /dev/null +++ b/src/conf/ucm/Dell-WD19-Dock/Makefile.am @@ -0,0 +1,4 @@ +alsaconfigdir = @ALSA_CONFIG_DIR@ +ucmdir = $(alsaconfigdir)/ucm/Dell-WD19-Dock +ucm_DATA = Dell-WD19-Dock.conf HiFi.conf +EXTRA_DIST = $(ucm_DATA) -- 2.17.1

1 1

[alsa-devel] [PATCH v7 3/3] ALSA: hda: add support for Huawei WMI micmute LED
by Ayman Bagabas 27 Nov '18

27 Nov '18

Some of Huawei laptops come with a LED in the micmute key. This patch enables the use of micmute LED for these devices: 1. Matebook X (19e5:3200), (19e5:3201) 2. Matebook X Pro (19e5:3204) Signed-off-by: Ayman Bagabas <ayman.bagabas(a)gmail.com> --- sound/pci/hda/patch_realtek.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 1326f32f4574..9766fd249bdf 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5776,7 +5776,9 @@ static const struct hda_fixup alc269_fixups[] = { {0x1e, 0x411111f0}, {0x21, 0x04211020}, { } - } + }, + .chained = true, + .chain_id = ALC255_FIXUP_MIC_MUTE_LED }, [ALC269_FIXUP_ASUS_X101_FUNC] = { .type = HDA_FIXUP_FUNC, @@ -6608,6 +6610,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K), SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD), + SND_PCI_QUIRK(0x19e5, 0x3200, "Huawei MBX", ALC255_FIXUP_MIC_MUTE_LED), + SND_PCI_QUIRK(0x19e5, 0x3201, "Huawei MBX", ALC255_FIXUP_MIC_MUTE_LED), SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", ALC256_FIXUP_HUAWEI_MBXP_PINS), SND_PCI_QUIRK(0x1b7d, 0xa831, "Ordissimo EVE2 ", ALC269VB_FIXUP_ORDISSIMO_EVE2), /* Also known as Malata PC-B1303 */ -- 2.19.1

1 0

[alsa-devel] [PATCH v7 1/3] ALSA: hda: fix front speakers on Huawei MBXP.
by Ayman Bagabas 27 Nov '18

27 Nov '18

This patch solves bug 200501 'Only 2 of 4 speakers playing sound.' https://bugzilla.kernel.org/show_bug.cgi?id=200501 It enables the front speakers on Huawei Matebook X Pro laptops. These laptops come with Dolby Atmos sound system and these pins configuration enables the front speakers. Signed-off-by: Ayman Bagabas <ayman.bagabas(a)gmail.com> Reviewed-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/patch_realtek.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 993d34c141c2..1326f32f4574 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5490,6 +5490,7 @@ enum { ALC298_FIXUP_TPT470_DOCK, ALC255_FIXUP_DUMMY_LINEOUT_VERB, ALC255_FIXUP_DELL_HEADSET_MIC, + ALC256_FIXUP_HUAWEI_MBXP_PINS, ALC295_FIXUP_HP_X360, ALC221_FIXUP_HP_HEADSET_MIC, }; @@ -5761,6 +5762,22 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HEADSET_MIC }, + [ALC256_FIXUP_HUAWEI_MBXP_PINS] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + {0x12, 0x90a60130}, + {0x13, 0x40000000}, + {0x14, 0x90170110}, + {0x18, 0x411111f0}, + {0x19, 0x04a11040}, + {0x1a, 0x411111f0}, + {0x1b, 0x90170112}, + {0x1d, 0x40759a05}, + {0x1e, 0x411111f0}, + {0x21, 0x04211020}, + { } + } + }, [ALC269_FIXUP_ASUS_X101_FUNC] = { .type = HDA_FIXUP_FUNC, .v.func = alc269_fixup_x101_headset_mic, @@ -6591,6 +6608,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K), SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD), + SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", ALC256_FIXUP_HUAWEI_MBXP_PINS), SND_PCI_QUIRK(0x1b7d, 0xa831, "Ordissimo EVE2 ", ALC269VB_FIXUP_ORDISSIMO_EVE2), /* Also known as Malata PC-B1303 */ #if 0 -- 2.19.1

1 0

[alsa-devel] [PATCH v9 0/8] Add support for audiocodec in Allwinner A64
by Chen-Yu Tsai 26 Nov '18

26 Nov '18

Hi everyone, This is v9 of the A64 audio codec series, originally started by Vasily. These are the last changes to make the A64 audio codec work correctly, and be accurately represented in the device tree and in software. Notably, the new driver changes cover regulator supplies for the simple audio amplifier, which is used in the Pinebook for the internal speakers, and the audio codec's internal headphone amp. There's also an extra patch that enables SDM fractional clock support for the audio PLL on the A64, which gives us accurate audio playback. Patch 1 & 2 add the cpvdd regulator supply to the sun50i-codec-analog dt bindings & driver. Patch 3 & 4 add a regulator supply to the simple-audio-amplifier dt bindings & driver. Patch 5 adds SDM fractional clock support for the audio PLL on the A64. Patch 6 ~ 8 add the device tree bits and enables audio on several boards. I have one extra patch for the Bananapi M64 that's not included here, as I'm waiting for an accessory to test the microphone bias. I'll send that one out once it's tested. As always, we'll take the clock and dts patches after Mark has merged the ASoC ones. And a big thanks to Vasily for having worked on this for so long. Regards ChenYu v9: - Dropped simple amplifier headphone amp device tree changes - Dropped "make enable-gpio optional for simple amplifier" - Lowered oversampling rate from 512 to 128 - Add regulator supply for audio codec CPVDD (headphone amp charge pump) - Hook up CPVDD regulator in board device trees - Add patch to enable SDM fractional clock support for audio PLL on A64 v8: - drop merged patches - add regulator property for simple amplifier, make enable-gpio optional - add regulator to speaker amp, introduce headphone amp v7: - drop 'Mic' and 'Headset Mic' from dtsi - move AIF1 Slot 0 ADC to ADC route to sun8i-codec - drop BIAS routes for Pine64 and SoPine v6: - driver patches has been merged through ASoC tree - rebase onto 4.20-rc1 - Drop 'Speaker' from routes on sopine and pine64, they don't have speaker. v5: - collect all the tags v4: - dts: don't use 'Mic' and 'Headset Mic' widgets from sun8i-codec, define our board-level widgets instead. v3: - renamed sunxi-adda-pr-regmap to sun8i-adda-pr-regmap - use ilog2() to calculate reg value for LRCK div instead of using a table v2: - Use simple-amplifier for speaker amp on Pinebook - Rename sun50i-a64-i2s to sun50i-a64-codec-i2s to preserve compatible string for other 3 I2S modules in A64 in case if there's any incompatibility with H3 Chen-Yu Tsai (3): ASoC: dt-bindings: sun50i-codec-analog: Add headphone amp regulator supply ASoC: sunxi: sun50i-codec-analog: Add support for cpvdd regulator supply clk: sunxi-ng: sun50i: a64: Use sigma-delta modulation for audio PLL Vasily Khoruzhick (5): ASoC: dt-bindings: add regulator property to simple amplifier ASoC: simple-amplifier: add VCC regulator widget arm64: dts: allwinner: a64: add nodes necessary for analog sound support arm64: dts: allwinner: a64: enable sound on Pine64 and SoPine arm64: dts: allwinner: a64: enable sound on Pinebook .../bindings/sound/simple-amplifier.txt | 5 ++ .../bindings/sound/sun50i-codec-analog.txt | 2 + .../boot/dts/allwinner/sun50i-a64-pine64.dts | 27 ++++++++++ .../dts/allwinner/sun50i-a64-pinebook.dts | 49 +++++++++++++++++ .../allwinner/sun50i-a64-sopine-baseboard.dts | 26 +++++++++ .../boot/dts/allwinner/sun50i-a64-sopine.dtsi | 4 ++ arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 54 +++++++++++++++++++ drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 37 ++++++++----- sound/soc/codecs/simple-amplifier.c | 4 ++ sound/soc/sunxi/sun50i-codec-analog.c | 2 + 10 files changed, 197 insertions(+), 13 deletions(-) -- 2.19.1

5 20

[alsa-devel] [PATCH] ASoC: amd: Fix a NULL vs IS_ERR() check in probe
by Dan Carpenter 26 Nov '18

26 Nov '18

The platform_device_register_full() function doesn't return NULL, it returns error pointers. Fixes: 7894a7e7ea3d ("ASoC: amd: create ACP3x PCM platform device") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- sound/soc/amd/raven/pci-acp3x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/amd/raven/pci-acp3x.c b/sound/soc/amd/raven/pci-acp3x.c index c28457fd9b81..facec2472b34 100644 --- a/sound/soc/amd/raven/pci-acp3x.c +++ b/sound/soc/amd/raven/pci-acp3x.c @@ -97,10 +97,10 @@ static int snd_acp3x_probe(struct pci_dev *pci, pdevinfo.size_data = sizeof(irqflags); adata->pdev = platform_device_register_full(&pdevinfo); - if (!adata->pdev) { + if (IS_ERR(adata->pdev)) { dev_err(&pci->dev, "cannot register %s device\n", pdevinfo.name); - ret = -ENODEV; + ret = PTR_ERR(adata->pdev); goto unmap_mmio; } break; -- 2.11.0

2 1

[alsa-devel] [PATCH] ASoC: rsnd: tidyup for SSIU subnode
by Kuninori Morimoto 26 Nov '18

26 Nov '18

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> commit da48a6eb82ea2 ("ASoC: rsnd: add SSIU BUSIF support for Document") updated Documentation for SSIU, but 1) we want to keep old/deprecated DMA description, 2) it is missing SSIU subnode properties. This patch tidyup these Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- Documentation/devicetree/bindings/sound/renesas,rsnd.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt index 47dc819..4d19d2b 100644 --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt @@ -327,8 +327,13 @@ SSI subnode properties: - no-busif : BUSIF is not ussed when [mem -> SSI] via DMA case - dma : Should contain Audio DMAC entry - dma-names : SSI case "rx" (=playback), "tx" (=capture) + Deprecated: see SSIU subnode properties SSIU case "rxu" (=playback), "txu" (=capture) +SSIU subnode properties: +- dma : Should contain Audio DMAC entry +- dma-names : "rx" (=playback), "tx" (=capture) + SRC subnode properties: - dma : Should contain Audio DMAC entry - dma-names : "rx" (=playback), "tx" (=capture) -- 2.7.4

2 1

[alsa-devel] [PATCH] ASoC: soc.h: makes snd_soc_of_parse_audio_prefix() inline
by Kuninori Morimoto 26 Nov '18

26 Nov '18

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> commit 3b7103562c03c ("ASoC: soc-core: add snd_soc_of_parse_node_prefix()") maked snd_soc_of_parse_audio_prefix() as #define. But it'd be better to make this a static inline rather than a #define. It helps with error messages and type safety. This patch makes it inline. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- include/sound/soc.h | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/include/sound/soc.h b/include/sound/soc.h index 37155f9..8ec1de8 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -1481,9 +1481,15 @@ void snd_soc_of_parse_node_prefix(struct device_node *np, struct snd_soc_codec_conf *codec_conf, struct device_node *of_node, const char *propname); -#define snd_soc_of_parse_audio_prefix(card, conf, node, name) \ - snd_soc_of_parse_node_prefix((card)->dev->of_node, \ - (conf), (node), (name)) +static inline +void snd_soc_of_parse_audio_prefix(struct snd_soc_card *card, + struct snd_soc_codec_conf *codec_conf, + struct device_node *of_node, + const char *propname) +{ + snd_soc_of_parse_node_prefix(card->dev->of_node, + codec_conf, of_node, propname); +} int snd_soc_of_parse_audio_routing(struct snd_soc_card *card, const char *propname); -- 2.7.4

2 1