October 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/5] ALSA: use managed-resource to maintain allocated buffers
by Takashi Sakamoto 04 Oct '18

04 Oct '18

Hi, Linux Device Driver subsystem has a feature of 'devres', which is resource allocator/deallocator synchronously to reference counter of kobject corresponding to device structure. This feature avoid memory leak from programming mistakes. This patchset replaces calls of allocator/deallocator with devres helper functions. There're two types of target device structure; firewire unit device and sound card device. All drivers in ALSA firewire stack use reference counting to serialize timing to release the type of two device, therefore no worries of dereferencing to released memory objects. This patchset is for v4.20 and based on my series of fix patches in 'sound-4.19-rc5' branch. But current 'for-next' branch doesn't include them. So this patchset is rebased to upstream 'master' branch (HEAD=067284726963). I'm OK to take them pending till the '-rc5' is merged. Takashi Sakamoto (5): ALSA: firewire: use managed-resource of fw unit device for private data ALSA: bebob: use managed-resource to maintain data specific to M-Audio FW-1814/ProjectMix I/O ALSA: fireworks: use managed-resource to maintain response buffer ALSA: oxfw: use managed-resource to maintain model-specific data ALSA: oxfw: use managed-resource to maintain cache of stream formats sound/firewire/bebob/bebob.c | 17 ++++++----------- sound/firewire/bebob/bebob_maudio.c | 5 +++-- sound/firewire/dice/dice.c | 8 +++----- sound/firewire/digi00x/digi00x.c | 9 ++++----- sound/firewire/fireface/ff.c | 10 +++------- sound/firewire/fireworks/fireworks.c | 15 +++++---------- sound/firewire/motu/motu.c | 10 ++++------ sound/firewire/oxfw/oxfw-scs1x.c | 5 +++-- sound/firewire/oxfw/oxfw-spkr.c | 5 +++-- sound/firewire/oxfw/oxfw-stream.c | 13 ++++++++----- sound/firewire/oxfw/oxfw.c | 28 ++++------------------------ sound/firewire/tascam/tascam.c | 10 +++------- 12 files changed, 49 insertions(+), 86 deletions(-) -- 2.17.1

2 6

[alsa-devel] [PATCH] ALSA: hda/realtek - Cannot adjust speaker's volume on Dell XPS 27 7760
by Kai-Heng Feng 04 Oct '18

04 Oct '18

The issue is the same as commit dd9aa335c880 ("ALSA: hda/realtek - Can't adjust speaker's volume on a Dell AIO"), the output requires to connect to a node with Amp-out capability. Applying the same fixup ALC298_FIXUP_SPK_VOLUME can fix the issue. BugLink: https://bugs.launchpad.net/bugs/1775068 Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 6f3c8e888c2a..69283633ae91 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6409,6 +6409,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x0706, "Dell Inspiron 7559", ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER), SND_PCI_QUIRK(0x1028, 0x0725, "Dell Inspiron 3162", ALC255_FIXUP_DELL_SPK_NOISE), SND_PCI_QUIRK(0x1028, 0x075b, "Dell XPS 13 9360", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE), + SND_PCI_QUIRK(0x1028, 0x075c, "Dell XPS 27 7760", ALC298_FIXUP_SPK_VOLUME), SND_PCI_QUIRK(0x1028, 0x075d, "Dell AIO", ALC298_FIXUP_SPK_VOLUME), SND_PCI_QUIRK(0x1028, 0x07b0, "Dell Precision 7520", ALC295_FIXUP_DISABLE_DAC3), SND_PCI_QUIRK(0x1028, 0x0798, "Dell Inspiron 17 7000 Gaming", ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER), -- 2.17.1

2 1

[alsa-devel] [PATCH 0/7] Add devres support to card resources
by Takashi Iwai 04 Oct '18

04 Oct '18

Hi, here is the patchset containing the changes to support a device-managed resource management for ALSA card and memory pages. The actual code changes are identical with the previous RFC series, but a few documentation updates are included in this official set. Takashi === Takashi Iwai (7): ALSA: core: Add device-managed page allocator helper ALSA: core: Add managed card creation ALSA: intel8x0: Allocate resources with device-managed APIs ALSA: atiixp: Allocate resources with device-managed APIs ALSA: hda: Allocate resources with device-managed APIs ALSA: doc: Brush up the old writing-an-alsa-driver ALSA: doc: Add device-managed resource section .../kernel-api/writing-an-alsa-driver.rst | 340 ++++++++++-------- include/sound/core.h | 5 + include/sound/memalloc.h | 4 + sound/core/init.c | 95 ++++- sound/core/memalloc.c | 88 ++++- sound/pci/atiixp.c | 104 ++---- sound/pci/atiixp_modem.c | 104 ++---- sound/pci/hda/hda_controller.h | 1 - sound/pci/hda/hda_intel.c | 43 +-- sound/pci/intel8x0.c | 143 +++----- sound/pci/intel8x0m.c | 143 +++----- 11 files changed, 514 insertions(+), 556 deletions(-) -- 2.18.0

2 19

[alsa-devel] [PATCH linux-next v2 0/9] ASoC: rsnd: support to use different BUSIF for GEN3
by jiada_wang＠mentor.com 04 Oct '18

04 Oct '18

From: Jiada Wang <jiada_wang(a)mentor.com> Rcar audio DMA/SSIU already support to use different BUSIF to transfer data, but BUSIF is fixed at 0. This patchset adds busif property to dai stream, GEN3 series can automatically select BUSIF to transfer data, based on channel and SSI mode (currently only BUSIF0 is selected). Device tree files are updated to use extended audio dmac register, and add dma request number for busif0 ~ busif7 for GEN3. --- v2: - Instead of configure BUSIF by kctl interface "SSI Out/In BUSIF", use rsnd_ssi_select_busif() to automatically select BUSIF. - Keep 'rxu/txu' dma request, to keep compatibility with GEN2 series - Re-order patch-set to satisfy git bisect v1: initial version Jiada Wang (9): arm64: r8a7795: add dma request number for busif0 ~ busif7 arm64: r8a7796: add dma request number for busif0 ~ busif7 arm64: r8a774a1: add dma request number for busif0 ~ busif7 arm64: r8a7795: change to use extended audio dmac register arm64: r8a7796: change to use extended audio dmac register arm64: r8a774a1: change to use extended audio dmac register arm64: r8a77965: change to use extended audio dmac register ASoC: rsnd: ssi: Request dedicated dma channels for busif0 to 7 ASoC: rsnd: add busif property to dai stream arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 166 +++++++++++++++++++--- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 166 +++++++++++++++++++--- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 166 +++++++++++++++++++--- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 +- sound/soc/sh/rcar/core.c | 3 + sound/soc/sh/rcar/dma.c | 31 ++++ sound/soc/sh/rcar/rsnd.h | 3 + sound/soc/sh/rcar/ssi.c | 58 +++++++- 8 files changed, 525 insertions(+), 70 deletions(-) -- 2.17.0

3 6

[alsa-devel] [PATCH linux-next v2 8/9] ASoC: rsnd: ssi: Request dedicated dma channels for busif0 to 7
by jiada_wang＠mentor.com 04 Oct '18

04 Oct '18

From: Jiada Wang <jiada_wang(a)mentor.com> Currently ssi driver only request dma channel for SSI_0, which is used to transfer data to/from busif0. But in GEN3 busif1 to busif7 also maybe used, dedicated dma channels are requested for data transfer through these busif. Signed-off-by: Jiada Wang <jiada_wang(a)mentor.com> --- sound/soc/sh/rcar/ssi.c | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c index 3adcc4f778f7..992aeac09e76 100644 --- a/sound/soc/sh/rcar/ssi.c +++ b/sound/soc/sh/rcar/ssi.c @@ -76,6 +76,8 @@ #define SSI_NAME "ssi" +#define SSI_DMA_NAME_SIZE 10 + struct rsnd_ssi { struct rsnd_mod mod; @@ -938,12 +940,28 @@ static struct dma_chan *rsnd_ssi_dma_req(struct rsnd_dai_stream *io, { struct rsnd_priv *priv = rsnd_mod_to_priv(mod); int is_play = rsnd_io_is_play(io); - char *name; + char name[SSI_DMA_NAME_SIZE]; - if (rsnd_ssi_use_busif(io)) - name = is_play ? "rxu" : "txu"; - else - name = is_play ? "rx" : "tx"; + if (rsnd_ssi_use_busif(io)) { + if (is_play) + snprintf(name, SSI_DMA_NAME_SIZE, "rxu"); + else + snprintf(name, SSI_DMA_NAME_SIZE, "txu"); + + if (rsnd_is_gen3(priv)) { + /* + * Gen3 supports to use all available BUSIF + */ + int busif = rsnd_ssi_get_busif(io); + + snprintf(name, SSI_DMA_NAME_SIZE, "%s%d", name, busif); + } + } else { + if (is_play) + snprintf(name, SSI_DMA_NAME_SIZE, "rx"); + else + snprintf(name, SSI_DMA_NAME_SIZE, "tx"); + } return rsnd_dma_request_channel(rsnd_ssi_of_node(priv), mod, name); -- 2.17.0

3 2

[alsa-devel] [PATCH] ALSA: intel8x0: Fix fall-through annotations
by Gustavo A. R. Silva 03 Oct '18

03 Oct '18

Replace "fallthru" with a proper "fall through" annotation. This fix is part of the ongoing efforts to enabling -Wimplicit-fallthrough Signed-off-by: Gustavo A. R. Silva <gustavo(a)embeddedor.com> --- sound/pci/intel8x0.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c index 9517f9b..ffddcdf 100644 --- a/sound/pci/intel8x0.c +++ b/sound/pci/intel8x0.c @@ -825,7 +825,7 @@ static int snd_intel8x0_pcm_trigger(struct snd_pcm_substream *substream, int cmd switch (cmd) { case SNDRV_PCM_TRIGGER_RESUME: ichdev->suspended = 0; - /* fallthru */ + /* fall through */ case SNDRV_PCM_TRIGGER_START: case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: val = ICH_IOCE | ICH_STARTBM; @@ -833,7 +833,7 @@ static int snd_intel8x0_pcm_trigger(struct snd_pcm_substream *substream, int cmd break; case SNDRV_PCM_TRIGGER_SUSPEND: ichdev->suspended = 1; - /* fallthru */ + /* fall through */ case SNDRV_PCM_TRIGGER_STOP: val = 0; break; @@ -867,7 +867,7 @@ static int snd_intel8x0_ali_trigger(struct snd_pcm_substream *substream, int cmd switch (cmd) { case SNDRV_PCM_TRIGGER_RESUME: ichdev->suspended = 0; - /* fallthru */ + /* fall through */ case SNDRV_PCM_TRIGGER_START: case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { @@ -884,7 +884,7 @@ static int snd_intel8x0_ali_trigger(struct snd_pcm_substream *substream, int cmd break; case SNDRV_PCM_TRIGGER_SUSPEND: ichdev->suspended = 1; - /* fallthru */ + /* fall through */ case SNDRV_PCM_TRIGGER_STOP: case SNDRV_PCM_TRIGGER_PAUSE_PUSH: /* pause */ -- 2.7.4

2 5

[alsa-devel] [PATCH linux-next v2 7/9] arm64: r8a77965: change to use extended audio dmac register
by jiada_wang＠mentor.com 03 Oct '18

03 Oct '18

From: Jiada Wang <jiada_wang(a)mentor.com> Basic audio dmac register only supports busif from 0 to 3, in order to use busif4 ~ busif7, extended audio dmac register need to be used. Signed-off-by: Jiada Wang <jiada_wang(a)mentor.com> --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index fd00010a5ed7..6c0d5053a81c 100644 --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi @@ -1405,7 +1405,7 @@ <0 0xec5a0000 0 0x100>, /* ADG */ <0 0xec540000 0 0x1000>, /* SSIU */ <0 0xec541000 0 0x280>, /* SSI */ - <0 0xec740000 0 0x200>; /* Audio DMAC peri peri*/ + <0 0xec760000 0 0x200>; /* Audio DMAC peri peri*/ /* placeholder */ rcar_sound,dvc { -- 2.17.0

1 0

[alsa-devel] [PATCH linux-next v2 6/9] arm64: r8a774a1: change to use extended audio dmac register
by jiada_wang＠mentor.com 03 Oct '18

03 Oct '18

From: Jiada Wang <jiada_wang(a)mentor.com> Basic audio dmac register only supports busif from 0 to 3, in order to use busif4 ~ busif7, extended audio dmac register need to be used. Signed-off-by: Jiada Wang <jiada_wang(a)mentor.com> --- arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi index ad2c9c0148ae..c04ca03f2987 100644 --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi @@ -1120,7 +1120,7 @@ <0 0xec5a0000 0 0x100>, /* ADG */ <0 0xec540000 0 0x1000>, /* SSIU */ <0 0xec541000 0 0x280>, /* SSI */ - <0 0xec740000 0 0x200>; /* Audio DMAC peri peri*/ + <0 0xec760000 0 0x200>; /* Audio DMAC peri peri*/ reg-names = "scu", "adg", "ssiu", "ssi", "audmapp"; clocks = <&cpg CPG_MOD 1005>, -- 2.17.0

1 0

[alsa-devel] [PATCH linux-next v2 5/9] arm64: r8a7796: change to use extended audio dmac register
by jiada_wang＠mentor.com 03 Oct '18

03 Oct '18

From: Jiada Wang <jiada_wang(a)mentor.com> Basic audio dmac register only supports busif from 0 to 3, in order to use busif4 ~ busif7, extended audio dmac register need to be used. Signed-off-by: Jiada Wang <jiada_wang(a)mentor.com> --- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index 53b361c5b16d..4526f62ee1f0 100644 --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi @@ -1670,7 +1670,7 @@ <0 0xec5a0000 0 0x100>, /* ADG */ <0 0xec540000 0 0x1000>, /* SSIU */ <0 0xec541000 0 0x280>, /* SSI */ - <0 0xec740000 0 0x200>; /* Audio DMAC peri peri*/ + <0 0xec760000 0 0x200>; /* Audio DMAC peri peri*/ reg-names = "scu", "adg", "ssiu", "ssi", "audmapp"; clocks = <&cpg CPG_MOD 1005>, -- 2.17.0

1 0

[alsa-devel] snd_pcm_poll_descriptors() error return
by Alan Horstmann 02 Oct '18

02 Oct '18

Hi, A user of the Portaudio library is reporting that from Alsa version 1.1.4 the function snd_pcm_poll_descriptors() can return -32 (Broken Pipe), and this fails an assert within Portaudio. Earlier 1.1.3 does not seem to show this issue. For more details, see https://app.assembla.com/spaces/portaudio/support/tickets/268. The Alsa docs don't mention any possible negative error code from this function - has the behaviour changed, or is it likely something else is triggering the difference? Regards Alan

3 3