January 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] Applied "IIO: ADC: stm32-dfsdm: avoid unused-variable warning" to the asoc tree
by Mark Brown 11 Jan '18

11 Jan '18

The patch IIO: ADC: stm32-dfsdm: avoid unused-variable warning has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 25140717414c319bcc44b5aac39357a52d0bc8e0 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann <arnd(a)arndb.de> Date: Thu, 11 Jan 2018 11:34:46 +0100 Subject: [PATCH] IIO: ADC: stm32-dfsdm: avoid unused-variable warning Building with CONFIG_OF disabled produces a compiler warning: drivers/iio/adc/stm32-dfsdm-core.c: In function 'stm32_dfsdm_probe': drivers/iio/adc/stm32-dfsdm-core.c:245:22: error: unused variable 'pnode' [-Werror=unused-variable] This removes the variable and open-codes it in the only place it gets used to avoid that warning. Fixes: bed73904e76f ("IIO: ADC: add stm32 DFSDM core support") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- drivers/iio/adc/stm32-dfsdm-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c index 72427414db7f..6cd655f8239b 100644 --- a/drivers/iio/adc/stm32-dfsdm-core.c +++ b/drivers/iio/adc/stm32-dfsdm-core.c @@ -242,7 +242,6 @@ MODULE_DEVICE_TABLE(of, stm32_dfsdm_of_match); static int stm32_dfsdm_probe(struct platform_device *pdev) { struct dfsdm_priv *priv; - struct device_node *pnode = pdev->dev.of_node; const struct of_device_id *of_id; const struct stm32_dfsdm_dev_data *dev_data; struct stm32_dfsdm *dfsdm; @@ -254,7 +253,7 @@ static int stm32_dfsdm_probe(struct platform_device *pdev) priv->pdev = pdev; - of_id = of_match_node(stm32_dfsdm_of_match, pnode); + of_id = of_match_node(stm32_dfsdm_of_match, pdev->dev.of_node); if (!of_id->data) { dev_err(&pdev->dev, "Data associated to device is missing\n"); return -EINVAL; -- 2.15.1

1 0

[alsa-devel] Applied "IIO: ADC: fix return value check in stm32_dfsdm_adc_probe()" to the asoc tree
by Mark Brown 11 Jan '18

11 Jan '18

The patch IIO: ADC: fix return value check in stm32_dfsdm_adc_probe() has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From d5ff18bcd4b5e66396eab7e8271172157ee1253e Mon Sep 17 00:00:00 2001 From: Wei Yongjun <weiyongjun1(a)huawei.com> Date: Thu, 11 Jan 2018 11:12:41 +0000 Subject: [PATCH] IIO: ADC: fix return value check in stm32_dfsdm_adc_probe() In case of error, the function devm_iio_device_alloc() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: e2e6771c6462 ("IIO: ADC: add STM32 DFSDM sigma delta ADC support") Signed-off-by: Wei Yongjun <weiyongjun1(a)huawei.com> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- drivers/iio/adc/stm32-dfsdm-adc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c index e628d04d5c77..5e871404f565 100644 --- a/drivers/iio/adc/stm32-dfsdm-adc.c +++ b/drivers/iio/adc/stm32-dfsdm-adc.c @@ -1100,9 +1100,9 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev) dev_data = (const struct stm32_dfsdm_dev_data *)of_id->data; iio = devm_iio_device_alloc(dev, sizeof(*adc)); - if (IS_ERR(iio)) { + if (!iio) { dev_err(dev, "%s: Failed to allocate IIO\n", __func__); - return PTR_ERR(iio); + return -ENOMEM; } adc = iio_priv(iio); -- 2.15.1

1 0

[alsa-devel] [PATCH] ASoC: stm32: select IIO_BUFFER
by Arnd Bergmann 11 Jan '18

11 Jan '18

The new stm32_adfsdm driver has incomplete dependencies as shown by Kconfig: warning: (SND_SOC_STM32_DFSDM && LMP91000) selects IIO_BUFFER_CB which has unmet direct dependencies (IIO && IIO_BUFFER) sound/soc/stm/stm32_adfsdm.o: In function `stm32_adfsdm_trigger': stm32_adfsdm.c:(.text+0x8c): undefined reference to `stm32_dfsdm_get_buff_cb' stm32_adfsdm.c:(.text+0x9c): undefined reference to `stm32_dfsdm_release_buff_cb' This makes the dependency on SND_SOC_STM32_DFSDM unconditional, so we can always resolve the stm32_dfsdm_get_buff_cb/stm32_dfsdm_release_buff_cb symbols and get the implied IIO_BUFFER dependency. compile-testing on other platforms is still possible as long as that IIO driver is there. Fixes: 55da094824c4 ("ASoC: stm32: add DFSDM DAI support") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- sound/soc/stm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/stm/Kconfig b/sound/soc/stm/Kconfig index a78f7700d489..3ad881fc40a1 100644 --- a/sound/soc/stm/Kconfig +++ b/sound/soc/stm/Kconfig @@ -30,8 +30,9 @@ config SND_SOC_STM32_SPDIFRX config SND_SOC_STM32_DFSDM tristate "SoC Audio support for STM32 DFSDM" - depends on (ARCH_STM32 && OF && STM32_DFSDM_ADC) || COMPILE_TEST + depends on ARCH_STM32 || COMPILE_TEST depends on SND_SOC + depends on STM32_DFSDM_ADC select SND_SOC_GENERIC_DMAENGINE_PCM select SND_SOC_DMIC select IIO_BUFFER_CB -- 2.9.0

2 1

[alsa-devel] WARNING in snd_interval_mulkdiv
by syzbot 11 Jan '18

11 Jan '18

Hello, syzkaller hit the following crash on cf1fb158230edce8a0482bfb2e59b9c390477fb6 git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached. C reproducer is attached syzkaller reproducer is attached. See https://goo.gl/kgGztJ for information about syzkaller reproducers IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+7e6ee55011deeebce15d(a)syzkaller.appspotmail.com It will help syzbot understand when the bug is fixed. See footer for details. If you forward the report, please keep this part and the footer. audit: type=1400 audit(1515606919.914:7): avc: denied { map } for pid=3501 comm="syzkaller879499" path="/root/syzkaller879499069" dev="sda1" ino=16481 scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 tcontext=unconfined_u:object_r:user_home_t:s0 tclass=file permissive=1 WARNING: CPU: 1 PID: 3501 at sound/core/pcm_lib.c:563 muldiv32 sound/core/pcm_lib.c:563 [inline] WARNING: CPU: 1 PID: 3501 at sound/core/pcm_lib.c:563 snd_interval_mulkdiv+0x5a9/0x650 sound/core/pcm_lib.c:756 Kernel panic - not syncing: panic_on_warn set ... CPU: 1 PID: 3501 Comm: syzkaller879499 Not tainted 4.15.0-rc7+ #256 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x194/0x257 lib/dump_stack.c:53 panic+0x1e4/0x41c kernel/panic.c:183 __warn+0x1dc/0x200 kernel/panic.c:547 report_bug+0x211/0x2d0 lib/bug.c:184 fixup_bug.part.11+0x37/0x80 arch/x86/kernel/traps.c:178 fixup_bug arch/x86/kernel/traps.c:247 [inline] do_error_trap+0x2d7/0x3e0 arch/x86/kernel/traps.c:296 do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:315 invalid_op+0x22/0x40 arch/x86/entry/entry_64.S:1079 RIP: 0010:muldiv32 sound/core/pcm_lib.c:563 [inline] RIP: 0010:snd_interval_mulkdiv+0x5a9/0x650 sound/core/pcm_lib.c:756 RSP: 0018:ffff8801c04c7478 EFLAGS: 00010293 RAX: ffff8801c05f43c0 RBX: ffff8801c04c7500 RCX: ffffffff841cb1f9 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 00000000000f4240 RBP: ffff8801c04c74c0 R08: 000000000000009c R09: ffffed00380bc5e3 R10: 0000000000000013 R11: ffffed00380bc5e2 R12: ffff8801c05e2ec0 R13: ffff8801c05e2eb4 R14: ffff8801c05e2ec8 R15: ffff8801c05e2ebc snd_pcm_hw_rule_mulkdiv+0xfd/0x1c0 sound/core/pcm_native.c:2040 constrain_params_by_rules+0x625/0x11b0 sound/core/pcm_native.c:400 snd_pcm_hw_refine+0x818/0x1070 sound/core/pcm_native.c:502 snd_pcm_hw_refine_old_user sound/core/pcm_native.c:3612 [inline] snd_pcm_common_ioctl+0x7f9/0x1f60 sound/core/pcm_native.c:2922 snd_pcm_ioctl+0x81/0xb0 sound/core/pcm_native.c:2959 vfs_ioctl fs/ioctl.c:46 [inline] do_vfs_ioctl+0x1b1/0x1520 fs/ioctl.c:686 SYSC_ioctl fs/ioctl.c:701 [inline] SyS_ioctl+0x8f/0xc0 fs/ioctl.c:692 entry_SYSCALL_64_fastpath+0x23/0x9a RIP: 0033:0x443d79 RSP: 002b:00007ffe547ec708 EFLAGS: 00000286 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: ffffffffffffffff RCX: 0000000000443d79 RDX: 0000000020001f64 RSI: 00000000c1004110 RDI: 0000000000000003 RBP: 00000000006ce018 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000020005000 R11: 0000000000000286 R12: 0000000000401a60 R13: 0000000000401af0 R14: 0000000000000000 R15: 0000000000000000 Dumping ftrace buffer: (ftrace buffer empty) Kernel Offset: disabled Rebooting in 86400 seconds.. --- This bug is generated by a dumb bot. It may contain errors. See https://goo.gl/tpsmEJ for details. Direct all questions to syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. If you forgot to add the Reported-by tag, once the fix for this bug is merged into any tree, please reply to this email with: #syz fix: exact-commit-title If you want to test a patch for this bug, please reply with: #syz test: git://repo/address.git branch and provide the patch inline or as an attachment. To mark this as a duplicate of another syzbot report, please reply with: #syz dup: exact-subject-of-another-report If it's a one-off invalid bug report, please reply with: #syz invalid Note: if the crash happens again, it will cause creation of a new bug report. Note: all commands must start from beginning of the line in the email body.

2 1

[alsa-devel] [PATCH] ASoC: ux500: add MODULE_LICENSE tag
by Arnd Bergmann 10 Jan '18

10 Jan '18

This adds MODULE_LICENSE/AUTHOR/DESCRIPTION tags to the ux500 platform drivers, to avoid these build warnings: WARNING: modpost: missing MODULE_LICENSE() in sound/soc/ux500/snd-soc-ux500-plat-dma.o WARNING: modpost: missing MODULE_LICENSE() in sound/soc/ux500/snd-soc-ux500-mach-mop500.o The company no longer exists, so the email addresses of the authors don't work any more, but I've added them anyway for consistency. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- sound/soc/ux500/mop500.c | 4 ++++ sound/soc/ux500/ux500_pcm.c | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/sound/soc/ux500/mop500.c b/sound/soc/ux500/mop500.c index 070a6880980e..c60a57797640 100644 --- a/sound/soc/ux500/mop500.c +++ b/sound/soc/ux500/mop500.c @@ -163,3 +163,7 @@ static struct platform_driver snd_soc_mop500_driver = { }; module_platform_driver(snd_soc_mop500_driver); + +MODULE_LICENSE("GPL v2"); +MODULE_DESCRIPTION("ASoC MOP500 board driver"); +MODULE_AUTHOR("Ola Lilja"); diff --git a/sound/soc/ux500/ux500_pcm.c b/sound/soc/ux500/ux500_pcm.c index f12c01dddc8d..d35ba7700f46 100644 --- a/sound/soc/ux500/ux500_pcm.c +++ b/sound/soc/ux500/ux500_pcm.c @@ -165,3 +165,8 @@ int ux500_pcm_unregister_platform(struct platform_device *pdev) return 0; } EXPORT_SYMBOL_GPL(ux500_pcm_unregister_platform); + +MODULE_AUTHOR("Ola Lilja"); +MODULE_AUTHOR("Roger Nilsson"); +MODULE_DESCRIPTION("ASoC UX500 driver"); +MODULE_LICENSE("GPL v2"); -- 2.9.0

3 2

[alsa-devel] [PATCH 0/2] ASoC: Remove mfld dead code
by Vinod Koul 10 Jan '18

10 Jan '18

Medfield machine was not compiling for long on mainline. Since no one complained, lets remove the dead code and associated codec. Vinod Koul (2): ASoC: Intel: remove mfld_machine ASoC: sn95031: remove this code sound/soc/codecs/Kconfig | 4 - sound/soc/codecs/Makefile | 1 - sound/soc/codecs/sn95031.c | 936 ---------------------------------- sound/soc/codecs/sn95031.h | 133 ----- sound/soc/intel/boards/Kconfig | 14 - sound/soc/intel/boards/mfld_machine.c | 430 ---------------- 6 files changed, 1518 deletions(-) delete mode 100644 sound/soc/codecs/sn95031.c delete mode 100644 sound/soc/codecs/sn95031.h delete mode 100644 sound/soc/intel/boards/mfld_machine.c -- 2.7.4

4 8

[alsa-devel] [asoc:topic/st-dfsdm 2/2] sound/soc/stm/stm32_adfsdm.c:17:10: fatal error: linux/iio/adc/stm32-dfsdm-adc.h: No such file or directory
by kbuild test robot 10 Jan '18

10 Jan '18

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/st-dfsdm head: 55da094824c4ef1d50bc591733d79448d00265bb commit: 55da094824c4ef1d50bc591733d79448d00265bb [2/2] ASoC: stm32: add DFSDM DAI support config: frv-allmodconfig (attached as .config) compiler: frv-linux-gcc (GCC) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 55da094824c4ef1d50bc591733d79448d00265bb # save the attached .config to linux build tree make.cross ARCH=frv All errors (new ones prefixed by >>): >> sound/soc/stm/stm32_adfsdm.c:17:10: fatal error: linux/iio/adc/stm32-dfsdm-adc.h: No such file or directory #include <linux/iio/adc/stm32-dfsdm-adc.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. vim +17 sound/soc/stm/stm32_adfsdm.c 14 15 #include <linux/iio/iio.h> 16 #include <linux/iio/consumer.h> > 17 #include <linux/iio/adc/stm32-dfsdm-adc.h> 18 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

2 1

Re: [alsa-devel] [PATCH v2] ASoC: sgtl5000: Fix powerup/down of micbias
by Fischer, Christian 10 Jan '18

10 Jan '18

Hello Daniel, I'm sorry, thats my first official patch :-) I've now cloned a kernel outside my buildsystem and (hopefully) a new, acceptable patch. Regards, Christian From d06794d98e3ed84ecb1641b74d093366ffff2cba Mon Sep 17 00:00:00 2001 From: Christian Fischer <fischerc(a)swissphone.de> Date: Wed, 10 Jan 2018 16:47:51 +0100 Subject: [PATCH v2] ASoC: sgtl5000: fix powerup/down of micbias-voltage The mic-bias-voltage should get powered up/down automatically. Added missing DAPM_PRE and DAPM_POST widgets to fire up the mic_bias_event function. Signed-off-by: Christian Fischer <fischerc(a)swissphone.de> --- sound/soc/codecs/sgtl5000.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index f2bb4fe..4973365 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -260,6 +260,9 @@ static const struct snd_soc_dapm_widget sgtl5000_dapm_widgets[] = { SND_SOC_DAPM_PRE("VAG_POWER_PRE", power_vag_event), SND_SOC_DAPM_POST("VAG_POWER_POST", power_vag_event), + + SND_SOC_DAPM_PRE("MIC_BIAS_PRE", mic_bias_event), + SND_SOC_DAPM_POST("MIC_BIAS_POST", mic_bias_event), }; /* routes for sgtl5000 */ -- 2.7.4 -----Ursprüngliche Nachricht----- Von: Daniel Baluta [mailto:daniel.baluta@nxp.com] Gesendet: Mittwoch, 10. Januar 2018 15:31 An: Fischer, Christian <fischerc(a)swissphone.de>; alsa-devel(a)alsa-project.org Cc: lgirdwood(a)gmail.com; broonie(a)kernel.org; tiwai(a)suse.com Betreff: Re: [alsa-devel] [PATCH v2] ASoC: sgtl5000: Fix powerup/down of micbias On Mi, 2018-01-10 at 14:26 +0000, Fischer, Christian wrote: > Hello Fabio, > > is it now ok? > I'm not working with linux-git, so my patch is created by myself. > > Regards, > Christian > > Signed-off-by: Christian Fischer <fischerc(a)swissphone.de> Hi Christian, This doesn't look good to me. How are creating/sending the patches? You should update the commit message to include your Signed-off-by tag and then resend the entire patch. thanks, Daniel. > > --- sound/soc/codecs/sgtl5000.c > +++ sound/soc/codecs/sgtl5000.c > @@ -260,6 +260,9 @@ static const struct snd_soc_dapm_widget > > SND_SOC_DAPM_PRE("VAG_POWER_PRE", power_vag_event), > SND_SOC_DAPM_POST("VAG_POWER_POST", power_vag_event), > + > + SND_SOC_DAPM_PRE("MIC_BIAS_PRE", mic_bias_event), > + SND_SOC_DAPM_POST("MIC_BIAS_POST", mic_bias_event), > }; > > /* routes for sgtl5000 */ > > -----Ursprüngliche Nachricht----- > Von: Fabio Estevam [mailto:festevam@gmail.com] > Gesendet: Mittwoch, 10. Januar 2018 13:42 > An: Fischer, Christian <fischerc(a)swissphone.de> > Cc: alsa-devel(a)alsa-project.org; Takashi Iwai <tiwai(a)suse.com>; Mark > Brown <broonie(a)kernel.org>; Liam Girdwood <lgirdwood(a)gmail.com> > Betreff: Re: [alsa-devel] [PATCH] ASoC: sgtl5000: Fix powerup/down of > micbias > > Hi Christian, > > On Wed, Jan 10, 2018 at 8:07 AM, Fischer, Christian <fischerc(a)swissphone.de> wrote: > > > > The bias-bias-voltage should powered up/down automatically. > > Added missing DAPM_PRE and DAPM_POST widgets to fire up the mic_bias_event function. > Thanks for submitting the patch. > > You missed your Signed-off-by tag. > > Please resend it. > > Thanks > _______________________________________________ > Alsa-devel mailing list > Alsa-devel(a)alsa-project.org > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail > man.alsa-project.org%2Fmailman%2Flistinfo%2Falsa-devel&data=02%7C01%7C > daniel.baluta%40nxp.com%7C4a771694af314fa7d73008d558362a37 > %7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636511912029282885&sdata=Zo42ZJxIxp54YyYLVsFrrRWkDt%2FqByR6uqr8U6pX3iY%3D&reserved=0

2 1

[alsa-devel] [asoc:topic/iio 9/11] drivers/iio/adc/stm32-dfsdm-adc.c:241:6: sparse: symbol 'stm32_dfsdm_stop_filter' was not declared. Should it be static?
by kbuild test robot 10 Jan '18

10 Jan '18

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/iio head: 16cbca06fa8288a4f58426fc898b141e12ee8008 commit: e2e6771c646251657fafb2a78db566d5c2c70635 [9/11] IIO: ADC: add STM32 DFSDM sigma delta ADC support reproduce: # apt-get install sparse git checkout e2e6771c646251657fafb2a78db566d5c2c70635 make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/iio/adc/stm32-dfsdm-adc.c:241:6: sparse: symbol 'stm32_dfsdm_stop_filter' was not declared. Should it be >> drivers/iio/adc/stm32-dfsdm-adc.c:283:5: sparse: symbol 'stm32_dfsdm_channel_parse_of' was not declared. Should it be Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

3 3

[alsa-devel] [-next PATCH 0/4] sysfs and DEVICE_ATTR_<foo>
by Joe Perches 10 Jan '18

10 Jan '18

16 24