January 2018 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] Headphone issues iMac 14.1 (A1418)
by Takashi Iwai 04 Jan '18

04 Jan '18

On Thu, 04 Jan 2018 17:27:55 +0100, Freaky wrote: > > Hi Takashi, > > we need it to get the headphone output working. Upon unplugging / > replugging we need to check them again (they remain checked, but the output > stops working). The speaker output (onboard speakers) works fine and the > script we run doesn't appear to have any effect on the speaker output at > all. The alsa-info.sh output showed that GPIO[1] is also set, so I wonder how and who sets it. In anyway, could you check whether flipping any such gpio bits turn on / off the headphone and the speaker outputs? Try to toggle it while playing back, such as, hda-verb /dev/snd/hwC1D0 0x01 SET_GPIO_DATA xxx where xxx is the value to be written (0x00, 0x02, 0x04, 0x06, etc). > Currently use a python script generated by the HDA Analyzer script that we > run every 5 seconds from boot. Pasted the script below. We run it every 5 > seconds to ensure audio will work after replugging the headphones (although > it might incur a small delay then of course). I don't notice any hick-ups > in audio playback because of the script firing every 5 seconds. > > There's no acpid running from which we could detect the plug event. Using a > system based on Fedora 24. Have watched dbus-monitor (--sytem), but see no > events there upon (un)plugging the headphones which we could use as trigger. The headphone jack detection on HD-audio is usually done via HD-audio codec unsolicited events. You can check "Headphone Jack" ALSA control element (e.g. watch the output of "amixer contents"). Takashi

1 0

[alsa-devel] Headphone issues iMac 14.1 (A1418)
by Freaky 04 Jan '18

04 Jan '18

Hi there, we're having issues enabling the headphone out on an iMac 14.1 (A1418). The parameters snd-hda-intel.model=imac27 or snd-hda-intel.model=imac27_122 do not resolve the problem. Plug detection seems to be working fine, upon plugging the headphone, speaker-out will mute and headphone out will unmute. Unplugging it does the reverse. There's no audio on the headphone out however. We ran the hda analyzer python script and when enabling 'out-dir', 'enable' and 'data' on the GPIO's marked as [2] the audio starts working. If we unplug/plug the headphone then the audio is dead again. Need to uncheck and check them and it will work again. Ran alsa-info.sh, whilst the GPIO's marked as [2] were enabled: http://www.alsa-project.org/db/?f=86db8b16d0118edd1feab9626c68eed4735b943e Would be much obliged if can help with a solution for this. Preferably with a kernel parameter as we run a stateless image that's used on a huge variety of systems. Tried different kernel versions by the way, problem still exists in 4.14.8 at least. Thanks in advance and best wishes for the new year to you all! Kind regards, Ferry

2 1

Re: [alsa-devel] [PATCH 1/6] ASoC: rt5645: change micbias widget type to supply.
by Mark Brown 04 Jan '18

04 Jan '18

On Thu, Jan 04, 2018 at 12:20:06PM +0000, Bard Liao wrote: > > > Yes, it's supply usage for a micbias. So it didn't take effect with > > > MICBIAS widget type. Actually, we don't need to set the micbias > > > power bit for headset mic and we have verified it today. So, I will > > > send a patch to remove them soon. > > Are you sure that's likely to be helpful? > Yes, I checked the register dump and the micbias power bits are > not set. The register settings will be the same if we remove it, > and it is verified. On the other hand, the micbias power bits will > be set and the micbias_event will be invoked after we convert the > micbias widget type to SUPPLY if we don't remove it. But are you sure that this was working properly for the Mediatek systems previously and your and Hans' patches don't actually fix a bug for them too? If that's the case then removing the supply hookup would cause a bug for them.

1 0

[alsa-devel] [PATCH] ASoC: rt5645: change micbias widget type to supply.
by Bard Liao 04 Jan '18

04 Jan '18

Register "micbias1" and "micbias2" to supply widegts as modern drivers do. Signed-off-by: Bard Liao <bardliao(a)realtek.com> --- sound/soc/codecs/rt5645.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index cd82302..8f37afd 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -1977,10 +1977,10 @@ static const struct snd_soc_dapm_widget rt5645_dapm_widgets[] = { /* Input Side */ /* micbias */ - SND_SOC_DAPM_MICBIAS("micbias1", RT5645_PWR_ANLG2, - RT5645_PWR_MB1_BIT, 0), - SND_SOC_DAPM_MICBIAS("micbias2", RT5645_PWR_ANLG2, - RT5645_PWR_MB2_BIT, 0), + SND_SOC_DAPM_SUPPLY("micbias1", RT5645_PWR_ANLG2, + RT5645_PWR_MB1_BIT, 0, NULL, 0), + SND_SOC_DAPM_SUPPLY("micbias2", RT5645_PWR_ANLG2, + RT5645_PWR_MB2_BIT, 0, NULL, 0), /* Input Lines */ SND_SOC_DAPM_INPUT("DMIC L1"), SND_SOC_DAPM_INPUT("DMIC R1"), -- 2.7.4

2 1

[alsa-devel] [PATCH 0/6] ASoC: rt5645: Analog microphone fixes
by Hans de Goede 04 Jan '18

04 Jan '18

Hi All, Here is a patch-series primarily fixing analog microphone inputs on Cherry Trail devices with a rt5645 codec. The first 2 patches are from Bard Liao, he has already submitted the first one himself a couple of days ago. I've included this because his second patch depends on it and he has not yet submitted that one himself I believe. My version of his 2nd patch fixes 2 compiler warnings by removing 2 unused variable declarations. Patches 3-5 makes some changes to platform data necessary to make everything work correctly on my cht + rt5645 devices. The 6th patch adds an "Int Analog Mic" DAPM widget which is used by updated ucm files for these devices to get the micbias supplies enabled without which the micrphones on these devices will not work. Regards, Hans

3 18

[alsa-devel] suspicious RCU usage at sound/core/pcm_lib.c:LINE
by syzbot 04 Jan '18

04 Jan '18

Hello, syzkaller hit the following crash on ad036b63ee57df9ab802a4eb20cbbbec66aa4520 git://git.cmpxchg.org/linux-mmots.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached. Unfortunately, I don't have any reproducer for this bug yet. IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+993cb4cfcbbff3947c21(a)syzkaller.appspotmail.com It will help syzbot understand when the bug is fixed. See footer for details. If you forward the report, please keep this part and the footer. ============================= WARNING: suspicious RCU usage 4.15.0-rc6-mm1+ #50 Not tainted kauditd_printk_skb: 75 callbacks suppressed audit: type=1326 audit(1514976425.195:283): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=202 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.196:284): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=8 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.196:285): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=202 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.196:286): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=9 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.199:287): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=202 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.202:288): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=257 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.203:289): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=202 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.203:290): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=202 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.240:291): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=317 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.240:292): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=202 compat=0 ip=0x452ac9 code=0x7ffc0000 WARNING: CPU: 0 PID: 6848 at sound/core/pcm_lib.c:1635 snd_pcm_hw_param_first+0x289/0x690 sound/core/pcm_lib.c:1635 Kernel panic - not syncing: panic_on_warn set ... CPU: 0 PID: 6848 Comm: syz-executor4 Not tainted 4.15.0-rc6-mm1+ #50 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x137/0x198 lib/dump_stack.c:53 panic+0x1e4/0x41c kernel/panic.c:183 __warn+0x1dc/0x200 kernel/panic.c:547 report_bug+0x211/0x2d0 lib/bug.c:184 fixup_bug.part.11+0x37/0x80 arch/x86/kernel/traps.c:178 fixup_bug arch/x86/kernel/traps.c:247 [inline] do_error_trap+0x249/0x290 arch/x86/kernel/traps.c:296 do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:315 invalid_op+0x22/0x40 arch/x86/entry/entry_64.S:1079 RIP: 0010:snd_pcm_hw_param_first+0x289/0x690 sound/core/pcm_lib.c:1635 RSP: 0018:ffff8801d5367950 EFLAGS: 00010216 RAX: 0000000000010000 RBX: ffff8801c18936c0 RCX: ffffffff83b45549 RDX: 00000000000018c6 RSI: ffffc90003dcc000 RDI: ffff8801c18936e8 RBP: ffff8801d53679a0 R08: ffffed003aa6ce99 R09: ffff8801d53674c0 R10: 0000000000000001 R11: ffffed003aa6ce98 R12: 000000000000000d R13: 00000000ffffffea R14: 0000000000000005 R15: 0000000000002000 snd_pcm_hw_param_near.constprop.28+0x66e/0x790 sound/core/oss/pcm_oss.c:457 snd_pcm_oss_change_params+0x1513/0x3210 sound/core/oss/pcm_oss.c:969 snd_pcm_oss_make_ready+0xaa/0x130 sound/core/oss/pcm_oss.c:1128 snd_pcm_oss_read1 sound/core/oss/pcm_oss.c:1436 [inline] snd_pcm_oss_read+0x161/0x5c0 sound/core/oss/pcm_oss.c:2623 __vfs_read+0xef/0x730 fs/read_write.c:411 vfs_read+0x11e/0x350 fs/read_write.c:447 SYSC_read fs/read_write.c:573 [inline] SyS_read+0xd4/0x1a0 fs/read_write.c:566 entry_SYSCALL_64_fastpath+0x23/0x9a RIP: 0033:0x452ac9 RSP: 002b:00007fc02c6cac58 EFLAGS: 00000212 ORIG_RAX: 0000000000000000 RAX: ffffffffffffffda RBX: 00007fc02c6cb700 RCX: 0000000000452ac9 RDX: 0000000000000099 RSI: 0000000020aebf67 RDI: 0000000000000013 RBP: 0000000000a2f870 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000212 R12: 0000000000000000 R13: 0000000000a2f7ef R14: 00007fc02c6cb9c0 R15: 0000000000000002 Dumping ftrace buffer: (ftrace buffer empty) Kernel Offset: disabled --- This bug is generated by a dumb bot. It may contain errors. See https://goo.gl/tpsmEJ for details. Direct all questions to syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. If you forgot to add the Reported-by tag, once the fix for this bug is merged into any tree, please reply to this email with: #syz fix: exact-commit-title To mark this as a duplicate of another syzbot report, please reply with: #syz dup: exact-subject-of-another-report If it's a one-off invalid bug report, please reply with: #syz invalid Note: if the crash happens again, it will cause creation of a new bug report. Note: all commands must start from beginning of the line in the email body.

1 0

[alsa-devel] suspicious RCU usage at sound/core/pcm_lib.c:LINE
by syzbot 04 Jan '18

04 Jan '18

Hello, syzkaller hit the following crash on ad036b63ee57df9ab802a4eb20cbbbec66aa4520 git://git.cmpxchg.org/linux-mmots.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached. Unfortunately, I don't have any reproducer for this bug yet. IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+993cb4cfcbbff3947c21(a)syzkaller.appspotmail.com It will help syzbot understand when the bug is fixed. See footer for details. If you forward the report, please keep this part and the footer. ============================= WARNING: suspicious RCU usage 4.15.0-rc6-mm1+ #50 Not tainted kauditd_printk_skb: 75 callbacks suppressed audit: type=1326 audit(1514976425.195:283): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=202 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.196:284): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=8 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.196:285): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=202 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.196:286): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=9 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.199:287): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=202 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.202:288): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=257 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.203:289): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=202 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.203:290): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=202 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.240:291): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=317 compat=0 ip=0x452ac9 code=0x7ffc0000 audit: type=1326 audit(1514976425.240:292): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 pid=6814 comm="syz-executor5" exe="/root/syz-executor5" sig=0 arch=c000003e syscall=202 compat=0 ip=0x452ac9 code=0x7ffc0000 WARNING: CPU: 0 PID: 6848 at sound/core/pcm_lib.c:1635 snd_pcm_hw_param_first+0x289/0x690 sound/core/pcm_lib.c:1635 Kernel panic - not syncing: panic_on_warn set ... CPU: 0 PID: 6848 Comm: syz-executor4 Not tainted 4.15.0-rc6-mm1+ #50 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x137/0x198 lib/dump_stack.c:53 panic+0x1e4/0x41c kernel/panic.c:183 __warn+0x1dc/0x200 kernel/panic.c:547 report_bug+0x211/0x2d0 lib/bug.c:184 fixup_bug.part.11+0x37/0x80 arch/x86/kernel/traps.c:178 fixup_bug arch/x86/kernel/traps.c:247 [inline] do_error_trap+0x249/0x290 arch/x86/kernel/traps.c:296 do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:315 invalid_op+0x22/0x40 arch/x86/entry/entry_64.S:1079 RIP: 0010:snd_pcm_hw_param_first+0x289/0x690 sound/core/pcm_lib.c:1635 RSP: 0018:ffff8801d5367950 EFLAGS: 00010216 RAX: 0000000000010000 RBX: ffff8801c18936c0 RCX: ffffffff83b45549 RDX: 00000000000018c6 RSI: ffffc90003dcc000 RDI: ffff8801c18936e8 RBP: ffff8801d53679a0 R08: ffffed003aa6ce99 R09: ffff8801d53674c0 R10: 0000000000000001 R11: ffffed003aa6ce98 R12: 000000000000000d R13: 00000000ffffffea R14: 0000000000000005 R15: 0000000000002000 snd_pcm_hw_param_near.constprop.28+0x66e/0x790 sound/core/oss/pcm_oss.c:457 snd_pcm_oss_change_params+0x1513/0x3210 sound/core/oss/pcm_oss.c:969 snd_pcm_oss_make_ready+0xaa/0x130 sound/core/oss/pcm_oss.c:1128 snd_pcm_oss_read1 sound/core/oss/pcm_oss.c:1436 [inline] snd_pcm_oss_read+0x161/0x5c0 sound/core/oss/pcm_oss.c:2623 __vfs_read+0xef/0x730 fs/read_write.c:411 vfs_read+0x11e/0x350 fs/read_write.c:447 SYSC_read fs/read_write.c:573 [inline] SyS_read+0xd4/0x1a0 fs/read_write.c:566 entry_SYSCALL_64_fastpath+0x23/0x9a RIP: 0033:0x452ac9 RSP: 002b:00007fc02c6cac58 EFLAGS: 00000212 ORIG_RAX: 0000000000000000 RAX: ffffffffffffffda RBX: 00007fc02c6cb700 RCX: 0000000000452ac9 RDX: 0000000000000099 RSI: 0000000020aebf67 RDI: 0000000000000013 RBP: 0000000000a2f870 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000212 R12: 0000000000000000 R13: 0000000000a2f7ef R14: 00007fc02c6cb9c0 R15: 0000000000000002 Dumping ftrace buffer: (ftrace buffer empty) Kernel Offset: disabled --- This bug is generated by a dumb bot. It may contain errors. See https://goo.gl/tpsmEJ for details. Direct all questions to syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. If you forgot to add the Reported-by tag, once the fix for this bug is merged into any tree, please reply to this email with: #syz fix: exact-commit-title To mark this as a duplicate of another syzbot report, please reply with: #syz dup: exact-subject-of-another-report If it's a one-off invalid bug report, please reply with: #syz invalid Note: if the crash happens again, it will cause creation of a new bug report. Note: all commands must start from beginning of the line in the email body.

1 0

Re: [alsa-devel] [PATCH 1/6] ASoC: rt5645: change micbias widget type to supply.
by Mark Brown 04 Jan '18

04 Jan '18

On Thu, Jan 04, 2018 at 11:14:40AM +0000, Bard Liao wrote: > > > I found mt8173 from mediatek is using rt5650 micbias. > > > {"Headset Mic", NULL, "micbias1"}, > > > {"Headset Mic", NULL, "micbias2"}, > > > I think we should remove it but still need to verify. > > > We are co-working with MTK folks on it and it may take some days. > > That looks like normal supply usage for a micbias so most likely your > > patch is a fix for them anyway. > Yes, it's supply usage for a micbias. So it didn't take effect with > MICBIAS widget type. Actually, we don't need to set the micbias > power bit for headset mic and we have verified it today. So, I will > send a patch to remove them soon. Are you sure that's likely to be helpful?

1 0

Re: [alsa-devel] [PATCH 1/6] ASoC: rt5645: change micbias widget type to supply.
by Mark Brown 04 Jan '18

04 Jan '18

On Thu, Jan 04, 2018 at 07:19:15AM +0000, Bard Liao wrote: > I found mt8173 from mediatek is using rt5650 micbias. > {"Headset Mic", NULL, "micbias1"}, > {"Headset Mic", NULL, "micbias2"}, > I think we should remove it but still need to verify. > We are co-working with MTK folks on it and it may take some days. That looks like normal supply usage for a micbias so most likely your patch is a fix for them anyway.

1 0

[alsa-devel] [RFC v5 0/3] Enable HDA Codec support on Intel Platforms (Series1)
by Rakesh Ughreja 04 Jan '18

04 Jan '18

Enhanced HD Audio capabilities introduced in HD Audio controllers are added in backward compatible way i.e. it does not change the behavior of the controller with respect to HDA Bus and HDA devices. Since there is no change in the hardware with respect to the HDA bus and HDA device it is more appropriate to represent the same in software as well. In order to align software representation with hardware it makes more sense to have common data structures across device, bus and driver for both enhanced HDA controllers and legacy HDA controllers. This patch series removes the hdac_ext_device structure, hdac_ext_bus and hdac_ext_driver data structures so that legacy and enhanced HDaudio capabilities can be handled in a backwards-compatible way without separate definitions. Once this clean-up is complete, additional patches will allow for HDaudio codec support in an ASoC framework without the need to develop new codec drivers, thereby enabling the use of the Intel DSP on more platforms (currently limited to hdmi). Changes in v5: - No functionality changes in this series except rebase. Changes in v4: - No changes in this series except rebase as there were no comments. Changes in v3: - No changes in this series except rebase as there were no comments. Changes in v2: - First three patches from v1 are merged so not included in this series. - No changes in this series except rebase as there were no comments. Rakesh Ughreja (3): ALSA: hdac: Remove usage of struct hdac_ext_device and use hdac_device instead ALSA: hdac: Remove usage of struct hdac_ext_bus and use hdac_bus instead ALSA: hdac: Remove usage of struct hdac_ext_driver, use hdac_driver instead include/sound/hdaudio.h | 21 ++ include/sound/hdaudio_ext.h | 119 +++------- sound/hda/ext/hdac_ext_bus.c | 76 +++--- sound/hda/ext/hdac_ext_controller.c | 55 +++-- sound/hda/ext/hdac_ext_stream.c | 104 ++++----- sound/soc/codecs/hdac_hdmi.c | 415 ++++++++++++++++----------------- sound/soc/intel/skylake/skl-messages.c | 50 ++-- sound/soc/intel/skylake/skl-nhlt.c | 8 +- sound/soc/intel/skylake/skl-pcm.c | 112 +++++---- sound/soc/intel/skylake/skl-topology.c | 18 +- sound/soc/intel/skylake/skl-topology.h | 6 +- sound/soc/intel/skylake/skl.c | 178 +++++++------- sound/soc/intel/skylake/skl.h | 7 +- 13 files changed, 522 insertions(+), 647 deletions(-) -- 2.7.4

3 5