January 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [asoc:topic/st-dfsdm 2/2] sound/soc/stm/stm32_adfsdm.c:17:10: fatal error: linux/iio/adc/stm32-dfsdm-adc.h: No such file or directory
by kbuild test robot 10 Jan '18

10 Jan '18

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/st-dfsdm head: 55da094824c4ef1d50bc591733d79448d00265bb commit: 55da094824c4ef1d50bc591733d79448d00265bb [2/2] ASoC: stm32: add DFSDM DAI support config: frv-allmodconfig (attached as .config) compiler: frv-linux-gcc (GCC) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 55da094824c4ef1d50bc591733d79448d00265bb # save the attached .config to linux build tree make.cross ARCH=frv All errors (new ones prefixed by >>): >> sound/soc/stm/stm32_adfsdm.c:17:10: fatal error: linux/iio/adc/stm32-dfsdm-adc.h: No such file or directory #include <linux/iio/adc/stm32-dfsdm-adc.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. vim +17 sound/soc/stm/stm32_adfsdm.c 14 15 #include <linux/iio/iio.h> 16 #include <linux/iio/consumer.h> > 17 #include <linux/iio/adc/stm32-dfsdm-adc.h> 18 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

2 1

Re: [alsa-devel] [PATCH v2] ASoC: sgtl5000: Fix powerup/down of micbias
by Fischer, Christian 10 Jan '18

10 Jan '18

Hello Daniel, I'm sorry, thats my first official patch :-) I've now cloned a kernel outside my buildsystem and (hopefully) a new, acceptable patch. Regards, Christian From d06794d98e3ed84ecb1641b74d093366ffff2cba Mon Sep 17 00:00:00 2001 From: Christian Fischer <fischerc(a)swissphone.de> Date: Wed, 10 Jan 2018 16:47:51 +0100 Subject: [PATCH v2] ASoC: sgtl5000: fix powerup/down of micbias-voltage The mic-bias-voltage should get powered up/down automatically. Added missing DAPM_PRE and DAPM_POST widgets to fire up the mic_bias_event function. Signed-off-by: Christian Fischer <fischerc(a)swissphone.de> --- sound/soc/codecs/sgtl5000.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index f2bb4fe..4973365 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -260,6 +260,9 @@ static const struct snd_soc_dapm_widget sgtl5000_dapm_widgets[] = { SND_SOC_DAPM_PRE("VAG_POWER_PRE", power_vag_event), SND_SOC_DAPM_POST("VAG_POWER_POST", power_vag_event), + + SND_SOC_DAPM_PRE("MIC_BIAS_PRE", mic_bias_event), + SND_SOC_DAPM_POST("MIC_BIAS_POST", mic_bias_event), }; /* routes for sgtl5000 */ -- 2.7.4 -----Ursprüngliche Nachricht----- Von: Daniel Baluta [mailto:daniel.baluta@nxp.com] Gesendet: Mittwoch, 10. Januar 2018 15:31 An: Fischer, Christian <fischerc(a)swissphone.de>; alsa-devel(a)alsa-project.org Cc: lgirdwood(a)gmail.com; broonie(a)kernel.org; tiwai(a)suse.com Betreff: Re: [alsa-devel] [PATCH v2] ASoC: sgtl5000: Fix powerup/down of micbias On Mi, 2018-01-10 at 14:26 +0000, Fischer, Christian wrote: > Hello Fabio, > > is it now ok? > I'm not working with linux-git, so my patch is created by myself. > > Regards, > Christian > > Signed-off-by: Christian Fischer <fischerc(a)swissphone.de> Hi Christian, This doesn't look good to me. How are creating/sending the patches? You should update the commit message to include your Signed-off-by tag and then resend the entire patch. thanks, Daniel. > > --- sound/soc/codecs/sgtl5000.c > +++ sound/soc/codecs/sgtl5000.c > @@ -260,6 +260,9 @@ static const struct snd_soc_dapm_widget > > SND_SOC_DAPM_PRE("VAG_POWER_PRE", power_vag_event), > SND_SOC_DAPM_POST("VAG_POWER_POST", power_vag_event), > + > + SND_SOC_DAPM_PRE("MIC_BIAS_PRE", mic_bias_event), > + SND_SOC_DAPM_POST("MIC_BIAS_POST", mic_bias_event), > }; > > /* routes for sgtl5000 */ > > -----Ursprüngliche Nachricht----- > Von: Fabio Estevam [mailto:festevam@gmail.com] > Gesendet: Mittwoch, 10. Januar 2018 13:42 > An: Fischer, Christian <fischerc(a)swissphone.de> > Cc: alsa-devel(a)alsa-project.org; Takashi Iwai <tiwai(a)suse.com>; Mark > Brown <broonie(a)kernel.org>; Liam Girdwood <lgirdwood(a)gmail.com> > Betreff: Re: [alsa-devel] [PATCH] ASoC: sgtl5000: Fix powerup/down of > micbias > > Hi Christian, > > On Wed, Jan 10, 2018 at 8:07 AM, Fischer, Christian <fischerc(a)swissphone.de> wrote: > > > > The bias-bias-voltage should powered up/down automatically. > > Added missing DAPM_PRE and DAPM_POST widgets to fire up the mic_bias_event function. > Thanks for submitting the patch. > > You missed your Signed-off-by tag. > > Please resend it. > > Thanks > _______________________________________________ > Alsa-devel mailing list > Alsa-devel(a)alsa-project.org > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail > man.alsa-project.org%2Fmailman%2Flistinfo%2Falsa-devel&data=02%7C01%7C > daniel.baluta%40nxp.com%7C4a771694af314fa7d73008d558362a37 > %7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636511912029282885&sdata=Zo42ZJxIxp54YyYLVsFrrRWkDt%2FqByR6uqr8U6pX3iY%3D&reserved=0

2 1

[alsa-devel] [asoc:topic/iio 9/11] drivers/iio/adc/stm32-dfsdm-adc.c:241:6: sparse: symbol 'stm32_dfsdm_stop_filter' was not declared. Should it be static?
by kbuild test robot 10 Jan '18

10 Jan '18

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/iio head: 16cbca06fa8288a4f58426fc898b141e12ee8008 commit: e2e6771c646251657fafb2a78db566d5c2c70635 [9/11] IIO: ADC: add STM32 DFSDM sigma delta ADC support reproduce: # apt-get install sparse git checkout e2e6771c646251657fafb2a78db566d5c2c70635 make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/iio/adc/stm32-dfsdm-adc.c:241:6: sparse: symbol 'stm32_dfsdm_stop_filter' was not declared. Should it be >> drivers/iio/adc/stm32-dfsdm-adc.c:283:5: sparse: symbol 'stm32_dfsdm_channel_parse_of' was not declared. Should it be Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

3 3

[alsa-devel] [-next PATCH 0/4] sysfs and DEVICE_ATTR_<foo>
by Joe Perches 10 Jan '18

10 Jan '18

16 24

Re: [alsa-devel] [PATCH v2] ASoC: sgtl5000: Fix powerup/down of micbias
by Fischer, Christian 10 Jan '18

10 Jan '18

Hello Fabio, is it now ok? I'm not working with linux-git, so my patch is created by myself. Regards, Christian Signed-off-by: Christian Fischer <fischerc(a)swissphone.de> --- sound/soc/codecs/sgtl5000.c +++ sound/soc/codecs/sgtl5000.c @@ -260,6 +260,9 @@ static const struct snd_soc_dapm_widget SND_SOC_DAPM_PRE("VAG_POWER_PRE", power_vag_event), SND_SOC_DAPM_POST("VAG_POWER_POST", power_vag_event), + + SND_SOC_DAPM_PRE("MIC_BIAS_PRE", mic_bias_event), + SND_SOC_DAPM_POST("MIC_BIAS_POST", mic_bias_event), }; /* routes for sgtl5000 */ -----Ursprüngliche Nachricht----- Von: Fabio Estevam [mailto:festevam@gmail.com] Gesendet: Mittwoch, 10. Januar 2018 13:42 An: Fischer, Christian <fischerc(a)swissphone.de> Cc: alsa-devel(a)alsa-project.org; Takashi Iwai <tiwai(a)suse.com>; Mark Brown <broonie(a)kernel.org>; Liam Girdwood <lgirdwood(a)gmail.com> Betreff: Re: [alsa-devel] [PATCH] ASoC: sgtl5000: Fix powerup/down of micbias Hi Christian, On Wed, Jan 10, 2018 at 8:07 AM, Fischer, Christian <fischerc(a)swissphone.de> wrote: > The bias-bias-voltage should powered up/down automatically. > Added missing DAPM_PRE and DAPM_POST widgets to fire up the mic_bias_event function. Thanks for submitting the patch. You missed your Signed-off-by tag. Please resend it. Thanks

2 1

Re: [alsa-devel] ASoC: sgtl5000: recording issue at 8 kHz with fsl-imx28
by Fischer, Christian 10 Jan '18

10 Jan '18

It's me again. I just found out that the audio playback is affected by this problem too. Maybe this can serve as a hint. Regards, Christian -----Ursprüngliche Nachricht----- Von: alsa-devel-bounces(a)alsa-project.org [mailto:alsa-devel-bounces@alsa-project.org] Im Auftrag von Fischer, Christian Gesendet: Mittwoch, 10. Januar 2018 11:31 An: alsa-devel(a)alsa-project.org Cc: 'Takashi Iwai' <tiwai(a)suse.com>; 'Mark Brown' <broonie(a)kernel.org>; 'Liam Girdwood' <lgirdwood(a)gmail.com> Betreff: [alsa-devel] ASoC: sgtl5000: recording issue at 8 kHz with fsl-imx28 Hello guys, trying to record from a SGTL5000 with 8 kHz sampling rate gives a very bad audio quality. All other sampling rates working fine. Initially posted at NXP forum: https://community.nxp.com/message/975131 Tested with imx28, sgtl5000 and Kernel 4.14.12. I've attached a recording with 8 kHz, capture-vol was 67, mic-gain 33, AVC-off and Capture-ZC off. Recorded with "arecord -D "hw:0,1" -t wav -f S16_LE -c 2 -r 8000 test.wav". Sounds like there are missing samples.. The microphone is powered from mic-bias and decoupled with a 100nF capacitor. Can anybody help me? Thank you guys! Kind regards, Christian Fischer

1 0

[alsa-devel] [RESEND PATCH v9 00/13] Add STM32 DFSDM support
by Arnaud Pouliquen 10 Jan '18

10 Jan '18

Hello Mark, Here is the resend of the patchset. I added the Reviewed-by: Jonathan Cameron in patch 10/13. Jonathan's comment for you, posted for this version: >So Mark, over to you. I'm happy if you want to do the immutable branch once >any issue you find are fixed, or I can do it. >I'm just looking for acks or a pull request now. History: Version 9 fix patch 10/13: IIO: ADC: add stm32 DFSDM support for PDM microphone Main deltas V9 vs V8: - Rework probe and remove order for audio configuration in stm32-dfsdm-adc.c. - Optimization of the filling of the dma_slave_config struct. Main deltas V8 vs V7: - Few typos fixes. - Function return optimizations in sound/soc/stm/stm32_adfsdm.c. Main deltas V7 vs V6: - Replaces the custom license information text with the appropriate SPDX identifier. - Few fixes in sound/soc/stm/stm32_adfsdm.c and stm32-dfsdm-core.c. - Add missing #interrupt-cells in binding examples. - Integrate last Jonathan's comments. Main deltas V6 vs V5: - Fix warning reported by kbuild test in : include/linux/iio/consumer.h sound/soc/stm/stm32_adfsdm.c Main deltas V5 vs V4: - Integrate ASOC DAI as a subnode of the DFSDM. - Add in kernel consumer interface to allow to manipulate attribute. Thanks, Arnaud Arnaud Pouliquen (12): docs: driver-api: add iio hw consumer section IIO: hw_consumer: add devm_iio_hw_consumer_alloc IIO: inkern: API for manipulating channel attributes IIO: Add DT bindings for sigma delta adc modulator IIO: ADC: add sigma delta modulator support IIO: add DT bindings for stm32 DFSDM filter IIO: ADC: add stm32 DFSDM core support IIO: ADC: add STM32 DFSDM sigma delta ADC support IIO: ADC: add stm32 DFSDM support for PDM microphone IIO: consumer: allow to set buffer sizes ASoC: add bindings for stm32 DFSDM filter ASoC: stm32: add DFSDM DAI support Lars-Peter Clausen (1): iio: Add hardware consumer buffer support .../ABI/testing/sysfs-bus-iio-dfsdm-adc-stm32 | 16 + .../bindings/iio/adc/sigma-delta-modulator.txt | 13 + .../bindings/iio/adc/st,stm32-dfsdm-adc.txt | 128 +++ .../devicetree/bindings/sound/st,stm32-adfsdm.txt | 63 + Documentation/driver-api/iio/hw-consumer.rst | 51 + Documentation/driver-api/iio/index.rst | 1 + drivers/iio/adc/Kconfig | 37 + drivers/iio/adc/Makefile | 3 + drivers/iio/adc/sd_adc_modulator.c | 68 ++ drivers/iio/adc/stm32-dfsdm-adc.c | 1216 ++++++++++++++++++++ drivers/iio/adc/stm32-dfsdm-core.c | 309 +++++ drivers/iio/adc/stm32-dfsdm.h | 310 +++++ drivers/iio/buffer/Kconfig | 10 + drivers/iio/buffer/Makefile | 1 + drivers/iio/buffer/industrialio-buffer-cb.c | 11 + drivers/iio/buffer/industrialio-hw-consumer.c | 247 ++++ drivers/iio/inkern.c | 17 +- include/linux/iio/adc/stm32-dfsdm-adc.h | 18 + include/linux/iio/consumer.h | 37 + include/linux/iio/hw-consumer.h | 21 + include/linux/iio/iio.h | 28 - include/linux/iio/types.h | 28 + sound/soc/stm/Kconfig | 11 + sound/soc/stm/Makefile | 3 + sound/soc/stm/stm32_adfsdm.c | 347 ++++++ 25 files changed, 2961 insertions(+), 33 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-dfsdm-adc-stm32 create mode 100644 Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt create mode 100644 Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt create mode 100644 Documentation/devicetree/bindings/sound/st,stm32-adfsdm.txt create mode 100644 Documentation/driver-api/iio/hw-consumer.rst create mode 100644 drivers/iio/adc/sd_adc_modulator.c create mode 100644 drivers/iio/adc/stm32-dfsdm-adc.c create mode 100644 drivers/iio/adc/stm32-dfsdm-core.c create mode 100644 drivers/iio/adc/stm32-dfsdm.h create mode 100644 drivers/iio/buffer/industrialio-hw-consumer.c create mode 100644 include/linux/iio/adc/stm32-dfsdm-adc.h create mode 100644 include/linux/iio/hw-consumer.h create mode 100644 sound/soc/stm/stm32_adfsdm.c -- 2.7.4

3 16

[alsa-devel] [PATCH 1/2] soundwire: Fix a signedness bug
by Dan Carpenter 10 Jan '18

10 Jan '18

"ret" is an int and "buf" is a u8. sdw_read() returns negative error codes which are truncated to the u8, 0-255 range before being stored as an int. It means that "ret" can't be less than zero. Fixes: b0a9c37b0178 ("soundwire: Add slave status handling") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index 4c345197eb55..ac88031f7664 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -771,12 +771,13 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) sdw_modify_slave_status(slave, SDW_SLAVE_ALERT); /* Read Instat 1, Instat 2 and Instat 3 registers */ - ret = buf = sdw_read(slave, SDW_SCP_INT1); + ret = sdw_read(slave, SDW_SCP_INT1); if (ret < 0) { dev_err(slave->bus->dev, "SDW_SCP_INT1 read failed:%d", ret); return ret; } + buf = ret; ret = sdw_nread(slave, SDW_SCP_INTSTAT2, 2, buf2); if (ret < 0) { @@ -870,12 +871,13 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) * Read status again to ensure no new interrupts arrived * while servicing interrupts. */ - ret = _buf = sdw_read(slave, SDW_SCP_INT1); + ret = sdw_read(slave, SDW_SCP_INT1); if (ret < 0) { dev_err(slave->bus->dev, "SDW_SCP_INT1 read failed:%d", ret); return ret; } + _buf = ret; ret = sdw_nread(slave, SDW_SCP_INTSTAT2, 2, _buf2); if (ret < 0) {

3 6

[alsa-devel] [PATCH] ASoC: sgtl5000: Fix powerup/down of micbias
by Fischer, Christian 10 Jan '18

10 Jan '18

The bias-bias-voltage should powered up/down automatically. Added missing DAPM_PRE and DAPM_POST widgets to fire up the mic_bias_event function. --- sound/soc/codecs/sgtl5000.c +++ sound/soc/codecs/sgtl5000.c @@ -260,6 +260,9 @@ static const struct snd_soc_dapm_widget SND_SOC_DAPM_PRE("VAG_POWER_PRE", power_vag_event), SND_SOC_DAPM_POST("VAG_POWER_POST", power_vag_event), + + SND_SOC_DAPM_PRE("MIC_BIAS_PRE", mic_bias_event), + SND_SOC_DAPM_POST("MIC_BIAS_POST", mic_bias_event), }; /* routes for sgtl5000 */

2 1

[alsa-devel] [PATCH v7 00/13] Add STM32 DFSDM support
by Arnaud Pouliquen 10 Jan '18

10 Jan '18

Hello, Here is a new version integrating last comments Main deltas V7 vs V6: - Replaces the custom license information text with the appropriate SPDX identifier. - Few fixes in sound/soc/stm/stm32_adfsdm.c and stm32-dfsdm-core.c. - Add missing #interrupt-cells in binding examples. - Integrate last Jonathan's comments. Main deltas V6 vs V5: - Fix warning reported by kbuild test in : include/linux/iio/consumer.h sound/soc/stm/stm32_adfsdm.c Main deltas V5 vs V4: - Integrate ASOC DAI as a subnode of the DFSDM. - Add in kernel consumer interface to allow to manipulate attribute. Regards, Arnaud Arnaud Pouliquen (12): docs: driver-api: add iio hw consumer section IIO: hw_consumer: add devm_iio_hw_consumer_alloc IIO: inkern: API for manipulating channel attributes IIO: Add DT bindings for sigma delta adc modulator IIO: ADC: add sigma delta modulator support IIO: add DT bindings for stm32 DFSDM filter IIO: ADC: add stm32 DFSDM core support IIO: ADC: add STM32 DFSDM sigma delta ADC support IIO: ADC: add stm32 DFSDM support for PDM microphone IIO: consumer: allow to set buffer sizes ASoC: add bindings for stm32 DFSDM filter ASoC: stm32: add DFSDM DAI support Lars-Peter Clausen (1): iio: Add hardware consumer buffer support .../ABI/testing/sysfs-bus-iio-dfsdm-adc-stm32 | 16 + .../bindings/iio/adc/sigma-delta-modulator.txt | 13 + .../bindings/iio/adc/st,stm32-dfsdm-adc.txt | 128 ++ .../devicetree/bindings/sound/st,stm32-adfsdm.txt | 63 + Documentation/driver-api/iio/hw-consumer.rst | 51 + Documentation/driver-api/iio/index.rst | 1 + drivers/iio/adc/Kconfig | 37 + drivers/iio/adc/Makefile | 3 + drivers/iio/adc/sd_adc_modulator.c | 68 ++ drivers/iio/adc/stm32-dfsdm-adc.c | 1220 ++++++++++++++++++++ drivers/iio/adc/stm32-dfsdm-core.c | 309 +++++ drivers/iio/adc/stm32-dfsdm.h | 310 +++++ drivers/iio/buffer/Kconfig | 10 + drivers/iio/buffer/Makefile | 1 + drivers/iio/buffer/industrialio-buffer-cb.c | 11 + drivers/iio/buffer/industrialio-hw-consumer.c | 247 ++++ drivers/iio/inkern.c | 18 +- include/linux/iio/adc/stm32-dfsdm-adc.h | 18 + include/linux/iio/consumer.h | 37 + include/linux/iio/hw-consumer.h | 21 + include/linux/iio/iio.h | 28 - include/linux/iio/types.h | 28 + sound/soc/stm/Kconfig | 11 + sound/soc/stm/Makefile | 3 + sound/soc/stm/stm32_adfsdm.c | 351 ++++++ 25 files changed, 2970 insertions(+), 33 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-dfsdm-adc-stm32 create mode 100644 Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt create mode 100644 Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt create mode 100644 Documentation/devicetree/bindings/sound/st,stm32-adfsdm.txt create mode 100644 Documentation/driver-api/iio/hw-consumer.rst create mode 100644 drivers/iio/adc/sd_adc_modulator.c create mode 100644 drivers/iio/adc/stm32-dfsdm-adc.c create mode 100644 drivers/iio/adc/stm32-dfsdm-core.c create mode 100644 drivers/iio/adc/stm32-dfsdm.h create mode 100644 drivers/iio/buffer/industrialio-hw-consumer.c create mode 100644 include/linux/iio/adc/stm32-dfsdm-adc.h create mode 100644 include/linux/iio/hw-consumer.h create mode 100644 sound/soc/stm/stm32_adfsdm.c -- 2.7.4

3 22