August 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/3] ALSA: control: fix issue of concurrent access of ELEM_READ/ELEM_WRITE
by Takashi Sakamoto 20 Aug '17

20 Aug '17

Hi, This patchset is to fix an issue of concurrent access to operate ELEM_READ/ELEM_WRITE, which I found in my previous patch: [PATCH 0/5] ALSA: control: fix issue of concurrent access for TLV operations http://mailman.alsa-project.org/pipermail/alsa-devel/2017-August/123561.html In current implementation of ALSA control core, concurrent accesses with ELEM_READ/ELEM_WRITE are managed with counting semaphore, however lock acquisition for both of these operations is a type of 'read'. In this case, ELEM_READ can be going to be handled for a target element when ELEM_WRITE is handled for the element. A purpose of the ELEM_WRITE operation is to change state of the target element. It's better to guarantee that concurrent accesses to the same element with these two operations are properly managed. For the above aim, this patchset uses the counting semaphore as 'write' lock for ELEM_WRITE operation. But I can imagine an discussion to add 'per-element' lock for this issue. In a comment of patch 03, I investigate it. Please refer to it. Takashi Sakamoto (3): ALSA: control: queue events within locking of controls_rwsem for ELEM_WRITE operation ALSA: control: code refactoring for ELEM_READ/ELEM_WRITE operations ALSA: control: use counting semaphore as write lock for ELEM_WRITE operation sound/core/control.c | 78 +++++++++++++++++++++++++--------------------------- 1 file changed, 38 insertions(+), 40 deletions(-) -- 2.11.0

2 4

[alsa-devel] [PATCH 10/12] ASoC: sun4i-codec: Remove unnecessary function call
by Peng Donglin 20 Aug '17

20 Aug '17

First of all,the address of pdev->dev is assigned to card->dev in create_card,then the function platform_set_drvdata copies the value the variable card to pdev->dev.driver_data, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will also do the same copy operation,so i think that the former copy operation can be removed. Signed-off-by: Peng Donglin <dolinux.peng(a)gmail.com> --- sound/soc/sunxi/sun4i-codec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c index 1500699..82beeae 100644 --- a/sound/soc/sunxi/sun4i-codec.c +++ b/sound/soc/sunxi/sun4i-codec.c @@ -1655,7 +1655,6 @@ static int sun4i_codec_probe(struct platform_device *pdev) goto err_unregister_codec; } - platform_set_drvdata(pdev, card); snd_soc_card_set_drvdata(card, scodec); ret = snd_soc_register_card(card); -- 1.9.1

1 0

[alsa-devel] [PATCH 07/12] ASoC: mxs-sgtl5000: Remove unnecessary function call
by Peng Donglin 20 Aug '17

20 Aug '17

First of all,the address of pdev->dev is assigned to card->dev,then the function platform_set_drvdata copies the value the variable card to pdev->dev.driver_data, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will also do the same copy operation,so i think that the former copy operation can be removed. Signed-off-by: Peng Donglin <dolinux.peng(a)gmail.com> --- sound/soc/mxs/mxs-sgtl5000.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/mxs/mxs-sgtl5000.c b/sound/soc/mxs/mxs-sgtl5000.c index a96276e..2ed3240 100644 --- a/sound/soc/mxs/mxs-sgtl5000.c +++ b/sound/soc/mxs/mxs-sgtl5000.c @@ -140,7 +140,6 @@ static int mxs_sgtl5000_probe(struct platform_device *pdev) } card->dev = &pdev->dev; - platform_set_drvdata(pdev, card); ret = devm_snd_soc_register_card(&pdev->dev, card); if (ret) { -- 1.9.1

1 0

[alsa-devel] [PATCH 06/12] ASoC: rockchip: Remove unnecessary function call
by Peng Donglin 20 Aug '17

20 Aug '17

First of all,the address of pdev->dev is assigned to card->dev,then the function platform_set_drvdata copies the value the variable card to pdev->dev.driver_data, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will also do the same copy operation,so i think that the former copy operation can be removed. Signed-off-by: Peng Donglin <dolinux.peng(a)gmail.com> --- sound/soc/rockchip/rk3288_hdmi_analog.c | 2 -- sound/soc/rockchip/rk3399_gru_sound.c | 1 - 2 files changed, 3 deletions(-) diff --git a/sound/soc/rockchip/rk3288_hdmi_analog.c b/sound/soc/rockchip/rk3288_hdmi_analog.c index dbc53e4..37ef162 100644 --- a/sound/soc/rockchip/rk3288_hdmi_analog.c +++ b/sound/soc/rockchip/rk3288_hdmi_analog.c @@ -272,8 +272,6 @@ static int snd_rk_mc_probe(struct platform_device *pdev) return ret; } - platform_set_drvdata(pdev, card); - return ret; } diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/rockchip/rk3399_gru_sound.c index 3475c61..70c0908 100644 --- a/sound/soc/rockchip/rk3399_gru_sound.c +++ b/sound/soc/rockchip/rk3399_gru_sound.c @@ -362,7 +362,6 @@ static int rockchip_sound_probe(struct platform_device *pdev) rockchip_dailinks[DAILINK_RT5514_DSP].platform_name = kstrdup_const(dev_name(dev), GFP_KERNEL); card->dev = &pdev->dev; - platform_set_drvdata(pdev, card); ret = devm_snd_soc_register_card(&pdev->dev, card); if (ret) -- 1.9.1

1 0

[alsa-devel] [PATCH 05/12] ASoC: atmel: Remove unnecessary function call
by Peng Donglin 20 Aug '17

20 Aug '17

The function platform_set_drvdata copies the value the variable card to card->dev->driver_data, then the address of &pdev->dev is assigned to card->dev in atmel_pdmic_asoc_card_init, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will do the same copy operation, so i think that the former copy operation can be removed. Signed-off-by: Peng Donglin <dolinux.peng(a)gmail.com> --- sound/soc/atmel/atmel-pdmic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/atmel/atmel-pdmic.c b/sound/soc/atmel/atmel-pdmic.c index c917df7..8e3d34b 100644 --- a/sound/soc/atmel/atmel-pdmic.c +++ b/sound/soc/atmel/atmel-pdmic.c @@ -694,7 +694,6 @@ static int atmel_pdmic_probe(struct platform_device *pdev) } snd_soc_card_set_drvdata(card, dd); - platform_set_drvdata(pdev, card); ret = atmel_pdmic_asoc_card_init(dev, card); if (ret) { -- 1.9.1

1 0

[alsa-devel] [PATCH 04/12] ASoC: atmel: Remove unnecessary function call
by Peng Donglin 20 Aug '17

20 Aug '17

The function platform_set_drvdata copies the value the variable card to card->dev->driver_data, then the address of &pdev->dev is assigned to card->dev in atmel_classd_asoc_card_init, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will do the same copy operation, so i think that the former copy operation can be removed. Signed-off-by: Peng Donglin <dolinux.peng(a)gmail.com> --- sound/soc/atmel/atmel-classd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c index b7ef8c5..0cd7caa 100644 --- a/sound/soc/atmel/atmel-classd.c +++ b/sound/soc/atmel/atmel-classd.c @@ -652,7 +652,6 @@ static int atmel_classd_probe(struct platform_device *pdev) } snd_soc_card_set_drvdata(card, dd); - platform_set_drvdata(pdev, card); ret = atmel_classd_asoc_card_init(dev, card); if (ret) { -- 1.9.1

1 0

[alsa-devel] [PATCH 01/12] ASoC: s3c24xx_uda134x: Remove unnecessary function call
by Peng Donglin 20 Aug '17

20 Aug '17

First of all,the address of pdev->dev is assigned to card->dev,then the function platform_set_drvdata copies the value the variable card to pdev->dev.driver_data, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will also do the same copy operation,so i think that the former copy operation can be removed. Signed-off-by: Peng Donglin <dolinux.peng(a)gmail.com> --- sound/soc/samsung/s3c24xx_uda134x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/samsung/s3c24xx_uda134x.c b/sound/soc/samsung/s3c24xx_uda134x.c index 55538e3..758e46e 100644 --- a/sound/soc/samsung/s3c24xx_uda134x.c +++ b/sound/soc/samsung/s3c24xx_uda134x.c @@ -237,7 +237,6 @@ static int s3c24xx_uda134x_probe(struct platform_device *pdev) mutex_init(&priv->clk_lock); card->dev = &pdev->dev; - platform_set_drvdata(pdev, card); snd_soc_card_set_drvdata(card, priv); ret = devm_snd_soc_register_card(&pdev->dev, card); -- 1.9.1

1 0

[alsa-devel] [PATCH 00/12] Remove unnecessary function call
by Peng Donglin 20 Aug '17

20 Aug '17

First of all,the address of pdev->dev is assigned to card->dev,then the function platform_set_drvdata copies the value the variable card to pdev->dev.driver_data, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will also do the same copy operation,so i think that the former copy operation can be removed. Peng Donglin (12): ASoC: s3c24xx_uda134x: Remove unnecessary function call ASoC: mediatek: Remove unnecessary function call ASoC: Intel: Remove unnecessary function call ASoC: atmel: Remove unnecessary function call ASoC: atmel: Remove unnecessary function call ASoC: rockchip: Remove unnecessary function call ASoC: mxs-sgtl5000: Remove unnecessary function call ASoC: qcom: Remove useless function call ASoC: qcom: Remove unnecessary function call ASoC: sun4i-codec: Remove unnecessary function call ASoC: tegra: Remove unnecessary function call ASoC: ux500: Remove unnecessary function call sound/soc/atmel/atmel-classd.c | 1 - sound/soc/atmel/atmel-pdmic.c | 1 - sound/soc/intel/boards/bytcht_da7213.c | 1 - sound/soc/intel/boards/bytcht_es8316.c | 1 - sound/soc/intel/boards/bytcr_rt5651.c | 1 - sound/soc/intel/boards/cht_bsw_max98090_ti.c | 1 - sound/soc/intel/boards/cht_bsw_rt5645.c | 1 - sound/soc/intel/boards/cht_bsw_rt5672.c | 1 - sound/soc/mediatek/mt8173/mt8173-rt5650-rt5514.c | 1 - sound/soc/mediatek/mt8173/mt8173-rt5650-rt5676.c | 1 - sound/soc/mediatek/mt8173/mt8173-rt5650.c | 1 - sound/soc/mxs/mxs-sgtl5000.c | 1 - sound/soc/qcom/apq8016_sbc.c | 1 - sound/soc/qcom/storm.c | 1 - sound/soc/rockchip/rk3288_hdmi_analog.c | 2 -- sound/soc/rockchip/rk3399_gru_sound.c | 1 - sound/soc/samsung/s3c24xx_uda134x.c | 1 - sound/soc/sunxi/sun4i-codec.c | 1 - sound/soc/tegra/tegra_alc5632.c | 1 - sound/soc/tegra/tegra_max98090.c | 1 - sound/soc/tegra/tegra_rt5640.c | 1 - sound/soc/tegra/tegra_rt5677.c | 1 - sound/soc/tegra/tegra_sgtl5000.c | 1 - sound/soc/tegra/tegra_wm8753.c | 1 - sound/soc/tegra/tegra_wm8903.c | 1 - sound/soc/tegra/tegra_wm9712.c | 1 - sound/soc/tegra/trimslice.c | 1 - sound/soc/ux500/mop500.c | 1 - 28 files changed, 29 deletions(-) -- 1.9.1

1 0

[alsa-devel] [alsa-utils] alsaloop falls into loop after SIGCONT
by Dimitrios Semitsoglou-Tsiapos 19 Aug '17

19 Aug '17

Hello everyone, I've ran into some issues while writing a wrapper around alsaloop. It's possible to make it fall into infinite loops of silence. Here is how to trigger one such loop: alsaloop -C cloop -P Audio -t 100000 -v... & # Read attached asoundrc sleep 2 mpc play pkill -STOP -x alsaloop; sleep 0.1; pkill -CONT -x alsaloop On the great majority of times, this happens: ... pool took 68171us playback hw:Audio/capture cloop: pollfds handle playback hw:Audio: delay 2160 / 38400 / 0 capture cloop: delay 15120 / 38400 / 0 playback hw:Audio/capture cloop: prevents = 0x4, crevents = 0x0 playback hw:Audio/capture cloop: queued 5040/18000 samples playback hw:Audio: end delay 5040 / 38400 / 0 capture cloop: end delay 18000 / 38400 / 0 playback hw:Audio/capture cloop: processing time 69us pool took 192670us playback hw:Audio/capture cloop: pollfds handle playback hw:Audio: delay error: Broken pipe / 38400 / 0 capture cloop: delay 8400 / 38400 / 0 playback hw:Audio/capture cloop: prevents = 0xc, crevents = 0x1 underrun for playback hw:Audio playback hw:Audio/capture cloop: xrun sync 0 1 sync: cdelay=18000(18000), pdelay=9600(9600), fill=4800 (delay=27600), src_out=0 sync: cbufcount=9600, pbufcount=9600 sync: capt stop removed 9600 samples playback hw:Audio/capture cloop: xrun sync 0 1 sync: cdelay=18000(18000), pdelay=0(0), fill=4800 (delay=18000), src_out=0 sync: cbufcount=0, pbufcount=0 sync: capt stop removed 0 samples playback hw:Audio/capture cloop: xrun sync 0 1 sync: cdelay=18000(18000), pdelay=0(0), fill=4800 (delay=18000), src_out=0 sync: cbufcount=0, pbufcount=0 sync: capt stop removed 0 samples playback hw:Audio/capture cloop: xrun sync 0 1 ... Moving outwards, some observations, * `remove_samples()` falls into `if (loop->play->buf == loop->capt->buf)`, which is what decides to always remove 0 samples after some point (as seen in output). * cdelay (from `snd_pcm_delay(capt->handle, &cdelay)`) is consistently 18000, meaning that `delay1 > fill` in `xrun_sync()` will always be true as `fill` is fixed during the run. If one forces this check to fail (by setting cdelay to 0), alsaloop recovers, with no audible delay compared to what's being played back. * It is this code that leads to `xrun()` in the first place: if (avail == -EPIPE) { if ((err = xrun(lhandle)) < 0) * The issue is hinted even earlier, as after err = snd_pcm_poll_descriptors_revents(play->handle, fds, play->pollfd_count, &prevents); `(prevents & POLLERR)` is true. * Depending on when STOP is sent, the same sometimes holds true after `thread_job1`'s err = poll(pfds, j, wake); on `pfds[i].revents`. I am not sure what the correct way of fixing this is, especially because I couldn't figure out why `snd_pcm_delay` returns this specific value. I can only guess it is related to aloop. Other ways of throwing alsaloop into infinite loops is unplugging a soundcard that it's using (I believe it should exit in this case) and suspending/resuming the system. I haven't gone through the codepaths in those cases carefully yet, but I'm interested in fixing them eventually. Please let me know if I can provide more useful output, Dimitri [alsa-info.sh]http://www.alsa-project.org/db/?f=89eb0056b0876a3b4fb377c39d5b…

1 0

[alsa-devel] [PATCH 00/13] constify alsa snd_pcm_ops structures
by Arvind Yadav 19 Aug '17

19 Aug '17

snd_pcm_ops are not supposed to change at runtime. All functions working with snd_pcm_ops provided by <sound/pcm.h> work with const snd_pcm_ops. So mark the non-const structs as const. Arvind Yadav (13): [PATCH 01/13] ALSA: aoa: constify snd_pcm_ops structures [PATCH 02/13] ALSA: arm: constify snd_pcm_ops structures [PATCH 03/13] ALSA: atmel: constify snd_pcm_ops structures [PATCH 04/13] ALSA: drivers: constify snd_pcm_ops structures [PATCH 05/13] ALSA: firewire: constify snd_pcm_ops structures [PATCH 06/13] ALSA: mips: constify snd_pcm_ops structures [PATCH 07/13] ALSA: parisc: constify snd_pcm_ops structures [PATCH 08/13] ALSA: pcmcia: constify snd_pcm_ops structures [PATCH 09/13] ALSA: ppc: constify snd_pcm_ops structures [PATCH 10/13] ALSA: sh: constify snd_pcm_ops structures [PATCH 11/13] ALSA: sparc: constify snd_pcm_ops structures [PATCH 12/13] ALSA: spi: constify snd_pcm_ops structures [PATCH 13/13] ALSA: usb: constify snd_pcm_ops structures sound/aoa/soundbus/i2sbus/pcm.c | 4 +- sound/arm/aaci.c | 4 +- sound/arm/pxa2xx-pcm.c | 2 +- sound/atmel/ac97c.c | 4 +- sound/drivers/aloop.c | 4 +- sound/drivers/ml403-ac97cr.c | 4 +- sound/firewire/isight.c | 2 +- sound/firewire/motu/motu-pcm.c | 4 +- sound/mips/hal2.c | 4 +- sound/mips/sgio2audio.c | 6 +- sound/parisc/harmony.c | 4 +- sound/pcmcia/pdaudiocf/pdaudiocf_pcm.c | 2 +- sound/ppc/pmac.c | 4 +- sound/ppc/snd_ps3.c | 2 +- sound/sh/aica.c | 2 +- sound/sh/sh_dac_audio.c | 2 +- sound/sparc/amd7930.c | 4 +- sound/sparc/cs4231.c | 4 +- sound/sparc/dbri.c | 2 +- sound/spi/at73c213.c | 2 +- sound/usb/6fire/pcm.c | 2 +- sound/usb/caiaq/audio.c | 2 +- sound/usb/hiface/pcm.c | 2 +- sound/usb/misc/ua101.c | 4 +- sound/usb/pcm.c | 4 +- sound/usb/usx2y/usbusx2yaudio.c | 2 +- sound/usb/usx2y/usx2yhwdeppcm.c | 2 +- 27 files changed, 42 insertions(+), 42 deletions(-) -- 1.9.1

2 14