July 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v2 0/2] ASoC: Intel: Add Kabylake machine driver for RT5663
by Kevin Cheng 28 Jul '17

28 Jul '17

Add kabylake machine driver & corresponding driver entry in machine table for rt5663 codec. For this particular machine, the RT5663 is a headset codec connected on ssp1. there is no dmic and speaker connected. Modify the machine driver in kbl_rt5663_max98927 to reuse the common codes. V2: adjust the code order. Kevin Cheng (2): ASoC: Intel: Add Kabylake machine driver for RT5663 ASoC: Intel: Add Kabylake RT5663 machine driver entry sound/soc/intel/boards/kbl_rt5663_max98927.c | 246 +++++++++++++++++++++++---- sound/soc/intel/skylake/skl.c | 5 + 2 files changed, 214 insertions(+), 37 deletions(-) -- 2.12.2

3 4

[alsa-devel] [PATCH 0/2] ASoC: Intel: Add Kabylake machine driver for RT5663
by Kevin Cheng 28 Jul '17

28 Jul '17

Add kabylake machine driver & corresponding driver entry in machine table for rt5663 codec. For this particular machine, the RT5663 is a headset codec connected on ssp1. there is no dmic and speaker connected. Modify the machine driver to kbl_rt5663_max98927 to reuse the common codes. Kevin Cheng (2): ASoC: Intel: Add Kabylake machine driver for RT5663 ASoC: Intel: Add Kabylake RT5663 machine driver entry sound/soc/intel/boards/kbl_rt5663_max98927.c | 246 +++++++++++++++++++++++---- sound/soc/intel/skylake/skl.c | 5 + 2 files changed, 214 insertions(+), 37 deletions(-) -- 1.9.1

2 3

[alsa-devel] [RFT 1/2] ASoC: samsung: Fix possible double iounmap on s3c24xx driver probe failure
by Krzysztof Kozlowski 28 Jul '17

28 Jul '17

Commit 87b132bc0315 ("ASoC: samsung: s3c24{xx,12}-i2s: port to use generic dmaengine API") moved ioremap() call from s3c-i2s-v2.c:s3c_i2sv2_probe() to s3c2412-i2s.c:s3c2412_iis_dev_probe() and converted it to devm- resource managed interface. However the error path in first of them - s3c_i2sv2_probe() - was not updated. If getting a iis clock in s3c_i2sv2_probe() failed, the address space would be unmapped there. This could lead to: 1. double iounmap() later from devm-interface of s3c2412_iis_dev_probe()), 2. accessing the memory by other functions in s3c2412-i2s.c unit. Anyway, the owner of this mapped region should be s3c2412-i2s.c because it starts the mapping. Affected are drivers for S3C24xx family although issue was not reproduced. Fixes: 87b132bc0315 ("ASoC: samsung: s3c24{xx,12}-i2s: port to use generic dmaengine API") Signed-off-by: Krzysztof Kozlowski <krzk(a)kernel.org> --- Not marking as Cc-stable because this is theoretical problem, not reproduced and also not tested. Please, kindly test on S3C24xx hardware. --- sound/soc/samsung/s3c-i2s-v2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/samsung/s3c-i2s-v2.c b/sound/soc/samsung/s3c-i2s-v2.c index ca522a95160b..9b28046eea8e 100644 --- a/sound/soc/samsung/s3c-i2s-v2.c +++ b/sound/soc/samsung/s3c-i2s-v2.c @@ -634,7 +634,6 @@ int s3c_i2sv2_probe(struct snd_soc_dai *dai, i2s->iis_pclk = clk_get(dev, "iis"); if (IS_ERR(i2s->iis_pclk)) { dev_err(dev, "failed to get iis_clock\n"); - iounmap(i2s->regs); return -ENOENT; } -- 2.11.0

3 5

[alsa-devel] [RFT v2 0/3] ASoC: samsung: s3c24xx: Fixes for error paths
by Krzysztof Kozlowski 28 Jul '17

28 Jul '17

Hi, Changes since v1: 1. Add patch 2/3. 2. Drop assignment of iis_cclk=iis_pclk to have balance with clk disables error and remove paths (pointed by Arvind). Best regards, Krzysztof Krzysztof Kozlowski (3): ASoC: samsung: Fix possible double iounmap on s3c24xx driver probe failure ASoC: samsung: Add missing prepare for iis clock of s3c24xx ASoC: samsung: Add proper error paths to s3c24xx I2S driver sound/soc/samsung/s3c-i2s-v2.c | 12 ++++++++++-- sound/soc/samsung/s3c-i2s-v2.h | 7 +++++++ sound/soc/samsung/s3c2412-i2s.c | 13 +++++++++---- 3 files changed, 26 insertions(+), 6 deletions(-) -- 2.11.0

3 10

[alsa-devel] [PATCH] ASoC: rsnd: merge snd_pcm_ops::open and snd_soc_dai_ops::startup
by Kuninori Morimoto 28 Jul '17

28 Jul '17

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> Current rsnd driver has snd_pcm_ops::open and snd_soc_dai_ops::startup, but, these are called from soc_pcm_open in same time. This patch merge these into rsnd_soc_dai_startup() Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/sh/rcar/core.c | 80 +++++++++++++++++++----------------------------- 1 file changed, 31 insertions(+), 49 deletions(-) diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c index 8dcf1a8..6fbbcbf 100644 --- a/sound/soc/sh/rcar/core.c +++ b/sound/soc/sh/rcar/core.c @@ -844,12 +844,28 @@ static int rsnd_soc_hw_rule_channels(struct snd_pcm_hw_params *params, ir, &ic); } -static void rsnd_soc_hw_constraint(struct snd_pcm_runtime *runtime, - struct snd_soc_dai *dai) +static struct snd_pcm_hardware rsnd_pcm_hardware = { + .info = SNDRV_PCM_INFO_INTERLEAVED | + SNDRV_PCM_INFO_MMAP | + SNDRV_PCM_INFO_MMAP_VALID, + .buffer_bytes_max = 64 * 1024, + .period_bytes_min = 32, + .period_bytes_max = 8192, + .periods_min = 1, + .periods_max = 32, + .fifo_size = 256, +}; + +static int rsnd_soc_dai_startup(struct snd_pcm_substream *substream, + struct snd_soc_dai *dai) { struct rsnd_dai *rdai = rsnd_dai_to_rdai(dai); + struct rsnd_priv *priv = rsnd_rdai_to_priv(rdai); + struct rsnd_dai_stream *io = rsnd_rdai_to_io(rdai, substream); struct snd_pcm_hw_constraint_list *constraint = &rdai->constraint; + struct snd_pcm_runtime *runtime = substream->runtime; unsigned int max_channels = rsnd_rdai_channels_get(rdai); + int ret; int i; /* @@ -866,34 +882,26 @@ static void rsnd_soc_hw_constraint(struct snd_pcm_runtime *runtime, constraint->count = i + 1; } + snd_soc_set_runtime_hwparams(substream, &rsnd_pcm_hardware); + snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS, constraint); + snd_pcm_hw_constraint_integer(runtime, + SNDRV_PCM_HW_PARAM_PERIODS); + /* * Sampling Rate / Channel Limitation * It depends on Clock Master Mode */ - if (!rsnd_rdai_is_clk_master(rdai)) - return; - - snd_pcm_hw_rule_add(runtime, 0, SNDRV_PCM_HW_PARAM_RATE, - rsnd_soc_hw_rule_rate, dai, - SNDRV_PCM_HW_PARAM_CHANNELS, -1); - snd_pcm_hw_rule_add(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS, - rsnd_soc_hw_rule_channels, dai, - SNDRV_PCM_HW_PARAM_RATE, -1); -} - -static int rsnd_soc_dai_startup(struct snd_pcm_substream *substream, - struct snd_soc_dai *dai) -{ - struct rsnd_dai *rdai = rsnd_dai_to_rdai(dai); - struct rsnd_priv *priv = rsnd_rdai_to_priv(rdai); - struct rsnd_dai_stream *io = rsnd_rdai_to_io(rdai, substream); - int ret; - - /* rsnd_io_to_runtime() is not yet enabled here */ - rsnd_soc_hw_constraint(substream->runtime, dai); + if (rsnd_rdai_is_clk_master(rdai)) { + snd_pcm_hw_rule_add(runtime, 0, SNDRV_PCM_HW_PARAM_RATE, + rsnd_soc_hw_rule_rate, dai, + SNDRV_PCM_HW_PARAM_CHANNELS, -1); + snd_pcm_hw_rule_add(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS, + rsnd_soc_hw_rule_channels, dai, + SNDRV_PCM_HW_PARAM_RATE, -1); + } /* * call rsnd_dai_call without spinlock @@ -1105,31 +1113,6 @@ static int rsnd_dai_probe(struct rsnd_priv *priv) /* * pcm ops */ -static struct snd_pcm_hardware rsnd_pcm_hardware = { - .info = SNDRV_PCM_INFO_INTERLEAVED | - SNDRV_PCM_INFO_MMAP | - SNDRV_PCM_INFO_MMAP_VALID, - .buffer_bytes_max = 64 * 1024, - .period_bytes_min = 32, - .period_bytes_max = 8192, - .periods_min = 1, - .periods_max = 32, - .fifo_size = 256, -}; - -static int rsnd_pcm_open(struct snd_pcm_substream *substream) -{ - struct snd_pcm_runtime *runtime = substream->runtime; - int ret = 0; - - snd_soc_set_runtime_hwparams(substream, &rsnd_pcm_hardware); - - ret = snd_pcm_hw_constraint_integer(runtime, - SNDRV_PCM_HW_PARAM_PERIODS); - - return ret; -} - static int rsnd_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *hw_params) { @@ -1159,7 +1142,6 @@ static snd_pcm_uframes_t rsnd_pointer(struct snd_pcm_substream *substream) } static struct snd_pcm_ops rsnd_pcm_ops = { - .open = rsnd_pcm_open, .ioctl = snd_pcm_lib_ioctl, .hw_params = rsnd_hw_params, .hw_free = snd_pcm_lib_free_pages, -- 1.9.1

2 1

[alsa-devel] [PATCH v3 0/3] ASoC: Intel: Fixes in Kabylake machine driver for clear playback and recording
by Harsha Priya 28 Jul '17

28 Jul '17

This patch series includes fixes for clean playback and recording in kabylake machine driver. It fixes the below issues in the corresponding patches and the details of each fix is provided in the patch's commit message. 1. Fix cracking noise in rt5663 headphones 2. Fix pop noise of dmic recording 3. Enable 4 slot IV feedback for maxim amps Harsha Priya (3): ASoC: Intel: Fix cracking noise in rt5663 headphones for kabylake platform ASoC: Intel: Fix pop noise of dmic recording in kabylake platform using rt5514 ASoC: Intel: Enabling 4 slot IV feedback for max98927 on Kabylake platform .../soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 28 +++++++++++----------- 1 file changed, 14 insertions(+), 14 deletions(-) -- 1.9.1

2 4

[alsa-devel] [PATCH v2 0/2] ASoC: Intel: Add Kabylake machine driver for RT5663
by Kevin Cheng 28 Jul '17

28 Jul '17

Add kabylake machine driver & corresponding driver entry in machine table for rt5663 codec. For this particular machine, the RT5663 is a headset codec connected on ssp1. there is no dmic and speaker connected. Modify the machine driver in kbl_rt5663_max98927 to reuse the common codes. V2: adjust the code order. Kevin Cheng (2): ASoC: Intel: Add Kabylake machine driver for RT5663 ASoC: Intel: Add Kabylake RT5663 machine driver entry sound/soc/intel/boards/kbl_rt5663_max98927.c | 246 +++++++++++++++++++++++---- sound/soc/intel/skylake/skl.c | 5 + 2 files changed, 214 insertions(+), 37 deletions(-) -- 2.12.2

2 3

[alsa-devel] [PATCH v1 0/3] add jack detection to MSM8916 analog
by Damien Riegel 27 Jul '17

27 Jul '17

This series adds support for the MBHC (Multi-Button Headset Control) of the PM8916's analog codec. This IP is capable to identify up to five buttons on a headset, but for now only the jack detection is supported. A complete implementation exists in the Android kernel, but it's quite complex and I'd rather go step by step. First patch fixes a define that is squatting a bit used by the MBHC. Second patch is the actual implementation of the jack detection, and third patch plugs the jack detection in the sound card driver. Damien Riegel (3): ASoC: codecs: msm8916-analog: fix DIG_CLK_CTL_RXD3_CLK_EN define ASoC: codecs: msm8916-analog: support jack detection ASoC: qcom: apq8016-sbc: enable jack detection sound/soc/codecs/msm8916-wcd-analog.c | 105 +++++++++++++++++++++++++++++++++- sound/soc/codecs/msm8916-wcd-analog.h | 18 ++++++ sound/soc/qcom/apq8016_sbc.c | 16 ++++++ 3 files changed, 138 insertions(+), 1 deletion(-) create mode 100644 sound/soc/codecs/msm8916-wcd-analog.h -- 2.13.3

3 10

[alsa-devel] [PATCH v3 0/2] Add support for TI TAS6424 digital amplifier
by Michael Stecklein 27 Jul '17

27 Jul '17

Hello all, This two-patch series adds the dt bindings, driver, and other related changes for the TAS6424 digital amplifier. I am upstreaming this driver on behalf of Andreas. Regards, Michael Stecklein <m-stecklein(a)ti.com> Changes since v2: - fixed binding as per Rob Herring's comments on v2 Changes since v1: - rebased on 4.13-rc1 Original v1 patches: - https://patchwork.kernel.org/patch/9795235/ - https://patchwork.kernel.org/patch/9795237/ Andreas Dannenberg (1): ASoC: add support for TAS6424 digital amplifier Michael Stecklein (1): dt-bindings: sound: add bindings for TAS6424 .../devicetree/bindings/sound/ti,tas6424.txt | 28 + sound/soc/codecs/Kconfig | 8 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/tas6424.c | 755 +++++++++++++++++++++ sound/soc/codecs/tas6424.h | 127 ++++ 5 files changed, 920 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ti,tas6424.txt create mode 100644 sound/soc/codecs/tas6424.c create mode 100644 sound/soc/codecs/tas6424.h -- 2.7.4

3 6

[alsa-devel] [PATCH v3 00/17] Add support for Cirrus Logic CS47L35/L85/L90/L91 codecs
by Richard Fitzgerald 27 Jul '17

27 Jul '17

The Cirrus Logic CS47L35, CS47L85, CS47L90/91 codecs are complex audio SoC devices. In addition to the core audio capability they have onboard GPIO, regulators, DSPs and interrupt controller and a large register map space accessed over SPI or I2C. This family of codecs is based around common IP blocks and they are managed by a set of common drivers referred to as "Madera". Summary of main changes since V1: - Removed child DT nodes and of_compatibles to make the DT flat - Fixed review comments on irqchip driver - Used new field names for IRQ1_STATUS_33 register - Moved the gpio driver bindings into the main MFD binding doc - Some code improvements to the pinctrl driver Richard Fitzgerald (17): mfd: madera: Add register definitions for Cirrus Logic Madera codecs mfd: madera: Add DT bindings for Cirrus Logic Madera codecs mfd: madera: Add common support for Cirrus Logic Madera codecs mfd: madera: Register map tables for Cirrus Logic CS47L35 mfd: madera: Register map tables for Cirrus Logic CS47L85 mfd: madera: Register map tables for Cirrus Logic CS47L90/91 regulator: arizona-micsupp: Add support for Cirrus Logic Madera codecs regulator: arizona-ldo1: Add support for Cirrus Logic Madera codecs irqchip: Add driver for Cirrus Logic Madera codecs pinctrl: madera: Add DT bindings for Cirrus Logic Madera codecs pinctrl: madera: Add driver for Cirrus Logic Madera codecs gpio: madera: Support Cirrus Logic Madera class codecs ASoC: madera: Add DT bindings for Cirrus Logic Madera codecs ASoC: madera: Add common support for Cirrus Logic Madera codecs ASoC: cs47l35: Add codec driver for Cirrus Logic CS47L35 ASoC: cs47l85: Add codec driver for Cirrus Logic CS47L85 ASoC: cs47l90: Add codec driver for Cirrus Logic CS47L90 Documentation/devicetree/bindings/mfd/madera.txt | 102 + .../bindings/pinctrl/cirrus,madera-pinctrl.txt | 99 + .../bindings/regulator/arizona-regulator.txt | 3 +- Documentation/devicetree/bindings/sound/madera.txt | 67 + MAINTAINERS | 23 + drivers/gpio/Kconfig | 6 + drivers/gpio/Makefile | 1 + drivers/gpio/gpio-madera.c | 196 + drivers/irqchip/Kconfig | 3 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-madera.c | 301 + drivers/mfd/Kconfig | 46 + drivers/mfd/Makefile | 13 + drivers/mfd/cs47l35-tables.c | 1688 ++++ drivers/mfd/cs47l85-tables.c | 3169 +++++++ drivers/mfd/cs47l90-tables.c | 2830 +++++++ drivers/mfd/madera-core.c | 632 ++ drivers/mfd/madera-i2c.c | 131 + drivers/mfd/madera-spi.c | 132 + drivers/mfd/madera.h | 52 + drivers/pinctrl/Kconfig | 1 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/cirrus/Kconfig | 15 + drivers/pinctrl/cirrus/Makefile | 11 + drivers/pinctrl/cirrus/pinctrl-cs47l35.c | 46 + drivers/pinctrl/cirrus/pinctrl-cs47l85.c | 60 + drivers/pinctrl/cirrus/pinctrl-cs47l90.c | 58 + drivers/pinctrl/cirrus/pinctrl-madera.c | 1074 +++ drivers/pinctrl/cirrus/pinctrl-madera.h | 40 + drivers/regulator/Kconfig | 15 +- drivers/regulator/arizona-ldo1.c | 82 +- drivers/regulator/arizona-micsupp.c | 71 +- include/dt-bindings/sound/madera.h | 27 + include/linux/irqchip/irq-madera-pdata.h | 23 + include/linux/irqchip/irq-madera.h | 96 + include/linux/mfd/madera/core.h | 180 + include/linux/mfd/madera/pdata.h | 61 + include/linux/mfd/madera/registers.h | 8832 ++++++++++++++++++++ include/sound/madera-pdata.h | 61 + sound/soc/codecs/Kconfig | 23 + sound/soc/codecs/Makefile | 8 + sound/soc/codecs/cs47l35.c | 1747 ++++ sound/soc/codecs/cs47l85.c | 2706 ++++++ sound/soc/codecs/cs47l90.c | 2645 ++++++ sound/soc/codecs/madera.c | 4430 ++++++++++ sound/soc/codecs/madera.h | 470 ++ 46 files changed, 32268 insertions(+), 10 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/madera.txt create mode 100644 Documentation/devicetree/bindings/pinctrl/cirrus,madera-pinctrl.txt create mode 100644 Documentation/devicetree/bindings/sound/madera.txt create mode 100644 drivers/gpio/gpio-madera.c create mode 100644 drivers/irqchip/irq-madera.c create mode 100644 drivers/mfd/cs47l35-tables.c create mode 100644 drivers/mfd/cs47l85-tables.c create mode 100644 drivers/mfd/cs47l90-tables.c create mode 100644 drivers/mfd/madera-core.c create mode 100644 drivers/mfd/madera-i2c.c create mode 100644 drivers/mfd/madera-spi.c create mode 100644 drivers/mfd/madera.h create mode 100644 drivers/pinctrl/cirrus/Kconfig create mode 100644 drivers/pinctrl/cirrus/Makefile create mode 100644 drivers/pinctrl/cirrus/pinctrl-cs47l35.c create mode 100644 drivers/pinctrl/cirrus/pinctrl-cs47l85.c create mode 100644 drivers/pinctrl/cirrus/pinctrl-cs47l90.c create mode 100644 drivers/pinctrl/cirrus/pinctrl-madera.c create mode 100644 drivers/pinctrl/cirrus/pinctrl-madera.h create mode 100644 include/dt-bindings/sound/madera.h create mode 100644 include/linux/irqchip/irq-madera-pdata.h create mode 100644 include/linux/irqchip/irq-madera.h create mode 100644 include/linux/mfd/madera/core.h create mode 100644 include/linux/mfd/madera/pdata.h create mode 100644 include/linux/mfd/madera/registers.h create mode 100644 include/sound/madera-pdata.h create mode 100644 sound/soc/codecs/cs47l35.c create mode 100644 sound/soc/codecs/cs47l85.c create mode 100644 sound/soc/codecs/cs47l90.c create mode 100644 sound/soc/codecs/madera.c create mode 100644 sound/soc/codecs/madera.h -- 1.9.1

7 42