June 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ALSA: hda - Fix doubly initialization of i915 component
by Takashi Iwai 29 Jun '17

29 Jun '17

In the commit fcc88d91cd36 ("ALSA: hda - Bind with i915 component before codec binding"), the binding with i915 audio component is moved to be performed always at probing the controller. This fixed the potential problems on IVB, but now it brought another issue on HSW and BDW. These two platforms give two individual HD-audio controllers, one for the analog codec on PCH and another for HDMI over gfx. Since I decided to take a lazy path to check only AZX_DRIVER_PCH type in the commit above, now both controllers try to bind with i915, and you see a kernel WARNING. This patch tries to address it again properly. Now a new DCAPS bit, AZX_DCAPS_I915_COMPONENT, is introduced for indicating the binding with i915 component in addition to the existing I915_POWERWELL bit flag. Each PCI entry has to give this new flag if it requires the binding with i915 component. For HSW/BDW PCH (i.e. the ones defined by AZX_DCAPS_INTEL_PCH) doesn't contain AZX_DCAPS_I915_COMPONENT bit while others have it. While we're at it, add parentheses around the bit flag check for avoiding possible compiler warnings, too. The bug was spotted by Intel CI tests. Fixes: fcc88d91cd36 ("ALSA: hda - Bind with i915 component before codec binding") Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196219 Reported-by: Martin Peres <martin.peres(a)free.fr> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/hda_controller.h | 6 +++++- sound/pci/hda/hda_intel.c | 40 ++++++++++++++++++++++------------------ 2 files changed, 27 insertions(+), 19 deletions(-) diff --git a/sound/pci/hda/hda_controller.h b/sound/pci/hda/hda_controller.h index 35a9ab2cac46..a68e75b00ea3 100644 --- a/sound/pci/hda/hda_controller.h +++ b/sound/pci/hda/hda_controller.h @@ -32,7 +32,11 @@ #define AZX_DCAPS_NO_MSI (1 << 9) /* No MSI support */ #define AZX_DCAPS_SNOOP_MASK (3 << 10) /* snoop type mask */ #define AZX_DCAPS_SNOOP_OFF (1 << 12) /* snoop default off */ -/* 13 unused */ +#ifdef CONFIG_SND_HDA_I915 +#define AZX_DCAPS_I915_COMPONENT (1 << 13) /* bind with i915 gfx */ +#else +#define AZX_DCAPS_I915_COMPONENT 0 /* NOP */ +#endif /* 14 unused */ #define AZX_DCAPS_CTX_WORKAROUND (1 << 15) /* X-Fi workaround */ #define AZX_DCAPS_POSFIX_LPIB (1 << 16) /* Use LPIB as default */ diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index a157582b8f2c..03e34edc8f24 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -293,38 +293,43 @@ enum { (AZX_DCAPS_NO_ALIGN_BUFSIZE | AZX_DCAPS_COUNT_LPIB_DELAY |\ AZX_DCAPS_SNOOP_TYPE(SCH)) -/* PCH up to IVB; no runtime PM */ +/* PCH up to IVB; no runtime PM; bind with i915 gfx */ #define AZX_DCAPS_INTEL_PCH_NOPM \ - (AZX_DCAPS_INTEL_PCH_BASE) + (AZX_DCAPS_INTEL_PCH_BASE | AZX_DCAPS_I915_COMPONENT) /* PCH for HSW/BDW; with runtime PM */ +/* no i915 binding for this as HSW/BDW has another controller for HDMI */ #define AZX_DCAPS_INTEL_PCH \ (AZX_DCAPS_INTEL_PCH_BASE | AZX_DCAPS_PM_RUNTIME) /* HSW HDMI */ #define AZX_DCAPS_INTEL_HASWELL \ (/*AZX_DCAPS_ALIGN_BUFSIZE |*/ AZX_DCAPS_COUNT_LPIB_DELAY |\ - AZX_DCAPS_PM_RUNTIME | AZX_DCAPS_I915_POWERWELL |\ - AZX_DCAPS_SNOOP_TYPE(SCH)) + AZX_DCAPS_PM_RUNTIME | AZX_DCAPS_I915_COMPONENT |\ + AZX_DCAPS_I915_POWERWELL | AZX_DCAPS_SNOOP_TYPE(SCH)) /* Broadwell HDMI can't use position buffer reliably, force to use LPIB */ #define AZX_DCAPS_INTEL_BROADWELL \ (/*AZX_DCAPS_ALIGN_BUFSIZE |*/ AZX_DCAPS_POSFIX_LPIB |\ - AZX_DCAPS_PM_RUNTIME | AZX_DCAPS_I915_POWERWELL |\ - AZX_DCAPS_SNOOP_TYPE(SCH)) + AZX_DCAPS_PM_RUNTIME | AZX_DCAPS_I915_COMPONENT |\ + AZX_DCAPS_I915_POWERWELL | AZX_DCAPS_SNOOP_TYPE(SCH)) #define AZX_DCAPS_INTEL_BAYTRAIL \ - (AZX_DCAPS_INTEL_PCH_NOPM | AZX_DCAPS_I915_POWERWELL) + (AZX_DCAPS_INTEL_PCH_BASE | AZX_DCAPS_I915_COMPONENT |\ + AZX_DCAPS_I915_POWERWELL) #define AZX_DCAPS_INTEL_BRASWELL \ - (AZX_DCAPS_INTEL_PCH | AZX_DCAPS_I915_POWERWELL) + (AZX_DCAPS_INTEL_PCH_BASE | AZX_DCAPS_PM_RUNTIME |\ + AZX_DCAPS_I915_COMPONENT | AZX_DCAPS_I915_POWERWELL) #define AZX_DCAPS_INTEL_SKYLAKE \ - (AZX_DCAPS_INTEL_PCH | AZX_DCAPS_SEPARATE_STREAM_TAG |\ + (AZX_DCAPS_INTEL_PCH_BASE | AZX_DCAPS_PM_RUNTIME |\ + AZX_DCAPS_SEPARATE_STREAM_TAG | AZX_DCAPS_I915_COMPONENT |\ AZX_DCAPS_I915_POWERWELL) #define AZX_DCAPS_INTEL_BROXTON \ - (AZX_DCAPS_INTEL_PCH | AZX_DCAPS_SEPARATE_STREAM_TAG |\ + (AZX_DCAPS_INTEL_PCH_BASE | AZX_DCAPS_PM_RUNTIME |\ + AZX_DCAPS_SEPARATE_STREAM_TAG | AZX_DCAPS_I915_COMPONENT |\ AZX_DCAPS_I915_POWERWELL) /* quirks for ATI SB / AMD Hudson */ @@ -1008,7 +1013,7 @@ static int azx_suspend(struct device *dev) if (chip->msi) pci_disable_msi(chip->pci); - if (chip->driver_caps & AZX_DCAPS_I915_POWERWELL + if ((chip->driver_caps & AZX_DCAPS_I915_POWERWELL) && hda->need_i915_power) snd_hdac_display_power(bus, false); @@ -1114,7 +1119,7 @@ static int azx_runtime_suspend(struct device *dev) azx_stop_chip(chip); azx_enter_link_reset(chip); azx_clear_irq_pending(chip); - if (chip->driver_caps & AZX_DCAPS_I915_POWERWELL + if ((chip->driver_caps & AZX_DCAPS_I915_POWERWELL) && hda->need_i915_power) snd_hdac_display_power(azx_bus(chip), false); @@ -1380,8 +1385,7 @@ static int azx_free(struct azx *chip) if (hda->need_i915_power) snd_hdac_display_power(bus, false); } - if (chip->driver_type == AZX_DRIVER_PCH || - (chip->driver_caps & AZX_DCAPS_I915_POWERWELL)) + if (chip->driver_type & AZX_DCAPS_I915_COMPONENT) snd_hdac_i915_exit(bus); kfree(hda); @@ -2199,8 +2203,7 @@ static int azx_probe_continue(struct azx *chip) hda->probe_continued = 1; /* bind with i915 if needed */ - if (chip->driver_type == AZX_DRIVER_PCH || - (chip->driver_caps & AZX_DCAPS_I915_POWERWELL)) { + if (chip->driver_caps & AZX_DCAPS_I915_COMPONENT) { err = snd_hdac_i915_init(bus); if (err < 0) { /* if the controller is bound only with HDMI/DP @@ -2214,7 +2217,8 @@ static int azx_probe_continue(struct azx *chip) goto out_free; } else { /* don't bother any longer */ - chip->driver_caps &= ~AZX_DCAPS_I915_POWERWELL; + chip->driver_caps &= + ~(AZX_DCAPS_I915_COMPONENT | AZX_DCAPS_I915_POWERWELL); } } } @@ -2279,7 +2283,7 @@ static int azx_probe_continue(struct azx *chip) pm_runtime_put_autosuspend(&pci->dev); out_free: - if (chip->driver_caps & AZX_DCAPS_I915_POWERWELL + if ((chip->driver_caps & AZX_DCAPS_I915_POWERWELL) && !hda->need_i915_power) snd_hdac_display_power(bus, false); -- 2.13.2

1 0

[alsa-devel] Make snd_card_free() a no-op again for NULL ptr argument
by Delio Brignoli 29 Jun '17

29 Jun '17

Hello Takashi, Commit “ALSA: Use standard device refcount for card accounting” <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/s…> changed the behaviour of snd_card_free() in case of a NULL ptr argument. Before f24640648186b59bd39f8cd640d631bdb61a3197 snd_card_free() was a no-op in case of a NULL ptr argument as I would expect for a *_free() function. Currently passing a NULL ptr results in a NULL ptr dereference. I believe the previous behaviour is worth restoring. If you agree I’ll follow up with a patch. Thank you. — Delio

2 2

Re: [alsa-devel] Add headset mode for new Dell machine
by Takashi Iwai 29 Jun '17

29 Jun '17

On Thu, 29 Jun 2017 09:43:22 +0200, Kailang wrote: > > Hi Takashi, > > Attach patch was for Add headset mode for new Dell machine. > Many Thanks. Applied, thanks. Takashi

1 0

[alsa-devel] [PATCH 0/4] ASoC: rt5645: GPD Win jack support
by Takashi Iwai 29 Jun '17

29 Jun '17

Hi, this is a patchset containing the fixes for the inverted jack detection on RT5645 codec and a quirk for GPD Win device. Possibly the newer one, GPD Pocket, would work with the same quirk. First three are from Bard, and the last one is the suggested by Hans. You may notice the ugliness there, but unfortunately this is the only way to identify the machine. Blame BIOS programmer. thanks, Takashi === Bard Liao (3): ASoC: rt5645: read jd1_1 status for jd detection ASoC: rt5645: rename jd_invert flag in platform data ASoC: rt5645: add inv_jd1_1 flag Takashi Iwai (1): ASoC: rt5645: Add jack detection workaround for GPD Win include/sound/rt5645.h | 6 ++-- sound/soc/codecs/rt5645.c | 72 +++++++++++++++++++++++++++++------------------ 2 files changed, 49 insertions(+), 29 deletions(-) -- 2.13.2

5 12

[alsa-devel] [PATCH] ASoC: Drop invalid DMI fields when setting card long name from DMI info
by mengdong.lin＠linux.intel.com 29 Jun '17

29 Jun '17

From: Mengdong Lin <mengdong.lin(a)linux.intel.com> Sometimes DMI fields may be invalid and so can't give useful vendor, product or board info, such as "Type2 - Board Manufacturer" or "Type1 - TBD by OEM". Including such invalid DMI fileds may create silly card long name. So this patch creates a black list of invalid strings. And if a DMI field contains any string in this list, it will be excluded from the card long name. Signed-off-by: Mengdong Lin <mengdong.lin(a)linux.intel.com> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index cfa9cf1476f2..419b788fd801 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -69,6 +69,20 @@ static int pmdown_time = 5000; module_param(pmdown_time, int, 0); MODULE_PARM_DESC(pmdown_time, "DAPM stream powerdown time (msecs)"); +/* If a DMI filed contain strings in this blacklist (e.g. + * "Type2 - Board Manufacturer" or "Type1 - TBD by OEM"), it will be taken + * as invalid and dropped when setting the card long name from DMI info. + */ +static const char * const dmi_blacklist[] = { + "To be filled by OEM", + "TBD by OEM", + "Default String", + "Board Manufacturer", + "Board Vendor Name", + "Board Product Name", + NULL, /* terminator */ +}; + /* returns the minimum number of bytes needed to represent * a particular given value */ static int min_bytes_needed(unsigned long val) @@ -1934,6 +1948,22 @@ static void cleanup_dmi_name(char *name) name[j] = '\0'; } +/* Check if a DMI field is valid, i.e. not containing any string + * in the black list. + */ +static int is_dmi_valid(const char *field) +{ + int i = 0; + + while (dmi_blacklist[i]) { + if (strstr(field, dmi_blacklist[i])) + return 0; + i++; + }; + + return 1; +} + /** * snd_soc_set_dmi_name() - Register DMI names to card * @card: The card to register DMI names @@ -1976,17 +2006,18 @@ int snd_soc_set_dmi_name(struct snd_soc_card *card, const char *flavour) /* make up dmi long name as: vendor.product.version.board */ vendor = dmi_get_system_info(DMI_BOARD_VENDOR); - if (!vendor) { + if (!vendor || !is_dmi_valid(vendor)) { dev_warn(card->dev, "ASoC: no DMI vendor name!\n"); return 0; } + snprintf(card->dmi_longname, sizeof(card->snd_card->longname), "%s", vendor); cleanup_dmi_name(card->dmi_longname); product = dmi_get_system_info(DMI_PRODUCT_NAME); - if (product) { + if (product && is_dmi_valid(product)) { len = strlen(card->dmi_longname); snprintf(card->dmi_longname + len, longname_buf_size - len, @@ -2000,7 +2031,7 @@ int snd_soc_set_dmi_name(struct snd_soc_card *card, const char *flavour) * name in the product version field */ product_version = dmi_get_system_info(DMI_PRODUCT_VERSION); - if (product_version) { + if (product_version && is_dmi_valid(product_version)) { len = strlen(card->dmi_longname); snprintf(card->dmi_longname + len, longname_buf_size - len, @@ -2013,7 +2044,7 @@ int snd_soc_set_dmi_name(struct snd_soc_card *card, const char *flavour) } board = dmi_get_system_info(DMI_BOARD_NAME); - if (board) { + if (board && is_dmi_valid(board)) { len = strlen(card->dmi_longname); snprintf(card->dmi_longname + len, longname_buf_size - len, -- 2.11.0

4 3

[alsa-devel] [PATCH] ASoC: nau8825: change crosstalk-bypass property to bool type
by John Hsu 29 Jun '17

29 Jun '17

The property type of "nuvoton,crosstalk-bypass" changes to boolean. The document is updated as well. Signed-off-by: John Hsu <KCHSU0(a)nuvoton.com> Signed-off-by: John Hsu <supercraig0719(a)gmail.com> --- Documentation/devicetree/bindings/sound/nau8825.txt | 3 +++ sound/soc/codecs/nau8825.c | 8 ++++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/nau8825.txt b/Documentation/devicetree/bindings/sound/nau8825.txt index d337423..2f5e973 100644 --- a/Documentation/devicetree/bindings/sound/nau8825.txt +++ b/Documentation/devicetree/bindings/sound/nau8825.txt @@ -69,6 +69,8 @@ Optional properties: - nuvoton,jack-insert-debounce: number from 0 to 7 that sets debounce time to 2^(n+2) ms - nuvoton,jack-eject-debounce: number from 0 to 7 that sets debounce time to 2^(n+2) ms + - nuvoton,crosstalk-bypass: make crosstalk function bypass if set. + - clocks: list of phandle and clock specifier pairs according to common clock bindings for the clocks described in clock-names - clock-names: should include "mclk" for the MCLK master clock @@ -96,6 +98,7 @@ Example: nuvoton,short-key-debounce = <2>; nuvoton,jack-insert-debounce = <7>; nuvoton,jack-eject-debounce = <7>; + nuvoton,crosstalk-bypass; clock-names = "mclk"; clocks = <&tegra_car TEGRA210_CLK_CLK_OUT_2>; diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c index a8c7a55..46a30ea 100644 --- a/sound/soc/codecs/nau8825.c +++ b/sound/soc/codecs/nau8825.c @@ -2440,6 +2440,8 @@ static void nau8825_print_device_properties(struct nau8825 *nau8825) nau8825->jack_insert_debounce); dev_dbg(dev, "jack-eject-debounce: %d\n", nau8825->jack_eject_debounce); + dev_dbg(dev, "crosstalk-bypass: %d\n", + nau8825->xtalk_bypass); } static int nau8825_read_device_properties(struct device *dev, @@ -2504,10 +2506,8 @@ static int nau8825_read_device_properties(struct device *dev, &nau8825->jack_eject_debounce); if (ret) nau8825->jack_eject_debounce = 0; - ret = device_property_read_u32(dev, "nuvoton,crosstalk-bypass", - &nau8825->xtalk_bypass); - if (ret) - nau8825->xtalk_bypass = 1; + nau8825->xtalk_bypass = device_property_read_bool(dev, + "nuvoton,crosstalk-bypass"); nau8825->mclk = devm_clk_get(dev, "mclk"); if (PTR_ERR(nau8825->mclk) == -EPROBE_DEFER) { -- 2.6.4

1 0

[alsa-devel] [asoc:topic/rt5670 3/3] sound/soc//codecs/rt5670.c:2775:2: warning: initialization from incompatible pointer type
by kbuild test robot 29 Jun '17

29 Jun '17

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/rt5670 head: 6c28ce3c425e32d372c7c6ee98d3c3711f13ad69 commit: 6c28ce3c425e32d372c7c6ee98d3c3711f13ad69 [3/3] ASoC: rt5670: move set_sysclk to codec level config: xtensa-allmodconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 6c28ce3c425e32d372c7c6ee98d3c3711f13ad69 # save the attached .config to linux build tree make.cross ARCH=xtensa All warnings (new ones prefixed by >>): sound/soc//codecs/rt5670.c: In function 'rt5670_set_codec_sysclk': sound/soc//codecs/rt5670.c:2448:57: error: 'codec' undeclared (first use in this function) struct rt5670_priv *rt5670 = snd_soc_codec_get_drvdata(codec); ^ sound/soc//codecs/rt5670.c:2448:57: note: each undeclared identifier is reported only once for each function it appears in sound/soc//codecs/rt5670.c: At top level: >> sound/soc//codecs/rt5670.c:2775:2: warning: initialization from incompatible pointer type .set_sysclk = rt5670_set_codec_sysclk, ^ sound/soc//codecs/rt5670.c:2775:2: warning: (near initialization for 'soc_codec_dev_rt5670.set_sysclk') vim +2775 sound/soc//codecs/rt5670.c 2759 .channels_min = 1, 2760 .channels_max = 2, 2761 .rates = RT5670_STEREO_RATES, 2762 .formats = RT5670_FORMATS, 2763 }, 2764 .ops = &rt5670_aif_dai_ops, 2765 }, 2766 }; 2767 2768 static struct snd_soc_codec_driver soc_codec_dev_rt5670 = { 2769 .probe = rt5670_probe, 2770 .remove = rt5670_remove, 2771 .suspend = rt5670_suspend, 2772 .resume = rt5670_resume, 2773 .set_bias_level = rt5670_set_bias_level, 2774 .idle_bias_off = true, > 2775 .set_sysclk = rt5670_set_codec_sysclk, 2776 .component_driver = { 2777 .controls = rt5670_snd_controls, 2778 .num_controls = ARRAY_SIZE(rt5670_snd_controls), 2779 .dapm_widgets = rt5670_dapm_widgets, 2780 .num_dapm_widgets = ARRAY_SIZE(rt5670_dapm_widgets), 2781 .dapm_routes = rt5670_dapm_routes, 2782 .num_dapm_routes = ARRAY_SIZE(rt5670_dapm_routes), 2783 }, --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH] ASoC: nau8825: devicetree for crosstalk bypass
by John Hsu 29 Jun '17

29 Jun '17

Update devicetree document for crosstalk function bypass. Signed-off-by: John Hsu <KCHSU0(a)nuvoton.com> Signed-off-by: John Hsu <supercraig0719(a)gmail.com> --- Documentation/devicetree/bindings/sound/nau8825.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/nau8825.txt b/Documentation/devicetree/bindings/sound/nau8825.txt index d337423..bf4451b 100644 --- a/Documentation/devicetree/bindings/sound/nau8825.txt +++ b/Documentation/devicetree/bindings/sound/nau8825.txt @@ -69,6 +69,8 @@ Optional properties: - nuvoton,jack-insert-debounce: number from 0 to 7 that sets debounce time to 2^(n+2) ms - nuvoton,jack-eject-debounce: number from 0 to 7 that sets debounce time to 2^(n+2) ms + - nuvoton,crosstalk-bypass: make crosstalk function bypass if set 1. + - clocks: list of phandle and clock specifier pairs according to common clock bindings for the clocks described in clock-names - clock-names: should include "mclk" for the MCLK master clock @@ -96,6 +98,7 @@ Example: nuvoton,short-key-debounce = <2>; nuvoton,jack-insert-debounce = <7>; nuvoton,jack-eject-debounce = <7>; + nuvoton,crosstalk-bypass = <1>; clock-names = "mclk"; clocks = <&tegra_car TEGRA210_CLK_CLK_OUT_2>; -- 2.6.4

3 2

[alsa-devel] [asoc:topic/rt5670 3/3] sound/soc/codecs/rt5670.c:2448:57: error: 'codec' undeclared
by kbuild test robot 29 Jun '17

29 Jun '17

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/rt5670 head: 6c28ce3c425e32d372c7c6ee98d3c3711f13ad69 commit: 6c28ce3c425e32d372c7c6ee98d3c3711f13ad69 [3/3] ASoC: rt5670: move set_sysclk to codec level config: x86_64-randconfig-x002-201726 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: git checkout 6c28ce3c425e32d372c7c6ee98d3c3711f13ad69 # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): sound/soc/codecs/rt5670.c: In function 'rt5670_set_codec_sysclk': >> sound/soc/codecs/rt5670.c:2448:57: error: 'codec' undeclared (first use in this function) struct rt5670_priv *rt5670 = snd_soc_codec_get_drvdata(codec); ^~~~~ sound/soc/codecs/rt5670.c:2448:57: note: each undeclared identifier is reported only once for each function it appears in sound/soc/codecs/rt5670.c: At top level: >> sound/soc/codecs/rt5670.c:2775:16: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] .set_sysclk = rt5670_set_codec_sysclk, ^~~~~~~~~~~~~~~~~~~~~~~ sound/soc/codecs/rt5670.c:2775:16: note: (near initialization for 'soc_codec_dev_rt5670.set_sysclk') cc1: some warnings being treated as errors vim +/codec +2448 sound/soc/codecs/rt5670.c 5e8351de Bard Liao 2014-06-30 2442 return 0; 5e8351de Bard Liao 2014-06-30 2443 } 5e8351de Bard Liao 2014-06-30 2444 6c28ce3c Bard Liao 2017-06-28 2445 static int rt5670_set_codec_sysclk(struct snd_soc_dai *dai, int clk_id, 6c28ce3c Bard Liao 2017-06-28 2446 int source, unsigned int freq, int dir) 5e8351de Bard Liao 2014-06-30 2447 { 5e8351de Bard Liao 2014-06-30 @2448 struct rt5670_priv *rt5670 = snd_soc_codec_get_drvdata(codec); 5e8351de Bard Liao 2014-06-30 2449 unsigned int reg_val = 0; 5e8351de Bard Liao 2014-06-30 2450 5e8351de Bard Liao 2014-06-30 2451 switch (clk_id) { :::::: The code at line 2448 was first introduced by commit :::::: 5e8351de740d9eff26cc146a6591a4e7517496b0 ASoC: add RT5670 CODEC driver :::::: TO: Bard Liao <bardliao(a)realtek.com> :::::: CC: Mark Brown <broonie(a)linaro.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH 0/5] ASoC: add HDMI sound support for Codec
by Kuninori Morimoto 28 Jun '17

28 Jun '17

Hi Mark, Archit These supports HDMI sound for Codec. Now, SYNOPSYS dw-hdmi-i2s-audio driver is supporting HDMI I2S and is using hdmi-codec driver. Now, ALSA SoC supports OF-graph DT style, this means V4L2/ALSA SoC can share same DT bindings. But 1 issue is that ALSA SoC side needs to adjust port ID <-> Sound DAI matching. 1) - 4) are for these purpose. 1) - 4) : ASoC side patch for hdmi-codec 5) : V4L2 side patch for SYNOPSYS dw-hdmi Kuninori Morimoto (5): 1) ASoC: add snd_soc_get_dai_id() function 2) ASoC: simple-card-utils: support snd_soc_get_dai_id() 3) ASoC: hdmi-codec: remove multi detection support 4) ASoC: hdmi-codec: add .get_dai_id support 5) drm: dw-hdmi-i2s: add .get_dai_id callback for ALSA SoC .../bindings/display/bridge/renesas,dw-hdmi.txt | 9 ++- .../gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 21 +++++ include/sound/hdmi-codec.h | 9 +++ include/sound/soc.h | 3 + sound/soc/codecs/hdmi-codec.c | 91 +++------------------- sound/soc/generic/simple-card-utils.c | 9 +++ sound/soc/soc-core.c | 37 +++++++++ 7 files changed, 98 insertions(+), 81 deletions(-) -- 1.9.1

3 16