June 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v1 1/3] ASoC: rt5677: Introduce proper table for ACPI enumeration
by Andy Shevchenko 16 Jun '17

16 Jun '17

I2C devices are enumerated by IDs, and not by instances. Make it clear by using proper module device table for ACPI case. Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> --- sound/soc/codecs/rt5677.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index 65ac4518ad06..64cf6cc41ad1 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -5030,7 +5030,6 @@ static const struct regmap_config rt5677_regmap = { static const struct i2c_device_id rt5677_i2c_id[] = { { "rt5677", RT5677 }, { "rt5676", RT5676 }, - { "RT5677CE:00", RT5677 }, { } }; MODULE_DEVICE_TABLE(i2c, rt5677_i2c_id); @@ -5041,6 +5040,14 @@ static const struct of_device_id rt5677_of_match[] = { }; MODULE_DEVICE_TABLE(of, rt5677_of_match); +#ifdef CONFIG_ACPI +static const struct acpi_device_id rt5677_acpi_match[] = { + { "RT5677CE", RT5677 }, + { } +}; +MODULE_DEVICE_TABLE(acpi, rt5677_acpi_match); +#endif + static const struct acpi_gpio_params plug_det_gpio = { RT5677_GPIO_PLUG_DET, 0, false }; static const struct acpi_gpio_params mic_present_gpio = { RT5677_GPIO_MIC_PRESENT_L, 0, false }; static const struct acpi_gpio_params headphone_enable_gpio = { RT5677_GPIO_HP_AMP_SHDN_L, 0, false }; @@ -5301,6 +5308,7 @@ static struct i2c_driver rt5677_i2c_driver = { .driver = { .name = "rt5677", .of_match_table = rt5677_of_match, + .acpi_match_table = ACPI_PTR(rt5677_acpi_match), }, .probe = rt5677_i2c_probe, .remove = rt5677_i2c_remove, -- 2.11.0

2 4

[alsa-devel] [PATCH v3] ASoC: dapm: Add new widget type snd_soc_dapm_dsp_component
by Liam Girdwood 16 Jun '17

16 Jun '17

Add a new widget type to represent internal DSP components and allow DSP drivers and firmware to define topologies using this widget type. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- Takashi, I'll send a subsequent patch for alsa-lib if Mark is happy with this version. Changes V2. o No need for multiple types since core does not care. Changes v1. o Added some documentation. o Split codec widget into encoder and decoder to avoid confusion with HW CODECS. Documentation/sound/soc/dapm.rst | 4 ++++ include/sound/soc-dapm.h | 1 + include/uapi/sound/asoc.h | 3 ++- sound/soc/soc-topology.c | 1 + 4 files changed, 8 insertions(+), 1 deletion(-) diff --git a/Documentation/sound/soc/dapm.rst b/Documentation/sound/soc/dapm.rst index a27f42befa4d..540a86012e29 100644 --- a/Documentation/sound/soc/dapm.rst +++ b/Documentation/sound/soc/dapm.rst @@ -105,6 +105,10 @@ Pre Special PRE widget (exec before all others) Post Special POST widget (exec after all others) +DSP Component + Internal DSP component not used by the ASoC core but may be used + by DSP driver and DSP firmware. + (Widgets are defined in include/sound/soc-dapm.h) diff --git a/include/sound/soc-dapm.h b/include/sound/soc-dapm.h index a466f4bdc835..87133c974991 100644 --- a/include/sound/soc-dapm.h +++ b/include/sound/soc-dapm.h @@ -510,6 +510,7 @@ enum snd_soc_dapm_type { snd_soc_dapm_dai_out, snd_soc_dapm_dai_link, /* link between two DAI structures */ snd_soc_dapm_kcontrol, /* Auto-disabled kcontrol */ + snd_soc_dapm_dsp_component, /* DSP internal component */ }; enum snd_soc_dapm_subclass { diff --git a/include/uapi/sound/asoc.h b/include/uapi/sound/asoc.h index 6702533c8bd8..e805ef651538 100644 --- a/include/uapi/sound/asoc.h +++ b/include/uapi/sound/asoc.h @@ -73,7 +73,8 @@ #define SND_SOC_TPLG_DAPM_DAI_IN 13 #define SND_SOC_TPLG_DAPM_DAI_OUT 14 #define SND_SOC_TPLG_DAPM_DAI_LINK 15 -#define SND_SOC_TPLG_DAPM_LAST SND_SOC_TPLG_DAPM_DAI_LINK +#define SND_SOC_TPLG_DAPM_DSP_COMPONENT 16 +#define SND_SOC_TPLG_DAPM_LAST SND_SOC_TPLG_DAPM_DSP_COMPONENT /* Header magic number and string sizes */ #define SND_SOC_TPLG_MAGIC 0x41536F43 /* ASoC */ diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index 12e189701924..17751736957f 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -242,6 +242,7 @@ static const struct soc_tplg_map dapm_map[] = { {SND_SOC_TPLG_DAPM_DAI_IN, snd_soc_dapm_dai_in}, {SND_SOC_TPLG_DAPM_DAI_OUT, snd_soc_dapm_dai_out}, {SND_SOC_TPLG_DAPM_DAI_LINK, snd_soc_dapm_dai_link}, + {SND_SOC_TPLG_DAPM_DSP_COMPONENT, snd_soc_dapm_dsp_component}, }; static int tplc_chan_get_reg(struct soc_tplg *tplg, -- 2.11.0

3 4

[alsa-devel] [PATCH 0/4] ALSA: Follow standard EXPORT_SYMBOL() declarations
by Takashi Iwai 16 Jun '17

16 Jun '17

Hi, this is a very very trivial cleanup, to make EXPORT_SYMBOL*() declarations to follow the standard style, i.e. right after the function definition. I didn't want this kind of changes because it makes the backporting difficult in general. But recently we've changed the core stuff enough, so it's good time to stir the code for this kind of cleanups, too. thanks, Takashi === Takashi Iwai (4): ALSA: pcm: Follow standard EXPORT_SYMBOL() declarations ALSA: seq: Follow standard EXPORT_SYMBOL() declarations ALSA: timer: Follow standard EXPORT_SYMBOL() declarations ALSA: core: Follow standard EXPORT_SYMBOL() declarations sound/core/info.c | 6 ------ sound/core/info_oss.c | 1 - sound/core/init.c | 8 +------- sound/core/isadma.c | 3 --- sound/core/memalloc.c | 13 ++++--------- sound/core/memory.c | 2 -- sound/core/misc.c | 1 - sound/core/oss/mixer_oss.c | 3 +-- sound/core/pcm_lib.c | 21 --------------------- sound/core/pcm_memory.c | 6 ------ sound/core/pcm_misc.c | 11 ----------- sound/core/pcm_native.c | 7 ------- sound/core/seq/seq_clientmgr.c | 8 -------- sound/core/seq/seq_lock.c | 1 - sound/core/seq/seq_memory.c | 2 -- sound/core/seq/seq_midi_emul.c | 9 ++++----- sound/core/seq/seq_midi_event.c | 21 ++++++++------------- sound/core/seq/seq_ports.c | 2 -- sound/core/seq/seq_virmidi.c | 3 +-- sound/core/sound.c | 2 -- sound/core/sound_oss.c | 3 --- sound/core/timer.c | 27 +++++++++++++-------------- 22 files changed, 32 insertions(+), 128 deletions(-) -- 2.13.1

1 4

[alsa-devel] [PATCH 0/2] Add support for TI TAS6424 digital amplifier
by Michael Stecklein 16 Jun '17

16 Jun '17

Hello all, This two-patch series adds the dt bindings, driver, and other related changes for the TAS6424 digital amplifier. I am upstreaming this driver on behalf of Andreas. Regards, Michael Stecklein <m-stecklein(a)ti.com> Andreas Dannenberg (1): ASoC: add support for TAS6424 digital amplifier Michael Stecklein (1): dt-bindings: sound: add bindings for TAS6424 .../devicetree/bindings/sound/ti,tas6424.txt | 31 + sound/soc/codecs/Kconfig | 8 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/tas6424.c | 755 +++++++++++++++++++++ sound/soc/codecs/tas6424.h | 127 ++++ 5 files changed, 923 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ti,tas6424.txt create mode 100644 sound/soc/codecs/tas6424.c create mode 100644 sound/soc/codecs/tas6424.h -- 2.7.4

1 2

Re: [alsa-devel] Add ALC256 HP depop function
by Takashi Iwai 16 Jun '17

16 Jun '17

On Fri, 16 Jun 2017 11:14:01 +0200, Kailang wrote: > > Hi Takashi, > > This patch is support ALC256 for HP depop function. > It also could solve some ALC256 machine for plug headset cause power off issue. Thanks, applied now. Takashi

1 0

[alsa-devel] [PATCH 1/2] ALSA: hda - Apply quirks to Broxton-T, too
by Takashi Iwai 16 Jun '17

16 Jun '17

Broxton-T was a forgotten child and we didn't apply the quirks for Skylake+ properly. Meanwhile, a quirk for reducing the DMA latency seems specific to the early Broxton model, so we leave as is. Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/hda_intel.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index e3c696c46a21..01eb1dc7b5b3 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -370,11 +370,12 @@ enum { #define IS_KBL_LP(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x9d71) #define IS_KBL_H(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0xa2f0) #define IS_BXT(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x5a98) +#define IS_BXT_T(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x1a98) #define IS_GLK(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x3198) #define IS_CFL(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0xa348) -#define IS_SKL_PLUS(pci) (IS_SKL(pci) || IS_SKL_LP(pci) || IS_BXT(pci)) || \ - IS_KBL(pci) || IS_KBL_LP(pci) || IS_KBL_H(pci) || \ - IS_GLK(pci) || IS_CFL(pci) +#define IS_SKL_PLUS(pci) (IS_SKL(pci) || IS_SKL_LP(pci) || IS_BXT(pci) || \ + IS_BXT_T(pci) || IS_KBL(pci) || IS_KBL_LP(pci) || \ + IS_KBL_H(pci) || IS_GLK(pci) || IS_CFL(pci)) static char *driver_short_names[] = { [AZX_DRIVER_ICH] = "HDA Intel", -- 2.13.1

1 1

[alsa-devel] [PATCH] ALSA: hda - Add Coffelake PCI ID
by Subhransu S. Prusty 16 Jun '17

16 Jun '17

From: Megha Dey <megha.dey(a)intel.com> Coffelake is another Intel part, so need to add PCI ID for it. Signed-off-by: Megha Dey <megha.dey(a)intel.com> Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty(a)intel.com> --- sound/pci/hda/hda_intel.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 1770f085c2a6..e3c696c46a21 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -371,9 +371,10 @@ enum { #define IS_KBL_H(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0xa2f0) #define IS_BXT(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x5a98) #define IS_GLK(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x3198) +#define IS_CFL(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0xa348) #define IS_SKL_PLUS(pci) (IS_SKL(pci) || IS_SKL_LP(pci) || IS_BXT(pci)) || \ IS_KBL(pci) || IS_KBL_LP(pci) || IS_KBL_H(pci) || \ - IS_GLK(pci) + IS_GLK(pci) || IS_CFL(pci) static char *driver_short_names[] = { [AZX_DRIVER_ICH] = "HDA Intel", @@ -2378,6 +2379,9 @@ static void azx_shutdown(struct pci_dev *pci) /* Kabylake-H */ { PCI_DEVICE(0x8086, 0xa2f0), .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_SKYLAKE }, + /* Coffelake */ + { PCI_DEVICE(0x8086, 0xa348), + .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_SKYLAKE}, /* Broxton-P(Apollolake) */ { PCI_DEVICE(0x8086, 0x5a98), .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_BROXTON }, -- 1.9.1

3 7

[alsa-devel] [PATCH 0/2] ASoC: ak4613: add PCM rule
by Kuninori Morimoto 16 Jun '17

16 Jun '17

Hi Mark These patches adds hw_constraint rule to ak4613. Otherwise, Renesas platform might use un-supported sampling rate Kuninori Morimoto (2): ASoC: ak4613: add use CTRL2::CKS = 00 ASoC: ak4613: add hw_constraint rule for Sampling Rate sound/soc/codecs/ak4613.c | 72 ++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 71 insertions(+), 1 deletion(-) -- 1.9.1

2 4

[alsa-devel] [asoc:topic/rcar 36/37] sound/soc/sh/rcar/ssi.c:285:5-14: WARNING: Unsigned expression compared with zero: main_rate < 0 (fwd)
by Julia Lawall 16 Jun '17

16 Jun '17

Please check on line 285. julia ---------- Forwarded message ---------- Date: Fri, 16 Jun 2017 04:21:36 +0800 From: kbuild test robot <fengguang.wu(a)intel.com> To: kbuild(a)01.org Cc: Julia Lawall <julia.lawall(a)lip6.fr> Subject: [asoc:topic/rcar 36/37] sound/soc/sh/rcar/ssi.c:285:5-14: WARNING: Unsigned expression compared with zero: main_rate < 0 tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/rcar head: 8cc03722403a5153054993388857e4e565dcdfb1 commit: ef4cf5d6a143e04e149ad81fc491fe10855544fe [36/37] ASoC: rsnd: add rsnd_ssi_clk_query() :::::: branch date: 3 hours ago :::::: commit date: 3 hours ago >> sound/soc/sh/rcar/ssi.c:285:5-14: WARNING: Unsigned expression compared with zero: main_rate < 0 git remote add asoc https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git git remote update asoc git checkout ef4cf5d6a143e04e149ad81fc491fe10855544fe vim +285 sound/soc/sh/rcar/ssi.c e7d850dd1 Kuninori Morimoto 2015-10-26 269 if (ssi_parent_mod && !rsnd_ssi_is_parent(mod, io)) e7d850dd1 Kuninori Morimoto 2015-10-26 270 return 0; e7d850dd1 Kuninori Morimoto 2015-10-26 271 b4c83b171 Kuninori Morimoto 2015-12-17 272 if (rsnd_ssi_is_multi_slave(mod, io)) b4c83b171 Kuninori Morimoto 2015-12-17 273 return 0; b4c83b171 Kuninori Morimoto 2015-12-17 274 e7d850dd1 Kuninori Morimoto 2015-10-26 275 if (ssi->usrcnt > 1) { e7d850dd1 Kuninori Morimoto 2015-10-26 276 if (ssi->rate != rate) { e7d850dd1 Kuninori Morimoto 2015-10-26 277 dev_err(dev, "SSI parent/child should use same rate\n"); e7d850dd1 Kuninori Morimoto 2015-10-26 278 return -EINVAL; e7d850dd1 Kuninori Morimoto 2015-10-26 279 } e7d850dd1 Kuninori Morimoto 2015-10-26 280 e7d850dd1 Kuninori Morimoto 2015-10-26 281 return 0; e7d850dd1 Kuninori Morimoto 2015-10-26 282 } e7d850dd1 Kuninori Morimoto 2015-10-26 283 ef4cf5d6a Kuninori Morimoto 2017-06-15 284 main_rate = rsnd_ssi_clk_query(priv, rate, chan, &idx); ef4cf5d6a Kuninori Morimoto 2017-06-15 @285 if (main_rate < 0) { ef4cf5d6a Kuninori Morimoto 2017-06-15 286 dev_err(dev, "unsupported clock rate\n"); ef4cf5d6a Kuninori Morimoto 2017-06-15 287 return -EIO; ef4cf5d6a Kuninori Morimoto 2017-06-15 288 } ae5c32230 Kuninori Morimoto 2013-07-21 289 b76e218ae Kuninori Morimoto 2015-09-10 290 ret = rsnd_adg_ssi_clk_try_start(mod, main_rate); ef4cf5d6a Kuninori Morimoto 2017-06-15 291 if (ret < 0) ef4cf5d6a Kuninori Morimoto 2017-06-15 292 return ret; ae5c32230 Kuninori Morimoto 2013-07-21 293 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

2 1

[alsa-devel] Applied "ASoC: rockchip: Fix build" to the asoc tree
by Mark Brown 15 Jun '17

15 Jun '17

The patch ASoC: rockchip: Fix build has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From b2e0a42e32d4eb9d5ee99264616dbba8fc288944 Mon Sep 17 00:00:00 2001 From: Mark Brown <broonie(a)kernel.org> Date: Thu, 15 Jun 2017 20:13:33 +0100 Subject: [PATCH] ASoC: rockchip: Fix build Reported-by: Christophe Jaillet <christophe.jaillet(a)wanadoo.fr> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/rockchip/rockchip_i2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index ce09dee2202e..80db9b8f6605 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -641,7 +641,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev) goto err_pm_disable; } - soc_dai = devm_kmemdup(&pdev->dev, &rockchip_i2s_dai + soc_dai = devm_kmemdup(&pdev->dev, &rockchip_i2s_dai, sizeof(*soc_dai), GFP_KERNEL); if (!soc_dai) { err = -ENOMEM; -- 2.11.0

1 0