June 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/3] ALSA: Add the explicit appl_ptr sync support
by Takashi Iwai 23 Jun '17

23 Jun '17

Hi, this is a patchset for the issues we've discussed recently lengthily, the explicit sync of appl_ptr by disabling the control mmap. The first patch achieves it for a driver setting the new INFO flag. The second patch is for a generic ABI extension I wanted to implement for long time. It allows user-space reporting its supporting protocol version, so that the kernel can behave differently. It's especially useful for extending the ABI struct to use the reserved bits. The third patch is the optimization by the second patch; it simply skips the previous workaround when the user-space declares itself being new enough to support the feature. The corresponding alsa-lib patchset will follow in another thread. thanks, Takashi === Takashi Iwai (3): ALSA: pcm: Add the explicit appl_ptr sync support ALSA: pcm: Add an ioctl to specify the supported protocol version ALSA: pcm: Limit the appl_ptr sync workaround only for old user-space include/sound/pcm.h | 1 + include/uapi/sound/asound.h | 4 +++- sound/core/pcm_compat.c | 1 + sound/core/pcm_native.c | 28 ++++++++++++++++++++++++++++ 4 files changed, 33 insertions(+), 1 deletion(-) -- 2.13.1

2 10

[alsa-devel] Constant headphone noise on Dell XPS 13 9365
by Felipe Contreras 23 Jun '17

23 Jun '17

Hi, Since I bought this machine I've always heard audio noise when I plug the headphones. This laptop has Intel HDA with the Realtec codec. This has happened in all the Linux versions I've tried, and I've also tried HDA Analyzer and changed every value I could find and nothing helps. The only value that seems to have an effect is "Headphone Playback Switch"; if I mute it I don't hear the noise any more, but I don't hear any audio either. Lowering the volume to zero doesn't help either, the noise remains at the same audible level. I'm running 4.11.3 at the moment. Any ideas? Cheers. -- Felipe Contreras

2 4

[alsa-devel] [alsa-lib][RFC][PATCH 0/9] pcm: handle status/control mapping independently
by Takashi Sakamoto 22 Jun '17

22 Jun '17

Hi, This RFC patchset is for recent discussion about new version of PCM protocol/interface (2.0.14). This is accumulated on the below patchset. http://mailman.alsa-project.org/pipermail/alsa-devel/2017-June/122066.html In the discussion, we found an advantage to handle page mapping for status/control data of runtime of PCM substream independently. Aim of this patchset is a proof-of-concept for alsa-lib. I tested this patchset with two machines based on x86/armv7a architectures. This looks work well without any regression. But I've never tested a case in which mapping is failed for one of the status/control data. For your information. Takashi Sakamoto (9): pcm: obsolete 'mmap_emulation' parameter of snd_pcm_hw_open_fd() pcm: minor code refactoring for ioctl call pcm: handle status/control mapping independently pcm: add a helper function to query status of PCM substream pcm: add a helper function to query hwptr pcm: add a helper function to query applptr pcm: add a helper function to issue avail_min pcm: add a helper function to issue applptr pcm: code refactoring to use helper functions src/pcm/pcm_direct.c | 2 +- src/pcm/pcm_hw.c | 324 +++++++++++++++++++++++++++++++++------------------ src/pcm/pcm_local.h | 3 +- 3 files changed, 214 insertions(+), 115 deletions(-) -- 2.11.0

1 9

[alsa-devel] [PATCH] ASoC: max9867: make array ni_div static const
by Colin King 22 Jun '17

22 Jun '17

From: Colin Ian King <colin.king(a)canonical.com> The array ni_div does not need to be in global scope and is not modified, so make it static const. Cleans up sparse warning: "symbol 'ni_div' was not declared. Should it be static?" Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/soc/codecs/max9867.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c index 0247edc9c84e..2a40a69a7513 100644 --- a/sound/soc/codecs/max9867.c +++ b/sound/soc/codecs/max9867.c @@ -132,7 +132,7 @@ enum rates { pcm_rate_48, max_pcm_rate, }; -struct ni_div_rates { +static const struct ni_div_rates { u32 mclk; u16 ni[max_pcm_rate]; } ni_div[] = { -- 2.11.0

3 2

[alsa-devel] [PATCH] ASoC: es8316: add I2C dependency
by Arnd Bergmann 22 Jun '17

22 Jun '17

Without CONFIG_I2C, we get a build failure: sound/soc/codecs/es8316.c:633:1: error: data definition has no type or storage class [-Werror] sound/soc/codecs/es8316.c:633:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int] sound/soc/codecs/es8316.c:633:1: error: parameter names (without types) in function declaration [-Werror] sound/soc/codecs/es8316.c:623:26: error: 'es8316_i2c_driver' defined but not used [-Werror=unused-variable] This adds the required Kconfig dependency. Fixes: b8b88b70875a ("ASoC: add es8316 codec driver") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index c6286e5ba511..f0f794186186 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -546,6 +546,7 @@ config SND_SOC_ES7134 config SND_SOC_ES8316 tristate "Everest Semi ES8316 CODEC" + depends on I2C config SND_SOC_ES8328 tristate -- 2.9.0

3 2

[alsa-devel] [PATCH 3/3] ASoC: pxa: add COMPILE_TEST on SND_MMP_SOC
by Kuninori Morimoto 22 Jun '17

22 Jun '17

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> It doesn't use asm header. We can add COMPILE_TEST Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/pxa/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig index 960744e..6feb34b 100644 --- a/sound/soc/pxa/Kconfig +++ b/sound/soc/pxa/Kconfig @@ -9,7 +9,7 @@ config SND_PXA2XX_SOC config SND_MMP_SOC bool "Soc Audio for Marvell MMP chips" - depends on ARCH_MMP + depends on ARCH_MMP || COMPILE_TEST select MMP_SRAM select SND_SOC_GENERIC_DMAENGINE_PCM select SND_ARM -- 1.9.1

2 3

[alsa-devel] Alsa-lib: Dmix slowptr latency behaviour
by Matin Momin 22 Jun '17

22 Jun '17

Hi, On my embedded device, I am using a push mode simple alsa pipeline with following command > arecord -D"dsp" -r48000 -c2 -fs32_le | aplay -D"dmix1" where the asound conf looks this ------------------------------------------------------------------- # This is the actual HW device pcm.dsp { type hw card 1 rate 48000 channels 2 format S32_LE } pcm.dmix1 { type dmix ipc_key 1024 ipc_key_add_uid false ipc_perm 0666 slave.pcm "dsp" slowptr true } ------------------------------------------------------------------- I measured the pipeline delay by using Audacity on my PC, and measuring the difference in spike of audio recorded on the PC in a silent environment (1st spike will be from the actual sound and second will be from the output of my embedded device). Here I get a delay of around 245 msecs. Now, in the same configuration if I disable slowptr in dmix1, the delay comes down to 160 msecs, which corresponds exactly to buffer time (85 msecs). I want to know whether this is expected or is it an aberration? I have measured the userland time for the data to travel from alsa-lib/src/pcm/pcm_hw.c: snd_pcm_hw_readi() to alsa-lib/src/pcm/pcm_dmix.c:mix_areas() (By adding incremental numbers to each period recorded by arecord and seeing how much time they take to reach dmix). I cannot find any difference in absolute time difference with both slowptr true and false. Also, the critical hw_ptr and appl_ptr variables in pcm_hw and pcm_dmix also reflect same values for slowptr true and false. Is the above mentioned method to measure delay correct? If I don't see a delay here, where else should I look? The alsa-lib version is 1.1.0 and kernel is 3.8.13. Thanks in advance. Regards, Matin

2 3

[alsa-devel] [PATCH] ASoC: nau8825: make crosstalk function optional
by John Hsu 22 Jun '17

22 Jun '17

Make crosstalk functoin optional. The jack detection can speed up without crosstalk detection. Let the decision of function usage to platform design. The patch helps the issue concern as follows: Google issue 35574278: Chell_headphone pop back from S3 There is a concern as follows: cras getting blocked for 2 seconds (worst-case 3 seconds) As I understand, ChromeOS expects resume finishes in 1 seconds. Video/Audio playing after 3 seconds of resume seems against the spec. If we really have to make the choice I would choose pop noise instead of waiting for 3 seconds. Signed-off-by: John Hsu <KCHSU0(a)nuvoton.com> Signed-off-by: John Hsu <supercraig0719(a)gmail.com> --- sound/soc/codecs/nau8825.c | 6 +++++- sound/soc/codecs/nau8825.h | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c index c00b86d..588805c 100644 --- a/sound/soc/codecs/nau8825.c +++ b/sound/soc/codecs/nau8825.c @@ -1682,7 +1682,7 @@ static irqreturn_t nau8825_interrupt(int irq, void *data) } else if (active_irq & NAU8825_HEADSET_COMPLETION_IRQ) { if (nau8825_is_jack_inserted(regmap)) { event |= nau8825_jack_insert(nau8825); - if (!nau8825->high_imped) { + if (!nau8825->xtalk_bypass && !nau8825->high_imped) { /* Apply the cross talk suppression in the * headset without high impedance. */ @@ -2489,6 +2489,10 @@ static int nau8825_read_device_properties(struct device *dev, &nau8825->jack_eject_debounce); if (ret) nau8825->jack_eject_debounce = 0; + ret = device_property_read_u32(dev, "nuvoton,crosstalk-bypass", + &nau8825->xtalk_bypass); + if (ret) + nau8825->xtalk_bypass = 1; nau8825->mclk = devm_clk_get(dev, "mclk"); if (PTR_ERR(nau8825->mclk) == -EPROBE_DEFER) { diff --git a/sound/soc/codecs/nau8825.h b/sound/soc/codecs/nau8825.h index 514fd13..8aee5c86 100644 --- a/sound/soc/codecs/nau8825.h +++ b/sound/soc/codecs/nau8825.h @@ -476,6 +476,7 @@ struct nau8825 { int xtalk_event_mask; bool xtalk_protect; int imp_rms[NAU8825_XTALK_IMM]; + int xtalk_bypass; }; int nau8825_enable_jack_detect(struct snd_soc_codec *codec, -- 2.6.4

1 0

[alsa-devel] [PATCH] ASoC: nau8825: fix jack type detection issue after resume
by John Hsu 22 Jun '17

22 Jun '17

Fix the issue that mic type detection error after resume. The microphone type detection procedure will recognize testing signal on JKSLV pin, but before the procedure, JKSLV already had supply voltage, that results in the failure. Therefore, the patch turns off the power and reset the jack type configuration before suspend. Then redo the jack detection procedure after resume. The patch help to fix the issue as follows: Google issue 37973093: CTIA/OMTP jack type detection failure after resume Reported Issue Chrome OS Version : ChromeOS R59-9460.13.0 Type of hardware : DVT sample What steps will reproduce the problem? (1 Play a music (2 Insert a headphones (3 Close laptop lid 3 sec then open it What is the expected output? The music is normal in the headphones. What do you see instead? Singer voice in the music is not clear. How frequently does this problem reproduce? Always What is the impact to the user, and is there a workaround? If so, what is it? Re-insert the headset or close the laptop lid and then open it again can be repaired. Signed-off-by: John Hsu <KCHSU0(a)nuvoton.com> Signed-off-by: John Hsu <supercraig0719(a)gmail.com> --- sound/soc/codecs/nau8825.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c index 588805c..a8c7a55 100644 --- a/sound/soc/codecs/nau8825.c +++ b/sound/soc/codecs/nau8825.c @@ -1612,7 +1612,6 @@ static int nau8825_jack_insert(struct nau8825 *nau8825) snd_soc_dapm_sync(dapm); break; case 2: - case 3: dev_dbg(nau8825->dev, "CTIA (micgnd2) mic connected\n"); type = SND_JACK_HEADSET; @@ -1632,6 +1631,11 @@ static int nau8825_jack_insert(struct nau8825 *nau8825) snd_soc_dapm_force_enable_pin(dapm, "SAR"); snd_soc_dapm_sync(dapm); break; + case 3: + /* detect error case */ + dev_err(nau8825->dev, "detection error; disable mic function\n"); + type = SND_JACK_HEADPHONE; + break; } /* Leaving HPOL/R grounded after jack insert by default. They will be @@ -2328,6 +2332,13 @@ static int nau8825_set_bias_level(struct snd_soc_codec *codec, break; case SND_SOC_BIAS_OFF: + /* Reset the configuration of jack type for detection */ + /* Detach 2kOhm Resistors from MICBIAS to MICGND1/2 */ + regmap_update_bits(nau8825->regmap, NAU8825_REG_MIC_BIAS, + NAU8825_MICBIAS_JKSLV | NAU8825_MICBIAS_JKR2, 0); + /* ground HPL/HPR, MICGRND1/2 */ + regmap_update_bits(nau8825->regmap, + NAU8825_REG_HSD_CTRL, 0xf, 0xf); /* Cancel and reset cross talk detection funciton */ nau8825_xtalk_cancel(nau8825); /* Turn off all interruptions before system shutdown. Keep the @@ -2351,6 +2362,10 @@ static int __maybe_unused nau8825_suspend(struct snd_soc_codec *codec) disable_irq(nau8825->irq); snd_soc_codec_force_bias_level(codec, SND_SOC_BIAS_OFF); + /* Power down codec power; don't suppoet button wakeup */ + snd_soc_dapm_disable_pin(nau8825->dapm, "SAR"); + snd_soc_dapm_disable_pin(nau8825->dapm, "MICBIAS"); + snd_soc_dapm_sync(nau8825->dapm); regcache_cache_only(nau8825->regmap, true); regcache_mark_dirty(nau8825->regmap); -- 2.6.4

1 0

[alsa-devel] ASoC: nau8825: default value for property
by John Hsu 22 Jun '17

22 Jun '17

Assign default value for codec private data when property not given. If without those default value and property, the codec will work abnormally. Signed-off-by: John Hsu <KCHSU0(a)nuvoton.com> Signed-off-by: John Hsu <supercraig0719(a)gmail.com> --- sound/soc/codecs/nau8825.c | 62 +++++++++++++++++++++++++++++++++++++--------- 1 file changed, 50 insertions(+), 12 deletions(-) diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c index 97fbeba..ff827bb 100644 --- a/sound/soc/codecs/nau8825.c +++ b/sound/soc/codecs/nau8825.c @@ -2429,37 +2429,75 @@ static void nau8825_print_device_properties(struct nau8825 *nau8825) static int nau8825_read_device_properties(struct device *dev, struct nau8825 *nau8825) { + int ret; nau8825->jkdet_enable = device_property_read_bool(dev, "nuvoton,jkdet-enable"); + if (nau8825->jkdet_enable != true && + nau8825->jkdet_enable != false) + nau8825->jkdet_enable = 1; nau8825->jkdet_pull_enable = device_property_read_bool(dev, "nuvoton,jkdet-pull-enable"); + if (nau8825->jkdet_pull_enable != true && + nau8825->jkdet_pull_enable != false) + nau8825->jkdet_pull_enable = 1; nau8825->jkdet_pull_up = device_property_read_bool(dev, "nuvoton,jkdet-pull-up"); - device_property_read_u32(dev, "nuvoton,jkdet-polarity", + if (nau8825->jkdet_pull_up != true && + nau8825->jkdet_pull_up != false) + nau8825->jkdet_pull_up = 1; + ret = device_property_read_u32(dev, "nuvoton,jkdet-polarity", &nau8825->jkdet_polarity); - device_property_read_u32(dev, "nuvoton,micbias-voltage", + if (ret) + nau8825->jkdet_polarity = 1; + ret = device_property_read_u32(dev, "nuvoton,micbias-voltage", &nau8825->micbias_voltage); - device_property_read_u32(dev, "nuvoton,vref-impedance", + if (ret) + nau8825->micbias_voltage = 6; + ret = device_property_read_u32(dev, "nuvoton,vref-impedance", &nau8825->vref_impedance); - device_property_read_u32(dev, "nuvoton,sar-threshold-num", + if (ret) + nau8825->vref_impedance = 2; + ret = device_property_read_u32(dev, "nuvoton,sar-threshold-num", &nau8825->sar_threshold_num); - device_property_read_u32_array(dev, "nuvoton,sar-threshold", + if (ret) + nau8825->sar_threshold_num = 4; + ret = device_property_read_u32_array(dev, "nuvoton,sar-threshold", nau8825->sar_threshold, nau8825->sar_threshold_num); - device_property_read_u32(dev, "nuvoton,sar-hysteresis", + if (ret) { + nau8825->sar_threshold[0] = 0x08; + nau8825->sar_threshold[1] = 0x12; + nau8825->sar_threshold[2] = 0x26; + nau8825->sar_threshold[3] = 0x73; + } + ret = device_property_read_u32(dev, "nuvoton,sar-hysteresis", &nau8825->sar_hysteresis); - device_property_read_u32(dev, "nuvoton,sar-voltage", + if (ret) + nau8825->sar_hysteresis = 0; + ret = device_property_read_u32(dev, "nuvoton,sar-voltage", &nau8825->sar_voltage); - device_property_read_u32(dev, "nuvoton,sar-compare-time", + if (ret) + nau8825->sar_voltage = 6; + ret = device_property_read_u32(dev, "nuvoton,sar-compare-time", &nau8825->sar_compare_time); - device_property_read_u32(dev, "nuvoton,sar-sampling-time", + if (ret) + nau8825->sar_compare_time = 1; + ret = device_property_read_u32(dev, "nuvoton,sar-sampling-time", &nau8825->sar_sampling_time); - device_property_read_u32(dev, "nuvoton,short-key-debounce", + if (ret) + nau8825->sar_sampling_time = 1; + ret = device_property_read_u32(dev, "nuvoton,short-key-debounce", &nau8825->key_debounce); - device_property_read_u32(dev, "nuvoton,jack-insert-debounce", + if (ret) + nau8825->key_debounce = 3; + ret = device_property_read_u32(dev, "nuvoton,jack-insert-debounce", &nau8825->jack_insert_debounce); - device_property_read_u32(dev, "nuvoton,jack-eject-debounce", + if (ret) + nau8825->jack_insert_debounce = 7; + ret = device_property_read_u32(dev, "nuvoton,jack-eject-debounce", &nau8825->jack_eject_debounce); + if (ret) + nau8825->jack_eject_debounce = 0; nau8825->mclk = devm_clk_get(dev, "mclk"); if (PTR_ERR(nau8825->mclk) == -EPROBE_DEFER) { -- 2.6.4

3 2