June 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v2 0/3] ALSA: pcm: add 'applptr' event of tracepoint
by Takashi Sakamoto 12 Jun '17

12 Jun '17

Hi, This is an update version of my previous patchset. [alsa-devel] [PATCH 0/3] ALSA: pcm: add 'applptr' event of tracepoint http://mailman.alsa-project.org/pipermail/alsa-devel/2017-June/121657.html Chagnes from v1: - rewrite change log for second patch, including content of cover letter in my previous patchset, according to advice from maintainer. In design of ALSA PCM core, both of hardware-side and application-side position on PCM buffer are maintained as a part of information for runtime of PCM substream. In a view of ALSA PCM application, these two positions can be updated by executing ioctl(2) with some commands. There's an event of tracepoint for hardware-side position; 'hwptr'. On the other hand, no events for application-side position. This patchset adds a new event for this purpose; 'applptr'. When the application-side position is changed in kernel space, this event is probed with useful information for developers. The event is not probed for all of ALSA PCM applications, In detail, please read second patch. Takashi Sakamoto (3): ALSA: pcm: unify codes to operate application-side position on PCM buffer ALSA: pcm: add 'applptr' event of tracepoint ALSA: pcm: use %s instead of %c for format of PCM buffer tracepoints sound/core/pcm_lib.c | 31 +++++++++++++++++++++++++++--- sound/core/pcm_local.h | 2 ++ sound/core/pcm_native.c | 28 ++++----------------------- sound/core/pcm_trace.h | 50 +++++++++++++++++++++++++++++++++++++++++++------ 4 files changed, 78 insertions(+), 33 deletions(-) -- 2.11.0

2 4

[alsa-devel] [sound:topic/seq-kconfig 139/139] undefined reference to `snd_seq_device_new'
by kbuild test robot 12 Jun '17

12 Jun '17

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/seq-kconfig head: 4d33d24dc3cd037a74c5f17809b7d3f2d35289ae commit: 4d33d24dc3cd037a74c5f17809b7d3f2d35289ae [139/139] ALSA: seq: Allow the modular sequencer registration config: x86_64-randconfig-h0-06121151 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: git checkout 4d33d24dc3cd037a74c5f17809b7d3f2d35289ae # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): sound/built-in.o: In function `snd_rawmidi_dev_register': rawmidi.c:(.text+0x1a775): undefined reference to `snd_seq_device_new' sound/built-in.o: In function `snd_opl3_hwdep_new': >> (.text+0x263c8): undefined reference to `snd_seq_device_new' --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH 0/3] ALSA: pcm: add 'applptr' event of tracepoint
by Takashi Sakamoto 12 Jun '17

12 Jun '17

Hi, This patchset is for a event at updating application-side position in kernel space. This also includes my previous patch: [alsa-devel] [PATCH 2/2] ALSA: pcm: add arrangement for applying appl_ptr http://mailman.alsa-project.org/pipermail/alsa-devel/2017-May/121091.html In design of ALSA PCM core, status and control data for runtime of ALSA PCM substream are shared between kernel/user spaces by page frame mapping with read-only attribute. The application-side position is a part of the status data and ALSA PCM applications can't update it. When applications are written by read/write programming scenario, they can be unaware of update of application-side position. In this case, ALSA PCM core certainly performs it. However, when applications are written by mmap programming scenario, if maintaining the application side position accurately in kernel space, applications should voluntarily execute ioctl(2) with some commands when they handles any PCM frames. If not voluntarily, the events are not probed. There's a loophole, using architectures to which ALSA PCM core judges non-cache coherent. In this case, the status and control data is not mapped into processe's VMA for any applications. Userland library, alsa-lib, is programmed for this case. It executes ioctl(2) with SNDRV_PCM_IOCTL_SYNC_PTR command every time to requiring the status and control data. ARM is such an architecture. Below is an example with serial sound interface (ssi) on i.mx6 quad core SoC. I use v4.1 kernel released by fsl-community with patches from VIA Tech. Inc. for VAB820, and my backport patches for relevant features for this patchset. I use Ubuntu 17.04 from ports.ubuntu.com as user land for armhf architecture. $ aplay -v -M -D hw:imx6vab820sgtl5,0 /dev/urandom -f S16_LE -r 48000 --period-size=128 --buffer-size=256 Playing raw data '/dev/urandom' : Signed 16 bit Little Endian, Rate 48000 Hz, Mono Hardware PCM card 0 'imx6-vab820-sgtl5000' device 0 subdevice 0 Its setup is: stream : PLAYBACK access : MMAP_INTERLEAVED format : S16_LE subformat : STD channels : 1 rate : 48000 exact rate : 48000 (48000/1) msbits : 16 buffer_size : 256 period_size : 128 period_time : 2666 tstamp_mode : NONE tstamp_type : MONOTONIC period_step : 1 avail_min : 128 period_event : 0 start_threshold : 256 stop_threshold : 256 silence_threshold: 0 silence_size : 0 boundary : 1073741824 appl_ptr : 0 hw_ptr : 0 mmap_area[0] = 0x76f98000,0,16 (16) $ trace-cmd record -e snd_pcm:hwptr -e snd_pcm:applptr $ trace-cmd report ... 60.208495: applptr: pcmC0D0p/sub0: prev=1792, curr=1792, avail=0, period=128, buf=256 60.208633: applptr: pcmC0D0p/sub0: prev=1792, curr=1792, avail=0, period=128, buf=256 60.210022: hwptr: pcmC0D0p/sub0: IRQ: pos=128, old=1536, base=1536, period=128, buf=256 60.210202: applptr: pcmC0D0p/sub0: prev=1792, curr=1792, avail=128, period=128, buf=256 60.210344: hwptr: pcmC0D0p/sub0: POS: pos=128, old=1664, base=1536, period=128, buf=256 60.210348: applptr: pcmC0D0p/sub0: prev=1792, curr=1792, avail=128, period=128, buf=256 60.210486: applptr: pcmC0D0p/sub0: prev=1792, curr=1792, avail=128, period=128, buf=256 60.210626: applptr: pcmC0D0p/sub0: prev=1792, curr=1920, avail=0, period=128, buf=256 60.211002: applptr: pcmC0D0p/sub0: prev=1920, curr=1920, avail=0, period=128, buf=256 60.211142: hwptr: pcmC0D0p/sub0: POS: pos=128, old=1664, base=1536, period=128, buf=256 60.211146: applptr: pcmC0D0p/sub0: prev=1920, curr=1920, avail=0, period=128, buf=256 60.211287: applptr: pcmC0D0p/sub0: prev=1920, curr=1920, avail=0, period=128, buf=256 60.212690: hwptr: pcmC0D0p/sub0: IRQ: pos=0, old=1664, base=1536, period=128, buf=256 60.212866: applptr: pcmC0D0p/sub0: prev=1920, curr=1920, avail=128, period=128, buf=256 60.212999: hwptr: pcmC0D0p/sub0: POS: pos=0, old=1792, base=1792, period=128, buf=256 60.213003: applptr: pcmC0D0p/sub0: prev=1920, curr=1920, avail=128, period=128, buf=256 60.213135: applptr: pcmC0D0p/sub0: prev=1920, curr=1920, avail=128, period=128, buf=256 60.213276: applptr: pcmC0D0p/sub0: prev=1920, curr=2048, avail=0, period=128, buf=256 60.213654: applptr: pcmC0D0p/sub0: prev=2048, curr=2048, avail=0, period=128, buf=256 60.213796: hwptr: pcmC0D0p/sub0: POS: pos=0, old=1792, base=1792, period=128, buf=256 60.213800: applptr: pcmC0D0p/sub0: prev=2048, curr=2048, avail=0, period=128, buf=256 60.213937: applptr: pcmC0D0p/sub0: prev=2048, curr=2048, avail=0, period=128, buf=256 60.215356: hwptr: pcmC0D0p/sub0: IRQ: pos=128, old=1792, base=1792, period=128, buf=256 60.215542: applptr: pcmC0D0p/sub0: prev=2048, curr=2048, avail=128, period=128, buf=256 60.215679: hwptr: pcmC0D0p/sub0: POS: pos=128, old=1920, base=1792, period=128, buf=256 60.215683: applptr: pcmC0D0p/sub0: prev=2048, curr=2048, avail=128, period=128, buf=256 60.215813: applptr: pcmC0D0p/sub0: prev=2048, curr=2048, avail=128, period=128, buf=256 60.215947: applptr: pcmC0D0p/sub0: prev=2048, curr=2176, avail=0, period=128, buf=256 ... We can surely see 'applptr' event is probed even if the application run for mmap programming scenario ('-M' option for 'hw' plugin). Below is a result of strace: 02:44:15.886382 ioctl(4, SNDRV_PCM_IOCTL_SYNC_PTR, 0x56a32b30) = 0 02:44:15.887203 poll([{fd=4, events=POLLOUT|POLLERR|POLLNVAL}], 1, -1) = 1 ([{fd=4, revents=POLLOUT}]) 02:44:15.887471 ioctl(4, SNDRV_PCM_IOCTL_SYNC_PTR, 0x56a32b30) = 0 02:44:15.887637 ioctl(4, SNDRV_PCM_IOCTL_SYNC_PTR, 0x56a32b30) = 0 02:44:15.887805 ioctl(4, SNDRV_PCM_IOCTL_SYNC_PTR, 0x56a32b30) = 0 02:44:15.887969 ioctl(4, SNDRV_PCM_IOCTL_SYNC_PTR, 0x56a32b30) = 0 02:44:15.888132 read(3, "..."..., 256) = 256 02:44:15.889040 ioctl(4, SNDRV_PCM_IOCTL_SYNC_PTR, 0x56a32b30) = 0 02:44:15.889221 ioctl(4, SNDRV_PCM_IOCTL_SYNC_PTR, 0x56a32b30) = 0 02:44:15.889431 ioctl(4, SNDRV_PCM_IOCTL_SYNC_PTR, 0x56a32b30) = 0 02:44:15.889606 poll([{fd=4, events=POLLOUT|POLLERR|POLLNVAL}], 1, -1) = 1 ([{fd=4, revents=POLLOUT}]) 02:44:15.889833 ioctl(4, SNDRV_PCM_IOCTL_SYNC_PTR, 0x56a32b30) = 0 02:44:15.889998 ioctl(4, SNDRV_PCM_IOCTL_SYNC_PTR, 0x56a32b30) = 0 02:44:15.890164 ioctl(4, SNDRV_PCM_IOCTL_SYNC_PTR, 0x56a32b30) = 0 02:44:15.891048 ioctl(4, SNDRV_PCM_IOCTL_SYNC_PTR, 0x56a32b30) = 0 02:44:15.891228 read(3, "..."..., 256) = 256 02:44:15.891497 ioctl(4, SNDRV_PCM_IOCTL_SYNC_PTR, 0x56a32b30) = 0 02:44:15.891661 ioctl(4, SNDRV_PCM_IOCTL_SYNC_PTR, 0x56a32b30) = 0 02:44:15.891829 ioctl(4, SNDRV_PCM_IOCTL_SYNC_PTR, 0x56a32b30) = 0 02:44:15.891991 poll([{fd=4, events=POLLOUT|POLLERR|POLLNVAL}], 1, -1) = 1 ([{fd=4, revents=POLLOUT}]) 02:44:15.893007 ioctl(4, SNDRV_PCM_IOCTL_SYNC_PTR, 0x56a32b30) = 0 We can see 7 calls of ioctl(2) with SNDRV_PCM_IOCTL_SYNC_PTR per loop with call of poll(2). 128 PCM frames are transferred per loop of one poll(2), because the PCM substream is configured with S16_LE format and 1 channel (2 byte * 1 * 128 = 256 bytes). This equals to the size of period of PCM buffer. Comparing to the probed data, one of the 7 system calls is actually used to commit the number of copied PCM frames to kernel space. The tracepoint event is useful to investigate this case. I note that below modules are related to the above sample. * snd-soc-dummy.ko * snd-soc-imx-sgtl5000.ko * snd-soc-fsl-ssi.ko * snd-soc-imx-pcm-dma.ko * snd-soc-sgtl5000.ko Takashi Sakamoto (3): ALSA: pcm: unify codes to operate application-side position on PCM buffer ALSA: pcm: add 'applptr' event of tracepoint ALSA: pcm: use %s instead of %c for format of PCM buffer tracepoints sound/core/pcm_lib.c | 31 +++++++++++++++++++++++++++--- sound/core/pcm_local.h | 2 ++ sound/core/pcm_native.c | 28 ++++----------------------- sound/core/pcm_trace.h | 50 +++++++++++++++++++++++++++++++++++++++++++------ 4 files changed, 78 insertions(+), 33 deletions(-) -- 2.11.0

2 7

[alsa-devel] [PATCH 0/2] ALSA: pcm: probe tracepoint events only when parameter is changed
by Takashi Sakamoto 11 Jun '17

11 Jun '17

Hi, This patchset includes a part of my former RFC: [alsa-devel] [PATCH RFC 00/21] ALSA: pcm: add tracepoints for PCM params operation http://mailman.alsa-project.org/pipermail/alsa-devel/2017-May/120548.html The purpose of this patchset is to limit added events of tracepoint for PCM parameters only when corresponding parameter is actually changed. Developers get the events without events for unchanged parameters. Additionally, this simplifies error handling of PCM parameters processing. This is intrusive somehow for userspace applications but just for error path. Takashi Sakamoto (2): ALSA: pcm: return error immediately for parameters handling ALSA: pcm: probe events when parameters are changed actually sound/core/pcm_native.c | 122 ++++++++++++++++++++++++++---------------------- 1 file changed, 67 insertions(+), 55 deletions(-) -- 2.11.0

2 3

[alsa-devel] [PATCH v2] ALSA: firewire-lib: Fix stall of process context at packet error
by Takashi Sakamoto 11 Jun '17

11 Jun '17

At Linux v3.5, packet processing can be done in process context of ALSA PCM application as well as software IRQ context for OHCI 1394. Below is an example of the callgraph (some calls are omitted). ioctl(2) with e.g. HWSYNC (sound/core/pcm_native.c) ->snd_pcm_common_ioctl1() ->snd_pcm_hwsync() ->snd_pcm_stream_lock_irq (sound/core/pcm_lib.c) ->snd_pcm_update_hw_ptr() ->snd_pcm_update_hw_ptr0() ->struct snd_pcm_ops.pointer() (sound/firewire/*) = Each handler on drivers in ALSA firewire stack (sound/firewire/amdtp-stream.c) ->amdtp_stream_pcm_pointer() (drivers/firewire/core-iso.c) ->fw_iso_context_flush_completions() ->struct fw_card_driver.flush_iso_completion() (drivers/firewire/ohci.c) = flush_iso_completions() ->struct fw_iso_context.callback.sc (sound/firewire/amdtp-stream.c) = in_stream_callback() or out_stream_callback() ->... ->snd_pcm_stream_unlock_irq When packet queueing error occurs or detecting invalid packets in 'in_stream_callback()' or 'out_stream_callback()', 'snd_pcm_stop_xrun()' is called on local CPU with disabled IRQ. (sound/firewire/amdtp-stream.c) in_stream_callback() or out_stream_callback() ->amdtp_stream_pcm_abort() ->snd_pcm_stop_xrun() ->snd_pcm_stream_lock_irqsave() ->snd_pcm_stop() ->snd_pcm_stream_unlock_irqrestore() The process is stalled on the CPU due to attempt to acquire recursive lock. [ 562.630853] INFO: rcu_sched detected stalls on CPUs/tasks: [ 562.630861] 2-...: (1 GPs behind) idle=37d/140000000000000/0 softirq=38323/38323 fqs=7140 [ 562.630862] (detected by 3, t=15002 jiffies, g=21036, c=21035, q=5933) [ 562.630866] Task dump for CPU 2: [ 562.630867] alsa-source-OXF R running task 0 6619 1 0x00000008 [ 562.630870] Call Trace: [ 562.630876] ? vt_console_print+0x79/0x3e0 [ 562.630880] ? msg_print_text+0x9d/0x100 [ 562.630883] ? up+0x32/0x50 [ 562.630885] ? irq_work_queue+0x8d/0xa0 [ 562.630886] ? console_unlock+0x2b6/0x4b0 [ 562.630888] ? vprintk_emit+0x312/0x4a0 [ 562.630892] ? dev_vprintk_emit+0xbf/0x230 [ 562.630895] ? do_sys_poll+0x37a/0x550 [ 562.630897] ? dev_printk_emit+0x4e/0x70 [ 562.630900] ? __dev_printk+0x3c/0x80 [ 562.630903] ? _raw_spin_lock+0x20/0x30 [ 562.630909] ? snd_pcm_stream_lock+0x31/0x50 [snd_pcm] [ 562.630914] ? _snd_pcm_stream_lock_irqsave+0x2e/0x40 [snd_pcm] [ 562.630918] ? snd_pcm_stop_xrun+0x16/0x70 [snd_pcm] [ 562.630922] ? in_stream_callback+0x3e6/0x450 [snd_firewire_lib] [ 562.630925] ? handle_ir_packet_per_buffer+0x8e/0x1a0 [firewire_ohci] [ 562.630928] ? ohci_flush_iso_completions+0xa3/0x130 [firewire_ohci] [ 562.630932] ? fw_iso_context_flush_completions+0x15/0x20 [firewire_core] [ 562.630935] ? amdtp_stream_pcm_pointer+0x2d/0x40 [snd_firewire_lib] [ 562.630938] ? pcm_capture_pointer+0x19/0x20 [snd_oxfw] [ 562.630943] ? snd_pcm_update_hw_ptr0+0x47/0x3d0 [snd_pcm] [ 562.630945] ? poll_select_copy_remaining+0x150/0x150 [ 562.630947] ? poll_select_copy_remaining+0x150/0x150 [ 562.630952] ? snd_pcm_update_hw_ptr+0x10/0x20 [snd_pcm] [ 562.630956] ? snd_pcm_hwsync+0x45/0xb0 [snd_pcm] [ 562.630960] ? snd_pcm_common_ioctl1+0x1ff/0xc90 [snd_pcm] [ 562.630962] ? futex_wake+0x90/0x170 [ 562.630966] ? snd_pcm_capture_ioctl1+0x136/0x260 [snd_pcm] [ 562.630970] ? snd_pcm_capture_ioctl+0x27/0x40 [snd_pcm] [ 562.630972] ? do_vfs_ioctl+0xa3/0x610 [ 562.630974] ? vfs_read+0x11b/0x130 [ 562.630976] ? SyS_ioctl+0x79/0x90 [ 562.630978] ? entry_SYSCALL_64_fastpath+0x1e/0xad This commit fixes the above bug by removing the calls of 'amdtp_stream_pcm_abort()' from packet handler. Instead, in 'struct snd_pcm_ops.pointer', SNDRV_PCM_POS_XRUN is returned to take ALSA PCM core to stop PCM substream safely. Suggested-by: Clemens Ladisch <clemens(a)ladisch.de> Fixes: e9148dddc3c7("ALSA: firewire-lib: flush completed packets when reading PCM position") Cc: <stable(a)vger.kernel.org> # 4.9+ Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- sound/firewire/amdtp-stream.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/firewire/amdtp-stream.c b/sound/firewire/amdtp-stream.c index 9678bc75dc5b..de4f6b6dbd47 100644 --- a/sound/firewire/amdtp-stream.c +++ b/sound/firewire/amdtp-stream.c @@ -701,7 +701,7 @@ static void out_stream_callback(struct fw_iso_context *context, u32 tstamp, cycle = increment_cycle_count(cycle, 1); if (s->handle_packet(s, 0, cycle, i) < 0) { s->packet_index = -1; - amdtp_stream_pcm_abort(s); + WRITE_ONCE(s->pcm_buffer_pointer, SNDRV_PCM_POS_XRUN); return; } } @@ -753,7 +753,7 @@ static void in_stream_callback(struct fw_iso_context *context, u32 tstamp, /* Queueing error or detecting invalid payload. */ if (i < packets) { s->packet_index = -1; - amdtp_stream_pcm_abort(s); + WRITE_ONCE(s->pcm_buffer_pointer, SNDRV_PCM_POS_XRUN); return; } -- 2.11.0

2 2

[alsa-devel] [sound:for-linus 20/20] rawmidi.c:undefined reference to `snd_seq_device_new'
by kbuild test robot 10 Jun '17

10 Jun '17

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-linus head: 8c6e31b25e15da191e3f2dafe3223f0eadc2db7f commit: 8c6e31b25e15da191e3f2dafe3223f0eadc2db7f [20/20] ALSA: seq: Simplify device registration config: x86_64-randconfig-s5-06110057 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: git checkout 8c6e31b25e15da191e3f2dafe3223f0eadc2db7f # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): sound/built-in.o: In function `snd_rawmidi_dev_register': >> rawmidi.c:(.text+0xba55): undefined reference to `snd_seq_device_new' --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH v1] ASoC: Intel: byt-max98090: Add GPIO ACPI mapping table
by Andy Shevchenko 10 Jun '17

10 Jun '17

In order to make GPIO ACPI library stricter prepare users of gpiod_get_index() to correctly behave when there no mapping is provided by firmware. Here we add explicit mapping between _CRS GpioIo() resources and their names used in the driver. Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> --- sound/soc/intel/boards/byt-max98090.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/sound/soc/intel/boards/byt-max98090.c b/sound/soc/intel/boards/byt-max98090.c index d9f81b8d915d..62f5a09aa613 100644 --- a/sound/soc/intel/boards/byt-max98090.c +++ b/sound/soc/intel/boards/byt-max98090.c @@ -67,20 +67,29 @@ static struct snd_soc_jack_pin hs_jack_pins[] = { static struct snd_soc_jack_gpio hs_jack_gpios[] = { { - .name = "hp-gpio", + .name = "hp", .idx = 0, .report = SND_JACK_HEADPHONE | SND_JACK_LINEOUT, .debounce_time = 200, }, { - .name = "mic-gpio", - .idx = 1, + .name = "mic", + .idx = 0, .invert = 1, .report = SND_JACK_MICROPHONE, .debounce_time = 200, }, }; +static const struct acpi_gpio_params hp_gpios = { 0, 0, false }; +static const struct acpi_gpio_params mic_gpios = { 1, 0, false }; + +static const struct acpi_gpio_mapping acpi_byt_max98090_gpios[] = { + { "hp-gpios", &hp_gpios, 1 }, + { "mic-gpios", &mic_gpios, 1 }, + {}, +}; + static int byt_max98090_init(struct snd_soc_pcm_runtime *runtime) { int ret; @@ -140,8 +149,9 @@ static struct snd_soc_card byt_max98090_card = { static int byt_max98090_probe(struct platform_device *pdev) { - int ret_val = 0; + struct device *dev = &pdev->dev; struct byt_max98090_private *priv; + int ret_val; priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_ATOMIC); if (!priv) { @@ -149,6 +159,10 @@ static int byt_max98090_probe(struct platform_device *pdev) return -ENOMEM; } + ret_val = devm_acpi_dev_add_driver_gpios(dev, acpi_byt_max98090_gpios); + if (ret_val) + dev_dbg(dev, "Unable to add GPIO mapping table\n"); + byt_max98090_card.dev = &pdev->dev; snd_soc_card_set_drvdata(&byt_max98090_card, priv); ret_val = devm_snd_soc_register_card(&pdev->dev, &byt_max98090_card); -- 2.11.0

2 3

[alsa-devel] [sound:for-linus 17/20] sound/drivers/opl3/opl3_oss.c:256:22: sparse: incompatible types for 'case' statement
by kbuild test robot 09 Jun '17

09 Jun '17

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-linus head: 8c6e31b25e15da191e3f2dafe3223f0eadc2db7f commit: d710684b7e2ee5500b6ced18f69fbb05c05cad60 [17/20] ALSA: seq: Allow the tristate build of OSS emulation reproduce: # apt-get install sparse git checkout d710684b7e2ee5500b6ced18f69fbb05c05cad60 make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) include/linux/compiler.h:264:8: sparse: attribute 'no_sanitize_address': unknown attribute sound/drivers/opl3/opl3_oss.c:172:12: sparse: using member 'private_data' in incomplete struct snd_seq_oss_arg sound/drivers/opl3/opl3_oss.c:173:12: sparse: using member 'addr' in incomplete struct snd_seq_oss_arg sound/drivers/opl3/opl3_oss.c:174:12: sparse: using member 'addr' in incomplete struct snd_seq_oss_arg sound/drivers/opl3/opl3_oss.c:190:19: sparse: using member 'private_data' in incomplete struct snd_seq_oss_arg sound/drivers/opl3/opl3_oss.c:254:19: sparse: using member 'private_data' in incomplete struct snd_seq_oss_arg sound/drivers/opl3/opl3_oss.c:256:22: sparse: undefined identifier 'SNDCTL_FM_LOAD_INSTR' sound/drivers/opl3/opl3_oss.c:262:22: sparse: undefined identifier 'SNDCTL_SYNTH_MEMAVL' sound/drivers/opl3/opl3_oss.c:265:22: sparse: undefined identifier 'SNDCTL_FM_4OP_ENABLE' >> sound/drivers/opl3/opl3_oss.c:256:22: sparse: incompatible types for 'case' statement sound/drivers/opl3/opl3_oss.c:262:22: sparse: incompatible types for 'case' statement sound/drivers/opl3/opl3_oss.c:265:22: sparse: incompatible types for 'case' statement sound/drivers/opl3/opl3_oss.c:213:19: sparse: using member 'private_data' in incomplete struct snd_seq_oss_arg sound/drivers/opl3/opl3_oss.c:215:23: sparse: undefined identifier 'FM_PATCH' sound/drivers/opl3/opl3_oss.c:217:28: sparse: undefined identifier 'OPL3_PATCH' sound/drivers/opl3/opl3_oss.c:229:16: sparse: using member 'channel' in incomplete struct sbi_instrument sound/drivers/opl3/opl3_oss.c:230:17: sparse: using member 'channel' in incomplete struct sbi_instrument sound/drivers/opl3/opl3_oss.c:236:36: sparse: using member 'channel' in incomplete struct sbi_instrument sound/drivers/opl3/opl3_oss.c:238:44: sparse: using member 'channel' in incomplete struct sbi_instrument sound/drivers/opl3/opl3_oss.c:282:19: sparse: using member 'private_data' in incomplete struct snd_seq_oss_arg sound/drivers/opl3/opl3_oss.c:49:10: sparse: unknown field name in initializer sound/drivers/opl3/opl3_oss.c:50:10: sparse: unknown field name in initializer sound/drivers/opl3/opl3_oss.c:51:10: sparse: unknown field name in initializer sound/drivers/opl3/opl3_oss.c:52:10: sparse: unknown field name in initializer sound/drivers/opl3/opl3_oss.c:53:10: sparse: unknown field name in initializer sound/drivers/opl3/opl3_oss.c:54:10: sparse: unknown field name in initializer sound/drivers/opl3/opl3_oss.c:63:59: sparse: no member 'oss_chset' in struct snd_opl3 sound/drivers/opl3/opl3_oss.c:73:39: sparse: no member 'oss_chset' in struct snd_opl3 sound/drivers/opl3/opl3_oss.c:84:13: sparse: no member 'oss_chset' in struct snd_opl3 sound/drivers/opl3/opl3_oss.c:85:17: sparse: no member 'oss_chset' in struct snd_opl3 sound/drivers/opl3/opl3_oss.c:87:13: sparse: no member 'oss_chset' in struct snd_opl3 sound/drivers/opl3/opl3_oss.c:98:13: sparse: no member 'oss_chset' in struct snd_opl3 sound/drivers/opl3/opl3_oss.c:99:13: sparse: no member 'oss_chset' in struct snd_opl3 sound/drivers/opl3/opl3_oss.c:107:17: sparse: no member 'oss_chset' in struct snd_opl3 sound/drivers/opl3/opl3_oss.c:109:28: sparse: no member 'oss_chset' in struct snd_opl3 sound/drivers/opl3/opl3_oss.c:110:47: sparse: no member 'oss_chset' in struct snd_opl3 sound/drivers/opl3/opl3_oss.c:124:47: sparse: undefined identifier 'SNDRV_SEQ_DEV_ID_OSS' sound/drivers/opl3/opl3_oss.c:128:13: sparse: no member 'oss_seq_dev' in struct snd_opl3 sound/drivers/opl3/opl3_oss.c:131:12: sparse: using member 'type' in incomplete struct snd_seq_oss_reg sound/drivers/opl3/opl3_oss.c:133:20: sparse: using member 'subtype' in incomplete struct snd_seq_oss_reg sound/drivers/opl3/opl3_oss.c:134:20: sparse: using member 'nvoices' in incomplete struct snd_seq_oss_reg sound/drivers/opl3/opl3_oss.c:136:20: sparse: using member 'subtype' in incomplete struct snd_seq_oss_reg sound/drivers/opl3/opl3_oss.c:137:20: sparse: using member 'nvoices' in incomplete struct snd_seq_oss_reg sound/drivers/opl3/opl3_oss.c:139:12: sparse: using member 'oper' in incomplete struct snd_seq_oss_reg sound/drivers/opl3/opl3_oss.c:140:12: sparse: using member 'private_data' in incomplete struct snd_seq_oss_reg sound/drivers/opl3/opl3_oss.c:151:17: sparse: no member 'oss_seq_dev' in struct snd_opl3 sound/drivers/opl3/opl3_oss.c:153:21: sparse: no member 'oss_seq_dev' in struct snd_opl3 sound/drivers/opl3/opl3_oss.c:256:22: sparse: Expected constant expression in case statement sound/drivers/opl3/opl3_oss.c:262:22: sparse: Expected constant expression in case statement sound/drivers/opl3/opl3_oss.c:265:22: sparse: Expected constant expression in case statement sound/drivers/opl3/opl3_oss.c:24:41: warning: 'struct snd_seq_oss_arg' declared inside parameter list will not be visible outside of this definition or declaration static int snd_opl3_open_seq_oss(struct snd_seq_oss_arg *arg, void *closure); ^~~~~~~~~~~~~~~ sound/drivers/opl3/opl3_oss.c:25:42: warning: 'struct snd_seq_oss_arg' declared inside parameter list will not be visible outside of this definition or declaration static int snd_opl3_close_seq_oss(struct snd_seq_oss_arg *arg); ^~~~~~~~~~~~~~~ sound/drivers/opl3/opl3_oss.c:26:42: warning: 'struct snd_seq_oss_arg' declared inside parameter list will not be visible outside of this definition or declaration static int snd_opl3_ioctl_seq_oss(struct snd_seq_oss_arg *arg, unsigned int cmd, unsigned long ioarg); ^~~~~~~~~~~~~~~ sound/drivers/opl3/opl3_oss.c:27:47: warning: 'struct snd_seq_oss_arg' declared inside parameter list will not be visible outside of this definition or declaration static int snd_opl3_load_patch_seq_oss(struct snd_seq_oss_arg *arg, int format, const char __user *buf, int offs, int count); ^~~~~~~~~~~~~~~ sound/drivers/opl3/opl3_oss.c:28:42: warning: 'struct snd_seq_oss_arg' declared inside parameter list will not be visible outside of this definition or declaration static int snd_opl3_reset_seq_oss(struct snd_seq_oss_arg *arg); ^~~~~~~~~~~~~~~ sound/drivers/opl3/opl3_oss.c:48:15: error: variable 'oss_callback' has initializer but incomplete type static struct snd_seq_oss_callback oss_callback = { ^~~~~~~~~~~~~~~~~~~~ sound/drivers/opl3/opl3_oss.c:49:2: error: unknown field 'owner' specified in initializer .owner = THIS_MODULE, ^ In file included from sound/drivers/opl3/opl3_oss.c:21:0: include/linux/export.h:35:21: warning: excess elements in struct initializer #define THIS_MODULE (&__this_module) ^ sound/drivers/opl3/opl3_oss.c:49:12: note: in expansion of macro 'THIS_MODULE' .owner = THIS_MODULE, ^~~~~~~~~~~ include/linux/export.h:35:21: note: (near initialization for 'oss_callback') #define THIS_MODULE (&__this_module) ^ sound/drivers/opl3/opl3_oss.c:49:12: note: in expansion of macro 'THIS_MODULE' .owner = THIS_MODULE, ^~~~~~~~~~~ sound/drivers/opl3/opl3_oss.c:50:2: error: unknown field 'open' specified in initializer .open = snd_opl3_open_seq_oss, ^ sound/drivers/opl3/opl3_oss.c:50:11: warning: excess elements in struct initializer .open = snd_opl3_open_seq_oss, ^~~~~~~~~~~~~~~~~~~~~ sound/drivers/opl3/opl3_oss.c:50:11: note: (near initialization for 'oss_callback') sound/drivers/opl3/opl3_oss.c:51:2: error: unknown field 'close' specified in initializer .close = snd_opl3_close_seq_oss, ^ sound/drivers/opl3/opl3_oss.c:51:11: warning: excess elements in struct initializer .close = snd_opl3_close_seq_oss, ^~~~~~~~~~~~~~~~~~~~~~ sound/drivers/opl3/opl3_oss.c:51:11: note: (near initialization for 'oss_callback') sound/drivers/opl3/opl3_oss.c:52:2: error: unknown field 'ioctl' specified in initializer .ioctl = snd_opl3_ioctl_seq_oss, ^ sound/drivers/opl3/opl3_oss.c:52:11: warning: excess elements in struct initializer .ioctl = snd_opl3_ioctl_seq_oss, ^~~~~~~~~~~~~~~~~~~~~~ sound/drivers/opl3/opl3_oss.c:52:11: note: (near initialization for 'oss_callback') sound/drivers/opl3/opl3_oss.c:53:2: error: unknown field 'load_patch' specified in initializer .load_patch = snd_opl3_load_patch_seq_oss, ^ sound/drivers/opl3/opl3_oss.c:53:16: warning: excess elements in struct initializer .load_patch = snd_opl3_load_patch_seq_oss, vim +/case +256 sound/drivers/opl3/opl3_oss.c 5e246b85 Takashi Iwai 2008-08-08 166 return -ENXIO; ^1da177e Linus Torvalds 2005-04-16 167 ^1da177e Linus Torvalds 2005-04-16 168 if ((err = snd_opl3_synth_setup(opl3)) < 0) ^1da177e Linus Torvalds 2005-04-16 169 return err; ^1da177e Linus Torvalds 2005-04-16 170 ^1da177e Linus Torvalds 2005-04-16 171 /* fill the argument data */ ^1da177e Linus Torvalds 2005-04-16 @172 arg->private_data = opl3; ^1da177e Linus Torvalds 2005-04-16 173 arg->addr.client = opl3->oss_chset->client; ^1da177e Linus Torvalds 2005-04-16 174 arg->addr.port = opl3->oss_chset->port; ^1da177e Linus Torvalds 2005-04-16 175 ^1da177e Linus Torvalds 2005-04-16 176 if ((err = snd_opl3_synth_use_inc(opl3)) < 0) ^1da177e Linus Torvalds 2005-04-16 177 return err; ^1da177e Linus Torvalds 2005-04-16 178 ^1da177e Linus Torvalds 2005-04-16 179 opl3->synth_mode = SNDRV_OPL3_MODE_SYNTH; ^1da177e Linus Torvalds 2005-04-16 180 return 0; ^1da177e Linus Torvalds 2005-04-16 181 } ^1da177e Linus Torvalds 2005-04-16 182 ^1da177e Linus Torvalds 2005-04-16 183 /* close OSS sequencer */ 5b1646a8 Takashi Iwai 2005-11-17 184 static int snd_opl3_close_seq_oss(struct snd_seq_oss_arg *arg) ^1da177e Linus Torvalds 2005-04-16 185 { 5b1646a8 Takashi Iwai 2005-11-17 186 struct snd_opl3 *opl3; ^1da177e Linus Torvalds 2005-04-16 187 5e246b85 Takashi Iwai 2008-08-08 188 if (snd_BUG_ON(!arg)) 5e246b85 Takashi Iwai 2008-08-08 189 return -ENXIO; ^1da177e Linus Torvalds 2005-04-16 190 opl3 = arg->private_data; ^1da177e Linus Torvalds 2005-04-16 191 ^1da177e Linus Torvalds 2005-04-16 192 snd_opl3_synth_cleanup(opl3); ^1da177e Linus Torvalds 2005-04-16 193 ^1da177e Linus Torvalds 2005-04-16 194 snd_opl3_synth_use_dec(opl3); ^1da177e Linus Torvalds 2005-04-16 195 return 0; ^1da177e Linus Torvalds 2005-04-16 196 } ^1da177e Linus Torvalds 2005-04-16 197 ^1da177e Linus Torvalds 2005-04-16 198 /* load patch */ ^1da177e Linus Torvalds 2005-04-16 199 ^1da177e Linus Torvalds 2005-04-16 200 /* from sound_config.h */ ^1da177e Linus Torvalds 2005-04-16 201 #define SBFM_MAXINSTR 256 ^1da177e Linus Torvalds 2005-04-16 202 5b1646a8 Takashi Iwai 2005-11-17 203 static int snd_opl3_load_patch_seq_oss(struct snd_seq_oss_arg *arg, int format, ^1da177e Linus Torvalds 2005-04-16 204 const char __user *buf, int offs, int count) ^1da177e Linus Torvalds 2005-04-16 205 { 5b1646a8 Takashi Iwai 2005-11-17 206 struct snd_opl3 *opl3; 224a0332 Takashi Iwai 2007-10-30 207 struct sbi_instrument sbi; 224a0332 Takashi Iwai 2007-10-30 208 char name[32]; 224a0332 Takashi Iwai 2007-10-30 209 int err, type; ^1da177e Linus Torvalds 2005-04-16 210 5e246b85 Takashi Iwai 2008-08-08 211 if (snd_BUG_ON(!arg)) 5e246b85 Takashi Iwai 2008-08-08 212 return -ENXIO; ^1da177e Linus Torvalds 2005-04-16 213 opl3 = arg->private_data; ^1da177e Linus Torvalds 2005-04-16 214 224a0332 Takashi Iwai 2007-10-30 215 if (format == FM_PATCH) 224a0332 Takashi Iwai 2007-10-30 216 type = FM_PATCH_OPL2; 224a0332 Takashi Iwai 2007-10-30 217 else if (format == OPL3_PATCH) 224a0332 Takashi Iwai 2007-10-30 218 type = FM_PATCH_OPL3; 224a0332 Takashi Iwai 2007-10-30 219 else 224a0332 Takashi Iwai 2007-10-30 220 return -EINVAL; ^1da177e Linus Torvalds 2005-04-16 221 ^1da177e Linus Torvalds 2005-04-16 222 if (count < (int)sizeof(sbi)) { 45203832 Takashi Iwai 2009-02-05 223 snd_printk(KERN_ERR "FM Error: Patch record too short\n"); ^1da177e Linus Torvalds 2005-04-16 224 return -EINVAL; ^1da177e Linus Torvalds 2005-04-16 225 } ^1da177e Linus Torvalds 2005-04-16 226 if (copy_from_user(&sbi, buf, sizeof(sbi))) ^1da177e Linus Torvalds 2005-04-16 227 return -EFAULT; ^1da177e Linus Torvalds 2005-04-16 228 ^1da177e Linus Torvalds 2005-04-16 229 if (sbi.channel < 0 || sbi.channel >= SBFM_MAXINSTR) { 45203832 Takashi Iwai 2009-02-05 230 snd_printk(KERN_ERR "FM Error: Invalid instrument number %d\n", 224a0332 Takashi Iwai 2007-10-30 231 sbi.channel); ^1da177e Linus Torvalds 2005-04-16 232 return -EINVAL; ^1da177e Linus Torvalds 2005-04-16 233 } ^1da177e Linus Torvalds 2005-04-16 234 224a0332 Takashi Iwai 2007-10-30 235 memset(name, 0, sizeof(name)); 224a0332 Takashi Iwai 2007-10-30 236 sprintf(name, "Chan%d", sbi.channel); ^1da177e Linus Torvalds 2005-04-16 237 224a0332 Takashi Iwai 2007-10-30 238 err = snd_opl3_load_patch(opl3, sbi.channel, 127, type, name, NULL, 224a0332 Takashi Iwai 2007-10-30 239 sbi.operators); 224a0332 Takashi Iwai 2007-10-30 240 if (err < 0) ^1da177e Linus Torvalds 2005-04-16 241 return err; 224a0332 Takashi Iwai 2007-10-30 242 224a0332 Takashi Iwai 2007-10-30 243 return sizeof(sbi); ^1da177e Linus Torvalds 2005-04-16 244 } ^1da177e Linus Torvalds 2005-04-16 245 ^1da177e Linus Torvalds 2005-04-16 246 /* ioctl */ 5b1646a8 Takashi Iwai 2005-11-17 247 static int snd_opl3_ioctl_seq_oss(struct snd_seq_oss_arg *arg, unsigned int cmd, ^1da177e Linus Torvalds 2005-04-16 248 unsigned long ioarg) ^1da177e Linus Torvalds 2005-04-16 249 { 5b1646a8 Takashi Iwai 2005-11-17 250 struct snd_opl3 *opl3; ^1da177e Linus Torvalds 2005-04-16 251 5e246b85 Takashi Iwai 2008-08-08 252 if (snd_BUG_ON(!arg)) 5e246b85 Takashi Iwai 2008-08-08 253 return -ENXIO; ^1da177e Linus Torvalds 2005-04-16 254 opl3 = arg->private_data; ^1da177e Linus Torvalds 2005-04-16 255 switch (cmd) { ^1da177e Linus Torvalds 2005-04-16 @256 case SNDCTL_FM_LOAD_INSTR: 45203832 Takashi Iwai 2009-02-05 257 snd_printk(KERN_ERR "OPL3: " 45203832 Takashi Iwai 2009-02-05 258 "Obsolete ioctl(SNDCTL_FM_LOAD_INSTR) used. " 45203832 Takashi Iwai 2009-02-05 259 "Fix the program.\n"); :::::: The code at line 256 was first introduced by commit :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 :::::: TO: Linus Torvalds <torvalds(a)ppc970.osdl.org> :::::: CC: Linus Torvalds <torvalds(a)ppc970.osdl.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH v12 00/14] sun4i-codec: Add Line-In, FM-In, Mic 2, Capture Source, Differential Line-In
by Danny Milosavljevic 09 Jun '17

09 Jun '17

This patchset adds some mixer controls to sun4i-codec. It also adds a mux for the capture source and the PGA for the MIC2 preamp. Where possible, it uses SOC_DAPM_DOUBLE in order to cut down on the number of distinct controls in alsamixer. v12 changes compared to v11 are: - Split u patchset in another way. - Renamed "Mic1 Capture Volume" to "Mic1 Boost Volume". - Renamed "Mic2 Capture Volume" to "Mic2 Boost Volume". - Renamed "Line Capture Volume" to "Line Boost Volume". - Renamed "Differential Line Capture Switch" to "Differential Line Source". v11 changes compared to v10 are: - Split up patchset. - Fixed typo in Differential Line Capture Switch. - Renamed "Non-Differential" value to "Stereo". - Removed duplicate PA Volume mixer control. v10 changes compared to v9 are: - Use SOC_DAPM_DOUBLE where possible and it makes sense in order to cut down on the number of controls. v9 changes compared to v8 are: - added Line Differential Capture Switch. - split Capture Source into Left Capture Select, Right Capture Select. - added Line Capture Volume. - rename "sun4i_codec_widgets" to "sun4i_codec_controls" for consistency with the struct field it's used in. - rename "Line-In" to "Line". - rename "Power Amplifier Playback Volume" to "Headphone Playback Volume". v8 changes compared to v7 are: - fixed the routes for line and mic capturing. v7 changes compared to v6 are: - preparation for different A20, A10 controls is now in an extra patch. - all register definitions are now at the top. - sun7i-specific things (A20-specific things) are now less grouped-together. - rename "Power Amplifier Volume" to "Power Amplifier Playback Volume". v6 changes compared to v5 are: - Mic preamplifier special cases for A20 and A10 now are now not icky: There are two different _widget arrays and the probe() function now selects the right one to pass to snd_soc_register_codec() unmodified. - sun7i-specific things (A20-specific things) are now grouped together. v5 changes compared to v4 are: - Mic preamplifier controls have more common names now. - Mic preamplifier scale has a 0 dB entry as well now, as documented in the A20 user manual. - Mic preamplifier has special cases for A20 and A10 now. - Gain controls have "Gain" in the name now. v4 changes compared to v3 are: - names of the input are not uppercase anymore. - bit index constants are now named as in the A20 user manual v1.4. - added Mic1-In, Mac2-In. - added Mic1 and Mic2 Pre-Amplifiers. v3 changes compared to v2 are: - added DAPM routes. v2 changes compared to v1 are: - moved Line-In and FM-In playback switches to their respective sun4i_codec_*_mixer_controls. v1 changes: - added linein, fmin output volumes and switches. Danny Milosavljevic (14): sun4i-codec: Add MIC2 Pre-Amplifier, Mic2 input, Mic2 routes. sun4i-codec: Add Mic Playback Volume. sun4i-codec: Add support for extra controls to struct sun4i_codec_quirks and use them. sun4i-codec: Add Mic1 Boost Volume, Mic2 Boost Volume. sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls. sun4i-codec: Add Mic1 Playback Switch, Mic2 Playback Switch. sun4i-codec: Add FM Playback Volume. sun4i-codec: Add FM Left, FM Right, FM Playback Switch. sun4i-codec: Add Line Playback Volume. sun4i-codec: Add Line Boost Volume. sun4i-codec: Add Line Right, Line Left, Line Playback Switch. sun4i-codec: Add Differential Line Source. sun4i-codec: Add Left Capture Select, Right Capture Select. sun4i-codec: Add Capture Volume. sound/soc/sunxi/sun4i-codec.c | 233 +++++++++++++++++++++++++++++++++++++----- 1 file changed, 210 insertions(+), 23 deletions(-) -- 2.1.4

1 14

[alsa-devel] [PATCH] ASoC: Intel: byt-max98090 Fix GPIOs lookup
by Dmitry Torokhov 09 Jun '17

09 Jun '17

From: Nicolas Porcel <nicolasporcel06(a)gmail.com> Commit 9c3c9bc9cc98 ("gpiolib: tighten up ACPI legacy gpio lookups") changed the way fallback to _CRS-defined GPIOs is executed by requiring drivers use common connection ID for all GPIOs fetched from _CRS. This broke byt-max98090 driver, which expected GPIO core to ignore the names it supplied and simply give GPIOs 0 and 1 from whatever block it finds. By giving the same name to both GPIOs 0 and 1, the driver will perform the lookup for both of them instead of the first requested. This is the same behavior than before the commit. Signed-off-by: Nicolas Porcel <nicolasporcel06(a)gmail.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov(a)gmail.com> --- sound/soc/intel/boards/byt-max98090.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/boards/byt-max98090.c b/sound/soc/intel/boards/byt-max98090.c index d9f81b8d915d..a6e57d95c1e2 100644 --- a/sound/soc/intel/boards/byt-max98090.c +++ b/sound/soc/intel/boards/byt-max98090.c @@ -67,13 +67,13 @@ static struct snd_soc_jack_pin hs_jack_pins[] = { static struct snd_soc_jack_gpio hs_jack_gpios[] = { { - .name = "hp-gpio", + .name = "byt_max98090", .idx = 0, .report = SND_JACK_HEADPHONE | SND_JACK_LINEOUT, .debounce_time = 200, }, { - .name = "mic-gpio", + .name = "byt_max98090", .idx = 1, .invert = 1, .report = SND_JACK_MICROPHONE, -- 2.13.0.506.g27d5fe0cd-goog -- Dmitry

2 1