May 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v2] sound: Disable the build of OSS drivers
by Takashi Iwai 12 May '17

12 May '17

OSS drivers are left as badly unmaintained, and now we're facing a problem to clean up the hackish set_fs() usage in their codes. Since most of drivers have been covered by ALSA, and the others are dead old and inactive, let's leave them RIP. This patch is the first step: disable the build of OSS drivers. We'll eventually drop the whole codes and clean up later. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- v1->v2: Smaller changes, as Linus and Randy suggested. The first dmasound Kconfig inclusion is still commented out since it's shorter/simpler in the end. sound/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/Kconfig b/sound/Kconfig index ee2e69a9ecd1..de23fc39cec8 100644 --- a/sound/Kconfig +++ b/sound/Kconfig @@ -54,7 +54,7 @@ config SOUND_OSS_CORE_PRECLAIM If unsure, say Y. -source "sound/oss/dmasound/Kconfig" +# source "sound/oss/dmasound/Kconfig" if !M68K && !UML @@ -115,6 +115,7 @@ endif # SND menuconfig SOUND_PRIME tristate "Open Sound System (DEPRECATED)" select SOUND_OSS_CORE + depends on BROKEN help Say 'Y' or 'M' to enable Open Sound System drivers. -- 2.12.2

3 2

[alsa-devel] [sound:topic/kill-set_fs 40/43] sound/soc/blackfin/bf5xx-ac97.c:62:30: error: 'SRC' undeclared
by kbuild test robot 11 May '17

11 May '17

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/kill-set_fs head: 79778abbaa9e2c939edeee9a9f6e56a519325110 commit: f96cf8a3d3ada486bdef6aca6d8a615429c03d0b [40/43] ASoC: blackfin: Convert to copy_silence ops config: blackfin-allmodconfig (attached as .config) compiler: bfin-uclinux-gcc (GCC) 6.2.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout f96cf8a3d3ada486bdef6aca6d8a615429c03d0b # save the attached .config to linux build tree make.cross ARCH=blackfin All errors (new ones prefixed by >>): sound/soc/blackfin/bf5xx-ac97.c: In function 'bf5xx_pcm_to_ac97': >> sound/soc/blackfin/bf5xx-ac97.c:62:30: error: 'SRC' undeclared (first use in this function) dst->ac97_pcm_l = GET_VAL(SRC); ^ sound/soc/blackfin/bf5xx-ac97.c:47:24: note: in definition of macro 'GET_VAL' #define GET_VAL(src) (*src++) /* copy only */ ^~~ sound/soc/blackfin/bf5xx-ac97.c:62:30: note: each undeclared identifier is reported only once for each function it appears in dst->ac97_pcm_l = GET_VAL(SRC); ^ sound/soc/blackfin/bf5xx-ac97.c:47:24: note: in definition of macro 'GET_VAL' #define GET_VAL(src) (*src++) /* copy only */ ^~~ vim +/SRC +62 sound/soc/blackfin/bf5xx-ac97.c 56 dst->ac97_tag = TAG_VALID; 57 if (chan_mask & SP_FL) { 58 dst->ac97_pcm_r = GET_VAL(src); 59 dst->ac97_tag |= TAG_PCM_RIGHT; 60 } 61 if (chan_mask & SP_FR) { > 62 dst->ac97_pcm_l = GET_VAL(SRC); 63 dst->ac97_tag |= TAG_PCM_LEFT; 64 65 } --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

Re: [alsa-devel] [PATCH v2 3/3] ASoC: stm32: Add full duplex support to i2s (fwd)
by Julia Lawall 11 May '17

11 May '17

Please check whether the lock taken on line 585 should be freed on line 598. The report also mentions line 652, although that is not shown. julia ---------- Forwarded message ---------- Date: Thu, 11 May 2017 09:49:21 +0800 From: kbuild test robot <fengguang.wu(a)intel.com> To: kbuild(a)01.org Cc: Julia Lawall <julia.lawall(a)lip6.fr> Subject: Re: [alsa-devel] [PATCH v2 3/3] ASoC: stm32: Add full duplex support to i2s Hi olivier, [auto build test WARNING on asoc/for-next] [also build test WARNING on next-20170510] [cannot apply to v4.11] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/olivier-moysan/Add-I2S-driver/2017… base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next :::::: branch date: 2 hours ago :::::: commit date: 2 hours ago >> sound/soc/stm/stm32_i2s.c:598:3-9: preceding lock on line 585 >> sound/soc/stm/stm32_i2s.c:598:3-9: preceding lock on line 585 sound/soc/stm/stm32_i2s.c:652:3-9: preceding lock on line 585 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 9f5663c4aa8961bf2a547683af787e606503376e vim +598 sound/soc/stm/stm32_i2s.c 1ebd36ae olivier moysan 2017-05-10 579 { 1ebd36ae olivier moysan 2017-05-10 580 struct stm32_i2s_data *i2s = snd_soc_dai_get_drvdata(cpu_dai); 1ebd36ae olivier moysan 2017-05-10 581 bool playback_flg = (substream->stream == SNDRV_PCM_STREAM_PLAYBACK); 9f5663c4 olivier moysan 2017-05-10 582 u32 cfg1_mask, ier; 1ebd36ae olivier moysan 2017-05-10 583 int ret; 1ebd36ae olivier moysan 2017-05-10 584 9f5663c4 olivier moysan 2017-05-10 @585 spin_lock(&i2s->lock_fd); 9f5663c4 olivier moysan 2017-05-10 586 1ebd36ae olivier moysan 2017-05-10 587 switch (cmd) { 1ebd36ae olivier moysan 2017-05-10 588 case SNDRV_PCM_TRIGGER_START: 1ebd36ae olivier moysan 2017-05-10 589 case SNDRV_PCM_TRIGGER_RESUME: 1ebd36ae olivier moysan 2017-05-10 590 case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: 1ebd36ae olivier moysan 2017-05-10 591 /* Enable i2s */ 1ebd36ae olivier moysan 2017-05-10 592 dev_dbg(cpu_dai->dev, "start I2S\n"); 1ebd36ae olivier moysan 2017-05-10 593 1ebd36ae olivier moysan 2017-05-10 594 ret = regmap_update_bits(i2s->regmap, STM32_I2S_CR1_REG, 1ebd36ae olivier moysan 2017-05-10 595 I2S_CR1_SPE, I2S_CR1_SPE); 1ebd36ae olivier moysan 2017-05-10 596 if (ret < 0) { 1ebd36ae olivier moysan 2017-05-10 597 dev_err(cpu_dai->dev, "Error %d enabling I2S\n", ret); 1ebd36ae olivier moysan 2017-05-10 @598 return ret; 1ebd36ae olivier moysan 2017-05-10 599 } 1ebd36ae olivier moysan 2017-05-10 600 1ebd36ae olivier moysan 2017-05-10 601 ret = regmap_update_bits(i2s->regmap, STM32_I2S_CR1_REG, :::::: The code at line 598 was first introduced by commit :::::: 1ebd36ae636af5c130a9df4d9a921e4ed984a6e9 ASoC: stm32: Add I2S driver :::::: TO: olivier moysan <olivier.moysan(a)st.com> :::::: CC: 0day robot <fengguang.wu(a)intel.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH] ASoC: Intel: sst: fix spelling mistake: "allocationf" -> "allocation"
by Colin King 10 May '17

10 May '17

From: Colin Ian King <colin.king(a)canonical.com> Trivial fix to spelling mistake in dev_err message. Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/atom/sst-mfld-platform-pcm.c b/sound/soc/intel/atom/sst-mfld-platform-pcm.c index 21cac1c8dd4c..e74119113713 100644 --- a/sound/soc/intel/atom/sst-mfld-platform-pcm.c +++ b/sound/soc/intel/atom/sst-mfld-platform-pcm.c @@ -690,7 +690,7 @@ static int sst_pcm_new(struct snd_soc_pcm_runtime *rtd) snd_dma_continuous_data(GFP_DMA), SST_MIN_BUFFER, SST_MAX_BUFFER); if (retval) { - dev_err(rtd->dev, "dma buffer allocationf fail\n"); + dev_err(rtd->dev, "dma buffer allocation fail\n"); return retval; } } -- 2.11.0

2 1

[alsa-devel] [PATCH] conf: topology: Fix index mismatch for skl and bxt
by Subhransu S. Prusty 10 May '17

10 May '17

The topology index in the conf is set to 1, where the driver expects index set to 0. Fix the inconsistency. Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty(a)intel.com> --- src/conf/topology/bxtrt298/bxt_i2s.conf | 62 ++++++++++++++++----------------- src/conf/topology/sklrt286/skl_i2s.conf | 56 ++++++++++++++--------------- 2 files changed, 59 insertions(+), 59 deletions(-) diff --git a/src/conf/topology/bxtrt298/bxt_i2s.conf b/src/conf/topology/bxtrt298/bxt_i2s.conf index 3b7a54e3a323..6b38f4f3c5ae 100644 --- a/src/conf/topology/bxtrt298/bxt_i2s.conf +++ b/src/conf/topology/bxtrt298/bxt_i2s.conf @@ -2924,7 +2924,7 @@ SectionData."lib_data" { SectionControlMixer."media0_in mi Switch" { - index"1" + index"0" invert "false" max "1" min"0" @@ -2944,7 +2944,7 @@ SectionControlMixer."media0_in mi Switch" { } } SectionControlMixer."dmic01_hifi_in mi Switch" { - index"1" + index"0" invert "false" max "1" min"0" @@ -2964,7 +2964,7 @@ SectionControlMixer."dmic01_hifi_in mi Switch" { } } SectionControlMixer."codec0_in mi Switch" { - index"1" + index"0" invert "false" max "1" min"0" @@ -2986,7 +2986,7 @@ SectionControlMixer."codec0_in mi Switch" { SectionWidget."media0_in cpr 0" { - index"1" + index"0" type"mixer" no_pm "true" event_type "3" @@ -2998,7 +2998,7 @@ SectionWidget."media0_in cpr 0" { ] } SectionWidget."media0_in mi" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -3011,7 +3011,7 @@ SectionWidget."media0_in mi" { ] } SectionWidget."codec0_in cpr 1" { - index"1" + index"0" type"mixer" no_pm "true" event_type "3" @@ -3023,7 +3023,7 @@ SectionWidget."codec0_in cpr 1" { ] } SectionWidget."codec0_in mi" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -3036,12 +3036,12 @@ SectionWidget."codec0_in mi" { ] } SectionWidget."codec0_in" { - index"1" + index"0" type"aif_in" no_pm "true" } SectionWidget."codec0_out mo" { - index"1" + index"0" type"mixer" no_pm "true" event_type "1" @@ -3059,7 +3059,7 @@ SectionWidget."codec0_out mo" { ] } SectionWidget."codec0_out cpr 2" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -3070,12 +3070,12 @@ SectionWidget."codec0_out cpr 2" { ] } SectionWidget."codec0_out" { - index"1" + index"0" type"aif_out" no_pm "true" } SectionWidget."media0_out mo" { - index"1" + index"0" type"mixer" no_pm "true" event_type "1" @@ -3093,7 +3093,7 @@ SectionWidget."media0_out mo" { ] } SectionWidget."media0_out cpr 3" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -3104,7 +3104,7 @@ SectionWidget."media0_out cpr 3" { ] } SectionWidget."dmic01_hifi_in cpr 4" { - index"1" + index"0" type"mixer" no_pm "true" event_type "3" @@ -3116,7 +3116,7 @@ SectionWidget."dmic01_hifi_in cpr 4" { ] } SectionWidget."dmic01_hifi_in mi" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -3129,12 +3129,12 @@ SectionWidget."dmic01_hifi_in mi" { ] } SectionWidget."dmic01_hifi" { - index"1" + index"0" type"aif_in" no_pm "true" } SectionWidget."codec1_out mo" { - index"1" + index"0" type"mixer" no_pm "true" event_type "1" @@ -3152,7 +3152,7 @@ SectionWidget."codec1_out mo" { ] } SectionWidget."codec1_out cpr 5" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -3163,12 +3163,12 @@ SectionWidget."codec1_out cpr 5" { ] } SectionWidget."codec1_out" { - index"1" + index"0" type"aif_out" no_pm "true" } SectionWidget."hdmi1_pt_out cpr 6" { - index"1" + index"0" type"mixer" no_pm "true" event_type "3" @@ -3180,7 +3180,7 @@ SectionWidget."hdmi1_pt_out cpr 6" { ] } SectionWidget."hdmi1_pt_out cpr 7" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -3191,12 +3191,12 @@ SectionWidget."hdmi1_pt_out cpr 7" { ] } SectionWidget."iDisp1_out" { - index"1" + index"0" type"aif_out" no_pm "true" } SectionWidget."hdmi2_pt_out cpr 8" { - index"1" + index"0" type"mixer" no_pm "true" event_type "3" @@ -3208,7 +3208,7 @@ SectionWidget."hdmi2_pt_out cpr 8" { ] } SectionWidget."hdmi2_pt_out cpr 9" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -3219,12 +3219,12 @@ SectionWidget."hdmi2_pt_out cpr 9" { ] } SectionWidget."iDisp2_out" { - index"1" + index"0" type"aif_out" no_pm "true" } SectionWidget."hdmi3_pt_out cpr 10" { - index"1" + index"0" type"mixer" no_pm "true" event_type "3" @@ -3236,7 +3236,7 @@ SectionWidget."hdmi3_pt_out cpr 10" { ] } SectionWidget."hdmi3_pt_out cpr 11" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -3247,12 +3247,12 @@ SectionWidget."hdmi3_pt_out cpr 11" { ] } SectionWidget."iDisp3_out" { - index"1" + index"0" type"aif_out" no_pm "true" } SectionWidget."mch_cap_in cpr 12" { - index"1" + index"0" type"mixer" no_pm "true" event_type "3" @@ -3264,7 +3264,7 @@ SectionWidget."mch_cap_in cpr 12" { ] } SectionWidget."mch_cap_in cpr 13" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -3283,7 +3283,7 @@ SectionManifest."lib_data" { } SectionGraph."Pipeline 1 Graph" { - index"1" + index"0" lines [ "media0_in mi, , media0_in cpr 0" "media0_in cpr 0, , System Playback" diff --git a/src/conf/topology/sklrt286/skl_i2s.conf b/src/conf/topology/sklrt286/skl_i2s.conf index bb1fe4f8435f..fbf041bfd0cf 100644 --- a/src/conf/topology/sklrt286/skl_i2s.conf +++ b/src/conf/topology/sklrt286/skl_i2s.conf @@ -2604,7 +2604,7 @@ SectionData."hdmi3_pt_out cpr 12" { SectionControlMixer."media0_in mi Switch" { - index"1" + index"0" invert "false" max "1" min"0" @@ -2624,7 +2624,7 @@ SectionControlMixer."media0_in mi Switch" { } } SectionControlMixer."codec0_in mi Switch" { - index"1" + index"0" invert "false" max "1" min"0" @@ -2644,7 +2644,7 @@ SectionControlMixer."codec0_in mi Switch" { } } SectionControlMixer."dmic01_hifi_in mi Switch" { - index"1" + index"0" invert "false" max "1" min"0" @@ -2666,7 +2666,7 @@ SectionControlMixer."dmic01_hifi_in mi Switch" { SectionWidget."media0_in cpr 0" { - index"1" + index"0" type"mixer" no_pm "true" event_type "3" @@ -2678,7 +2678,7 @@ SectionWidget."media0_in cpr 0" { ] } SectionWidget."media0_in mi" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -2691,7 +2691,7 @@ SectionWidget."media0_in mi" { ] } SectionWidget."media0_out mo" { - index"1" + index"0" type"mixer" no_pm "true" event_type "1" @@ -2709,7 +2709,7 @@ SectionWidget."media0_out mo" { ] } SectionWidget."media0_out cpr 6" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -2720,7 +2720,7 @@ SectionWidget."media0_out cpr 6" { ] } SectionWidget."codec0_out mo" { - index"1" + index"0" type"mixer" no_pm "true" event_type "1" @@ -2738,7 +2738,7 @@ SectionWidget."codec0_out mo" { ] } SectionWidget."codec0_out cpr 4" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -2749,12 +2749,12 @@ SectionWidget."codec0_out cpr 4" { ] } SectionWidget."codec0_out" { - index"1" + index"0" type"aif_out" no_pm "true" } SectionWidget."codec1_out mo" { - index"1" + index"0" type"mixer" no_pm "true" event_type "1" @@ -2772,7 +2772,7 @@ SectionWidget."codec1_out mo" { ] } SectionWidget."codec1_out cpr 5" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -2783,12 +2783,12 @@ SectionWidget."codec1_out cpr 5" { ] } SectionWidget."codec1_out" { - index"1" + index"0" type"aif_out" no_pm "true" } SectionWidget."codec0_in cpr 1" { - index"1" + index"0" type"mixer" no_pm "true" event_type "3" @@ -2800,7 +2800,7 @@ SectionWidget."codec0_in cpr 1" { ] } SectionWidget."codec0_in mi" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -2813,12 +2813,12 @@ SectionWidget."codec0_in mi" { ] } SectionWidget."codec0_in" { - index"1" + index"0" type"aif_in" no_pm "true" } SectionWidget."dmic01_hifi_in cpr 3" { - index"1" + index"0" type"mixer" no_pm "true" event_type "3" @@ -2830,7 +2830,7 @@ SectionWidget."dmic01_hifi_in cpr 3" { ] } SectionWidget."dmic01_hifi_in mi" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -2843,12 +2843,12 @@ SectionWidget."dmic01_hifi_in mi" { ] } SectionWidget."dmic01_hifi" { - index"1" + index"0" type"aif_in" no_pm "true" } SectionWidget."hdmi1_pt_out cpr 7" { - index"1" + index"0" type"mixer" no_pm "true" event_type "3" @@ -2860,7 +2860,7 @@ SectionWidget."hdmi1_pt_out cpr 7" { ] } SectionWidget."hdmi1_pt_out cpr 8" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -2871,12 +2871,12 @@ SectionWidget."hdmi1_pt_out cpr 8" { ] } SectionWidget."iDisp1_out" { - index"1" + index"0" type"aif_out" no_pm "true" } SectionWidget."hdmi2_pt_out cpr 9" { - index"1" + index"0" type"mixer" no_pm "true" event_type "3" @@ -2888,7 +2888,7 @@ SectionWidget."hdmi2_pt_out cpr 9" { ] } SectionWidget."hdmi2_pt_out cpr 10" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -2899,12 +2899,12 @@ SectionWidget."hdmi2_pt_out cpr 10" { ] } SectionWidget."iDisp2_out" { - index"1" + index"0" type"aif_out" no_pm "true" } SectionWidget."hdmi3_pt_out cpr 11" { - index"1" + index"0" type"mixer" no_pm "true" event_type "3" @@ -2916,7 +2916,7 @@ SectionWidget."hdmi3_pt_out cpr 11" { ] } SectionWidget."hdmi3_pt_out cpr 12" { - index"1" + index"0" type"pga" no_pm "true" event_type "4" @@ -2927,7 +2927,7 @@ SectionWidget."hdmi3_pt_out cpr 12" { ] } SectionGraph."Pipeline 1 Graph" { - index"1" + index"0" lines [ "media0_in mi, , media0_in cpr 0" "media0_in cpr 0, , System Playback" -- 1.9.1

2 1

[alsa-devel] [PATCH] ALSA: hda: Fix cpu lockup when stopping the cmd dmas
by jeeja.kp＠intel.com 10 May '17

10 May '17

From: Jeeja KP <jeeja.kp(a)intel.com> Using jiffies in hdac_wait_for_cmd_dmas() to determine when to time out when interrupts are off (snd_hdac_bus_stop_cmd_io()/spin_lock_irq()) causes hard lockup so unlock while waiting using jiffies. ---<-snip->--- <0>[ 1211.603046] NMI watchdog: Watchdog detected hard LOCKUP on cpu 3 <4>[ 1211.603047] Modules linked in: snd_hda_intel i915 vgem <4>[ 1211.603053] irq event stamp: 13366 <4>[ 1211.603053] hardirqs last enabled at (13365): ... <4>[ 1211.603059] Call Trace: <4>[ 1211.603059] ? delay_tsc+0x3d/0xc0 <4>[ 1211.603059] __delay+0xa/0x10 <4>[ 1211.603060] __const_udelay+0x31/0x40 <4>[ 1211.603060] snd_hdac_bus_stop_cmd_io+0x96/0xe0 [snd_hda_core] <4>[ 1211.603060] ? azx_dev_disconnect+0x20/0x20 [snd_hda_intel] <4>[ 1211.603061] snd_hdac_bus_stop_chip+0xb1/0x100 [snd_hda_core] <4>[ 1211.603061] azx_stop_chip+0x9/0x10 [snd_hda_codec] <4>[ 1211.603061] azx_suspend+0x72/0x220 [snd_hda_intel] <4>[ 1211.603061] pci_pm_suspend+0x71/0x140 <4>[ 1211.603062] dpm_run_callback+0x6f/0x330 <4>[ 1211.603062] ? pci_pm_freeze+0xe0/0xe0 <4>[ 1211.603062] __device_suspend+0xf9/0x370 <4>[ 1211.603062] ? dpm_watchdog_set+0x60/0x60 <4>[ 1211.603063] async_suspend+0x1a/0x90 <4>[ 1211.603063] async_run_entry_fn+0x34/0x160 <4>[ 1211.603063] process_one_work+0x1f4/0x6d0 <4>[ 1211.603063] ? process_one_work+0x16e/0x6d0 <4>[ 1211.603064] worker_thread+0x49/0x4a0 <4>[ 1211.603064] kthread+0x107/0x140 <4>[ 1211.603064] ? process_one_work+0x6d0/0x6d0 <4>[ 1211.603065] ? kthread_create_on_node+0x40/0x40 <4>[ 1211.603065] ret_from_fork+0x2e/0x40 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100419 Reported-by: Marta Lofstedt <marta.lofstedt(a)intel.com> Suggested-by: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Jeeja KP <jeeja.kp(a)intel.com> --- sound/hda/hdac_controller.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c index 6f1e99c..0f703372 100644 --- a/sound/hda/hdac_controller.c +++ b/sound/hda/hdac_controller.c @@ -106,7 +106,11 @@ void snd_hdac_bus_stop_cmd_io(struct hdac_bus *bus) /* disable ringbuffer DMAs */ snd_hdac_chip_writeb(bus, RIRBCTL, 0); snd_hdac_chip_writeb(bus, CORBCTL, 0); + spin_unlock_irq(&bus->reg_lock); + hdac_wait_for_cmd_dmas(bus); + + spin_lock_irq(&bus->reg_lock); /* disable unsolicited responses */ snd_hdac_chip_updatel(bus, GCTL, AZX_GCTL_UNSOL, 0); spin_unlock_irq(&bus->reg_lock); -- 2.5.0

3 2

[alsa-devel] `alsatplg` miscompiles UUID in ASoC topology
by ojab 09 May '17

09 May '17

Oh hai! I'm trying to get sound from my HP Chromebook 13 with proper linux and right now messing with ASoC topology: ChromeOS contains topology file that can't be loaded on up-to-date upstream kernel, so I've wrote a parser that converts dfw_sst.bin back to topology.conf that can be processed by `alsatplg`. AFAICS alsatplg miscompiles at least UUID field in the private data: for example `alsatplg -c /usr/share/alsa/topology/sklrt286/skl_i2s.conf -o tplg.bin` produces the file with no UUID in `strings tplg.bin` output and my parser shows that there is nonsense (mostly zeroes) where UUID should be (reproducible with both alsa-{lib,utils}-1.13 and current git master). Is it a bug or I'm doing something wrong? -- //wbr ojab

1 0

[alsa-devel] BUG/Oops triggered by zita-a2j on snd-aloop with 4.10.13
by Jörn Nettingsmeier 08 May '17

08 May '17

Hi *, openSUSE Tumbleweed with kernel Linux hoppetosse.villakunterbunt.netz 4.10.13-1-default #1 SMP PREEMPT Thu Apr 27 12:23:31 UTC 2017 (e5d11ce) x86_64 x86_64 x86_64 GNU/Linux jackd running on a hdspm MADIface, I try to add a zita-a2j client with zita-a2j -v -d hw:jackbridge,1,1 ("jackbridge" is a snd-aloop device) nettings@hoppetosse:~> aplay -l **** List of PLAYBACK Hardware Devices **** card 0: PCH [HDA Intel PCH], device 0: ALC269VC Analog [ALC269VC Analog] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: PCH [HDA Intel PCH], device 3: HDMI 0 [HDMI 0] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: PCH [HDA Intel PCH], device 7: HDMI 1 [HDMI 1] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: PCH [HDA Intel PCH], device 8: HDMI 2 [HDMI 2] Subdevices: 1/1 Subdevice #0: subdevice #0 card 2: ma2chboxXT [RME MADIface], device 0: RME MADIface [RME MADIface] Subdevices: 0/1 Subdevice #0: subdevice #0 card 4: jackbridge [Loopback], device 0: Loopback PCM [Loopback PCM] Subdevices: 2/2 Subdevice #0: subdevice #0 Subdevice #1: subdevice #1 card 4: jackbridge [Loopback], device 1: Loopback PCM [Loopback PCM] Subdevices: 2/2 Subdevice #0: subdevice #0 Subdevice #1: subdevice #1 [ 1416.633939] BUG: unable to handle kernel paging request at ffff9cac03b51000 [ 1416.634046] IP: snd_pcm_format_set_silence+0xea/0x100 [snd_pcm] [ 1416.634092] PGD 17fc9d067 [ 1416.634093] PUD 17fc9e067 [ 1416.634117] PMD 18314b067 [ 1416.634139] PTE 0 [ 1416.634194] Oops: 0002 [#1] PREEMPT SMP [ 1416.634226] Modules linked in: snd_hrtimer snd_seq_midi snd_seq_midi_event snd_seq_dummy snd_seq ccm fuse af_packet nf_log_ipv6 xt_comment nf_log_ipv4 nf_log_common xt_LOG xt_limit uvcvideo videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 videobuf2_core videodev nfnetlink_cthelper nfnetlink ip6t_REJECT nf_reject_ipv6 nf_conntrack_ipv6 nf_defrag_ipv6 ipt_REJECT nf_reject_ipv4 xt_pkttype xt_tcpudp iptable_filter ip6table_mangle nf_conntrack_netbios_ns nf_conntrack_broadcast nf_conntrack_ipv4 nf_defrag_ipv4 ip_tables xt_conntrack nf_conntrack ip6table_filter ip6_tables x_tables msr snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic intel_rapl x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul mei_wdt iTCO_wdt iTCO_vendor_support arc4 ghash_clmulni_intel [ 1416.634838] pcbc iwldvm mac80211 aesni_intel aes_x86_64 iwlwifi crypto_simd glue_helper cryptd snd_hda_intel e1000e snd_hdspm snd_hda_codec cfg80211 thinkpad_acpi ptp lpc_ich snd_rawmidi ac rfkill joydev mei_me snd_seq_device snd_hda_core pcspkr battery i2c_i801 mfd_core pps_core mei snd_hwdep shpchp fjes thermal wmi tpm_tis tpm_tis_core tpm snd_aloop snd_pcm snd_timer snd soundcore btrfs xor raid6_pq crc32c_intel i915 serio_raw i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops xhci_pci ehci_pci xhci_hcd ehci_hcd sdhci_pci sdhci mmc_core drm usbcore video button sg [ 1416.635255] CPU: 0 PID: 3387 Comm: zita-a2j Not tainted 4.10.13-1-default #1 [ 1416.635312] Hardware name: LENOVO 2325UR7/2325UR7, BIOS G2ETA2WW (2.62 ) 09/12/2014 [ 1416.635378] task: ffff8d6757c160c0 task.stack: ffff9cac03b74000 [ 1416.635444] RIP: 0010:snd_pcm_format_set_silence+0xea/0x100 [snd_pcm] [ 1416.635494] RSP: 0018:ffff9cac03b77d50 EFLAGS: 00010282 [ 1416.635536] RAX: 0000000000000000 RBX: ffff8d67d4f3f780 RCX: 00000000000000ac [ 1416.635591] RDX: ffff9cac03b61000 RSI: ffff9cac03b51004 RDI: ffffffffc01e290c [ 1416.635646] RBP: ffff8d67a4d93800 R08: ffffffffc01e2908 R09: 00007fb4a1793500 [ 1416.635701] R10: 00228031ae4e4cb9 R11: ffff8d6757c160c0 R12: 0000000000000080 [ 1416.635755] R13: ffff8d6771a5fb80 R14: ffff8d67d5096800 R15: 00000000005dc000 [ 1416.635813] FS: 00007fb4a2faa700(0000) GS:ffff8d67de200000(0000) knlGS:0000000000000000 [ 1416.635875] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1416.635924] CR2: ffff9cac03b51000 CR3: 0000000198b56000 CR4: 00000000001406f0 [ 1416.636001] Call Trace: [ 1416.636054] loopback_prepare+0x2d6/0x2f0 [snd_aloop] [ 1416.636110] snd_pcm_do_prepare+0x13/0x30 [snd_pcm] [ 1416.636158] snd_pcm_action_single+0x2a/0x70 [snd_pcm] [ 1416.636207] ? snd_pcm_action_single+0x5d/0x70 [snd_pcm] [ 1416.636255] snd_pcm_action_nonatomic+0x61/0x70 [snd_pcm] [ 1416.636308] snd_pcm_common_ioctl1+0x6d8/0xc60 [snd_pcm] [ 1416.636357] ? __wake_up+0x34/0x50 [ 1416.636388] ? tty_write+0x228/0x2b0 [ 1416.636424] snd_pcm_capture_ioctl1+0x117/0x280 [snd_pcm] [ 1416.636474] ? __vfs_write+0x23/0x140 [ 1416.636510] snd_pcm_capture_ioctl+0x2a/0x30 [snd_pcm] [ 1416.636555] do_vfs_ioctl+0x8f/0x5d0 [ 1416.636589] ? __fget+0x70/0xc0 [ 1416.636616] SyS_ioctl+0x74/0x80 [ 1416.636651] entry_SYSCALL_64_fastpath+0x1e/0xad [ 1416.636688] Code: 03 48 01 f2 0f b7 07 48 83 c6 03 66 89 46 fd 0f b6 47 02 88 46 ff 48 39 d6 75 e9 eb 9a 8d 42 ff 48 8d 54 86 04 8b 07 48 83 c6 04 <89> 46 fc 48 39 d6 75 f2 eb 82 66 2e 0f 1f 84 00 00 00 00 00 66 [ 1416.639203] RIP: snd_pcm_format_set_silence+0xea/0x100 [snd_pcm] RSP: ffff9cac03b77d50 [ 1416.641594] CR2: ffff9cac03b51000 [ 1416.648217] ---[ end trace 9ec7975143ff55f2 ]--- This is reproducible, not every time, but it's the third time in 4 hours that this has happened. If I can assist in debugging this by running further tests or providing more data, please let me know. Best, Jörn -- Jörn Nettingsmeier De Rijpgracht 8, 1055VR Amsterdam, Nederland Tel. +49 177 7937487 Meister für Veranstaltungstechnik (Bühne/Studio), Tonmeister VDT http://stackingdwarves.net

2 1

[alsa-devel] [PATCH v2] ALSA: hda - Add mute led support for HP EliteBook 840 G3
by Florin Tudorache 08 May '17

08 May '17

Signed-off-by: Florin Tudorache <florin_tudorache(a)live.com> --- sound/pci/hda/patch_conexant.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index e825373..63bc894 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -860,7 +860,9 @@ static const struct hda_fixup cxt_fixups[] = { { 0x16, 0x21011020 }, /* line-out */ { 0x18, 0x2181103f }, /* line-in */ { } - } + }, + .chained = true, + .chain_id = CXT_FIXUP_MUTE_LED_GPIO, }, [CXT_FIXUP_HP_SPECTRE] = { .type = HDA_FIXUP_PINS, -- 2.7.4

2 1

[alsa-devel] [PATCH] ASoC: ak4613: disable asymmetric audio interface format
by Kuninori Morimoto 08 May '17

08 May '17

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> Asymmetric audio interface formats exist in ak4613 by same register settings. Capture Playback 24bit LEFT_J 16bit RIGHT_J 24bit LEFT_J 20bit RIGHT_J 24bit LEFT_J 24bit RIGHT_J 24bit LEFT_J 24bit LEFT_J 24bit I2S 24bit I2S These asymmetric formats makes driver / behavior difficult. It is not HW limitation, but SW limitation. To makes code reading easy, this patch doesn't remove code, but just comment out. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/codecs/ak4613.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/ak4613.c b/sound/soc/codecs/ak4613.c index b2dfdde..9d2be7c 100644 --- a/sound/soc/codecs/ak4613.c +++ b/sound/soc/codecs/ak4613.c @@ -139,9 +139,9 @@ struct ak4613_priv { #define AUDIO_IFACE(b, fmt) { b, SND_SOC_DAIFMT_##fmt } static const struct ak4613_interface ak4613_iface[] = { /* capture */ /* playback */ - [0] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(16, RIGHT_J) }, - [1] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(20, RIGHT_J) }, - [2] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(24, RIGHT_J) }, +/* [0] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(16, RIGHT_J) }, */ +/* [1] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(20, RIGHT_J) }, */ +/* [2] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(24, RIGHT_J) }, */ [3] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(24, LEFT_J) }, [4] = { AUDIO_IFACE(24, I2S), AUDIO_IFACE(24, I2S) }, }; @@ -262,7 +262,7 @@ static int ak4613_dai_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) fmt &= SND_SOC_DAIFMT_FORMAT_MASK; switch (fmt) { - case SND_SOC_DAIFMT_RIGHT_J: +/* case SND_SOC_DAIFMT_RIGHT_J:*/ case SND_SOC_DAIFMT_LEFT_J: case SND_SOC_DAIFMT_I2S: priv->fmt = fmt; @@ -420,7 +420,7 @@ static int ak4613_set_bias_level(struct snd_soc_codec *codec, SNDRV_PCM_RATE_96000 |\ SNDRV_PCM_RATE_176400 |\ SNDRV_PCM_RATE_192000) -#define AK4613_PCM_FMTBIT (SNDRV_PCM_FMTBIT_S16_LE |\ +#define AK4613_PCM_FMTBIT (/*SNDRV_PCM_FMTBIT_S16_LE |*/ \ SNDRV_PCM_FMTBIT_S24_LE) static struct snd_soc_dai_driver ak4613_dai = { -- 1.9.1

2 2