April 2017 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] [PATCH] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode
by Garrett Thornburg 18 Apr '17

18 Apr '17

This is my first time posting in any type of mailing list, so hopefully I'm doing this right. I recently encountered the audio trouble with I2S mode via the headphone jack on my Dell XPS 9343 as well and found your patch. I applied the patch to the latest stable kernel (4.10) on arch linux mostly using their tools and the repeated clicking sound is fixed when no sound is playing. However, sometimes when sound is playing, the clicking returns but it's much more mild. If I pause/ resume music, for example, it might "click.. click.. click.." very quietly, but not always. It's audible when I turn the volume level down low, but overall it's much better. I do still get somewhat loud pops when resuming music after the sound card has been idle for a while, or a pop when the card switches to an idle state. This patch has really improved my situation though, so thank you :).

1 0

[alsa-devel] [PATCH v4 6/6] sound: replace /proc/bus/usb by /dev/bus/usb
by Mauro Carvalho Chehab 17 Apr '17

17 Apr '17

The /proc/bus/usb devices don't exist anymore, since when we got rid of usbfs. Those devices are now seen at /dev/bus/usb. Signed-off-by: Mauro Carvalho Chehab <mchehab(a)s-opensource.com> --- sound/usb/usx2y/us122l.c | 2 +- sound/usb/usx2y/usX2Yhwdep.c | 2 +- sound/usb/usx2y/usx2yhwdeppcm.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/usb/usx2y/us122l.c b/sound/usb/usx2y/us122l.c index cf45bf1f7ee0..e118bdca983d 100644 --- a/sound/usb/usx2y/us122l.c +++ b/sound/usb/usx2y/us122l.c @@ -472,7 +472,7 @@ static int usb_stream_hwdep_new(struct snd_card *card) hw->ops.mmap = usb_stream_hwdep_mmap; hw->ops.poll = usb_stream_hwdep_poll; - sprintf(hw->name, "/proc/bus/usb/%03d/%03d/hwdeppcm", + sprintf(hw->name, "/dev/bus/usb/%03d/%03d/hwdeppcm", dev->bus->busnum, dev->devnum); return 0; } diff --git a/sound/usb/usx2y/usX2Yhwdep.c b/sound/usb/usx2y/usX2Yhwdep.c index 605e1047c01d..f4b3cda412fc 100644 --- a/sound/usb/usx2y/usX2Yhwdep.c +++ b/sound/usb/usx2y/usX2Yhwdep.c @@ -258,7 +258,7 @@ int usX2Y_hwdep_new(struct snd_card *card, struct usb_device* device) hw->ops.mmap = snd_us428ctls_mmap; hw->ops.poll = snd_us428ctls_poll; hw->exclusive = 1; - sprintf(hw->name, "/proc/bus/usb/%03d/%03d", device->bus->busnum, device->devnum); + sprintf(hw->name, "/dev/bus/usb/%03d/%03d", device->bus->busnum, device->devnum); return 0; } diff --git a/sound/usb/usx2y/usx2yhwdeppcm.c b/sound/usb/usx2y/usx2yhwdeppcm.c index f95164b91152..d51c7fd7835b 100644 --- a/sound/usb/usx2y/usx2yhwdeppcm.c +++ b/sound/usb/usx2y/usx2yhwdeppcm.c @@ -723,7 +723,7 @@ int usX2Y_hwdep_pcm_new(struct snd_card *card) hw->ops.release = snd_usX2Y_hwdep_pcm_release; hw->ops.mmap = snd_usX2Y_hwdep_pcm_mmap; hw->exclusive = 1; - sprintf(hw->name, "/proc/bus/usb/%03d/%03d/hwdeppcm", dev->bus->busnum, dev->devnum); + sprintf(hw->name, "/dev/bus/usb/%03d/%03d/hwdeppcm", dev->bus->busnum, dev->devnum); err = snd_pcm_new(card, NAME_ALLCAPS" hwdep Audio", 2, 1, 1, &pcm); if (err < 0) { -- 2.9.3

2 1

Re: [alsa-devel] [PATCH 2/3] docs-rst/usb: usb/devices is now at /sys/kernel/debug/
by Mauro Carvalho Chehab 16 Apr '17

16 Apr '17

Em Sun, 16 Apr 2017 10:39:58 -0400 (EDT) Alan Stern <stern(a)rowland.harvard.edu> escreveu: > On Sun, 16 Apr 2017, Mauro Carvalho Chehab wrote: > > > The /proc/bus/usb/devices got moved to sysfs. It is now > > sitting at: > > /sys/kernel/debug/usb/devices > > > > Fix the old references at the USB documentation > > Many of the things you changed are still out of date. > > > Signed-off-by: Mauro Carvalho Chehab <mchehab(a)s-opensource.com> > > --- > > Documentation/driver-api/usb/usb.rst | 14 +++++++------- > > Documentation/usb/acm.txt | 2 +- > > Documentation/usb/gadget_serial.txt | 4 ++-- > > Documentation/usb/proc_usb_info.txt | 20 ++++++++++---------- > > 4 files changed, 20 insertions(+), 20 deletions(-) > > > > diff --git a/Documentation/driver-api/usb/usb.rst b/Documentation/driver-api/usb/usb.rst > > index 6824089ef4c8..036e77038d42 100644 > > --- a/Documentation/driver-api/usb/usb.rst > > +++ b/Documentation/driver-api/usb/usb.rst > > @@ -233,7 +233,7 @@ What files are in "usbfs"? > > > > Conventionally mounted at ``/proc/bus/usb``, usbfs features include: > > This whole section is highly misleading. usbfs no longer exists as a > filesystem. Instead, the files which used to be part of usbfs have > either moved to debugfs (/sys/kernel/debug/usb/devices) or are > character device nodes managed by systemctl/udev and typically created > under /dev/bus/usb. > > > @@ -299,23 +299,23 @@ invocations of *mount*, are: > > 0) > > > > *listgid*\ =NNNNN > > - Controls the GID used for the /proc/bus/usb/devices and drivers > > + Controls the GID used for the /sys/kernel/debug/usb/devices and drivers > > files. (Default: 0) > > > > *listmode*\ =MMM > > - Controls the file mode used for the /proc/bus/usb/devices and > > + Controls the file mode used for the /sys/kernel/debug/usb/devices and > > drivers files. (Default: 0444) > > > > *listuid*\ =NNNNN > > - Controls the UID used for the /proc/bus/usb/devices and drivers > > + Controls the UID used for the /sys/kernel/debug/usb/devices and drivers > > files. (Default: 0) > > > > Note that many Linux distributions hard-wire the mount options for usbfs > > in their init scripts, such as ``/etc/rc.d/rc.sysinit``, rather than > > making it easy to set this per-system policy in ``/etc/fstab``. > > This is all totally out of date. usbfs is no longer a filesystem that > can be mounted. True. Sent already a new patchset covering it, and other places where /proc/bus/bus are mentioned. Besides the stuff already fixed, there are still a few other bits to address: Documentation/usb/proc_usb_info.txt:/proc/bus/usb filesystem output Documentation/usb/proc_usb_info.txt:/proc/bus/usb. It provides the /sys/kernel/debug/usb/devices file, as well as Documentation/usb/proc_usb_info.txt:the /proc/bus/usb/BBB/DDD files. Documentation/usb/proc_usb_info.txt:**NOTE**: If /proc/bus/usb appears empty, and a host controller Documentation/usb/proc_usb_info.txt: mount -t usbfs none /proc/bus/usb Documentation/usb/proc_usb_info.txt: none /proc/bus/usb usbfs defaults 0 0 Documentation/usb/proc_usb_info.txt:THE /proc/bus/usb/BBB/DDD FILES: Documentation/usb/proc_usb_info.txt:devices. You would open the /proc/bus/usb/BBB/DDD file read/write, This should likely be merged at usb.rst file or fully reworked. include/uapi/linux/capability.h:/* Allow sending USB messages to any device via /proc/bus/usb */ include/uapi/linux/usb/ch9.h: * not other descriptors) are read from usbfs (i.e. /proc/bus/usb/BBB/DDD); I'll address this on a version 4. sound/usb/usx2y/us122l.c: sprintf(hw->name, "/proc/bus/usb/%03d/%03d/hwdeppcm", sound/usb/usx2y/usX2Yhwdep.c: sprintf(hw->name, "/proc/bus/usb/%03d/%03d", device->bus->busnum, device->devnum); sound/usb/usx2y/usx2yhwdeppcm.c: sprintf(hw->name, "/proc/bus/usb/%03d/%03d/hwdeppcm", dev->bus->busnum, dev->devnum); Not sure about the above. Regards, Mauro

1 0

Re: [alsa-devel] Internal Speaker problem
by Laszlo Papp 15 Apr '17

15 Apr '17

Guys, seriously, no one willing to help with a completely broken setup?! It works fine on Windows, so I would really like to get it working on Linux, too. On Mon, Mar 27, 2017 at 8:29 AM, Laszlo Papp <lpapp(a)kde.org> wrote: > I am sorry about flooding with my emails. I just thought that I would > amend some information that I forgot to mention in my original email. > > The same laptop and internal speaker work ok on Windows 10. Also, the > setup used to work about 1-2 months ago. I cannot remember what exactly > broke, perhaps a system upgrade. If it matters, I am using Archlinux. > > On Mon, Mar 27, 2017 at 8:27 AM, Laszlo Papp <lpapp(a)kde.org> wrote: > >> Dear Alsa Developers, >> >> My internal speaker in the Lenovo Thinkpad T510 laptop stopped working. >> Normally, it would provide either no sound or just for a couple of seconds >> and then it would go off. >> >> I do not have auto-mute enabled. I checked it with alsamixer that it is >> disabled. >> >> My ALSA information is located at http://www.alsa-project.org/db >> /?f=87547de5ff55e44e360aa2382d4e5d3b7bbed091 >> >> Do you know how I could fix this? >> >> Ys, L. >> >> >

4 12

[alsa-devel] [PATCH 1/3] ASoC: rt5514: Mark rt5514_i2c_driver as static
by Douglas Anderson 14 Apr '17

14 Apr '17

There's no reason for rt5514_i2c_driver to be non-static. Signed-off-by: Douglas Anderson <dianders(a)chromium.org> --- sound/soc/codecs/rt5514.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5514.c b/sound/soc/codecs/rt5514.c index b281a46d769d..481e77763fe4 100644 --- a/sound/soc/codecs/rt5514.c +++ b/sound/soc/codecs/rt5514.c @@ -1149,7 +1149,7 @@ static int rt5514_i2c_remove(struct i2c_client *i2c) return 0; } -struct i2c_driver rt5514_i2c_driver = { +static struct i2c_driver rt5514_i2c_driver = { .driver = { .name = "rt5514", .of_match_table = of_match_ptr(rt5514_of_match), -- 2.12.2.762.g0e3151a226-goog

2 5

[alsa-devel] [PATCH] ALSA: fireface: obsolete usage of ktime_set() for zero assignment
by Takashi Sakamoto 14 Apr '17

14 Apr '17

In development period for Linux v4.10, ktime_t became an alias of s64, instead of union. I forgot it. We can just assign zero, instead of usage of ktime_set(0, 0). Fixes: 19174295788 ("ALSA: fireface: add transaction support") Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- sound/firewire/fireface/ff-transaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/firewire/fireface/ff-transaction.c b/sound/firewire/fireface/ff-transaction.c index d1b098f..dd6c8e8 100644 --- a/sound/firewire/fireface/ff-transaction.c +++ b/sound/firewire/fireface/ff-transaction.c @@ -21,7 +21,7 @@ static void finish_transmit_midi_msg(struct snd_ff *ff, unsigned int port, if (rcode != RCODE_COMPLETE) { /* Transfer the message again, immediately. */ - ff->next_ktime[port] = ktime_set(0, 0); + ff->next_ktime[port] = 0; schedule_work(&ff->rx_midi_work[port]); return; } -- 2.9.3

1 0

[alsa-devel] [PATCH v2 0/8] ALSA: firewire-lib/firewire-tascam: localize async midi port
by Takashi Sakamoto 14 Apr '17

14 Apr '17

Hi, This patchset is a revised version of my previous one: [alsa-devel] [PATCH 0/8] ALSA: firewire-lib/firewire-tascam: localize async midi port http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/119748.html A bug of this feature was reported: http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/119775.html And I posted a fix: http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/119782.html The fix brought conflict to the previous patchset and this is a revised version. Takashi Sakamoto (8): ALSA: firewire-lib/firewire-tascam: localize async midi port ALSA: firewire-tascam: remove callback function from async midi port ALSA: firewire-tascam: send fixed-length transaction for async midi port ALSA: firewire-tascam: use the same address for asynchronous transaction for MIDI message ALSA: firewire-tascam: use fixed-length array for message cache to async midi port ALSA: firewire-tascam: initialize parameters at open of rawmidi character devices ALSA: firewire-tascam: move message parameters for async midi port ALSA: firewire-tascam: support drain callback for MIDI playback substream sound/firewire/lib.c | 141 ---------------------------- sound/firewire/lib.h | 54 ----------- sound/firewire/tascam/tascam-midi.c | 13 ++- sound/firewire/tascam/tascam-transaction.c | 142 ++++++++++++++++++++++++----- sound/firewire/tascam/tascam.h | 39 +++++++- 5 files changed, 162 insertions(+), 227 deletions(-) -- 2.9.3

2 9

[alsa-devel] usx2y: usx2yhwdeppcm.c gives "should not be here with counts=40" (linux 4.9.0)
by Jaime T 14 Apr '17

14 Apr '17

Hi all. I'm running a fresh and cleanly-installed debian testing (stretch) with my tascam us-122. After about 6 hours of perfect, joyous sound, the kernel (4.9.0-2-686) emits: should not be here with counts=40 and my jack server stops working. I'm aware that I should be running a vanilla kernel before logging a bug against the driver - is that my next step? (it might take a very long time!) (FWIW, I've run alsa-info.sh and the results are available at http://www.alsa-project.org/db/?f=f5e0f8f654ef467cedaaed7ae129b02267c46a95) Many thanks, Jaime

1 0

[alsa-devel] [PATCH 0/8] ALSA: firewire-lib/firewire-tascam: localize async midi port
by Takashi Sakamoto 14 Apr '17

14 Apr '17

Hi, At a development period for Linux v4.4, firewire-lib module got an abstraction of asynchronous transaction for transmission of MIDI message. I did this with an assumption that this is required for Digi00x series, as well as TASCAM FireWire series. However, my recent work reveal it's actually not[0]. This patchset localizes the abstraction just for TASCAM FireWire series. [0] [alsa-devel] [PATCH 0/4] ALSA: firewire-digi00x: integration to support console models http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/119397.html Takashi Sakamoto (8): firewire-lib/firewire-tascam: localize async midi port firewire-tascam: remove callback function from async midi port firewire-tascam: send fixed-length transaction for async midi port firewire-tascam: use the same address for asynchronous transaction for MIDI message firewire-tascam: use fixed-length array for message cache to async midi port firewire-tascam: initialize parameters at open of rawmidi character devices firewire-tascam: move message parameters for async midi port firewire-tascam: support drain callback for MIDI playback substream sound/firewire/lib.c | 141 ---------------------------- sound/firewire/lib.h | 54 ----------- sound/firewire/tascam/tascam-midi.c | 13 ++- sound/firewire/tascam/tascam-transaction.c | 142 ++++++++++++++++++++++++----- sound/firewire/tascam/tascam.h | 39 +++++++- 5 files changed, 162 insertions(+), 227 deletions(-) -- 2.9.3

2 9

[alsa-devel] [PATCH] ALSA: usb-line6: constify snd_kcontrol_new strucutre array
by Takashi Sakamoto 14 Apr '17

14 Apr '17

In kernel APIs of ALSA control interface, drivers can create a control element set by a call of snd_ctl_new1() with a template. This template is known to have const qualifier in general cases. This commit adds the qualifier to template array, for safer program and runtime. Application of this change moves the symbol from .data section to .rodata section. Cc: Bhumika Goyal <bhumirks(a)gmail.com> Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- sound/usb/line6/pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/usb/line6/pcm.c b/sound/usb/line6/pcm.c index fab53f5..b3854f8 100644 --- a/sound/usb/line6/pcm.c +++ b/sound/usb/line6/pcm.c @@ -430,7 +430,7 @@ static int snd_line6_control_playback_put(struct snd_kcontrol *kcontrol, } /* control definition */ -static struct snd_kcontrol_new line6_controls[] = { +static const struct snd_kcontrol_new line6_controls[] = { { .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = "PCM Playback Volume", -- 2.9.3

2 1