March 2017 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] [PATCH 3/4] sound: arm: Add build system for bcm2835-analog-audio driver.
by Michael Zoran 14 Mar '17

14 Mar '17

On Tue, 2017-03-14 at 15:15 +0800, kbuild test robot wrote: > Hi Michael, > > [auto build test ERROR on sound/for-next] > [also build test ERROR on v4.11-rc2 next-20170310] > [if your patch is applied to the wrong git tree, please drop us a > note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Michael-Zoran/dt-bin > dings-Document-the-dmas-and-dma-names-properties-for-bcm2835-analog- > audio/20170314-091035 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.g > it for-next > config: arm64-allmodconfig (attached as .config) > compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: > wget https://raw.githubusercontent.com/01org/lkp-tests/master > /sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=arm64 > > All errors (new ones prefixed by >>): > > /tmp/ccNU8kQ5.s: Assembler messages: > > > /tmp/ccNU8kQ5.s:1411: Error: unknown mnemonic `ldmia' -- `ldmia > > > x26,{r0,r1,r2,r3}' > > > /tmp/ccNU8kQ5.s:1412: Error: unknown mnemonic `stmia' -- `stmia > > > x19!,{r0,r1,r2,r3}' > > > /tmp/ccNU8kQ5.s:1618: Error: unknown mnemonic `ldmia' -- `ldmia > > > x19!,{r0,r1,r2,r3}' > > > /tmp/ccNU8kQ5.s:1619: Error: unknown mnemonic `stmia' -- `stmia > > > x26,{r0,r1,r2,r3}' > > --- > 0-DAY kernel test infrastructure Open Source > Technology Center > https://lists.01.org/pipermail/kbuild-all Intel > Corporation I'm a bit confused here. Why I'm I seeing assembly instruction build errors when the mail points to a DT binding document change?

1 0

Re: [alsa-devel] [PATCH 4/4] dts: bcm283x.dtsi: Add analog audio/headphone jack for bcm2835
by Michael Zoran 14 Mar '17

14 Mar '17

On Tue, 2017-03-14 at 09:05 +0100, Stefan Wahren wrote: > AFAIK the Raspberry Pi 3 uses pin 40 and 41. > I did all my testing on the RPI 3, so I'm almost certain it's correct. It matches with the schematic and it matches with what the downstream tree uses for the firmware based driver(dummy claiming of pins).

1 0

Re: [alsa-devel] [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new, free}
by Kuninori Morimoto 14 Mar '17

14 Mar '17

Hi Brian > > The crasher was snd_dmaengine_pcm_register's platform ? > > No, actually it wasn't. It was spi2.0, which was a dummy, from > snd_soc_dummy_probe(). But somehow snd_soc_platform_drv_pcm_new() got > called for it... Hmm.. I couldn't reproduce your issue on my system with dummy platform. And your log is indicating something is happening which shouldn't happen. Best regards --- Kuninori Morimoto

1 0

[alsa-devel] [PATCH 0/5] MinnowBoard MAX support for DA7212
by Pierre-Louis Bossart 13 Mar '17

13 Mar '17

This patch set enables the Dialog ARD-Audio-Da7212 board connected to MinnowBoardMAX. The files for SSDT update are provided on github [1] as well as UCM files [2]. Headset capture and playback were tested and levels adjusted with the loopback dongle. The on-board mic can only be tested with a hardware mod. As an added bonus the machine driver to expose all I2S signals on the LSE connector was rebased to the latest kernel, it is useful to figure out what signals are generated by the Intel firmware/hardware. [1] https://github.com/plbossart/MinnowBoardMaxFirmware/tree/master/X64 [2] https://github.com/plbossart/UCM/tree/master/bytcht-da7213 Pierre-Louis Bossart (5): ASoC: da7213: add ACPI support ASoC: Intel: add machine driver for BYT/CHT + DA7213 ASoC: Intel: Atom: enable BYT/CHT+DA7213 machine driver ASoC: Intel: boards: add card for MinnowBoardMax/Up I2S access ASoC: Intel: Enable bytcht_nocodec machine driver sound/soc/codecs/da7213.c | 13 ++ sound/soc/intel/Kconfig | 24 +++ sound/soc/intel/atom/sst/sst_acpi.c | 25 ++- sound/soc/intel/boards/Makefile | 4 + sound/soc/intel/boards/bytcht_da7213.c | 283 ++++++++++++++++++++++++++++++++ sound/soc/intel/boards/bytcht_nocodec.c | 208 +++++++++++++++++++++++ 6 files changed, 556 insertions(+), 1 deletion(-) create mode 100644 sound/soc/intel/boards/bytcht_da7213.c create mode 100644 sound/soc/intel/boards/bytcht_nocodec.c -- 2.7.4

4 14

[alsa-devel] [PATCH] ASoC: rsnd: fix sound route path when using SRC6/SRC9
by Kuninori Morimoto 13 Mar '17

13 Mar '17

From: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx(a)renesas.com> This patch fixes the problem that the missing value of the route path setting table and incorrect values are set in the CMD_ROUTE_SELECT register. Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx(a)renesas.com> [Kuninori: shared data on MIX and non-MIX case] Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/sh/rcar/cmd.c | 36 ++++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/sound/soc/sh/rcar/cmd.c b/sound/soc/sh/rcar/cmd.c index abb5eaa..7d92a24 100644 --- a/sound/soc/sh/rcar/cmd.c +++ b/sound/soc/sh/rcar/cmd.c @@ -31,23 +31,24 @@ static int rsnd_cmd_init(struct rsnd_mod *mod, struct rsnd_mod *mix = rsnd_io_to_mod_mix(io); struct device *dev = rsnd_priv_to_dev(priv); u32 data; + u32 path[] = { + [1] = 1 << 0, + [5] = 1 << 8, + [6] = 1 << 12, + [9] = 1 << 15, + }; if (!mix && !dvc) return 0; + if (ARRAY_SIZE(path) < rsnd_mod_id(mod) + 1) + return -ENXIO; + if (mix) { struct rsnd_dai *rdai; struct rsnd_mod *src; struct rsnd_dai_stream *tio; int i; - u32 path[] = { - [0] = 0, - [1] = 1 << 0, - [2] = 0, - [3] = 0, - [4] = 0, - [5] = 1 << 8 - }; /* * it is assuming that integrater is well understanding about @@ -70,16 +71,19 @@ static int rsnd_cmd_init(struct rsnd_mod *mod, } else { struct rsnd_mod *src = rsnd_io_to_mod_src(io); - u32 path[] = { - [0] = 0x30000, - [1] = 0x30001, - [2] = 0x40000, - [3] = 0x10000, - [4] = 0x20000, - [5] = 0x40100 + u8 cmd_case[] = { + [0] = 0x3, + [1] = 0x3, + [2] = 0x4, + [3] = 0x1, + [4] = 0x2, + [5] = 0x4, + [6] = 0x1, + [9] = 0x2, }; - data = path[rsnd_mod_id(src)]; + data = path[rsnd_mod_id(src)] | + cmd_case[rsnd_mod_id(src)] << 16; } dev_dbg(dev, "ctu/mix path = 0x%08x", data); -- 1.9.1

2 1

[alsa-devel] [PATCH] ASoC: Intel: Skylake: code cleanup for pin fixup limitation
by Takashi Sakamoto 13 Mar '17

13 Mar '17

As a commit 4cd9899f0d16 ("ASoC: Intel: Skylake: Add multiple pin formats") describes, 'fixups is applied to pin 0 only'. On the other hand, the commit left some codes as what they were. This might confuses readers. This commit fixes the issue. This doesn't change driver behaviour at all. Fixes: 4cd9899f0d16 ("ASoC: Intel: Skylake: Add multiple pin formats") Signed-off-by: Takashi Sakamoto <takashi.sakamoto(a)miraclelinux.com> --- sound/soc/intel/skylake/skl-topology.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index f38f8e6..8651359 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -310,13 +310,11 @@ static void skl_tplg_update_buffer_size(struct skl_sst *ctx, multiplier = 5; mcfg->ibs = DIV_ROUND_UP(in_fmt->s_freq, 1000) * - (mcfg->in_fmt->channels) * - (mcfg->in_fmt->bit_depth >> 3) * + in_fmt->channels * (in_fmt->bit_depth >> 3) * multiplier; - mcfg->obs = DIV_ROUND_UP(mcfg->out_fmt->s_freq, 1000) * - (mcfg->out_fmt->channels) * - (mcfg->out_fmt->bit_depth >> 3) * + mcfg->obs = DIV_ROUND_UP(out_fmt->s_freq, 1000) * + out_fmt->channels * (out_fmt->bit_depth >> 3) * multiplier; } -- 2.9.3

3 2

[alsa-devel] [PATCH 1/5] ASoC: cs35l35: Add missing return in probe
by Charles Keepax 13 Mar '17

13 Mar '17

A return statement is missing just before the error paths at the end of probe. This causes us to fall straight into the error path and disable the supplies and re-enable reset, as these are only controlled during probe this causes the part to no longer function. Signed-off-by: Charles Keepax <ckeepax(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/cs35l35.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c index 260ed42..48b45dc 100644 --- a/sound/soc/codecs/cs35l35.c +++ b/sound/soc/codecs/cs35l35.c @@ -1509,6 +1509,8 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client, goto err; } + return 0; + err: regulator_bulk_disable(cs35l35->num_supplies, cs35l35->supplies); -- 2.1.4

3 10

[alsa-devel] Applied "ASoC: cs35l35: Fix display revision id" to the asoc tree
by Mark Brown 13 Mar '17

13 Mar '17

The patch ASoC: cs35l35: Fix display revision id has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 82875163a8ef1e25477402c5ebb8f5beaea5e93e Mon Sep 17 00:00:00 2001 From: Axel Lin <axel.lin(a)ingics.com> Date: Sat, 11 Mar 2017 20:57:07 +0800 Subject: [PATCH] ASoC: cs35l35: Fix display revision id Signed-off-by: Axel Lin <axel.lin(a)ingics.com> Acked-by: Paul Handrigan <Paul.Handrigan(a)cirrus.com> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/codecs/cs35l35.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c index 7c4d74ec32cb..a9e45dea309e 100644 --- a/sound/soc/codecs/cs35l35.c +++ b/sound/soc/codecs/cs35l35.c @@ -1463,7 +1463,7 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client, } dev_info(dev, "Cirrus Logic CS35L35 (%x), Revision: %02X\n", - devid, ret & 0xFF); + devid, reg & 0xFF); /* Set the INT Masks for critical errors */ regmap_write(cs35l35->regmap, CS35L35_INT_MASK_1, -- 2.11.0

1 0

[alsa-devel] Applied "ASoC: cs35l35: trivial fix to indentation" to the asoc tree
by Mark Brown 13 Mar '17

13 Mar '17

The patch ASoC: cs35l35: trivial fix to indentation has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 03ff570c6b45b27e233f5cb1fd04404374fd883f Mon Sep 17 00:00:00 2001 From: Colin Ian King <colin.king(a)canonical.com> Date: Sat, 11 Mar 2017 19:19:22 +0000 Subject: [PATCH] ASoC: cs35l35: trivial fix to indentation Remove extraneous tab to correct the nesting level indentation Detected by CoverityScan, CID#1416584 ("Nesting level does not match indentation") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/codecs/cs35l35.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c index a9e45dea309e..a5da1d511a8a 100644 --- a/sound/soc/codecs/cs35l35.c +++ b/sound/soc/codecs/cs35l35.c @@ -1375,7 +1375,8 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client, for (i = 0; i < ARRAY_SIZE(cs35l35_supplies); i++) cs35l35->supplies[i].supply = cs35l35_supplies[i]; - cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies); + + cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies); ret = devm_regulator_bulk_get(dev, cs35l35->num_supplies, cs35l35->supplies); -- 2.11.0

1 0

[alsa-devel] [PATCH] ASoC: fix semicolon.cocci warnings
by kbuild test robot 13 Mar '17

13 Mar '17

sound/soc/codecs/cs35l35.c:706:2-3: Unneeded semicolon sound/soc/codecs/cs35l35.c:543:4-5: Unneeded semicolon sound/soc/codecs/cs35l35.c:553:4-5: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Brian Austin <brian.austin(a)cirrus.com> Signed-off-by: Fengguang Wu <fengguang.wu(a)intel.com> --- cs35l35.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/sound/soc/codecs/cs35l35.c +++ b/sound/soc/codecs/cs35l35.c @@ -540,7 +540,7 @@ static int cs35l35_hw_params(struct snd_ default: dev_err(codec->dev, "ratio not supported\n"); return -EINVAL; - }; + } } else { /* Only certain ratios supported in I2S MASTER Mode */ switch (sp_sclks) { @@ -550,7 +550,7 @@ static int cs35l35_hw_params(struct snd_ default: dev_err(codec->dev, "ratio not supported\n"); return -EINVAL; - }; + } } ret = regmap_update_bits(cs35l35->regmap, CS35L35_CLK_CTL3, @@ -703,7 +703,7 @@ static int cs35l35_codec_set_sysclk(stru default: dev_err(codec->dev, "Invalid CLK Source\n"); return -EINVAL; - }; + } switch (freq) { case 5644800:

2 1