February 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [RFC v2 0/7] Add STM32 DFSDM support
by Arnaud Pouliquen 05 Mar '17

05 Mar '17

Hello, This RFC is following first patch-set sent for DFSDM driver (https://www.spinics.net/lists/arm-kernel/msg557133.html). AS MFD driver has been rejected, a new way to integrate DFSDM has to be defined. Aim of this RFC is to provide a base to discuss this redesign. 1) DFSDM hardware overview: ----------------------- The Digital Filter for Sigma Delta is a module dedicated to interface external sigma delta modulators to STM32 micro-controllers. It is targeted for: - Audio mode signal with Pulse density modulation (PDM) microphone - motor and Sensing mode with sigma delta ADC modulator Main Features: - Up to 8 multiplexed input digital serial channel (SIT) . SPI (PDM compatible) or Manchester interface . Slave or master ( one main SPI CLK OUT for all interface) - Alternative inputs for 8 internal digital parallel channels (PIT) . 16 bits resolution . internal sources: ADC or memory - Digital signal processing: . 4 instances . Sincx filter (x : order 1 to 5) oversampling ratio up to 1024 . integrator: oversampling ratio up to 256 - Channel multiplexer . allow to connect SIT or PIT to filter . channel n can be connected SIT n or SIT n+1 - up to 24-bit output resolution . signed . sampling rate and resolution depend on filter parameters. - data offset correction - detector: . analog watchdog . short circuit detection . clock absence detection . extremes For details on DFSDM IP, please refer to STM32F413 data-sheet chapter 15: http://www.st.com/content/ccc/resource/technical/document/reference_manual/… 2) SW design proposal: --------------------- Patch-set associated to this RFC proposes an implementation of the DFSDM features shared between ASoC and IIO frameworks. Patch-set is only a Skeleton of the drivers, so a base to discuss and validate a design. It contains minimum code to allow probing (with DT) and to expose the ASoC and IIO ABI. Hope that is sufficent in a first step to allow to focus on APIs. In this patch-set there are two new APIs used: - IIO in-kern API: based on hw_customer API proposed by Lars - ASOC <-> IIO API inspired by API defined for hdmi-codec for ASoC/DRM interconnect. API is dedicated to DFSDM only. Notice also that this design is based on following assumption: - Audio stream ABI interface is ASoC, no access to data through IIO ABI for PDM. - ASoC DMA should be used for audio transfer as designed for real time stream. - Need some runtime parameters exchange between ASoC and IIO due to the correlation between the sample frequency, the DFSDM decimation factor and the associated scaling. - "ASoC: dmaengine_pcm: add copy support" patch: I added a patch in ASoC that allows to implement a copy function to process data after DMA transfer. Requested, as DFSDM samples captured contain channel ID on 8-LSB bits and need also a potential rescale to present DAT on 24-bits. - "IIO: ADC: add sigma delta modulator support" patch: Simple dummy driver created to support external Sigma delta modulator. It is binded to DFSDM driver through hw_customer API. Regards Arnaud Arnaud Pouliquen (6): iio: Add hardware consumer support IIO: Add bindings for simple sigma delta adc IIO: ADC: add sigma delta modulator support ASoC: stm32: add DFSDM DAI support IIO: add bindings for stm32 DFSDM filter IIO: ADC: add stm32 DFSDM support olivier moysan (1): ASoC: dmaengine_pcm: add copy support .../devicetree/bindings/iio/adc/simple_sd_adc.txt | 13 + .../bindings/iio/adc/st,stm32-dfsdm-adc.txt | 125 ++++++ drivers/iio/Kconfig | 6 + drivers/iio/Makefile | 1 + drivers/iio/adc/Kconfig | 24 + drivers/iio/adc/Makefile | 2 + drivers/iio/adc/simple_sd_adc.c | 112 +++++ drivers/iio/adc/stm32-dfsdm-adc.c | 483 +++++++++++++++++++++ drivers/iio/adc/stm32-dfsdm-core.c | 273 ++++++++++++ drivers/iio/adc/stm32-dfsdm.h | 141 ++++++ drivers/iio/hw_consumer.c | 156 +++++++ include/linux/iio/hw_consumer.h | 12 + include/sound/dmaengine_pcm.h | 3 + include/sound/stm32-adfsdm.h | 80 ++++ sound/soc/Kconfig | 1 + sound/soc/Makefile | 1 + sound/soc/soc-generic-dmaengine-pcm.c | 37 +- sound/soc/stm/Kconfig | 10 + sound/soc/stm/Makefile | 2 + sound/soc/stm/stm32_adfsdm.c | 365 ++++++++++++++++ 20 files changed, 1845 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/iio/adc/simple_sd_adc.txt create mode 100644 Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt create mode 100644 drivers/iio/adc/simple_sd_adc.c create mode 100644 drivers/iio/adc/stm32-dfsdm-adc.c create mode 100644 drivers/iio/adc/stm32-dfsdm-core.c create mode 100644 drivers/iio/adc/stm32-dfsdm.h create mode 100644 drivers/iio/hw_consumer.c create mode 100644 include/linux/iio/hw_consumer.h create mode 100644 include/sound/stm32-adfsdm.h create mode 100644 sound/soc/stm/Kconfig create mode 100644 sound/soc/stm/Makefile create mode 100644 sound/soc/stm/stm32_adfsdm.c -- 1.9.1

4 32

[alsa-devel] [PATCH v2 6/6] pcm:plug: save converter config
by sutar.mounesh＠gmail.com 03 Mar '17

03 Mar '17

From: Andreas Pape <apape(a)de.adit-jv.com> Passed config is freed after call to open, thus it is invalid when trying to extract the converter name. So config entry is saved for later usage. Signed-off-by: Andreas Pape <apape(a)de.adit-jv.com> Signed-off-by: Mounesh Sutar <sutar.mounesh(a)gmail.com> diff --git a/src/pcm/pcm_plug.c b/src/pcm/pcm_plug.c index 266707b..ad0e99e 100644 --- a/src/pcm/pcm_plug.c +++ b/src/pcm/pcm_plug.c @@ -64,6 +64,8 @@ static int snd_pcm_plug_close(snd_pcm_t *pcm) snd_pcm_plug_t *plug = pcm->private_data; int err, result = 0; free(plug->ttable); + if (plug->rate_converter) + snd_config_delete((snd_config_t*)plug->rate_converter); assert(plug->gen.slave == plug->req_slave); if (plug->gen.close_slave) { snd_pcm_unlink_hw_ptr(pcm, plug->req_slave); @@ -1108,7 +1110,13 @@ int snd_pcm_plug_open(snd_pcm_t **pcmp, plug->sformat = sformat; plug->schannels = schannels; plug->srate = srate; - plug->rate_converter = rate_converter; + if (rate_converter) { + if ((err = snd_config_copy((snd_config_t**)&plug->rate_converter, + (snd_config_t *)rate_converter)) < 0) + free(plug); + return err; + } + plug->gen.slave = plug->req_slave = slave; plug->gen.close_slave = close_slave; plug->route_policy = route_policy; @@ -1119,6 +1127,8 @@ int snd_pcm_plug_open(snd_pcm_t **pcmp, err = snd_pcm_new(&pcm, SND_PCM_TYPE_PLUG, name, slave->stream, slave->mode); if (err < 0) { + if (plug->rate_converter) + snd_config_delete((snd_config_t*)plug->rate_converter); free(plug); return err; } -- 2.7.4

3 2

[alsa-devel] [PATCH 1/9] ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock
by Icenowy Zheng 01 Mar '17

01 Mar '17

Lichee Pi Zero features a dock, which adds some functions, and should be soldered with the core board of Lichee Pi Zero. Add support for the dock as a new dts, as soldering is needed to make the dock usable and there's functions enabled on the dock that is unavailable at the 2.54mm pins of the core board. Currently no new feature on core board is available in the mainline kernel, so the dock dt file only includes the core board device tree. Signed-off-by: Icenowy Zheng <icenowy(a)aosc.xyz> --- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 49 ++++++++++++++++++++++ 2 files changed, 51 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 011808490fed..1aa365306479 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -876,7 +876,8 @@ dtb-$(CONFIG_MACH_SUN8I) += \ sun8i-h3-orangepi-plus.dtb \ sun8i-h3-orangepi-plus2e.dtb \ sun8i-r16-parrot.dtb \ - sun8i-v3s-licheepi-zero.dtb + sun8i-v3s-licheepi-zero.dtb \ + sun8i-v3s-licheepi-zero-dock.dtb dtb-$(CONFIG_MACH_SUN9I) += \ sun9i-a80-optimus.dtb \ sun9i-a80-cubieboard4.dtb diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts new file mode 100644 index 000000000000..68c114d6b939 --- /dev/null +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts @@ -0,0 +1,49 @@ +/* + * Copyright (C) 2016 Icenowy Zheng <icenowy(a)aosc.xyz> + * + * This file is dual-licensed: you can use it either under the terms + * of the GPL or the X11 license, at your option. Note that this dual + * licensing only applies to this file, and not this project as a + * whole. + * + * a) This file is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of the + * License, or (at your option) any later version. + * + * This file is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * Or, alternatively, + * + * b) Permission is hereby granted, free of charge, to any person + * obtaining a copy of this software and associated documentation + * files (the "Software"), to deal in the Software without + * restriction, including without limitation the rights to use, + * copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following + * conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + */ + +#include "sun8i-v3s-licheepi-zero.dts" + +/ { + model = "Lichee Pi Zero with Dock"; + compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero", + "allwinner,sun8i-v3s"; +}; -- 2.11.1

4 18

[alsa-devel] sounds: deadlocked processed in snd_seq_pool_done
by Dmitry Vyukov 28 Feb '17

28 Feb '17

Hello, The following program creates deadlocked processed in snd_seq_pool_done: https://gist.githubusercontent.com/dvyukov/1c9b1e4641f46c16a42cdb4458bbe8fd… # cat /proc/2964/status Name: a.out State: D (disk sleep) Tgid: 2964 Ngid: 0 Pid: 2964 PPid: 2956 TracerPid: 0 Uid: 0 0 0 0 Gid: 0 0 0 0 FDSize: 0 Groups: 0 NStgid: 2964 NSpid: 2964 NSpgid: 2964 NSsid: 2956 Threads: 1 SigQ: 1/3304 SigPnd: 0000000000000000 ShdPnd: 0000000000000100 SigBlk: 0000000000000000 SigIgn: 0000000000000000 SigCgt: 0000000180000000 CapInh: 0000000000000000 CapPrm: 0000003fffffffff CapEff: 0000003fffffffff CapBnd: 0000003fffffffff CapAmb: 0000000000000000 NoNewPrivs: 0 Seccomp: 0 Cpus_allowed: f Cpus_allowed_list: 0-3 Mems_allowed: 00000000,00000001 Mems_allowed_list: 0 voluntary_ctxt_switches: 103997 nonvoluntary_ctxt_switches: 0 # cat /proc/2964/task/*/stack [<ffffffff8356c96b>] snd_seq_pool_done+0x31b/0x620 sound/core/seq/seq_memory.c:435 [<ffffffff83571961>] snd_seq_fifo_delete+0x161/0x1f0 sound/core/seq/seq_fifo.c:83 [<ffffffff83562b4f>] snd_seq_release+0x7f/0xe0 sound/core/seq/seq_clientmgr.c:368 [<ffffffff81a8aae2>] __fput+0x332/0x7f0 fs/file_table.c:208 [<ffffffff81a8b025>] ____fput+0x15/0x20 fs/file_table.c:244 [<ffffffff814c782a>] task_work_run+0x18a/0x260 kernel/task_work.c:116 [<ffffffff81451a86>] exit_task_work include/linux/task_work.h:21 [inline] [<ffffffff81451a86>] do_exit+0x1956/0x2900 kernel/exit.c:873 [<ffffffff81457579>] do_group_exit+0x149/0x420 kernel/exit.c:977 [<ffffffff8145786d>] SYSC_exit_group kernel/exit.c:988 [inline] [<ffffffff8145786d>] SyS_exit_group+0x1d/0x20 kernel/exit.c:986 [<ffffffff8457c781>] entry_SYSCALL_64_fastpath+0x1f/0xc2 [<ffffffffffffffff>] 0xffffffffffffffff

2 1

[alsa-devel] [PATCH 1/5] ALSA: hda/realtek - Add support for Acer Aspire E5-475 headset mic
by Daniel Drake 28 Feb '17

28 Feb '17

From: Chris Chiu <chiu(a)endlessm.com> The Acer laptop Aspire E5-475 with ALC255 can't detect the headset microphone until we modify a pin definition. Signed-off-by: Chris Chiu <chiu(a)endlessm.com> Signed-off-by: Daniel Drake <drake(a)endlessm.com> --- sound/pci/hda/patch_realtek.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index e2da176..2b1f74f9 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4833,6 +4833,7 @@ enum { ALC290_FIXUP_SUBWOOFER_HSJACK, ALC269_FIXUP_THINKPAD_ACPI, ALC269_FIXUP_DMIC_THINKPAD_ACPI, + ALC255_FIXUP_ACER_MIC_NO_PRESENCE, ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, ALC255_FIXUP_DELL2_MIC_NO_PRESENCE, ALC255_FIXUP_HEADSET_MODE, @@ -5287,6 +5288,15 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_THINKPAD_ACPI, }, + [ALC255_FIXUP_ACER_MIC_NO_PRESENCE] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x19, 0x01a1913c }, /* use as headset mic, without its own jack detect */ + { } + }, + .chained = true, + .chain_id = ALC255_FIXUP_HEADSET_MODE + }, [ALC255_FIXUP_DELL1_MIC_NO_PRESENCE] = { .type = HDA_FIXUP_PINS, .v.pins = (const struct hda_pintbl[]) { @@ -5852,6 +5862,10 @@ static const struct hda_model_fixup alc269_fixup_models[] = { {0x21, 0x03211020} static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { + SND_HDA_PIN_QUIRK(0x10ec0255, 0x1025, "Acer", ALC255_FIXUP_ACER_MIC_NO_PRESENCE, + {0x12, 0x90a601c0}, + {0x14, 0x90171120}, + {0x21, 0x02211030}), SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, ALC225_STANDARD_PINS, {0x12, 0xb7a60130}, -- 2.9.3

2 5

[alsa-devel] [sound:topic/cht-whiskey-cove 1/3] include/acpi/acpi_bus.h:32:21: sparse: expected ; at end of declaration
by kbuild test robot 28 Feb '17

28 Feb '17

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/cht-whiskey-cove head: fe0334695c856dbdbeea861a5eb76f5ddc0dbaa9 commit: fbba8603f93e60c68116197326cdbbceee0b875b [1/3] mfd: Add Cherrytrail WhiskeyCove PMIC driver reproduce: # apt-get install sparse git checkout fbba8603f93e60c68116197326cdbbceee0b875b make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) include/linux/compiler.h:253:8: sparse: attribute 'no_sanitize_address': unknown attribute >> include/acpi/acpi_bus.h:32:21: sparse: expected ; at end of declaration include/acpi/acpi_bus.h:32:21: sparse: Expected } at end of struct-union-enum-specifier include/acpi/acpi_bus.h:32:21: sparse: got handles include/acpi/acpi_bus.h:33:1: sparse: Expected ; at the end of type declaration include/acpi/acpi_bus.h:33:1: sparse: got } include/acpi/acpi_bus.h:37:1: sparse: Expected ; at end of declaration include/acpi/acpi_bus.h:37:1: sparse: got acpi_extract_package include/acpi/acpi_bus.h:40:1: sparse: Expected ; at end of declaration include/acpi/acpi_bus.h:40:1: sparse: got acpi_evaluate_integer include/acpi/acpi_bus.h:44:1: sparse: Expected ; at end of declaration include/acpi/acpi_bus.h:44:1: sparse: got acpi_evaluate_reference include/acpi/acpi_bus.h:49:1: sparse: Expected ; at end of declaration include/acpi/acpi_bus.h:49:1: sparse: got acpi_evaluate_ost include/acpi/acpi_bus.h:53:1: sparse: Expected ; at end of declaration include/acpi/acpi_bus.h:53:1: sparse: got acpi_get_physical_device_location include/acpi/acpi_bus.h:55:34: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:55:34: sparse: got handle include/acpi/acpi_bus.h:56:13: sparse: Expected ; at end of declaration include/acpi/acpi_bus.h:56:13: sparse: got acpi_execute_simple_method include/acpi/acpi_bus.h:58:13: sparse: Expected ; at end of declaration include/acpi/acpi_bus.h:58:13: sparse: got acpi_evaluate_ej0 include/acpi/acpi_bus.h:59:13: sparse: Expected ; at end of declaration include/acpi/acpi_bus.h:59:13: sparse: got acpi_evaluate_lck include/acpi/acpi_bus.h:60:33: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:60:33: sparse: got handle include/acpi/acpi_bus.h:61:33: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:61:33: sparse: got handle include/acpi/acpi_bus.h:62:34: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:62:34: sparse: got handle include/acpi/acpi_bus.h:64:33: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:64:33: sparse: got handle include/acpi/acpi_bus.h:65:50: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:65:50: sparse: got handle include/acpi/acpi_bus.h:69:37: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:69:37: sparse: got handle include/acpi/acpi_bus.h:75:17: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:75:17: sparse: got && >> include/acpi/acpi_bus.h:75:9: sparse: Trying to use reserved word 'if' as identifier include/acpi/acpi_bus.h:78:9: sparse: Expected ; at the end of type declaration include/acpi/acpi_bus.h:78:9: sparse: got } include/acpi/acpi_bus.h:81:1: sparse: Expected ; at the end of type declaration include/acpi/acpi_bus.h:81:1: sparse: got } include/acpi/acpi_bus.h:326:21: sparse: expected ; at end of declaration include/acpi/acpi_bus.h:326:21: sparse: Expected } at end of struct-union-enum-specifier include/acpi/acpi_bus.h:326:21: sparse: got gpe_device include/acpi/acpi_bus.h:334:1: sparse: Expected ; at the end of type declaration include/acpi/acpi_bus.h:334:1: sparse: got } include/acpi/acpi_bus.h:356:21: sparse: expected ; at end of declaration include/acpi/acpi_bus.h:356:21: sparse: Expected } at end of struct-union-enum-specifier include/acpi/acpi_bus.h:356:21: sparse: got handle include/acpi/acpi_bus.h:382:1: sparse: Expected ; at the end of type declaration include/acpi/acpi_bus.h:382:1: sparse: got } include/acpi/acpi_bus.h:387:21: sparse: expected ; at end of declaration include/acpi/acpi_bus.h:387:21: sparse: Expected } at end of struct-union-enum-specifier include/acpi/acpi_bus.h:387:21: sparse: got handle include/acpi/acpi_bus.h:393:1: sparse: Expected ; at the end of type declaration include/acpi/acpi_bus.h:393:1: sparse: got } include/acpi/acpi_bus.h:478:47: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:478:47: sparse: got , include/acpi/acpi_bus.h:479:42: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:479:42: sparse: got , include/acpi/acpi_bus.h:480:45: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:480:45: sparse: got , include/acpi/acpi_bus.h:490:37: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:490:37: sparse: got handle include/acpi/acpi_bus.h:491:58: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:491:58: sparse: got handle include/acpi/acpi_bus.h:493:13: sparse: Expected ; at end of declaration include/acpi/acpi_bus.h:493:13: sparse: got acpi_bus_get_status_handle include/acpi/acpi_bus.h:497:36: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:497:36: sparse: got handle include/acpi/acpi_bus.h:503:39: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:503:39: sparse: got handle include/acpi/acpi_bus.h:505:44: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:505:44: sparse: got handle include/acpi/acpi_bus.h:508:38: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:508:38: sparse: got handle include/acpi/acpi_bus.h:520:31: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:520:31: sparse: got handle include/acpi/acpi_bus.h:522:13: sparse: Expected ; at end of declaration include/acpi/acpi_bus.h:522:13: sparse: got acpi_bus_get_ejd include/acpi/acpi_bus.h:582:54: sparse: Expected ) in function declarator include/acpi/acpi_bus.h:582:54: sparse: got handle include/acpi/acpi_bus.h:588:13: sparse: Expected ; at end of declaration include/acpi/acpi_bus.h:588:13: sparse: got acpi_add_pm_notifier include/acpi/acpi_bus.h:590:13: sparse: Expected ; at end of declaration include/acpi/acpi_bus.h:590:13: sparse: got acpi_remove_pm_notifier include/acpi/acpi_bus.h:74:33: sparse: undefined identifier 'handle' include/acpi/acpi_bus.h:77:17: sparse: symbol 'obj' has multiple initializers (originally initialized at include/acpi/acpi_bus.h:74) include/acpi/acpi_bus.h:364:34: sparse: symbol 'flags' redeclared with different type (originally declared at include/acpi/acpi_bus.h:330) - different base types include/acpi/acpi_bus.h:286:47: sparse: undefined identifier 'ACPI_D_STATE_COUNT' >> include/acpi/acpi_bus.h:286:47: sparse: bad constant expression type include/acpi/acpi_bus.h:409:17: sparse: no member 'fwnode' in struct acpi_device >> include/acpi/acpi_bus.h:409:17: sparse: unknown member >> include/acpi/acpi_bus.h:409:17: sparse: cast from unknown type >> include/acpi/acpi_bus.h:408:44: sparse: incompatible types in conditional expression (different types) include/linux/acpi.h:51:27: sparse: no member 'handle' in struct acpi_device drivers/mfd/intel_soc_pmic_chtwc.c:104:18: sparse: undefined identifier 'acpi_evaluate_integer' In file included from drivers/mfd/intel_soc_pmic_chtwc.c:18:0: include/acpi/acpi_bus.h:32:2: error: unknown type name 'acpi_handle' acpi_handle handles[ACPI_MAX_HANDLES]; ^~~~~~~~~~~ include/acpi/acpi_bus.h:36:1: error: unknown type name 'acpi_status' acpi_status ^~~~~~~~~~~ include/acpi/acpi_bus.h:38:15: warning: 'struct acpi_buffer' declared inside parameter list will not be visible outside of this definition or declaration struct acpi_buffer *format, struct acpi_buffer *buffer); ^~~~~~~~~~~ include/acpi/acpi_bus.h:37:28: warning: 'union acpi_object' declared inside parameter list will not be visible outside of this definition or declaration acpi_extract_package(union acpi_object *package, ^~~~~~~~~~~ include/acpi/acpi_bus.h:39:1: error: unknown type name 'acpi_status' acpi_status ^~~~~~~~~~~ include/acpi/acpi_bus.h:40:23: error: unknown type name 'acpi_handle' acpi_evaluate_integer(acpi_handle handle, ^~~~~~~~~~~ include/acpi/acpi_bus.h:41:9: error: unknown type name 'acpi_string' acpi_string pathname, ^~~~~~~~~~~ include/acpi/acpi_bus.h:43:1: error: unknown type name 'acpi_status' acpi_status ^~~~~~~~~~~ include/acpi/acpi_bus.h:44:25: error: unknown type name 'acpi_handle' acpi_evaluate_reference(acpi_handle handle, ^~~~~~~~~~~ include/acpi/acpi_bus.h:45:4: error: unknown type name 'acpi_string' acpi_string pathname, ^~~~~~~~~~~ include/acpi/acpi_bus.h:48:1: error: unknown type name 'acpi_status' acpi_status ^~~~~~~~~~~ include/acpi/acpi_bus.h:49:19: error: unknown type name 'acpi_handle' acpi_evaluate_ost(acpi_handle handle, u32 source_event, u32 status_code, ^~~~~~~~~~~ include/acpi/acpi_bus.h:52:1: error: unknown type name 'acpi_status' acpi_status ^~~~~~~~~~~ include/acpi/acpi_bus.h:53:35: error: unknown type name 'acpi_handle' acpi_get_physical_device_location(acpi_handle handle, struct acpi_pld_info **pld); ^~~~~~~~~~~ include/acpi/acpi_bus.h:55:22: error: unknown type name 'acpi_handle' bool acpi_has_method(acpi_handle handle, char *name); ^~~~~~~~~~~ include/acpi/acpi_bus.h:56:1: error: unknown type name 'acpi_status' acpi_status acpi_execute_simple_method(acpi_handle handle, char *method, ^~~~~~~~~~~ include/acpi/acpi_bus.h:56:40: error: unknown type name 'acpi_handle' acpi_status acpi_execute_simple_method(acpi_handle handle, char *method, ^~~~~~~~~~~ include/acpi/acpi_bus.h:58:1: error: unknown type name 'acpi_status' acpi_status acpi_evaluate_ej0(acpi_handle handle); ^~~~~~~~~~~ include/acpi/acpi_bus.h:58:31: error: unknown type name 'acpi_handle' acpi_status acpi_evaluate_ej0(acpi_handle handle); ^~~~~~~~~~~ include/acpi/acpi_bus.h:59:1: error: unknown type name 'acpi_status' acpi_status acpi_evaluate_lck(acpi_handle handle, int lock); ^~~~~~~~~~~ include/acpi/acpi_bus.h:59:31: error: unknown type name 'acpi_handle' acpi_status acpi_evaluate_lck(acpi_handle handle, int lock); ^~~~~~~~~~~ include/acpi/acpi_bus.h:60:21: error: unknown type name 'acpi_handle' bool acpi_ata_match(acpi_handle handle); ^~~~~~~~~~~ include/acpi/acpi_bus.h:61:21: error: unknown type name 'acpi_handle' bool acpi_bay_match(acpi_handle handle); ^~~~~~~~~~~ include/acpi/acpi_bus.h:62:22: error: unknown type name 'acpi_handle' bool acpi_dock_match(acpi_handle handle); ^~~~~~~~~~~ include/acpi/acpi_bus.h:64:21: error: unknown type name 'acpi_handle' bool acpi_check_dsm(acpi_handle handle, const u8 *uuid, u64 rev, u64 funcs); ^~~~~~~~~~~ include/acpi/acpi_bus.h:65:38: error: unknown type name 'acpi_handle' union acpi_object *acpi_evaluate_dsm(acpi_handle handle, const u8 *uuid, ^~~~~~~~~~~ include/acpi/acpi_bus.h:69:25: error: unknown type name 'acpi_handle' acpi_evaluate_dsm_typed(acpi_handle handle, const u8 *uuid, u64 rev, u64 func, ^~~~~~~~~~~ include/acpi/acpi_bus.h:70:30: error: unknown type name 'acpi_object_type' union acpi_object *argv4, acpi_object_type type) ^~~~~~~~~~~~~~~~ In file included from drivers/mfd/intel_soc_pmic_chtwc.c:18:0: include/acpi/acpi_bus.h:286:40: error: 'ACPI_D_STATE_COUNT' undeclared here (not in a function) struct acpi_device_power_state states[ACPI_D_STATE_COUNT]; /* Power states (D0-D3Cold) */ ^~~~~~~~~~~~~~~~~~ include/acpi/acpi_bus.h:326:2: error: unknown type name 'acpi_handle' acpi_handle gpe_device; ^~~~~~~~~~~ include/acpi/acpi_bus.h:356:2: error: unknown type name 'acpi_handle' acpi_handle handle; /* no handle for fixed hardware */ ^~~~~~~~~~~ include/acpi/acpi_bus.h:387:2: error: unknown type name 'acpi_handle' acpi_handle handle; ^~~~~~~~~~~ vim +32 include/acpi/acpi_bus.h 8a0662d9 Rafael J. Wysocki 2014-11-04 26 #include <linux/property.h> ^1da177e Linus Torvalds 2005-04-16 27 ^1da177e Linus Torvalds 2005-04-16 28 /* TBD: Make dynamic */ ^1da177e Linus Torvalds 2005-04-16 29 #define ACPI_MAX_HANDLES 10 ^1da177e Linus Torvalds 2005-04-16 30 struct acpi_handle_list { ^1da177e Linus Torvalds 2005-04-16 31 u32 count; ^1da177e Linus Torvalds 2005-04-16 @32 acpi_handle handles[ACPI_MAX_HANDLES]; ^1da177e Linus Torvalds 2005-04-16 33 }; ^1da177e Linus Torvalds 2005-04-16 34 ^1da177e Linus Torvalds 2005-04-16 35 /* acpi_utils.h */ ^1da177e Linus Torvalds 2005-04-16 36 acpi_status 4be44fcd Len Brown 2005-08-05 37 acpi_extract_package(union acpi_object *package, 4be44fcd Len Brown 2005-08-05 38 struct acpi_buffer *format, struct acpi_buffer *buffer); ^1da177e Linus Torvalds 2005-04-16 39 acpi_status 4be44fcd Len Brown 2005-08-05 40 acpi_evaluate_integer(acpi_handle handle, ^1da177e Linus Torvalds 2005-04-16 41 acpi_string pathname, 27663c58 Matthew Wilcox 2008-10-10 42 struct acpi_object_list *arguments, unsigned long long *data); ^1da177e Linus Torvalds 2005-04-16 43 acpi_status 4be44fcd Len Brown 2005-08-05 44 acpi_evaluate_reference(acpi_handle handle, ^1da177e Linus Torvalds 2005-04-16 45 acpi_string pathname, ^1da177e Linus Torvalds 2005-04-16 46 struct acpi_object_list *arguments, ^1da177e Linus Torvalds 2005-04-16 47 struct acpi_handle_list *list); 275c58d7 Toshi Kani 2012-05-23 48 acpi_status 05730c19 Jiang Liu 2014-02-19 49 acpi_evaluate_ost(acpi_handle handle, u32 source_event, u32 status_code, 05730c19 Jiang Liu 2014-02-19 50 struct acpi_buffer *status_buf); ^1da177e Linus Torvalds 2005-04-16 51 38ac0f1b Matthew Garrett 2012-05-11 52 acpi_status 8ede06ab Feng Tang 2012-08-21 53 acpi_get_physical_device_location(acpi_handle handle, struct acpi_pld_info **pld); 952c63e9 Jiang Liu 2013-06-29 54 952c63e9 Jiang Liu 2013-06-29 55 bool acpi_has_method(acpi_handle handle, char *name); 0db98202 Jiang Liu 2013-06-29 56 acpi_status acpi_execute_simple_method(acpi_handle handle, char *method, 0db98202 Jiang Liu 2013-06-29 57 u64 arg); 7d2421f8 Jiang Liu 2013-06-29 58 acpi_status acpi_evaluate_ej0(acpi_handle handle); 7d2421f8 Jiang Liu 2013-06-29 59 acpi_status acpi_evaluate_lck(acpi_handle handle, int lock); ebf4df8d Jiang Liu 2013-06-29 60 bool acpi_ata_match(acpi_handle handle); ebf4df8d Jiang Liu 2013-06-29 61 bool acpi_bay_match(acpi_handle handle); ebf4df8d Jiang Liu 2013-06-29 @62 bool acpi_dock_match(acpi_handle handle); 952c63e9 Jiang Liu 2013-06-29 63 c7e16e52 Jerry Hoemann 2016-04-11 64 bool acpi_check_dsm(acpi_handle handle, const u8 *uuid, u64 rev, u64 funcs); a65ac520 Jiang Liu 2013-12-19 65 union acpi_object *acpi_evaluate_dsm(acpi_handle handle, const u8 *uuid, c7e16e52 Jerry Hoemann 2016-04-11 66 u64 rev, u64 func, union acpi_object *argv4); a65ac520 Jiang Liu 2013-12-19 67 a65ac520 Jiang Liu 2013-12-19 68 static inline union acpi_object * c7e16e52 Jerry Hoemann 2016-04-11 69 acpi_evaluate_dsm_typed(acpi_handle handle, const u8 *uuid, u64 rev, u64 func, a65ac520 Jiang Liu 2013-12-19 70 union acpi_object *argv4, acpi_object_type type) a65ac520 Jiang Liu 2013-12-19 71 { a65ac520 Jiang Liu 2013-12-19 72 union acpi_object *obj; a65ac520 Jiang Liu 2013-12-19 73 a65ac520 Jiang Liu 2013-12-19 74 obj = acpi_evaluate_dsm(handle, uuid, rev, func, argv4); a65ac520 Jiang Liu 2013-12-19 @75 if (obj && obj->type != type) { a65ac520 Jiang Liu 2013-12-19 76 ACPI_FREE(obj); a65ac520 Jiang Liu 2013-12-19 77 obj = NULL; a65ac520 Jiang Liu 2013-12-19 78 } :::::: The code at line 32 was first introduced by commit :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 :::::: TO: Linus Torvalds <torvalds(a)ppc970.osdl.org> :::::: CC: Linus Torvalds <torvalds(a)ppc970.osdl.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH] ALSA: hda - Add subwoofer support for Dell Inspiron 17 7000 Gaming
by Takashi Iwai 28 Feb '17

28 Feb '17

Dell Inspiron 17 7000 Gaming laptop needs a similar quirk like Inspiron 7599 to support its subwoofer speaker. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=194191 Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 73a00460b5c1..fb03c122e0e4 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5606,6 +5606,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x0725, "Dell Inspiron 3162", ALC255_FIXUP_DELL_SPK_NOISE), SND_PCI_QUIRK(0x1028, 0x075b, "Dell XPS 13 9360", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE), SND_PCI_QUIRK(0x1028, 0x075d, "Dell AIO", ALC298_FIXUP_SPK_VOLUME), + SND_PCI_QUIRK(0x1028, 0x0798, "Dell Inspiron 17 7000 Gaming", ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER), SND_PCI_QUIRK(0x1028, 0x164a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x164b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2), -- 2.11.1

1 0

[alsa-devel] [PATCH] ALSA: ctxfi: Fallback DMA mask to 32bit
by Takashi Iwai 28 Feb '17

28 Feb '17

Currently ctxfi driver tries to set only the 64bit DMA mask on 64bit architectures, and bails out if it fails. This causes a problem on some platforms since the 64bit DMA isn't always guaranteed. We should fall back to the default 32bit DMA when 64bit DMA fails. Fixes: 6d74b86d3c0f ("ALSA: ctxfi - Allow 64bit DMA") Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/ctxfi/cthw20k1.c | 19 ++++++------------- sound/pci/ctxfi/cthw20k2.c | 19 ++++++------------- 2 files changed, 12 insertions(+), 26 deletions(-) diff --git a/sound/pci/ctxfi/cthw20k1.c b/sound/pci/ctxfi/cthw20k1.c index 9667cbfb0ca2..ab4cdab5cfa5 100644 --- a/sound/pci/ctxfi/cthw20k1.c +++ b/sound/pci/ctxfi/cthw20k1.c @@ -27,12 +27,6 @@ #include "cthw20k1.h" #include "ct20k1reg.h" -#if BITS_PER_LONG == 32 -#define CT_XFI_DMA_MASK DMA_BIT_MASK(32) /* 32 bit PTE */ -#else -#define CT_XFI_DMA_MASK DMA_BIT_MASK(64) /* 64 bit PTE */ -#endif - struct hw20k1 { struct hw hw; spinlock_t reg_20k1_lock; @@ -1904,19 +1898,18 @@ static int hw_card_start(struct hw *hw) { int err; struct pci_dev *pci = hw->pci; + const unsigned int dma_bits = BITS_PER_LONG; err = pci_enable_device(pci); if (err < 0) return err; /* Set DMA transfer mask */ - if (dma_set_mask(&pci->dev, CT_XFI_DMA_MASK) < 0 || - dma_set_coherent_mask(&pci->dev, CT_XFI_DMA_MASK) < 0) { - dev_err(hw->card->dev, - "architecture does not support PCI busmaster DMA with mask 0x%llx\n", - CT_XFI_DMA_MASK); - err = -ENXIO; - goto error1; + if (dma_set_mask(&pci->dev, DMA_BIT_MASK(dma_bits))) { + dma_set_coherent_mask(&pci->dev, DMA_BIT_MASK(dma_bits)); + } else { + dma_set_mask(&pci->dev, DMA_BIT_MASK(32)); + dma_set_coherent_mask(&pci->dev, DMA_BIT_MASK(32)); } if (!hw->io_base) { diff --git a/sound/pci/ctxfi/cthw20k2.c b/sound/pci/ctxfi/cthw20k2.c index 6414ecf93efa..18ee7768b7c4 100644 --- a/sound/pci/ctxfi/cthw20k2.c +++ b/sound/pci/ctxfi/cthw20k2.c @@ -26,12 +26,6 @@ #include "cthw20k2.h" #include "ct20k2reg.h" -#if BITS_PER_LONG == 32 -#define CT_XFI_DMA_MASK DMA_BIT_MASK(32) /* 32 bit PTE */ -#else -#define CT_XFI_DMA_MASK DMA_BIT_MASK(64) /* 64 bit PTE */ -#endif - struct hw20k2 { struct hw hw; /* for i2c */ @@ -2029,19 +2023,18 @@ static int hw_card_start(struct hw *hw) int err = 0; struct pci_dev *pci = hw->pci; unsigned int gctl; + const unsigned int dma_bits = BITS_PER_LONG; err = pci_enable_device(pci); if (err < 0) return err; /* Set DMA transfer mask */ - if (dma_set_mask(&pci->dev, CT_XFI_DMA_MASK) < 0 || - dma_set_coherent_mask(&pci->dev, CT_XFI_DMA_MASK) < 0) { - dev_err(hw->card->dev, - "architecture does not support PCI busmaster DMA with mask 0x%llx\n", - CT_XFI_DMA_MASK); - err = -ENXIO; - goto error1; + if (!dma_set_mask(&pci->dev, DMA_BIT_MASK(dma_bits))) { + dma_set_coherent_mask(&pci->dev, DMA_BIT_MASK(dma_bits)); + } else { + dma_set_mask(&pci->dev, DMA_BIT_MASK(32)); + dma_set_coherent_mask(&pci->dev, DMA_BIT_MASK(32)); } if (!hw->io_base) { -- 2.11.1

1 0

[alsa-devel] sound: spinlock lockup in snd_timer_user_tinterrupt
by Dmitry Vyukov 28 Feb '17

28 Feb '17

Hello, The following program locks up system: https://gist.githubusercontent.com/dvyukov/1b5cdca7f0fc6254afd4816901160e4c… BUG: spinlock lockup suspected on CPU#1, syz-executor0/6018 lock: kvm_count_lock+0x0/0x60, .magic: dead4ead, .owner: syz-executor0/6001, .owner_cpu: 2 CPU: 1 PID: 6018 Comm: syz-executor0 Not tainted 4.10.0-rc8+ #228 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:15 [inline] dump_stack+0x2ee/0x3ef lib/dump_stack.c:51 spin_dump+0x14d/0x280 kernel/locking/spinlock_debug.c:67 __spin_lock_debug kernel/locking/spinlock_debug.c:117 [inline] do_raw_spin_lock+0x2c1/0x5b0 kernel/locking/spinlock_debug.c:137 __raw_spin_lock include/linux/spinlock_api_smp.h:145 [inline] _raw_spin_lock+0x3b/0x50 kernel/locking/spinlock.c:151 hardware_enable_all arch/x86/kvm/../../../virt/kvm/kvm_main.c:3324 [inline] kvm_create_vm arch/x86/kvm/../../../virt/kvm/kvm_main.c:632 [inline] kvm_dev_ioctl_create_vm arch/x86/kvm/../../../virt/kvm/kvm_main.c:3173 [inline] kvm_dev_ioctl+0x984/0x11b0 arch/x86/kvm/../../../virt/kvm/kvm_main.c:3217 vfs_ioctl fs/ioctl.c:43 [inline] do_vfs_ioctl+0x1bf/0x1790 fs/ioctl.c:683 SYSC_ioctl fs/ioctl.c:698 [inline] SyS_ioctl+0x8f/0xc0 fs/ioctl.c:689 entry_SYSCALL_64_fastpath+0x1f/0xc2 RIP: 0033:0x4458b9 RSP: 002b:00007fb0cb7b7b58 EFLAGS: 00000286 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 0000000000000017 RCX: 00000000004458b9 RDX: 0000000000000000 RSI: 000000000000ae01 RDI: 0000000000000017 RBP: 00000000006dfa10 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000286 R12: 0000000000708150 R13: 0000000020000000 R14: 0000000000fff000 R15: 0000000000000003 NMI backtrace for cpu 1 CPU: 1 PID: 6018 Comm: syz-executor0 Not tainted 4.10.0-rc8+ #228 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:15 [inline] dump_stack+0x2ee/0x3ef lib/dump_stack.c:51 nmi_cpu_backtrace+0xfd/0x120 lib/nmi_backtrace.c:99 nmi_trigger_cpumask_backtrace+0x11d/0x170 lib/nmi_backtrace.c:60 arch_trigger_cpumask_backtrace+0x14/0x20 arch/x86/kernel/apic/hw_nmi.c:37 trigger_all_cpu_backtrace include/linux/nmi.h:58 [inline] __spin_lock_debug kernel/locking/spinlock_debug.c:119 [inline] do_raw_spin_lock+0x2cf/0x5b0 kernel/locking/spinlock_debug.c:137 __raw_spin_lock include/linux/spinlock_api_smp.h:145 [inline] _raw_spin_lock+0x3b/0x50 kernel/locking/spinlock.c:151 hardware_enable_all arch/x86/kvm/../../../virt/kvm/kvm_main.c:3324 [inline] kvm_create_vm arch/x86/kvm/../../../virt/kvm/kvm_main.c:632 [inline] kvm_dev_ioctl_create_vm arch/x86/kvm/../../../virt/kvm/kvm_main.c:3173 [inline] kvm_dev_ioctl+0x984/0x11b0 arch/x86/kvm/../../../virt/kvm/kvm_main.c:3217 vfs_ioctl fs/ioctl.c:43 [inline] do_vfs_ioctl+0x1bf/0x1790 fs/ioctl.c:683 SYSC_ioctl fs/ioctl.c:698 [inline] SyS_ioctl+0x8f/0xc0 fs/ioctl.c:689 entry_SYSCALL_64_fastpath+0x1f/0xc2 RIP: 0033:0x4458b9 RSP: 002b:00007fb0cb7b7b58 EFLAGS: 00000286 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 0000000000000017 RCX: 00000000004458b9 RDX: 0000000000000000 RSI: 000000000000ae01 RDI: 0000000000000017 RBP: 00000000006dfa10 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000286 R12: 0000000000708150 R13: 0000000020000000 R14: 0000000000fff000 R15: 0000000000000003 Sending NMI from CPU 1 to CPUs 0,2-3: NMI backtrace for cpu 0 skipped: idling at pc 0xffffffff84288cb6 NMI backtrace for cpu 2 CPU: 2 PID: 6001 Comm: syz-executor0 Not tainted 4.10.0-rc8+ #228 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 task: ffff880049720640 task.stack: ffff880024a38000 RIP: 0010:rep_nop arch/x86/include/asm/processor.h:616 [inline] RIP: 0010:cpu_relax arch/x86/include/asm/processor.h:621 [inline] RIP: 0010:csd_lock_wait kernel/smp.c:99 [inline] RIP: 0010:smp_call_function_many+0x75c/0x930 kernel/smp.c:455 RSP: 0018:ffff880024a3f6a0 EFLAGS: 00000246 RAX: 0000000000010000 RBX: ffffe8ffffd052d0 RCX: ffffc90000ab5000 RDX: 0000000000010000 RSI: ffffffff8167f79a RDI: ffffffff84ba1ad8 RBP: ffff880024a3f8c0 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000006 R11: 0000000000000000 R12: ffffe8ffffd052e8 R13: dffffc0000000000 R14: 0000000000000003 R15: ffffed0004947eeb FS: 00007fb0cb7fa700(0000) GS:ffff880089e00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000006dfa10 CR3: 0000000051171000 CR4: 00000000000006e0 DR0: 0000000020000000 DR1: 0000000020000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000600 Call Trace: smp_call_function kernel/smp.c:479 [inline] on_each_cpu+0x109/0x330 kernel/smp.c:589 hardware_enable_all arch/x86/kvm/../../../virt/kvm/kvm_main.c:3329 [inline] kvm_create_vm arch/x86/kvm/../../../virt/kvm/kvm_main.c:632 [inline] kvm_dev_ioctl_create_vm arch/x86/kvm/../../../virt/kvm/kvm_main.c:3173 [inline] kvm_dev_ioctl+0xbe2/0x11b0 arch/x86/kvm/../../../virt/kvm/kvm_main.c:3217 vfs_ioctl fs/ioctl.c:43 [inline] do_vfs_ioctl+0x1bf/0x1790 fs/ioctl.c:683 SYSC_ioctl fs/ioctl.c:698 [inline] SyS_ioctl+0x8f/0xc0 fs/ioctl.c:689 entry_SYSCALL_64_fastpath+0x1f/0xc2 RIP: 0033:0x4458b9 RSP: 002b:00007fb0cb7f9b58 EFLAGS: 00000286 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 0000000000000017 RCX: 00000000004458b9 RDX: 0000000000000000 RSI: 000000000000ae01 RDI: 0000000000000017 RBP: 00000000006dfa10 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000286 R12: 0000000000708000 R13: 0000000020000000 R14: 0000000000fff000 R15: 0000000000000003 Code: 3c 03 0f 8e d0 01 00 00 44 89 b5 98 fe ff ff 41 83 e6 01 41 c6 07 f8 74 51 4d 89 e6 41 83 e6 07 41 83 c6 03 e8 66 af 0a 00 f3 90 <4c> 89 e0 41 c6 07 04 48 c1 e8 03 42 0f b6 04 28 41 38 c6 7c 08 NMI backtrace for cpu 3 CPU: 3 PID: 5984 Comm: syz-executor3 Not tainted 4.10.0-rc8+ #228 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 task: ffff88004a566500 task.stack: ffff88002f9f0000 RIP: 0010:arch_local_irq_restore arch/x86/include/asm/paravirt.h:767 [inline] RIP: 0010:lock_release+0x86c/0xe90 kernel/locking/lockdep.c:3775 RSP: 0018:ffff880089f073e8 EFLAGS: 00000082 RAX: dffffc0000000000 RBX: ffff88004a566500 RCX: 1ffff100113e0ea2 RDX: 1ffffffff09d8a95 RSI: 0000000000000001 RDI: 0000000000000082 RBP: ffff880089f07638 R08: ffffe8ffffd32500 R09: 0000000000000001 R10: 1ffff100113e0e6e R11: ffff88009fff70dd R12: ffff880086136d60 R13: 0000000000000001 R14: ffff88004a566d20 R15: 0000000000000002 FS: 00007f366abbe700(0000) GS:ffff880089f00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00005642b47a21e8 CR3: 000000003d684000 CR4: 00000000000006e0 Call Trace: <IRQ> __raw_spin_unlock include/linux/spinlock_api_smp.h:152 [inline] _raw_spin_unlock+0x1a/0x30 kernel/locking/spinlock.c:183 spin_unlock include/linux/spinlock.h:347 [inline] snd_timer_user_tinterrupt+0x54d/0x950 sound/core/timer.c:1322 snd_timer_interrupt.part.12+0xa8f/0x1480 sound/core/timer.c:799 snd_timer_interrupt+0x88/0xb0 sound/core/timer.c:719 snd_hrtimer_callback+0x1f0/0x3c0 sound/core/hrtimer.c:64 __run_hrtimer kernel/time/hrtimer.c:1238 [inline] __hrtimer_run_queues+0x385/0xf80 kernel/time/hrtimer.c:1302 hrtimer_interrupt+0x1c2/0x5e0 kernel/time/hrtimer.c:1336 local_apic_timer_interrupt+0x6f/0xe0 arch/x86/kernel/apic/apic.c:936 smp_apic_timer_interrupt+0x71/0xa0 arch/x86/kernel/apic/apic.c:960 apic_timer_interrupt+0x93/0xa0 arch/x86/entry/entry_64.S:487 RIP: 0010:arch_local_irq_restore arch/x86/include/asm/paravirt.h:767 [inline] RIP: 0010:__raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:162 [inline] RIP: 0010:_raw_spin_unlock_irqrestore+0x144/0x200 kernel/locking/spinlock.c:191 RSP: 0018:ffff88002f9f7568 EFLAGS: 00000282 ORIG_RAX: ffffffffffffff10 RAX: 1ffffffff09d8a95 RBX: 1ffff10005f3eead RCX: 0000000000000006 RDX: 1ffff10005f3eed1 RSI: ffff88004a566cf8 RDI: 0000000000000282 RBP: ffff88002f9f7728 R08: ffffe8ffffd32500 R09: 0000000000000000 R10: 0000000000000006 R11: 0000000000000000 R12: dffffc0000000000 R13: 0000000000000282 R14: ffff88004c077bf0 R15: 0000000000000000 </IRQ> spin_unlock_irqrestore include/linux/spinlock.h:362 [inline] snd_timer_start1+0x1e3/0x950 sound/core/timer.c:480 snd_timer_start+0x5d/0xa0 sound/core/timer.c:589 snd_timer_user_start.isra.7+0xde/0x130 sound/core/timer.c:1823 __snd_timer_user_ioctl sound/core/timer.c:1910 [inline] snd_timer_user_ioctl+0x79d/0x34a0 sound/core/timer.c:1931 vfs_ioctl fs/ioctl.c:43 [inline] do_vfs_ioctl+0x1bf/0x1790 fs/ioctl.c:683 SYSC_ioctl fs/ioctl.c:698 [inline] SyS_ioctl+0x8f/0xc0 fs/ioctl.c:689 entry_SYSCALL_64_fastpath+0x1f/0xc2 RIP: 0033:0x4458b9 RSP: 002b:00007f366abbdb58 EFLAGS: 00000286 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 0000000000000017 RCX: 00000000004458b9 RDX: 0000000000000000 RSI: 00000000000054a0 RDI: 0000000000000017 RBP: 00000000006e0680 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000286 R12: 00000000007080a8 R13: 000000002002f000 R14: 0000000000001000 R15: 0000000000000003 Code: 04 02 f8 48 89 fa 48 c1 ea 03 80 3c 02 00 0f 85 99 03 00 00 48 83 3d fb 94 92 03 00 0f 84 c4 02 00 00 48 8b bd 00 fe ff ff 57 9d <0f> 1f 44 00 00 48 b8 00 00 00 00 00 fc ff df 48 03 85 10 fe ff Or: [ 393.912269] NMI backtrace for cpu 2 [ 393.912271] CPU: 2 PID: 2937 Comm: a.out Not tainted 4.10.0+ #229 [ 393.912274] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 [ 393.912276] task: ffff88006353c400 task.stack: ffff880066da0000 [ 393.912277] RIP: 0010:__lock_acquire+0xc9/0x3430 kernel/locking/lockdep.c:3204 [ 393.912279] RSP: 0018:ffff88006d106f68 EFLAGS: 00000086 [ 393.912282] RAX: ffffed000da20e03 RBX: 1ffff1000da20ea0 RCX: 0000000000000000 [ 393.912285] RDX: dffffc0000000000 RSI: 0000000000000000 RDI: ffff8800681416c8 [ 393.912287] RBP: ffff88006d1074a0 R08: 0000000000000001 R09: 0000000000000001 [ 393.912289] R10: ffff8800681416c8 R11: 0000000000000000 R12: ffff88006d107720 [ 393.912291] R13: ffff88006353c400 R14: 0000000000000000 R15: 0000000000000001 [ 393.912294] FS: 000000000082f880(0000) GS:ffff88006d100000(0000) knlGS:0000000000000000 [ 393.912295] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 393.912298] CR2: 000000002001cfb0 CR3: 000000006ae13000 CR4: 00000000001406e0 [ 393.912299] Call Trace: [ 393.912300] <IRQ> [ 393.912336] lock_acquire+0x2a1/0x630 kernel/locking/lockdep.c:3753 [ 393.912359] __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline] [ 393.912359] _raw_spin_lock+0x33/0x50 kernel/locking/spinlock.c:151 [ 393.912362] spin_lock include/linux/spinlock.h:299 [inline] [ 393.912362] snd_timer_interrupt.part.12+0xaa0/0x1480 sound/core/timer.c:800 [ 393.912401] snd_timer_interrupt+0x88/0xb0 sound/core/timer.c:719 [ 393.912403] snd_hrtimer_callback+0x1f0/0x3c0 sound/core/hrtimer.c:64 [ 393.912404] __run_hrtimer kernel/time/hrtimer.c:1210 [inline] [ 393.912404] __hrtimer_run_queues+0x349/0xe50 kernel/time/hrtimer.c:1274 [ 393.912422] hrtimer_interrupt+0x1c2/0x5e0 kernel/time/hrtimer.c:1308 [ 393.912424] local_apic_timer_interrupt+0x6f/0xe0 arch/x86/kernel/apic/apic.c:937 [ 393.912425] smp_apic_timer_interrupt+0x71/0xa0 arch/x86/kernel/apic/apic.c:961 [ 393.912427] apic_timer_interrupt+0x93/0xa0 arch/x86/entry/entry_64.S:487 [ 393.912429] RIP: 0010:arch_local_irq_restore arch/x86/include/asm/paravirt.h:778 [inline] [ 393.912429] RIP: 0010:__raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:160 [inline] [ 393.912429] RIP: 0010:_raw_spin_unlock_irqrestore+0x144/0x200 kernel/locking/spinlock.c:191 [ 393.912431] RSP: 0018:ffff880066da7568 EFLAGS: 00000286 ORIG_RAX: ffffffffffffff10 [ 393.912436] RAX: 1ffffffff09d8eb9 RBX: 1ffff1000cdb4ead RCX: 0000000000000006 [ 393.912438] RDX: 1ffff1000cdb4ed1 RSI: ffff88006353cbe0 RDI: 0000000000000286 [ 393.912440] RBP: ffff880066da7728 R08: ffff88007fff709c R09: 0000000000000000 [ 393.912443] R10: 0000000000000006 R11: 0000000000000000 R12: dffffc0000000000 [ 393.912445] R13: 0000000000000286 R14: ffff8800681416b0 R15: 0000000000000000 [ 393.912446] </IRQ> [ 393.912467] spin_unlock_irqrestore include/linux/spinlock.h:354 [inline] [ 393.912467] snd_timer_start1+0x1e3/0x950 sound/core/timer.c:480 [ 393.912479] snd_timer_start+0x5d/0xa0 sound/core/timer.c:589 [ 393.912481] snd_timer_user_start.isra.7+0xde/0x130 sound/core/timer.c:1823 [ 393.912482] __snd_timer_user_ioctl sound/core/timer.c:1910 [inline] [ 393.912482] snd_timer_user_ioctl+0x79d/0x34a0 sound/core/timer.c:1931 [ 393.912509] vfs_ioctl fs/ioctl.c:43 [inline] [ 393.912509] do_vfs_ioctl+0x1bf/0x1790 fs/ioctl.c:683 [ 393.912524] SYSC_ioctl fs/ioctl.c:698 [inline] [ 393.912524] SyS_ioctl+0x8f/0xc0 fs/ioctl.c:689 [ 393.912525] entry_SYSCALL_64_fastpath+0x1f/0xc2 [ 393.912527] RIP: 0033:0x434d89 [ 393.912528] RSP: 002b:00007ffd0ad83a48 EFLAGS: 00000217 ORIG_RAX: 0000000000000010 [ 393.912532] RAX: ffffffffffffffda RBX: 0000000000401ae0 RCX: 0000000000434d89 [ 393.912534] RDX: 0000000000000000 RSI: 00000000000054a0 RDI: 0000000000000003 [ 393.912536] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 [ 393.912538] R10: 0000000000000000 R11: 0000000000000217 R12: 00000000004002b0 [ 393.912540] R13: 0000000000401ae0 R14: 0000000000401b70 R15: 0000000000000000 [ 393.912542] Code: f2 c7 40 28 f2 f2 f2 f2 c7 40 2c 04 f2 f2 f2 c7 40 30 f2 f2 f2 f2 c7 40 34 00 f2 f2 f2 c7 40 38 f2 f2 f2 f2 c7 40 3c 00 f2 f2 f2 <c7> 40 40 f2 f2 f2 f2 c7 40 44 00 f2 f2 f2 c7 40 48 f2 f2 f2 f2 On commit e5d56efc97f8240d0b5d66c03949382b6d7e5570

2 2

[alsa-devel] [PATCH -next] ASoC: hdmi-codec: fix non static symbol warnings
by Wei Yongjun 28 Feb '17

28 Feb '17

From: Wei Yongjun <weiyongjun1(a)huawei.com> Fixes the following sparse warnings: sound/soc/codecs/hdmi-codec.c:34:1: warning: symbol 'hdmi_device_list' was not declared. Should it be static? sound/soc/codecs/hdmi-codec.c:80:33: warning: symbol 'hdmi_codec_stereo_chmaps' was not declared. Should it be static? sound/soc/codecs/hdmi-codec.c:87:33: warning: symbol 'hdmi_codec_8ch_chmaps' was not declared. Should it be static? sound/soc/codecs/hdmi-codec.c:354:6: warning: symbol 'hdmi_codec_eld_chmap' was not declared. Should it be static? Signed-off-by: Wei Yongjun <weiyongjun1(a)huawei.com> --- sound/soc/codecs/hdmi-codec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c index dc6715a..4982c91 100644 --- a/sound/soc/codecs/hdmi-codec.c +++ b/sound/soc/codecs/hdmi-codec.c @@ -31,7 +31,7 @@ struct hdmi_device { int cnt; }; #define pos_to_hdmi_device(pos) container_of((pos), struct hdmi_device, list) -LIST_HEAD(hdmi_device_list); +static LIST_HEAD(hdmi_device_list); #define DAI_NAME_SIZE 16 @@ -77,14 +77,14 @@ struct hdmi_codec_cea_spk_alloc { }; /* Channel maps stereo HDMI */ -const struct snd_pcm_chmap_elem hdmi_codec_stereo_chmaps[] = { +static const struct snd_pcm_chmap_elem hdmi_codec_stereo_chmaps[] = { { .channels = 2, .map = { SNDRV_CHMAP_FL, SNDRV_CHMAP_FR } }, { } }; /* Channel maps for multi-channel playbacks, up to 8 n_ch */ -const struct snd_pcm_chmap_elem hdmi_codec_8ch_chmaps[] = { +static const struct snd_pcm_chmap_elem hdmi_codec_8ch_chmaps[] = { { .channels = 2, /* CA_ID 0x00 */ .map = { SNDRV_CHMAP_FL, SNDRV_CHMAP_FR } }, { .channels = 4, /* CA_ID 0x01 */ @@ -351,7 +351,7 @@ static unsigned long hdmi_codec_spk_mask_from_alloc(int spk_alloc) return spk_mask; } -void hdmi_codec_eld_chmap(struct hdmi_codec_priv *hcp) +static void hdmi_codec_eld_chmap(struct hdmi_codec_priv *hcp) { u8 spk_alloc; unsigned long spk_mask;

3 2