February 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/9] tools subsystem refcounter conversions
by Elena Reshetova 24 Feb '17

24 Feb '17

Now when new refcount_t type and API are finally merged (see include/linux/refcount.h), the following patches convert various refcounters in the tools susystem from atomic_t to refcount_t. By doing this we prevent intentional or accidental underflows or overflows that can led to use-after-free vulnerabilities. The below patches are fully independent and can be cherry-picked separately. Since we convert all kernel subsystems in the same fashion, resulting in about 300 patches, we have to group them for sending at least in some fashion to be manageable. Please excuse the long cc list. Elena Reshetova (9): tools: convert cgroup_sel.refcnt from atomic_t to refcount_t tools: convert cpu_map.refcnt from atomic_t to refcount_t tools: convert comm_str.refcnt from atomic_t to refcount_t tools: convert dso.refcnt from atomic_t to refcount_t tools: convert map.refcnt from atomic_t to refcount_t tools: convert map_groups.refcnt from atomic_t to refcount_t tools: convert perf_map.refcnt from atomic_t to refcount_t tools: convert thread.refcnt from atomic_t to refcount_t tools: convert thread_map.refcnt from atomic_t to refcount_t tools/perf/util/cgroup.c | 6 +++--- tools/perf/util/cgroup.h | 4 ++-- tools/perf/util/comm.c | 13 +++++-------- tools/perf/util/cpumap.c | 16 ++++++++-------- tools/perf/util/cpumap.h | 4 ++-- tools/perf/util/dso.c | 6 +++--- tools/perf/util/dso.h | 4 ++-- tools/perf/util/evlist.c | 18 +++++++++--------- tools/perf/util/evlist.h | 4 ++-- tools/perf/util/map.c | 10 +++++----- tools/perf/util/map.h | 10 +++++----- tools/perf/util/thread.c | 6 +++--- tools/perf/util/thread.h | 4 ++-- tools/perf/util/thread_map.c | 20 ++++++++++---------- tools/perf/util/thread_map.h | 4 ++-- 15 files changed, 63 insertions(+), 66 deletions(-) -- 2.7.4

4 35

[alsa-devel] [sound:topic/asus-e100h-4.10 5/26] arch/x86/include/asm/iosf_mbi.h:137:55: warning: 'struct notifier_block' declared inside parameter list will not be visible outside of this definition or declaration
by kbuild test robot 24 Feb '17

24 Feb '17

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/asus-e100h-4.10 head: c86c0067e6111324a39f523c250c8b1089b1d822 commit: d97e0b9238852206e9dce1de994ff8d2791f6429 [5/26] x86/platform/intel/iosf_mbi: Add a PMIC bus access notifier config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: git checkout d97e0b9238852206e9dce1de994ff8d2791f6429 # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): In file included from arch/x86/platform/intel-quark/imr.c:30:0: >> arch/x86/include/asm/iosf_mbi.h:137:55: warning: 'struct notifier_block' declared inside parameter list will not be visible outside of this definition or declaration int iosf_mbi_register_pmic_bus_access_notifier(struct notifier_block *nb); ^~~~~~~~~~~~~~ arch/x86/include/asm/iosf_mbi.h:144:57: warning: 'struct notifier_block' declared inside parameter list will not be visible outside of this definition or declaration int iosf_mbi_unregister_pmic_bus_access_notifier(struct notifier_block *nb); ^~~~~~~~~~~~~~ vim +137 arch/x86/include/asm/iosf_mbi.h 121 122 /** 123 * iosf_mbi_register_pmic_bus_access_notifier - Register PMIC bus notifier 124 * 125 * This function can be used by drivers which may need to acquire P-Unit 126 * managed resources from interrupt context, where iosf_mbi_punit_acquire() 127 * can not be used. 128 * 129 * This function allows a driver to register a notifier to get notified (in a 130 * process context) before other drivers start accessing the PMIC bus. 131 * 132 * This allows the driver to acquire any resources, which it may need during 133 * the window the other driver is accessing the PMIC, before hand. 134 * 135 * @nb: notifier_block to register 136 */ > 137 int iosf_mbi_register_pmic_bus_access_notifier(struct notifier_block *nb); 138 139 /** 140 * iosf_mbi_register_pmic_bus_access_notifier - Unregister PMIC bus notifier 141 * 142 * @nb: notifier_block to unregister 143 */ 144 int iosf_mbi_unregister_pmic_bus_access_notifier(struct notifier_block *nb); 145 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

3 2

[alsa-devel] [sound:topic/asus-e100h-4.10 18/26] drivers/clk/x86/clk-pmc-atom.c:156:29: error: storage size of 'plt_clk_ops' isn't known
by kbuild test robot 23 Feb '17

23 Feb '17

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/asus-e100h-4.10 head: c86c0067e6111324a39f523c250c8b1089b1d822 commit: 19a80107e5cf1d2d02b678bb086f305a05e4f692 [18/26] clk: x86: Add Atom PMC platform clocks config: x86_64-randconfig-b0-02240418 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: git checkout 19a80107e5cf1d2d02b678bb086f305a05e4f692 # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): ^~~~~~~~~~~~ drivers/clk/x86/clk-pmc-atom.c:141:24: note: in expansion of macro 'to_clk_plt' struct clk_plt *clk = to_clk_plt(hw); ^~~~~~~~~~ include/linux/kernel.h:850:48: note: (near initialization for 'clk') const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/clk/x86/clk-pmc-atom.c:51:25: note: in expansion of macro 'container_of' #define to_clk_plt(_hw) container_of(_hw, struct clk_plt, hw) ^~~~~~~~~~~~ drivers/clk/x86/clk-pmc-atom.c:141:24: note: in expansion of macro 'to_clk_plt' struct clk_plt *clk = to_clk_plt(hw); ^~~~~~~~~~ drivers/clk/x86/clk-pmc-atom.c: In function 'plt_clk_is_enabled': include/linux/kernel.h:850:48: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/clk/x86/clk-pmc-atom.c:51:25: note: in expansion of macro 'container_of' #define to_clk_plt(_hw) container_of(_hw, struct clk_plt, hw) ^~~~~~~~~~~~ drivers/clk/x86/clk-pmc-atom.c:148:24: note: in expansion of macro 'to_clk_plt' struct clk_plt *clk = to_clk_plt(hw); ^~~~~~~~~~ include/linux/kernel.h:850:48: note: (near initialization for 'clk') const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/clk/x86/clk-pmc-atom.c:51:25: note: in expansion of macro 'container_of' #define to_clk_plt(_hw) container_of(_hw, struct clk_plt, hw) ^~~~~~~~~~~~ drivers/clk/x86/clk-pmc-atom.c:148:24: note: in expansion of macro 'to_clk_plt' struct clk_plt *clk = to_clk_plt(hw); ^~~~~~~~~~ drivers/clk/x86/clk-pmc-atom.c: At top level: drivers/clk/x86/clk-pmc-atom.c:156:21: error: variable 'plt_clk_ops' has initializer but incomplete type static const struct clk_ops plt_clk_ops = { ^~~~~~~ drivers/clk/x86/clk-pmc-atom.c:157:2: error: unknown field 'enable' specified in initializer .enable = plt_clk_enable, ^ drivers/clk/x86/clk-pmc-atom.c:157:12: warning: excess elements in struct initializer .enable = plt_clk_enable, ^~~~~~~~~~~~~~ drivers/clk/x86/clk-pmc-atom.c:157:12: note: (near initialization for 'plt_clk_ops') drivers/clk/x86/clk-pmc-atom.c:158:2: error: unknown field 'disable' specified in initializer .disable = plt_clk_disable, ^ drivers/clk/x86/clk-pmc-atom.c:158:13: warning: excess elements in struct initializer .disable = plt_clk_disable, ^~~~~~~~~~~~~~~ drivers/clk/x86/clk-pmc-atom.c:158:13: note: (near initialization for 'plt_clk_ops') drivers/clk/x86/clk-pmc-atom.c:159:2: error: unknown field 'is_enabled' specified in initializer .is_enabled = plt_clk_is_enabled, ^ drivers/clk/x86/clk-pmc-atom.c:159:16: warning: excess elements in struct initializer .is_enabled = plt_clk_is_enabled, ^~~~~~~~~~~~~~~~~~ drivers/clk/x86/clk-pmc-atom.c:159:16: note: (near initialization for 'plt_clk_ops') drivers/clk/x86/clk-pmc-atom.c:160:2: error: unknown field 'get_parent' specified in initializer .get_parent = plt_clk_get_parent, ^ drivers/clk/x86/clk-pmc-atom.c:160:16: warning: excess elements in struct initializer .get_parent = plt_clk_get_parent, ^~~~~~~~~~~~~~~~~~ drivers/clk/x86/clk-pmc-atom.c:160:16: note: (near initialization for 'plt_clk_ops') drivers/clk/x86/clk-pmc-atom.c:161:2: error: unknown field 'set_parent' specified in initializer .set_parent = plt_clk_set_parent, ^ drivers/clk/x86/clk-pmc-atom.c:161:16: warning: excess elements in struct initializer .set_parent = plt_clk_set_parent, ^~~~~~~~~~~~~~~~~~ drivers/clk/x86/clk-pmc-atom.c:161:16: note: (near initialization for 'plt_clk_ops') drivers/clk/x86/clk-pmc-atom.c:162:2: error: unknown field 'determine_rate' specified in initializer .determine_rate = __clk_mux_determine_rate, ^ drivers/clk/x86/clk-pmc-atom.c:162:20: error: '__clk_mux_determine_rate' undeclared here (not in a function) .determine_rate = __clk_mux_determine_rate, ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/clk/x86/clk-pmc-atom.c:162:20: warning: excess elements in struct initializer drivers/clk/x86/clk-pmc-atom.c:162:20: note: (near initialization for 'plt_clk_ops') drivers/clk/x86/clk-pmc-atom.c: In function 'plt_clk_register': drivers/clk/x86/clk-pmc-atom.c:171:23: error: storage size of 'init' isn't known struct clk_init_data init; ^~~~ drivers/clk/x86/clk-pmc-atom.c:188:8: error: implicit declaration of function 'devm_clk_hw_register' [-Werror=implicit-function-declaration] ret = devm_clk_hw_register(&pdev->dev, &pclk->hw); ^~~~~~~~~~~~~~~~~~~~ drivers/clk/x86/clk-pmc-atom.c:171:23: warning: unused variable 'init' [-Wunused-variable] struct clk_init_data init; ^~~~ drivers/clk/x86/clk-pmc-atom.c: In function 'plt_clk_register_fixed_rate': drivers/clk/x86/clk-pmc-atom.c:221:14: error: implicit declaration of function 'clk_hw_register_fixed_rate' [-Werror=implicit-function-declaration] pclk->clk = clk_hw_register_fixed_rate(&pdev->dev, name, parent_name, ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/clk/x86/clk-pmc-atom.c:221:12: warning: assignment makes pointer from integer without a cast [-Wint-conversion] pclk->clk = clk_hw_register_fixed_rate(&pdev->dev, name, parent_name, ^ drivers/clk/x86/clk-pmc-atom.c:228:3: error: implicit declaration of function 'clk_hw_unregister_fixed_rate' [-Werror=implicit-function-declaration] clk_hw_unregister_fixed_rate(pclk->clk); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/clk/x86/clk-pmc-atom.c: At top level: >> drivers/clk/x86/clk-pmc-atom.c:156:29: error: storage size of 'plt_clk_ops' isn't known static const struct clk_ops plt_clk_ops = { ^~~~~~~~~~~ cc1: some warnings being treated as errors vim +156 drivers/clk/x86/clk-pmc-atom.c 150 151 value = readl(clk->reg); 152 153 return plt_reg_to_enabled(value); 154 } 155 > 156 static const struct clk_ops plt_clk_ops = { 157 .enable = plt_clk_enable, 158 .disable = plt_clk_disable, 159 .is_enabled = plt_clk_is_enabled, 160 .get_parent = plt_clk_get_parent, 161 .set_parent = plt_clk_set_parent, 162 .determine_rate = __clk_mux_determine_rate, 163 }; 164 165 static struct clk_plt *plt_clk_register(struct platform_device *pdev, int id, 166 void __iomem *base, 167 const char **parent_names, 168 int num_parents) 169 { 170 struct clk_plt *pclk; 171 struct clk_init_data init; 172 int ret; 173 174 pclk = devm_kzalloc(&pdev->dev, sizeof(*pclk), GFP_KERNEL); 175 if (!pclk) 176 return ERR_PTR(-ENOMEM); 177 178 init.name = kasprintf(GFP_KERNEL, "%s_%d", PLT_CLK_NAME_BASE, id); 179 init.ops = &plt_clk_ops; 180 init.flags = 0; 181 init.parent_names = parent_names; 182 init.num_parents = num_parents; 183 184 pclk->hw.init = &init; 185 pclk->reg = base + PMC_CLK_CTL_OFFSET + id * PMC_CLK_CTL_SIZE; 186 spin_lock_init(&pclk->lock); 187 188 ret = devm_clk_hw_register(&pdev->dev, &pclk->hw); 189 if (ret) { 190 pclk = ERR_PTR(ret); 191 goto err_free_init; 192 } 193 194 pclk->lookup = clkdev_hw_create(&pclk->hw, init.name, NULL); 195 if (!pclk->lookup) { 196 pclk = ERR_PTR(-ENOMEM); 197 goto err_free_init; 198 } 199 200 err_free_init: 201 kfree(init.name); 202 return pclk; 203 } 204 205 static void plt_clk_unregister(struct clk_plt *pclk) 206 { 207 clkdev_drop(pclk->lookup); 208 } 209 210 static struct clk_plt_fixed *plt_clk_register_fixed_rate(struct platform_device *pdev, 211 const char *name, 212 const char *parent_name, 213 unsigned long fixed_rate) 214 { 215 struct clk_plt_fixed *pclk; 216 217 pclk = devm_kzalloc(&pdev->dev, sizeof(*pclk), GFP_KERNEL); 218 if (!pclk) 219 return ERR_PTR(-ENOMEM); 220 > 221 pclk->clk = clk_hw_register_fixed_rate(&pdev->dev, name, parent_name, 222 0, fixed_rate); 223 if (IS_ERR(pclk->clk)) 224 return ERR_CAST(pclk->clk); --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [sound:topic/asus-e100h-4.10 18/26] drivers/clk/x86/clk-pmc-atom.c:44:16: error: field 'hw' has incomplete type
by kbuild test robot 23 Feb '17

23 Feb '17

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/asus-e100h-4.10 head: c86c0067e6111324a39f523c250c8b1089b1d822 commit: 19a80107e5cf1d2d02b678bb086f305a05e4f692 [18/26] clk: x86: Add Atom PMC platform clocks config: i386-randconfig-i1-02231015 (attached as .config) compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4 reproduce: git checkout 19a80107e5cf1d2d02b678bb086f305a05e4f692 # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): >> drivers/clk/x86/clk-pmc-atom.c:44:16: error: field 'hw' has incomplete type struct clk_hw hw; ^ In file included from include/asm-generic/bug.h:13:0, from arch/x86/include/asm/bug.h:35, from include/linux/bug.h:4, from include/linux/io.h:23, from include/linux/clk-provider.h:14, from drivers/clk/x86/clk-pmc-atom.c:17: drivers/clk/x86/clk-pmc-atom.c: In function 'plt_clk_set_parent': include/linux/kernel.h:850:48: warning: initialization from incompatible pointer type [enabled by default] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/clk/x86/clk-pmc-atom.c:51:25: note: in expansion of macro 'container_of' #define to_clk_plt(_hw) container_of(_hw, struct clk_plt, hw) ^ drivers/clk/x86/clk-pmc-atom.c:113:24: note: in expansion of macro 'to_clk_plt' struct clk_plt *clk = to_clk_plt(hw); ^ include/linux/kernel.h:850:48: warning: (near initialization for 'clk') [enabled by default] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/clk/x86/clk-pmc-atom.c:51:25: note: in expansion of macro 'container_of' #define to_clk_plt(_hw) container_of(_hw, struct clk_plt, hw) ^ drivers/clk/x86/clk-pmc-atom.c:113:24: note: in expansion of macro 'to_clk_plt' struct clk_plt *clk = to_clk_plt(hw); ^ drivers/clk/x86/clk-pmc-atom.c: In function 'plt_clk_get_parent': include/linux/kernel.h:850:48: warning: initialization from incompatible pointer type [enabled by default] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/clk/x86/clk-pmc-atom.c:51:25: note: in expansion of macro 'container_of' #define to_clk_plt(_hw) container_of(_hw, struct clk_plt, hw) ^ drivers/clk/x86/clk-pmc-atom.c:122:24: note: in expansion of macro 'to_clk_plt' struct clk_plt *clk = to_clk_plt(hw); ^ include/linux/kernel.h:850:48: warning: (near initialization for 'clk') [enabled by default] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/clk/x86/clk-pmc-atom.c:51:25: note: in expansion of macro 'container_of' #define to_clk_plt(_hw) container_of(_hw, struct clk_plt, hw) ^ drivers/clk/x86/clk-pmc-atom.c:122:24: note: in expansion of macro 'to_clk_plt' struct clk_plt *clk = to_clk_plt(hw); ^ drivers/clk/x86/clk-pmc-atom.c: In function 'plt_clk_enable': include/linux/kernel.h:850:48: warning: initialization from incompatible pointer type [enabled by default] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/clk/x86/clk-pmc-atom.c:51:25: note: in expansion of macro 'container_of' #define to_clk_plt(_hw) container_of(_hw, struct clk_plt, hw) ^ drivers/clk/x86/clk-pmc-atom.c:132:24: note: in expansion of macro 'to_clk_plt' struct clk_plt *clk = to_clk_plt(hw); ^ include/linux/kernel.h:850:48: warning: (near initialization for 'clk') [enabled by default] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/clk/x86/clk-pmc-atom.c:51:25: note: in expansion of macro 'container_of' #define to_clk_plt(_hw) container_of(_hw, struct clk_plt, hw) ^ drivers/clk/x86/clk-pmc-atom.c:132:24: note: in expansion of macro 'to_clk_plt' struct clk_plt *clk = to_clk_plt(hw); ^ drivers/clk/x86/clk-pmc-atom.c: In function 'plt_clk_disable': include/linux/kernel.h:850:48: warning: initialization from incompatible pointer type [enabled by default] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/clk/x86/clk-pmc-atom.c:51:25: note: in expansion of macro 'container_of' #define to_clk_plt(_hw) container_of(_hw, struct clk_plt, hw) ^ drivers/clk/x86/clk-pmc-atom.c:141:24: note: in expansion of macro 'to_clk_plt' struct clk_plt *clk = to_clk_plt(hw); ^ include/linux/kernel.h:850:48: warning: (near initialization for 'clk') [enabled by default] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/clk/x86/clk-pmc-atom.c:51:25: note: in expansion of macro 'container_of' #define to_clk_plt(_hw) container_of(_hw, struct clk_plt, hw) ^ drivers/clk/x86/clk-pmc-atom.c:141:24: note: in expansion of macro 'to_clk_plt' struct clk_plt *clk = to_clk_plt(hw); ^ drivers/clk/x86/clk-pmc-atom.c: In function 'plt_clk_is_enabled': include/linux/kernel.h:850:48: warning: initialization from incompatible pointer type [enabled by default] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/clk/x86/clk-pmc-atom.c:51:25: note: in expansion of macro 'container_of' #define to_clk_plt(_hw) container_of(_hw, struct clk_plt, hw) ^ drivers/clk/x86/clk-pmc-atom.c:148:24: note: in expansion of macro 'to_clk_plt' struct clk_plt *clk = to_clk_plt(hw); ^ include/linux/kernel.h:850:48: warning: (near initialization for 'clk') [enabled by default] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ drivers/clk/x86/clk-pmc-atom.c:51:25: note: in expansion of macro 'container_of' #define to_clk_plt(_hw) container_of(_hw, struct clk_plt, hw) ^ drivers/clk/x86/clk-pmc-atom.c:148:24: note: in expansion of macro 'to_clk_plt' struct clk_plt *clk = to_clk_plt(hw); ^ drivers/clk/x86/clk-pmc-atom.c: At top level: >> drivers/clk/x86/clk-pmc-atom.c:156:21: error: variable 'plt_clk_ops' has initializer but incomplete type static const struct clk_ops plt_clk_ops = { ^ >> drivers/clk/x86/clk-pmc-atom.c:157:2: error: unknown field 'enable' specified in initializer .enable = plt_clk_enable, ^ >> drivers/clk/x86/clk-pmc-atom.c:157:2: warning: excess elements in struct initializer [enabled by default] drivers/clk/x86/clk-pmc-atom.c:157:2: warning: (near initialization for 'plt_clk_ops') [enabled by default] >> drivers/clk/x86/clk-pmc-atom.c:158:2: error: unknown field 'disable' specified in initializer .disable = plt_clk_disable, ^ drivers/clk/x86/clk-pmc-atom.c:158:2: warning: excess elements in struct initializer [enabled by default] drivers/clk/x86/clk-pmc-atom.c:158:2: warning: (near initialization for 'plt_clk_ops') [enabled by default] >> drivers/clk/x86/clk-pmc-atom.c:159:2: error: unknown field 'is_enabled' specified in initializer .is_enabled = plt_clk_is_enabled, ^ drivers/clk/x86/clk-pmc-atom.c:159:2: warning: excess elements in struct initializer [enabled by default] drivers/clk/x86/clk-pmc-atom.c:159:2: warning: (near initialization for 'plt_clk_ops') [enabled by default] >> drivers/clk/x86/clk-pmc-atom.c:160:2: error: unknown field 'get_parent' specified in initializer .get_parent = plt_clk_get_parent, ^ drivers/clk/x86/clk-pmc-atom.c:160:2: warning: excess elements in struct initializer [enabled by default] drivers/clk/x86/clk-pmc-atom.c:160:2: warning: (near initialization for 'plt_clk_ops') [enabled by default] >> drivers/clk/x86/clk-pmc-atom.c:161:2: error: unknown field 'set_parent' specified in initializer .set_parent = plt_clk_set_parent, ^ drivers/clk/x86/clk-pmc-atom.c:161:2: warning: excess elements in struct initializer [enabled by default] drivers/clk/x86/clk-pmc-atom.c:161:2: warning: (near initialization for 'plt_clk_ops') [enabled by default] >> drivers/clk/x86/clk-pmc-atom.c:162:2: error: unknown field 'determine_rate' specified in initializer .determine_rate = __clk_mux_determine_rate, ^ >> drivers/clk/x86/clk-pmc-atom.c:162:20: error: '__clk_mux_determine_rate' undeclared here (not in a function) .determine_rate = __clk_mux_determine_rate, ^ drivers/clk/x86/clk-pmc-atom.c:162:2: warning: excess elements in struct initializer [enabled by default] .determine_rate = __clk_mux_determine_rate, ^ drivers/clk/x86/clk-pmc-atom.c:162:2: warning: (near initialization for 'plt_clk_ops') [enabled by default] drivers/clk/x86/clk-pmc-atom.c: In function 'plt_clk_register': >> drivers/clk/x86/clk-pmc-atom.c:171:23: error: storage size of 'init' isn't known struct clk_init_data init; ^ >> drivers/clk/x86/clk-pmc-atom.c:188:2: error: implicit declaration of function 'devm_clk_hw_register' [-Werror=implicit-function-declaration] ret = devm_clk_hw_register(&pdev->dev, &pclk->hw); ^ drivers/clk/x86/clk-pmc-atom.c:171:23: warning: unused variable 'init' [-Wunused-variable] struct clk_init_data init; ^ drivers/clk/x86/clk-pmc-atom.c: In function 'plt_clk_register_fixed_rate': >> drivers/clk/x86/clk-pmc-atom.c:221:2: error: implicit declaration of function 'clk_hw_register_fixed_rate' [-Werror=implicit-function-declaration] pclk->clk = clk_hw_register_fixed_rate(&pdev->dev, name, parent_name, ^ >> drivers/clk/x86/clk-pmc-atom.c:221:12: warning: assignment makes pointer from integer without a cast [enabled by default] pclk->clk = clk_hw_register_fixed_rate(&pdev->dev, name, parent_name, ^ >> drivers/clk/x86/clk-pmc-atom.c:228:3: error: implicit declaration of function 'clk_hw_unregister_fixed_rate' [-Werror=implicit-function-declaration] clk_hw_unregister_fixed_rate(pclk->clk); ^ cc1: some warnings being treated as errors vim +/hw +44 drivers/clk/x86/clk-pmc-atom.c 38 struct clk_plt_fixed { 39 struct clk_hw *clk; 40 struct clk_lookup *lookup; 41 }; 42 43 struct clk_plt { > 44 struct clk_hw hw; 45 void __iomem *reg; 46 struct clk_lookup *lookup; 47 /* protect access to PMC registers */ 48 spinlock_t lock; 49 }; 50 > 51 #define to_clk_plt(_hw) container_of(_hw, struct clk_plt, hw) 52 53 struct clk_plt_data { 54 struct clk_plt_fixed **parents; 55 u8 nparents; 56 struct clk_plt *clks[PMC_CLK_NUM]; 57 }; 58 59 /* Return an index in parent table */ 60 static inline int plt_reg_to_parent(int reg) 61 { 62 switch (reg & PMC_MASK_CLK_FREQ) { 63 default: 64 case PMC_CLK_FREQ_XTAL: 65 return 0; 66 case PMC_CLK_FREQ_PLL: 67 return 1; 68 } 69 } 70 71 /* Return clk index of parent */ 72 static inline int plt_parent_to_reg(int index) 73 { 74 switch (index) { 75 default: 76 case 0: 77 return PMC_CLK_FREQ_XTAL; 78 case 1: 79 return PMC_CLK_FREQ_PLL; 80 } 81 } 82 83 /* Abstract status in simpler enabled/disabled value */ 84 static inline int plt_reg_to_enabled(int reg) 85 { 86 switch (reg & PMC_MASK_CLK_CTL) { 87 case PMC_CLK_CTL_GATED_ON_D3: 88 case PMC_CLK_CTL_FORCE_ON: 89 return 1; /* enabled */ 90 case PMC_CLK_CTL_FORCE_OFF: 91 case PMC_CLK_CTL_RESERVED: 92 default: 93 return 0; /* disabled */ 94 } 95 } 96 97 static void plt_clk_reg_update(struct clk_plt *clk, u32 mask, u32 val) 98 { 99 u32 tmp; 100 unsigned long flags; 101 102 spin_lock_irqsave(&clk->lock, flags); 103 104 tmp = readl(clk->reg); 105 tmp = (tmp & ~mask) | (val & mask); 106 writel(tmp, clk->reg); 107 108 spin_unlock_irqrestore(&clk->lock, flags); 109 } 110 111 static int plt_clk_set_parent(struct clk_hw *hw, u8 index) 112 { 113 struct clk_plt *clk = to_clk_plt(hw); 114 115 plt_clk_reg_update(clk, PMC_MASK_CLK_FREQ, plt_parent_to_reg(index)); 116 117 return 0; 118 } 119 120 static u8 plt_clk_get_parent(struct clk_hw *hw) 121 { 122 struct clk_plt *clk = to_clk_plt(hw); 123 u32 value; 124 125 value = readl(clk->reg); 126 127 return plt_reg_to_parent(value); 128 } 129 130 static int plt_clk_enable(struct clk_hw *hw) 131 { 132 struct clk_plt *clk = to_clk_plt(hw); 133 134 plt_clk_reg_update(clk, PMC_MASK_CLK_CTL, PMC_CLK_CTL_FORCE_ON); 135 136 return 0; 137 } 138 139 static void plt_clk_disable(struct clk_hw *hw) 140 { 141 struct clk_plt *clk = to_clk_plt(hw); 142 143 plt_clk_reg_update(clk, PMC_MASK_CLK_CTL, PMC_CLK_CTL_FORCE_OFF); 144 } 145 146 static int plt_clk_is_enabled(struct clk_hw *hw) 147 { > 148 struct clk_plt *clk = to_clk_plt(hw); 149 u32 value; 150 151 value = readl(clk->reg); 152 153 return plt_reg_to_enabled(value); 154 } 155 > 156 static const struct clk_ops plt_clk_ops = { > 157 .enable = plt_clk_enable, > 158 .disable = plt_clk_disable, > 159 .is_enabled = plt_clk_is_enabled, > 160 .get_parent = plt_clk_get_parent, > 161 .set_parent = plt_clk_set_parent, > 162 .determine_rate = __clk_mux_determine_rate, 163 }; 164 165 static struct clk_plt *plt_clk_register(struct platform_device *pdev, int id, 166 void __iomem *base, 167 const char **parent_names, 168 int num_parents) 169 { 170 struct clk_plt *pclk; > 171 struct clk_init_data init; 172 int ret; 173 174 pclk = devm_kzalloc(&pdev->dev, sizeof(*pclk), GFP_KERNEL); 175 if (!pclk) 176 return ERR_PTR(-ENOMEM); 177 178 init.name = kasprintf(GFP_KERNEL, "%s_%d", PLT_CLK_NAME_BASE, id); 179 init.ops = &plt_clk_ops; 180 init.flags = 0; 181 init.parent_names = parent_names; 182 init.num_parents = num_parents; 183 184 pclk->hw.init = &init; 185 pclk->reg = base + PMC_CLK_CTL_OFFSET + id * PMC_CLK_CTL_SIZE; 186 spin_lock_init(&pclk->lock); 187 > 188 ret = devm_clk_hw_register(&pdev->dev, &pclk->hw); 189 if (ret) { 190 pclk = ERR_PTR(ret); 191 goto err_free_init; 192 } 193 194 pclk->lookup = clkdev_hw_create(&pclk->hw, init.name, NULL); 195 if (!pclk->lookup) { 196 pclk = ERR_PTR(-ENOMEM); 197 goto err_free_init; 198 } 199 200 err_free_init: 201 kfree(init.name); 202 return pclk; 203 } 204 205 static void plt_clk_unregister(struct clk_plt *pclk) 206 { 207 clkdev_drop(pclk->lookup); 208 } 209 210 static struct clk_plt_fixed *plt_clk_register_fixed_rate(struct platform_device *pdev, 211 const char *name, 212 const char *parent_name, 213 unsigned long fixed_rate) 214 { 215 struct clk_plt_fixed *pclk; 216 217 pclk = devm_kzalloc(&pdev->dev, sizeof(*pclk), GFP_KERNEL); 218 if (!pclk) 219 return ERR_PTR(-ENOMEM); 220 > 221 pclk->clk = clk_hw_register_fixed_rate(&pdev->dev, name, parent_name, 222 0, fixed_rate); 223 if (IS_ERR(pclk->clk)) 224 return ERR_CAST(pclk->clk); 225 226 pclk->lookup = clkdev_hw_create(pclk->clk, name, NULL); 227 if (!pclk->lookup) { > 228 clk_hw_unregister_fixed_rate(pclk->clk); 229 return ERR_PTR(-ENOMEM); 230 } 231 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

Re: [alsa-devel] [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn
by Rob Herring 23 Feb '17

23 Feb '17

On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <joe(a)perches.com> wrote: > There are ~4300 uses of pr_warn and ~250 uses of the older > pr_warning in the kernel source tree. > > Make the use of pr_warn consistent across all kernel files. > > This excludes all files in tools/ as there is a separate > define pr_warning for that directory tree and pr_warn is > not used in tools/. > > Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing. > > Miscellanea: > > o Coalesce formats and realign arguments > > Some files not compiled - no cross-compilers > > Joe Perches (35): > alpha: Convert remaining uses of pr_warning to pr_warn > ARM: ep93xx: Convert remaining uses of pr_warning to pr_warn > arm64: Convert remaining uses of pr_warning to pr_warn > arch/blackfin: Convert remaining uses of pr_warning to pr_warn > ia64: Convert remaining use of pr_warning to pr_warn > powerpc: Convert remaining uses of pr_warning to pr_warn > sh: Convert remaining uses of pr_warning to pr_warn > sparc: Convert remaining use of pr_warning to pr_warn > x86: Convert remaining uses of pr_warning to pr_warn > drivers/acpi: Convert remaining uses of pr_warning to pr_warn > block/drbd: Convert remaining uses of pr_warning to pr_warn > gdrom: Convert remaining uses of pr_warning to pr_warn > drivers/char: Convert remaining use of pr_warning to pr_warn > clocksource: Convert remaining use of pr_warning to pr_warn > drivers/crypto: Convert remaining uses of pr_warning to pr_warn > fmc: Convert remaining use of pr_warning to pr_warn > drivers/gpu: Convert remaining uses of pr_warning to pr_warn > drivers/ide: Convert remaining uses of pr_warning to pr_warn > drivers/input: Convert remaining uses of pr_warning to pr_warn > drivers/isdn: Convert remaining uses of pr_warning to pr_warn > drivers/macintosh: Convert remaining uses of pr_warning to pr_warn > drivers/media: Convert remaining use of pr_warning to pr_warn > drivers/mfd: Convert remaining uses of pr_warning to pr_warn > drivers/mtd: Convert remaining uses of pr_warning to pr_warn > drivers/of: Convert remaining uses of pr_warning to pr_warn > drivers/oprofile: Convert remaining uses of pr_warning to pr_warn > drivers/platform: Convert remaining uses of pr_warning to pr_warn > drivers/rapidio: Convert remaining use of pr_warning to pr_warn > drivers/scsi: Convert remaining use of pr_warning to pr_warn > drivers/sh: Convert remaining use of pr_warning to pr_warn > drivers/tty: Convert remaining uses of pr_warning to pr_warn > drivers/video: Convert remaining uses of pr_warning to pr_warn > kernel/trace: Convert remaining uses of pr_warning to pr_warn > lib: Convert remaining uses of pr_warning to pr_warn > sound/soc: Convert remaining uses of pr_warning to pr_warn Where's the removal of pr_warning so we don't have more sneak in? Rob

3 3

[alsa-devel] [Bug report] dmix on armv8
by Rémi Pincent 23 Feb '17

23 Feb '17

Here is my alsa config : http://www.alsa-project.org/db/?f=d8c96ba81442526650f277e0b7d43dfb6fd668a4 On raspberry I cannot use dmix plugin, when I run a speaker-test with a very simple config using dmix (refer given config in alsa result), its stays stuck. When I use default alsa config (direct use of hw:0,0 without dmix), mixing is done as said here : NOTE: For ALSA 1.0.9rc2 and higher you don't need to setup dmix for analogue output. Dmix is enabled by default for soundcards which don't support hardware mixing. You still need to set it up for digital outputs. Here are some users having same problem http://raspberrypi.stackexchange.com/questions/57787/using-the-alsa-dmix-pl… . I'm not sure it is an alsa problem. But alsa developers could help solving this issue. regards lah

1 0

[alsa-devel] [PATCH] sound: convert snd_seq_subscribers.ref_count from atomic_t to refcount_t
by Elena Reshetova 23 Feb '17

23 Feb '17

refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova <elena.reshetova(a)intel.com> Signed-off-by: Hans Liljestrand <ishkamiel(a)gmail.com> Signed-off-by: Kees Cook <keescook(a)chromium.org> Signed-off-by: David Windsor <dwindsor(a)gmail.com> --- sound/core/seq/seq_clientmgr.c | 2 +- sound/core/seq/seq_ports.c | 7 +++---- sound/core/seq/seq_ports.h | 3 ++- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/core/seq/seq_clientmgr.c b/sound/core/seq/seq_clientmgr.c index 4c93520..3440f76 100644 --- a/sound/core/seq/seq_clientmgr.c +++ b/sound/core/seq/seq_clientmgr.c @@ -666,7 +666,7 @@ static int deliver_to_subscribers(struct snd_seq_client *client, down_read(&grp->list_mutex); list_for_each_entry(subs, &grp->list_head, src_list) { /* both ports ready? */ - if (atomic_read(&subs->ref_count) != 2) + if (refcount_read(&subs->ref_count) != 2) continue; event->dest = subs->info.dest; if (subs->info.flags & SNDRV_SEQ_PORT_SUBS_TIMESTAMP) diff --git a/sound/core/seq/seq_ports.c b/sound/core/seq/seq_ports.c index fe686ee..1ca896b 100644 --- a/sound/core/seq/seq_ports.c +++ b/sound/core/seq/seq_ports.c @@ -241,7 +241,7 @@ static void clear_subscriber_list(struct snd_seq_client *client, * we decrease the counter, and when both ports are deleted * remove the subscriber info */ - if (atomic_dec_and_test(&subs->ref_count)) + if (refcount_dec_and_test(&subs->ref_count)) kfree(subs); continue; } @@ -520,7 +520,6 @@ static int check_and_subscribe_port(struct snd_seq_client *client, else list_add_tail(&subs->dest_list, &grp->list_head); grp->exclusive = exclusive; - atomic_inc(&subs->ref_count); write_unlock_irq(&grp->list_lock); err = 0; @@ -570,7 +569,6 @@ int snd_seq_port_connect(struct snd_seq_client *connector, return -ENOMEM; subs->info = *info; - atomic_set(&subs->ref_count, 0); INIT_LIST_HEAD(&subs->src_list); INIT_LIST_HEAD(&subs->dest_list); @@ -587,6 +585,7 @@ int snd_seq_port_connect(struct snd_seq_client *connector, if (err < 0) goto error_dest; + refcount_set(&subs->ref_count, 2); return 0; error_dest: @@ -613,7 +612,7 @@ int snd_seq_port_disconnect(struct snd_seq_client *connector, /* look for the connection */ list_for_each_entry(subs, &src->list_head, src_list) { if (match_subs_info(info, &subs->info)) { - atomic_dec(&subs->ref_count); /* mark as not ready */ + refcount_dec(&subs->ref_count); /* mark as not ready */ err = 0; break; } diff --git a/sound/core/seq/seq_ports.h b/sound/core/seq/seq_ports.h index 26bd71f..d09e396 100644 --- a/sound/core/seq/seq_ports.h +++ b/sound/core/seq/seq_ports.h @@ -21,6 +21,7 @@ #ifndef __SND_SEQ_PORTS_H #define __SND_SEQ_PORTS_H +#include <linux/refcount.h> #include <sound/seq_kernel.h> #include "seq_lock.h" @@ -44,7 +45,7 @@ struct snd_seq_subscribers { struct snd_seq_port_subscribe info; /* additional info */ struct list_head src_list; /* link of sources */ struct list_head dest_list; /* link of destinations */ - atomic_t ref_count; + refcount_t ref_count; }; struct snd_seq_port_subs_info { -- 2.7.4

3 2

[alsa-devel] [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64
by Andreas Färber 23 Feb '17

23 Feb '17

SND_MMP_SOC selects SND_ARM, which is limited to ARM, as well as MMP_SRAM, which is a non-DT driver in arch/arm/mach-arm/. Avoid Kconfig warnings by not making this driver available on ARM64. While at it, tidy the title (Soc -> SoC). Signed-off-by: Andreas Färber <afaerber(a)suse.de> --- v2: new sound/soc/pxa/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig index 823b5a2..f8e1c06 100644 --- a/sound/soc/pxa/Kconfig +++ b/sound/soc/pxa/Kconfig @@ -8,8 +8,8 @@ config SND_PXA2XX_SOC to select the audio interfaces to support below. config SND_MMP_SOC - bool "Soc Audio for Marvell MMP chips" - depends on ARCH_MMP + bool "SoC Audio for Marvell MMP chips" + depends on ARCH_MMP && ARM select MMP_SRAM select SND_SOC_GENERIC_DMAENGINE_PCM select SND_ARM -- 2.10.2

3 4

[alsa-devel] [PATCH] aserver: fix building on ppc64le
by leitao＠debian.org 23 Feb '17

23 Feb '17

From: Breno Leitao <leitao(a)debian.org> Currently aserver fails to build when using parameter --without-versioned, due to an workaround for ppc64 (06221f86d207cb33ddd4867ca5301eeb247c4400). This workaround is not required anymore on the ppc64 ABI v2, and, in fact is breaking the compilation. Reverting this commit Signed-off-by: Breno Leitao <leitao(a)debian.org> --- include/alsa-symbols.h | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/include/alsa-symbols.h b/include/alsa-symbols.h index 51cb982..eeacfdb 100644 --- a/include/alsa-symbols.h +++ b/include/alsa-symbols.h @@ -29,19 +29,10 @@ #define INTERNAL_CONCAT2_2(Pre, Post) Pre##Post #define INTERNAL(Name) INTERNAL_CONCAT2_2(__, Name) -#ifdef __powerpc64__ -# define symbol_version(real, name, version) \ - __asm__ (".symver " ASM_NAME(#real) "," ASM_NAME(#name) "@" #version); \ - __asm__ (".symver ." ASM_NAME(#real) ",." ASM_NAME(#name) "@" #version) -# define default_symbol_version(real, name, version) \ - __asm__ (".symver " ASM_NAME(#real) "," ASM_NAME(#name) "@@" #version); \ - __asm__ (".symver ." ASM_NAME(#real) ",." ASM_NAME(#name) "@@" #version) -#else # define symbol_version(real, name, version) \ __asm__ (".symver " ASM_NAME(#real) "," ASM_NAME(#name) "@" #version) # define default_symbol_version(real, name, version) \ __asm__ (".symver " ASM_NAME(#real) "," ASM_NAME(#name) "@@" #version) -#endif #ifdef USE_VERSIONED_SYMBOLS #define use_symbol_version(real, name, version) \ @@ -50,13 +41,6 @@ default_symbol_version(real, name, version) #else #define use_symbol_version(real, name, version) /* nothing */ -#ifdef __powerpc64__ -#define use_default_symbol_version(real, name, version) \ - __asm__ (".weak " ASM_NAME(#name)); \ - __asm__ (".weak ." ASM_NAME(#name)); \ - __asm__ (".set " ASM_NAME(#name) "," ASM_NAME(#real)); \ - __asm__ (".set ." ASM_NAME(#name) ",." ASM_NAME(#real)) -#else #if defined(__alpha__) || defined(__mips__) #define use_default_symbol_version(real, name, version) \ __asm__ (".weak " ASM_NAME(#name)); \ @@ -67,6 +51,5 @@ __asm__ (".set " ASM_NAME(#name) "," ASM_NAME(#real)) #endif #endif -#endif #endif /* __ALSA_SYMBOLS_H */ -- 1.9.3

2 1

[alsa-devel] [bug report] ALSA: usb-audio: Tascam US-16x08 DSP mixer quirk
by Dan Carpenter 22 Feb '17

22 Feb '17

Hello Detlef Urban, This is a semi-automatic email about new static checker warnings. The patch d2bb390a2081: "ALSA: usb-audio: Tascam US-16x08 DSP mixer quirk" from Feb 20, 2017, leads to the following Smatch complaint: sound/usb/mixer_us16x08.c:716 snd_us16x08_meter_get() warn: variable dereferenced before check 'elem' (see line 711) sound/usb/mixer_us16x08.c 710 struct usb_mixer_elem_info *elem = kcontrol->private_data; 711 struct snd_usb_audio *chip = elem->head.mixer->chip; ^^^^^^^^^^^^^^^^^^^^^^ Dereference. 712 struct snd_us16x08_meter_store *store = elem->private_data; 713 u8 meter_urb[64]; 714 char tmp[max(sizeof(mix_init_msg1), sizeof(mix_init_msg2))]; 715 716 if (elem) { ^^^^ Check. 717 store = (struct snd_us16x08_meter_store *) elem->private_data; 718 chip = elem->head.mixer->chip; regards, dan carpenter

2 1