December 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: atmel-classd: select correct Kconfig symbol
by Arnd Bergmann 08 Dec '17

08 Dec '17

Commit 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") changed the way that the dependencies are handled, but then the Class D amplifier support got merged, which used the old method. This seems to have triggered a very rare randconfig condition for me now, leading to a link error: sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio': atmel_ssc_dai.c:(.text+0x79c): undefined reference to `atmel_pcm_dma_platform_register' atmel_ssc_dai.c:(.text+0x79c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `atmel_pcm_dma_platform_register' sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_put_audio': atmel_ssc_dai.c:(.text+0xf24): undefined reference to `atmel_pcm_dma_platform_unregister' atmel_ssc_dai.c:(.text+0xf24): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `atmel_pcm_dma_platform_unregister' Changing it to select SND_ATMEL_SOC_SSC_DMA as intended rather than SND_ATMEL_SOC_DMA directly makes it work again. Fixes: e0a25b6d1862 ("ASoC: atmel-classd: add the Audio Class D Amplifier") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- sound/soc/atmel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig index 4a56f3dfba51..2d998e5c4fb5 100644 --- a/sound/soc/atmel/Kconfig +++ b/sound/soc/atmel/Kconfig @@ -64,7 +64,7 @@ config SND_AT91_SOC_SAM9X5_WM8731 config SND_ATMEL_SOC_CLASSD tristate "Atmel ASoC driver for boards using CLASSD" depends on ARCH_AT91 || COMPILE_TEST - select SND_ATMEL_SOC_DMA + select SND_ATMEL_SOC_SSC_DMA select REGMAP_MMIO help Say Y if you want to add support for Atmel ASoC driver for boards using -- 2.9.0

4 11

Re: [alsa-devel] [Intel-gfx] [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio
by Ville Syrjälä 08 Dec '17

08 Dec '17

On Fri, Dec 08, 2017 at 08:34:16AM +0000, Chen, Augustine wrote: > Dear Sirs, > Please kindly help reviewing this patch for the Bugzilla below. > https://bugs.freedesktop.org/show_bug.cgi?id=103731 Resend the patch using git send-email please. -- Ville Syrjälä Intel OTC

1 0

[alsa-devel] [PATCH v2 0/2] fix race condition in rsnd_ssi_pointer_update
by jiada_wang＠mentor.com 08 Dec '17

08 Dec '17

From: Jiada Wang <jiada_wang(a)mentor.com> This patch set aims to fix the race condition in rsnd_ssi_pointer_update, between set of byte_pos and wrap it around when new buffer starts. Jiada Wang (2): ASoC: rsnd: ssi: fix race condition in rsnd_ssi_pointer_update ASoC: rsnd: ssi: remove unnesessary period_pos Changes for v2: * Updated commit message sound/soc/sh/rcar/ssi.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) -- 1.7.9.5

2 3

[alsa-devel] [PATCH] ALSA: hda - Add vendor id for Cannonlake HDMI codec
by Guneshwor Singh 08 Dec '17

08 Dec '17

Cannonlake HDMI codec has the same nid as Geminilake. This adds the codec entry for it. Signed-off-by: Guneshwor Singh <guneshwor.o.singh(a)intel.com> --- sound/pci/hda/patch_hdmi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index c19c81d230bd..b4f1b6e88305 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -55,10 +55,11 @@ MODULE_PARM_DESC(static_hdmi_pcm, "Don't restrict PCM parameters per ELD info"); #define is_kabylake(codec) ((codec)->core.vendor_id == 0x8086280b) #define is_geminilake(codec) (((codec)->core.vendor_id == 0x8086280d) || \ ((codec)->core.vendor_id == 0x80862800)) +#define is_cannonlake(codec) ((codec)->core.vendor_id == 0x8086280c) #define is_haswell_plus(codec) (is_haswell(codec) || is_broadwell(codec) \ || is_skylake(codec) || is_broxton(codec) \ - || is_kabylake(codec)) || is_geminilake(codec) - + || is_kabylake(codec)) || is_geminilake(codec) \ + || is_cannonlake(codec) #define is_valleyview(codec) ((codec)->core.vendor_id == 0x80862882) #define is_cherryview(codec) ((codec)->core.vendor_id == 0x80862883) #define is_valleyview_plus(codec) (is_valleyview(codec) || is_cherryview(codec)) @@ -3841,6 +3842,7 @@ HDA_CODEC_ENTRY(0x80862808, "Broadwell HDMI", patch_i915_hsw_hdmi), HDA_CODEC_ENTRY(0x80862809, "Skylake HDMI", patch_i915_hsw_hdmi), HDA_CODEC_ENTRY(0x8086280a, "Broxton HDMI", patch_i915_hsw_hdmi), HDA_CODEC_ENTRY(0x8086280b, "Kabylake HDMI", patch_i915_hsw_hdmi), +HDA_CODEC_ENTRY(0x8086280c, "Cannonlake HDMI", patch_i915_glk_hdmi), HDA_CODEC_ENTRY(0x8086280d, "Geminilake HDMI", patch_i915_glk_hdmi), HDA_CODEC_ENTRY(0x80862800, "Geminilake HDMI", patch_i915_glk_hdmi), HDA_CODEC_ENTRY(0x80862880, "CedarTrail HDMI", patch_generic_hdmi), -- 2.15.1

4 3

[alsa-devel] [PATCH v2] ASoC: Intel: Change kern log level to avoid unwanted messages
by Naveen Manohar 08 Dec '17

08 Dec '17

patch suppresses the warning message "control load not supported" as this is a debug information to help debug issues in topology. Signed-off-by: Naveen Manohar <naveen.m(a)intel.com> Acked-By: Vinod Koul <vinod.koul(a)intel.com> --- v1->v2: Added Intel sub-system sound/soc/intel/skylake/skl-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index a072bcf..81923da 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -2908,7 +2908,7 @@ static int skl_tplg_control_load(struct snd_soc_component *cmpnt, break; default: - dev_warn(bus->dev, "Control load not supported %d:%d:%d\n", + dev_dbg(bus->dev, "Control load not supported %d:%d:%d\n", hdr->ops.get, hdr->ops.put, hdr->ops.info); break; } -- 1.9.1

1 0

[alsa-devel] [PATCH][next] ASoC: pcm186x: make pcm186x_dai_ops and pcm186x_adc_input_channel_sel_value static
by Colin King 07 Dec '17

07 Dec '17

From: Colin Ian King <colin.king(a)canonical.com> pcm186x_dai_ops and pcm186x_adc_input_channel_sel_value are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: symbol 'pcm186x_dai_ops' was not declared. Should it be static? symbol 'pcm186x_adc_input_channel_sel_value' was not declared. Should it be static? Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/soc/codecs/pcm186x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/pcm186x.c b/sound/soc/codecs/pcm186x.c index f7aa56e20169..cdb51427facc 100644 --- a/sound/soc/codecs/pcm186x.c +++ b/sound/soc/codecs/pcm186x.c @@ -59,7 +59,7 @@ static const struct snd_kcontrol_new pcm1865_snd_controls[] = { pcm186x_pga_tlv), }; -const unsigned int pcm186x_adc_input_channel_sel_value[] = { +static const unsigned int pcm186x_adc_input_channel_sel_value[] = { 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f, 0x10, 0x20, 0x30 @@ -475,7 +475,7 @@ static int pcm186x_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id, return 0; } -const struct snd_soc_dai_ops pcm186x_dai_ops = { +static const struct snd_soc_dai_ops pcm186x_dai_ops = { .set_sysclk = pcm186x_set_dai_sysclk, .set_tdm_slot = pcm186x_set_tdm_slot, .set_fmt = pcm186x_set_fmt, -- 2.14.1

2 1

[alsa-devel] [PATCH v3 00/10] Add Headphone Detection to TLV320AIC31xx Driver
by Andrew F. Davis 07 Dec '17

07 Dec '17

Hello all, This series has the end goal of adding headphone detection to the tlv320aic31xx driver. The first few patches are mostly cleanups. Then a couple bug fixes I noticed. Followed by adding interrupt handling and finally headphone detection. Still not sure if the IRQ patch is correct, I think we have no good way to share this IRQ line, so leaving it the way it is for now. Thanks, Andrew Changes from v2: - Rebased on -next - Added delta patch for GPIO header fix - Split platform data remove into fwnode and pdata removal - Rework reset patch to print error code - Use snd_soc_codec_set_jack to set jack Changes from v1: - Splitup the cleanup patch a bit more - Move the GPIO1 register fix patch before header cleanup so it can be taken back into stable - Added Acked-by - New patch dealing with regulator notifications - Various small touchups - Rebased on v4.15-rc1 Andrew F. Davis (10): ASoC: tlv320aic31xx: Fix GPIO header includes ASoC: tlv320aic31xx: Use fwnode APIs over raw OF calls ASoC: tlv320aic31xx: Remove platform data ASoC: tlv320aic31xx: Add MICBIAS off setting ASoC: tlv320aic31xx: Remove regulator notification handling ASoC: tlv320aic31xx: Reset registers during power up ASoC: tlv320aic31xx: Add short circuit detection support ASoC: tlv320aic31xx: Add overflow detection support ASoC: tlv320aic31xx: Add headphone/headset detection ASoC: tlv320aic31xx: Add button press detection .../devicetree/bindings/sound/tlv320aic31xx.txt | 1 + include/dt-bindings/sound/tlv320aic31xx-micbias.h | 1 + sound/soc/codecs/tlv320aic31xx.c | 263 +++++++++++++-------- sound/soc/codecs/tlv320aic31xx.h | 41 +++- 4 files changed, 196 insertions(+), 110 deletions(-) -- 2.15.0

2 13

[alsa-devel] [PATCH v2 00/19] Add Headphone Detection to TLV320AIC31xx Driver
by Andrew F. Davis 07 Dec '17

07 Dec '17

Hello all, This series has the end goal of adding headphone detection to the tlv320aic31xx driver. The first few patches are mostly cleanups. Then a couple bug fixes I noticed. Followed by adding interrupt handling and finally headphone detection. This series (or at least patch #8) depend on this DT fix[0]. Thanks, Andrew Changes from v1: - Splitup the cleanup patch a bit more - Move the GPIO1 register fix patch before header cleanup so it can be taken back into stable - Added Acked-by - New patch dealing with regulator notifications - Various small touchups - Rebased on v4.15-rc1 + [0] [0] http://www.spinics.net/lists/kernel/msg2660968.html Andrew F. Davis (19): ASoC: tlv320aic31xx: File header and copyright cleanup ASoC: tlv320aic31xx: Change aic31xx_power_off return type to void ASoC: tlv320aic31xx: Move ACPI table next to OF table ASoC: tlv320aic31xx: General source formatting cleanup ASoC: tlv320aic31xx: Fix GPIO1 register definition ASoC: tlv320aic31xx: Reformat header file using GENMASK and BIT macros ASoC: tlv320aic31xx: Merge init function into probe ASoC: tlv320aic31xx: Switch GPIO handling to use gpiod_* API ASoC: tlv320aic31xx: Remove platform data ASoC: tlv320aic31xx: Add MICBIAS off setting ASoC: tlv320aic31xx: Check clock and divider before division ASoC: tlv320aic31xx: Add CODEC clock slave support ASoC: tlv320aic31xx: Fix inverted BCLK handling ASoC: tlv320aic31xx: Remove regulator notification handling ASoC: tlv320aic31xx: Reset registers during power up ASoC: tlv320aic31xx: Add short circuit detection support ASoC: tlv320aic31xx: Add overflow detection support ASoC: tlv320aic31xx: Add headphone/headset detection ASoC: tlv320aic31xx: Add button press detection .../devicetree/bindings/sound/tlv320aic31xx.txt | 1 + include/dt-bindings/sound/tlv320aic31xx-micbias.h | 1 + sound/soc/codecs/tlv320aic31xx.c | 422 ++++++++++-------- sound/soc/codecs/tlv320aic31xx.h | 496 ++++++++++----------- 4 files changed, 471 insertions(+), 449 deletions(-) rewrite sound/soc/codecs/tlv320aic31xx.h (83%) -- 2.15.0

2 62

[alsa-devel] [RFC 00/10] Enable HDA Codec support on Intel Platforms (Series2)
by Rakesh Ughreja 07 Dec '17

07 Dec '17

Many Intel platforms (SKL,KBL) etc. in the market supports enahanced audio capabilities which also includes DSP processing. This patch carry forwads the works that is done in the previous series to enable HD Audio codecs on such platforms. This patch series adds ASoC HDA codec driver for Intel platforms. It is written by reusing the legacy HDA ALSA codec driver. Intention is to maximize the reuse and minimize the changes in the legacy HDA codec driver. I would like to receive feedback before proceeding further on this direction. TODO: - This series is tested on KBL based product (Dell XPS 13). - Basic playback is working with headset and speakers. - Capture operation is not tested. - More platforms and use cases coverage can be added once we have basic agreement in terms of the overall approach. FIXME: - KConfig changes does not look right, but I could not think of any proper way without making changes into legacy HDA codec driver. So need some help on this topic. Rakesh Ughreja (10): ASoC: Intel: Boards: Machine driver for Intel platforms ASoC: Intel: Skylake: Add entry in sst_acpi_mach for HDA codecs ASoC: Intel: Skylake: add HDA BE DAIs ASoC: Intel: Skylake: use hda_bus instead of hdac_bus ALSA: hda - make some of the functions externally visible ASoC: hdac_hda: add ASoC based HDA codec driver ALSA: hda: add new API snd_hda_asoc_codec_new for ASoC codec drivers ASoC: hdac_hda: add DAI, widgets and related ops ASoC: hdac_hda: add runtime PM support ASoC: Intel: Boards: add support for HDA codecs include/sound/hdaudio_ext.h | 3 +- sound/hda/ext/hdac_ext_bus.c | 9 +- sound/pci/hda/Kconfig | 11 + sound/pci/hda/hda_codec.c | 109 +++++- sound/pci/hda/hda_codec.h | 32 +- sound/soc/codecs/Kconfig | 6 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/hdac_hda.c | 633 +++++++++++++++++++++++++++++++ sound/soc/codecs/hdac_hda.h | 16 + sound/soc/intel/boards/Kconfig | 11 + sound/soc/intel/boards/Makefile | 2 + sound/soc/intel/boards/skl_hda_generic.c | 386 +++++++++++++++++++ sound/soc/intel/skylake/skl-pcm.c | 32 +- sound/soc/intel/skylake/skl.c | 79 +++- sound/soc/intel/skylake/skl.h | 10 +- 15 files changed, 1315 insertions(+), 26 deletions(-) create mode 100644 sound/soc/codecs/hdac_hda.c create mode 100644 sound/soc/codecs/hdac_hda.h create mode 100644 sound/soc/intel/boards/skl_hda_generic.c -- 2.7.4

5 47

[alsa-devel] [PATCH] alsa-utils: aplay: Adjust sample rate limits to support newer hardware
by Jussi Laako 07 Dec '17

07 Dec '17

There are number of devices that support up to 384 kHz sampling rate and some devices up to 768 kHz sampling rate. This patch increases sanity check limit to 768k in order to support testing of such hardware. Signed-off-by: Jussi Laako <jussi(a)sonarnerd.net> --- aplay/aplay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/aplay/aplay.c b/aplay/aplay.c index dbae17c..6b740c2 100644 --- a/aplay/aplay.c +++ b/aplay/aplay.c @@ -635,10 +635,10 @@ int main(int argc, char *argv[]) error(_("invalid rate argument '%s'"), optarg); return 1; } - if (tmp < 300) + if (tmp < 1000) tmp *= 1000; rhwparams.rate = tmp; - if (tmp < 2000 || tmp > 192000) { + if (tmp < 2000 || tmp > 768000) { error(_("bad speed value %i"), tmp); return 1; } -- 2.7.4

2 1