November 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/9] ASoC: prepare for Component conversion - step 2
by Kuninori Morimoto 08 Nov '17

08 Nov '17

Hi Mark These are resend of one of "replace component" patch series. I had posted it as below. Subject: Prepare to covert Codec/Platform into Component Date: Fri, 01 Sep 2017 14:18:11 +0900 Because it is big patch-set, to avoid sending patch bomb, I will repost it as small amount of patch set. To review from big picture, please check above patch-set. I will continue to resend remainings of it if this small patch-set were accepted Kuninori Morimoto (9): ASoC: snd_soc_component_driver has snd_pcm_ops ASoC: snd_soc_component_driver has snd_compr_ops ASoC: snd_soc_component_driver has pmdown_time ASoC: snd_soc_component_driver has endianness ASoC: snd_soc_component_driver has non_legacy_dai_naming ASoC: add snd_soc_component_read32 ASoC: add snd_soc_component_xxx_bias_level() ASoC: add snd_soc_component_cache_sync() ASoC: add snd_soc_dapm_kcontrol_component() include/sound/soc.h | 78 ++++++++ sound/soc/soc-compress.c | 461 +++++++++++++++++++++++++++++++++++++++++++---- sound/soc/soc-core.c | 83 +++++---- sound/soc/soc-io.c | 14 ++ sound/soc/soc-pcm.c | 378 ++++++++++++++++++++++++++++++++++++-- 5 files changed, 929 insertions(+), 85 deletions(-) -- 1.9.1

2 11

[alsa-devel] Applied "ASoC: add snd_soc_component_xxx_bias_level()" to the asoc tree
by Mark Brown 08 Nov '17

08 Nov '17

The patch ASoC: add snd_soc_component_xxx_bias_level() has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 10e079d9874802c35dc3f51af922531e5423a6bf Mon Sep 17 00:00:00 2001 From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> Date: Mon, 6 Nov 2017 01:48:37 +0000 Subject: [PATCH] ASoC: add snd_soc_component_xxx_bias_level() snd_soc_codec_xxx_bias_level() (= for Codec) will be removed soon. This patch Component version of it. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- include/sound/soc.h | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/include/sound/soc.h b/include/sound/soc.h index 747588273c96..f69b13c4a641 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -1439,6 +1439,21 @@ static inline void snd_soc_codec_init_bias_level(struct snd_soc_codec *codec, snd_soc_dapm_init_bias_level(snd_soc_codec_get_dapm(codec), level); } +/** + * snd_soc_component_init_bias_level() - Initialize COMPONENT DAPM bias level + * @component: The COMPONENT for which to initialize the DAPM bias level + * @level: The DAPM level to initialize to + * + * Initializes the COMPONENT DAPM bias level. See snd_soc_dapm_init_bias_level(). + */ +static inline void +snd_soc_component_init_bias_level(struct snd_soc_component *component, + enum snd_soc_bias_level level) +{ + snd_soc_dapm_init_bias_level( + snd_soc_component_get_dapm(component), level); +} + /** * snd_soc_dapm_get_bias_level() - Get current CODEC DAPM bias level * @codec: The CODEC for which to get the DAPM bias level @@ -1451,6 +1466,19 @@ static inline enum snd_soc_bias_level snd_soc_codec_get_bias_level( return snd_soc_dapm_get_bias_level(snd_soc_codec_get_dapm(codec)); } +/** + * snd_soc_component_get_bias_level() - Get current COMPONENT DAPM bias level + * @component: The COMPONENT for which to get the DAPM bias level + * + * Returns: The current DAPM bias level of the COMPONENT. + */ +static inline enum snd_soc_bias_level +snd_soc_component_get_bias_level(struct snd_soc_component *component) +{ + return snd_soc_dapm_get_bias_level( + snd_soc_component_get_dapm(component)); +} + /** * snd_soc_codec_force_bias_level() - Set the CODEC DAPM bias level * @codec: The CODEC for which to set the level @@ -1466,6 +1494,23 @@ static inline int snd_soc_codec_force_bias_level(struct snd_soc_codec *codec, level); } +/** + * snd_soc_component_force_bias_level() - Set the COMPONENT DAPM bias level + * @component: The COMPONENT for which to set the level + * @level: The level to set to + * + * Forces the COMPONENT bias level to a specific state. See + * snd_soc_dapm_force_bias_level(). + */ +static inline int +snd_soc_component_force_bias_level(struct snd_soc_component *component, + enum snd_soc_bias_level level) +{ + return snd_soc_dapm_force_bias_level( + snd_soc_component_get_dapm(component), + level); +} + /** * snd_soc_dapm_kcontrol_codec() - Returns the codec associated to a kcontrol * @kcontrol: The kcontrol -- 2.15.0

1 0

[alsa-devel] [PATCH 1/2] ASoC: rt5514: Voice wakeup support.
by Oder Chiou 08 Nov '17

08 Nov '17

If the rt5514 Wake on Voice device is opened while suspended, it will be able to wake up the system when a voice command is detected. This patch also supports user-space policy to override wakeup behavior by /sys/bus/spi/drivers/rt5514/spi2.0/power/wakeup. Signed-off-by: Chinyue Chen <chinyue(a)chromium.org> Signed-off-by: Oder Chiou <oder_chiou(a)realtek.com> --- sound/soc/codecs/rt5514-spi.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/sound/soc/codecs/rt5514-spi.c b/sound/soc/codecs/rt5514-spi.c index b90d6d5..0c0e209 100644 --- a/sound/soc/codecs/rt5514-spi.c +++ b/sound/soc/codecs/rt5514-spi.c @@ -448,9 +448,35 @@ static int rt5514_spi_probe(struct spi_device *spi) return ret; } + device_init_wakeup(&spi->dev, true); + + return 0; +} + +static int rt5514_suspend(struct device *dev) +{ + int irq = to_spi_device(dev)->irq; + + if (device_may_wakeup(dev)) + enable_irq_wake(irq); + return 0; } +static int rt5514_resume(struct device *dev) +{ + int irq = to_spi_device(dev)->irq; + + if (device_may_wakeup(dev)) + disable_irq_wake(irq); + + return 0; +} + +static const struct dev_pm_ops rt5514_pm_ops = { + SET_SYSTEM_SLEEP_PM_OPS(rt5514_suspend, rt5514_resume) +}; + static const struct of_device_id rt5514_of_match[] = { { .compatible = "realtek,rt5514", }, {}, @@ -460,6 +486,7 @@ MODULE_DEVICE_TABLE(of, rt5514_of_match); static struct spi_driver rt5514_spi_driver = { .driver = { .name = "rt5514", + .pm = &rt5514_pm_ops, .of_match_table = of_match_ptr(rt5514_of_match), }, .probe = rt5514_spi_probe, -- 2.7.4

2 3

Re: [alsa-devel] [PATCH] ASoC: rt5663: Delay and retry reading rt5663 ID register
by Mark Brown 08 Nov '17

08 Nov '17

On Tue, Nov 07, 2017 at 02:21:21AM +0000, Oder Chiou wrote: > The issue is similar the patch https://patchwork.kernel.org/patch/9681421/. > And in current project, these 2 devices were connected to the same i2c host, > and they meet the same problem. OK... can you resend with the log message all on one line please? That makes it easier for people to grep the kernel source to find where the error came from, it's more important than 80 columns.

1 0

[alsa-devel] ASoC: snd_soc_pcm512x_spi: no license, taints kernel
by Randy Dunlap 08 Nov '17

08 Nov '17

kernel is 4.14-rc8. [ 2600.284567] snd_soc_pcm512x_spi: module license 'unspecified' taints kernel. -- ~Randy

1 0

Re: [alsa-devel] [PATCH] ASoC: amd: fix report accurate hw_ptr during dma
by Alex Deucher 08 Nov '17

08 Nov '17

On Wed, Nov 8, 2017 at 2:30 PM, Guenter Roeck <groeck(a)google.com> wrote: > On Wed, Nov 8, 2017 at 11:18 AM, Deucher, Alexander > <Alexander.Deucher(a)amd.com> wrote: >> >> > -----Original Message----- >> > From: Mark Brown [mailto:broonie@kernel.org] >> > Sent: Wednesday, November 08, 2017 1:48 PM >> > To: Alex Deucher >> > Cc: amd-gfx list; alsa-devel(a)alsa-project.org; Maling list - DRI >> > developers; >> > Mukunda, Vijendar; Liam Girdwood; Takashi Iwai; Guenter Roeck; Deucher, >> > Alexander >> > Subject: Re: [PATCH] ASoC: amd: fix report accurate hw_ptr during dma >> > >> > On Wed, Nov 08, 2017 at 01:40:32PM -0500, Alex Deucher wrote: >> > > On Wed, Nov 8, 2017 at 1:22 PM, Mark Brown <broonie(a)kernel.org> >> > wrote: >> > >> > > > Like I said in reply to your other mail please don't resubmit >> > > > already >> > > > applied patches. The current tip of my topic/amd branch appears to >> > > > be >> > > > this very patch, if there's anything needs changing please send an >> > > > incremental patch. >> > >> > > I'm not seeing this one in your tree either. This is just a resend of >> > > Guenter's patch from an hour ago with the chromium stuff removed. >> > > Maybe you already applied it in the interim? >> > >> > Is this different to "ASoC: amd: Report accurate hw_ptr during dma" >> > which was applied at 16:07? >> >> Yes, this is a fix for that patch. It fixes a 64 bit division that wasn't >> properly handled. >> > > In that case, the subject should reflect the problem fixed, the description > should describe the problem, and there should be a Fixes: tag pointing to > the problematic patch. I updated the patch subject and added a fixes tag when I resent it after removing the chrome tags. The subject could have been bit better, but I wasn't sure how far to take it since it wasn't my patch originally. Alex > > Sorry, I was not aware that the problematic patch is already pending > upstream, or I would have submitted a proper patch upstream myself. > > Guenter > >> >> Alex >> >

2 1

Re: [alsa-devel] [PATCH] ASoC: amd: fix report accurate hw_ptr during dma
by Mark Brown 08 Nov '17

08 Nov '17

On Wed, Nov 08, 2017 at 11:13:50AM -0800, Guenter Roeck wrote: > On Wed, Nov 8, 2017 at 10:47 AM, Mark Brown <broonie(a)kernel.org> wrote: > > Is this different to "ASoC: amd: Report accurate hw_ptr during dma" > > which was applied at 16:07? > I suspect we may be getting hit by chromeos-isms again. In Chrome OS, we > don't use Fixes: tags but "FIXUP: <original description>" in the subject > (not that I like it, but it is what it is). So it probably is the same patch that was just resent with a slightly modified subject line? That's what it looked like initially.

2 1

[alsa-devel] [PATCH] ASoC: amd: fix report accurate hw_ptr during dma
by Alex Deucher 08 Nov '17

08 Nov '17

From: Guenter Roeck <groeck(a)chromium.org> ERROR: "__aeabi_uldivmod" [sound/soc/amd/snd-soc-acp-pcm.ko] undefined! 64-bit divides require special operations to avoid build errors on 32-bit systems. fixes: 61add8147942 (ASoC: amd: Report accurate hw_ptr during dma) Signed-off-by: Guenter Roeck <groeck(a)chromium.org> Reviewed-on: https://chromium-review.googlesource.com/678919 Reviewed-by: Jason Clinton <jclinton(a)chromium.org> (cherry picked from commit 7ca726e80f21abdbaed9a5a70def1c33a26f8533) Reviewed-on: https://chromium-review.googlesource.com/681618 Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> --- v2: resend with the Chromium tags removed and the subject updated. sound/soc/amd/acp-pcm-dma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c index 13d040a4d26f..ef7e98ad960c 100644 --- a/sound/soc/amd/acp-pcm-dma.c +++ b/sound/soc/amd/acp-pcm-dma.c @@ -856,12 +856,11 @@ static snd_pcm_uframes_t acp_dma_pointer(struct snd_pcm_substream *substream) if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { if (bytescount > rtd->renderbytescount) bytescount = bytescount - rtd->renderbytescount; - pos = bytescount % buffersize; } else { if (bytescount > rtd->capturebytescount) bytescount = bytescount - rtd->capturebytescount; - pos = bytescount % buffersize; } + pos = do_div(bytescount, buffersize); return bytes_to_frames(runtime, pos); } -- 2.13.6

3 4

[alsa-devel] [PATCH 1/2] ASoC: Intel: improve DMADEVICES dependency
by Arnd Bergmann 08 Nov '17

08 Nov '17

As pointed out by Pierre-Louis Bossart, the depndency I added was broader than necessary, only Baytrail and Haswell/Broadwell actually need it, the others don't. At the same time, we have individual entries for the codecs that all have the 'select' statement but now don't need it any more. Fixes: f7a88db6fffd ("ASoC: Intel: fix Kconfig dependencies") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- sound/soc/intel/Kconfig | 3 ++- sound/soc/intel/boards/Kconfig | 5 ----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig index e18118209b75..bb8be10b8437 100644 --- a/sound/soc/intel/Kconfig +++ b/sound/soc/intel/Kconfig @@ -32,19 +32,20 @@ config SND_SOC_ACPI_INTEL_MATCH config SND_SOC_INTEL_SST_TOPLEVEL tristate "Intel ASoC SST drivers" depends on X86 || COMPILE_TEST - depends on DMADEVICES select SND_SOC_INTEL_MACH select SND_SOC_INTEL_COMMON config SND_SOC_INTEL_HASWELL tristate "Intel ASoC SST driver for Haswell/Broadwell" depends on SND_SOC_INTEL_SST_TOPLEVEL && SND_DMA_SGBUF + depends on DMADEVICES select SND_SOC_INTEL_SST select SND_SOC_INTEL_SST_FIRMWARE config SND_SOC_INTEL_BAYTRAIL tristate "Intel ASoC SST driver for Baytrail (legacy)" depends on SND_SOC_INTEL_SST_TOPLEVEL + depends on DMADEVICES select SND_SOC_INTEL_SST select SND_SOC_INTEL_SST_FIRMWARE diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig index 449bc8baaa60..5063f15b4ca4 100644 --- a/sound/soc/intel/boards/Kconfig +++ b/sound/soc/intel/boards/Kconfig @@ -19,7 +19,6 @@ config SND_SOC_INTEL_HASWELL_MACH tristate "ASoC Audio DSP support for Intel Haswell Lynxpoint" depends on SND_SOC_INTEL_MACH depends on X86_INTEL_LPSS && I2C && I2C_DESIGNWARE_PLATFORM - depends on DMADEVICES depends on SND_SOC_INTEL_HASWELL select SND_SOC_RT5640 help @@ -32,7 +31,6 @@ config SND_SOC_INTEL_BDW_RT5677_MACH tristate "ASoC Audio driver for Intel Broadwell with RT5677 codec" depends on SND_SOC_INTEL_MACH depends on X86_INTEL_LPSS && GPIOLIB && I2C - depends on DMADEVICES depends on SND_SOC_INTEL_HASWELL select SND_SOC_RT5677 help @@ -43,7 +41,6 @@ config SND_SOC_INTEL_BROADWELL_MACH tristate "ASoC Audio DSP support for Intel Broadwell Wildcatpoint" depends on SND_SOC_INTEL_MACH depends on X86_INTEL_LPSS && I2C && I2C_DESIGNWARE_PLATFORM - depends on DMADEVICES depends on SND_SOC_INTEL_HASWELL select SND_SOC_RT286 help @@ -56,7 +53,6 @@ config SND_SOC_INTEL_BYT_MAX98090_MACH tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec" depends on SND_SOC_INTEL_MACH depends on X86_INTEL_LPSS && I2C - depends on DMADEVICES depends on SND_SST_IPC_ACPI = n depends on SND_SOC_INTEL_BAYTRAIL select SND_SOC_MAX98090 @@ -68,7 +64,6 @@ config SND_SOC_INTEL_BYT_RT5640_MACH tristate "ASoC Audio driver for Intel Baytrail with RT5640 codec" depends on SND_SOC_INTEL_MACH depends on X86_INTEL_LPSS && I2C - depends on DMADEVICES depends on SND_SST_IPC_ACPI = n depends on SND_SOC_INTEL_BAYTRAIL select SND_SOC_RT5640 -- 2.9.0

4 8

Re: [alsa-devel] [PATCH 3/3] FIXUP: FROMLIST: ASoC: amd: Report accurate hw_ptr during dma
by Alex Deucher 08 Nov '17

08 Nov '17

On Wed, Nov 8, 2017 at 12:29 PM, Guenter Roeck <groeck(a)google.com> wrote: > On Wed, Nov 8, 2017 at 9:24 AM, Alex Deucher <alexdeucher(a)gmail.com> wrote: >> >> From: Guenter Roeck <groeck(a)chromium.org> >> >> ERROR: "__aeabi_uldivmod" [sound/soc/amd/snd-soc-acp-pcm.ko] undefined! >> >> 64-bit divides require special operations to avoid build errors on 32-bit >> systems. >> >> BUG=b:63121716 >> TEST="Build i386:allmodconfig" >> > > Is this an upstream submission ? Fine with me, but it should not include any > chromium specific tags, neither in the subject not in the description. I'm not familiar with which are chromium specific (TEST, BUG, FIXUP, FROMLIST I guess?). The info seems useful to have in the bug, but I can respin if it's a big deal. Alex > > Guenter > >> >> Signed-off-by: Guenter Roeck <groeck(a)chromium.org> >> Reviewed-on: https://chromium-review.googlesource.com/678919 >> Reviewed-by: Jason Clinton <jclinton(a)chromium.org> >> (cherry picked from commit 7ca726e80f21abdbaed9a5a70def1c33a26f8533) >> Reviewed-on: https://chromium-review.googlesource.com/681618 >> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> >> --- >> sound/soc/amd/acp-pcm-dma.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c >> index 13d040a4d26f..ef7e98ad960c 100644 >> --- a/sound/soc/amd/acp-pcm-dma.c >> +++ b/sound/soc/amd/acp-pcm-dma.c >> @@ -856,12 +856,11 @@ static snd_pcm_uframes_t acp_dma_pointer(struct >> snd_pcm_substream *substream) >> if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { >> if (bytescount > rtd->renderbytescount) >> bytescount = bytescount - rtd->renderbytescount; >> - pos = bytescount % buffersize; >> } else { >> if (bytescount > rtd->capturebytescount) >> bytescount = bytescount - rtd->capturebytescount; >> - pos = bytescount % buffersize; >> } >> + pos = do_div(bytescount, buffersize); >> return bytes_to_frames(runtime, pos); >> } >> >> -- >> 2.13.6 >> >

2 2