November 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/3] ALSA-S3 SonicVibes: Fine-tuning for five function implementations
by SF Markus Elfring 18 Nov '17

18 Nov '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Sat, 18 Nov 2017 16:25:43 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (3): Adjust 15 function calls together with a variable assignment Use common error handling code in snd_sonic_probe() Use common error handling code in snd_sonicvibes_create() sound/pci/sonicvibes.c | 144 +++++++++++++++++++++++++++---------------------- 1 file changed, 79 insertions(+), 65 deletions(-) -- 2.15.0

1 3

[alsa-devel] [PATCH 0/2] ALSA-RME Digi96: Fine-tuning for four function implementations
by SF Markus Elfring 18 Nov '17

18 Nov '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Sat, 18 Nov 2017 13:45:43 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Adjust 11 function calls together with a variable assignment Improve unlocking of an IRQ in snd_rme96_capture_hw_params() sound/pci/rme96.c | 91 +++++++++++++++++++++++++++++++------------------------ 1 file changed, 51 insertions(+), 40 deletions(-) -- 2.15.0

1 2

[alsa-devel] [PATCH 1/3 v3] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking
by Arvind Yadav 18 Nov '17

18 Nov '17

The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav <arvind.yadav.cs(a)gmail.com> --- changes in v2 : irq was unsigned. so changed it to signed. changes in v3 : Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. sound/soc/cirrus/ep93xx-ac97.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/cirrus/ep93xx-ac97.c b/sound/soc/cirrus/ep93xx-ac97.c index bbf7a92..b86b83b 100644 --- a/sound/soc/cirrus/ep93xx-ac97.c +++ b/sound/soc/cirrus/ep93xx-ac97.c @@ -365,7 +365,7 @@ static int ep93xx_ac97_probe(struct platform_device *pdev) { struct ep93xx_ac97_info *info; struct resource *res; - unsigned int irq; + int irq; int ret; info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); @@ -378,8 +378,8 @@ static int ep93xx_ac97_probe(struct platform_device *pdev) return PTR_ERR(info->regs); irq = platform_get_irq(pdev, 0); - if (!irq) - return -ENODEV; + if (irq <= 0) + return irq; ret = devm_request_irq(&pdev->dev, irq, ep93xx_ac97_interrupt, IRQF_TRIGGER_HIGH, pdev->name, info); -- 2.7.4

1 4

[alsa-devel] [PATCH 1/5 v2] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking
by Arvind Yadav 18 Nov '17

18 Nov '17

The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav <arvind.yadav.cs(a)gmail.com> --- changes in v2 : irq was unsigned. so changed it to signed. sound/soc/cirrus/ep93xx-ac97.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/cirrus/ep93xx-ac97.c b/sound/soc/cirrus/ep93xx-ac97.c index bbf7a92..b86b83b 100644 --- a/sound/soc/cirrus/ep93xx-ac97.c +++ b/sound/soc/cirrus/ep93xx-ac97.c @@ -365,7 +365,7 @@ static int ep93xx_ac97_probe(struct platform_device *pdev) { struct ep93xx_ac97_info *info; struct resource *res; - unsigned int irq; + int irq; int ret; info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); @@ -378,8 +378,8 @@ static int ep93xx_ac97_probe(struct platform_device *pdev) return PTR_ERR(info->regs); irq = platform_get_irq(pdev, 0); - if (!irq) - return -ENODEV; + if (irq < 0) + return irq; ret = devm_request_irq(&pdev->dev, irq, ep93xx_ac97_interrupt, IRQF_TRIGGER_HIGH, pdev->name, info); -- 2.7.4

2 5

[alsa-devel] [PATCH 0/3] ALSA-RME Digi32: Fine-tuning for seven function implementations
by SF Markus Elfring 17 Nov '17

17 Nov '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Fri, 17 Nov 2017 22:08:44 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (3): Adjust 15 function calls together with a variable assignment Use common error handling code in snd_rme32_probe() Improve unlocking of an IRQ in two functions sound/pci/rme32.c | 127 +++++++++++++++++++++++++++++++----------------------- 1 file changed, 74 insertions(+), 53 deletions(-) -- 2.15.0

1 3

Re: [alsa-devel] BUG: unable to handle kernel paging request in snd_seq_oss_readq_puts
by Dmitry Vyukov 17 Nov '17

17 Nov '17

On Fri, Nov 17, 2017 at 9:10 PM, syzbot <bot+31681772ec7a18dde8d3f8caf475f361a89b9514(a)syzkaller.appspotmail.com> wrote: > Hello, > > syzbot has tested the proposed patch but the reproducer still triggered > crash: > no output from test machine please ignore this, this testing of patch testing

1 0

[alsa-devel] Missing surround channels with Nvidia HDMI & snd-hda-intel driver
by VDR User 17 Nov '17

17 Nov '17

Hi. I just noticed that I'm missing some surround channels and I think it may be a bug in the alsa drivers because my current setup used to work just fine. I'm running Debian Testing, stable kernel 4.13.12, alsa-utils 1.1.3-1. My ~/.asoundrc is: ~$ cat .asoundrc pcm.!default "hdmi:NVidia,1" ~$ I am not setting anything on my kernel load line: echo 'Loading Linux 4.13.12-amd ...' linux /vmlinuz-4.13.12-amd root=UUID=6df5733d-b089-450c-9ec6-661dd013c7c0 ro echo 'Loading initial ramdisk ...' initrd /initrd.img-4.13.12-amd The driver being used is snd-hda-intel with an Nvidia GT520 video card. And lastly I do not have Pulse or a desktop environment. This is a minimal HTPC setup that runs only an xserver to provide video output, with audio/video being sent to my surround receiver via HDMI. The first thing I noticed was mpv-player was downmixing 5.1 to 3.1 and giving the following log message: [ao/alsa] trying to set ALSA channel map: FL FR FC LFE RL RR [ao/alsa] channel map reported by ALSA: FL FR FC LFE UNKNOWN UNKNOWN [ao/alsa] which we understand as: fl-fr-fc-lfe-na-na [ao/alsa] using the ALSA channel map. [ao/alsa] hw pausing supported: yes [ao/alsa] buffersize: 2720 samples [ao/alsa] period size: 160 samples [ao/alsa] device buffer: 2720 samples. [ao/alsa] using soft-buffer of 8820 samples. [cplayer] AO: [alsa] 44100Hz fl-fr-fc-lfe-na-na (3.1) 6ch s32 [cplayer] AO: Description: ALSA audio output [af] Adding filter lavrresample [lavrresample] Remix: 5.1 -> 3.1 [af] Audio filter chain: [af] [in] 44100Hz 5.1 6ch floatp [af] [lavrresample] 44100Hz fl-fr-fc-lfe-na-na (3.1) 6ch s32 [a] [af] [out] 44100Hz fl-fr-fc-lfe-na-na (3.1) 6ch s32 [af] [ao] 44100Hz fl-fr-fc-lfe-na-na (3.1) 6ch s32 That makes it look like Rear Left/Right channels are absent. I think ran speaker-test. 4 and 5 show as "Unknown" but correctly audibly announced as "front center" and "subwoofer" respectively: ~$ speaker-test -c 6 -t wav speaker-test 1.1.3 Playback device is default Stream parameters are 48000Hz, S16_LE, 6 channels WAV file(s) Rate set to 48000Hz (requested 48000Hz) Buffer size range from 64 to 5440 Period size range from 32 to 2720 Using max buffer size 5440 Periods = 4 was set period_size = 1088 was set buffer_size = 5440 0 - Front Left 1 - Front Right 3 - Rear Right 2 - Rear Left 4 - Unknown 5 - Unknown Additional information that may be of use: ~$ aplay -l **** List of PLAYBACK Hardware Devices **** card 1: NVidia [HDA NVidia], device 3: HDMI 0 [HDMI 0] Subdevices: 1/1 Subdevice #0: subdevice #0 card 1: NVidia [HDA NVidia], device 7: HDMI 1 [HDMI 1] Subdevices: 0/1 Subdevice #0: subdevice #0 ~$ cat /proc/asound/card1/eld#0.1 monitor_present 1 eld_valid 1 monitor_name SONY AVAMP connection_type HDMI eld_version [0x2] CEA-861D or below edid_version [0x3] CEA-861-B, C or D manufacture_id 0xd94d product_id 0xf02 port_id 0x200 support_hdcp 0 support_ai 0 audio_sync_delay 0 speakers [0x5f] FL/FR LFE FC RL/RR RC RLC/RRC sad_count 12 sad0_coding_type [0xc] MLP (Dolby TrueHD) sad0_channels 2 sad0_rates [0x1ec0] 44100 48000 88200 96000 176400 192000 sad1_coding_type [0xc] MLP (Dolby TrueHD) sad1_channels 6 sad1_rates [0x1ec0] 44100 48000 88200 96000 176400 192000 sad2_coding_type [0xc] MLP (Dolby TrueHD) sad2_channels 8 sad2_rates [0x6c0] 44100 48000 88200 96000 sad3_coding_type [0xb] DTS-HD sad3_channels 2 sad3_rates [0x1ec0] 44100 48000 88200 96000 176400 192000 sad4_coding_type [0xb] DTS-HD sad4_channels 6 sad4_rates [0x1ec0] 44100 48000 88200 96000 176400 192000 sad5_coding_type [0xb] DTS-HD sad5_channels 8 sad5_rates [0x6c0] 44100 48000 88200 96000 sad6_coding_type [0x1] LPCM sad6_channels 2 sad6_rates [0x1ee0] 32000 44100 48000 88200 96000 176400 192000 sad6_bits [0xe0000] 16 20 24 sad7_coding_type [0x1] LPCM sad7_channels 6 sad7_rates [0x1ee0] 32000 44100 48000 88200 96000 176400 192000 sad7_bits [0xe0000] 16 20 24 sad8_coding_type [0x1] LPCM sad8_channels 8 sad8_rates [0x1ee0] 32000 44100 48000 88200 96000 176400 192000 sad8_bits [0xe0000] 16 20 24 sad9_coding_type [0x2] AC-3 sad9_channels 6 sad9_rates [0xe0] 32000 44100 48000 sad9_max_bitrate 680000 sad10_coding_type [0x7] DTS sad10_channels 6 sad10_rates [0x6e0] 32000 44100 48000 88200 96000 sad10_max_bitrate 1536000 sad11_coding_type [0xa] E-AC-3/DD+ (Dolby Digital Plus) sad11_channels 8 sad11_rates [0xc0] 44100 48000 02:00.0 VGA compatible controller: NVIDIA Corporation GF119 [GeForce GT 520] (rev a1) (prog-if 00 [VGA controller]) Subsystem: eVga.com. Corp. GF119 [GeForce GT 520] Flags: bus master, fast devsel, latency 0, IRQ 25 Memory at fd000000 (32-bit, non-prefetchable) [size=16M] Memory at f0000000 (64-bit, prefetchable) [size=128M] Memory at fa000000 (64-bit, prefetchable) [size=32M] I/O ports at ec00 [size=128] [virtual] Expansion ROM at 000c0000 [disabled] [size=128K] Capabilities: <access denied> Kernel driver in use: nvidia Kernel modules: nvidia 02:00.1 Audio device: NVIDIA Corporation GF119 HDMI Audio Controller (rev a1) Subsystem: eVga.com. Corp. GF119 HDMI Audio Controller Flags: bus master, fast devsel, latency 0, IRQ 17 Memory at fea7c000 (32-bit, non-prefetchable) [size=16K] Capabilities: <access denied> Kernel driver in use: snd_hda_intel Kernel modules: snd_hda_intel

2 14

Re: [alsa-devel] [GIT PULL] sound updates for 4.15-rc1
by Takashi Iwai 17 Nov '17

17 Nov '17

[Adding more people and alsa-devel to Cc] On Wed, 15 Nov 2017 03:40:09 +0100, Linus Torvalds wrote: > > On Tue, Nov 14, 2017 at 6:51 AM, Takashi Iwai <tiwai(a)suse.de> wrote: > > > > please pull sound updates for v4.15-rc1 from: > > Hmm. Making "oldconfig" on my laptop with this, my > SND_SOC_INTEL_SKYLAKE went away. > > And the reason seems to be that new SND_SOC_INTEL_SST_TOPLEVEL config option. > > Which has no help associated with it. > > This is not a friendly thing to do to people. It basically breaks > existing setups for no documented reason, and with no explanation. > > Please fix the config situation. At the very least, add documentation. Sorry about that. I saw Vinod already submitted a patch to add the help text to CONFIG_SND_SOC_INTEL_SST_TOPLEVEL, so the least fix should go in soon. But now looking at these changes, I noticed a few things, too: - With the introduction of SND_SOC_INTEL_SST_TOPLEVEL, keeping SND_SOC_INTEL_COMMON and SND_SOC_INTEL_MACH individually doesn't make much sense. They can be dropped and replaced with SND_SOC_INTEL_SST_TOPLEVEL as a further cleanup. - ... or, make SND_SOC_INTEL_SST_TOPLEVEL=y as default, if this is considered to be a top-level filter config (like the network vendor kconfig items). In that case, the reverse-selection of SND_SOC_INTEL_COMMON and SND_SOC_INTEL_MACH should be avoided, but they should be selected from the actual drivers instead. And I believe there are a few more possible cleanups / fixes in the messy Intel ASoC Kconfigs. For example, SND_SOC_INTEL_SST is almost always set. The only exception is via SND_SST_ATOM_HIFI2_PLATFORM. But all machine drivers using Atom Hifi2 do set SND_SST_IPC_ACPI, which also requires SND_SOC_INTEL_SST. Further looking at this, we see that the only entry that does *not* require SND_SOC_INTEL_SST is the case with SND_MFLD_MACHINE in sound/soc/intel/boards. And now more interesting part -- there is no corresponding entry in Makefile. That is, this kconfig is effectively dead! The source code mfld_machine.c exists, but it's just a place holder now. The code was supposed to be integrated into atom directory by the commit b97169da0699, but it seems forgotten to be updated. Hmm... Takashi

4 13

Re: [alsa-devel] [PATCH] ASoC: Intel: mfld: allow mfld machine to be build
by Vinod Koul 17 Nov '17

17 Nov '17

On Wed, Nov 15, 2017 at 08:41:18AM -0600, Pierre-Louis Bossart wrote: > On 11/15/17 4:52 AM, Vinod Koul wrote: > >Commit b97169da0699: ("ASoC: Intel: create atom folder and move atom > >platform files in") missed adding Kconfig and Makefile support for > >MFLD machine driver, so add it while alos fixing the relative patch to > >codec header > > Does anyone test this code? I don't think anyone on the Intel side has a > working platform any longer... That is good question, we had boards for these but not sure if this is needed. This was not compiling and noone noticed, so I dont mind removing these bits. Any objections.. -- ~Vinod

3 2

[alsa-devel] [PATCH] ALSA: synth: emux: remove redundant test for r <= 13
by Colin King 17 Nov '17

17 Nov '17

From: Colin Ian King <colin.king(a)canonical.com> The calculation r = (3 - ((rate >> 6) & 3)) * 3 results in r being 0, 3, 6 or 9 and so the check (13 > r) is always true and hence we can remove the redundant check and the else path. Detected by CoverityScan, CID#744415 ("Logically dead code") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/synth/emux/soundfont.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sound/synth/emux/soundfont.c b/sound/synth/emux/soundfont.c index 31a4ea94830e..0beb5a737c8b 100644 --- a/sound/synth/emux/soundfont.c +++ b/sound/synth/emux/soundfont.c @@ -858,10 +858,7 @@ calc_gus_envelope_time(int rate, int start, int end) p = rate & 0x3f; t = end - start; if (t < 0) t = -t; - if (13 > r) - t = t << (13 - r); - else - t = t >> (r - 13); + t = t << (13 - r); return (t * 10) / (p * 441); } -- 2.14.1

4 3