November 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: nau8825: disable crosstalk by default
by John Hsu 23 Nov '17

23 Nov '17

The driver makes the crosstalk funciton disabled by default which can simplify the codec function. The platform may not need this funciton and reduce the potential risk. Therefore, We change the property "nuvoton,crosstalk-bypass" to "nuvoton,crosstalk-enable". The crosstalk measurement is enabled if the property is set. Otherwise, it is disabled. Besides, add more condition in the entry point of the crosstalk sequence to disable the function completely. Signed-off-by: John Hsu <KCHSU0(a)nuvoton.com> --- Documentation/devicetree/bindings/sound/nau8825.txt | 4 ++-- sound/soc/codecs/nau8825.c | 21 +++++++++++++-------- sound/soc/codecs/nau8825.h | 2 +- 3 files changed, 16 insertions(+), 11 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/nau8825.txt b/Documentation/devicetree/bindings/sound/nau8825.txt index 2f5e973..d16d968 100644 --- a/Documentation/devicetree/bindings/sound/nau8825.txt +++ b/Documentation/devicetree/bindings/sound/nau8825.txt @@ -69,7 +69,7 @@ Optional properties: - nuvoton,jack-insert-debounce: number from 0 to 7 that sets debounce time to 2^(n+2) ms - nuvoton,jack-eject-debounce: number from 0 to 7 that sets debounce time to 2^(n+2) ms - - nuvoton,crosstalk-bypass: make crosstalk function bypass if set. + - nuvoton,crosstalk-enable: make crosstalk function enable if set. - clocks: list of phandle and clock specifier pairs according to common clock bindings for the clocks described in clock-names @@ -98,7 +98,7 @@ Example: nuvoton,short-key-debounce = <2>; nuvoton,jack-insert-debounce = <7>; nuvoton,jack-eject-debounce = <7>; - nuvoton,crosstalk-bypass; + nuvoton,crosstalk-enable; clock-names = "mclk"; clocks = <&tegra_car TEGRA210_CLK_CLK_OUT_2>; diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c index 714ce17..2d6c536 100644 --- a/sound/soc/codecs/nau8825.c +++ b/sound/soc/codecs/nau8825.c @@ -792,6 +792,10 @@ static void nau8825_xtalk_work(struct work_struct *work) struct nau8825 *nau8825 = container_of( work, struct nau8825, xtalk_work); + /* block when crosstalk disabled */ + if (!nau8825->xtalk_enable) + return; + nau8825_xtalk_measure(nau8825); /* To determine the cross talk side tone gain when reach * the impedance measure state. @@ -815,11 +819,12 @@ static void nau8825_xtalk_work(struct work_struct *work) static void nau8825_xtalk_cancel(struct nau8825 *nau8825) { - /* If the xtalk_protect is true, that means the process is still - * on going. The driver forces to cancel the cross talk task and + /* If the crosstalk is eanbled and the process is on going, + * the driver forces to cancel the cross talk task and * restores the configuration to original status. */ - if (nau8825->xtalk_protect) { + if (nau8825->xtalk_enable && nau8825->xtalk_protect && + nau8825->xtalk_state != NAU8825_XTALK_DONE) { cancel_work_sync(&nau8825->xtalk_work); nau8825_xtalk_clean(nau8825); } @@ -1686,7 +1691,7 @@ static irqreturn_t nau8825_interrupt(int irq, void *data) } else if (active_irq & NAU8825_HEADSET_COMPLETION_IRQ) { if (nau8825_is_jack_inserted(regmap)) { event |= nau8825_jack_insert(nau8825); - if (!nau8825->xtalk_bypass && !nau8825->high_imped) { + if (nau8825->xtalk_enable && !nau8825->high_imped) { /* Apply the cross talk suppression in the * headset without high impedance. */ @@ -2440,8 +2445,8 @@ static void nau8825_print_device_properties(struct nau8825 *nau8825) nau8825->jack_insert_debounce); dev_dbg(dev, "jack-eject-debounce: %d\n", nau8825->jack_eject_debounce); - dev_dbg(dev, "crosstalk-bypass: %d\n", - nau8825->xtalk_bypass); + dev_dbg(dev, "crosstalk-enable: %d\n", + nau8825->xtalk_enable); } static int nau8825_read_device_properties(struct device *dev, @@ -2506,8 +2511,8 @@ static int nau8825_read_device_properties(struct device *dev, &nau8825->jack_eject_debounce); if (ret) nau8825->jack_eject_debounce = 0; - nau8825->xtalk_bypass = device_property_read_bool(dev, - "nuvoton,crosstalk-bypass"); + nau8825->xtalk_enable = device_property_read_bool(dev, + "nuvoton,crosstalk-enable"); nau8825->mclk = devm_clk_get(dev, "mclk"); if (PTR_ERR(nau8825->mclk) == -EPROBE_DEFER) { diff --git a/sound/soc/codecs/nau8825.h b/sound/soc/codecs/nau8825.h index 8aee5c86..199d6ea 100644 --- a/sound/soc/codecs/nau8825.h +++ b/sound/soc/codecs/nau8825.h @@ -476,7 +476,7 @@ struct nau8825 { int xtalk_event_mask; bool xtalk_protect; int imp_rms[NAU8825_XTALK_IMM]; - int xtalk_bypass; + int xtalk_enable; }; int nau8825_enable_jack_detect(struct snd_soc_codec *codec, -- 2.6.4

2 4

[alsa-devel] [PATCH] ALSA: hda: Add Raven PCI ID
by Vijendar Mukunda 23 Nov '17

23 Nov '17

This commit adds PCI ID for Raven platform v2: Comment added for Raven Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> --- sound/pci/hda/hda_intel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 01eb1dc..44babe5 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2454,6 +2454,9 @@ static const struct pci_device_id azx_ids[] = { /* AMD Hudson */ { PCI_DEVICE(0x1022, 0x780d), .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_ATI_SB }, + /* AMD Raven */ + { PCI_DEVICE(0x1022, 0x15e3), + .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_ATI_SB }, /* ATI HDMI */ { PCI_DEVICE(0x1002, 0x0002), .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, -- 2.7.4

2 1

Re: [alsa-devel] AMD Raven Platform
by Kailang 23 Nov '17

23 Nov '17

Hi Takashi, Attach patch for fix AMD no sound issue. It also could solve Intel ALC700 no sound issue. Thanks. BR, Kailang > -----Original Message----- > From: Takashi Iwai [mailto:tiwai@suse.de] > Sent: Tuesday, November 21, 2017 2:40 PM > To: Kailang > Subject: Re: AMD Raven Platform > > On Tue, 21 Nov 2017 04:13:16 +0100, > Kailang wrote: > > > > Hi Takashi, > > > > AMD guys add below patch. To support their new HDA controller. > > But it still no sound. > > This platform codec is ALC701. > > But ALC701 was worked with Intel platform on Intel site. > > My test platform was ICH7. ALC701 and ICH7 was also worked > on my site. > > > > I check alsa-info dump as attach file. It's very well. > > > > The patch that AMD guys assigned ATI_SB flag. > > I think no sound issue maybe the HDA controller setting relation. > > > > Could you can find any difference? > > First off, if the main target is the onboard analog I/O, I'd > pass index=1,0 option to snd-hda-intel module to swap the > HDMI/DP and the analog I/O. This will allow testing with the > native ALSA API more easily. > > Did you pass need some COEF setups as we applied for Intel > reference board? There is even another patch that isn't > still included to upstream (the difference is COEF 0x4a with > bit 0x2000). > > In the controller side, one thing that comes to my mind about > AMD is the PCI snooping. Try AZX_DCAPS_PRESET_ATI_HDMI_NS > instead as a test. > The essential difference with this preset is > AZX_DCAPS_SNOOP_OFF bits. Other than that, the recent Intel > chip requires the different slot assignment, and > AZX_DCAPS_SEPARATE_STREAM_TAG is used. But this is set > automatically also when the number of streams is greater than > 15, too. (You'll see a warning.) > > Feel free to put me to Cc in the communication with AMD > people directly. > > > thanks, > > Takashi > > > > > Many Thanks. > > Kailang > > --- a/sound/pci/hda/hda_intel.c > > +++ b/sound/pci/hda/hda_intel.c > > @@ -2454,6 +2454,8 @@ static const struct pci_device_id > azx_ids[] = { > > /* AMD Hudson */ > > { PCI_DEVICE(0x1022, 0x780d), > > .driver_data = AZX_DRIVER_GENERIC | > AZX_DCAPS_PRESET_ATI_SB > > }, > > + { PCI_DEVICE(0x1022, 0x15e3), > > + .driver_data = AZX_DRIVER_GENERIC | > AZX_DCAPS_PRESET_ATI_SB > > + }, > > /* ATI HDMI */ > > { PCI_DEVICE(0x1002, 0x0002), > > .driver_data = AZX_DRIVER_ATIHDMI_NS | > > AZX_DCAPS_PRESET_ATI_HDMI_NS }, > > ------Please consider the environment before printing this e-mail. >

2 1

[alsa-devel] [PATCH] ALSA: hda: Add Raven PCI ID
by Vijendar Mukunda 23 Nov '17

23 Nov '17

This commit adds PCI ID for Raven platform Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> --- sound/pci/hda/hda_intel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 01eb1dc..9c7d479 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2454,6 +2454,8 @@ static const struct pci_device_id azx_ids[] = { /* AMD Hudson */ { PCI_DEVICE(0x1022, 0x780d), .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_ATI_SB }, + { PCI_DEVICE(0x1022, 0x15e3), + .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_ATI_SB }, /* ATI HDMI */ { PCI_DEVICE(0x1002, 0x0002), .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, -- 2.7.4

2 1

[alsa-devel] [PATCH 0/7] mark expected switch fall-throughs
by Gustavo A. R. Silva 23 Nov '17

23 Nov '17

In preparation to enabling -Wimplicit-fallthrough, this patchset aims to mark switch cases where we are expecting to fall through. Thanks! Gustavo A. R. Silva (7): ASoC: msm8916-wcd-analog: mark expected switch fall-through ASoC: tlv320aic23: mark expected switch fall-through ASoC: tlv320dac31xx: mark expected switch fall-through ASoC: tpa6130a2: mark expected switch fall-through ASoC: wm8753: mark expected switch fall-throughs ASoC: wm8993: mark expected switch fall-throughs ASoC: wm8994: mark expected switch fall-throughs sound/soc/codecs/msm8916-wcd-analog.c | 1 + sound/soc/codecs/tlv320aic23.c | 1 + sound/soc/codecs/tlv320aic31xx.c | 2 +- sound/soc/codecs/tpa6130a2.c | 1 + sound/soc/codecs/wm8753.c | 4 ++-- sound/soc/codecs/wm8993.c | 2 ++ sound/soc/codecs/wm8994.c | 2 ++ 7 files changed, 10 insertions(+), 3 deletions(-) -- 2.7.4

3 15

[alsa-devel] [GIT PULL]: Geminilake audio firmware update
by Vinod Koul 23 Nov '17

23 Nov '17

Hi, Please PULL to receive update for GLK audio firmware. The following changes since commit bf04291309d3169c0ad3b8db52564235bbd08e30: WHENCE: Add new qed firmware (2017-10-09 18:03:26 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/firmware.git glk for you to fetch changes up to b964279f2d9955a6ce00d3a672b273ae4d7a362f: linux-firmware: intel: Update Geminilake audio firmware (2017-11-07 10:25:50 +0530) ---------------------------------------------------------------- Pradeep Tewani (1): linux-firmware: intel: Update Geminilake audio firmware WHENCE | 4 +++- intel/dsp_fw_glk.bin | 2 +- intel/dsp_fw_glk_v2880.bin | Bin 0 -> 505608 bytes 3 files changed, 4 insertions(+), 2 deletions(-) create mode 100644 intel/dsp_fw_glk_v2880.bin Thanks -- ~Vinod

2 1

[alsa-devel] [v5 RESEND 00/17] Add support for Cirrus Logic CS47L35/L85/L90/L91 codecs
by Richard Fitzgerald 22 Nov '17

22 Nov '17

Patches still waiting for review/ack: #8 regulator #9 irqchip #14-17 ASoC Summary of changes since V4: - Fixed review comments on MFD code - Fixed dependency error in core codec driver - minor bugfix to core codec driver Richard Fitzgerald (17): mfd: madera: Add register definitions for Cirrus Logic Madera codecs mfd: madera: Add DT bindings for Cirrus Logic Madera codecs mfd: madera: Add common support for Cirrus Logic Madera codecs mfd: madera: Register map tables for Cirrus Logic CS47L35 mfd: madera: Register map tables for Cirrus Logic CS47L85 mfd: madera: Register map tables for Cirrus Logic CS47L90/91 regulator: arizona-micsupp: Add support for Cirrus Logic Madera codecs regulator: arizona-ldo1: Add support for Cirrus Logic Madera codecs irqchip: Add driver for Cirrus Logic Madera codecs pinctrl: madera: Add DT bindings for Cirrus Logic Madera codecs pinctrl: madera: Add driver for Cirrus Logic Madera codecs gpio: madera: Support Cirrus Logic Madera class codecs ASoC: madera: Add DT bindings for Cirrus Logic Madera codecs ASoC: madera: Add common support for Cirrus Logic Madera codecs ASoC: cs47l35: Add codec driver for Cirrus Logic CS47L35 ASoC: cs47l85: Add codec driver for Cirrus Logic CS47L85 ASoC: cs47l90: Add codec driver for Cirrus Logic CS47L90 Documentation/devicetree/bindings/mfd/madera.txt | 102 + .../bindings/pinctrl/cirrus,madera-pinctrl.txt | 99 + .../bindings/regulator/arizona-regulator.txt | 3 +- Documentation/devicetree/bindings/sound/madera.txt | 67 + MAINTAINERS | 23 + drivers/gpio/Kconfig | 6 + drivers/gpio/Makefile | 1 + drivers/gpio/gpio-madera.c | 196 + drivers/irqchip/Kconfig | 3 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-madera.c | 301 ++ drivers/mfd/Kconfig | 48 + drivers/mfd/Makefile | 13 + drivers/mfd/cs47l35-tables.c | 1610 +++++++ drivers/mfd/cs47l85-tables.c | 3010 +++++++++++++ drivers/mfd/cs47l90-tables.c | 2675 ++++++++++++ drivers/mfd/madera-core.c | 599 +++ drivers/mfd/madera-i2c.c | 139 + drivers/mfd/madera-spi.c | 138 + drivers/mfd/madera.h | 44 + drivers/pinctrl/Kconfig | 1 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/cirrus/Kconfig | 15 + drivers/pinctrl/cirrus/Makefile | 11 + drivers/pinctrl/cirrus/pinctrl-cs47l35.c | 46 + drivers/pinctrl/cirrus/pinctrl-cs47l85.c | 60 + drivers/pinctrl/cirrus/pinctrl-cs47l90.c | 58 + drivers/pinctrl/cirrus/pinctrl-madera.c | 1074 +++++ drivers/pinctrl/cirrus/pinctrl-madera.h | 40 + drivers/regulator/Kconfig | 15 +- drivers/regulator/arizona-ldo1.c | 82 +- drivers/regulator/arizona-micsupp.c | 71 +- include/dt-bindings/sound/madera.h | 27 + include/linux/irqchip/irq-madera-pdata.h | 23 + include/linux/irqchip/irq-madera.h | 98 + include/linux/mfd/madera/core.h | 196 + include/linux/mfd/madera/pdata.h | 61 + include/linux/mfd/madera/registers.h | 3987 ++++++++++++++++++ include/sound/madera-pdata.h | 61 + sound/soc/codecs/Kconfig | 23 + sound/soc/codecs/Makefile | 8 + sound/soc/codecs/cs47l35.c | 1748 ++++++++ sound/soc/codecs/cs47l85.c | 2722 ++++++++++++ sound/soc/codecs/cs47l90.c | 2661 ++++++++++++ sound/soc/codecs/madera.c | 4439 ++++++++++++++++++++ sound/soc/codecs/madera.h | 470 +++ 46 files changed, 27066 insertions(+), 10 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/madera.txt create mode 100644 Documentation/devicetree/bindings/pinctrl/cirrus,madera-pinctrl.txt create mode 100644 Documentation/devicetree/bindings/sound/madera.txt create mode 100644 drivers/gpio/gpio-madera.c create mode 100644 drivers/irqchip/irq-madera.c create mode 100644 drivers/mfd/cs47l35-tables.c create mode 100644 drivers/mfd/cs47l85-tables.c create mode 100644 drivers/mfd/cs47l90-tables.c create mode 100644 drivers/mfd/madera-core.c create mode 100644 drivers/mfd/madera-i2c.c create mode 100644 drivers/mfd/madera-spi.c create mode 100644 drivers/mfd/madera.h create mode 100644 drivers/pinctrl/cirrus/Kconfig create mode 100644 drivers/pinctrl/cirrus/Makefile create mode 100644 drivers/pinctrl/cirrus/pinctrl-cs47l35.c create mode 100644 drivers/pinctrl/cirrus/pinctrl-cs47l85.c create mode 100644 drivers/pinctrl/cirrus/pinctrl-cs47l90.c create mode 100644 drivers/pinctrl/cirrus/pinctrl-madera.c create mode 100644 drivers/pinctrl/cirrus/pinctrl-madera.h create mode 100644 include/dt-bindings/sound/madera.h create mode 100644 include/linux/irqchip/irq-madera-pdata.h create mode 100644 include/linux/irqchip/irq-madera.h create mode 100644 include/linux/mfd/madera/core.h create mode 100644 include/linux/mfd/madera/pdata.h create mode 100644 include/linux/mfd/madera/registers.h create mode 100644 include/sound/madera-pdata.h create mode 100644 sound/soc/codecs/cs47l35.c create mode 100644 sound/soc/codecs/cs47l85.c create mode 100644 sound/soc/codecs/cs47l90.c create mode 100644 sound/soc/codecs/madera.c create mode 100644 sound/soc/codecs/madera.h -- 2.11.0

4 21

[alsa-devel] [PATCH 2/2] ASoC: fsl_ssi: add 20-bit sample format for AC'97 and use it for capture
by Maciej S. Szmigiero 22 Nov '17

22 Nov '17

When testing AC'97 capture on UDOO board (currently the only user of fsl_ssi driver in the AC'97 mode) it become obvious that there is a massive distortion above certain, small input signal. This problem has been traced to silicon errata ERR003778: "In AC97, 16-bit mode, received data is shifted by 4-bit locations" that has "No fix scheduled". This errata suggests a workaround of doing a 4-bit shift back in SDMA script for this specific operation mode, however our SDMA scripts are shared between various SoC peripherals so we can't really modify them. There is a simple way to avoid this problem, however, that is to disallow recording in 16-bit mode and only support it in AC'97-native 20-bit mode. We have to use a 4-byte format for this since SSI FIFOs do not allow 3-byte accesses (and these aren't supported by imx-sdma driver anyway). With this change the capture distortion is gone. We can also add this format as an additional one supported for playback, using this opportunity to make sure that we use CPU-endian-native formats in AC'97 mode as we already do in I2S mode. There is no problem in using different bit widths in playback and capture in AC'97 mode so allow this, too. Signed-off-by: Maciej S. Szmigiero <mail(a)maciej.szmigiero.name> --- sound/soc/fsl/fsl_ssi.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 20ef09e1a395..2aed089fdd76 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -1278,14 +1278,15 @@ static struct snd_soc_dai_driver fsl_ssi_ac97_dai = { .channels_min = 2, .channels_max = 2, .rates = SNDRV_PCM_RATE_8000_48000, - .formats = SNDRV_PCM_FMTBIT_S16_LE, + .formats = SNDRV_PCM_FMTBIT_S16 | SNDRV_PCM_FMTBIT_S20_4, }, .capture = { .stream_name = "AC97 Capture", .channels_min = 2, .channels_max = 2, .rates = SNDRV_PCM_RATE_48000, - .formats = SNDRV_PCM_FMTBIT_S16_LE, + /* 16-bit capture is broken (errata ERR003778) */ + .formats = SNDRV_PCM_FMTBIT_S20_4, }, .ops = &fsl_ssi_dai_ops, }; @@ -1557,11 +1558,12 @@ static int fsl_ssi_probe(struct platform_device *pdev) /* Are the RX and the TX clocks locked? */ if (!of_find_property(np, "fsl,ssi-asynchronous", NULL)) { - if (!fsl_ssi_is_ac97(ssi_private)) + if (!fsl_ssi_is_ac97(ssi_private)) { ssi_private->cpu_dai_drv.symmetric_rates = 1; + ssi_private->cpu_dai_drv.symmetric_samplebits = 1; + } ssi_private->cpu_dai_drv.symmetric_channels = 1; - ssi_private->cpu_dai_drv.symmetric_samplebits = 1; } /* Determine the FIFO depth. */

1 0

[alsa-devel] Regression with a91d66129fb9 ("ALSA: hda - Fix incorrect TLV callback check introduced during set_fs() removal")
by Laura Abbott 22 Nov '17

22 Nov '17

Hi, Fedora got a bug report (https://bugzilla.redhat.com/show_bug.cgi?id=1512853) that Line Out stopped working between 4.13.9 and 4.13.10. Reverting 82d745a55779 ("ALSA: hda - Fix incorrect TLV callback check introduced during set_fs() removal") fixed the problem. I didn't ask the reporter to test on 4.14 since I didn't see anything explicitly tagged as fixing the issue. Any ideas? Thanks, Laura

2 3

[alsa-devel] [PATCH] Emit an error message when dlopen fails.
by Cedric Roux 22 Nov '17

22 Nov '17

Signed-off-by: Cedric Roux <sed(a)free.fr> --- src/dlmisc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git src/dlmisc.c src/dlmisc.c index f154ebd0..9e8e401e 100644 --- src/dlmisc.c +++ src/dlmisc.c @@ -81,10 +81,14 @@ void *snd_dlopen(const char *name, int mode) strcat(filename, "/"); strcat(filename, name); handle = dlopen(filename, mode); + if (!handle) + SNDERR("snd_dlopen: %s: %s", filename, dlerror()); free(filename); } if (!handle) handle = dlopen(name, mode); + if (!handle) + SNDERR("snd_dlopen: %s: %s", name, dlerror()); return handle; #else return NULL; -- 2.15.0

4 6