August 2016 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/9] ASoC: simple-card: tidyup and synchronize patches
by Kuninori Morimoto 25 Aug '16

25 Aug '16

Hi Mark These are cleanup/tidyup and synchronize patches for simple-card. We have now simple-card and simple-scu-card. These are almost same, difference is very small. But, because of historical reason, these have "code" difference. This patch cleanup and synchronize these. Kuninori Morimoto (9): ASoC: simple-card: call of_node_put() for dai_link ASoC: simple-card: tidyup mclk-fs of_property_read_u32() usage ASoC: simple-card: code sync: tidyup simple_priv_to_xxx() macro ASoC: simple-card: code sync: use simple_priv_to_props() macro ASoC: simple-card: is GPL v2 ASoC: simple-card: code sync: tidyup white line ASoC: simple-card: code sync: use tag ASoC: simple-card: code sync: rename num_link to num ASoC: simple-card: use kzalloc() for dai_props / dai_link sound/soc/generic/simple-card.c | 87 ++++++++++++++++++++--------------------- 1 file changed, 43 insertions(+), 44 deletions(-) -- 1.9.1

1 9

[alsa-devel] [PATCH] ASoC: nau8810: Fix memory leak in nau8810_eq_put error path
by Axel Lin 25 Aug '16

25 Aug '16

Signed-off-by: Axel Lin <axel.lin(a)ingics.com> --- sound/soc/codecs/nau8810.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/nau8810.c b/sound/soc/codecs/nau8810.c index f9bcdc3..e455186 100644 --- a/sound/soc/codecs/nau8810.c +++ b/sound/soc/codecs/nau8810.c @@ -221,6 +221,7 @@ static int nau8810_eq_put(struct snd_kcontrol *kcontrol, if (ret) { dev_err(codec->dev, "EQ configuration fail, register: %x ret: %d\n", reg + i, ret); + kfree(data); return ret; } } -- 2.7.4

1 0

[alsa-devel] [PATCH v2 1/2] ASoC: simple-card-utils: add __printf attribute
by Nicolas Iooss 25 Aug '16

25 Aug '16

asoc_simple_card_set_dailink_name() uses devm_kvasprintf() to format some of its arguments. Adding a __printf attribute to this function makes it possible to detect at compile-time errors related to format strings. Signed-off-by: Nicolas Iooss <nicolas.iooss_linux(a)m4x.org> --- include/sound/simple_card_utils.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h index 86088aed9002..3207b1a70d38 100644 --- a/include/sound/simple_card_utils.h +++ b/include/sound/simple_card_utils.h @@ -27,6 +27,7 @@ int asoc_simple_card_parse_daifmt(struct device *dev, struct device_node *codec, char *prefix, unsigned int *retfmt); +__printf(3, 4) int asoc_simple_card_set_dailink_name(struct device *dev, struct snd_soc_dai_link *dai_link, const char *fmt, ...); -- 2.9.3

2 2

[alsa-devel] [PATCH] ASoC: tegra_rt5640: Correct a copy and paste typo in the comments
by Nicolin Chen 25 Aug '16

25 Aug '16

This patch corrects a copy and paste typo. Signed-off-by: Nicolin Chen <nicoleotsuka(a)gmail.com> --- sound/soc/tegra/tegra_rt5640.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/tegra/tegra_rt5640.c b/sound/soc/tegra/tegra_rt5640.c index 773daec..e5ef4e9 100644 --- a/sound/soc/tegra/tegra_rt5640.c +++ b/sound/soc/tegra/tegra_rt5640.c @@ -1,5 +1,5 @@ /* -* tegra_rt5640.c - Tegra machine ASoC driver for boards using WM8903 codec. +* tegra_rt5640.c - Tegra machine ASoC driver for boards using RT5640 codec. * * Copyright (c) 2013, NVIDIA CORPORATION. All rights reserved. * -- 2.1.4

1 0

[alsa-devel] Spam in the wiki
by Tanu Kaskinen 24 Aug '16

24 Aug '16

I got a notification, because a wiki page that I had created was edited by a spammer. Looking at the recent changes, it seems that there's quite a lot of spam activity: http://www.alsa-project.org/main/index.php/Special:RecentChanges Can the wiki user registrations be restricted? There's already a captcha, but that doesn't seem very effective. -- Tanu

1 0

[alsa-devel] [PATCH] ASoC: rt5659: Enable IRQ output for GPIO1 pin
by Nicolin Chen 24 Aug '16

24 Aug '16

Since it's possible to have an IRQ without enabling JD3, the GPIO1 pin then would remain its default GPIO function which is set as an input direction (seeing from rt5659). Meanwhile, CPU would also listen this connection via its own GPIO input: [input] [input] CPU GPIO <--------> RT5659 GPIO1 The result for the IRQ on the CPU side will be unexpectable. So this patch enables the IRQ output for GPIO1 pin any way as long as there's an IRQ assigned from platform data or DT: [input] [IRQ output] CPU GPIO <--------< RT5659 GPIO1 Signed-off-by: Nicolin Chen <nicoleotsuka(a)gmail.com> --- sound/soc/codecs/rt5659.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/rt5659.c b/sound/soc/codecs/rt5659.c index 4c0d2b8..db54550 100644 --- a/sound/soc/codecs/rt5659.c +++ b/sound/soc/codecs/rt5659.c @@ -4189,6 +4189,9 @@ static int rt5659_i2c_probe(struct i2c_client *i2c, if (ret) dev_err(&i2c->dev, "Failed to reguest IRQ: %d\n", ret); + /* Enable IRQ output for GPIO1 pin any way */ + regmap_update_bits(rt5659->regmap, RT5659_GPIO_CTRL_1, + RT5659_GP1_PIN_MASK, RT5659_GP1_PIN_IRQ); } return snd_soc_register_codec(&i2c->dev, &soc_codec_dev_rt5659, -- 2.1.4

1 0

[alsa-devel] [PATCH 1/2] ASoC: simple-card-utils: add __printf attribute
by Nicolas Iooss 24 Aug '16

24 Aug '16

asoc_simple_card_set_dailink_name() uses devm_kvasprintf() to format some of its arguments. Adding a __printf attribute to this function makes it possible to detect at compile-time errors related to format strings. Signed-off-by: Nicolas Iooss <nicolas.iooss_linux(a)m4x.org> --- include/sound/simple_card_utils.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h index 86088aed9002..3207b1a70d38 100644 --- a/include/sound/simple_card_utils.h +++ b/include/sound/simple_card_utils.h @@ -27,6 +27,7 @@ int asoc_simple_card_parse_daifmt(struct device *dev, struct device_node *codec, char *prefix, unsigned int *retfmt); +__printf(3, 4) int asoc_simple_card_set_dailink_name(struct device *dev, struct snd_soc_dai_link *dai_link, const char *fmt, ...); -- 2.9.3

3 4

[alsa-devel] [PATCH -next] sound: rockchip: fix build when SPI_MASTER is not enabled
by Randy Dunlap 24 Aug '16

24 Aug '16

From: Randy Dunlap <rdunlap(a)infradead.org> Fix multiple build errors in sound/soc/rockchip/ drivers by adding "depends on SPI_MASTER". Fixes these build errors: sound/built-in.o: In function `rt5514_spi_burst_read': (.text+0x6c26c): undefined reference to `spi_sync' sound/built-in.o: In function `rt5514_spi_burst_write': (.text+0x6c96e): undefined reference to `spi_sync' sound/built-in.o: In function `rockchip_sound_probe': rk3399_gru_sound.c:(.text+0x9f579): undefined reference to `spi_bus_type' sound/built-in.o: In function `rt5514_spi_driver_init': rt5514-spi.c:(.init.text+0x983): undefined reference to `__spi_register_driver' Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> Cc: Heiko Stuebner <heiko(a)sntech.de> Cc: linux-arm-kernel(a)lists.infradead.org Cc: linux-rockchip(a)lists.infradead.org --- sound/soc/rockchip/Kconfig | 1 + 1 file changed, 1 insertion(+) --- linux-next-20160824.orig/sound/soc/rockchip/Kconfig +++ linux-next-20160824/sound/soc/rockchip/Kconfig @@ -45,6 +45,7 @@ config SND_SOC_ROCKCHIP_RT5645 config SND_SOC_RK3399_GRU_SOUND tristate "ASoC support multiple codecs for Rockchip RK3399 GRU boards" depends on SND_SOC_ROCKCHIP && I2C && GPIOLIB && CLKDEV_LOOKUP + depends on SPI_MASTER select SND_SOC_ROCKCHIP_I2S select SND_SOC_MAX98357A select SND_SOC_RT5514

1 0

[alsa-devel] [PATCH -next] sound: rockchip: fix build when SPI is not enabled
by Randy Dunlap 24 Aug '16

24 Aug '16

From: Randy Dunlap <rdunlap(a)infradead.org> Fix build errors found in rt5514 drivers when SPI is not enabled. Fixes these build errors: ERROR: "__spi_register_driver" [sound/soc/codecs/snd-soc-rt5514-spi.ko] undefined! ERROR: "spi_sync" [sound/soc/codecs/snd-soc-rt5514-spi.ko] undefined! Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> Cc: Bard Liao <bardliao(a)realtek.com> Cc: Oder Chiou <oder_chiou(a)realtek.com> --- sound/soc/rockchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) This builds without errors, but if you always want to have the SPI interface available in this driver, change the first "depends" to include "&& SPI_MASTER". --- linux-next-20160822.orig/sound/soc/rockchip/Kconfig +++ linux-next-20160822/sound/soc/rockchip/Kconfig @@ -49,7 +49,7 @@ config SND_SOC_RK3399_GRU_SOUND select SND_SOC_MAX98357A select SND_SOC_RT5514 select SND_SOC_DA7219 - select SND_SOC_RT5514_SPI + select SND_SOC_RT5514_SPI if SPI_MASTER help Say Y or M here if you want to add support multiple codecs for SoC audio on Rockchip RK3399 GRU boards.

1 1

[alsa-devel] Questions about DAPM Routing for STA309A DSP Driver
by Mauricio Cirelli 24 Aug '16

24 Aug '16

Dear ALSA Community, I am new to this community and have a basic knowledge on ASoC architecture. I have worked a few times with Freescale's boards and the SGTL5000 Codec driver. Now, time has come for me to develop a ASoC Codec Driver for an Audio DSP (ST Microelectronics STA309A). Obviously, this driver should work only on the Playback stream. This chip supports up to 8 playback channels (I2S format) and has up to 8 output channels. There are also 8 internal channels, whose inputs can be one of the 8 playback channels and outputs are connected to one of each 8 output channels like this: Playback Channel X --> Input Channel Y --> Output Channel Z This DSP has several controls to apply effects and modify volume on each channel internal channel individually. I have been able to implement snd_kcontrol_new for them successfully and I am able to control them from the userspace correctly. The part I am still in doubt on how to proceed is related to this channel routing. From what I have researched, this could be designed on top of DAPM Widgets and DAPM Routes in a way that the machine-level driver could configure this routing according to the specific board and the userspace would not be required to deal with this stuff. I want to develop a device driver following the ASoC architecture so I can use it in different boards and in a way it could be useful for other developers. Here is what I was sketching up for this snd_soc_codec_driver: static const char *input_names[8] = { "DIN1", "DIN2", "DIN3", "DIN4", "DIN5", "DIN6", "DIN7", "DIN8" }; static const char *internal_names[8] = { "INT1", "INT2", "INT3", "INT4", "INT5", "INT6", "INT7", "INT8" }; /* Playback Channel to Internal DSP Channel Mapping */ static SOC_ENUM_SINGLE_DECL(int1mux, STA309A_C12IM, 0, input_names); static const struct snd_kcontrol_new int1mux_ctrl = SOC_DAPM_ENUM("INT1MUX", int1mux); .... replicated to all 8 internal channels /* Internal DSP Channel to Output Channel Mapping */ static SOC_ENUM_SINGLE_DECL(out1mux, STA309A_C12OM, 0, internal_names); static const struct snd_kcontrol_new out1mux_ctrl = SOC_DAPM_ENUM("OUT1MUX", out1mux); .... replicated to all 8 output channels static const struct snd_soc_dapm_widget sta309a_dsp_dapm_widgets[] = { SND_SOC_DAPM_MUX("INT1MUX", SND_SOC_NOPM, 0, 0, &int1mux_ctrl), .... added 8 internal channel muxes SND_SOC_DAPM_MUX("OUT1MUX", SND_SOC_NOPM, 0, 0, &out1mux_ctrl), .... added 8 output channel muxes }; Now I am lost on how to declare the possible routes. It should be possible to route each playback channel to any of the 8 possible internal channels and the internal channels to any of the 8 possible output channels. Note that this DSP supports Cross-Overs, so one can route a playback channel to one or more internal channels. Analogously, one can route an internal channel to one or more output channels. I have not started to develop the machine-level driver, but any thoughts on how to design it would be very helpful. In the machine-level driver, I would like to define the DSP routing for an specific board. How can I do it? Thank you very much. Mauricio Cirelli

1 0