August 2016 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 1160/1285] Replace numeric parameter like 0444 with macro
by Baole Ni 02 Aug '16

02 Aug '16

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu(a)intel.com> Signed-off-by: Baole Ni <baolex.ni(a)intel.com> --- sound/drivers/ml403-ac97cr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/drivers/ml403-ac97cr.c b/sound/drivers/ml403-ac97cr.c index bdcb572..3945d76 100644 --- a/sound/drivers/ml403-ac97cr.c +++ b/sound/drivers/ml403-ac97cr.c @@ -75,11 +75,11 @@ static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX; static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR; static bool enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE; -module_param_array(index, int, NULL, 0444); +module_param_array(index, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(index, "Index value for ML403 AC97 Controller Reference."); -module_param_array(id, charp, NULL, 0444); +module_param_array(id, charp, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(id, "ID string for ML403 AC97 Controller Reference."); -module_param_array(enable, bool, NULL, 0444); +module_param_array(enable, bool, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(enable, "Enable this ML403 AC97 Controller Reference."); /* Special feature options */ -- 2.9.2

1 0

[alsa-devel] [PATCH 1159/1285] Replace numeric parameter like 0444 with macro
by Baole Ni 02 Aug '16

02 Aug '16

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu(a)intel.com> Signed-off-by: Baole Ni <baolex.ni(a)intel.com> --- sound/drivers/dummy.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c index c0f8f61..2318140 100644 --- a/sound/drivers/dummy.c +++ b/sound/drivers/dummy.c @@ -70,24 +70,24 @@ static bool hrtimer = 1; #endif static bool fake_buffer = 1; -module_param_array(index, int, NULL, 0444); +module_param_array(index, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(index, "Index value for dummy soundcard."); -module_param_array(id, charp, NULL, 0444); +module_param_array(id, charp, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(id, "ID string for dummy soundcard."); -module_param_array(enable, bool, NULL, 0444); +module_param_array(enable, bool, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(enable, "Enable this dummy soundcard."); -module_param_array(model, charp, NULL, 0444); +module_param_array(model, charp, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(model, "Soundcard model."); -module_param_array(pcm_devs, int, NULL, 0444); +module_param_array(pcm_devs, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(pcm_devs, "PCM devices # (0-4) for dummy driver."); -module_param_array(pcm_substreams, int, NULL, 0444); +module_param_array(pcm_substreams, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(pcm_substreams, "PCM substreams # (1-128) for dummy driver."); //module_param_array(midi_devs, int, NULL, 0444); //MODULE_PARM_DESC(midi_devs, "MIDI devices # (0-2) for dummy driver."); -module_param(fake_buffer, bool, 0444); +module_param(fake_buffer, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(fake_buffer, "Fake buffer allocations."); #ifdef CONFIG_HIGH_RES_TIMERS -module_param(hrtimer, bool, 0644); +module_param(hrtimer, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(hrtimer, "Use hrtimer as the timer source."); #endif -- 2.9.2

1 0

[alsa-devel] [PATCH 1158/1285] Replace numeric parameter like 0444 with macro
by Baole Ni 02 Aug '16

02 Aug '16

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu(a)intel.com> Signed-off-by: Baole Ni <baolex.ni(a)intel.com> --- sound/drivers/aloop.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/drivers/aloop.c b/sound/drivers/aloop.c index 54f348a..03cc8be 100644 --- a/sound/drivers/aloop.c +++ b/sound/drivers/aloop.c @@ -55,15 +55,15 @@ static bool enable[SNDRV_CARDS] = {1, [1 ... (SNDRV_CARDS - 1)] = 0}; static int pcm_substreams[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS - 1)] = 8}; static int pcm_notify[SNDRV_CARDS]; -module_param_array(index, int, NULL, 0444); +module_param_array(index, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(index, "Index value for loopback soundcard."); -module_param_array(id, charp, NULL, 0444); +module_param_array(id, charp, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(id, "ID string for loopback soundcard."); -module_param_array(enable, bool, NULL, 0444); +module_param_array(enable, bool, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(enable, "Enable this loopback soundcard."); -module_param_array(pcm_substreams, int, NULL, 0444); +module_param_array(pcm_substreams, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(pcm_substreams, "PCM substreams # (1-8) for loopback driver."); -module_param_array(pcm_notify, int, NULL, 0444); +module_param_array(pcm_notify, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(pcm_notify, "Break capture when PCM format/rate/channels changes."); #define NO_PITCH 100000 -- 2.9.2

1 0

[alsa-devel] [PATCH 1157/1285] Replace numeric parameter like 0444 with macro
by Baole Ni 02 Aug '16

02 Aug '16

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu(a)intel.com> Signed-off-by: Baole Ni <baolex.ni(a)intel.com> --- sound/core/timer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/core/timer.c b/sound/core/timer.c index e722022..07ec222 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -46,9 +46,9 @@ static int timer_tstamp_monotonic = 1; MODULE_AUTHOR("Jaroslav Kysela <perex(a)perex.cz>, Takashi Iwai <tiwai(a)suse.de>"); MODULE_DESCRIPTION("ALSA timer interface"); MODULE_LICENSE("GPL"); -module_param(timer_limit, int, 0444); +module_param(timer_limit, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(timer_limit, "Maximum global timers in system."); -module_param(timer_tstamp_monotonic, int, 0444); +module_param(timer_tstamp_monotonic, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(timer_tstamp_monotonic, "Use posix monotonic clock source for timestamps (default)."); MODULE_ALIAS_CHARDEV(CONFIG_SND_MAJOR, SNDRV_MINOR_TIMER); -- 2.9.2

1 0

[alsa-devel] [PATCH 1156/1285] Replace numeric parameter like 0444 with macro
by Baole Ni 02 Aug '16

02 Aug '16

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu(a)intel.com> Signed-off-by: Baole Ni <baolex.ni(a)intel.com> --- sound/core/sound.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/core/sound.c b/sound/core/sound.c index 175f9e4..6c5a4f2 100644 --- a/sound/core/sound.c +++ b/sound/core/sound.c @@ -41,9 +41,9 @@ static int cards_limit = 1; MODULE_AUTHOR("Jaroslav Kysela <perex(a)perex.cz>"); MODULE_DESCRIPTION("Advanced Linux Sound Architecture driver for soundcards."); MODULE_LICENSE("GPL"); -module_param(major, int, 0444); +module_param(major, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(major, "Major # for sound driver."); -module_param(cards_limit, int, 0444); +module_param(cards_limit, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(cards_limit, "Count of auto-loadable soundcards."); MODULE_ALIAS_CHARDEV_MAJOR(CONFIG_SND_MAJOR); -- 2.9.2

1 0

[alsa-devel] [PATCH 1155/1285] Replace numeric parameter like 0444 with macro
by Baole Ni 02 Aug '16

02 Aug '16

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu(a)intel.com> Signed-off-by: Baole Ni <baolex.ni(a)intel.com> --- sound/core/seq/seq_midi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/core/seq/seq_midi.c b/sound/core/seq/seq_midi.c index 5dd0ee2..18c428d 100644 --- a/sound/core/seq/seq_midi.c +++ b/sound/core/seq/seq_midi.c @@ -43,10 +43,10 @@ MODULE_AUTHOR("Frank van de Pol <fvdpol(a)coil.demon.nl>, Jaroslav Kysela <perex@p MODULE_DESCRIPTION("Advanced Linux Sound Architecture sequencer MIDI synth."); MODULE_LICENSE("GPL"); static int output_buffer_size = PAGE_SIZE; -module_param(output_buffer_size, int, 0644); +module_param(output_buffer_size, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(output_buffer_size, "Output buffer size in bytes."); static int input_buffer_size = PAGE_SIZE; -module_param(input_buffer_size, int, 0644); +module_param(input_buffer_size, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(input_buffer_size, "Input buffer size in bytes."); /* data for this midi synth driver */ -- 2.9.2

1 0

[alsa-devel] [PATCH 1154/1285] Replace numeric parameter like 0444 with macro
by Baole Ni 02 Aug '16

02 Aug '16

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu(a)intel.com> Signed-off-by: Baole Ni <baolex.ni(a)intel.com> --- sound/core/seq/seq_dummy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/core/seq/seq_dummy.c b/sound/core/seq/seq_dummy.c index d3a2ec4..1b01fb6 100644 --- a/sound/core/seq/seq_dummy.c +++ b/sound/core/seq/seq_dummy.c @@ -67,9 +67,9 @@ MODULE_ALIAS("snd-seq-client-" __stringify(SNDRV_SEQ_CLIENT_DUMMY)); static int ports = 1; static bool duplex; -module_param(ports, int, 0444); +module_param(ports, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ports, "number of ports to be created"); -module_param(duplex, bool, 0444); +module_param(duplex, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(duplex, "create DUPLEX ports"); struct snd_seq_dummy_port { -- 2.9.2

1 0

[alsa-devel] [PATCH 1153/1285] Replace numeric parameter like 0444 with macro
by Baole Ni 02 Aug '16

02 Aug '16

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu(a)intel.com> Signed-off-by: Baole Ni <baolex.ni(a)intel.com> --- sound/core/seq/seq.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sound/core/seq/seq.c b/sound/core/seq/seq.c index 639544b..5b1c00e 100644 --- a/sound/core/seq/seq.c +++ b/sound/core/seq/seq.c @@ -58,19 +58,19 @@ MODULE_AUTHOR("Frank van de Pol <fvdpol(a)coil.demon.nl>, Jaroslav Kysela <perex@p MODULE_DESCRIPTION("Advanced Linux Sound Architecture sequencer."); MODULE_LICENSE("GPL"); -module_param_array(seq_client_load, int, NULL, 0444); +module_param_array(seq_client_load, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(seq_client_load, "The numbers of global (system) clients to load through kmod."); -module_param(seq_default_timer_class, int, 0644); +module_param(seq_default_timer_class, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(seq_default_timer_class, "The default timer class."); -module_param(seq_default_timer_sclass, int, 0644); +module_param(seq_default_timer_sclass, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(seq_default_timer_sclass, "The default timer slave class."); -module_param(seq_default_timer_card, int, 0644); +module_param(seq_default_timer_card, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(seq_default_timer_card, "The default timer card number."); -module_param(seq_default_timer_device, int, 0644); +module_param(seq_default_timer_device, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(seq_default_timer_device, "The default timer device number."); -module_param(seq_default_timer_subdevice, int, 0644); +module_param(seq_default_timer_subdevice, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(seq_default_timer_subdevice, "The default timer subdevice number."); -module_param(seq_default_timer_resolution, int, 0644); +module_param(seq_default_timer_resolution, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(seq_default_timer_resolution, "The default timer resolution in Hz."); MODULE_ALIAS_CHARDEV(CONFIG_SND_MAJOR, SNDRV_MINOR_SEQUENCER); -- 2.9.2

1 0

[alsa-devel] [PATCH 1152/1285] Replace numeric parameter like 0444 with macro
by Baole Ni 02 Aug '16

02 Aug '16

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu(a)intel.com> Signed-off-by: Baole Ni <baolex.ni(a)intel.com> --- sound/core/seq/oss/seq_oss_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/seq/oss/seq_oss_init.c b/sound/core/seq/oss/seq_oss_init.c index 92c96a9..4d25f28 100644 --- a/sound/core/seq/oss/seq_oss_init.c +++ b/sound/core/seq/oss/seq_oss_init.c @@ -37,7 +37,7 @@ * common variables */ static int maxqlen = SNDRV_SEQ_OSS_MAX_QLEN; -module_param(maxqlen, int, 0444); +module_param(maxqlen, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(maxqlen, "maximum queue length"); static int system_client = -1; /* ALSA sequencer client number */ -- 2.9.2

1 0

[alsa-devel] [PATCH 1151/1285] Replace numeric parameter like 0444 with macro
by Baole Ni 02 Aug '16

02 Aug '16

I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu(a)intel.com> Signed-off-by: Baole Ni <baolex.ni(a)intel.com> --- sound/core/rawmidi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/core/rawmidi.c b/sound/core/rawmidi.c index 795437b..850c8a9 100644 --- a/sound/core/rawmidi.c +++ b/sound/core/rawmidi.c @@ -42,9 +42,9 @@ MODULE_LICENSE("GPL"); #ifdef CONFIG_SND_OSSEMUL static int midi_map[SNDRV_CARDS]; static int amidi_map[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS-1)] = 1}; -module_param_array(midi_map, int, NULL, 0444); +module_param_array(midi_map, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(midi_map, "Raw MIDI device number assigned to 1st OSS device."); -module_param_array(amidi_map, int, NULL, 0444); +module_param_array(amidi_map, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(amidi_map, "Raw MIDI device number assigned to 2nd OSS device."); #endif /* CONFIG_SND_OSSEMUL */ -- 2.9.2

1 0