July 2016 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH RFC alsa-lib 0/5] Add thread-safety to PCM API
by Takashi Iwai 05 Jul '16

05 Jul '16

Hi, here is an experimental patchset to add multi thread safety to PCM functions. Basically ALSA PCM functions are thread-unsafe, and applications are supposed to do the proper protection against racy accesses. The reality is, however, that application developers don't care such, as alsa-lib works in most cases. Of course, users still get occasionally mysterious crashes. As a workaround, this patchset adds the pthread mutex protection to most of exported PCM functions. This is slightly an overkill, but the biggest merit is that it's easy to implement; I just wrapped the functions and replaced the internal ones with unlocked versions. To be noted, there is an optimization for the direct hw PCM access. Performance-sensitive applications like JACK should work like before without any overhead. Another bonus by this addition is that we can finally get rid of home brew (and deadly smelling) atomic macros from the tree, since it's now more widely protected. I lightly tested on my local machines and it seems working well, so far. Comments and suggestions welcome. thanks, Takashi === Takashi Iwai (5): pcm: Add thread-safety to PCM API test: Add pcm-multi-thread program Add pcm-multi-thread to .gitignore pcm: Remove superfluous rmb() from PCM meter plugin pcm: Remove home brew atomic operations .gitignore | 1 + configure.ac | 15 ++ include/Makefile.am | 2 +- include/iatomic.h | 170 ------------------ src/pcm/Makefile.am | 2 +- src/pcm/atomic.c | 43 ----- src/pcm/pcm.c | 468 +++++++++++++++++++++++++++++++++++++++++------- src/pcm/pcm_direct.c | 4 +- src/pcm/pcm_dmix.c | 13 +- src/pcm/pcm_dshare.c | 13 +- src/pcm/pcm_dsnoop.c | 15 +- src/pcm/pcm_file.c | 21 ++- src/pcm/pcm_generic.c | 10 +- src/pcm/pcm_hw.c | 3 + src/pcm/pcm_ioplug.c | 11 +- src/pcm/pcm_local.h | 62 ++++++- src/pcm/pcm_meter.c | 1 - src/pcm/pcm_mmap.c | 16 +- src/pcm/pcm_params.c | 2 +- src/pcm/pcm_plugin.c | 72 ++------ src/pcm/pcm_plugin.h | 2 - src/pcm/pcm_rate.c | 41 ++--- src/pcm/pcm_route.c | 2 +- test/Makefile.am | 3 +- test/pcm-multi-thread.c | 263 +++++++++++++++++++++++++++ 25 files changed, 851 insertions(+), 404 deletions(-) delete mode 100644 include/iatomic.h delete mode 100644 src/pcm/atomic.c create mode 100644 test/pcm-multi-thread.c -- 2.9.0

2 7

[alsa-devel] [PATCH v2 0/6] Sound support for Exynos5433 TM2(E) boards
by Sylwester Nawrocki 05 Jul '16

05 Jul '16

This patch series adds sound supoort for the Exynos 5433 based TM2 and TM2E board. It includes minimal drivers for the Low Power Audio Subsystem (LPASS) and the MAX98504 class D speaker amplifier as well as the actual asoc machine driver. The changes are listed in individual patches, there were only v1 3/6, 4/6 patches (max98504), for others I skipped from RFC to v2. Inha Song (2): ASoC: samsung: Add Samsung Low Power Audio Subsystem driver ASoC: samsung: Add machine driver for Exynos5433 based TM2 board Sylwester Nawrocki (4): ASoC: samsung: Add DT bindings documentation for LPASS ASoC: Add DT bindings documentation for max98504 amplifier ASoC: max98504: Add max98504 speaker amplifier driver ASoC: samsung: Add DT bindings documentation for TM2 sound subsystem .../devicetree/bindings/sound/max98504.txt | 26 + .../bindings/sound/samsung,exynos5433-lpass.txt | 8 + .../bindings/sound/samsung,tm2-audio.txt | 36 ++ sound/soc/codecs/Kconfig | 4 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/max98504.c | 356 +++++++++++++ sound/soc/codecs/max98504.h | 76 +++ sound/soc/samsung/Kconfig | 13 + sound/soc/samsung/Makefile | 4 + sound/soc/samsung/lpass.c | 162 ++++++ sound/soc/samsung/lpass.h | 47 ++ sound/soc/samsung/tm2_wm5110.c | 579 +++++++++++++++++++++ 12 files changed, 1313 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/max98504.txt create mode 100644 Documentation/devicetree/bindings/sound/samsung,exynos5433-lpass.txt create mode 100644 Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt create mode 100644 sound/soc/codecs/max98504.c create mode 100644 sound/soc/codecs/max98504.h create mode 100644 sound/soc/samsung/lpass.c create mode 100644 sound/soc/samsung/lpass.h create mode 100644 sound/soc/samsung/tm2_wm5110.c -- 1.9.1

3 20

Re: [alsa-devel] [PATCH] hda/realtek: Add Lenovo L460 to docking unit fixup
by Takashi Iwai 05 Jul '16

05 Jul '16

On Tue, 05 Jul 2016 10:40:22 +0200, Torsten Hilbrich wrote: > > This solves the issue that a headphone is not working on the docking > unit. > > Signed-off-by: Torsten Hilbrich <torsten.hilbrich(a)secunet.com> Applied, thanks. Takashi

1 0

[alsa-devel] [PATCH 0/4] ASoC: Mediatek: add MT2701 platform and machine driver
by Garlic Tseng 05 Jul '16

05 Jul '16

Some patches of the patchset "ASoC: Mediatek: Add support for MT2701 SOC" have been applied to the broonie tree, so I send a new patchset for the remaining patches. The patchset adds mt2701 support based on Mediatek AFE common structure. Change since the previous patchset: * remove unnecessary set_clkdiv and set_fmt ops in mt2701 platform driver * add another snd_soc_dai_driver for bt-sco codec to support 8k and 16k Garlic Tseng (4): ASoC: mediatek: add mt2701 platform driver implementation. ASoC: bt-sco: extend rate and add a general compatible string ASoC: mediatek: add BT implementation ASoC: mediatek: Add mt2701-cs42448 driver and config option. Documentation/devicetree/bindings/sound/bt-sco.txt | 2 +- sound/soc/codecs/bt-sco.c | 52 +- sound/soc/mediatek/Kconfig | 21 + sound/soc/mediatek/Makefile | 1 + sound/soc/mediatek/mt2701/Makefile | 19 + sound/soc/mediatek/mt2701/mt2701-afe-common.h | 9 - sound/soc/mediatek/mt2701/mt2701-afe-pcm.c | 1654 ++++++++++++++++++++ sound/soc/mediatek/mt2701/mt2701-cs42448.c | 412 +++++ 8 files changed, 2144 insertions(+), 26 deletions(-) create mode 100644 sound/soc/mediatek/mt2701/Makefile create mode 100644 sound/soc/mediatek/mt2701/mt2701-afe-pcm.c create mode 100644 sound/soc/mediatek/mt2701/mt2701-cs42448.c -- 1.9.1

2 12

Re: [alsa-devel] ASUS STRIX sound card quiet microphone (like, really quiet ...)
by Clemens Ladisch 05 Jul '16

05 Jul '16

auspicious(a)inventati.org wrote: > On 05/07/2016 07:19, Clemens Ladisch wrote: >> auspicious(a)inventati.org wrote: >>> I currently am using an ASUS STRIX RAID DLX sound card. It contains the following processor: >>> C-Media USB2.0 6632AX High-Definition Sound Processor (Max. 384KHz / 24bit) >>> >>> the microphone bit has always been troublesome. >>> it started working but it is incredibly quiet. >> >> You did not mention mixer controls. >> Does it have any? (Try alsamixer.) > > Attached image in the attachment That "Input Gain" looks OK. Does it actually work? Does it make the mic input quieter? It's possible that there is some vendor-specific stuff that the USB audio driver does not know. Does it work in Windows with Microsoft's generic USB audio driver, or does it need a custom driver from Asus? Regards, Clemens

1 0

[alsa-devel] [PATCH] ASoC: rt5645: disable soft volume control
by Bard Liao 05 Jul '16

05 Jul '16

With soft volume control function, rt5645/rt5650 will start with 0dB volume and take a little time to adjust volume to given value. And it will cause a bad user experience. This patch disable it. Signed-off-by: Bard Liao <bardliao(a)realtek.com> --- sound/soc/codecs/rt5645.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 97bf96e..c969f48 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -63,6 +63,7 @@ static const struct reg_sequence init_list[] = { {RT5645_PR_BASE + 0x20, 0x611f}, {RT5645_PR_BASE + 0x21, 0x4040}, {RT5645_PR_BASE + 0x23, 0x0004}, + {RT5645_PR_BASE + 0x00, 0x0a2a}, {RT5645_ASRC_4, 0x0120}, }; -- 1.8.1.1.439.g50a6b54

2 2

[alsa-devel] ASUS STRIX sound card quiet microphone (like, really quiet ...)
by auspicious＠inventati.org 05 Jul '16

05 Jul '16

Dear mailing list individuals, I currently am using an ASUS STRIX RAID DLX sound card. It contains the following processor: C-Media USB2.0 6632AX High-Definition Sound Processor (Max. 384KHz / 24bit) More information: https://www.asus.com/Sound-Cards/STRIX-RAID-DLX/specifications It gets detected as so on Debian testing with Linux kernel 4.6: card 1: DLX [STRIX RAID DLX], device 0: USB Audio [USB Audio] Subdevices: 1/1 Subdevice #0: subdevice #0 card 1: DLX [STRIX RAID DLX], device 1: USB Audio [USB Audio #1] Subdevices: 1/1 Subdevice #0: subdevice #0 card 1: DLX [STRIX RAID DLX], device 2: USB Audio [USB Audio #2] Subdevices: 1/1 Subdevice #0: subdevice #0 The output of the card has been wonderfully fine ever since I have had it, but the microphone bit has always been troublesome. On Linux Mint 17.3 it would not work (kernel 4.1 I believe). On Linux Mint 18 (kernel 4.4) it started working but it is incredibly quiet. On the loudest setting, I have to put the microphone against my mouth for anyone to hear. On the same system using on-board Intel audio, this issue does not occur. I am using Debian testing to have more recent software, but nothing made a difference. What can I do about this? I do not really know whether I need to contact the Linux kernel guys or ALSA. I am rather inexperienced with Linux driver things. Sincerely yours, Desperate Individual

2 1

[alsa-devel] SND_PCM_STREAM_CAPTURE and SND_PCM_NONBLOCK producing strange artifacts
by Trent Reed 05 Jul '16

05 Jul '16

Hey All, I've been banging my head against the wall for about a week on this bug. The following gist shows my sample reproduction code: https://gist.github.com/TReed0803/985c5d5c3d295245e19006a27be447c3 I'm simply opening up a non-blocking PCM capture stream and writing the contents of the reads to stdout. (Originally, I was writing to the playback stream, but I was hearing this strange static occasionally!) It's the static I'm trying to debug. It doesn't happen every time. In fact, sometimes I'll go a few consecutive executions without hearing it. I was able to capture some of the bad data, and I loaded it up in Audacity for visualization: https://drive.google.com/file/d/0B-1aumGKQcQTcUJoZzIwRWhYSFE/view?usp=shari… It looks like the internal buffer occasionally is sending me more data than it actually captured, and I end up either reading old PCM data from the internal ring buffer, or (at the very beginning) a bunch of zeros. Can anyone help me understand what is going on? What could cause these definitely incorrect samples to be recorded? (I get the same effect regardless of hardware, but I will list hardware just in case.) I hope I have all the information you might need: Hardware: Samson Meteor Mic (USB-Audio, USB Mixer) [Though, it even happens with my built-in microphone] ALSA version: Advanced Linux Sound Architecture Driver Version k4.4.0-28-generic. apt-cache policy (installed alsa-lib version): 1.1.0-0ubuntu1 Thanks, - Trent Reed

2 2

[alsa-devel] [PATCH v2 0/2] Add audio support for Microsoft Surface 3 tablet
by Stephen Just 05 Jul '16

05 Jul '16

This series adds audio support for the Surface 3 tablet. This tablet identifes an rt5645 audio codec using the ACPI identifer 10EC5640, which is already associated with the rt5640, thus a quirk is required to have the correct drivers loaded. Additionally, in order for jack-detection and the tablet's internal microphone to work, the Surface 3 must be configured in the audio codec driver similarly to other devices. Resolves: https://bugzilla.kernel.org/show_bug.cgi?id=98001 Changes in v2: Remove alsa-lib changes from series Stephen Just (2): ASoC: rt5645: Add support for Surface 3 tablet ASoC: Intel: Atom: add quirk for CHT w/ RT5645 sound/soc/codecs/rt5645.c | 7 +++++++ sound/soc/intel/atom/sst/sst_acpi.c | 29 ++++++++++++++++++++++++++++- sound/soc/intel/boards/cht_bsw_rt5645.c | 1 + 3 files changed, 36 insertions(+), 1 deletion(-) -- 2.7.4

3 6

[alsa-devel] [PATCH] [alsa-lib] conf/ucm: chtrt5645: Add UCM config for chtrt5645
by Stephen Just 05 Jul '16

05 Jul '16

Add a UCM configuration for the rt5645 codec on Intel's Cherry-Trail platform. Tested on the Microsoft Surface 3. Signed-off-by: Stephen Just <stephenjust(a)gmail.com> --- configure.ac | 1 + src/conf/ucm/Makefile.am | 2 +- src/conf/ucm/chtrt5645/HiFi.conf | 209 ++++++++++++++++++++++++++++++++++ src/conf/ucm/chtrt5645/Makefile.am | 4 + src/conf/ucm/chtrt5645/chtrt5645.conf | 5 + 5 files changed, 220 insertions(+), 1 deletion(-) create mode 100644 src/conf/ucm/chtrt5645/HiFi.conf create mode 100644 src/conf/ucm/chtrt5645/Makefile.am create mode 100644 src/conf/ucm/chtrt5645/chtrt5645.conf diff --git a/configure.ac b/configure.ac index 53fca33..9eebd0a 100644 --- a/configure.ac +++ b/configure.ac @@ -659,6 +659,7 @@ AC_OUTPUT(Makefile doc/Makefile doc/pictures/Makefile doc/doxygen.cfg \ src/conf/ucm/GoogleNyan/Makefile \ src/conf/ucm/broadwell-rt286/Makefile \ src/conf/ucm/VEYRON-I2S/Makefile \ + src/conf/ucm/chtrt5645/Makefile \ src/conf/topology/Makefile \ src/conf/topology/broadwell/Makefile \ modules/Makefile modules/mixer/Makefile modules/mixer/simple/Makefile \ diff --git a/src/conf/ucm/Makefile.am b/src/conf/ucm/Makefile.am index 3cce36a..8865770 100644 --- a/src/conf/ucm/Makefile.am +++ b/src/conf/ucm/Makefile.am @@ -1 +1 @@ -SUBDIRS=DAISY-I2S PandaBoard PandaBoardES SDP4430 tegraalc5632 PAZ00 GoogleNyan broadwell-rt286 VEYRON-I2S +SUBDIRS=DAISY-I2S PandaBoard PandaBoardES SDP4430 tegraalc5632 PAZ00 GoogleNyan broadwell-rt286 VEYRON-I2S chtrt5645 diff --git a/src/conf/ucm/chtrt5645/HiFi.conf b/src/conf/ucm/chtrt5645/HiFi.conf new file mode 100644 index 0000000..0c2c83c --- /dev/null +++ b/src/conf/ucm/chtrt5645/HiFi.conf @@ -0,0 +1,209 @@ +SectionVerb { + # ALSA PCM + Value { + TQ "HiFi" + + # ALSA PCM device for HiFi + PlaybackPCM "hw:chtrt5645,0" + CapturePCM "hw:chtrt5645,0" + } + + EnableSequence [ + cdev "hw:chtrt5645" + + # Enable audio output path + cset "name='codec_out1 mix 0 pcm0_in Switch' on" + cset "name='media0_out mix 0 media1_in Switch' on" + + cset "name='media1_in Gain 0 Ramp Delay' 50" + cset "name='media1_in Gain 0 Switch' on" + cset "name='media1_in Gain 0 Volume' 80% 80%" + + cset "name='pcm0_in Gain 0 Ramp Delay' 50" + cset "name='pcm0_in Gain 0 Switch' on" + cset "name='pcm0_in Gain 0 Volume' 80% 80%" + + cset "name='codec_out1 Gain 0 Ramp Delay' 50" + cset "name='codec_out1 Gain 0 Switch' on" + cset "name='codec_out1 Gain 0 Volume' 70% 70%" + + # Enable audio input path + cset "name='pcm1_out mix 0 media_loop2_in Switch' on" + cset "name='media_loop2_out mix 0 codec_in0 Switch' on" + + cset "name='codec_in0 Gain 0 Ramp Delay' 50" + cset "name='codec_in0 Gain 0 Switch' on" + cset "name='codec_in0 Gain 0 Volume' 80% 80%" + + cset "name='media_loop2_out Gain 0 Ramp Delay' 50" + cset "name='media_loop2_out Gain 0 Switch' on" + cset "name='media_loop2_out Gain 0 Volume' 80% 80%" + + cset "name='pcm1_out Gain 0 Ramp Delay' 50" + cset "name='pcm1_out Gain 0 Switch' on" + cset "name='pcm1_out Gain 0 Volume' 80% 80%" + + # Output Configuration + cset "name='DAC L2 Mux' 'IF1 DAC'" + cset "name='DAC R2 Mux' 'IF1 DAC'" + cset "name='Mono DAC MIXL DAC L2 Switch' on" + cset "name='Mono DAC MIXR DAC R2 Switch' on" + cset "name='DAC2 Playback Switch' on" + + cset "name='HPOVOL MIXL DAC2 Switch' on" + cset "name='HPOVOL MIXR DAC2 Switch' on" + cset "name='HPO MIX HPVOL Switch' on" + cset "name='HPOVOL L Switch' on" + cset "name='HPOVOL R Switch' on" + + cset "name='SPK MIXL DAC L2 Switch' on" + cset "name='SPK MIXR DAC R2 Switch' on" + cset "name='SPOL MIX SPKVOL L Switch' on" + cset "name='SPOR MIX SPKVOL R Switch' on" + cset "name='SPKVOL L Switch' on" + cset "name='SPKVOL R Switch' on" + + # Input Configuration + cset "name='Stereo1 DMIC Mux' 0" + cset "name='Stereo1 ADC2 Mux' 1" + cset "name='ADC Capture Switch' on" + cset "name='ADC Capture Volume' 31" + cset "name='ADC Boost Capture Volume' 3" + cset "name='Mono ADC Capture Volume' 63" + cset "name='Mono ADC Boost Capture Volume' 2" + cset "name='IN Capture Volume' 63" + cset "name='I2S2 Func Switch' on" + + ] + + DisableSequence [ + cdev "hw:chtrt5645" + + # Disable audio output path + cset "name='codec_out1 mix 0 pcm0_in Switch' off" + cset "name='media0_out mix 0 media1_in Switch' off" + + cset "name='media1_in Gain 0 Switch' off" + cset "name='pcm0_in Gain 0 Switch' off" + cset "name='codec_out1 Gain 0 Switch' off" + + # Disable audio input path + cset "name='pcm1_out mix 0 media_loop2_in Switch' off" + cset "name='media_loop2_out mix 0 codec_in0 Switch' off" + + cset "name='media_loop2_out Gain 0 Switch' off" + cset "name='pcm1_out Gain 0 Switch' off" + cset "name='codec_in0 Gain 0 Switch' off" + ] +} + +SectionDevice."Speaker" { + Comment "Speaker" + + Value { + PlaybackChannels "2" + } + + ConflictingDevice [ + "Headphone" + ] + + EnableSequence [ + cdev "hw:chtrt5645" + + cset "name='Ext Spk Switch' on" + cset "name='Speaker Channel Switch' on" + cset "name='Speaker Playback Volume' 39" + ] + + DisableSequence [ + cdev "hw:chtrt5645" + + cset "name='Ext Spk Switch' off" + cset "name='Speaker Channel Switch' off" + ] +} + +SectionDevice."Headphone".0 { + Comment "Headphones" + + Value { + PlaybackChannels "2" + JackControl "Headphone Jack" + JackHWMute "Speaker" + } + + ConflictingDevice [ + "Speaker" + ] + + EnableSequence [ + cdev "hw:chtrt5645" + + cset "name='Headphone Switch' on" + cset "name='Headphone Channel Switch' on" + cset "name='Headphone Playback Volume' 39" + ] + + DisableSequence [ + cdev "hw:chtrt5645" + + cset "name='Headphone Switch' off" + cset "name='Headphone Channel Switch' off" + ] +} + +SectionDevice."Mic".0 { + Comment "Internal Microphone" + + Value { + CaptureChannels "2" + CapturePriority "150" + } + + EnableSequence [ + cdev "hw:chtrt5645" + + cset "name='Int Mic Switch' on" + cset "name='Sto1 ADC MIXL ADC2 Switch' on" + cset "name='Sto1 ADC MIXR ADC2 Switch' on" + ] + + DisableSequence [ + cdev "hw:chtrt5645" + + cset "name='Sto1 ADC MIXL ADC2 Switch' off" + cset "name='Sto1 ADC MIXR ADC2 Switch' off" + cset "name='Int Mic Switch' off" + ] +} + +SectionDevice."HSMic".0 { + Comment "Headset Microphone" + + Value { + CaptureChannels "2" + JackControl "Headset Mic Jack" + JackHWMute "Mic" + } + + EnableSequence [ + cdev "hw:chtrt5645" + + cset "name='Headset Mic Switch' on" + cset "name='RECMIXL BST1 Switch' on" + cset "name='RECMIXR BST1 Switch' on" + cset "name='Sto1 ADC MIXL ADC1 Switch' on" + cset "name='Sto1 ADC MIXR ADC1 Switch' on" + ] + + DisableSequence [ + cdev "hw:chtrt5645" + + cset "name='Headset Mic Switch' off" + cset "name='RECMIXL BST1 Switch' off" + cset "name='RECMIXR BST1 Switch' off" + cset "name='Sto1 ADC MIXL ADC1 Switch' off" + cset "name='Sto1 ADC MIXR ADC1 Switch' off" + ] +} diff --git a/src/conf/ucm/chtrt5645/Makefile.am b/src/conf/ucm/chtrt5645/Makefile.am new file mode 100644 index 0000000..b3a82f5 --- /dev/null +++ b/src/conf/ucm/chtrt5645/Makefile.am @@ -0,0 +1,4 @@ +alsaconfigdir = @ALSA_CONFIG_DIR@ +ucmdir = $(alsaconfigdir)/ucm/chtrt5645 +ucm_DATA = chtrt5645.conf HiFi.conf +EXTRA_DIST = $(ucm_DATA) diff --git a/src/conf/ucm/chtrt5645/chtrt5645.conf b/src/conf/ucm/chtrt5645/chtrt5645.conf new file mode 100644 index 0000000..dfc36c8 --- /dev/null +++ b/src/conf/ucm/chtrt5645/chtrt5645.conf @@ -0,0 +1,5 @@ +Comment "Intel SoC Audio Device" +SectionUseCase."HiFi" { + File "HiFi.conf" + Comment "Default" +} -- 2.9.0

2 1