May 2016 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] [PATCH v7 0/3] ASoC: cygnus: Add audio support for Broadcom Cygnus SoC
by Florian Fainelli 17 May '16

17 May '16

On 05/17/2016 12:46 PM, Simran Rai wrote: > From: Simran <ssimran(a)lbrmn-ssimran-lnxub64.ric.broadcom.com> Please fix your git email address and resubmit. -- Florian

1 0

[alsa-devel] Imx6 i2s master driver without i2c
by nick83ola 17 May '16

17 May '16

Hello Alsa dev! Anyone have an example of an i2s only driver for imx6 solo? I need a driver without i2c....

2 16

[alsa-devel] [PATCH] ASoC: hdac_hdmi: remove ununsed variable 'timeout'
by Colin King 17 May '16

17 May '16

From: Colin Ian King <colin.king(a)canonical.com> Fix build warning by removing unused variable timeout Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/soc/codecs/hdac_hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c index 3733297..181cd3b 100644 --- a/sound/soc/codecs/hdac_hdmi.c +++ b/sound/soc/codecs/hdac_hdmi.c @@ -1718,7 +1718,6 @@ static int hdac_hdmi_runtime_suspend(struct device *dev) struct hdac_ext_device *edev = to_hda_ext_device(dev); struct hdac_device *hdac = &edev->hdac; struct hdac_bus *bus = hdac->bus; - unsigned long timeout; struct hdac_ext_bus *ebus = hbus_to_ebus(bus); struct hdac_ext_link *hlink = NULL; int err; -- 2.8.1

2 1

[alsa-devel] [PATCH] sound: oss: Use setup_timer and mod_timer.
by Muhammad Falak R Wani 17 May '16

17 May '16

The function setup_timer combines the initialization of a timer with the initialization of the timer's function and data fields. The mulitiline code for timer initialization is now replaced with function setup_timer. Also, quoting the mod_timer() function comment: -> mod_timer() is a more efficient way to update the expire field of an active timer (if the timer is inactive it will be activated). Use setup_timer() and mod_timer() to setup and arm a timer, making the code compact and aid readablity. Signed-off-by: Muhammad Falak R Wani <falakreyaz(a)gmail.com> --- sound/oss/waveartist.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sound/oss/waveartist.c b/sound/oss/waveartist.c index b36ea47..0b8d0de 100644 --- a/sound/oss/waveartist.c +++ b/sound/oss/waveartist.c @@ -1414,11 +1414,9 @@ attach_waveartist(struct address_info *hw, const struct waveartist_mixer_info *m else { #ifdef CONFIG_ARCH_NETWINDER if (machine_is_netwinder()) { - init_timer(&vnc_timer); - vnc_timer.function = vnc_slider_tick; - vnc_timer.expires = jiffies; - vnc_timer.data = nr_waveartist_devs; - add_timer(&vnc_timer); + setup_timer(&vnc_timer, vnc_slider_tick, + nr_waveartist_devs); + mod_timer(&vnc_timer, jiffies); vnc_configure_mixer(devc, 0); -- 1.9.1

2 1

[alsa-devel] [PATCH] ASoC: nau8825: Export I2C module alias information
by Javier Martinez Canillas 17 May '16

17 May '16

The I2C driver has an i2c_device_id array but that information isn't exported to the module using the MODULE_DEVICE_TABLE() macro. So the module autoloading won't work if the I2C device is registered using OF or legacy board files due missing alias information in the module. The issue was found using Kieran Bingham's coccinelle semantic patch: https://lkml.org/lkml/2016/5/10/520 Signed-off-by: Javier Martinez Canillas <javier(a)osg.samsung.com> --- sound/soc/codecs/nau8825.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c index 81fc97b07751..e988f89ef715 100644 --- a/sound/soc/codecs/nau8825.c +++ b/sound/soc/codecs/nau8825.c @@ -1493,6 +1493,7 @@ static const struct i2c_device_id nau8825_i2c_ids[] = { { "nau8825", 0 }, { } }; +MODULE_DEVICE_TABLE(i2c, nau8825_i2c_ids); #ifdef CONFIG_OF static const struct of_device_id nau8825_of_ids[] = { -- 2.5.5

1 0

[alsa-devel] [PATCH] alsa-lib:Make snd_atomic_write_* truly atomic
by Andreas x Larsson 17 May '16

17 May '16

Under some usecases a race condition appears inside the snd_atomic_write_* functions. The 'begin' and 'end' variables are updated with the ++ operator which is not atomic but needs to be. This can be achieved with the gcc atomic_* built-ins. Combined with __ATOMIC_SEQ_CST as the memory model, memory barriers are introduced so those can also be removed from the code. Signed-off-by: Andreas x Larsson <andrelan(a)axis.com> Signed-off-by: Arvid Nihlgård Lindell <arvidnl(a)axis.com> --- alsa-lib/include/iatomic.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/alsa-lib/include/iatomic.h b/alsa-lib/include/iatomic.h index acdd3e2..7fafe20 100644 --- a/alsa-lib/include/iatomic.h +++ b/alsa-lib/include/iatomic.h @@ -140,14 +140,12 @@ static __inline__ void snd_atomic_write_init(snd_atomic_write_t *w) static __inline__ void snd_atomic_write_begin(snd_atomic_write_t *w) { - w->begin++; - wmb(); + __atomic_add_fetch(&w->begin, 1,__ATOMIC_SEQ_CST); } static __inline__ void snd_atomic_write_end(snd_atomic_write_t *w) { - wmb(); - w->end++; + __atomic_add_fetch(&w->end, 1, __ATOMIC_SEQ_CST); } static __inline__ void snd_atomic_read_init(snd_atomic_read_t *r, snd_atomic_write_t *w) -- 2.1.4

3 14

[alsa-devel] [PATCH v2 0/5] ASoC: rockchip: Fix audio on Veyron.
by Enric Balletbo i Serra 17 May '16

17 May '16

Hi all, This patch series adds support and fixes the audio support for Veyron devices. With these patches I'm able to playback from speakers and headphones, and record from the microphone on a Veyron Jerry Chromebook. Patches from 1/5 to 3/5 should go through the Mark Brown ASoC tree. Patches 4/5 and 5/5 should go through the Heiko Stuebner rockchip tree. Changes since v1: - Improve log messages trying to explain better the issues (suggested by Mark Brown) - Remove patches from John Keeping as are already cherry-picked. - https://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/commit/?h=fo… - https://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/commit/?h=fo… Enric Balletbo i Serra (5): ASoC: rockchip-max98090: Fix NULL pointer dereference while accessing to jack. ASoC: rockchip-max98090: Fix the Headset Mic route. ASoC: rockchip-max98090: Fix jack detection and event reporting. ARM: dts: rockchip: Add shared file for audio related nodes for veyron boards ARM: dts: rockchip: veyron: Add analog audio codecs. arch/arm/boot/dts/rk3288-veyron-analog-audio.dtsi | 102 ++++++++++++++++++++++ arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 1 + sound/soc/rockchip/rockchip_max98090.c | 65 ++++++++------ 3 files changed, 140 insertions(+), 28 deletions(-) create mode 100644 arch/arm/boot/dts/rk3288-veyron-analog-audio.dtsi -- 2.1.0

4 11

[alsa-devel] BUG since "ASoC: simple-card: Add pm callbacks to platform driver"
by Geert Uytterhoeven 17 May '16

17 May '16

Hi Peter, Mark, Liam, With today's sound-asoc/for-next, I'm seeing on r8a7791/koelsch and sh73a0/kzm9g: kernel BUG at drivers/base/regmap/regcache.c:347! Internal error: Oops - BUG: 0 [#1] SMP ARM Modules linked in: CPU: 0 PID: 20 Comm: kworker/0:1 Not tainted 4.6.0-koelsch-07135-g1481dd77fa7d01cb #2621 Hardware name: Generic R8A7791 (Flattened Device Tree) Workqueue: events soc_resume_deferred task: ef512100 ti: ef5a6000 task.ti: ef5a6000 PC is at regcache_sync+0xc/0x118 LR is at ak4642_resume+0x20/0x28 pc : [<c04932a4>] lr : [<c05bd34c>] psr: 60000153 sp : ef5a7ee0 ip : ee7ea62c fp : 00000008 r10: 00000000 r9 : ee7ebd0c r8 : ee7ebd18 r7 : ee7ebc10 r6 : ee7ebcb8 r5 : ee7ebd08 r4 : eefc5800 r3 : 00000000 r2 : eefc5814 r1 : 001c001b r0 : eefc5800 Flags: nZCv IRQs on FIQs off Mode SVC_32 ISA ARM Segment kernel Control: 30c5387d Table: 6eaee540 DAC: fffffffd Process kworker/0:1 (pid: 20, stack limit = 0xef5a6210) Stack: (0xef5a7ee0 to 0xef5a8000) 7ee0: eefc5600 c05ae878 ef588100 ee7ebd08 ef9bdf00 00000000 ef9c4400 c023341c 7f00: ef588100 ee7ebd08 ef588100 ef9bdf00 ef9bdf00 ef5a6000 ef9bdf24 c0e02100 7f20: ef588118 c0233ae0 ef512100 ef59ae00 00000000 ef588100 c0233838 00000000 7f40: 00000000 00000000 00000000 c0237b58 00000001 00000000 ef43b040 ef588100 7f60: 00000000 00000000 dead4ead ffffffff ffffffff ef5a7f74 ef5a7f74 00000000 7f80: 00000000 dead4ead ffffffff ffffffff ef5a7f90 ef5a7f90 ef5a7fac ef59ae00 7fa0: c0237a80 00000000 00000000 c0206b68 00000000 00000000 00000000 00000000 7fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 7fe0: 00000000 00000000 00000000 00000000 00000013 00000000 ef5a7ff4 00000000 [<c04932a4>] (regcache_sync) from [<ee7ebd08>] (0xee7ebd08) Code: c0978f0f e590312c e3530000 1a000000 (e7f001f2) I've bisected this to commit 7c3767115a04bc7aa87bdbd3352d1801d4bbeea4 Author: Peter Ujfalusi <peter.ujfalusi(a)ti.com> Date: Mon May 9 13:38:10 2016 +0300 ASoC: simple-card: Add pm callbacks to platform driver Set snd_soc_pm_ops for the pm ops to make sure that the ASoC level of PM operations are going to happen. This is needed to get suspend/resume working correctly when the audio is using simple-card. Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)ti.com> Signed-off-by: Mark Brown <broonie(a)kernel.org> Reverting it fixes the problem for me. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

2 3

[alsa-devel] [PATCH v2] ASoC: rsnd: open 31bit of SSICKR mask
by Kuninori Morimoto 17 May '16

17 May '16

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> SSICKR (Gen2) / BRGCKR (Gen3) 31bit mask should be opened, because BRGB (= for 48kHz) might select it. Special thanks Yokoyama-san Reported-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx(a)renesas.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- v1 -> v2 - removed #define DEBUG (^o^) sound/soc/sh/rcar/adg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sh/rcar/adg.c b/sound/soc/sh/rcar/adg.c index 606399d..0891014 100644 --- a/sound/soc/sh/rcar/adg.c +++ b/sound/soc/sh/rcar/adg.c @@ -522,7 +522,7 @@ static void rsnd_adg_get_clkout(struct rsnd_priv *priv, } } - rsnd_mod_bset(adg_mod, SSICKR, 0x00FF0000, ckr); + rsnd_mod_bset(adg_mod, SSICKR, 0x80FF0000, ckr); rsnd_mod_write(adg_mod, BRRA, rbga); rsnd_mod_write(adg_mod, BRRB, rbgb); -- 1.9.1

1 0

[alsa-devel] [PATCH] ASoC: rsnd: open 31bit of SSICKR mask
by Kuninori Morimoto 17 May '16

17 May '16

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> SSICKR (Gen2) / BRGCKR (Gen3) 31bit mask should be opened, because BRGB (= for 48kHz) might select it. Special thanks Yokoyama-san Reported-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx(a)renesas.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/sh/rcar/adg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/sh/rcar/adg.c b/sound/soc/sh/rcar/adg.c index 606399d..061deb7 100644 --- a/sound/soc/sh/rcar/adg.c +++ b/sound/soc/sh/rcar/adg.c @@ -7,6 +7,7 @@ * License. See the file "COPYING" in the main directory of this archive * for more details. */ +#define DEBUG #include <linux/clk-provider.h> #include "rsnd.h" @@ -522,7 +523,7 @@ static void rsnd_adg_get_clkout(struct rsnd_priv *priv, } } - rsnd_mod_bset(adg_mod, SSICKR, 0x00FF0000, ckr); + rsnd_mod_bset(adg_mod, SSICKR, 0x80FF0000, ckr); rsnd_mod_write(adg_mod, BRRA, rbga); rsnd_mod_write(adg_mod, BRRB, rbgb); -- 1.9.1

1 1