February 2016 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] fireworks: serialize transactions to update connections at bus reset
by Takashi Sakamoto 20 Feb '16

20 Feb '16

In IEC 61883-1, at bus-reset, applications can continue isochronous streaming by updating connections. In ALSA fireworks driver, the operation is executed in 'update' handler for bus driver. The connection resources are also changed in process contexts of PCM/MIDI applications. Therefore, bus-reset handling has race condition against connection. Current ALSA fireworks driver has a bug for the condition. This commit fixes the bug, by expand critical section with mutex. As a result, connection updating operation in bus-reset handler and connection changing operation in process context are serialized. Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- sound/firewire/fireworks/fireworks.c | 3 +++ sound/firewire/fireworks/fireworks_stream.c | 6 ++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c index d5b19bc..8f27b67 100644 --- a/sound/firewire/fireworks/fireworks.c +++ b/sound/firewire/fireworks/fireworks.c @@ -301,7 +301,10 @@ static void efw_update(struct fw_unit *unit) struct snd_efw *efw = dev_get_drvdata(&unit->device); snd_efw_transaction_bus_reset(efw->unit); + + mutex_lock(&efw->mutex); snd_efw_stream_update_duplex(efw); + mutex_unlock(&efw->mutex); } static void efw_remove(struct fw_unit *unit) diff --git a/sound/firewire/fireworks/fireworks_stream.c b/sound/firewire/fireworks/fireworks_stream.c index 968a40a..425db8d 100644 --- a/sound/firewire/fireworks/fireworks_stream.c +++ b/sound/firewire/fireworks/fireworks_stream.c @@ -313,12 +313,10 @@ void snd_efw_stream_stop_duplex(struct snd_efw *efw) void snd_efw_stream_update_duplex(struct snd_efw *efw) { - if ((cmp_connection_update(&efw->out_conn) < 0) || - (cmp_connection_update(&efw->in_conn) < 0)) { - mutex_lock(&efw->mutex); + if (cmp_connection_update(&efw->out_conn) < 0 || + cmp_connection_update(&efw->in_conn) < 0) { stop_stream(efw, &efw->rx_stream); stop_stream(efw, &efw->tx_stream); - mutex_unlock(&efw->mutex); } else { amdtp_stream_update(&efw->rx_stream); amdtp_stream_update(&efw->tx_stream); -- 2.5.0

2 2

[alsa-devel] [PATCH 0/4] ALSA: bebob: give up updating streams at bus reset
by Takashi Sakamoto 20 Feb '16

20 Feb '16

Hi, This patchset is to simplify codes of ALSA bebob driver by giving up updating streams at bus reset. DM1000/DM1100/DM1500 chipsets have a quirk to transfer packets with discontinuous value in 'dbc' field of CIP header. This is against packet streaming protocol (IEC 61883-1/6). In the specification, units should continue packet streaming during 1 seconds after bus reset. During this period, connections are updated. Else, the streaming stops. The discontinuity causes firewire-lib module (packet streaming layer) to stop streaming immediately. This is done far earlier than executing bus-reset handler. Therefore, updating streams at the bus-reset handler has no meaning. This patchset will have little impacts for userspace applications because most users won't update IEEE 1394 bus when playbacking/recording. And PCM substream recovery is still available. Regards Takashi Sakamoto (4): ALSA: bebob: simplify bus-reset handling ALSA: bebob: move mutex from function callee to callers ALSA: bebob: change type of substream counter from atomic_t to unsigned int ALSA: bebob: give up updating streams at bus reset handler sound/firewire/bebob/bebob.c | 21 ++++++++++---- sound/firewire/bebob/bebob.h | 5 +--- sound/firewire/bebob/bebob_midi.c | 16 +++++++--- sound/firewire/bebob/bebob_pcm.c | 28 +++++++++++++----- sound/firewire/bebob/bebob_stream.c | 58 +++---------------------------------- 5 files changed, 53 insertions(+), 75 deletions(-) -- 2.5.0

2 5

Re: [alsa-devel] Issues with ALSA:ice1724 sound cards on powerpc machines
by Julian Margetson 20 Feb '16

20 Feb '16

On 2/17/2016 2:29 PM, Julian Margetson wrote: > Hi > > Having an issue issue with ice1724 sound cards on powerpc motherboards. > Motherboards in question Acube Sam460ex . > The card appears as a valid device but there is no sound output on the > majority of boots of the computer. > Logs attached. > On the first set boot audio playback produced sound ok. > On the second set boot no sound was produce with audio playback > > > Regards > Julian Margetson > > > Issue also with A-Eon Cyrus powerpc motherboard .

1 0

[alsa-devel] [PATCH v6 0/2] ASoC: Add SPDIF support for Allwinner SoCs
by codekipper＠gmail.com 19 Feb '16

19 Feb '16

From: Marcus Cooper <codekipper(a)gmail.com> This patch set adds support for the Allwinner SPDIF transceiver. For now just the SPDIF transmitter has been tested on a Mele A2000(A10) and a Itead Ibox(A20). In order for this patch set to be functional we require an audio clock patch which will be delivered separately. For those that are interested I've pushed the patches here with all the required changes to get SPDIF audio out of the device. https://github.com/codekipper/linux-sunxi/commits/spdif_delivery Thanks in advance, CK --- Changes since v5: - fixed warning that had sneaked in.' Changes since v4: - corrected indentation issues - removed old macros - removed unnecessary enabling of apb clock Changes since v3: - removed code required for spdif capture - added disable/enable of apb clk to suspend/resume. - removed unnecessary dt checks in probe - fixed error conditions in probe/resume - modified pm_runtime functionality and confirmed that driver worked when PM was disabled. - removed .owner from platform driver - renamed bindings file Changes since v2: - removed sunxi-machine-spdif and replaced with simple audio card - removed untested compatibilities from device tree documentation - added pm_runtime and remove shutdown - removed pll2 as it's the parent of the spdif clock - rename clk to spdif_clk - removed enabling of mclk output - removed interrupts status being cleared as it's not being used - use default fifo settings for now - fixed alignments for wrapped lines Changes since v1: - Moved sunxi-machine-spdif.c to separate patch - replaced sunxi in naming scheme with sun4i in the sun4i-spdif driver. - split tx controller into separate enable/disable functions - moved setclk and setfmt functionality into hw params - added support for mono signals. - cleaned up probe clock set up. - removed all writes to transmit status registers. - removed of_id - removed power management code. - Added support for more rates. Marcus Cooper (2): dt-bindings: sunxi :add sun4i SPDIF transceiver ASoC: sunxi: Add support for the SPDIF block .../bindings/sound/sunxi,sun4i-spdif.txt | 39 ++ sound/soc/sunxi/Kconfig | 8 + sound/soc/sunxi/Makefile | 1 + sound/soc/sunxi/sun4i-spdif.c | 550 +++++++++++++++++++++ 4 files changed, 598 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt create mode 100644 sound/soc/sunxi/sun4i-spdif.c -- 2.7.1

3 6

[alsa-devel] [PATCH 0/2] ALSA: oxfw: implement retries for scs1x at transaction failure
by Takashi Sakamoto 19 Feb '16

19 Feb '16

Hi, Current ALSA oxfw driver has a TODO to retry IEEE 1394 asynchronous transactions when transaction failure occurs. This patchset is for it. Additionally, this patchset classifies reason of the failure and stop the retries to prevent from endless loop of scheduling work. Regards Takashi Sakamoto (2): ALSA: oxfw: retry MIDI transferring for scs1x at transaction failure ALSA: oxfw: discontinue MIDI substream for scs1x at transaction failure sound/firewire/oxfw/oxfw-scs1x.c | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) -- 2.5.0

2 11

[alsa-devel] [PATCH v7 0/9] ASoC: hdac_hdmi: Update to HDMI driver
by Subhransu S. Prusty 19 Feb '16

19 Feb '16

This is remaining patches of v6 and appended platform changes for enumerating HDMI codec Jeeja KP (1): ASoC: hdac_hdmi: Add PM support Ramesh Babu (1): ASoC: hdac_hdmi: Fix to keep codec power active during enumeration. Subhransu S. Prusty (6): ASoC: hdac_hdmi: Fix possible memory leak in hw_params ASoC: hdac_hdmi: Don't fail in dai startup to make userland happy ASoC: hdac_hdmi: Fix to reconfigure registers in runtime resume ASoC: hdac_hdmi: Fix to wait for D3 before powering off codec ASoC: Intel: Skylake: Fix possible memory corruption in codec dai dma params ASoC: Intel: Skylake: Add HDMI FE and BE cpu dais Vinod Koul (1): ASoC: Intel: Skylake: Add i915 enabling in skl probe sound/soc/codecs/hdac_hdmi.c | 178 +++++++++++++++++++++++++++++++------- sound/soc/intel/Kconfig | 1 + sound/soc/intel/skylake/skl-pcm.c | 84 ++++++++++++++++-- sound/soc/intel/skylake/skl.c | 51 +++++++++++ 4 files changed, 275 insertions(+), 39 deletions(-) -- 1.9.1

2 16

[alsa-devel] [PATCH 0/4] Add I2S/ADV7511 audio support for ARC AXS10x boards.
by Carlos Palminha 19 Feb '16

19 Feb '16

ARC AXS10x platforms consist of a mainboard with several peripherals. One of those peripherals is an HDMI output port controlled by ADV7511 transmitter. This patch set adds audio for the ADV7511 transmitter and I2S audio for the AXS10x platform. Jose Abreu (4): drm/i2c/adv7511: Add audio support ARC: axs10x: Update defconfigs so that audio is enabled ASoC: dwc: Add I2S HDMI audio support using custom platform ARC: axs10x: Update defconfigs so that I2S is enabled arch/arc/boot/dts/axs10x_mb.dtsi | 20 +- arch/arc/configs/axs101_defconfig | 4 + arch/arc/configs/axs103_defconfig | 6 + arch/arc/configs/axs103_smp_defconfig | 6 + drivers/gpu/drm/i2c/Kconfig | 8 + drivers/gpu/drm/i2c/Makefile | 2 + drivers/gpu/drm/i2c/adv7511.c | 1024 --------------------------------- drivers/gpu/drm/i2c/adv7511.h | 41 ++ drivers/gpu/drm/i2c/adv7511_audio.c | 310 ++++++++++ drivers/gpu/drm/i2c/adv7511_core.c | 1005 ++++++++++++++++++++++++++++++++ include/sound/soc-dai.h | 1 + sound/soc/dwc/Kconfig | 1 + sound/soc/dwc/Makefile | 4 +- sound/soc/dwc/designware_i2s.c | 139 ++++- sound/soc/dwc/designware_pcm.c | 264 +++++++++ sound/soc/dwc/designware_pcm.h | 21 + 16 files changed, 1813 insertions(+), 1043 deletions(-) delete mode 100644 drivers/gpu/drm/i2c/adv7511.c create mode 100644 drivers/gpu/drm/i2c/adv7511_audio.c create mode 100644 drivers/gpu/drm/i2c/adv7511_core.c create mode 100644 sound/soc/dwc/designware_pcm.c create mode 100644 sound/soc/dwc/designware_pcm.h -- 2.5.0

1 3

[alsa-devel] [RFC v2 0/6] sti: add audio interface to the hdmi driver
by Arnaud Pouliquen 19 Feb '16

19 Feb '16

V2: - patch: ALSA: pcm: add IEC958 channel status control helper - Return 1 instead of 0 in snd_pcm_iec958_put - Add .access field in control structure - I have kept condition on mutex for flexibility (but could be cleaned to force user to use a mutex) - patch: video: hdmi: add helper function for N and CTS - Duplicate function to have a separte treatment for coherent and non-coherent clcocks - Add ratio fiel for alternate CTS value - Clock frequency in Hz for TMDS and audio clocks - Add information concerning clocks and CTS calculation. V1: This RFC is the implementation of audio HDMI on sti platform based on generic hdmi-codec driver: https://patchwork.kernel.org/patch/7215271/ ("ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders") Arnaud Pouliquen (6): video: hdmi: add helper function for N and CTS ALSA: pcm: add IEC958 channel status control helper ASoC: core: add code to complete dai init after pcm creation drm: sti: Add ASoC generic hdmi codec support. ASoc: hdmi-codec: add IEC control. ARM: DT: b2120: add audio HDMI dai link in audio card arch/arm/boot/dts/stihxxx-b2120.dtsi | 15 ++- drivers/gpu/drm/sti/Kconfig | 1 + drivers/gpu/drm/sti/sti_hdmi.c | 248 ++++++++++++++++++++++++++++++++--- drivers/gpu/drm/sti/sti_hdmi.h | 10 ++ drivers/video/hdmi.c | 222 +++++++++++++++++++++++++++++++ include/linux/hdmi.h | 22 ++++ include/sound/hdmi-codec.h | 1 + include/sound/pcm_iec958.h | 16 +++ include/sound/soc-dai.h | 7 + sound/core/pcm_iec958.c | 99 ++++++++++++++ sound/soc/codecs/hdmi-codec.c | 59 +++++++-- sound/soc/soc-core.c | 14 ++ 12 files changed, 682 insertions(+), 32 deletions(-) -- 1.9.1

4 17

[alsa-devel] [PATCH] ALSA: hda - hdmi get jack from hda_jack_tbl when not dyn_pcm_assign
by libin.yang＠linux.intel.com 19 Feb '16

19 Feb '16

From: Libin Yang <libin.yang(a)linux.intel.com> On Intel platform, if !dyn_pcm_assign, spec->pcm_rec[].jack is not NULL even after snd_hda_jack_tbl_clear() is called to free snd_jack. This may cause access invalid memory when calling snd_jack_report. Signed-off-by: Libin Yang <libin.yang(a)linux.intel.com> --- sound/pci/hda/patch_hdmi.c | 30 ++++++++++++++++++++++++++---- 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index f4443b5..541986f 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -1956,6 +1956,29 @@ static bool hdmi_present_sense_via_verbs(struct hdmi_spec_per_pin *per_pin, return ret; } +static struct snd_jack *pin_idx_to_jack(struct hda_codec *codec, + struct hdmi_spec_per_pin *per_pin) +{ + struct hdmi_spec *spec = codec->spec; + struct snd_jack *jack = NULL; + struct hda_jack_tbl *jack_tbl; + + /* if !dyn_pcm_assign, get jack from hda_jack_tbl + * in !dyn_pcm_assign case, spec->pcm_rec[].jack is not + * NULL even after snd_hda_jack_tbl_clear() is called to + * free snd_jack. This may cause access invalid memory + * when calling snd_jack_report + */ + if (per_pin->pcm_idx >= 0 && spec->dyn_pcm_assign) + jack = spec->pcm_rec[per_pin->pcm_idx].jack; + else if (!spec->dyn_pcm_assign) { + jack_tbl = snd_hda_jack_tbl_get(codec, per_pin->pin_nid); + if (jack_tbl) + jack = jack_tbl->jack; + } + return jack; +} + /* update ELD and jack state via audio component */ static void sync_eld_via_acomp(struct hda_codec *codec, struct hdmi_spec_per_pin *per_pin) @@ -1989,11 +2012,10 @@ static void sync_eld_via_acomp(struct hda_codec *codec, /* pcm_idx >=0 before update_eld() means it is in monitor * disconnected event. Jack must be fetched before update_eld() */ - if (per_pin->pcm_idx >= 0) - jack = spec->pcm_rec[per_pin->pcm_idx].jack; + jack = pin_idx_to_jack(codec, per_pin); update_eld(codec, per_pin, eld); - if (jack == NULL && per_pin->pcm_idx >= 0) - jack = spec->pcm_rec[per_pin->pcm_idx].jack; + if (jack == NULL) + jack = pin_idx_to_jack(codec, per_pin); if (jack == NULL) goto unlock; snd_jack_report(jack, -- 1.9.1

2 1

Re: [alsa-devel] [pulseaudio-discuss] [PATCH 0/1] alsa: Make profiles' availability dynamic
by Raymond Yau 19 Feb '16

19 Feb '16

2016-2-18 下午5:38於 "Bob Ham" <bob.ham(a)collabora.com>寫道： > > Make ALSA profiles stick around and update their availability if the > HDMI ELD changes. This alters the presence of card profiles quite > dramatically. Specifically, the existing autogeneration of profiles > generates a large set of input/output mapping combinations and all of > these combinations are reported by the API, marked as unavailable. To > give an idea of the consequences, here is what pavucontrol looks like > with this patch: > > https://people.collabora.com/~rah/pavucontrol-unavailable-profiles.png > > Similarly, here is the output of "pactl list cards": > > https://people.collabora.com/~rah/pactl-list-cards-output.txt > AFAIK, 1) mono is not supported by hda-intel 2) those desktop with three jacks at rear panel need retasking input jacks to output jacks by changing control channel mode from 2ch to 6ch, you may need to add hook for alsa devices to change the channel mode in alsa HDA-Intel.conf 3) even HDMI codec support 8 channels, it still require your hdmi monitor support multi channels

1 0