February 2016 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] [PATCH] ASoC: nau8825: Modify power management and add interrupt wakeup
by John Hsu 25 Feb '16

25 Feb '16

Hi Mark, This patch has cancel and only submit enhance codec suspend and resume patch. Please review the following link for the patch. Many thanks. http://mailman.alsa-project.org/pipermail/alsa-devel/2016-January/102924.ht… [alsa-devel] [PATCH] ASoC: nau8825: fix interrupt fails and unstable after resume On 1/8/2016 9:14 PM, Mark Brown wrote: > On Fri, Jan 08, 2016 at 03:11:22PM +0800, John Hsu wrote: > >> 1. Enhance codec suspend and resume sequence 2. Add interrupt wakeup >> function >> > > If this is two or more separate changes you should be sending two or more separate patches. You also need a better changelog which describes what the patch is supposed to do, in what way is suspend and resume enhanced for example? > > >> +/** >> + * nau8825_init_wakeup - set wakeup capability for codec >> + * >> + * @codec: codec device component >> + * >> + * After this function done, codec can support system wakeup by button. >> + */ >> +int nau8825_init_wakeup(struct snd_soc_codec *codec) { >> + struct nau8825 *nau8825 = snd_soc_codec_get_drvdata(codec); >> + >> + device_init_wakeup(nau8825->dev, true); >> + >> + return 0; >> +} >> +EXPORT_SYMBOL_GPL(nau8825_init_wakeup); >> > > You need a bit more explanation as to what's going on here. Why is this not something the driver just does or if this should be done elsewhere why do we need the wrapper function? > > >> +int nau8825_irq_wakeup(struct snd_soc_codec *codec, int on) { >> + struct nau8825 *nau8825 = snd_soc_codec_get_drvdata(codec); >> > > Same thing here, this looks like an unclear interface. >

2 2

[alsa-devel] Headset doesn't work for HP EliteBook 755 G2
by Derick Eddington 25 Feb '16

25 Feb '16

Hi, first time here, following suggestion [1] to report non-working default configuration, which I found how to make work. I checked using the latest stable kernel 4.4.2 and my headset jack doesn't work by default but my fix does work, on Scientific Linux 7.2 using the 4.4.2 kernel from the ELRepo repository. I also checked using Ubuntu 16.04 alpha with its 4.4.0 kernel and the problem and fix are the same. My laptop is an HP EliteBook 755 G2 from mid 2015 [2] that has a combined headset (headphone + mic) jack that doesn't work by default. The speakers work fine by default and they mute when a headset is plugged in, but the headphones don't work. The snd-hda-intel module handles my device. The codec is Realtek ALC3228. I have the latest BIOS update from HP. I got it working by passing model=hp,headset-mic to snd-hda-intel. I found this fix in an alsa-user message about a different HP laptop with the same codec [3], but I had to modify the message's fix by only including the module option for model= and omitting the other options and aliases that seem to be specific to Arch Linux. I tried using only "hp" or only "headset-mic" as the value for model= but neither worked. Attached are my outputs of alsa-info.sh from before and after I did model=hp,headset-mic. Also, there's another problem after enabling model=hp,headset-mic, which I found how to fix: There is a very annoying squeaky background noise in the headphones that's independent of adjusting the volume level but it does stop when the headphones are muted. I tried a different headset and it's the same. I found how to suppress this by using the white_noise_fix.py script from [4] as described at [5,6], which apparently does some ioctl verbs to adjust the amp gain. I thought this might be something that should be fixed/adjusted in the kernel module(s) that handle this device, so that the white_noise_fix.py isn't needed. If so, maybe it's worth mentioning that when my laptop resumes from sleep, the background noise comes back, so I have to run white_noise_fix.py again. I'm willing to help investigate my hardware more or try other configurations or distros if requested. If it's worth mentioning, I found someone else with the same laptop who has the same non-working headset problem, see [7]. I'd like to help get this fixed in Ubuntu 16.04 before its release. If the proper fix is in the kernel ALSA, I'm willing to go through Ubuntu's process for asking them to incorporate it in 16.04. Apologies if I've misdirected this report. Thanks for your work on ALSA! -- Derick [1] linux-doc/sound/alsa/ALSA-Configuration.txt [2] Product number L9H51UT#ABA [3] https://sourceforge.net/p/alsa/mailman/message/33087916/ [4] http://xps13-9333.appspot.com/root/usr/local/bin/white_noise_fix.py [5] http://xps13-9333.appspot.com/#background_noise [6] http://askubuntu.com/questions/524344/noise-from-headphones [7] http://askubuntu.com/questions/714920/audio-card-alc3228-issue

2 3

[alsa-devel] [PATCH] hda-emu: add acpi_dev_present
by David Henningsson 25 Feb '16

25 Feb '16

Signed-off-by: David Henningsson <david.henningsson(a)canonical.com> --- include/acpi/acpi.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/acpi/acpi.h b/include/acpi/acpi.h index d7d6cb9..9fd9c86 100644 --- a/include/acpi/acpi.h +++ b/include/acpi/acpi.h @@ -33,4 +33,6 @@ acpi_get_devices(const char *HID, return user_function(NULL, 0, context, NULL); } +static inline bool acpi_dev_present(const char *hid) { return true; } + #endif /* __ACPI_H__ */ -- 1.9.1

2 1

[alsa-devel] [PATCH v2] ALSA: hda - Fixup speaker pass-through control for nid 0x14 on ALC225
by David Henningsson 25 Feb '16

25 Feb '16

On one of the machines we enable, we found that the actual speaker volume did not always correspond to the volume set in alsamixer. This patch fixes that problem. This patch was orginally written by Kailang @ Realtek, I've rebased it to fit sound git master. Cc: stable(a)vger.kernel.org BugLink: https://bugs.launchpad.net/bugs/1549660 Co-Authored-By: Kailang <kailang(a)realtek.com> Signed-off-by: David Henningsson <david.henningsson(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 72fa58d..7fded69 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -3801,6 +3801,10 @@ static void alc_headset_mode_mic_in(struct hda_codec *codec, hda_nid_t hp_pin, static void alc_headset_mode_default(struct hda_codec *codec) { + static struct coef_fw coef0225[] = { + UPDATE_COEF(0x45, 0x3f<<10, 0x34<<10), + {} + }; static struct coef_fw coef0255[] = { WRITE_COEF(0x45, 0xc089), WRITE_COEF(0x45, 0xc489), @@ -3842,6 +3846,9 @@ static void alc_headset_mode_default(struct hda_codec *codec) }; switch (codec->core.vendor_id) { + case 0x10ec0225: + alc_process_coef_fw(codec, coef0225); + break; case 0x10ec0255: case 0x10ec0256: alc_process_coef_fw(codec, coef0255); @@ -4750,6 +4757,7 @@ enum { ALC293_FIXUP_LENOVO_SPK_NOISE, ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY, ALC255_FIXUP_DELL_SPK_NOISE, + ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, }; static const struct hda_fixup alc269_fixups[] = { @@ -5375,6 +5383,17 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC255_FIXUP_DELL1_MIC_NO_PRESENCE }, + [ALC225_FIXUP_DELL1_MIC_NO_PRESENCE] = { + .type = HDA_FIXUP_VERBS, + .v.verbs = (const struct hda_verb[]) { + /* Disable pass-through path for FRONT 14h */ + { 0x20, AC_VERB_SET_COEF_INDEX, 0x36 }, + { 0x20, AC_VERB_SET_PROC_COEF, 0x57d7 }, + {} + }, + .chained = true, + .chain_id = ALC269_FIXUP_DELL1_MIC_NO_PRESENCE + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -5646,10 +5665,10 @@ static const struct hda_model_fixup alc269_fixup_models[] = { {0x21, 0x03211020} static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { - SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, + SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, ALC225_STANDARD_PINS, {0x14, 0x901701a0}), - SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, + SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, ALC225_STANDARD_PINS, {0x14, 0x901701b0}), SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE, -- 1.9.1

2 1

[alsa-devel] [PATCH] ALSA: hda - Fixup speaker pass-through control for nid 0x14 on ALC225
by David Henningsson 25 Feb '16

25 Feb '16

On one of the machines we enable, we found that the actual speaker volume did not always correspond to the volume set in alsamixer. This patch fixes that problem. This patch was orginally written by Kailang @ Realtek, I've rebased it to fit sound git master. BugLink: https://bugs.launchpad.net/bugs/1549660 Co-Authored-By: Kailang <kailang(a)realtek.com> Signed-off-by: David Henningsson <david.henningsson(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index efd4980..ab353b0 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -3801,6 +3801,10 @@ static void alc_headset_mode_mic_in(struct hda_codec *codec, hda_nid_t hp_pin, static void alc_headset_mode_default(struct hda_codec *codec) { + static struct coef_fw coef0225[] = { + UPDATE_COEF(0x45, 0x3f<<10, 0x34<<10), + {} + }; static struct coef_fw coef0255[] = { WRITE_COEF(0x45, 0xc089), WRITE_COEF(0x45, 0xc489), @@ -3842,6 +3846,9 @@ static void alc_headset_mode_default(struct hda_codec *codec) }; switch (codec->core.vendor_id) { + case 0x10ec0225: + alc_process_coef_fw(codec, coef0225); + break; case 0x10ec0255: case 0x10ec0256: alc_process_coef_fw(codec, coef0255); @@ -4749,6 +4756,7 @@ enum { ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE, ALC293_FIXUP_LENOVO_SPK_NOISE, ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY, + ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, }; static const struct hda_fixup alc269_fixups[] = { @@ -5368,6 +5376,17 @@ static const struct hda_fixup alc269_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = alc233_fixup_lenovo_line2_mic_hotkey, }, + [ALC225_FIXUP_DELL1_MIC_NO_PRESENCE] = { + .type = HDA_FIXUP_VERBS, + .v.verbs = (const struct hda_verb[]) { + /* Disable pass-through path for FRONT 14h */ + { 0x20, AC_VERB_SET_COEF_INDEX, 0x36 }, + { 0x20, AC_VERB_SET_PROC_COEF, 0x57d7 }, + {} + }, + .chained = true, + .chain_id = ALC269_FIXUP_DELL1_MIC_NO_PRESENCE + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -5638,10 +5657,10 @@ static const struct hda_model_fixup alc269_fixup_models[] = { {0x21, 0x03211020} static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { - SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, + SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, ALC225_STANDARD_PINS, {0x14, 0x901701a0}), - SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, + SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, ALC225_STANDARD_PINS, {0x14, 0x901701b0}), SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE, -- 1.9.1

2 2

[alsa-devel] [patch 1/2] ASoC: max9867: signedness bug in max9867_dai_hw_params()
by Dan Carpenter 25 Feb '16

25 Feb '16

"value" needs to be signed for the error handling to work. Fixes: 805d132dcbbd ('ASoC: Add max9867 codec driver') Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c index ab7a94d..4fb6fc7 100755 --- a/sound/soc/codecs/max9867.c +++ b/sound/soc/codecs/max9867.c @@ -180,7 +180,8 @@ static int max9867_dai_hw_params(struct snd_pcm_substream *substream, { struct snd_soc_codec *codec = dai->codec; struct max9867_priv *max9867 = snd_soc_codec_get_drvdata(codec); - unsigned int ni_h, ni_l, value; + unsigned int ni_h, ni_l; + int value; value = get_ni_value(max9867->sysclk, params_rate(params)); if (value < 0)

2 1

[alsa-devel] [PATCH] ALSA: hda - Fixing background noise on Dell Inspiron 3162
by Kai-Heng Feng 25 Feb '16

25 Feb '16

After login to the desktop on Dell Inspiron 3162, there's a very loud background noise comes from the builtin speaker. The noise does not go away even if the speaker is muted. The noise disappears after using the aamix fixup. Codec: Realtek ALC3234 Address: 0 AFG Function Id: 0x1 (unsol 1) Vendor Id: 0x10ec0255 Subsystem Id: 0x10280725 Revision Id: 0x100002 No Modem Function Group found BugLink: http://bugs.launchpad.net/bugs/1549620 Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index efd4980..72fa58d 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4749,6 +4749,7 @@ enum { ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE, ALC293_FIXUP_LENOVO_SPK_NOISE, ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY, + ALC255_FIXUP_DELL_SPK_NOISE, }; static const struct hda_fixup alc269_fixups[] = { @@ -5368,6 +5369,12 @@ static const struct hda_fixup alc269_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = alc233_fixup_lenovo_line2_mic_hotkey, }, + [ALC255_FIXUP_DELL_SPK_NOISE] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc_fixup_disable_aamix, + .chained = true, + .chain_id = ALC255_FIXUP_DELL1_MIC_NO_PRESENCE + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -5410,6 +5417,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x06df, "Dell", ALC293_FIXUP_DISABLE_AAMIX_MULTIJACK), SND_PCI_QUIRK(0x1028, 0x06e0, "Dell", ALC293_FIXUP_DISABLE_AAMIX_MULTIJACK), SND_PCI_QUIRK(0x1028, 0x0704, "Dell XPS 13", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE), + SND_PCI_QUIRK(0x1028, 0x0725, "Dell Inspiron 3162", ALC255_FIXUP_DELL_SPK_NOISE), SND_PCI_QUIRK(0x1028, 0x164a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x164b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2), -- 2.5.0

2 1

[alsa-devel] [PATCH 0/2 v2] ALSA: oxfw: implement retries for scs1x at transaction failure
by Takashi Sakamoto 25 Feb '16

25 Feb '16

Hi, This patchset updates my former post below. Changes are just adding my sign (I forgot it...) and improvements of commit messages. [alsa-devel] [PATCH 0/2] ALSA: oxfw: implement retries for scs1x at transaction failure http://mailman.alsa-project.org/pipermail/alsa-devel/2016-February/104579.h… In thread of the post, I got some comments about work to extend ALSA rawmidi core. I've investigated it in a few days ago and realized that it may not so light work, mainly because of a lack of unified state management[0]. In this development cycle, I'd like to give it up and use my time for the other work within my plan for the cycle. Please just apply these two patches. [0] In short, the state management is understandable for developers who can understand it, and I'm not. Regards Takashi Sakamoto (2): ALSA: oxfw: retry MIDI transferring for scs1x at transaction failure ALSA: oxfw: discontinue MIDI substream for scs1x at transaction failure sound/firewire/oxfw/oxfw-scs1x.c | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) -- 2.5.0

2 4

[alsa-devel] [PATCH] ASoC: arizona: Make logging of FLL calculations clearer
by Richard Fitzgerald 25 Feb '16

25 Feb '16

The debug logging of FLL calculations was confusing. Values were printed in hex without indicating this by a leading 0x, and despite these normally being required in decimal. Also where the register value isn't the actual value (it s a power-of-two or 0 means 1, 1 means 2, ...) it was unclear whether the actual or register value was shown. This patch changes the log print so that all mathematical values are shown in decimal, all register values are shown in hex with a 0x prefix, and where the register value isn't the actual integer value the decimal integer value is shown in () after the hex register value. Signed-off-by: Richard Fitzgerald <rf(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/arizona.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/arizona.c b/sound/soc/codecs/arizona.c index 913cfa8..92d22a0 100644 --- a/sound/soc/codecs/arizona.c +++ b/sound/soc/codecs/arizona.c @@ -2149,11 +2149,12 @@ static int arizona_calc_fll(struct arizona_fll *fll, return -EINVAL; } - arizona_fll_dbg(fll, "N=%x THETA=%x LAMBDA=%x\n", + arizona_fll_dbg(fll, "N=%d THETA=%d LAMBDA=%d\n", cfg->n, cfg->theta, cfg->lambda); - arizona_fll_dbg(fll, "FRATIO=%x(%d) OUTDIV=%x REFCLK_DIV=%x\n", - cfg->fratio, cfg->fratio, cfg->outdiv, cfg->refdiv); - arizona_fll_dbg(fll, "GAIN=%d\n", cfg->gain); + arizona_fll_dbg(fll, "FRATIO=0x%x(%d) OUTDIV=%d REFCLK_DIV=0x%x(%d)\n", + cfg->fratio, ratio, cfg->outdiv, + cfg->refdiv, 1 << cfg->refdiv); + arizona_fll_dbg(fll, "GAIN=0x%x(%d)\n", cfg->gain, 1 << cfg->gain); return 0; -- 1.9.1

2 4

Re: [alsa-devel] Fwd: Lenovo Y700-17ISK notebook - multiple issues
by Takashi Iwai 24 Feb '16

24 Feb '16

On Wed, 24 Feb 2016 19:00:36 +0100, Aljosa wrote: > > Hi Takashi, > thank you very much for your reply. > Notebook subwoofer doesn't work at all (it does not produce any sound). OK, could you give more details? Which kernel did you test? Did you test any model option? Also give alsa-info.sh output (run it with --no-upload option and attach the output). This contains the h/w details. Last but not least, don't drop Cc to ML. thanks, Takashi > Regards, Aljosa > > > > On 2016-02-24 16:35, Takashi Iwai wrote: > > On Tue, 23 Feb 2016 20:37:21 +0100, > > Aljosa wrote: > >> > >> Hello, > >> advised by one of the kernel developers - I'm reporting you the > >> problem > >> nr.2 from the below link. > > > > Could you describe what are the exact issues, instead of pointing some > > URL? > > > > > > thanks, > > > > Takashi >

1 0