December 2016 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] [PATCH] fix get_stop_threshold alsa-lib 0.9 alias
by Takashi Iwai 15 Dec '16

15 Dec '16

On Tue, 13 Dec 2016 13:54:26 +0100, Rene Rebe wrote: > > Hi there, > > resurrecting some decade old code I got some crashes and noticed a typo in > an old 0.9 legacy symver alias: > > Signed-off-by: René Rebe <rene(a)exactcode.com> A good catch, applied now. Thanks. Takashi > > --- alsa-lib-1.1.2/include/pcm_old.h.vanilla 2016-12-12 19:27:34.119596843 +0100 > +++ alsa-lib-1.1.2/include/pcm_old.h 2016-12-12 19:28:02.039596717 +0100 > @@ -206,7 +206,7 @@ > asm(".symver snd_pcm_sw_params_get_avail_min,snd_pcm_sw_params_get_avail_min(a)ALSA_0.9"); > asm(".symver snd_pcm_sw_params_get_xfer_align,snd_pcm_sw_params_get_xfer_align(a)ALSA_0.9"); > asm(".symver snd_pcm_sw_params_get_start_threshold,snd_pcm_sw_params_get_start_threshold(a)ALSA_0.9"); > -asm(".symver snd_pcm_sw_params_get_stop_threshold,snd_pcm_sw_params_set_stop_threshold(a)ALSA_0.9"); > +asm(".symver snd_pcm_sw_params_get_stop_threshold,snd_pcm_sw_params_get_stop_threshold(a)ALSA_0.9"); > asm(".symver snd_pcm_sw_params_get_silence_threshold,snd_pcm_sw_params_get_silence_threshold(a)ALSA_0.9"); > asm(".symver snd_pcm_sw_params_get_silence_size,snd_pcm_sw_params_get_silence_size(a)ALSA_0.9"); > > > -- > René Rebe, ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin > http://exactcode.com | http://t2-project.org | http://rene.rebe.de >

1 0

[alsa-devel] [PATCH 0/7] Add support for Legacy HDMI audio drivers
by Jerome Anand 15 Dec '16

15 Dec '16

Legacy (CherryTrail/ Baytrail) HDMI audio drivers added Legacy hdmi audio-Gfx interaction/ interfacing is updated to use irq chip framework Jerome Anand (7): drm/i915: setup bridge for HDMI LPE audio driver drm/i915: Add support for audio driver notifications ALSA: add shell for Intel HDMI LPE audio driver ALSA: x86: hdmi: Add audio support for BYT and CHT ALSA: x86: hdmi: Improve position reporting ALSA: x86: hdmi: Fixup some monitor ALSA: x86: hdmi: continue playback even when display resolution changes Documentation/gpu/i915.rst | 9 + drivers/gpu/drm/i915/Makefile | 3 + drivers/gpu/drm/i915/i915_drv.c | 8 +- drivers/gpu/drm/i915/i915_drv.h | 18 + drivers/gpu/drm/i915/i915_irq.c | 27 + drivers/gpu/drm/i915/i915_reg.h | 3 + drivers/gpu/drm/i915/intel_audio.c | 8 + drivers/gpu/drm/i915/intel_hdmi.c | 1 + drivers/gpu/drm/i915/intel_lpe_audio.c | 409 +++++++ include/drm/intel_lpe_audio.h | 46 + sound/Kconfig | 2 + sound/Makefile | 2 +- sound/x86/Kconfig | 16 + sound/x86/Makefile | 10 + sound/x86/intel_hdmi_audio.c | 1932 ++++++++++++++++++++++++++++++++ sound/x86/intel_hdmi_audio.h | 201 ++++ sound/x86/intel_hdmi_audio_if.c | 551 +++++++++ sound/x86/intel_hdmi_lpe_audio.c | 626 +++++++++++ sound/x86/intel_hdmi_lpe_audio.h | 692 ++++++++++++ 19 files changed, 4561 insertions(+), 3 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_lpe_audio.c create mode 100644 include/drm/intel_lpe_audio.h create mode 100644 sound/x86/Kconfig create mode 100644 sound/x86/Makefile create mode 100644 sound/x86/intel_hdmi_audio.c create mode 100644 sound/x86/intel_hdmi_audio.h create mode 100644 sound/x86/intel_hdmi_audio_if.c create mode 100644 sound/x86/intel_hdmi_lpe_audio.c create mode 100644 sound/x86/intel_hdmi_lpe_audio.h -- 2.9.3 base-commit: f6a248e2507f98d7eb1f4fec8cfcbf685a33d289

7 37

[alsa-devel] [PATCH 0/5] ASoC/arizona: Ensure pin searches use widget name prefix
by Richard Fitzgerald 15 Dec '16

15 Dec '16

The name of a codec pin can have an optional prefix string, which is defined by the audio machine driver. The snd_soc_dapm_x_pin functions take the fully-specified name including the prefix and so the existing code would fail to find the pin if the audio machine driver had added a prefix. This patch chain adds new helper functions that take a non-prefixed name for a specific ASoC component and internally add that component's prefix. The other patches update the arizona drivers to use these new functions. Richard Fitzgerald (5): ASoC: core: Add component pin control functions ASoC: arizona: Use component pin control functions regulator: arizona-micsupp: Use SoC component pin control functions extcon: arizona: Use SoC component pin control functions Input: arizona-haptics - Use SoC component pin control functions drivers/extcon/extcon-arizona.c | 8 +- drivers/input/misc/arizona-haptics.c | 13 ++- drivers/regulator/arizona-micsupp.c | 6 +- include/sound/soc.h | 25 +++++ sound/soc/codecs/arizona.c | 13 ++- sound/soc/codecs/cs47l24.c | 2 +- sound/soc/codecs/wm5102.c | 2 +- sound/soc/codecs/wm5110.c | 2 +- sound/soc/codecs/wm8998.c | 2 +- sound/soc/soc-utils.c | 199 +++++++++++++++++++++++++++++++++++ 10 files changed, 254 insertions(+), 18 deletions(-) -- 1.9.1

4 11

[alsa-devel] [PATCH] ASoC: add Component level pcm_new/pcm_free
by Kuninori Morimoto 15 Dec '16

15 Dec '16

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> In current ALSA SoC, Platform only has pcm_new/pcm_free feature, but it should be supported on Component level. This patch adds it. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- include/sound/soc.h | 6 ++++++ sound/soc/soc-core.c | 21 +++++++++++++++++++++ sound/soc/soc-pcm.c | 32 +++++++++++++++++++++++--------- 3 files changed, 50 insertions(+), 9 deletions(-) diff --git a/include/sound/soc.h b/include/sound/soc.h index 2b502f6..e580a67 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -785,6 +785,10 @@ struct snd_soc_component_driver { int (*suspend)(struct snd_soc_component *); int (*resume)(struct snd_soc_component *); + /* pcm creation and destruction */ + int (*pcm_new)(struct snd_soc_pcm_runtime *); + void (*pcm_free)(struct snd_pcm *); + /* DT */ int (*of_xlate_dai_name)(struct snd_soc_component *component, struct of_phandle_args *args, @@ -858,6 +862,8 @@ struct snd_soc_component { void (*remove)(struct snd_soc_component *); int (*suspend)(struct snd_soc_component *); int (*resume)(struct snd_soc_component *); + int (*pcm_new)(struct snd_soc_pcm_runtime *); + void (*pcm_free)(struct snd_pcm *); /* machine specific init */ int (*init)(struct snd_soc_component *component); diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index f1901bb..981443e 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -2976,6 +2976,8 @@ static int snd_soc_component_initialize(struct snd_soc_component *component, component->remove = component->driver->remove; component->suspend = component->driver->suspend; component->resume = component->driver->resume; + component->pcm_new = component->driver->pcm_new; + component->pcm_free= component->driver->pcm_free; dapm = &component->dapm; dapm->dev = dev; @@ -3158,6 +3160,21 @@ static void snd_soc_platform_drv_remove(struct snd_soc_component *component) platform->driver->remove(platform); } +static int snd_soc_platform_drv_pcm_new(struct snd_soc_pcm_runtime *rtd) +{ + struct snd_soc_platform *platform = rtd->platform; + + return platform->driver->pcm_new(rtd); +} + +static void snd_soc_platform_drv_pcm_free(struct snd_pcm *pcm) +{ + struct snd_soc_pcm_runtime *rtd = pcm->private_data; + struct snd_soc_platform *platform = rtd->platform; + + platform->driver->pcm_free(pcm); +} + /** * snd_soc_add_platform - Add a platform to the ASoC core * @dev: The parent device for the platform @@ -3181,6 +3198,10 @@ int snd_soc_add_platform(struct device *dev, struct snd_soc_platform *platform, platform->component.probe = snd_soc_platform_drv_probe; if (platform_drv->remove) platform->component.remove = snd_soc_platform_drv_remove; + if (platform_drv->pcm_new) + platform->component.pcm_new = snd_soc_platform_drv_pcm_new; + if (platform_drv->pcm_free) + platform->component.pcm_free = snd_soc_platform_drv_pcm_free; #ifdef CONFIG_DEBUG_FS platform->component.debugfs_prefix = "platform"; diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index e7a1eaa..a9ef8ae 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -2640,12 +2640,25 @@ static int dpcm_fe_dai_close(struct snd_pcm_substream *fe_substream) return ret; } +static void soc_pcm_free(struct snd_pcm *pcm) +{ + struct snd_soc_pcm_runtime *rtd = pcm->private_data; + struct snd_soc_component *component; + + list_for_each_entry(component, &rtd->card->component_dev_list, + card_list) { + if (component->pcm_free) + component->pcm_free(pcm); + } +} + /* create a new pcm */ int soc_new_pcm(struct snd_soc_pcm_runtime *rtd, int num) { struct snd_soc_platform *platform = rtd->platform; struct snd_soc_dai *codec_dai; struct snd_soc_dai *cpu_dai = rtd->cpu_dai; + struct snd_soc_component *component; struct snd_pcm *pcm; char new_name[64]; int ret = 0, playback = 0, capture = 0; @@ -2754,17 +2767,18 @@ int soc_new_pcm(struct snd_soc_pcm_runtime *rtd, int num) if (capture) snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &rtd->ops); - if (platform->driver->pcm_new) { - ret = platform->driver->pcm_new(rtd); - if (ret < 0) { - dev_err(platform->dev, - "ASoC: pcm constructor failed: %d\n", - ret); - return ret; + list_for_each_entry(component, &rtd->card->component_dev_list, card_list) { + if (component->pcm_new) { + ret = component->pcm_new(rtd); + if (ret < 0) { + dev_err(component->dev, + "ASoC: pcm constructor failed: %d\n", + ret); + return ret; + } } } - - pcm->private_free = platform->driver->pcm_free; + pcm->private_free = soc_pcm_free; out: dev_info(rtd->card->dev, "%s <-> %s mapping ok\n", (rtd->num_codecs > 1) ? "multicodec" : rtd->codec_dai->name, -- 1.9.1

2 1

[alsa-devel] [PATCH] ASoC: wm0010: Remove unneeded linux/miscdevice.h include
by Corentin Labbe 15 Dec '16

15 Dec '16

sound/soc/codecs/wm0010.c does not use any miscdevice so this patch remove this unnecessary inclusion. Signed-off-by: Corentin Labbe <clabbe.montjoie(a)gmail.com> --- sound/soc/codecs/wm0010.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c index 0eb5dcf..4f5f571 100644 --- a/sound/soc/codecs/wm0010.c +++ b/sound/soc/codecs/wm0010.c @@ -21,7 +21,6 @@ #include <linux/firmware.h> #include <linux/delay.h> #include <linux/fs.h> -#include <linux/miscdevice.h> #include <linux/gpio.h> #include <linux/regulator/consumer.h> #include <linux/mutex.h> -- 2.10.2

2 1

[alsa-devel] [PATCH 1/2] ASoC: rt5514-spi: Remove unneeded linux/miscdevice.h include
by Corentin Labbe 15 Dec '16

15 Dec '16

sound/soc/codecs/rt5514-spi.c does not use any miscdevice so this patch remove this unnecessary inclusion. Signed-off-by: Corentin Labbe <clabbe.montjoie(a)gmail.com> --- sound/soc/codecs/rt5514-spi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/rt5514-spi.c b/sound/soc/codecs/rt5514-spi.c index 0901e25..7ed62e8 100644 --- a/sound/soc/codecs/rt5514-spi.c +++ b/sound/soc/codecs/rt5514-spi.c @@ -21,7 +21,6 @@ #include <linux/gpio.h> #include <linux/sched.h> #include <linux/uaccess.h> -#include <linux/miscdevice.h> #include <linux/regulator/consumer.h> #include <linux/pm_qos.h> #include <linux/sysfs.h> -- 2.10.2

1 1

Re: [alsa-devel] [PATCH 0/7] Move dell-led to drivers/platform/x86
by Michał Kępień 15 Dec '16

15 Dec '16

> On 12 December 2016 at 01:13, <Mario.Limonciello(a)dell.com> wrote: > > > add Anthony Wong @ Canonical. > > > > I'm about to go on break and won't have access to hardware for a while. > > > > Anthony, > > > > Your team has this hardware more readily available than I do. Would you be > > able to have someone on the team verify this series? > > > Sorry, just back from vacation. > > Yes, we can test it here some time next week. That is great news, thanks! I will try to post a v2 of this patch series within the next few days, so hopefully it will be ready before you get around to testing. I will keep you in the loop. -- Best regards, Michał Kępień

1 0

[alsa-devel] [PATCH] ASoC: rsnd: don't double free kctrl
by Colin King 15 Dec '16

15 Dec '16

From: Colin Ian King <colin.king(a)canonical.com> On an error, snd_ctl_add already free's kctrl, so calling snd_ctl_free_one to free it again leads to a double free error. Fix this by removing the extraneous snd_ctl_free_one call. Issue found using static analysis with CoverityScan, CID 1372908 Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/soc/sh/rcar/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c index 4bd68de..99b5b08 100644 --- a/sound/soc/sh/rcar/core.c +++ b/sound/soc/sh/rcar/core.c @@ -1030,10 +1030,8 @@ static int __rsnd_kctrl_new(struct rsnd_mod *mod, return -ENOMEM; ret = snd_ctl_add(card, kctrl); - if (ret < 0) { - snd_ctl_free_one(kctrl); + if (ret < 0) return ret; - } cfg->update = update; cfg->card = card; -- 2.10.2

3 2

[alsa-devel] [PATCH 00/14] ASoC: Compile fixes with W=1
by Vinod Koul 15 Dec '16

15 Dec '16

We seem to have few warnings in ASoC (I have tried only one config today) when we compile with W=1. So this is first set to fix these warning, which predominantly are unused but initialized variables. Few instances actually helped remove a bit more code as well. Vinod Koul (14): ASoC: Intel: Skylake: remove unused 'ret' ASoC: Intel: sst: remove unused 'msg_high' ASoC: Intel: sst: remove unused 'ops' ASoC: topology: remove unused 'err' ASoC: hdac_hdmi: remove unused 'dai_map' ASoC: max98090: remove superflous check for 'micbias' ASoC: AMD: remove unused ‘dma_buffer’ ASoC: adau17x1: remove unused ‘ret’ ASoC: max9867: remove unused ‘ret’ ASoC: pcm3168a: remove unused ‘format’ ASoC: img: remove unused ‘format’ ASoC: Intel: sst: remove unused ‘ret_val’ ASoC: samsung: smdk_wm8580: remove unused ‘bfs’ ASoC: zx296702-i2s: remove unused ‘format’ sound/soc/amd/acp-pcm-dma.c | 3 --- sound/soc/codecs/adau17x1.c | 3 +-- sound/soc/codecs/hdac_hdmi.c | 5 ----- sound/soc/codecs/max98090.c | 2 +- sound/soc/codecs/max9867.c | 5 ++--- sound/soc/codecs/pcm3168a.c | 2 -- sound/soc/img/img-parallel-out.c | 2 -- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 4 ++-- sound/soc/intel/atom/sst/sst_ipc.c | 2 -- sound/soc/intel/atom/sst/sst_stream.c | 2 -- sound/soc/intel/skylake/skl-topology.c | 3 +-- sound/soc/samsung/smdk_wm8580.c | 5 +---- sound/soc/soc-topology.c | 4 ++-- sound/soc/zte/zx296702-i2s.c | 5 +---- 14 files changed, 11 insertions(+), 36 deletions(-) -- 1.9.1

4 25

[alsa-devel] [PATCH] ASoC: topology: kfree kcontrol->private_value before freeing kcontrol
by Colin King 15 Dec '16

15 Dec '16

From: Colin Ian King <colin.king(a)canonical.com> kcontrol->private_value is being kfree'd after kcontrol has been freed (in previous call to snd_ctl_remove). Instead, fix this by kfreeing the private_value before kcontrol. CoverityScan CID#1388311 "Read from pointer after free" Fixes: eea3dd4f1247a ("ASoC: topology: Only free TLV for volume mixers of a widget") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/soc/soc-topology.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index 11feb19..b5472e0 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -514,13 +514,12 @@ static void remove_widget(struct snd_soc_component *comp, == SND_SOC_TPLG_TYPE_MIXER) kfree(kcontrol->tlv.p); - snd_ctl_remove(card, kcontrol); - /* Private value is used as struct soc_mixer_control * for volume mixers or soc_bytes_ext for bytes * controls. */ kfree((void *)kcontrol->private_value); + snd_ctl_remove(card, kcontrol); } kfree(w->kcontrol_news); } -- 2.10.2

2 1