January 2016 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] Problem with commit 924eb47512 ("ASoC: dwc: fix dma stop transferring issue")
by Jon Medhurst (Tixy) 27 Jan '16

27 Jan '16

Hi In trying to work out why audio stopped working on ARM's Juno board I bisected the problem to $subject commit and reverting this fixed things. The symptoms of broken audio was that alsa-utils' speaker-test produced very short duration 'churps' rather than the voice sample naming each speaker channel. (Additional note, audio on Juno is routed through a HDMI transmitter and the patches to support that aren't in the mainline kernel tree.) Now, I don't have any documentation for the Designware I2S device so the following is my speculation from looking at the code and guessing what's going on... 1. $subject patch makes i2s_start() unmask interrupts for all four hardware channels. 2. i2s_stop masks interrupts for all four channels. 3. dw_i2s_hw_params unmasks interrupts for only the number of hardware channels as required for the specified audio stream format. So, playing stereo sound (one hardware channel) on my Juno board is going wrong because i2s_start() now unmasks interrupts for the other 3 unused hardware channels and these are immediately generating interrupts, making the code think the buffer has finished transmission (or underflowed, or something like that, remember I'm speculating here). Now, if audio playback/capture is always achieved by using this sequence of calls: dw_i2s_hw_params i2s_start i2s_stop then it seems to me that $subject patch is redundant and should be reverted. However, if this is allowed (possibly is, depends on how dw_i2s_trigger can be called) ... dw_i2s_hw_params i2s_start i2s_stop i2s_start i2s_stop then we need to change i2s_start to unmask interrupts for just the hardware channels being used. I can have a go at producing a patch for that if that's deemed the correct solution. (Looks like we'd need to stash the number of used hardware channels in struct dw_i2s_dev). -- Tixy

2 1

[alsa-devel] [PATCH] ASoC: pxa: pxa-ssp.c: indent with TABs, not spaces
by Antonio Ospite 27 Jan '16

27 Jan '16

Signed-off-by: Antonio Ospite <ao2(a)ao2.it> Cc: Daniel Mack <daniel(a)zonque.org> Cc: Mark Brown <broonie(a)kernel.org> --- sound/soc/pxa/pxa-ssp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/pxa/pxa-ssp.c b/sound/soc/pxa/pxa-ssp.c index da03fad..3caace4 100644 --- a/sound/soc/pxa/pxa-ssp.c +++ b/sound/soc/pxa/pxa-ssp.c @@ -586,7 +586,7 @@ static int pxa_ssp_hw_params(struct snd_pcm_substream *substream, switch (priv->dai_fmt & SND_SOC_DAIFMT_FORMAT_MASK) { case SND_SOC_DAIFMT_I2S: - sspsp = pxa_ssp_read_reg(ssp, SSPSP); + sspsp = pxa_ssp_read_reg(ssp, SSPSP); if ((pxa_ssp_get_scr(ssp) == 4) && (width == 16)) { /* This is a special case where the bitclk is 64fs -- 2.7.0

1 0

[alsa-devel] sound: WARNING in snd_rawmidi_transmit_ack
by Dmitry Vyukov 26 Jan '16

26 Jan '16

Hello, The following program triggers WARNING in snd_rawmidi_transmit_ack: ------------[ cut here ]------------ WARNING: CPU: 1 PID: 20739 at sound/core/rawmidi.c:1136 snd_rawmidi_transmit_ack+0x275/0x400() Modules linked in: CPU: 1 PID: 20739 Comm: syz-executor Tainted: G W 4.4.0+ #276 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 00000000ffffffff ffff8800346af8d8 ffffffff82999e2d 0000000000000000 ffff88002fea97c0 ffffffff86d3f920 ffff8800346af918 ffffffff81352089 ffffffff84f80bd5 ffffffff86d3f920 0000000000000470 ffff8800600b9b68 Call Trace: [< inline >] __dump_stack lib/dump_stack.c:15 [<ffffffff82999e2d>] dump_stack+0x6f/0xa2 lib/dump_stack.c:50 [<ffffffff81352089>] warn_slowpath_common+0xd9/0x140 kernel/panic.c:482 [<ffffffff813522b9>] warn_slowpath_null+0x29/0x30 kernel/panic.c:515 [<ffffffff84f80bd5>] snd_rawmidi_transmit_ack+0x275/0x400 sound/core/rawmidi.c:1136 [<ffffffff84fdb3c1>] snd_virmidi_output_trigger+0x4b1/0x5a0 sound/core/seq/seq_virmidi.c:163 [< inline >] snd_rawmidi_output_trigger sound/core/rawmidi.c:150 [<ffffffff84f87ed9>] snd_rawmidi_kernel_write1+0x549/0x780 sound/core/rawmidi.c:1223 [<ffffffff84f89fd3>] snd_rawmidi_write+0x543/0xb30 sound/core/rawmidi.c:1273 [<ffffffff817b0323>] __vfs_write+0x113/0x480 fs/read_write.c:528 [<ffffffff817b1db7>] vfs_write+0x167/0x4a0 fs/read_write.c:577 [< inline >] SYSC_write fs/read_write.c:624 [<ffffffff817b50a1>] SyS_write+0x111/0x220 fs/read_write.c:616 [<ffffffff86336c36>] entry_SYSCALL_64_fastpath+0x16/0x7a arch/x86/entry/entry_64.S:185 ---[ end trace 93509ba74cc3e259 ]--- // autogenerated by syzkaller (http://github.com/google/syzkaller) #include <pthread.h> #include <stdint.h> #include <string.h> #include <sys/syscall.h> #include <unistd.h> #include <fcntl.h> long r[11]; void* thr(void* arg) { switch ((long)arg) { case 0: r[0] = syscall(SYS_mmap, 0x20000000ul, 0x10000ul, 0x3ul, 0x32ul, 0xfffffffffffffffful, 0x0ul); break; case 1: r[1] = syscall(SYS_open, "/dev/dmmidi2", O_RDWR, 0); break; case 2: *(uint32_t*)0x20006fda = (uint32_t)0x28; *(uint32_t*)0x20006fde = (uint32_t)0x7; *(uint64_t*)0x20006fe2 = (uint64_t)0x0; *(uint64_t*)0x20006fea = (uint64_t)0x7; *(uint64_t*)0x20006ff2 = (uint64_t)0x8; *(uint16_t*)0x20006ffa = (uint16_t)0xfffffffffffffff8; r[8] = syscall(SYS_write, r[1], 0x20006fdaul, 0x28ul, 0, 0, 0); break; case 3: memcpy((void*)0x20007000, "\x3c\x3f\xbc\xd7\x07\xee\x01\x21\x84\x26\x11\x6d\xc6\xc3" "\xac\x7f\x14\xa3\x15\xda\xa1\x34\x67\xe9\xb6\xf8\xa8\xdd" "\xb5\xe0\x2a\x64\x6e\x04\x7c\x40\xdb\x64\x4f\x53\x41\x90" "\x02\x3b\x48\xba\xf6\xd7\x32\xe5\x11\x3f\xe5\xc5\xf2\x5f" "\x4e\x6f\x5b\xe9\x0e\x76\x1a\x72\x77\x68\xad\xd3\x1b\x8d" "\x8f\x71\x2f\x40\xde\xf4\xbf\x78\x48\xc2\xc3\xe5\xe9\x11" "\x11\xd2\x9a\x91\x94\x81\x57\x22\xef\x2a\x5b\xe2\x9e\xce" "\x3f\xa6\x07\x54\xd4\xb6\x1f\x30\xfd\x09\x35\x54\xcc\x78" "\x12\x37\x59\xf7\x5c\x51\xd2\x47\xb8\x40\x98\x2b\xb4\x8d" "\xbf\xd5\x34\x26\xcd\xb5\xe4\x98\x2d\x0e\xb1\x71\x0f\x12" "\x06\xb0\x2c\x78\x74\xba\x3d\x32\x9c\x72\x96\x0d\x91\x50" "\x9a\xe3\xbc\x4f\x1e\x26\xb2\xe3\xb2\xa2\x68\x6f\x10\xb5" "\xc1\x7f\xfc\xfd\xf0\xe6\xd9\x0c\xa0\xa7\x54\x2c\x62\x0d" "\xee\x04\x5b\x9d\x73\xf4\xcc\x29\x37\x01\xc2\x35\x8d\x3c" "\x8a\x2f\xe3\xf5\x55\x42\x77\x55\x2d\x49\x6f\x46\xf7\x34" "\xb1\x5f\xe7\x98\x55\xb5\x7c\x4e\xd7\x47\x18\xd1\xf9\xf2" "\xd2\xfe\x47\xff\x22\x04\xa9\x32\xe9\xd6\x28\xda\xe1\x85" "\xcb\xc5\xe6\xc1\xca\x9e\x3f\x1f\x80\xe6", 248); r[10] = syscall(SYS_write, r[1], 0x20007000ul, 0xf8ul, 0, 0, 0); break; } return 0; } int main() { long i; pthread_t th[4]; memset(r, -1, sizeof(r)); for (i = 0; i < 4; i++) { pthread_create(&th[i], 0, thr, (void*)i); usleep(10000); } for (i = 0; i < 4; i++) { pthread_create(&th[i], 0, thr, (void*)i); if (i % 2 == 0) usleep(10000); } usleep(100000); return 0; } On commit 30f05309bde49295e02e45c7e615f73aa4e0ccc2.

2 1

[alsa-devel] [PATCH] ASoC: imx-spdif: Fix crash on suspend
by Lars-Peter Clausen 26 Jan '16

26 Jan '16

When registering a ASoC card the driver data of the parent device is set to point to the card. This driver data is used in the snd_soc_suspend()/resume() callbacks. The imx-spdif driver overwrites the driver data with custom data which causes snd_soc_suspend() to crash. Since the custom driver is not used anywhere simply deleting the line which sets the custom driver data fixes the issue. Fixes: 43ac946922b3 ("ASoC: imx-spdif: add snd_soc_pm_ops for spdif machine driver") Tested-by: Fabio Estevam <fabio.estevam(a)nxp.com> Signed-off-by: Lars-Peter Clausen <lars(a)metafoo.de> --- sound/soc/fsl/imx-spdif.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/fsl/imx-spdif.c b/sound/soc/fsl/imx-spdif.c index a407e83..fb896b2 100644 --- a/sound/soc/fsl/imx-spdif.c +++ b/sound/soc/fsl/imx-spdif.c @@ -72,8 +72,6 @@ static int imx_spdif_audio_probe(struct platform_device *pdev) goto end; } - platform_set_drvdata(pdev, data); - end: of_node_put(spdif_np); -- 2.1.4

1 0

Re: [alsa-devel] [sound:for-next 5/5] sound/firewire/bebob/bebob_stream.c:57:3-14: code aligned with following code on line 58
by Julia Lawall 26 Jan '16

26 Jan '16

It looks like braces are missing here. julia On Tue, 26 Jan 2016, kbuild test robot wrote: > CC: kbuild-all(a)01.org > CC: alsa-devel(a)alsa-project.org > TO: Lucas Tanure <tanure(a)linux.com> > CC: Takashi Iwai <tiwai(a)suse.de> > CC: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next > head: a1d35f23965e7c0175ddecb1af0ae287c4e0aa23 > commit: a1d35f23965e7c0175ddecb1af0ae287c4e0aa23 [5/5] ALSA: bebob: Use a signed return type for get_formation_index > :::::: branch date: 3 hours ago > :::::: commit date: 3 hours ago > > >> sound/firewire/bebob/bebob_stream.c:57:3-14: code aligned with following code on line 58 > > git remote add sound https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git > git remote update sound > git checkout a1d35f23965e7c0175ddecb1af0ae287c4e0aa23 > vim +57 sound/firewire/bebob/bebob_stream.c > > a1d35f23 Lucas Tanure 2016-01-25 51 get_formation_index(unsigned int rate, unsigned int *index) > eb7b3a05 Takashi Sakamoto 2014-04-25 52 { > eb7b3a05 Takashi Sakamoto 2014-04-25 53 unsigned int i; > eb7b3a05 Takashi Sakamoto 2014-04-25 54 > eb7b3a05 Takashi Sakamoto 2014-04-25 55 for (i = 0; i < ARRAY_SIZE(snd_bebob_rate_table); i++) { > eb7b3a05 Takashi Sakamoto 2014-04-25 56 if (snd_bebob_rate_table[i] == rate) > a1d35f23 Lucas Tanure 2016-01-25 @57 *index = i; > a1d35f23 Lucas Tanure 2016-01-25 @58 return 0; > eb7b3a05 Takashi Sakamoto 2014-04-25 59 } > eb7b3a05 Takashi Sakamoto 2014-04-25 60 return -EINVAL; > eb7b3a05 Takashi Sakamoto 2014-04-25 61 } > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation >

4 3

[alsa-devel] Porting codec driver to DT
by Andreas Irestål 26 Jan '16

26 Jan '16

Hi! We're using the adau17x1 codecs in our products. They currently rely on platform_data to provide information such as mic bias voltage, jack detection and a few other hardware-specific parameters. As we want to move to DT while still having support for the old platform_data way of providing HW-specific information, this makes things a bit more complicated. There are a few enums declared in <linux/platform_data/adau17x1.h> which are used by the codec driver to distunguish between different configurations. I'd like to use/provide these values in my .dts-file as well, but that would mean either duplicating the definitions, or including DT-specific parts in platform_data or vice versa. What would the Proper (TM) way of implementing support for both be? I've peeked on other drivers but it hasn't helped a lot. At the moment I'm considering the solution of having a second set of definitions in the DT path with slightly different names, and then change the codec driver to use these definitions instead. If platform_data is provided, there'll be some translation logic at probing time. Any suggestions? /Andreas

1 0

[alsa-devel] [PATCH] ALSA: bebob: Use a signed return type for get_formation_index
by Lucas Tanure 26 Jan '16

26 Jan '16

The return type "unsigned int" was used by the get_formation_index function despite of the aspect that it will eventually return a negative error code. So, change to signed int and get index by reference in the parameters. Done with the help of Coccinelle. Signed-off-by: Lucas Tanure <tanure(a)linux.com> --- sound/firewire/bebob/bebob_stream.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/sound/firewire/bebob/bebob_stream.c b/sound/firewire/bebob/bebob_stream.c index 926e5dc..79940e3 100644 --- a/sound/firewire/bebob/bebob_stream.c +++ b/sound/firewire/bebob/bebob_stream.c @@ -47,14 +47,15 @@ static const unsigned int bridgeco_freq_table[] = { [6] = 0x07, }; -static unsigned int -get_formation_index(unsigned int rate) +static int +get_formation_index(unsigned int rate, unsigned int *index) { unsigned int i; for (i = 0; i < ARRAY_SIZE(snd_bebob_rate_table); i++) { if (snd_bebob_rate_table[i] == rate) - return i; + *index = i; + return 0; } return -EINVAL; } @@ -425,7 +426,9 @@ make_both_connections(struct snd_bebob *bebob, unsigned int rate) goto end; /* confirm params for both streams */ - index = get_formation_index(rate); + err = get_formation_index(rate, &index); + if (err < 0) + goto end; pcm_channels = bebob->tx_stream_formations[index].pcm; midi_channels = bebob->tx_stream_formations[index].midi; err = amdtp_am824_set_parameters(&bebob->tx_stream, rate, -- 2.7.0

3 2

[alsa-devel] sound: use-after-free in _snd_timer_stop
by Dmitry Vyukov 25 Jan '16

25 Jan '16

Hello, The following program causes use-after-free in _snd_timer_stop (if run in a parallel loop): // autogenerated by syzkaller (http://github.com/google/syzkaller) #include <pthread.h> #include <stdint.h> #include <stdlib.h> #include <string.h> #include <sys/syscall.h> #include <unistd.h> #include <sys/types.h> #include <sys/stat.h> #include <fcntl.h> long r[53]; void* thr(void* arg) { switch ((long)arg) { case 0: r[0] = syscall(SYS_mmap, 0x20000000ul, 0x65e000ul, 0x3ul, 0x32ul, 0xfffffffffffffffful, 0x0ul); break; case 1: r[11] = open("/dev/snd/timer", O_RDWR); break; case 2: *(uint32_t*)0x20653000 = (uint32_t)0x0; *(uint32_t*)0x20653004 = (uint32_t)0x2; *(uint32_t*)0x20653008 = (uint32_t)0x0; *(uint32_t*)0x2065300c = (uint32_t)0x0; *(uint32_t*)0x20653010 = (uint32_t)0x0; *(uint8_t*)0x20653014 = (uint8_t)0x0; *(uint8_t*)0x20653015 = (uint8_t)0x0; *(uint8_t*)0x20653016 = (uint8_t)0x0; *(uint8_t*)0x20653017 = (uint8_t)0x0; *(uint8_t*)0x20653018 = (uint8_t)0x0; *(uint8_t*)0x20653019 = (uint8_t)0x0; *(uint8_t*)0x2065301a = (uint8_t)0x0; *(uint8_t*)0x2065301b = (uint8_t)0x0; *(uint8_t*)0x2065301c = (uint8_t)0x0; *(uint8_t*)0x2065301d = (uint8_t)0x0; *(uint8_t*)0x2065301e = (uint8_t)0x0; *(uint8_t*)0x2065301f = (uint8_t)0x0; *(uint8_t*)0x20653020 = (uint8_t)0x0; *(uint8_t*)0x20653021 = (uint8_t)0x0; *(uint8_t*)0x20653022 = (uint8_t)0x0; *(uint8_t*)0x20653023 = (uint8_t)0x0; *(uint8_t*)0x20653024 = (uint8_t)0x0; *(uint8_t*)0x20653025 = (uint8_t)0x0; *(uint8_t*)0x20653026 = (uint8_t)0x0; *(uint8_t*)0x20653027 = (uint8_t)0x0; *(uint8_t*)0x20653028 = (uint8_t)0x0; *(uint8_t*)0x20653029 = (uint8_t)0x0; *(uint8_t*)0x2065302a = (uint8_t)0x0; *(uint8_t*)0x2065302b = (uint8_t)0x0; *(uint8_t*)0x2065302c = (uint8_t)0x0; *(uint8_t*)0x2065302d = (uint8_t)0x0; *(uint8_t*)0x2065302e = (uint8_t)0x0; *(uint8_t*)0x2065302f = (uint8_t)0x0; *(uint8_t*)0x20653030 = (uint8_t)0x0; *(uint8_t*)0x20653031 = (uint8_t)0x0; *(uint8_t*)0x20653032 = (uint8_t)0x0; *(uint8_t*)0x20653033 = (uint8_t)0x0; r[49] = syscall(SYS_ioctl, r[11], 0x40345410ul, 0x20653000ul, 0, 0, 0); break; case 3: r[50] = syscall(SYS_ioctl, r[11], 0x54a2ul, 0, 0, 0, 0); break; case 4: open("/dev/sequencer", O_RDWR); break; } return 0; } int main() { long i; pthread_t th[5]; srand(getpid()); memset(r, -1, sizeof(r)); for (i = 0; i < 5; i++) { pthread_create(&th[i], 0, thr, (void*)i); usleep(10000); } for (i = 0; i < 5; i++) { pthread_create(&th[i], 0, thr, (void*)i); if (rand()%2) usleep(rand()%10000); } usleep(100000); return 0; } BUG: KASAN: use-after-free in snd_timer_notify1+0x42b/0x460 at addr ffff8800331c88b8 Read of size 8 by task a.out/7186 ============================================================================= BUG kmalloc-256 (Tainted: G B W ): kasan: bad access detected ----------------------------------------------------------------------------- INFO: Allocated in snd_timer_instance_new+0x52/0x3a0 age=105 cpu=0 pid=7291 [< none >] ___slab_alloc+0x4c2/0x500 mm/slub.c:2470 [< none >] __slab_alloc+0x66/0xc0 mm/slub.c:2499 [< inline >] slab_alloc_node mm/slub.c:2562 [< inline >] slab_alloc mm/slub.c:2604 [< none >] kmem_cache_alloc_trace+0x27a/0x300 mm/slub.c:2621 [< inline >] kmalloc include/linux/slab.h:463 [< inline >] kzalloc include/linux/slab.h:607 [< none >] snd_timer_instance_new+0x52/0x3a0 sound/core/timer.c:106 [< none >] snd_timer_open+0xbb/0xd20 sound/core/timer.c:251 [< inline >] snd_timer_user_tselect sound/core/timer.c:1572 [< inline >] __snd_timer_user_ioctl sound/core/timer.c:1848 [< none >] snd_timer_user_ioctl+0x8db/0x25f0 sound/core/timer.c:1878 [< inline >] vfs_ioctl fs/ioctl.c:43 [< none >] do_vfs_ioctl+0x18c/0xfb0 fs/ioctl.c:674 [< inline >] SYSC_ioctl fs/ioctl.c:689 [< none >] SyS_ioctl+0x8f/0xc0 fs/ioctl.c:680 [< none >] entry_SYSCALL_64_fastpath+0x16/0x7a arch/x86/entry/entry_64.S:185 INFO: Freed in snd_timer_close+0x55d/0x750 age=10 cpu=0 pid=7333 [< none >] __slab_free+0x1fc/0x320 mm/slub.c:2680 [< inline >] slab_free mm/slub.c:2835 [< none >] kfree+0x2b7/0x2e0 mm/slub.c:3664 [< none >] snd_timer_close+0x55d/0x750 sound/core/timer.c:375 [< inline >] snd_timer_user_tselect sound/core/timer.c:1562 [< inline >] __snd_timer_user_ioctl sound/core/timer.c:1848 [< none >] snd_timer_user_ioctl+0x7b6/0x25f0 sound/core/timer.c:1878 [< inline >] vfs_ioctl fs/ioctl.c:43 [< none >] do_vfs_ioctl+0x18c/0xfb0 fs/ioctl.c:674 [< inline >] SYSC_ioctl fs/ioctl.c:689 [< none >] SyS_ioctl+0x8f/0xc0 fs/ioctl.c:680 [< none >] entry_SYSCALL_64_fastpath+0x16/0x7a arch/x86/entry/entry_64.S:185 INFO: Slab 0xffffea0000cc7200 objects=22 used=16 fp=0xffff8800331cbbb8 flags=0x1fffc0000004080 INFO: Object 0xffff8800331c8888 @offset=2184 fp=0xffff8800331c9998 CPU: 2 PID: 7186 Comm: a.out Tainted: G B W 4.5.0-rc1+ #283 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 00000000ffffffff ffff88003372f700 ffffffff8299a06d ffff88003e807000 ffff8800331c8888 ffff8800331c8000 ffff88003372f730 ffffffff81752854 ffff88003e807000 ffffea0000cc7200 ffff8800331c8888 ffff88003372f878 Call Trace: [< inline >] kasan_report mm/kasan/report.c:274 [<ffffffff8175befe>] __asan_report_load8_noabort+0x3e/0x40 mm/kasan/report.c:295 [<ffffffff84f5ea5b>] snd_timer_notify1+0x42b/0x460 sound/core/timer.c:424 [<ffffffff84f5ed52>] _snd_timer_stop+0x2c2/0x670 sound/core/timer.c:537 [<ffffffff84f5f122>] snd_timer_stop+0x22/0x140 sound/core/timer.c:552 [<ffffffff84fdf617>] snd_seq_timer_close+0x77/0x130 sound/core/seq/seq_timer.c:311 [<ffffffff84fd834e>] queue_delete+0x4e/0xb0 sound/core/seq/seq_queue.c:147 [<ffffffff84fd85bc>] snd_seq_queue_delete+0x3c/0x60 sound/core/seq/seq_queue.c:213 [<ffffffff84fcd84a>] snd_seq_ioctl_delete_queue+0xca/0x120 sound/core/seq/seq_clientmgr.c:1569 [<ffffffff84fcf4ad>] snd_seq_do_ioctl+0x19d/0x1c0 sound/core/seq/seq_clientmgr.c:2209 [<ffffffff84fd0ecb>] snd_seq_kernel_client_ctl+0xdb/0x170 sound/core/seq/seq_clientmgr.c:2423 [<ffffffff84fe7e19>] delete_seq_queue.part.3+0x99/0xf0 sound/core/seq/oss/seq_oss_init.c:389 [< inline >] delete_seq_queue sound/core/seq/oss/seq_oss_init.c:385 [<ffffffff84fe8c3b>] snd_seq_oss_release+0xfb/0x130 sound/core/seq/oss/seq_oss_init.c:434 [<ffffffff84fe724a>] odev_release+0x5a/0x80 sound/core/seq/oss/seq_oss.c:155 [<ffffffff817b2376>] __fput+0x236/0x780 fs/file_table.c:208 [<ffffffff817b2945>] ____fput+0x15/0x20 fs/file_table.c:244 [<ffffffff813ad760>] task_work_run+0x170/0x210 kernel/task_work.c:115 [< inline >] exit_task_work include/linux/task_work.h:21 [<ffffffff81358da5>] do_exit+0x8b5/0x2c60 kernel/exit.c:748 [<ffffffff8135b2c8>] do_group_exit+0x108/0x330 kernel/exit.c:878 [< inline >] SYSC_exit_group kernel/exit.c:889 [<ffffffff8135b50d>] SyS_exit_group+0x1d/0x20 kernel/exit.c:887 [<ffffffff86359636>] entry_SYSCALL_64_fastpath+0x16/0x7a arch/x86/entry/entry_64.S:185 ================================================================== 181.377203] ------------[ cut here ]------------ WARNING: CPU: 1 PID: 29599 at lib/list_debug.c:68 __list_del_entry+0x14c/0x1e0() list_del corruption. prev->next should be ffff88006346f690, but was ffff8800351ebc40 Modules linked in: CPU: 1 PID: 29599 Comm: a.out Not tainted 4.5.0-rc1+ #283 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 00000000ffffffff ffff88003437fa78 ffffffff8299a06d ffff88003437fae8 ffff880034208000 ffffffff866fd220 ffff88003437fab8 ffffffff8134fcf9 ffffffff82a0187c ffffed000686ff59 ffffffff866fd220 0000000000000044 Call Trace: [< inline >] __dump_stack lib/dump_stack.c:15 [<ffffffff8299a06d>] dump_stack+0x6f/0xa2 lib/dump_stack.c:50 [<ffffffff8134fcf9>] warn_slowpath_common+0xd9/0x140 kernel/panic.c:482 [<ffffffff8134fe09>] warn_slowpath_fmt+0xa9/0xd0 kernel/panic.c:494 [<ffffffff82a0187c>] __list_del_entry+0x14c/0x1e0 lib/list_debug.c:66 [< inline >] list_del_init include/linux/list.h:156 [<ffffffff84f5edf6>] _snd_timer_stop+0x366/0x670 sound/core/timer.c:507 [<ffffffff84f5f122>] snd_timer_stop+0x22/0x140 sound/core/timer.c:552 [<ffffffff84f5f273>] snd_timer_close+0x33/0x750 sound/core/timer.c:322 [<ffffffff84f5fa27>] snd_timer_user_release+0x97/0x130 sound/core/timer.c:1322 [<ffffffff817b2376>] __fput+0x236/0x780 fs/file_table.c:208 [<ffffffff817b2945>] ____fput+0x15/0x20 fs/file_table.c:244 [<ffffffff813ad760>] task_work_run+0x170/0x210 kernel/task_work.c:115 [< inline >] exit_task_work include/linux/task_work.h:21 [<ffffffff81358da5>] do_exit+0x8b5/0x2c60 kernel/exit.c:748 [<ffffffff8135b2c8>] do_group_exit+0x108/0x330 kernel/exit.c:878 [< inline >] SYSC_exit_group kernel/exit.c:889 [<ffffffff8135b50d>] SyS_exit_group+0x1d/0x20 kernel/exit.c:887 [<ffffffff86359636>] entry_SYSCALL_64_fastpath+0x16/0x7a arch/x86/entry/entry_64.S:185 ---[ end trace e005332b84fa3a56 ]--- ================================================================== Later the machine usually hangs. On commit 92e963f50fc74041b5e9e744c330dca48e04f08d

1 0

[alsa-devel] [RFC 0/2] ASoC: img: Add Pistachio card support
by Damien Horsley 25 Jan '16

25 Jan '16

From: "Damien.Horsley" <Damien.Horsley(a)imgtec.com> This patch set provides an initial implementation of a card driver suitable for all boards that use the Pistachio SoC The Pistachio SoC contains the following audio components: Controllers - SPDIF out, SPDIF in, parallel out, I2S out, I2S in Codecs - Internal DAC (connected to parallel out) Clocks - Audio PLL, dividers, gates, codec system clocks There are a number of boards that use the Pistachio SoC. The following can vary from board to board: - Which audio interfaces are usable on the board - The I2S codecs used (including multicodec paths on some boards) - The use of the two system clocks by the I2S codecs - Other external audio components present on the board - I2S clock loopback - I2S formats - Sample rates For some boards, a single system clock is used by components on both the I2S out and I2S in paths. This creates two dependacy issues that require further review as follows: - The information required to control the system clock rate(s) in response to a sample rate change cannot be specified as a single frequency, or as a single fs-ratio. Instead, the Pistachio card driver must store sufficient information to derive acceptable system clock rate(s) for any usable combination of {I2S out sample rate, I2S in sample rate} In this revision, the information is specified as a per-codec list of fs-rates, accompanied by min/max frequencies. This specification is sufficient for the codecs used so far, but this likely needs to change to support a greater range of codecs. - In order for the Pistachio card driver to establish usable system clock rate(s) for a given combination of {I2S out sample rate, I2S in sample rate}, the card driver must be made aware of both of the sample rate requirements in advance of either of the streams starting, as system clock rates cannot typically be changed when a codec is actively playing/recording. For this revision of the Pistachio card driver, a control has been used to specify these rates in advance. Calls to hw_params that require a system clock to change rate when another stream is already using the clock fail with -EBUSY. Damien.Horsley (2): ASoC: img: Add binding document for Pistachio audio card ASoC: img: Add driver for Pistachio audio card .../bindings/sound/img,pistachio-audio.txt | 308 +++ include/dt-bindings/sound/pistachio-audio.h | 7 + sound/soc/img/Kconfig | 10 + sound/soc/img/Makefile | 1 + sound/soc/img/pistachio.c | 2249 ++++++++++++++++++++ 5 files changed, 2575 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/img,pistachio-audio.txt create mode 100644 include/dt-bindings/sound/pistachio-audio.h create mode 100644 sound/soc/img/pistachio.c -- 2.1.4

1 2

[alsa-devel] [PATCH 1/2] ALSA: seq: Fix incorrect sanity check at snd_seq_oss_synth_cleanup()
by Takashi Iwai 25 Jan '16

25 Jan '16

ALSA sequencer OSS emulation code has a sanity check for currently opened devices, but there is a thinko there, eventually it spews warnings and skips the operation wrongly like: WARNING: CPU: 1 PID: 7573 at sound/core/seq/oss/seq_oss_synth.c:311 Fix this off-by-one error. Reported-by: Dmitry Vyukov <dvyukov(a)google.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/seq/oss/seq_oss_synth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/seq/oss/seq_oss_synth.c b/sound/core/seq/oss/seq_oss_synth.c index 0f3b38184fe5..b16dbef04174 100644 --- a/sound/core/seq/oss/seq_oss_synth.c +++ b/sound/core/seq/oss/seq_oss_synth.c @@ -308,7 +308,7 @@ snd_seq_oss_synth_cleanup(struct seq_oss_devinfo *dp) struct seq_oss_synth *rec; struct seq_oss_synthinfo *info; - if (snd_BUG_ON(dp->max_synthdev >= SNDRV_SEQ_OSS_MAX_SYNTH_DEVS)) + if (snd_BUG_ON(dp->max_synthdev > SNDRV_SEQ_OSS_MAX_SYNTH_DEVS)) return; for (i = 0; i < dp->max_synthdev; i++) { info = &dp->synths[i]; -- 2.7.0

1 1