July 2015 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: sti-sas: fix platform_no_drv_owner.cocci warnings
by kbuild test robot 13 Jul '15

13 Jul '15

sound/soc/codecs/sti-sas.c:616:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Arnaud Pouliquen <arnaud.pouliquen(a)st.com> Signed-off-by: Fengguang Wu <fengguang.wu(a)intel.com> --- sti-sas.c | 1 - 1 file changed, 1 deletion(-) --- a/sound/soc/codecs/sti-sas.c +++ b/sound/soc/codecs/sti-sas.c @@ -613,7 +613,6 @@ static int sti_sas_driver_remove(struct static struct platform_driver sti_sas_platform_driver = { .driver = { .name = "sti-sas-codec", - .owner = THIS_MODULE, .of_match_table = sti_sas_dev_match, }, .probe = sti_sas_driver_probe,

2 1

[alsa-devel] Applied "ASoC: zx: i2s: Fix devm_ioremap_resource return value check" to the asoc tree
by Mark Brown 13 Jul '15

13 Jul '15

The patch ASoC: zx: i2s: Fix devm_ioremap_resource return value check has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From a18da49ff3ec849c4584ae3abe2b83ff50705ace Mon Sep 17 00:00:00 2001 From: Krzysztof Kozlowski <k.kozlowski.k(a)gmail.com> Date: Thu, 9 Jul 2015 22:19:28 +0900 Subject: [PATCH] ASoC: zx: i2s: Fix devm_ioremap_resource return value check Value returned by devm_ioremap_resource() was checked for non-NULL but devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of error this could lead to dereference of ERR_PTR. Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k(a)gmail.com> Reviewed-by: Jun Nie <jun.nie(a)linaro.org> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/zte/zx296702-i2s.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/zte/zx296702-i2s.c b/sound/soc/zte/zx296702-i2s.c index 98d96e1b17e0..1930c42e1f55 100644 --- a/sound/soc/zte/zx296702-i2s.c +++ b/sound/soc/zte/zx296702-i2s.c @@ -393,9 +393,9 @@ static int zx_i2s_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); zx_i2s->mapbase = res->start; zx_i2s->reg_base = devm_ioremap_resource(&pdev->dev, res); - if (!zx_i2s->reg_base) { + if (IS_ERR(zx_i2s->reg_base)) { dev_err(&pdev->dev, "ioremap failed!\n"); - return -EIO; + return PTR_ERR(zx_i2s->reg_base); } writel_relaxed(0, zx_i2s->reg_base + ZX_I2S_FIFO_CTRL); -- 2.1.4

1 0

[alsa-devel] Applied "ASoC: zx: spdif: Fix devm_ioremap_resource return value check" to the asoc tree
by Mark Brown 13 Jul '15

13 Jul '15

The patch ASoC: zx: spdif: Fix devm_ioremap_resource return value check has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 2dfbe9afcda3243dd309826cbbb8ae9e9f602006 Mon Sep 17 00:00:00 2001 From: Krzysztof Kozlowski <k.kozlowski.k(a)gmail.com> Date: Thu, 9 Jul 2015 22:19:29 +0900 Subject: [PATCH] ASoC: zx: spdif: Fix devm_ioremap_resource return value check Value returned by devm_ioremap_resource() was checked for non-NULL but devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of error this could lead to dereference of ERR_PTR. Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k(a)gmail.com> Reviewed-by: Jun Nie <jun.nie(a)linaro.org> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/zte/zx296702-spdif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/zte/zx296702-spdif.c b/sound/soc/zte/zx296702-spdif.c index 11a0e46a1156..26265ce4caca 100644 --- a/sound/soc/zte/zx296702-spdif.c +++ b/sound/soc/zte/zx296702-spdif.c @@ -322,9 +322,9 @@ static int zx_spdif_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); zx_spdif->mapbase = res->start; zx_spdif->reg_base = devm_ioremap_resource(&pdev->dev, res); - if (!zx_spdif->reg_base) { + if (IS_ERR(zx_spdif->reg_base)) { dev_err(&pdev->dev, "ioremap failed!\n"); - return -EIO; + return PTR_ERR(zx_spdif->reg_base); } zx_spdif_dev_init(zx_spdif->reg_base); -- 2.1.4

1 0

[alsa-devel] [PATCH 1/3] ASoC: max98357a: Make 'sdmode-gpios' dts property optional
by Anatol Pomozov 12 Jul '15

12 Jul '15

The option is not needed if chip is always on or managed by some other part of system like platform card driver. Signed-off-by: Anatol Pomozov <anatol.pomozov(a)gmail.com> --- Documentation/devicetree/bindings/sound/max98357a.txt | 6 +++++- sound/soc/codecs/max98357a.c | 5 ++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/max98357a.txt b/Documentation/devicetree/bindings/sound/max98357a.txt index a7a149a..28645a2 100644 --- a/Documentation/devicetree/bindings/sound/max98357a.txt +++ b/Documentation/devicetree/bindings/sound/max98357a.txt @@ -4,7 +4,11 @@ This node models the Maxim MAX98357A DAC. Required properties: - compatible : "maxim,max98357a" -- sdmode-gpios : GPIO specifier for the GPIO -> DAC SDMODE pin + +Optional properties: +- sdmode-gpios : GPIO specifier for the chip's SD_MODE pin. + If this option is not specified then driver does not manage + the pin state (e.g. chip is always on). Example: diff --git a/sound/soc/codecs/max98357a.c b/sound/soc/codecs/max98357a.c index 3a2fda0..6d4246a 100644 --- a/sound/soc/codecs/max98357a.c +++ b/sound/soc/codecs/max98357a.c @@ -31,6 +31,9 @@ static int max98357a_daiops_trigger(struct snd_pcm_substream *substream, { struct gpio_desc *sdmode = snd_soc_dai_get_drvdata(dai); + if (!sdmode) + return 0; + switch (cmd) { case SNDRV_PCM_TRIGGER_START: case SNDRV_PCM_TRIGGER_RESUME: @@ -61,7 +64,7 @@ static int max98357a_codec_probe(struct snd_soc_codec *codec) struct gpio_desc *sdmode; sdmode = devm_gpiod_get(codec->dev, "sdmode", GPIOD_OUT_LOW); - if (IS_ERR(sdmode)) { + if (IS_ERR(sdmode) && (PTR_ERR(sdmode) != -ENOENT)) { dev_err(codec->dev, "%s() unable to get sdmode GPIO: %ld\n", __func__, PTR_ERR(sdmode)); return PTR_ERR(sdmode); -- 2.4.5

2 5

[alsa-devel] When select 2.1 profile in pulseaudio, how do pulseaudio select notebook 's internal subwoofer or 5.1 external speaker ?
by Raymond Yau 12 Jul '15

12 Jul '15

> > > > Are you sure that it is alsa driver bug since pulseaudio seem not using > > line out jack to mute internal speakers ? > > No, I'm not. I set all my jacks to line out and it works now. > Do pulseaudio 2.1 profile select the internal subwoofer or your 5.1 external speaker ? diff --git a/sound/pci/hda/hda_auto_parser.c b/sound/pci/hda/hda_auto_parser.c index 03b7399..c9e45e7 100644 @@ -952,6 +960,7 @@ void snd_hda_pick_fixup(struct hda_codec *codec, const struct snd_pci_quirk *q; int id = HDA_FIXUP_ID_NOT_SET; const char *name = NULL; + int i; if (codec->fixup_id != HDA_FIXUP_ID_NOT_SET) return; @@ -966,6 +975,9 @@ void snd_hda_pick_fixup(struct hda_codec *codec, return; } + if (!snd_hda_get_int_hint(codec, "alt_config", &i)) + codec->alt_config = i; + if (codec->modelname && models) { while (models->name) { if (!strcmp(codec->modelname, models->name)) { diff --git a/sound/pci/hda/hda_codec.h b/sound/pci/hda/hda_codec.h index 12837ab..38841db 100644 --- a/sound/pci/hda/hda_codec.h +++ b/sound/pci/hda/hda_codec.h @@ -283,6 +283,8 @@ struct hda_codec { /* additional init verbs */ struct snd_array verbs; + int alt_config; + int combo_jack; }; #define dev_to_hda_codec(_dev) container_of(_dev, struct hda_codec, core.dev) diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c index ac0db16..12ee7f7 100644 --- a/sound/pci/hda/hda_generic.c +++ b/sound/pci/hda/hda_generic.c @@ -39,7 +39,6 @@ #include "hda_beep.h" #include "hda_generic.h" - /** * snd_hda_gen_spec_init - initialize hda_gen_spec struct * @spec: hda_gen_spec object to initialize @@ -180,10 +179,10 @@ static void parse_user_hints(struct hda_codec *codec) /* the following two are just for compatibility */ val = snd_hda_get_bool_hint(codec, "add_out_jack_modes"); if (val >= 0) - spec->add_jack_modes = !!val; + spec->add_out_jack_modes = !!val; val = snd_hda_get_bool_hint(codec, "add_in_jack_modes"); if (val >= 0) - spec->add_jack_modes = !!val; + spec->add_in_jack_modes = !!val; val = snd_hda_get_bool_hint(codec, "add_jack_modes"); if (val >= 0) spec->add_jack_modes = !!val; @@ -2648,7 +2720,7 @@ static void get_jack_mode_name(struct hda_codec *codec, hda_nid_t pin, static int get_out_jack_num_items(struct hda_codec *codec, hda_nid_t pin) { struct hda_gen_spec *spec = codec->spec; - if (spec->add_jack_modes) { + if (spec->add_jack_modes || spec->add_out_jack_modes) { unsigned int pincap = snd_hda_query_pin_caps(codec, pin); if ((pincap & AC_PINCAP_OUT) && (pincap & AC_PINCAP_HP_DRV)) return 2; @@ -2791,7 +2863,7 @@ static int get_in_jack_num_items(struct hda_codec *codec, hda_nid_t pin) { struct hda_gen_spec *spec = codec->spec; int nitems = 0; - if (spec->add_jack_modes) + if (spec->add_jack_modes || spec->add_in_jack_modes) nitems = hweight32(get_vref_caps(codec, pin)); return nitems ? nitems : 1; } @@ -3287,7 +3359,7 @@ static int create_input_ctls(struct hda_codec *codec) if (err < 0) return err; - if (spec->add_jack_modes) { + if (spec->add_jack_modes || spec->add_in_jack_modes) { err = create_in_jack_mode(codec, pin); if (err < 0) return err; @@ -4895,13 +4971,13 @@ int snd_hda_gen_parse_auto_config(struct hda_codec *codec, */ if (spec->hp_mic_pin && (spec->auto_mic || spec->input_mux.num_items == 1 || - spec->add_jack_modes)) { + spec->add_jack_modes || spec->add_in_jack_modes)) { err = create_hp_mic_jack_mode(codec, spec->hp_mic_pin); if (err < 0) return err; } - if (spec->add_jack_modes) { + if (spec->add_jack_modes || spec->add_out_jack_modes) { if (cfg->line_out_type != AUTO_PIN_SPEAKER_OUT) { err = create_out_jack_modes(codec, cfg->line_outs, cfg->line_out_pins); diff --git a/sound/pci/hda/hda_generic.h b/sound/pci/hda/hda_generic.h index 56e4139..f10c55b 100644 --- a/sound/pci/hda/hda_generic.h +++ b/sound/pci/hda/hda_generic.h @@ -227,6 +229,8 @@ struct hda_gen_spec { unsigned int prefer_hp_amp:1; /* enable HP amp for speaker if any */ unsigned int add_stereo_mix_input:2; /* add aamix as a capture src */ unsigned int add_jack_modes:1; /* add i/o jack mode enum ctls */ + unsigned int add_in_jack_modes:1; /* add in jack mode enum ctls */ + unsigned int add_out_jack_modes:1; /* add out jack mode enum ctls */ unsigned int power_down_unused:1; /* power down unused widgets */ unsigned int dac_min_mute:1; /* minimal = mute for DACs */ diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 8e02cdf..b13f588 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -1914,6 +1914,62 @@ static void alc889_fixup_mba21_vref(struct hda_codec *codec, alc889_fixup_mac_pins(codec, nids, ARRAY_SIZE(nids)); } +static const struct snd_pcm_chmap_elem acer_pcm_chmaps[] = { + { .channels = 2, + .map = { SNDRV_CHMAP_FL, SNDRV_CHMAP_FR } }, + { .channels = 4, + .map = { SNDRV_CHMAP_FL, SNDRV_CHMAP_FR, + SNDRV_CHMAP_LFE, SNDRV_CHMAP_NA } }, /* LFE only on left */ + { .channels = 4, + .map = { SNDRV_CHMAP_FL, SNDRV_CHMAP_FR, + SNDRV_CHMAP_RL, SNDRV_CHMAP_RR } }, + { .channels = 6, + .map = { SNDRV_CHMAP_FL, SNDRV_CHMAP_FR, + SNDRV_CHMAP_RL, SNDRV_CHMAP_RR, + SNDRV_CHMAP_FC, SNDRV_CHMAP_LFE } }, + { } +}; + +static void alc888_fixup_acer_aspire_4930g(struct hda_codec *codec, + const struct hda_fixup *fix, int action) +{ + static const struct hda_pintbl subwoofer_cfg[] = { + { 0x16, 0x90170111 }, /* internal subwoofer */ + {} + }; + static const struct hda_pintbl front_cfg[] = { + { 0x15, 0x02014010}, + {} + }; + static const struct hda_pintbl rear_cfg[] = { + { 0x1a, 0x02014011}, + {} + }; + static const struct hda_pintbl clfe_cfg[] = { + { 0x18, 0x02014012}, + {} + }; + struct alc_spec *spec = codec->spec; + switch(action){ + case HDA_FIXUP_ACT_PRE_PROBE: + snd_hda_apply_pincfgs(codec, subwoofer_cfg); + spec->gen.add_out_jack_modes = true; + switch(codec->alt_config){ + case 3: + snd_hda_apply_pincfgs(codec, clfe_cfg); + case 2: + snd_hda_apply_pincfgs(codec, rear_cfg); + case 1: + snd_hda_apply_pincfgs(codec, front_cfg); + break; + } + break; + case HDA_FIXUP_ACT_BUILD: + spec->gen.pcm_rec[0]->stream[0].chmap = acer_pcm_chmaps; + break; + } +} + /* Don't take HP output as primary * Strangely, the speaker output doesn't work on Vaio Z and some Vaio * all-in-one desktop PCs (for example VGC-LN51JGB) through DAC 0x05 @@ -2048,12 +2104,8 @@ static const struct hda_fixup alc882_fixups[] = { .v.func = alc889_fixup_coef, }, [ALC882_FIXUP_ACER_ASPIRE_4930G] = { - .type = HDA_FIXUP_PINS, - .v.pins = (const struct hda_pintbl[]) { - { 0x16, 0x99130111 }, /* CLFE speaker */ - { 0x17, 0x99130112 }, /* surround speaker */ - { } - }, + .type = HDA_FIXUP_FUNC, + .v.func = alc888_fixup_acer_aspire_4930g, .chained = true, .chain_id = ALC882_FIXUP_GPIO1, },

1 0

[alsa-devel] How to activate DAI link to dummy codec?
by Anatol Pomozov 12 Jul '15

12 Jul '15

Hi I have following hardware configuration [SoC] <=> [RT5677] <=> [MAX98357A] MAX98357A is a simple speaker amplifier with I2S data interface and no I2C control. The chip automatically configures itself (rate/block frequency) when I2S is started streaming to the chip. This chip does not need a driver (there is nothing to configure) and we can use "dummy-codec" for it. There is a DAI link between RT5677 and MAX and it should be configured from RT5677 side. RT5677 is master here and it need to set I2S bus parameters. Configuration happens in rt5677 hw_params() function and it is triggered by dai link activation. My question is how to tell DAPM that I need to activate this link? If MAX98357A was a real codec then it would have an OUTPUT widget that I can activate, this would trigger dai link in between to be activated as well. But dummy codec does not have any widgets, so how I suppose to activate link to dummy codec?

2 2

[alsa-devel] [asoc:topic/sti-sas 1/1] sound/soc/codecs/sti-sas.c:227:2: error: implicit declaration of function 'devm_reset_control_get'
by kbuild test robot 11 Jul '15

11 Jul '15

tree: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/sti-sas head: 32a726b2e089ec1851965290a610c4ae9cab3303 commit: 32a726b2e089ec1851965290a610c4ae9cab3303 [1/1] ASoC: sti-sas: Add sti platform codec config: i386-randconfig-x0-07112203 (attached as .config) reproduce: git checkout 32a726b2e089ec1851965290a610c4ae9cab3303 # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): sound/soc/codecs/sti-sas.c: In function 'stih416_dac_probe': >> sound/soc/codecs/sti-sas.c:227:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration] dac->rst = devm_reset_control_get(codec->dev, "dac_rst"); ^ >> sound/soc/codecs/sti-sas.c:227:11: warning: assignment makes pointer from integer without a cast dac->rst = devm_reset_control_get(codec->dev, "dac_rst"); ^ cc1: some warnings being treated as errors vim +/devm_reset_control_get +227 sound/soc/codecs/sti-sas.c 221 { 222 struct snd_soc_codec *codec = dai->codec; 223 struct sti_sas_data *drvdata = dev_get_drvdata(codec->dev); 224 struct sti_dac_audio *dac = &drvdata->dac; 225 226 /* Get reset control */ > 227 dac->rst = devm_reset_control_get(codec->dev, "dac_rst"); 228 if (IS_ERR(dac->rst)) { 229 dev_err(dai->codec->dev, 230 "%s: ERROR: DAC reset control not defined (%d)!\n", --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [asoc:topic/sti-sas 1/1] sound/soc/codecs/sti-sas.c:558:2: note: in expansion of macro 'if'
by kbuild test robot 11 Jul '15

11 Jul '15

tree: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/sti-sas head: 32a726b2e089ec1851965290a610c4ae9cab3303 commit: 32a726b2e089ec1851965290a610c4ae9cab3303 [1/1] ASoC: sti-sas: Add sti platform codec config: i386-randconfig-x0-07111645 (attached as .config) reproduce: git checkout 32a726b2e089ec1851965290a610c4ae9cab3303 # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): In file included from include/uapi/linux/stddef.h:1:0, from include/linux/stddef.h:4, from include/uapi/linux/posix_types.h:4, from include/uapi/linux/types.h:13, from include/linux/types.h:5, from include/linux/io.h:21, from sound/soc/codecs/sti-sas.c:8: sound/soc/codecs/sti-sas.c: In function 'sti_sas_driver_probe': sound/soc/codecs/sti-sas.c:558:46: warning: dereferencing 'void *' pointer if (!of_match_node(sti_sas_dev_match, pnode)->data) { ^ include/linux/compiler.h:147:28: note: in definition of macro '__trace_if' if (__builtin_constant_p((cond)) ? !!(cond) : \ ^ >> sound/soc/codecs/sti-sas.c:558:2: note: in expansion of macro 'if' if (!of_match_node(sti_sas_dev_match, pnode)->data) { ^ sound/soc/codecs/sti-sas.c:558:46: error: request for member 'data' in something not a structure or union if (!of_match_node(sti_sas_dev_match, pnode)->data) { ^ include/linux/compiler.h:147:28: note: in definition of macro '__trace_if' if (__builtin_constant_p((cond)) ? !!(cond) : \ ^ >> sound/soc/codecs/sti-sas.c:558:2: note: in expansion of macro 'if' if (!of_match_node(sti_sas_dev_match, pnode)->data) { ^ sound/soc/codecs/sti-sas.c:558:46: warning: dereferencing 'void *' pointer if (!of_match_node(sti_sas_dev_match, pnode)->data) { ^ include/linux/compiler.h:147:40: note: in definition of macro '__trace_if' if (__builtin_constant_p((cond)) ? !!(cond) : \ ^ >> sound/soc/codecs/sti-sas.c:558:2: note: in expansion of macro 'if' if (!of_match_node(sti_sas_dev_match, pnode)->data) { ^ sound/soc/codecs/sti-sas.c:558:46: error: request for member 'data' in something not a structure or union if (!of_match_node(sti_sas_dev_match, pnode)->data) { ^ include/linux/compiler.h:147:40: note: in definition of macro '__trace_if' if (__builtin_constant_p((cond)) ? !!(cond) : \ ^ >> sound/soc/codecs/sti-sas.c:558:2: note: in expansion of macro 'if' if (!of_match_node(sti_sas_dev_match, pnode)->data) { ^ sound/soc/codecs/sti-sas.c:558:46: warning: dereferencing 'void *' pointer if (!of_match_node(sti_sas_dev_match, pnode)->data) { ^ include/linux/compiler.h:158:16: note: in definition of macro '__trace_if' ______r = !!(cond); \ ^ >> sound/soc/codecs/sti-sas.c:558:2: note: in expansion of macro 'if' if (!of_match_node(sti_sas_dev_match, pnode)->data) { ^ sound/soc/codecs/sti-sas.c:558:46: error: request for member 'data' in something not a structure or union if (!of_match_node(sti_sas_dev_match, pnode)->data) { ^ include/linux/compiler.h:158:16: note: in definition of macro '__trace_if' ______r = !!(cond); \ ^ >> sound/soc/codecs/sti-sas.c:558:2: note: in expansion of macro 'if' if (!of_match_node(sti_sas_dev_match, pnode)->data) { ^ sound/soc/codecs/sti-sas.c:563:61: warning: dereferencing 'void *' pointer drvdata->dev_data = of_match_node(sti_sas_dev_match, pnode)->data; ^ sound/soc/codecs/sti-sas.c:563:61: error: request for member 'data' in something not a structure or union vim +/if +558 sound/soc/codecs/sti-sas.c 542 }, 543 {}, 544 }; 545 546 static int sti_sas_driver_probe(struct platform_device *pdev) 547 { 548 struct device_node *pnode = pdev->dev.of_node; 549 struct sti_sas_data *drvdata; 550 551 /* Allocate device structure */ 552 drvdata = devm_kzalloc(&pdev->dev, sizeof(struct sti_sas_data), 553 GFP_KERNEL); 554 if (!drvdata) 555 return -ENOMEM; 556 557 /* Populate data structure depending on compatibility */ > 558 if (!of_match_node(sti_sas_dev_match, pnode)->data) { 559 dev_err(&pdev->dev, "data associated to device is missing"); 560 return -EINVAL; 561 } 562 563 drvdata->dev_data = of_match_node(sti_sas_dev_match, pnode)->data; 564 565 /* Initialise device structure */ 566 drvdata->dev = &pdev->dev; --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [asoc:topic/sti-sas 1/1] sound/soc/codecs/sti-sas.c:558:46: error: request for member 'data' in something not a structure or union
by kbuild test robot 11 Jul '15

11 Jul '15

tree: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/sti-sas head: 32a726b2e089ec1851965290a610c4ae9cab3303 commit: 32a726b2e089ec1851965290a610c4ae9cab3303 [1/1] ASoC: sti-sas: Add sti platform codec config: x86_64-randconfig-a0-07111354 (attached as .config) reproduce: git checkout 32a726b2e089ec1851965290a610c4ae9cab3303 # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): sound/soc/codecs/sti-sas.c: In function 'stih416_dac_probe': sound/soc/codecs/sti-sas.c:231:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] __func__, (int)dac->rst); ^ sound/soc/codecs/sti-sas.c: In function 'sti_sas_driver_probe': >> sound/soc/codecs/sti-sas.c:558:46: warning: dereferencing 'void *' pointer if (!of_match_node(sti_sas_dev_match, pnode)->data) { ^ >> sound/soc/codecs/sti-sas.c:558:46: error: request for member 'data' in something not a structure or union sound/soc/codecs/sti-sas.c:563:61: warning: dereferencing 'void *' pointer drvdata->dev_data = of_match_node(sti_sas_dev_match, pnode)->data; ^ sound/soc/codecs/sti-sas.c:563:61: error: request for member 'data' in something not a structure or union vim +/data +558 sound/soc/codecs/sti-sas.c 552 drvdata = devm_kzalloc(&pdev->dev, sizeof(struct sti_sas_data), 553 GFP_KERNEL); 554 if (!drvdata) 555 return -ENOMEM; 556 557 /* Populate data structure depending on compatibility */ > 558 if (!of_match_node(sti_sas_dev_match, pnode)->data) { 559 dev_err(&pdev->dev, "data associated to device is missing"); 560 return -EINVAL; 561 } --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

Re: [alsa-devel] [pulseaudio-discuss] Strange hardware: XFX nForce 780i SLI MCP
by Raymond Yau 11 Jul '15

11 Jul '15

> Yesterday I got an interesting email related to dcaenc support. > > The person has an "XFX nForce 780i SLI" MCP board: > http://www.nvidia.com/object/product_nforce_780i_sli_us.html , > http://www.evga.com/support/manuals/files/132-CK-NF78.pdf > > As you see on page 18 of the manual, this board has no HDMI output, but > there is an optical SPDIF. Strangely enough, this SPDIF is his > "hdmi:CARD=NVidia,DEV=0" device. > > Given the recent discussions related to dynamically creating PCM devices > for HDMI, I think you will be interested in this alsa-info output. > > Is there anything here that would need special treatment by ALSA or > PulseAudio? Or, is this just a misnumbered/misnamed codec? > swap dig_out_pins of autocfg when type are different diff --git a/sound/pci/hda/hda_auto_parser.c b/sound/pci/hda/hda_auto_parser.c index 03b7399..3ff16e8 100644 --- a/sound/pci/hda/hda_auto_parser.c +++ b/sound/pci/hda/hda_auto_parser.c @@ -405,6 +405,19 @@ int snd_hda_parse_pin_defcfg(struct hda_codec *codec, sort(cfg->inputs, cfg->num_inputs, sizeof(cfg->inputs[0]), compare_input_type, NULL); + if (cfg->dig_outs == 2) { + if (cfg->dig_out_type[0] != cfg->dig_out_type[1]) { + if (cfg->dig_out_type[0] == HDA_PCM_TYPE_HDMI) { + hda_nid_t temp = cfg->dig_out_pins[0]; + int temp_type = cfg->dig_out_type[0]; + cfg->dig_out_pins[0] = cfg->dig_out_pins[1]; + cfg->dig_out_type[0] = cfg->dig_out_type[1]; + cfg->dig_out_pins[1] = temp; + cfg->dig_out_type[1] = temp_type; + } + } + } + /* * debug prints of the parsed results */ > >

1 0