May 2015 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [REGRESSION] 4.1-rc4: Sound muted after boot
by Martin Steigerwald 21 May '15

21 May '15

Hello! On ThinkPad T520 (Intel Sandybridge) with 4.14-rc4 + two BTRFS patches and one Intel P-State debug patch I have no sound output on internal Intel HD audio codec. According to ThinkPad T520 LED with striked-through speaker the loud speaker is in disabled state. Also KDE´s Phonon says a soundcard is missing. In alsa-mixer I see nothing as MM for muted. If I press the key next to the LED I get a notification on the desktop that loud speaker has been enabled / disabled, but the LED still is on for it being disabled. I do not hear anything in Amarok or with aplay. alsa-mixer sound volumes are 100 for master and PCM. I also tried with disabling "Auto-Mute Mod", but still no sound. When I reboot and in BIOS or GRUB press the key then the LED toggles state. When I reboot into Linux 4.0.1 sound is working fine and loud speaker disabled LED is toggled off, so I bet this is a regression 4.1-rc4 compared to 4.0.1. The following is from non-working 4.1-rc4 kernel: merkaba:~> lspci -s 00:1b.0 -nnv 00:1b.0 Audio device [0403]: Intel Corporation 6 Series/C200 Series Chipset Family High Definition Audio Controller [8086:1c20] (rev 04) Subsystem: Lenovo Device [17aa:21cf] Flags: bus master, fast devsel, latency 0, IRQ 29 Memory at f2520000 (64-bit, non-prefetchable) [size=16K] Capabilities: [50] Power Management version 2 Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+ Capabilities: [70] Express Root Complex Integrated Endpoint, MSI 00 Capabilities: [100] Virtual Channel Capabilities: [130] Root Complex Link Kernel driver in use: snd_hda_intel merkaba:~> cat /proc/asound/cards 0 [PCH ]: HDA-Intel - HDA Intel PCH HDA Intel PCH at 0xf2520000 irq 29 merkaba:~> cat /proc/asound/version Advanced Linux Sound Architecture Driver Version k4.1.0-rc4-tp520-btrfstrim- pstatetrace+. merkaba:~> cat /proc/asound/devices 2: [ 0] : control 3: [ 0- 0]: digital audio playback 4: [ 0- 0]: digital audio capture 5: [ 0- 3]: digital audio playback 6: [ 0- 7]: digital audio playback 7: [ 0- 8]: digital audio playback 8: [ 0- 0]: hardware dependent 9: [ 0- 1]: hardware dependent 10: [ 0- 3]: hardware dependent 33: : timer merkaba:~> merkaba:~> aplay -L null Discard all samples (playback) or generate zero samples (capture) pulse PulseAudio Sound Server phonon HDA Intel PCH mit Mixer default:CARD=PCH HDA Intel PCH, CX20590 Analog Default Audio Device sysdefault:CARD=PCH HDA Intel PCH, CX20590 Analog Default Audio Device front:CARD=PCH,DEV=0 HDA Intel PCH, CX20590 Analog Front speakers surround21:CARD=PCH,DEV=0 HDA Intel PCH, CX20590 Analog 2.1 Surround output to Front and Subwoofer speakers surround40:CARD=PCH,DEV=0 HDA Intel PCH, CX20590 Analog 4.0 Surround output to Front and Rear speakers surround41:CARD=PCH,DEV=0 HDA Intel PCH, CX20590 Analog 4.1 Surround output to Front, Rear and Subwoofer speakers surround50:CARD=PCH,DEV=0 HDA Intel PCH, CX20590 Analog 5.0 Surround output to Front, Center and Rear speakers surround51:CARD=PCH,DEV=0 HDA Intel PCH, CX20590 Analog 5.1 Surround output to Front, Center, Rear and Subwoofer speakers surround71:CARD=PCH,DEV=0 HDA Intel PCH, CX20590 Analog 7.1 Surround output to Front, Center, Side, Rear and Woofer speakers hdmi:CARD=PCH,DEV=0 HDA Intel PCH, HDMI 0 HDMI Audio Output hdmi:CARD=PCH,DEV=1 HDA Intel PCH, HDMI 1 HDMI Audio Output hdmi:CARD=PCH,DEV=2 HDA Intel PCH, HDMI 2 HDMI Audio Output dmix:CARD=PCH,DEV=0 HDA Intel PCH, CX20590 Analog Direct sample mixing device dmix:CARD=PCH,DEV=3 HDA Intel PCH, HDMI 0 Direct sample mixing device dmix:CARD=PCH,DEV=7 HDA Intel PCH, HDMI 1 Direct sample mixing device dmix:CARD=PCH,DEV=8 HDA Intel PCH, HDMI 2 Direct sample mixing device dsnoop:CARD=PCH,DEV=0 HDA Intel PCH, CX20590 Analog Direct sample snooping device dsnoop:CARD=PCH,DEV=3 HDA Intel PCH, HDMI 0 Direct sample snooping device dsnoop:CARD=PCH,DEV=7 HDA Intel PCH, HDMI 1 Direct sample snooping device dsnoop:CARD=PCH,DEV=8 HDA Intel PCH, HDMI 2 Direct sample snooping device hw:CARD=PCH,DEV=0 HDA Intel PCH, CX20590 Analog Direct hardware device without any conversions hw:CARD=PCH,DEV=3 HDA Intel PCH, HDMI 0 Direct hardware device without any conversions hw:CARD=PCH,DEV=7 HDA Intel PCH, HDMI 1 Direct hardware device without any conversions hw:CARD=PCH,DEV=8 HDA Intel PCH, HDMI 2 Direct hardware device without any conversions plughw:CARD=PCH,DEV=0 HDA Intel PCH, CX20590 Analog Hardware device with all software conversions plughw:CARD=PCH,DEV=3 HDA Intel PCH, HDMI 0 Hardware device with all software conversions plughw:CARD=PCH,DEV=7 HDA Intel PCH, HDMI 1 Hardware device with all software conversions plughw:CARD=PCH,DEV=8 HDA Intel PCH, HDMI 2 Hardware device with all software conversions Ciao, -- Martin 'Helios' Steigerwald - http://www.Lichtvoll.de GPG: 03B0 0D6C 0040 0710 4AFA B82F 991B EAAC A599 84C7

2 9

Re: [alsa-devel] [PATCH 1/4] ASoC: rockchip: add rockchip machine driver
by Mark Brown 21 May '15

21 May '15

On Wed, May 13, 2015 at 09:23:01PM +0800, zhengxing wrote: > On 2015年05月13日 03:22, Mark Brown wrote: > >Is it not possible to extend simple card to handle your use cases? > >Given the very generic naming and the fact that things like jack > >detection and so on should depend on the CODEC and board usually rather > >than on the SoC it doesn't sound like this is Rockchip specific. > >This also looks like you're reimplementing some device model enumeration > >stuff which probably shouldn't be happening but let's understand the > >problem you're trying to solve here before going too far into the code. > Because we are trying to bring rt5650 in the project, so we intend to > describe supported codecs with DTS via only a rockchip machine driver file, > others remain pre-implement(like max98090 / rt5645 that vendor machine > driver). I don't undertand what you're saying here, sorry - why is this not just a case of writing multiple machine drivers? > I communicated with Dylan, and he told me that the jack detection is an > issue in the simple-card, and suggested we are better to send them at > present. But what are these issues?

3 6

[alsa-devel] [PATCH] ASoC: mop500_ab8500: Add a NULL pointer check in mop500_ab8500_machine_init()
by Rajan Vaja 21 May '15

21 May '15

Avoid possible crash (NULL pointer dereference) by making sure that dem_kzalloc() is successful. Signed-off-by: Rajan Vaja <rajan.vaja(a)gmail.com> --- sound/soc/ux500/mop500_ab8500.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/ux500/mop500_ab8500.c b/sound/soc/ux500/mop500_ab8500.c index b81a7a4c..85d810d 100644 --- a/sound/soc/ux500/mop500_ab8500.c +++ b/sound/soc/ux500/mop500_ab8500.c @@ -372,6 +372,10 @@ int mop500_ab8500_machine_init(struct snd_soc_pcm_runtime *rtd) /* Create driver private-data struct */ drvdata = devm_kzalloc(dev, sizeof(struct mop500_ab8500_drvdata), GFP_KERNEL); + + if (!drvdata) + return -ENOMEM; + snd_soc_card_set_drvdata(rtd->card, drvdata); /* Setup clocks */ -- 1.7.9.5

2 1

[alsa-devel] [PATCH] ALSA: jack: Remove MODULE_*() macros
by Takashi Iwai 21 May '15

21 May '15

The jack interface is statically included in sound core. Having doubly module information is rather confusing. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/jack.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sound/core/jack.c b/sound/core/jack.c index eb66327b5f1c..7237acbdcbbc 100644 --- a/sound/core/jack.c +++ b/sound/core/jack.c @@ -372,7 +372,3 @@ void snd_jack_report(struct snd_jack *jack, int status) } EXPORT_SYMBOL(snd_jack_report); - -MODULE_AUTHOR("Mark Brown <broonie(a)opensource.wolfsonmicro.com>"); -MODULE_DESCRIPTION("Jack detection support for ALSA"); -MODULE_LICENSE("GPL"); -- 2.4.1

1 0

[alsa-devel] [PATCH] ASoC: rx51: use flags argument of devm_gpiod_get to set direction
by Uwe Kleine-König 20 May '15

20 May '15

Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) which appeared in v3.17-rc1, the gpiod_get* functions take an additional parameter that allows to specify direction and initial value for output. Use this to simplify the driver. Furthermore this is one caller less that stops us making the flags argument to gpiod_get*() mandatory. Fixes: 386e81ab3b4d ("ASoC: omap: rx51: get GPIO numbers via gpiod API") Signed-off-by: Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> --- sound/soc/omap/rx51.c | 30 ++++++++---------------------- 1 file changed, 8 insertions(+), 22 deletions(-) diff --git a/sound/soc/omap/rx51.c b/sound/soc/omap/rx51.c index c2ddf0fbfa28..fded99362d39 100644 --- a/sound/soc/omap/rx51.c +++ b/sound/soc/omap/rx51.c @@ -455,50 +455,36 @@ static int rx51_soc_probe(struct platform_device *pdev) snd_soc_card_set_drvdata(card, pdata); pdata->tvout_selection_gpio = devm_gpiod_get(card->dev, - "tvout-selection"); + "tvout-selection", + GPIOD_OUT_LOW); if (IS_ERR(pdata->tvout_selection_gpio)) { dev_err(card->dev, "could not get tvout selection gpio\n"); return PTR_ERR(pdata->tvout_selection_gpio); } - err = gpiod_direction_output(pdata->tvout_selection_gpio, 0); - if (err) { - dev_err(card->dev, "could not setup tvout selection gpio\n"); - return err; - } - pdata->jack_detection_gpio = devm_gpiod_get(card->dev, - "jack-detection"); + "jack-detection", + GPIOD_ASIS); if (IS_ERR(pdata->jack_detection_gpio)) { dev_err(card->dev, "could not get jack detection gpio\n"); return PTR_ERR(pdata->jack_detection_gpio); } - pdata->eci_sw_gpio = devm_gpiod_get(card->dev, "eci-switch"); + pdata->eci_sw_gpio = devm_gpiod_get(card->dev, "eci-switch", + GPIOD_OUT_HIGH); if (IS_ERR(pdata->eci_sw_gpio)) { dev_err(card->dev, "could not get eci switch gpio\n"); return PTR_ERR(pdata->eci_sw_gpio); } - err = gpiod_direction_output(pdata->eci_sw_gpio, 1); - if (err) { - dev_err(card->dev, "could not setup eci switch gpio\n"); - return err; - } - pdata->speaker_amp_gpio = devm_gpiod_get(card->dev, - "speaker-amplifier"); + "speaker-amplifier", + GPIOD_OUT_LOW); if (IS_ERR(pdata->speaker_amp_gpio)) { dev_err(card->dev, "could not get speaker enable gpio\n"); return PTR_ERR(pdata->speaker_amp_gpio); } - err = gpiod_direction_output(pdata->speaker_amp_gpio, 0); - if (err) { - dev_err(card->dev, "could not setup speaker enable gpio\n"); - return err; - } - err = devm_snd_soc_register_card(card->dev, card); if (err) { dev_err(&pdev->dev, "snd_soc_register_card failed (%d)\n", err); -- 2.1.4

3 4

[alsa-devel] [PATCH] SoC: max98357a: use flags argument of devm_gpiod_get to set direction
by Uwe Kleine-König 20 May '15

20 May '15

Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) which appeared in v3.17-rc1, the gpiod_get* functions take an additional parameter that allows to specify direction and initial value for output. Use this to simplify the driver. Furthermore this is one caller less that stops us making the flags argument to gpiod_get*() mandatory. Fixes: af5adf129369 ("ASoC: max98357a: Add MAX98357A codec driver") Signed-off-by: Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> --- sound/soc/codecs/max98357a.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/codecs/max98357a.c b/sound/soc/codecs/max98357a.c index bf3e933ee895..3a2fda08a893 100644 --- a/sound/soc/codecs/max98357a.c +++ b/sound/soc/codecs/max98357a.c @@ -60,13 +60,12 @@ static int max98357a_codec_probe(struct snd_soc_codec *codec) { struct gpio_desc *sdmode; - sdmode = devm_gpiod_get(codec->dev, "sdmode"); + sdmode = devm_gpiod_get(codec->dev, "sdmode", GPIOD_OUT_LOW); if (IS_ERR(sdmode)) { dev_err(codec->dev, "%s() unable to get sdmode GPIO: %ld\n", __func__, PTR_ERR(sdmode)); return PTR_ERR(sdmode); } - gpiod_direction_output(sdmode, 0); snd_soc_codec_set_drvdata(codec, sdmode); return 0; -- 2.1.4

3 2

[alsa-devel] [PATCH] SoC: sta32x: use devm_gpiod_get_optional for optional reset gpio
by Uwe Kleine-König 20 May '15

20 May '15

Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) which appeared in v3.17-rc1, the gpiod_get* functions take an additional parameter that allows to specify direction and initial value for output. Also there is a variant to find optional gpios that returns NULL if there is no gpio instead of -ENOENT. Make use of both features to simplify the driver. This changes behaviour if gpiod_get returns -ENOSYS which is the case if CONFIG_GPIOLIB is not enabled. This is a good change because without GPIOLIB there is no way to determine if the reset gpio is specified in the device tree. And if it is it must be handled, so erroring out is the right thing to do. Furthermore this is one caller less that stops us making the flags argument to gpiod_get*() mandatory. Fixes: b66a29808e1f ("ASoC: sta32x: make sta32x a gpio consumer for the reset GPIO") Signed-off-by: Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> --- sound/soc/codecs/sta32x.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/sound/soc/codecs/sta32x.c b/sound/soc/codecs/sta32x.c index 007a0e3bc273..0111baf9a5d4 100644 --- a/sound/soc/codecs/sta32x.c +++ b/sound/soc/codecs/sta32x.c @@ -1096,16 +1096,10 @@ static int sta32x_i2c_probe(struct i2c_client *i2c, #endif /* GPIOs */ - sta32x->gpiod_nreset = devm_gpiod_get(dev, "reset"); - if (IS_ERR(sta32x->gpiod_nreset)) { - ret = PTR_ERR(sta32x->gpiod_nreset); - if (ret != -ENOENT && ret != -ENOSYS) - return ret; - - sta32x->gpiod_nreset = NULL; - } else { - gpiod_direction_output(sta32x->gpiod_nreset, 0); - } + sta32x->gpiod_nreset = devm_gpiod_get_optional(dev, "reset", + GPIOD_OUT_LOW); + if (IS_ERR(sta32x->gpiod_nreset)) + return PTR_ERR(sta32x->gpiod_nreset); /* regulators */ for (i = 0; i < ARRAY_SIZE(sta32x->supplies); i++) -- 2.1.4

2 1

[alsa-devel] [PATCH] ASoC: omap: fix up SND_OMAP_SOC_OMAP_ABE_TWL6040 dependency, again
by Arnd Bergmann 20 May '15

20 May '15

I tried to fix this before and submitted a working patch, but after some discussion we came up with what seemed to be a nicer solution, resulting in commit 3d4cf65e2d ("ASoC: omap: fix up SND_OMAP_SOC_OMAP_ABE_TWL6040 dependency"). Unfortunately, that version was incomplete, and we still get this build error: drivers/clk/clk-palmas.c:46:16: error: field 'hw' has incomplete type drivers/clk/clk-palmas.c: In function 'to_palmas_clks_info': drivers/clk/clk-palmas.c:54:74: warning: initialization from incompatible pointer type [-Winc This happens only in randconfig builds that turn on MFD_PALMAS on a platform other than OMAP2+ when COMPILE_TEST is set but COMMON_CLK is not. The new approach is only 'select COMMON_CLK_PALMAS' if we know that we are on an OMAP5 platform and MFD_PALMAS is already set. This patch has survived thousands of randconfig builds and I don't see a remaining hole in the logic. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> Fixes: 3d4cf65e2d ("ASoC: omap: fix up SND_OMAP_SOC_OMAP_ABE_TWL6040 dependency") diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig index 6768e4f7d7d0..30d0109703a9 100644 --- a/sound/soc/omap/Kconfig +++ b/sound/soc/omap/Kconfig @@ -100,12 +100,13 @@ config SND_OMAP_SOC_OMAP_TWL4030 config SND_OMAP_SOC_OMAP_ABE_TWL6040 tristate "SoC Audio support for OMAP boards using ABE and twl6040 codec" - depends on TWL6040_CORE && SND_OMAP_SOC && (ARCH_OMAP4 || SOC_OMAP5 || COMPILE_TEST) + depends on TWL6040_CORE && SND_OMAP_SOC + depends on ARCH_OMAP4 || (SOC_OMAP5 && MFD_PALMAS) || COMPILE_TEST select SND_OMAP_SOC_DMIC select SND_OMAP_SOC_MCPDM select SND_SOC_TWL6040 select SND_SOC_DMIC - select COMMON_CLK_PALMAS if MFD_PALMAS + select COMMON_CLK_PALMAS if (SOC_OMAP5 && MFD_PALMAS) help Say Y if you want to add support for SoC audio on OMAP boards using ABE and twl6040 codec. This driver currently supports:

3 2

Re: [alsa-devel] [PATCH v3 06/17] video: lcd: add LoCoMo LCD driver
by Jingoo Han 20 May '15

20 May '15

> LoCoMo has some special handling for TFT screens attached to Collie and > Poodle. Implement that as a separate driver. > > Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov(a)gmail.com> Acked-by: Jingoo Han <jingoohan1(a)gmail.com> Best regards, Jingoo Han > --- > drivers/video/backlight/Kconfig | 10 ++ > drivers/video/backlight/Makefile | 1 + > drivers/video/backlight/locomo_lcd.c | 285 +++++++++++++++++++++++++++++++++++ > 3 files changed, 296 insertions(+) > create mode 100644 drivers/video/backlight/locomo_lcd.c

1 0

[alsa-devel] [PATCH 1/7] ASoC: alc5623: Replace direct snd_soc_codec dapm field access
by Lars-Peter Clausen 20 May '15

20 May '15

The dapm field of the snd_soc_codec struct is eventually going to be removed, in preparation for this replace all manual access to codec->dapm with snd_soc_codec_get_dapm(). Signed-off-by: Lars-Peter Clausen <lars(a)metafoo.de> --- Full series depends on topic/dapm --- sound/soc/codecs/alc5623.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/alc5623.c b/sound/soc/codecs/alc5623.c index e92b5ae..0fc24e0 100644 --- a/sound/soc/codecs/alc5623.c +++ b/sound/soc/codecs/alc5623.c @@ -893,7 +893,7 @@ static int alc5623_resume(struct snd_soc_codec *codec) static int alc5623_probe(struct snd_soc_codec *codec) { struct alc5623_priv *alc5623 = snd_soc_codec_get_drvdata(codec); - struct snd_soc_dapm_context *dapm = &codec->dapm; + struct snd_soc_dapm_context *dapm = snd_soc_codec_get_dapm(codec); alc5623_reset(codec); -- 1.8.0

2 7