April 2015 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] Lost Interrput on VIA VT1708S
by Raymond Yau 17 Apr '15

17 Apr '15

> > The second opint is what you have an issue with - see "Lost interrupts" in comment #28. > > https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/sound/c… hwptr tracking was replaced by tracepoint This seem to be the reason that you only find those Lost Interrput in the system log https://bugs.freedesktop.org/show_bug.cgi?id=49608#c28 https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/tree/sound/cor…

1 0

[alsa-devel] [PATCH -next] ASoC: Intel: sst_byt: remove kfree for memory allocated with devm_kzalloc
by weiyj_lk＠163.com 17 Apr '15

17 Apr '15

From: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> It's not necessary to free memory allocated with devm_kzalloc and using kfree leads to a double free. Signed-off-by: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> --- sound/soc/intel/baytrail/sst-baytrail-ipc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/intel/baytrail/sst-baytrail-ipc.c b/sound/soc/intel/baytrail/sst-baytrail-ipc.c index 1efb33b..a839dbf 100644 --- a/sound/soc/intel/baytrail/sst-baytrail-ipc.c +++ b/sound/soc/intel/baytrail/sst-baytrail-ipc.c @@ -759,7 +759,6 @@ fw_err: dsp_new_err: sst_ipc_fini(ipc); ipc_init_err: - kfree(byt); return err; }

3 2

[alsa-devel] [patch] ALSA: hda - potential (but unlikely) uninitialized variable
by Dan Carpenter 17 Apr '15

17 Apr '15

This function is a bit unusual because it accepts negative values as "conn_len". It's theoretically possible for both "cache_len" and "conn_len" to be -ENOSPC and in that case we would oops trying to run memcmp() on the uninitialized "list" pointer. My static checker complains about this. Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> diff --git a/sound/pci/hda/hda_proc.c b/sound/pci/hda/hda_proc.c index ce5a6da..387fdfc 100644 --- a/sound/pci/hda/hda_proc.c +++ b/sound/pci/hda/hda_proc.c @@ -556,8 +556,8 @@ static void print_conn_list(struct snd_info_buffer *buffer, /* Get Cache connections info */ cache_len = snd_hda_get_conn_list(codec, nid, &list); - if (cache_len != conn_len - || memcmp(list, conn, conn_len)) { + if (cache_len < 0 || cache_len != conn_len || + memcmp(list, conn, conn_len) != 0) { snd_iprintf(buffer, " In-driver Connection: %d\n", cache_len); if (cache_len > 0) { snd_iprintf(buffer, " ");

2 4

[alsa-devel] [PATCH -next] ASoC: Intel: sst_hsw: remove kfree for memory allocated with devm_kzalloc
by weiyj_lk＠163.com 17 Apr '15

17 Apr '15

From: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> It's not necessary to free memory allocated with devm_kzalloc and using kfree leads to a double free. Signed-off-by: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> --- sound/soc/intel/haswell/sst-haswell-ipc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/intel/haswell/sst-haswell-ipc.c b/sound/soc/intel/haswell/sst-haswell-ipc.c index 344a1e9..324eceb 100644 --- a/sound/soc/intel/haswell/sst-haswell-ipc.c +++ b/sound/soc/intel/haswell/sst-haswell-ipc.c @@ -2201,7 +2201,6 @@ dma_err: dsp_new_err: sst_ipc_fini(ipc); ipc_init_err: - kfree(hsw); return ret; } EXPORT_SYMBOL_GPL(sst_hsw_dsp_init);

4 3

[alsa-devel] [PATCH -next] ASoC: cs35l32: Remove unused including <linux/version.h>
by weiyj_lk＠163.com 17 Apr '15

17 Apr '15

From: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> Remove including <linux/version.h> that don't need it. Signed-off-by: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> --- sound/soc/codecs/cs35l32.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs35l32.c b/sound/soc/codecs/cs35l32.c index 60598b2..8f40025 100644 --- a/sound/soc/codecs/cs35l32.c +++ b/sound/soc/codecs/cs35l32.c @@ -13,7 +13,6 @@ #include <linux/module.h> #include <linux/moduleparam.h> -#include <linux/version.h> #include <linux/kernel.h> #include <linux/init.h> #include <linux/delay.h>

3 2

[alsa-devel] [PATCH] ASoC: samsung: s3c24xx-i2s: Fix return value check in s3c24xx_iis_dev_probe()
by weiyj_lk＠163.com 17 Apr '15

17 Apr '15

From: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> --- sound/soc/samsung/s3c24xx-i2s.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/samsung/s3c24xx-i2s.c b/sound/soc/samsung/s3c24xx-i2s.c index 326d3c3..5bf7236 100644 --- a/sound/soc/samsung/s3c24xx-i2s.c +++ b/sound/soc/samsung/s3c24xx-i2s.c @@ -461,8 +461,8 @@ static int s3c24xx_iis_dev_probe(struct platform_device *pdev) return -ENOENT; } s3c24xx_i2s.regs = devm_ioremap_resource(&pdev->dev, res); - if (s3c24xx_i2s.regs == NULL) - return -ENXIO; + if (IS_ERR(s3c24xx_i2s.regs)) + return PTR_ERR(s3c24xx_i2s.regs); s3c24xx_i2s_pcm_stereo_out.dma_addr = res->start + S3C2410_IISFIFO; s3c24xx_i2s_pcm_stereo_in.dma_addr = res->start + S3C2410_IISFIFO;

3 2

[alsa-devel] [PATCH] ASoC: tfa9879: Fix return value check in tfa9879_i2c_probe()
by weiyj_lk＠163.com 17 Apr '15

17 Apr '15

From: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> In case of error, the function devm_kzalloc() returns NULL not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Signed-off-by: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> --- sound/soc/codecs/tfa9879.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9879.c index 16f1b71..aab0af6 100644 --- a/sound/soc/codecs/tfa9879.c +++ b/sound/soc/codecs/tfa9879.c @@ -280,8 +280,8 @@ static int tfa9879_i2c_probe(struct i2c_client *i2c, int i; tfa9879 = devm_kzalloc(&i2c->dev, sizeof(*tfa9879), GFP_KERNEL); - if (IS_ERR(tfa9879)) - return PTR_ERR(tfa9879); + if (!tfa9879) + return -ENOMEM; i2c_set_clientdata(i2c, tfa9879);

3 2

[alsa-devel] [PATCH] ASoC: fsl_ssi: Fix platform_get_irq() error handling
by Fabio Estevam 17 Apr '15

17 Apr '15

From: Fabio Estevam <fabio.estevam(a)freescale.com> We should check whether platform_get_irq() returns a negative number and propagate the error in this case. Signed-off-by: Fabio Estevam <fabio.estevam(a)freescale.com> --- sound/soc/fsl/fsl_ssi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index e8bb8ee..0d48804 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -1357,7 +1357,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) } ssi_private->irq = platform_get_irq(pdev, 0); - if (!ssi_private->irq) { + if (ssi_private->irq < 0) { dev_err(&pdev->dev, "no irq for node %s\n", pdev->name); return ssi_private->irq; } -- 1.9.1

2 1

[alsa-devel] [PATCH v3 0/2] ALSA: HDA: add stream params to hda core
by Vinod Koul 17 Apr '15

17 Apr '15

This two patches are splut form the series v2 as they are specfic to HDAC. First adds ASoC device type later to be used by ASOC driver and second for the stream params. Jeeja KP (1): ALSA: hda - add generic functions to set hdac stream params Ramesh Babu (1): ALSA: hda - add ASoC device type for hda core include/sound/hdaudio.h | 3 +++ sound/hda/hdac_stream.c | 38 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+) -- 1.7.9.5

2 3

Re: [alsa-devel] [PATCH] ASoC: max98090: add shutdown callback for max98090
by Caesar Wang 17 Apr '15

17 Apr '15

在 2015年04月17日 15:14, Anish Kumar 写道: > 在 2015年04月16日 10:41, Anish Kumar 写道: >> 在 2015年04月16日 05:14, Anish Kumar 写道: >>> 在 04/10/2015 03:38 AM, Anish Kumar 写道: >>>>> To fix pop noise when shutdown,the pop noise during shutdown >>>>> is the pmic cutoff power of codec without any notice. >>>> Is the power turned off without any intimation to the codec driver? >>>> Or is it physically removed? Can you describe the probelm >>>> better? >>>> When device is shutdown with playing music, the origin driver does nothing for shutdown operation, >>>> as a result, pmic will cut off the power of codec IC, thus cause a pop noise from speaker and headphone. >>>> So the patch added a shutdown callback for driver, enable volume smoothing and disable zero cross, >>>> this is referenced from mic_input which does the samething before mic switch. >>>> I'm very happy if some suggestion from maximintegrate . :-) >>> Please let me know if the patch worked for you. >>> Yes, the patch can work for me. >> I hope this patch is what you tested. >> >> +static void max98090_i2c_shutdown(struct i2c_client *i2c) >> +{ >> + struct max98090_priv *max98090 = dev_get_drvdata(&i2c->dev); >> + >> + dev_info(&i2c->dev, "shut down device\n"); >> + >> + /* enable zero crossing */ >> + regmap_write(max98090->regmap, >> + M98090_REG_LEVEL_CONTROL, M98090_ZDENN_MASK-1); >> + >> + /* turn down volume levels for all the outputs */ >> + regmap_write(max98090->regmap, >> + M98090_REG_RCV_LOUTL_VOLUME, 0x00); >> + regmap_write(max98090->regmap, >> + M98090_REG_LOUTR_VOLUME, 0x00); >> + regmap_write(max98090->regmap, >> + M98090_REG_LEFT_SPK_VOLUME, 0x00); >> + regmap_write(max98090->regmap, >> + M98090_REG_RIGHT_SPK_VOLUME, 0x00); >> + regmap_write(max98090->regmap, >> + M98090_REG_LEFT_HP_VOLUME, 0x00); >> + regmap_write(max98090->regmap, >> + M98090_REG_RIGHT_HP_VOLUME, 0x00); >> + regmap_write(max98090->regmap, >> + M98090_REG_DEVICE_SHUTDOWN, 0x00); >> + msleep(40); >> +} >> + >> Please go ahead and submit to Mark. > With the about is also useful to solve it. > > @zengxing, could you also help verify it? > Verified ? zengxing, who told me is useful to solve it. >>> We had tested on chromiumos. >>>> +static void max98090_i2c_shutdown(struct i2c_client *i2c) >>>> +{ >>>> + struct max98090_priv *max98090 = dev_get_drvdata(&i2c->dev); >>>> + >>>> + dev_info(&i2c->dev, "shut down device\n"); >>>> + >>>> + /* Enable volume smoothing, disable zero cross. This will cause >>>> + * a quick 40ms ramp to mute on shutdown. >>>> + */ >>>> + regmap_write(max98090->regmap, >>>> + M98090_REG_LEVEL_CONTROL, M98090_VSENN_MASK); >>>> + regmap_write(max98090->regmap, >>>> + M98090_REG_DEVICE_SHUTDOWN, 0x00); >>>> + msleep(40); >>>> +} >>>> + >>>> >>>> >>> >>> >> -- >> ************************************************************************************** >> 王晓腾 Caesar Wang >> Product R&D Dept.III >> Fuzhou Rockchip Electronics Co.Ltd >> Addr： NO.18 Building, A District, Fuzhou Software Park,Gulou District,Fuzhou, Fujian,China(Fuzhou Headquarters) >> 21F,Malata Building,Kejizhongyi Avenue,Nanshan District,Shenzhen (Shenzhen Office) >> Tel：+86-591-83991906/07 - 8221 >> Mobile:+86 15059456742 >> E-mail : wxt(a)rock-chips.com >> *************************************************************************************** >> *************************************************************************************** >> IMPORTANT NOTICE: This email is from Fuzhou Rockchip Electronics Co., Ltd .The contents of this email and any attachments may >> contain information that is privileged, confidential and/or exempt from disclosure under applicable law and relevant NDA. >> If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the >> information is STRICTLY PROHIBITED. Please immediately contact the sender as soon as possible and destroy the material >> in its entirety in any format. Thank you. >> *************************************************************************************** >> > -- > ************************************************************************************** > 王晓腾 Caesar Wang > Product R&D Dept.III > Fuzhou Rockchip Electronics Co.Ltd > Addr： NO.18 Building, A District, Fuzhou Software Park,Gulou District,Fuzhou, Fujian,China(Fuzhou Headquarters) > 21F,Malata Building,Kejizhongyi Avenue,Nanshan District,Shenzhen (Shenzhen Office) > Tel：+86-591-83991906/07 - 8221 > Mobile:+86 15059456742 > E-mail : wxt(a)rock-chips.com > *************************************************************************************** > *************************************************************************************** > IMPORTANT NOTICE: This email is from Fuzhou Rockchip Electronics Co., Ltd .The contents of this email and any attachments may > contain information that is privileged, confidential and/or exempt from disclosure under applicable law and relevant NDA. > If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the > information is STRICTLY PROHIBITED. Please immediately contact the sender as soon as possible and destroy the material > in its entirety in any format. Thank you. > *************************************************************************************** > > -- ************************************************************************************** 王晓腾 Caesar Wang Product R&D Dept.III Fuzhou Rockchip Electronics Co.Ltd Addr： NO.18 Building, A District, Fuzhou Software Park,Gulou District,Fuzhou, Fujian,China(Fuzhou Headquarters) 21F,Malata Building,Kejizhongyi Avenue,Nanshan District,Shenzhen (Shenzhen Office) Tel：+86-591-83991906/07 - 8221 Mobile:+86 15059456742 E-mail : wxt(a)rock-chips.com *************************************************************************************** *************************************************************************************** IMPORTANT NOTICE: This email is from Fuzhou Rockchip Electronics Co., Ltd .The contents of this email and any attachments may contain information that is privileged, confidential and/or exempt from disclosure under applicable law and relevant NDA. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information is STRICTLY PROHIBITED. Please immediately contact the sender as soon as possible and destroy the material in its entirety in any format. Thank you. ***************************************************************************************

1 0