April 2015 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] [pulseaudio-discuss] ThinkPad T-510 audio output mute LED non-workingness
by Takashi Iwai 16 May '15

16 May '15

[Switched Cc to alsa-devel ML, as it's irrelevant from PA but rather a driver issue.] At Mon, 27 Apr 2015 07:58:59 -0600, Glenn Golden wrote: > > Takashi Iwai <tiwai(a)suse.de> [2015-04-27 08:50:34 +0200]: > > > > Gah, I hate reports without alsa-info.sh output (not a link to > > somewhere else). > > > > Glenn, please attach alsa-info.sh outputs (run it with --no-upload > > option) and the whole dmesg output after boot. 3.19 should already > > contain the hook to thinkpad_acpi.c. If anything is missing, you > > should have a warning indicating it. > > > > Apologies for the omissions. Both are attached. Thanks! > Fwiw -- perhaps nothing at this point -- a good deal of info has also been > posted to the kernel bugtracker ticket: > > https://bugzilla.kernel.org/show_bug.cgi?id=96171 > > Re: "...you should have a warning indicating it": I'm an unskilled laboror > here w.r.t. kernel affairs, and not even sure what sort of warnings to be > looking for, so may have missed something important without realizing it. > Just let me know what add'l info you need, I'll be happy to post it. I do > appreciate your attention to the issue. I see no such warning in the log you attached, so it's not the issue, as it seems. Below is a debug patch, and now you should see messages like "XXX ..." in kernel log at loading the driver. If there is no such a message, it means that the thinkpad hook isn't built in at all. Please check the kernel log again with the patch. Takashi --- diff --git a/sound/pci/hda/thinkpad_helper.c b/sound/pci/hda/thinkpad_helper.c index 0a4ad5feb82e..48ce61e46599 100644 --- a/sound/pci/hda/thinkpad_helper.c +++ b/sound/pci/hda/thinkpad_helper.c @@ -34,6 +34,7 @@ static void update_tpacpi_mute_led(void *private_data, int enabled) if (old_vmaster_hook) old_vmaster_hook(private_data, enabled); + pr_info("XXX mute led updated %d\n", enabled); if (led_set_func) led_set_func(TPACPI_LED_MUTE, !enabled); } @@ -58,8 +59,10 @@ static void hda_fixup_thinkpad_acpi(struct hda_codec *codec, bool removefunc = false; if (action == HDA_FIXUP_ACT_PROBE) { + codec_info(codec, "XXX hda_fixup_thinkpad_acpi init...\n"); if (!is_thinkpad(codec)) return; + codec_info(codec, "XXX ok, this is thinkpad\n"); if (!led_set_func) led_set_func = symbol_request(tpacpi_led_set); if (!led_set_func) { @@ -70,18 +73,24 @@ static void hda_fixup_thinkpad_acpi(struct hda_codec *codec, removefunc = true; if (led_set_func(TPACPI_LED_MUTE, false) >= 0) { + codec_info(codec, "XXX ok, mute LED is hooked\n"); old_vmaster_hook = spec->vmaster_mute.hook; spec->vmaster_mute.hook = update_tpacpi_mute_led; removefunc = false; + } else { + codec_err(codec, "XXX mute LED NOT WORKING!\n"); } if (led_set_func(TPACPI_LED_MICMUTE, false) >= 0) { if (spec->num_adc_nids > 1) codec_dbg(codec, "Skipping micmute LED control due to several ADCs"); else { + codec_info(codec, "XXX ok, mic LED is hooked\n"); spec->cap_sync_hook = update_tpacpi_micmute_led; removefunc = false; } + } else { + codec_err(codec, "XXX mic LED NOT WORKING!\n"); } }

5 24

[alsa-devel] [PATCH v2 00/17] new locomo driver set
by Dmitry Eremin-Solenikov 13 May '15

13 May '15

Sharp Zaurus SL-5500 and SL-5600 use special companion Gate Array. With this patchset I tried to modernise and restructure the LoCoMo drivers. * Use platform bus and mfd core code * Use GPIO API instead of custom locomo GPIO code * Use irqdomains to manage IRQs * Split mixed locomolcd driver to lcd and backlight parts * Implement IRQ handling in GPIO driver * Implement SPI driver used as a host for mmc_spi device to control SD cards V1 was submitted about a half of a year ago. Major changes: * Use gpiod_* in most of places * Use regmap for accessing registers instead of manual RMW cycles * Split dac driver from core module to i2c bus and separate IIO driver * Replaced mdelay() calls with usleep_range or msleep where it was suitable * Rewrote SPI driver to use core transfer_one() interface

7 38

[alsa-devel] [PATCH 0/5] ASoC: rsnd: tidyup patches
by Kuninori Morimoto 12 May '15

12 May '15

Hi Mark These are not so very important, but tidyup patches for Renesas R-Car driver. Kuninori Morimoto (5): ASoC: rsnd: add rsnd_dai_to_priv() macro ASoC: rsnd: make sure it uses lock when it calls rsnd_dai_call ASoC: rsnd: tidyup SSI parent related function/macro names ASoC: rsnd: make sure SSI parent/child uses same number of sound channel. ASoC: rsnd: care snd_kcontrol's index sound/soc/sh/rcar/core.c | 34 +++++++++++++++++++++++++++------- sound/soc/sh/rcar/ssi.c | 52 +++++++++++++++++++++++++++++++++++++++++++++------- 2 files changed, 72 insertions(+), 14 deletions(-) Best regards --- Kuninori Morimoto

3 11

[alsa-devel] [PATCH 0/3] ASoC: DPCM can care FE/BE merged format
by Kuninori Morimoto 11 May '15

11 May '15

Hi Mark These patches add new .dpcm_merged_foramt to merge FE/BE formats. It will be no sound if DPCM were below style, and user selects S24_LE. FE: S16_LE/S24_LE BE: S16_LE DPCM will selects FE/BE merged formats (= S16_LE here) if FE has .dpcm_merged_foramt. Kuninori Morimoto (3): ASoC: soc.h: tidyup struct snd_soc_dai_link definition order ASoC: soc-pcm: DPCM cares BE format ASoC: rsnd: rsrc-card uses FE/BE merged format when DPCM include/sound/soc.h | 39 +++++++++++++++++++++------------------ sound/soc/sh/rcar/rsrc-card.c | 1 + sound/soc/soc-pcm.c | 47 ++++++++++++++++++++++++++++++++++++++++++----- 3 files changed, 64 insertions(+), 23 deletions(-) Best regards --- Kuninori Morimoto

3 12

[alsa-devel] Alsa triggering methods
by Andy Ng 07 May '15

07 May '15

Hi, I am working on a ALSA card driver that handles a DSP instance. The problem I have is that the triggering mechanism in ALSA to start a PCM has the interrupts disabled, and my dsp framework is actually acknowledging the start trigger with an event after 50 microseconds time that I can't handle because the IRQs are disabled. Is there any way when the trigger mechanism goes down to the card to be able to handle any acknowledgements what will happen within a sort period of time. I have seen bespoke triggering method but not sure if everyone is using it. Any ideas would be helpful. Best regards, Andreas

3 2

[alsa-devel] [PATCH] ASoC: omap-twl4030: Use card DAPM context to access widgets
by Lars-Peter Clausen 06 May '15

06 May '15

Use the card DAPM context instead of the CODEC DAPM context since only card level widgets are accessed here. Signed-off-by: Lars-Peter Clausen <lars(a)metafoo.de> --- sound/soc/omap/omap-twl4030.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/omap/omap-twl4030.c b/sound/soc/omap/omap-twl4030.c index 3673ada..7431314 100644 --- a/sound/soc/omap/omap-twl4030.c +++ b/sound/soc/omap/omap-twl4030.c @@ -159,9 +159,8 @@ static inline void twl4030_disconnect_pin(struct snd_soc_dapm_context *dapm, static int omap_twl4030_init(struct snd_soc_pcm_runtime *rtd) { - struct snd_soc_codec *codec = rtd->codec; struct snd_soc_card *card = rtd->card; - struct snd_soc_dapm_context *dapm = &codec->dapm; + struct snd_soc_dapm_context *dapm = &card->dapm; struct omap_tw4030_pdata *pdata = dev_get_platdata(card->dev); struct omap_twl4030 *priv = snd_soc_card_get_drvdata(card); int ret = 0; -- 1.8.0

2 1

[alsa-devel] [PATCH v3 0/7] ASoC: intel - add skylake PCM driver
by Vinod Koul 06 May '15

06 May '15

This patch series adds the hda codec wrapper first followed by asoc hda controller library, then SKL PCM driver and last decouples the controller for splitting the links Jeeja KP (7): ASoC: hda - add soc hda codec driver wrapper ALSA: hda - add new HDA registers ASoC: hda - adds SoC controller and stream operations ASoC: intel - add Skylake HDA platform driver ASoC: intel - add Skylake HDA audio driver ASoC: intel - add makefile support for SKL driver ASoC: intel - adds support for decoupled mode in skl driver include/sound/hda_register.h | 87 +++ include/sound/soc-hdaudio.h | 343 ++++++++++++ sound/soc/Kconfig | 1 + sound/soc/Makefile | 1 + sound/soc/hda/Kconfig | 3 + sound/soc/hda/Makefile | 3 + sound/soc/hda/soc-hda-codec.c | 85 +++ sound/soc/hda/soc-hda-codec.h | 44 ++ sound/soc/hda/soc-hdac-controller.c | 289 ++++++++++ sound/soc/hda/soc-hdac-stream.c | 390 ++++++++++++++ sound/soc/intel/Kconfig | 20 + sound/soc/intel/Makefile | 1 + sound/soc/intel/skylake/Makefile | 3 + sound/soc/intel/skylake/hda-skl-pcm.c | 933 +++++++++++++++++++++++++++++++++ sound/soc/intel/skylake/hda-skl.c | 743 ++++++++++++++++++++++++++ sound/soc/intel/skylake/hda-skl.h | 74 +++ 16 files changed, 3020 insertions(+) create mode 100644 include/sound/soc-hdaudio.h create mode 100644 sound/soc/hda/Kconfig create mode 100644 sound/soc/hda/Makefile create mode 100644 sound/soc/hda/soc-hda-codec.c create mode 100644 sound/soc/hda/soc-hda-codec.h create mode 100644 sound/soc/hda/soc-hdac-controller.c create mode 100644 sound/soc/hda/soc-hdac-stream.c create mode 100644 sound/soc/intel/skylake/Makefile create mode 100644 sound/soc/intel/skylake/hda-skl-pcm.c create mode 100644 sound/soc/intel/skylake/hda-skl.c create mode 100644 sound/soc/intel/skylake/hda-skl.h -- 1.7.9.5

3 25

[alsa-devel] [PATCH v11 0/3] ASoC: tda998x: add a codec to the HDMI transmitter
by Jean-Francois Moine 06 May '15

06 May '15

Based on 4.1-rc1 v11: - reduce the patch series to adding the tda998x codec only v10: - add the generic dt-card - define the audio ports from a DT graph of ports (Russell King) - reuse HDMI constants (Andrew Jackson - Jyri Sarha) - alloc rate_constraints in codec (Jyri Sarha) - fix bad number of channels (Jyri Sarha) - correct codec generation from config (Russell King - Jyri Sarha) - no module init/exit (Russell King) v9: - back to a TDA998x specific CODEC - more comments - change magic values to constants v8: - change some comments about the patches v7: - remove the change of the K predivider (Jyri Sarha) - add S24_3LE and S32_LE as possible audio formats (Jyri Sarha) - don't move the struct priv2 definition and use the slave encoder private data as the device private data (Russell King) - remove the useless request_module (Russell King/Mark Brown) - don't lock the HDMI module (Russell King) - use platform_device_unregister to remove the codec (Russell King) v6: - extend the HDMI CODEC instead of using a specific CODEC v5: - use the TDA998x private data instead of a specific area for the CODEC interface - the CODEC is TDA998x specific (Mark Brown) v4: - remove all the TDA998x specific stuff from the CODEC - move the EDID scan from the CODEC to the TDA998x - move the CODEC to sound/soc (Mark Brown) - update the audio_sample_rate from the EDID (Andrew Jackson) v3: fix bad rate (Andrew Jackson) v2: check double stream start (Mark Brown) Jean-Francois Moine (3): drm/i2c: tda998x: Add support of a DT graph of ports drm/i2c: tda998x: Change drvdata for audio extension ASoC: tda998x: add a codec to the HDMI transmitter .../devicetree/bindings/drm/i2c/tda998x.txt | 51 +++++ drivers/gpu/drm/i2c/tda998x_drv.c | 220 +++++++++++++++++++-- include/sound/tda998x.h | 30 +++ sound/soc/codecs/Kconfig | 5 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/tda998x.c | 174 ++++++++++++++++ 6 files changed, 471 insertions(+), 11 deletions(-) create mode 100644 include/sound/tda998x.h create mode 100644 sound/soc/codecs/tda998x.c -- 2.1.4

2 4

[alsa-devel] [PATCH 1/6] ASoC: rt5645: remove RT5645_I2S_BCLK_MS1 control
by Bard Liao 05 May '15

05 May '15

RT5645_I2S_BCLK_MS1 (reg 0x73 [5]) is reserverd in rt5645 and rt5650. This function is move to TDM control. We can configure it by snd_soc_dai_set_tdm_slot's slot_width parameter. Signed-off-by: Bard Liao <bardliao(a)realtek.com> --- sound/soc/codecs/rt5645.c | 5 ++--- sound/soc/codecs/rt5645.h | 4 ---- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 8bad9fe..33ebe88 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -2104,9 +2104,8 @@ static int rt5645_hw_params(struct snd_pcm_substream *substream, switch (dai->id) { case RT5645_AIF1: - mask_clk = RT5645_I2S_BCLK_MS1_MASK | RT5645_I2S_PD1_MASK; - val_clk = bclk_ms << RT5645_I2S_BCLK_MS1_SFT | - pre_div << RT5645_I2S_PD1_SFT; + mask_clk = RT5645_I2S_PD1_MASK; + val_clk = pre_div << RT5645_I2S_PD1_SFT; snd_soc_update_bits(codec, RT5645_I2S1_SDP, (0x3 << dl_sft), (val_len << dl_sft)); snd_soc_update_bits(codec, RT5645_ADDA_CLK1, mask_clk, val_clk); diff --git a/sound/soc/codecs/rt5645.h b/sound/soc/codecs/rt5645.h index 4473636..fa5c560 100644 --- a/sound/soc/codecs/rt5645.h +++ b/sound/soc/codecs/rt5645.h @@ -942,10 +942,6 @@ #define RT5645_I2S2_SDI_I2S2 (0x1 << 6) /* ADC/DAC Clock Control 1 (0x73) */ -#define RT5645_I2S_BCLK_MS1_MASK (0x1 << 15) -#define RT5645_I2S_BCLK_MS1_SFT 15 -#define RT5645_I2S_BCLK_MS1_32 (0x0 << 15) -#define RT5645_I2S_BCLK_MS1_64 (0x1 << 15) #define RT5645_I2S_PD1_MASK (0x7 << 12) #define RT5645_I2S_PD1_SFT 12 #define RT5645_I2S_PD1_1 (0x0 << 12) -- 1.8.1.1.439.g50a6b54

2 11

[alsa-devel] [PATCH 1/4] ASoC: Intel: Add support max98090 in sst driver
by yang.a.fang＠intel.com 04 May '15

04 May '15

From: "Fang, Yang A" <yang.a.fang(a)intel.com> Added entry in sst driver to support max98090 codec for intel Braswell platform. Signed-off-by: Fang, Yang A <yang.a.fang(a)intel.com> --- sound/soc/intel/atom/sst/sst_acpi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c index fc02a48..bb19b58 100644 --- a/sound/soc/intel/atom/sst/sst_acpi.c +++ b/sound/soc/intel/atom/sst/sst_acpi.c @@ -356,6 +356,8 @@ static struct sst_machines sst_acpi_chv[] = { &chv_platform_data }, {"10EC5650", "cht-bsw", "cht-bsw-rt5645", NULL, "intel/fw_sst_22a8.bin", &chv_platform_data }, + {"193C9890", "cht-bsw", "cht-bsw-max98090", NULL, + "intel/fw_sst_22a8.bin", &chv_platform_data }, {}, }; -- 1.7.9.5

7 23