March 2015 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] ti, codec property in sound/soc/omap/omap-twl4030.c not used
by Belisko Marek 12 Mar '15

12 Mar '15

Hi, I'm looking at sources for omap-twl4030.c driver which is used by many boards. In DT bindings documentation is property ti,codec described as mandatory but it's never parsed in driver code. I did small experiment in gta04 board and remove ti,codec from devicetree and sound was working. I think it can be removed from documentation and also from various device trees. Is my assumption correct? Thanks. BR, marek -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite twitter: #opennandra web: http://open-nandra.com

2 2

[alsa-devel] [PATCH] ALSA: snd-usb: add quirks for Roland UA-22
by Daniel Mack 12 Mar '15

12 Mar '15

The device complies to the UAC1 standard but hides that fact with proprietary descriptors. The autodetect quirk for Roland devices catches the audio interface but misses the MIDI part, so a specific quirk is needed. Signed-off-by: Daniel Mack <daniel(a)zonque.org> Reported-by: Rafa Lafuente <rafalafuente(a)gmail.com> Tested-by: Raphaël Doursenaud <raphael(a)doursenaud.fr> --- sound/usb/quirks-table.h | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h index 67d4765..07f984d 100644 --- a/sound/usb/quirks-table.h +++ b/sound/usb/quirks-table.h @@ -1773,6 +1773,36 @@ YAMAHA_DEVICE(0x7010, "UB99"), } } }, +{ + USB_DEVICE(0x0582, 0x0159), + .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { + /* .vendor_name = "Roland", */ + /* .product_name = "UA-22", */ + .ifnum = QUIRK_ANY_INTERFACE, + .type = QUIRK_COMPOSITE, + .data = (const struct snd_usb_audio_quirk[]) { + { + .ifnum = 0, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + { + .ifnum = 1, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + { + .ifnum = 2, + .type = QUIRK_MIDI_FIXED_ENDPOINT, + .data = & (const struct snd_usb_midi_endpoint_info) { + .out_cables = 0x0001, + .in_cables = 0x0001 + } + }, + { + .ifnum = -1 + } + } + } +}, /* this catches most recent vendor-specific Roland devices */ { .match_flags = USB_DEVICE_ID_MATCH_VENDOR | -- 2.3.1

2 1

[alsa-devel] [PATCH 41/45] include/uapi/sound/emu10k1.h: hide gpr_valid, tram_valid and code_valid in userspace
by Mikko Rapeli 12 Mar '15

12 Mar '15

The DECLARE_BITMAP macro is not available in userspace headers. Fixes userspace compile error: error: expected specifier-qualifier-list before ‘DECLARE_BITMAP’ Signed-off-by: Mikko Rapeli <mikko.rapeli(a)iki.fi> --- include/uapi/sound/emu10k1.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/uapi/sound/emu10k1.h b/include/uapi/sound/emu10k1.h index ec1535b..f2fd870 100644 --- a/include/uapi/sound/emu10k1.h +++ b/include/uapi/sound/emu10k1.h @@ -300,7 +300,9 @@ struct snd_emu10k1_fx8010_control_old_gpr { struct snd_emu10k1_fx8010_code { char name[128]; +#ifdef __KERNEL__ DECLARE_BITMAP(gpr_valid, 0x200); /* bitmask of valid initializers */ +#endif __u32 __user *gpr_map; /* initializers */ unsigned int gpr_add_control_count; /* count of GPR controls to add/replace */ @@ -313,11 +315,15 @@ struct snd_emu10k1_fx8010_code { unsigned int gpr_list_control_total; /* total count of GPR controls */ struct snd_emu10k1_fx8010_control_gpr __user *gpr_list_controls; /* listed GPR controls */ +#ifdef __KERNEL__ DECLARE_BITMAP(tram_valid, 0x100); /* bitmask of valid initializers */ +#endif __u32 __user *tram_data_map; /* data initializers */ __u32 __user *tram_addr_map; /* map initializers */ +#ifdef __KERNEL__ DECLARE_BITMAP(code_valid, 1024); /* bitmask of valid instructions */ +#endif __u32 __user *code; /* one instruction - 64 bits */ }; -- 2.1.4

3 7

[alsa-devel] [PATCH] rate: Allow LGPL for libsamplerate commercial licensee
by Takashi Iwai 12 Mar '15

12 Mar '15

alsa-plugins-rate is tagged with GPL just for following the license of libsamplerate. However, libsamplerate provides a commercial license to allow it used with less restrictions. In that case, we also don't have to stick with GPL. Instead, the code follows LGPL like other plugin codes in this package. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- If anyone sees a legal problem with this, please let me know. I find it OK, but IANAL. rate/rate_samplerate.c | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/rate/rate_samplerate.c b/rate/rate_samplerate.c index 53a0627b21dc..0b14a59000bf 100644 --- a/rate/rate_samplerate.c +++ b/rate/rate_samplerate.c @@ -3,6 +3,14 @@ * * Copyright (c) 2006 by Takashi Iwai <tiwai(a)suse.de> * + * This plugin code is supposed to be used and distributed primarily + * under GPL v2 or later, in order to follow the license of libsamplerate. + * However, if you already own a commercial license to use libsamplerate + * for dynamic linking, this plugin code can be used and distributed also + * under LGPL v2.1 or later. + * + * For GPL-2.0+: + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or @@ -13,9 +21,17 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA. + * For LGPL-2.1+: + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. */ #include <stdio.h> -- 2.3.2

1 0

[alsa-devel] [PATCH] sound:pci:Change return type of function, shift_bits in xonar_dg.c to avoid overflow
by Nicholas Krause 12 Mar '15

12 Mar '15

This changes the return type of the function,shift_bits to unsigned long in order to avoid overflowing issues with this function when called as found when running sparse on the kernel source tree. Signed-off-by: Nicholas Krause <xerofoify(a)gmail.com> --- sound/pci/oxygen/xonar_dg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/oxygen/xonar_dg.c b/sound/pci/oxygen/xonar_dg.c index 4cf3200..2337a76 100644 --- a/sound/pci/oxygen/xonar_dg.c +++ b/sound/pci/oxygen/xonar_dg.c @@ -238,7 +238,7 @@ void set_cs4245_adc_params(struct oxygen *chip, cs4245_write_spi(chip, CS4245_MCLK_FREQ); } -static inline unsigned int shift_bits(unsigned int value, +static inline unsigned long shift_bits(unsigned int value, unsigned int shift_from, unsigned int shift_to, unsigned int mask) -- 2.1.0

3 2

[alsa-devel] [PATCH] ALSA: control: Add sanity checks for user ctl id name string
by Takashi Iwai 12 Mar '15

12 Mar '15

There was no check about the id string of user control elements, so we accepted even a control element with an empty string, which is obviously bogus. This patch adds more sanity checks of id strings. Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/control.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/core/control.c b/sound/core/control.c index 35324a8e83c8..7ed2b214b16d 100644 --- a/sound/core/control.c +++ b/sound/core/control.c @@ -1170,6 +1170,10 @@ static int snd_ctl_elem_add(struct snd_ctl_file *file, if (info->count < 1) return -EINVAL; + if (*info->id.name) + return -EINVAL; + if (strnlen(info->id.name, sizeof(info->id.name)) > sizeof(info->id.name)) + return -EINVAL; access = info->access == 0 ? SNDRV_CTL_ELEM_ACCESS_READWRITE : (info->access & (SNDRV_CTL_ELEM_ACCESS_READWRITE| SNDRV_CTL_ELEM_ACCESS_INACTIVE| -- 2.3.2

2 2

[alsa-devel] [PATCH 03/22] sound: %pF is only for function pointers
by Scott Wood 12 Mar '15

12 Mar '15

Use %pS for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pF expects a function descriptor. Signed-off-by: Scott Wood <scottwood(a)freescale.com> Cc: alsa-devel(a)alsa-project.org --- sound/core/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/device.c b/sound/core/device.c index 41bec30..4879711 100644 --- a/sound/core/device.c +++ b/sound/core/device.c @@ -127,7 +127,7 @@ void snd_device_free(struct snd_card *card, void *device_data) if (dev) __snd_device_free(dev); else - dev_dbg(card->dev, "device free %p (from %pF), not found\n", + dev_dbg(card->dev, "device free %p (from %pS), not found\n", device_data, __builtin_return_address(0)); } EXPORT_SYMBOL(snd_device_free); -- 2.1.0

1 0

[alsa-devel] [PATCH 0/8] Fix struct clk pointer comparing
by Shawn Guo 12 Mar '15

12 Mar '15

On the first day back from Chinese new year holiday, I got a regression report from rmk, saying Ethernet stops working on HimmingBoard with v4.0-rc1. I read through the thread [1] and found a couple of i.MX audio drivers are also affected per Stephen's Coccinelle report. That's why I came up with this series based on Quentin's structclk.cocci, Stephen's result and Mike's input (thanks all). The first two patches are run-time tested and all others are compile-tested only. [1] http://thread.gmane.org/gmane.linux.kernel/1872604/focus=1880862 Shawn Guo (8): clk: add helper function clk_is_match() ARM: imx: fix struct clk pointer comparing drm: armada: fix struct clk pointer comparing pwm: atmel-hlcdc: fix struct clk pointer comparing serial: samsung: fix struct clk pointer comparing ASoC: fsl_esai: fix struct clk pointer comparing ASoC: fsl_spdif: fix struct clk pointer comparing ASoC: kirkwood: fix struct clk pointer comparing arch/arm/mach-imx/mach-imx6q.c | 5 +++-- drivers/clk/clk.c | 6 ++++++ drivers/gpu/drm/armada/armada_510.c | 2 +- drivers/pwm/pwm-atmel-hlcdc.c | 2 +- drivers/tty/serial/samsung.c | 2 +- include/linux/clk.h | 16 ++++++++++++++++ sound/soc/fsl/fsl_esai.c | 2 +- sound/soc/fsl/fsl_spdif.c | 4 ++-- sound/soc/kirkwood/kirkwood-i2s.c | 2 +- 9 files changed, 32 insertions(+), 9 deletions(-) -- 1.9.1

15 40

[alsa-devel] [asoc:topic/max98925 1/1] sound/soc/codecs/max98925.c:189:1: sparse: symbol 'max98925_spk_tlv' was not declared. Should it be static?
by kbuild test robot 11 Mar '15

11 Mar '15

tree: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/max98925 head: 31bdf73603f61a22c1643d1d887cf36eaa3a6834 commit: 31bdf73603f61a22c1643d1d887cf36eaa3a6834 [1/1] ASoC: Add max98925 codec driver reproduce: # apt-get install sparse git checkout 31bdf73603f61a22c1643d1d887cf36eaa3a6834 make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> sound/soc/codecs/max98925.c:189:1: sparse: symbol 'max98925_spk_tlv' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation

2 2

[alsa-devel] [PATCH 0/15] don't export static symbol
by Julia Lawall 11 Mar '15

11 Mar '15

These patches remove EXPORT_SYMBOL or EXPORT_SYMBOL_GPL declarations on static functions. This was done using the following semantic patch: (http://coccinelle.lip6.fr/) // <smpl> @r@ type T; identifier f; @@ static T f (...) { ... } @@ identifier r.f; declarer name EXPORT_SYMBOL; @@ -EXPORT_SYMBOL(f); @@ identifier r.f; declarer name EXPORT_SYMBOL_GPL; @@ -EXPORT_SYMBOL_GPL(f); // </smpl>

2 2