February 2015 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/3] Fixing snd_use_case_get() bugs
by Tanu Kaskinen 17 Feb '15

17 Feb '15

Tanu Kaskinen (3): ucm: fix incorrect error code sign ucm: fix the logic of choosing the default cdev ucm: fix some variable constness issues include/use-case.h | 5 +++-- src/ucm/main.c | 51 ++++++++++++++++++++++++++++++++------------------- 2 files changed, 35 insertions(+), 21 deletions(-) -- 1.9.3

2 4

[alsa-devel] [PATCH] ALSA: usb: Fix support for Denon DA-300USB DAC (ID 154e:1003)
by Takashi Iwai 17 Feb '15

17 Feb '15

From: Frank C Guenther <bugzilla.frnkcg(a)spamgourmet.com> Fix problem where playback of Denon DA-300USB DAC sometimes does not start and leads to error messages like "clock source 41 is not valid, cannot use". Solution: Treat this device the same as other Denon/Marantz devices in sound/usb/quirks.c. Tested with both PCM and DSD formats. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=93261 Signed-off-by: Frank C Guenther <bugzilla.frnkcg(a)spamgourmet.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/usb/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 5c0c05314df0..753a47de8459 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1127,6 +1127,7 @@ int snd_usb_select_mode_quirk(struct snd_usb_substream *subs, int err; switch (subs->stream->chip->usb_id) { + case USB_ID(0x154e, 0x1003): /* Denon DA-300USB */ case USB_ID(0x154e, 0x3005): /* Marantz HD-DAC1 */ case USB_ID(0x154e, 0x3006): /* Marantz SA-14S1 */ @@ -1206,6 +1207,7 @@ void snd_usb_ctl_msg_quirk(struct usb_device *dev, unsigned int pipe, (requesttype & USB_TYPE_MASK) == USB_TYPE_CLASS) { switch (le16_to_cpu(dev->descriptor.idProduct)) { + case 0x1003: /* Denon DA300-USB */ case 0x3005: /* Marantz HD-DAC1 */ case 0x3006: /* Marantz SA-14S1 */ mdelay(20); @@ -1267,6 +1269,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip, /* Denon/Marantz devices with USB DAC functionality */ switch (chip->usb_id) { + case USB_ID(0x154e, 0x1003): /* Denon DA300-USB */ case USB_ID(0x154e, 0x3005): /* Marantz HD-DAC1 */ case USB_ID(0x154e, 0x3006): /* Marantz SA-14S1 */ if (fp->altsetting == 2) -- 2.3.0

1 0

[alsa-devel] [PATCH] ASoC: Intel: add SNDRV_PCM_INFO_DRAIN_TRIGGER flag
by libin.yang＠intel.com 17 Feb '15

17 Feb '15

From: Libin Yang <libin.yang(a)intel.com> Add SNDRV_PCM_INFO_DRAIN_TRIGGER in snd_pcm_hardware.info to call sst_hsw_stream_set_silence_start() when PCM draining. Signed-off-by: Libin Yang <libin.yang(a)intel.com> --- sound/soc/intel/sst-haswell-pcm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/sst-haswell-pcm.c b/sound/soc/intel/sst-haswell-pcm.c index d6fa9d5..7e21e8f 100644 --- a/sound/soc/intel/sst-haswell-pcm.c +++ b/sound/soc/intel/sst-haswell-pcm.c @@ -91,7 +91,8 @@ static const struct snd_pcm_hardware hsw_pcm_hardware = { SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME | - SNDRV_PCM_INFO_NO_PERIOD_WAKEUP, + SNDRV_PCM_INFO_NO_PERIOD_WAKEUP | + SNDRV_PCM_INFO_DRAIN_TRIGGER, .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE, .period_bytes_min = PAGE_SIZE, -- 1.9.1

3 3

[alsa-devel] [PATCH 40/45] include/uapi/sound/emu10k1.h: include sound/asound.h
by Mikko Rapeli 17 Feb '15

17 Feb '15

Fixes userspace compilation errors like: error: field ‘id’ has incomplete type struct snd_ctl_elem_id id; /* full control ID definition */ Signed-off-by: Mikko Rapeli <mikko.rapeli(a)iki.fi> --- include/uapi/sound/emu10k1.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/uapi/sound/emu10k1.h b/include/uapi/sound/emu10k1.h index d1bbaf7..ec1535b 100644 --- a/include/uapi/sound/emu10k1.h +++ b/include/uapi/sound/emu10k1.h @@ -23,8 +23,7 @@ #define _UAPI__SOUND_EMU10K1_H #include <linux/types.h> - - +#include <sound/asound.h> /* * ---- FX8010 ---- -- 2.1.4

2 1

[alsa-devel] [PATCH 39/45] include/uapi/sound/asequencer.h: include sound/asound.h
by Mikko Rapeli 17 Feb '15

17 Feb '15

Fixes userspace compilation error: error: unknown type name ‘snd_seq_client_type_t’ snd_seq_client_type_t type; /* client type */ Signed-off-by: Mikko Rapeli <mikko.rapeli(a)iki.fi> --- include/uapi/sound/asequencer.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/sound/asequencer.h b/include/uapi/sound/asequencer.h index 09c8a00..5a5fa49 100644 --- a/include/uapi/sound/asequencer.h +++ b/include/uapi/sound/asequencer.h @@ -22,6 +22,7 @@ #ifndef _UAPI__SOUND_ASEQUENCER_H #define _UAPI__SOUND_ASEQUENCER_H +#include <sound/asound.h> /** version of the sequencer */ #define SNDRV_SEQ_VERSION SNDRV_PROTOCOL_VERSION (1, 0, 1) -- 2.1.4

2 1

[alsa-devel] [PATCH 35/45] include/uapi/sound/asound.h: include stdlib.h in userspace
by Mikko Rapeli 17 Feb '15

17 Feb '15

Fixes compiler errors like: error: field ‘trigger_tstamp’ has incomplete type error: invalid application of ‘sizeof’ to incomplete t ype ‘struct timespec’ Signed-off-by: Mikko Rapeli <mikko.rapeli(a)iki.fi> --- include/uapi/sound/asound.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h index 941d32f..af156b0 100644 --- a/include/uapi/sound/asound.h +++ b/include/uapi/sound/asound.h @@ -25,6 +25,9 @@ #include <linux/types.h> +#ifndef __KERNEL__ +#include <stdlib.h> +#endif /* * protocol version -- 2.1.4

2 1

[alsa-devel] [PATCH 0/3] ALSA: hdspm - Remove various code duplication
by Adrian Knoth 17 Feb '15

17 Feb '15

From: Adrian Knoth <aknoth(a)google.com> Hi! As promised last week, here's a series that removes code duplication in hdspm.c. Adrian Knoth (3): ALSA: hdspm - DRY cleanup in .open callbacks ALSA: hdspm - DRY cleanup in .release callback ALSA: hdspm - DRY cleanup of snd_pcm_ops sound/pci/rme9652/hdspm.c | 141 ++++++++++++---------------------------------- 1 file changed, 35 insertions(+), 106 deletions(-) -- 2.1.0

2 4

[alsa-devel] [PATCH v2] ALSA: usb-audio: Don't attempt to get Lifecam HD-5000 sample rate
by Joe Turner 17 Feb '15

17 Feb '15

Adds a quirk to disable the check that the sample rate has been set correctly, as the Lifecam does not support getting the sample rate. This means that we don't need to wait for the USB timeout when attempting to get the sample rate. Waiting for the timeout causes problems in some applications, which give up on the device acquisition process before it has had time to complete, resulting in no sound. Signed-off-by: Joe Turner <joe(a)oampo.co.uk> --- Changes in v2: - Fixed code style, as suggested by Takashi Iwai <tiwai(a)suse.de> sound/usb/clock.c | 5 +++++ sound/usb/quirks.c | 5 +++++ sound/usb/quirks.h | 2 ++ 3 files changed, 12 insertions(+) diff --git a/sound/usb/clock.c b/sound/usb/clock.c index 03fed66..9d6e709 100644 --- a/sound/usb/clock.c +++ b/sound/usb/clock.c @@ -303,6 +303,11 @@ static int set_sample_rate_v1(struct snd_usb_audio *chip, int iface, return err; } + /* Don't check the sample rate for devices which we know don't + * support reading */ + if (snd_usb_get_sample_rate_quirk(chip)) + return 0; + if ((err = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), UAC_GET_CUR, USB_TYPE_CLASS | USB_RECIP_ENDPOINT | USB_DIR_IN, UAC_EP_CS_ATTR_SAMPLE_RATE << 8, ep, diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index a739841..50add5e 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1111,6 +1111,11 @@ void snd_usb_set_format_quirk(struct snd_usb_substream *subs, } } +int snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip) +{ + /* MS Lifecam HD-5000 doesn't support reading the sample rate. */ + return chip->usb_id == USB_ID(0x045E, 0x076D); +} /* Marantz/Denon USB DACs need a vendor cmd to switch * between PCM and native DSD mode diff --git a/sound/usb/quirks.h b/sound/usb/quirks.h index 1b86238..428c158 100644 --- a/sound/usb/quirks.h +++ b/sound/usb/quirks.h @@ -21,6 +21,8 @@ int snd_usb_apply_boot_quirk(struct usb_device *dev, void snd_usb_set_format_quirk(struct snd_usb_substream *subs, struct audioformat *fmt); +int snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip); + int snd_usb_is_big_endian_format(struct snd_usb_audio *chip, struct audioformat *fp); -- 2.3.0

2 1

[alsa-devel] iMX6 SSI driver: fsl_ssi vs imx-ssi
by Xuebing Wang 17 Feb '15

17 Feb '15

Hi community, I am developing an ASOC codec driver based on iMX6SL platform. I noticed there are fsl_ssi.c and imx-ssi.c in folder sound/soc/fsl. Would you please tell me what are the differences between these 2, and which one should I use? Thanks. -- Xuebing

2 2

[alsa-devel] [PATCH] .gitignore: add test-driver
by Tanu Kaskinen 16 Feb '15

16 Feb '15

Signed-off-by: Tanu Kaskinen <tanu.kaskinen(a)linux.intel.com> --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 05a2459..e1cc163 100644 --- a/.gitignore +++ b/.gitignore @@ -11,6 +11,7 @@ Makefile libtool depcomp ltmain.sh +test-driver version Makefile.in aclocal.m4 -- 1.9.3

2 3