February 2015 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] sound/pci/hda/hda_tegra.c
by Eliot Blennerhassett 13 Feb '15

13 Feb '15

Browsing code I came across this... sound/pci/hda/hda_tegra.c static int hda_tegra_init_chip(struct azx *chip, struct platform_device *pdev) ... res = platform_get_resource(pdev, IORESOURCE_MEM, 0); hda->regs = devm_ioremap_resource(dev, res); Checking chip->remap_addr before assignment looks wierd to me, am I missing something? Should it be 'hda->regs' here? if (IS_ERR(chip->remap_addr)) return PTR_ERR(chip->remap_addr); chip->remap_addr = hda->regs + HDA_BAR0; chip->addr = res->start + HDA_BAR0;

2 1

[alsa-devel] [PATCH] ALSA: hda - enable mute led quirk for one more hp machine.
by Hui Wang 13 Feb '15

13 Feb '15

Otherwise, the mute led can't work at all. Tested-by: Taihsiang Ho <taihsiang.ho(a)canonical.com> Cc: <stable(a)vger.kernel.org> BugLink: https://bugs.launchpad.net/bugs/1410704 Signed-off-by: Hui Wang <hui.wang(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index ddb9308..b2b24a8 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4937,6 +4937,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x218b, "HP", ALC269_FIXUP_LIMIT_INT_MIC_BOOST_MUTE_LED), SND_PCI_QUIRK(0x103c, 0x225f, "HP", ALC280_FIXUP_HP_GPIO2_MIC_HOTKEY), /* ALC282 */ + SND_PCI_QUIRK(0x103c, 0x21f9, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1), SND_PCI_QUIRK(0x103c, 0x2210, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1), SND_PCI_QUIRK(0x103c, 0x2214, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1), SND_PCI_QUIRK(0x103c, 0x2236, "HP", ALC269_FIXUP_HP_LINE1_MIC1_LED), -- 1.9.1

2 1

[alsa-devel] [PATCH 0/5] ALSA: control: improve core codes with intrusion
by Takashi Sakamoto 13 Feb '15

13 Feb '15

This patchset is for improving core control codes. Most of them have any effects for processing, messaging or status codes. This patchset is based on my previous one: [alsa-devel] [PATCH 0/8] ALSA: control: refactoring core codes http://mailman.alsa-project.org/pipermail/alsa-devel/2015-February/087783.h… Takashi Sakamoto (5): ALSA: control: drop a sub-effect for caller's data ALSA: control: use dev_dbg() for warning to add duplicated controls ALSA: control: fix logic error about control count in a device ALSA: control: improve returned value because of the rest ALSA: control: save stack usage at creating new instance sound/core/control.c | 209 ++++++++++++++++++++++++++++----------------------- 1 file changed, 116 insertions(+), 93 deletions(-) -- 2.1.0

2 11

[alsa-devel] [PATCH 0/4 v3] ASoC: rsnd: tidyup .remove method
by Kuninori Morimoto 13 Feb '15

13 Feb '15

Hi Mark These are v3 of unbind/bind issue fixup patches. v2 patch-set was Kuninori Morimoto (6): 1) ASoC: rsnd: set device data before snd_soc_register_platform/component 2) ASoC: soc-core: indicate unregister debug message once 3) ASoC: soc-core: add snd_soc_remove_card() 4) ASoC: soc-core: deactivate pins in snd_soc_instantiate_card() 5) ASoC: soc-core: call soc_cleanup_card_debugfs() from snd_soc_unregister_card() 6) ASoC: soc-core: call snd_soc_remove_card() when component del Now, 1) / 2) are applied already. So, v3 patches is same as 3) - 6)

3 13

[alsa-devel] davinci-mcasp: extension to use AHCLKX pin as external clock source
by Urs Fässler 12 Feb '15

12 Feb '15

The AHCLKX pin seems not to be supported as external source. The first patch is a general fix to allow external clock. The second allows you to select the AHCLKX pin as clock source. Patch built against v3.19-rc7

2 4

[alsa-devel] Status of ALSA FireWire stack as of Linux 3.19
by Takashi Sakamoto 12 Feb '15

12 Feb '15

Dear all, I'm just a developer, not a maintainer of this stack, but often receive personal messages from users. I think it helpful to explain about its status and known issues here, as of Linux 3.19. == Impovements in 3.19 release * ALSA FireWire stack gain a thlottle for MIDI data rate. No devices can disorder due to MIDI buffer overflow. http://mailman.alsa-project.org/pipermail/alsa-devel/2014-November/084652.h… * ALSA Dice driver becomes to handle more models with 176.4/192.0 kHz support and both of playback/capture for PCM/MIDI substreams. * ALSA firewire-speakers driver was obsoleted by ALSA OXFW driver to handles more models based on OXFW 970/971. * As a result, ALSA supports approximately 140 FireWire models in comparison to Linux 3.15. == Model dependent issues There're some reports about model dependent issues. * PreSonus FP10 (former known as FirePod) * When ALSA BeBoB driver re-establishes connections, this model causes hung-up, then reset automatically. The cause is unknown. * Terratek PHASE 88 Rack FW * https://github.com/takaswie/snd-firewire-improve/issues/8 * According to a reporter, when ALSA BeBoB driver establishes connections according to CMP, this model transfers no packets. The cause is unknown. * Behringer XENIX UFX 1604 * http://sourceforge.net/p/ffado/mailman/message/32846563/ * When ALSA BeBoB driver communicates, this model sometimes misses to transfer responses. The cause is unknown but I guess that this model expects vendor-specific command. * Echo AudioFire 2 * http://mailman.alsa-project.org/pipermail/alsa-devel/2014-August/080379.html * At least, firmware version 5.7.3 for this model has a quirk about AMDTP processing. It's not compliant to this protocol. Even if ALSA Fireworks driver communicates successfully, ALSA FireWire stack detects protocol error. * Weiss engineering DAC 202 * According to a reporter, when ALSA Dice driver probes this model it's trials are ETIMEDOUT at setting sampling rate. The cause is unknown. == Stack and driver issues There're still some issues about ALSA FireWire stack and drivers. Most of them are written in my report: https://github.com/takaswie/alsa-firewire-report * 9.2 A lack of arrangement for severe latency * 9.3 A lack of delay for timestamp processing * 9.4 A lack of PCM configuration for virtual surround nodes * 9.6 A lack of control elements for ALSA control interface * 9.7 A lack of packet sorting * 9.9 Various results at bus reset * 9.10 A lack of synchronizing several devices on the same bus * Sometimes kernel oops at disconnecting devices during streaming. * I guess three contexts have somewhat race condition: * Application process with snd_pcm_prepare() * Isochronous context * .remove callback by OHCI 1394 host controller driver == The other issues * PulseAudio 6,0 (not released yet) gain multichannel profiles. http://www.freedesktop.org/wiki/Software/PulseAudio/Notes/6.0/ ALSA FireWire sound devices can be available, while in most case the display name is the name of OHCI 3194 host controller. https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/1381475 I've posted RFC patch to pulseaudio-discuss but I think it better to touch hardware database which systemd produces. http://lists.freedesktop.org/archives/pulseaudio-discuss/2015-January/02294… == My plan for 3.21 release * Some userspace library is under development for developers of mixer application. * libhinawa http://mailman.alsa-project.org/pipermail/alsa-devel/2015-January/086969.ht… * alsa-gir https://github.com/takaswie/alsa-gir * An offload of control functionality from ALSA OXFW driver to userspace * Currently ALSA OXFW driver includes control functionality in kernel side, while this can be implemented in userspace. This functionaliy utilizes certailn commands which the other drivers can use for the same purpose. * Need to discuss about it, later. * ALSA BeBoB driver improvement * ALSA BeBoB driver's bootup command for M-Audio models depends on little-endiannness machine. I need more time to prepare for big-endianness machine to test my patch for this issue. * Some models expect BridgeCo.-specific command to change sampling rate. Currently ALSA BeBoB driver uses commands in AV/C general specification. Let's start to replace these comands. Regards Takashi Sakamoto

1 0

[alsa-devel] [Patch V2] ASoC: max98357a: Add missing deps and headers
by Kenneth Westfield 12 Feb '15

12 Feb '15

From: Kenneth Westfield <kwestfie(a)codeaurora.org> Add missing build dependancy to GPIOLIB in Kconfig. Add header files to avoid implicit declarations and indirect inclusions. Remove use of DRV_NAME constant. Signed-off-by: Kenneth Westfield <kwestfie(a)codeaurora.org> --- for topic/max98357a branch changes from v1: - matched subject line to subsystem style sound/soc/codecs/Kconfig | 2 +- sound/soc/codecs/max98357a.c | 23 +++++++++++++++-------- 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 6ecac1e4428eafc491d6cfc25110f6b3dbf699ed..0500b3ed5fa5ac4d45663ad659da9db3003bc5a3 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -69,7 +69,7 @@ config SND_SOC_ALL_CODECS select SND_SOC_MAX98088 if I2C select SND_SOC_MAX98090 if I2C select SND_SOC_MAX98095 if I2C - select SND_SOC_MAX98357A + select SND_SOC_MAX98357A if GPIOLIB select SND_SOC_MAX9850 if I2C select SND_SOC_MAX9768 if I2C select SND_SOC_MAX9877 if I2C diff --git a/sound/soc/codecs/max98357a.c b/sound/soc/codecs/max98357a.c index 1806333ea29e5a6b49e2a0adb8c58257d34b7508..4ee23fbc4e1237268ae104319a9cfe4fc369934e 100644 --- a/sound/soc/codecs/max98357a.c +++ b/sound/soc/codecs/max98357a.c @@ -12,11 +12,19 @@ * max98357a.c -- MAX98357A ALSA SoC Codec driver */ -#include <linux/module.h> +#include <linux/device.h> +#include <linux/err.h> #include <linux/gpio.h> +#include <linux/gpio/consumer.h> +#include <linux/kernel.h> +#include <linux/mod_devicetable.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/platform_device.h> +#include <sound/pcm.h> #include <sound/soc.h> - -#define DRV_NAME "max98357a" +#include <sound/soc-dai.h> +#include <sound/soc-dapm.h> static int max98357a_daiops_trigger(struct snd_pcm_substream *substream, int cmd, struct snd_soc_dai *dai) @@ -77,9 +85,9 @@ static struct snd_soc_dai_ops max98357a_dai_ops = { }; static struct snd_soc_dai_driver max98357a_dai_driver = { - .name = DRV_NAME, + .name = "max98357a", .playback = { - .stream_name = DRV_NAME "-playback", + .stream_name = "max98357a-playback", .formats = SNDRV_PCM_FMTBIT_S16 | SNDRV_PCM_FMTBIT_S24 | SNDRV_PCM_FMTBIT_S32, @@ -117,7 +125,7 @@ static int max98357a_platform_remove(struct platform_device *pdev) #ifdef CONFIG_OF static const struct of_device_id max98357a_device_id[] = { - { .compatible = "maxim," DRV_NAME, }, + { .compatible = "maxim,max98357a" }, {} }; MODULE_DEVICE_TABLE(of, max98357a_device_id); @@ -125,7 +133,7 @@ MODULE_DEVICE_TABLE(of, max98357a_device_id); static struct platform_driver max98357a_platform_driver = { .driver = { - .name = DRV_NAME, + .name = "max98357a", .of_match_table = of_match_ptr(max98357a_device_id), }, .probe = max98357a_platform_probe, @@ -135,4 +143,3 @@ module_platform_driver(max98357a_platform_driver); MODULE_DESCRIPTION("Maxim MAX98357A Codec Driver"); MODULE_LICENSE("GPL v2"); -MODULE_ALIAS("platform:" DRV_NAME); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

1 0

[alsa-devel] [Patch V5 00/12] ASoC: QCOM: Add support for ipq806x SOC
by Kenneth Westfield 12 Feb '15

12 Feb '15

From: Kenneth Westfield <kwestfie(a)codeaurora.org> This patch series adds support for I2S audio playback on the Qualcomm Technologies ipq806x SOC. The ipq806x SOC has audio-related hardware blocks in its low-power audio subsystem (or LPASS). One of the relevant blocks in the LPASS is its low-power audio interface (or LPAIF). This contains an MI2S port, which is what these drivers are configured to use. The LPAIF also contains a DMA engine that is dedicated to moving audio samples into the transmit FIFO of the MI2S port. The development board being used for testing contains the ipq806x SOC and a Maxim max98357a DAC/amp. One bus from the MI2S port of the SOC is connected to the DAC/amp for stereo playback. This bus is configured so that the SOC is bus master and consists of DATA, LRCLK, and BCLK. The DAC/amp does not need MCLK to operate. In addition, a single GPIO pin from the SOC is connected to the same DAC/amp, which gives enable/disable control over the DAC/amp. The specific drivers added are: * a codec DAI driver for controlling the DAC/amp * a CPU DAI driver for controlling the MI2S port * a platform driver for controlling the LPAIF DMA engine * a machine driver that instantiates a dai-link for playback Corresponding additions to the device tree for the ipq806x SOC and its documentation has also been added. Also, as this is a new directory, the MAINTAINERS file has been updated as well. The LPASS also contains clocks that need to be controlled. Those drivers have been submitted as a separate patch series: [PATCH v3 0/8] qcom audio clock control drivers http://lkml.org/lkml/2015/1/19/656 = Changes since V4 [Patch V4 00/10] ASoC: QCOM: Add support for ipq806x SOC http://mailman.alsa-project.org/pipermail/alsa-devel/2015-February/087499.h… * Replaced simple-card with a machine driver to resolve the system clock configuration, rather than having the CPU DAI driver do it. * Added header files to avoid indirect header dependencies and implicit forward declarations. * Tweaked the ISR to match the conventions of the surrounding code. * Removed the usage of the low-power memory as it is not needed. * Removed the use of the DRV_NAME constant. * Added explicit dependancy on gpiolib for the codec driver. * Moved the MODULE_DEVICE_TABLE macro inside the CONFIG_OF conditional. * Modified the documentation to reflect the changes. * General code cleanup. = Changes since V3 [Patch V3 00/10] ASoC: QCOM: Add support for ipq806x SOC http://mailman.alsa-project.org/pipermail/alsa-devel/2014-December/085694.h… * Placed the content of the inline functions into the callbacks. * Replaced use of readl/writel register access functions with regmap access functions. Notable exception is the ISR, which uses ioread32/iowrite32. * Rearranged the sequencing of the hardware block enables to fit within the ASoC framework callbacks, while remaining functional. REQ 1: The hardware requires the enable sequence to be: LPAIF-DMA[enable],then LPAIF-MI2S[enable], then DAC-GPIO[enable] REQ 2: The hardware requires the disable sequence to be: DAC-GPIO[disable], then LPAIF-MI2S[disable] * Corrected the implementation of the pointer callback. * Utilize the LPM to buffer audio samples, rather than memory external to LPASS. * Corrected the interrupt clearing in the ISR. * Implemented a default system clock (defined by the simple-card DT node), and optional LPASS DT node modifiers that can alter the system clock in order to expand the range of available bit clock frequencies. * Addressed all of the remaining issues raised by Mark Brown. * General code cleanup. = Changes since V2 [Patch v2 00/11] ASoC: QCOM: Add support for ipq806x SOC http://mailman.alsa-project.org/pipermail/alsa-devel/2014-December/085186.h… * Removed the PCM platform driver from the DTS platform and tied it to the CPU DAI driver. * Changed I2S pinctrl to use generic naming convention and moved control to CPU DAI driver. It should be controlled now by soc-core's pinctrl_pm_* functionality. * Added stub DAPM support in codec driver. As the DAC GPIO needs to be enabled last when starting playback, and disabled first when stopping playback, it seems as though the trigger function may be the place for this. Suggestions are welcome for a better place to put this. * Removed machine driver and tied DAI drivers to simple-audio-card. * Packaged the build files and Maxim codec files together in one change. * Removed QCOM as vendor from Maxim code and documentation. * Separated the SOC and board definitions into the correct DTS files. * Update device tree documentation to reflect changes. * General code cleanup. = Changes since V1 [PATCH 0/9] ASoC: QCOM: Add support for ipq806x SOC http://mailman.alsa-project.org/pipermail/alsa-devel/2014-November/084322.h… * Remove the native LPAIF driver, and move its functionality to the CPU DAI driver. * Add a codec driver to manage the pins going to the external DAC (previously managed by the machine driver). * Use devm_* and dev_* where possible. * ISR only handles relevant DMA channel now. * Update device tree documentation to reflect changes. * General code cleanup. Kenneth Westfield (12): MAINTAINERS: Add QCOM audio ASoC maintainer ASoC: max98357a: Document MAX98357A bindings ASoC: qcom: Document LPASS CPU bindings ASoC: qcom: Document IPQ806X-MAX89357A bindings ASoC: codec: Add MAX98357A codec driver ASoC: ipq806x: add LPASS header files ASoC: ipq806x: Add LPASS CPU DAI driver ASoC: ipq806x: Add LPASS platform driver ASoC: ipq806x: Add @max98357a machine driver ASoC: qcom: Add ability to build QCOM drivers ASoC: Allow for building QCOM drivers ARM: dts: Model IPQ LPASS audio hardware .../devicetree/bindings/sound/max98357a.txt | 14 + .../bindings/sound/qcom,ipq806x-max98357a.txt | 24 + .../devicetree/bindings/sound/qcom,lpass-cpu.txt | 38 ++ MAINTAINERS | 7 + arch/arm/boot/dts/qcom-ipq8064.dtsi | 23 + sound/soc/Kconfig | 1 + sound/soc/Makefile | 1 + sound/soc/codecs/Kconfig | 4 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/max98357a.c | 145 ++++++ sound/soc/qcom/Kconfig | 26 + sound/soc/qcom/Makefile | 11 + sound/soc/qcom/ipq806x-max98357a.c | 171 +++++++ sound/soc/qcom/lpass-cpu.c | 481 +++++++++++++++++++ sound/soc/qcom/lpass-lpaif-ipq806x.h | 172 +++++++ sound/soc/qcom/lpass-platform.c | 526 +++++++++++++++++++++ sound/soc/qcom/lpass.h | 51 ++ 17 files changed, 1697 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/max98357a.txt create mode 100644 Documentation/devicetree/bindings/sound/qcom,ipq806x-max98357a.txt create mode 100644 Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt create mode 100644 sound/soc/codecs/max98357a.c create mode 100644 sound/soc/qcom/Kconfig create mode 100644 sound/soc/qcom/Makefile create mode 100644 sound/soc/qcom/ipq806x-max98357a.c create mode 100644 sound/soc/qcom/lpass-cpu.c create mode 100644 sound/soc/qcom/lpass-lpaif-ipq806x.h create mode 100644 sound/soc/qcom/lpass-platform.c create mode 100644 sound/soc/qcom/lpass.h -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

2 14

[alsa-devel] [PATCH] ASoC: max98357a: Fix missing include
by Vincent Stehlé 12 Feb '15

12 Feb '15

This fixes the following compilation errors: sound/soc/codecs/max98357a.c: In function ‘max98357a_daiops_trigger’: sound/soc/codecs/max98357a.c:30:3: error: implicit declaration of function ‘gpiod_set_value’ [-Werror=implicit-function-declaration] sound/soc/codecs/max98357a.c: In function ‘max98357a_codec_probe’: sound/soc/codecs/max98357a.c:55:2: error: implicit declaration of function ‘devm_gpiod_get’ [-Werror=implicit-function-declaration] sound/soc/codecs/max98357a.c:61:2: error: implicit declaration of function ‘gpiod_direction_output’ [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors Signed-off-by: Vincent Stehlé <vincent.stehle(a)laposte.net> Cc: Kenneth Westfield <kwestfie(a)codeaurora.org> Cc: Mark Brown <broonie(a)kernel.org> --- Hi, Those compilation errors can be seen for example with hppa allmodconfig. Best regards, V. sound/soc/codecs/max98357a.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/max98357a.c b/sound/soc/codecs/max98357a.c index 1806333..f493fb6 100644 --- a/sound/soc/codecs/max98357a.c +++ b/sound/soc/codecs/max98357a.c @@ -14,6 +14,7 @@ #include <linux/module.h> #include <linux/gpio.h> +#include <linux/gpio/consumer.h> #include <sound/soc.h> #define DRV_NAME "max98357a" -- 2.1.4

2 1

[alsa-devel] [PATCH 0/3] ucm: miscellaneous fixes
by Tanu Kaskinen 11 Feb '15

11 Feb '15

While working on PulseAudio's UCM code, I noticed strange use of const in snd_use_case_get(). The third patch fixes that. While working on the third patch, I also noticed strange code in execute_sequence(). The first patch fixes one obvious bug, but there was another issue which I didn't know how to fix, so I just added a FIXME comment instead (that's just as an RFC, I hope the discussion will reveal what the proper fix should be). Tanu Kaskinen (3): ucm: fix variable mixup ucm: add a FIXME comment ucm: fix inappropriate use of const include/use-case.h | 2 +- src/ucm/main.c | 34 +++++++++++++++++++++------------- 2 files changed, 22 insertions(+), 14 deletions(-) -- 1.9.3

3 11