December 2015 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [sound:for-next 38/40] sound/pci/hda/hda_tegra.c:484:36: error: 'AZX_DCAPS_RIRB_DELAY' undeclared
by kbuild test robot 17 Dec '15

17 Dec '15

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next head: 64cfd2fd5325dbe24b990dbe003c22f5675d9742 commit: 119a42ac2b249abd6b5195e0606a0d70af2953eb [38/40] ALSA: hda - Move Nvidia-specific check into hda_intel.c config: arm-allyesconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/m… -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 119a42ac2b249abd6b5195e0606a0d70af2953eb # save the attached .config to linux build tree make.cross ARCH=arm All errors (new ones prefixed by >>): sound/pci/hda/hda_tegra.c: In function 'hda_tegra_probe': >> sound/pci/hda/hda_tegra.c:484:36: error: 'AZX_DCAPS_RIRB_DELAY' undeclared (first use in this function) const unsigned int driver_flags = AZX_DCAPS_RIRB_DELAY | ^ sound/pci/hda/hda_tegra.c:484:36: note: each undeclared identifier is reported only once for each function it appears in vim +/AZX_DCAPS_RIRB_DELAY +484 sound/pci/hda/hda_tegra.c 3c320f3f Dylan Reid 2014-05-19 478 {}, 3c320f3f Dylan Reid 2014-05-19 479 }; f73387cb Dylan Reid 2014-05-20 480 MODULE_DEVICE_TABLE(of, hda_tegra_match); 3c320f3f Dylan Reid 2014-05-19 481 3c320f3f Dylan Reid 2014-05-19 482 static int hda_tegra_probe(struct platform_device *pdev) 3c320f3f Dylan Reid 2014-05-19 483 { 88871dd2 Thierry Reding 2015-05-05 @484 const unsigned int driver_flags = AZX_DCAPS_RIRB_DELAY | 88871dd2 Thierry Reding 2015-05-05 485 AZX_DCAPS_CORBRP_SELF_CLEAR; 3c320f3f Dylan Reid 2014-05-19 486 struct snd_card *card; 3c320f3f Dylan Reid 2014-05-19 487 struct azx *chip; :::::: The code at line 484 was first introduced by commit :::::: 88871dd25f64b9bf16222e829ad766fac201866a ALSA: hda/tegra - Set CORBRP self-clear flag :::::: TO: Thierry Reding <treding(a)nvidia.com> :::::: CC: Takashi Iwai <tiwai(a)suse.de> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

2 1

[alsa-devel] [RESEND PATCH v2 0/2] ASoC: atmel-pdmic: add driver for Atmel PDMIC
by Songjun Wu 17 Dec '15

17 Dec '15

The Pulse Density Modulation Inteface Controller driver includes two parts. 1) Driver code to implement the PDMIC function. 2) Device tree binding documentation, it describes how to add the PDMIC in device tree. Changes in v2: - Remove the function 'atmel_pdmic_codec_get_remap', since the regmap is initialized in the core. - Replace 'if' with 'switch' in function 'atmel_pdmic_codec_dai_hw_params'. - Fix the coding style issue in function 'atmel_pdmic_dt_init', 'atmel_pdmic_interrupt','pdmic_put_mic_volsw', 'atmel_pdmic_codec_probe', 'pdmic_get_mic_volsw' and 'atmel_pdmic_codec_dai_hw_params'. Songjun Wu (2): ASoC: atmel-pdmic: add the Pulse Density Modulation Interface Controller ASoC: atmel-classd: DT binding for PDMIC driver .../devicetree/bindings/sound/atmel-pdmic.txt | 55 ++ sound/soc/atmel/Kconfig | 9 + sound/soc/atmel/Makefile | 2 + sound/soc/atmel/atmel-pdmic.c | 738 ++++++++++++++++++++ sound/soc/atmel/atmel-pdmic.h | 80 +++ 5 files changed, 884 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/atmel-pdmic.txt create mode 100644 sound/soc/atmel/atmel-pdmic.c create mode 100644 sound/soc/atmel/atmel-pdmic.h -- 1.7.9.5

1 1

[alsa-devel] [PATCH 0/4] Be ecologist; save more bits in AZX_DCAPS_*
by Takashi Iwai 17 Dec '15

17 Dec '15

Hi, this patchset cleans up messy AZX_DCAPS_* definitions and remove a few usages there. Takashi === Takashi Iwai (4): ALSA: hda - Merge RIRB_PRE_DELAY into CTX_WORKAROUND caps ALSA: hda - Move Nvidia-specific check into hda_intel.c ALSA: hda - Drop AZX_DCAPS_POSFIX_VIA bit ALSA: hda - Drop unused AZX_DCAPS_REVERSE_ASSIGN sound/pci/hda/hda_controller.c | 7 +------ sound/pci/hda/hda_controller.h | 8 ++++---- sound/pci/hda/hda_intel.c | 20 +++++++++++--------- 3 files changed, 16 insertions(+), 19 deletions(-) -- 2.6.4

1 4

[alsa-devel] [PATCH 0/2] ASoC: atmel-pdmic: add driver for Atmel PDMIC
by Songjun Wu 17 Dec '15

17 Dec '15

The Pulse Density Modulation Inteface Controller driver includes two parts. 1) Driver code to implement the PDMIC function. 2) Device tree binding documentation, it describes how to add the PDMIC in device tree. Songjun Wu (2): ASoC: atmel-pdmic: add the Pulse Density Modulation Interface Controller ASoC: atmel-pdmic: DT binding for PDMIC driver .../devicetree/bindings/sound/atmel-pdmic.txt | 55 ++ sound/soc/atmel/Kconfig | 9 + sound/soc/atmel/Makefile | 2 + sound/soc/atmel/atmel-pdmic.c | 745 ++++++++++++++++++++ sound/soc/atmel/atmel-pdmic.h | 80 +++ 5 files changed, 891 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/atmel-pdmic.txt create mode 100644 sound/soc/atmel/atmel-pdmic.c create mode 100644 sound/soc/atmel/atmel-pdmic.h -- 1.7.9.5

3 3

[alsa-devel] [patch] ASoC: Intel: Skylake: Fix a couple signedness bugs
by Dan Carpenter 16 Dec '15

16 Dec '15

These need to be unsigned because they hold negative error codes. Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> diff --git a/sound/soc/intel/skylake/skl-sst.c b/sound/soc/intel/skylake/skl-sst.c index 8cd5cdb..e26f474 100644 --- a/sound/soc/intel/skylake/skl-sst.c +++ b/sound/soc/intel/skylake/skl-sst.c @@ -208,7 +208,7 @@ static unsigned int skl_get_errorcode(struct sst_dsp *ctx) * since get/set_module are called from DAPM context, * we don't need lock for usage count */ -static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id) +static int skl_get_module(struct sst_dsp *ctx, u16 mod_id) { struct skl_module_table *module; @@ -220,7 +220,7 @@ static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id) return -EINVAL; } -static unsigned int skl_put_module(struct sst_dsp *ctx, u16 mod_id) +static int skl_put_module(struct sst_dsp *ctx, u16 mod_id) { struct skl_module_table *module; @@ -340,7 +340,7 @@ static int skl_load_module(struct sst_dsp *ctx, u16 mod_id, char *guid) static int skl_unload_module(struct sst_dsp *ctx, u16 mod_id) { - unsigned int usage_cnt; + int usage_cnt; struct skl_sst *skl = ctx->thread_context; int ret = 0;

3 4

[alsa-devel] [PATCH] ASoC: arizona: In arizona_calc_fratio make new codecs the default case
by Richard Fitzgerald 16 Dec '15

16 Dec '15

This patch rearranges the switch statement in arizona_calc_fratio so that older codecs are the special cases, with the default case applying to newer codecs (WM8998 and later). This is preferable because it avoids having to patch new cases in every time a new codec is added. Signed-off-by: Richard Fitzgerald <rf(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/arizona.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/arizona.c b/sound/soc/codecs/arizona.c index d90b3c5..38a73e3 100644 --- a/sound/soc/codecs/arizona.c +++ b/sound/soc/codecs/arizona.c @@ -2020,18 +2020,18 @@ static int arizona_calc_fratio(struct arizona_fll *fll, } switch (fll->arizona->type) { + case WM5102: + case WM8997: + return init_ratio; case WM5110: case WM8280: if (fll->arizona->rev < 3 || sync) return init_ratio; break; - case WM8998: - case WM1814: + default: if (sync) return init_ratio; break; - default: - return init_ratio; } cfg->fratio = init_ratio - 1; -- 1.9.1

2 1

[alsa-devel] [patch] ASoC: Intel: Skylake: pointer math issue
by Dan Carpenter 16 Dec '15

16 Dec '15

"data" is a u32 pointer so this copies the information to wrong place entirely. Fixes: 140adfba5280 ('ASoC: Intel: Skylake: Add tlv byte kcontrols') Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index dde8d3c..2c4405e 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -885,9 +885,9 @@ static int skl_tplg_tlv_control_get(struct snd_kcontrol *kcontrol, if (bc->params) { if (copy_to_user(data, &bc->param_id, sizeof(u32))) return -EFAULT; - if (copy_to_user(data + sizeof(u32), &size, sizeof(u32))) + if (copy_to_user(data + 1, &size, sizeof(u32))) return -EFAULT; - if (copy_to_user(data + 2 * sizeof(u32), bc->params, size)) + if (copy_to_user(data + 2, bc->params, size)) return -EFAULT; }

3 3

[alsa-devel] [patch v2] ASoC: Intel: Skylake: Fix a couple signedness bugs
by Dan Carpenter 16 Dec '15

16 Dec '15

These need to be signed because they hold negative error codes. Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- Fix a typo in the change log. s/unsigned/signed/ diff --git a/sound/soc/intel/skylake/skl-sst.c b/sound/soc/intel/skylake/skl-sst.c index 8cd5cdb..e26f474 100644 --- a/sound/soc/intel/skylake/skl-sst.c +++ b/sound/soc/intel/skylake/skl-sst.c @@ -208,7 +208,7 @@ static unsigned int skl_get_errorcode(struct sst_dsp *ctx) * since get/set_module are called from DAPM context, * we don't need lock for usage count */ -static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id) +static int skl_get_module(struct sst_dsp *ctx, u16 mod_id) { struct skl_module_table *module; @@ -220,7 +220,7 @@ static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id) return -EINVAL; } -static unsigned int skl_put_module(struct sst_dsp *ctx, u16 mod_id) +static int skl_put_module(struct sst_dsp *ctx, u16 mod_id) { struct skl_module_table *module; @@ -340,7 +340,7 @@ static int skl_load_module(struct sst_dsp *ctx, u16 mod_id, char *guid) static int skl_unload_module(struct sst_dsp *ctx, u16 mod_id) { - unsigned int usage_cnt; + int usage_cnt; struct skl_sst *skl = ctx->thread_context; int ret = 0;

2 1

[alsa-devel] [PATCH v5 1/2] ALSA: hda - hdmi dynamically bind PCM to pin when monitor hotplug
by libin.yang＠linux.intel.com 16 Dec '15

16 Dec '15

From: Libin Yang <libin.yang(a)linux.intel.com> Dynamically bind/unbind the PCM to pin when HDMI/DP monitor hotplug. When monitor is connected, find a proper PCM for the monitor. When monitor is disconnected, unbind the PCM from the pin. The binding policy (use Intel platform as example) is: 1. Try to use the legacy pin-pcm mapping for the device entry 0 of the pin. 2. If step 1 fails, try to bind pin to the backup PCMs. For example, on Intel platform, if DP MST is enabled, 5 PCMs will be created. PCM 3, PCM 7, PCM 8 are supposed to be used by device entry 0 of pin 5, pin 6 and pin 7. PCM 9 and PCM 10 are the backup PCMs. 3. If step 2 fails, try to find any PCM to bind to the pin. Signed-off-by: Libin Yang <libin.yang(a)linux.intel.com> --- sound/pci/hda/patch_hdmi.c | 82 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 80 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 19bf782..56b7625 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -73,6 +73,8 @@ struct hdmi_spec_per_cvt { struct hdmi_spec_per_pin { hda_nid_t pin_nid; + /* pin idx, different device entries on the same pin use the same idx */ + int pin_nid_idx; int num_mux_nids; hda_nid_t mux_nids[HDA_MAX_CONNECTIONS]; int mux_idx; @@ -85,6 +87,7 @@ struct hdmi_spec_per_pin { struct snd_kcontrol *eld_ctl; struct snd_jack *acomp_jack; /* jack via audio component */ struct hda_pcm *pcm; /* pointer to spec->pcm_rec[n] dynamically*/ + int pcm_idx; /* which pcm is attached. -1 means no pcm is attached */ int repoll_count; bool setup; /* the stream has been set up by prepare callback */ int channels; /* current number of channels */ @@ -138,6 +141,8 @@ struct hdmi_spec { struct snd_array pins; /* struct hdmi_spec_per_pin */ struct hda_pcm *pcm_rec[16]; struct mutex pcm_lock; + /* pcm_bitmap means which pcms have been assigned to pins*/ + unsigned long pcm_bitmap; int pcm_used; /* counter of pcm_rec[] */ unsigned int channels_max; /* max over all cvts */ @@ -1671,6 +1676,60 @@ static int hdmi_read_pin_conn(struct hda_codec *codec, int pin_idx) return 0; } +static int hdmi_find_pcm_slot(struct hdmi_spec *spec, + struct hdmi_spec_per_pin *per_pin) +{ + int i; + + /* try the prefer PCM */ + if (!test_bit(per_pin->pin_nid_idx, &spec->pcm_bitmap)) + return per_pin->pin_nid_idx; + + /* have a second try; check the "reserved area" over num_pins */ + for (i = spec->num_pins; i < spec->pcm_used; i++) { + if (!test_bit(i, &spec->pcm_bitmap)) + return i; + } + + /* the last try; check the empty slots in pins */ + for (i = 0; i < spec->num_pins; i++) { + if (!test_bit(i, &spec->pcm_bitmap)) + return i; + } + return -EBUSY; +} + +static void hdmi_attach_hda_pcm(struct hdmi_spec *spec, + struct hdmi_spec_per_pin *per_pin) +{ + int idx; + + /* pcm already be attached to the pin */ + if (per_pin->pcm) + return; + idx = hdmi_find_pcm_slot(spec, per_pin); + if (idx == -ENODEV) + return; + per_pin->pcm_idx = idx; + per_pin->pcm = spec->pcm_rec[idx]; + set_bit(idx, &spec->pcm_bitmap); +} + +static void hdmi_detach_hda_pcm(struct hdmi_spec *spec, + struct hdmi_spec_per_pin *per_pin) +{ + int idx; + + /* pcm already be detached from the pin */ + if (!per_pin->pcm) + return; + idx = per_pin->pcm_idx; + per_pin->pcm_idx = -1; + per_pin->pcm = NULL; + if (idx >= 0 && idx < spec->pcm_used) + clear_bit(idx, &spec->pcm_bitmap); +} + /* update per_pin ELD from the given new ELD; * setup info frame and notification accordingly */ @@ -1679,9 +1738,17 @@ static void update_eld(struct hda_codec *codec, struct hdmi_eld *eld) { struct hdmi_eld *pin_eld = &per_pin->sink_eld; + struct hdmi_spec *spec = codec->spec; bool old_eld_valid = pin_eld->eld_valid; bool eld_changed; + if (spec->dyn_pcm_assign) { + if (eld->eld_valid) + hdmi_attach_hda_pcm(spec, per_pin); + else + hdmi_detach_hda_pcm(spec, per_pin); + } + if (eld->eld_valid) snd_hdmi_show_eld(codec, &eld->info); @@ -1825,13 +1892,19 @@ static void sync_eld_via_acomp(struct hda_codec *codec, static bool hdmi_present_sense(struct hdmi_spec_per_pin *per_pin, int repoll) { struct hda_codec *codec = per_pin->codec; + struct hdmi_spec *spec = codec->spec; + int ret; + mutex_lock(&spec->pcm_lock); if (codec_has_acomp(codec)) { sync_eld_via_acomp(codec, per_pin); - return false; /* don't call snd_hda_jack_report_sync() */ + ret = false; /* don't call snd_hda_jack_report_sync() */ } else { - return hdmi_present_sense_via_verbs(per_pin, repoll); + ret = hdmi_present_sense_via_verbs(per_pin, repoll); } + mutex_unlock(&spec->pcm_lock); + + return ret; } static void hdmi_repoll_eld(struct work_struct *work) @@ -1875,6 +1948,11 @@ static int hdmi_add_pin(struct hda_codec *codec, hda_nid_t pin_nid) per_pin->pin_nid = pin_nid; per_pin->non_pcm = false; + if (spec->dyn_pcm_assign) + per_pin->pcm_idx = -1; + else + per_pin->pcm_idx = pin_idx; + per_pin->pin_nid_idx = pin_idx; err = hdmi_read_pin_conn(codec, pin_idx); if (err < 0) -- 1.9.1

2 2

[alsa-devel] [PATCH] ASoC: Intel: sst: fix sst_memcpy32 wrong with non-4x bytes issue
by Jie Yang 16 Dec '15

16 Dec '15

sst_memcpy32() only copied bytes/4 32bits, which means it dropped the remaining bytes%4 bytes wrongly. Here add copying those missing bytes, first to a 32bits tmp, and then write the tmp to 32bits iomem. Signed-off-by: Jie Yang <yang.jie(a)intel.com> --- sound/soc/intel/common/sst-firmware.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/common/sst-firmware.c b/sound/soc/intel/common/sst-firmware.c index 60652cb..d745a78 100644 --- a/sound/soc/intel/common/sst-firmware.c +++ b/sound/soc/intel/common/sst-firmware.c @@ -51,8 +51,22 @@ struct sst_dma { static inline void sst_memcpy32(volatile void __iomem *dest, void *src, u32 bytes) { + u32 tmp = 0; + int i, m, n; + const u8 *src_byte = src; + + m = bytes / 4; + n = bytes % 4; + /* __iowrite32_copy use 32bit size values so divide by 4 */ - __iowrite32_copy((void *)dest, src, bytes/4); + __iowrite32_copy((void *)dest, src, m); + + if (n) { + for (i = 0; i < n; i++) + tmp |= (u32)*(src_byte + m * 4 + i) << (i * 8); + __iowrite32_copy((void *)(dest + m * 4), &tmp, 1); + } + } static void sst_dma_transfer_complete(void *arg) -- 2.5.0

2 1