November 2015 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: topology: Fix not to keep a reference to tplg fw
by Subhransu S. Prusty 27 Nov '15

27 Nov '15

During element creation, the name of some of the elements point to memory referenced in tplg fw. If the tplg fw is released after tplg is parsed by framework, kernel panic happens during creation of elements while card initialization. Issue is caught with id#87b5ed8ecb9fe05a696e1c0b53c7a49ea66432c1 So create a copy of the memory and assign to names instead. Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty(a)intel.com> Signed-off-by: Vinod Koul <vinod.koul(a)intel.com> --- sound/soc/soc-topology.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index 6963ba2..61eb1de 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -709,7 +709,7 @@ static int soc_tplg_dbytes_create(struct soc_tplg *tplg, unsigned int count, be->hdr.name, be->hdr.access); memset(&kc, 0, sizeof(kc)); - kc.name = be->hdr.name; + kc.name = kstrdup(be->hdr.name, GFP_KERNEL); kc.private_value = (long)sbe; kc.iface = SNDRV_CTL_ELEM_IFACE_MIXER; kc.access = be->hdr.access; @@ -789,7 +789,7 @@ static int soc_tplg_dmixer_create(struct soc_tplg *tplg, unsigned int count, mc->hdr.name, mc->hdr.access); memset(&kc, 0, sizeof(kc)); - kc.name = mc->hdr.name; + kc.name = kstrdup(mc->hdr.name, GFP_KERNEL); kc.private_value = (long)sm; kc.iface = SNDRV_CTL_ELEM_IFACE_MIXER; kc.access = mc->hdr.access; @@ -935,7 +935,7 @@ static int soc_tplg_denum_create(struct soc_tplg *tplg, unsigned int count, ec->hdr.name, ec->items); memset(&kc, 0, sizeof(kc)); - kc.name = ec->hdr.name; + kc.name = kstrdup(ec->hdr.name, GFP_KERNEL); kc.private_value = (long)se; kc.iface = SNDRV_CTL_ELEM_IFACE_MIXER; kc.access = ec->hdr.access; @@ -1105,8 +1105,8 @@ static int soc_tplg_dapm_graph_elems_load(struct soc_tplg *tplg, SNDRV_CTL_ELEM_ID_NAME_MAXLEN) return -EINVAL; - route.source = elem->source; - route.sink = elem->sink; + route.source = kstrdup(elem->source, GFP_KERNEL); + route.sink = kstrdup(elem->sink, GFP_KERNEL); route.connected = NULL; /* set to NULL atm for tplg users */ if (strnlen(elem->control, SNDRV_CTL_ELEM_ID_NAME_MAXLEN) == 0) route.control = NULL; @@ -1149,7 +1149,7 @@ static struct snd_kcontrol_new *soc_tplg_dapm_widget_dmixer_create( dev_dbg(tplg->dev, " adding DAPM widget mixer control %s at %d\n", mc->hdr.name, i); - kc[i].name = mc->hdr.name; + kc[i].name = kstrdup(mc->hdr.name, GFP_KERNEL); kc[i].private_value = (long)sm; kc[i].iface = SNDRV_CTL_ELEM_IFACE_MIXER; kc[i].access = mc->hdr.access; @@ -1228,7 +1228,7 @@ static struct snd_kcontrol_new *soc_tplg_dapm_widget_denum_create( dev_dbg(tplg->dev, " adding DAPM widget enum control %s\n", ec->hdr.name); - kc->name = ec->hdr.name; + kc->name = kstrdup(ec->hdr.name, GFP_KERNEL); kc->private_value = (long)se; kc->iface = SNDRV_CTL_ELEM_IFACE_MIXER; kc->access = ec->hdr.access; @@ -1330,7 +1330,7 @@ static struct snd_kcontrol_new *soc_tplg_dapm_widget_dbytes_create( "ASoC: adding bytes kcontrol %s with access 0x%x\n", be->hdr.name, be->hdr.access); - kc[i].name = be->hdr.name; + kc[i].name = kstrdup(be->hdr.name, GFP_KERNEL); kc[i].private_value = (long)sbe; kc[i].iface = SNDRV_CTL_ELEM_IFACE_MIXER; kc[i].access = be->hdr.access; -- 1.9.1

4 16

Re: [alsa-devel] [PATCH] alsa-mixer: sb-omni-surround-5.1.conf: remove analog-surround-21, add Linux 4.3+ support
by Raymond Yau 27 Nov '15

27 Nov '15

>> >> > Do you mean 2.1 mode won't work with all usb audio since surround 5.1 of usb audio is already using route plugin >> What do you mean by "all usb audio"? In 4.1/5.1 mode LFE and all other outputs work properly, it is just for 2.1, which works as stereo. >> >> > If you don't have SPDIF output/input, you need to add your card in USB-AUDIO.conf >> Sound card has S/PDIF output, but not input. Not sure whether output works properly though. I do not have speakers or any other hardware with S/PDIF input to test it. >> >>> >>> > >>> > In 2.1 mode LFE is not actually working at all, so it is removed. >>> >>> Do you mean 2.1 mode won't work with all usb audio since surround 5.1 of usb audio is already using route plugin >>> >>> USB-Audio.pcm.surround51.0 { >>> @args [ CARD ] >>> @args.CARD { type string } >>> @func refer >>> name { >>> @func concat >>> strings [ >>> "cards.USB-Audio." >>> { @func card_name card $CARD } >>> ".pcm.surround51:CARD=" $CARD >>> ] >>> } >>> default { >>> type route >>> ttable.0.0 1 >>> ttable.1.1 1 >>> ttable.2.4 1 >>> ttable.3.5 1 >>> ttable.4.2 1 >>> ttable.5.3 1 >>> slave { >>> pcm { >>> type hw >>> card $CARD >>> device 0 >>> } >>> channels 6 >>> } >>> } >>> } >>> http://git.alsa-project.org/?p=alsa-lib.git;a=blob_plain;f=src/conf/pcm/sur… type route slave.pcm { @func refer name { @func concat strings [ "cards." { @func card_driver card $CARD } ".pcm.surround51." $DEV ":CARD=" $CARD ] } } ttable.0.FL 1 ttable.1.FR 1 ttable.2.LFE 1 hint { description "2.1 Surround output to Front and Subwoofer speakers" device $DEV } 2.1 seem use 5.1 and route plugin If you mean route plugin cannot be used twice, you need to remove surround 2.1 from USB-Audio.conf

1 0

[alsa-devel] Intel SST and HP ElitePad 1000 G2
by Jorge Fernandez Monteagudo 26 Nov '15

26 Nov '15

Hi, This is my first email in this list, and my last chance to make my tablet audio system work I'm trying to get my tablet audio system working but I'm run out of ideas. The HP ElitePad 1000 G2 it's an Atom Z3795 1.60GHz Bay Trail-T tablet. I'm using a kernel 4.2.5 with all the SST configs enabled: CONFIG_SND_SST_MFLD_PLATFORM=m CONFIG_SND_SST_IPC=m CONFIG_SND_SST_IPC_ACPI=m CONFIG_SND_SOC_INTEL_SST=m CONFIG_SND_SOC_INTEL_SST_ACPI=m CONFIG_SND_SOC_INTEL_HASWELL=m CONFIG_SND_SOC_INTEL_BAYTRAIL=m CONFIG_SND_SOC_INTEL_HASWELL_MACH=m CONFIG_SND_SOC_INTEL_BYT_RT5640_MACH=m CONFIG_SND_SOC_INTEL_BYT_MAX98090_MACH=m CONFIG_SND_SOC_INTEL_BROADWELL_MACH=m CONFIG_SND_SOC_INTEL_BYTCR_RT5640_MACH=m CONFIG_SND_SOC_INTEL_CHT_BSW_RT5672_MACH=m CONFIG_SND_SOC_INTEL_CHT_BSW_RT5645_MACH=m CONFIG_SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH=m # CONFIG_SND_SOC_QCOM is not set # CONFIG_SND_SOC_XTFPGA_I2S is not set CONFIG_SND_SOC_I2C_AND_SPI=m I've follow the same steps as the installation for Asus T100TA https://wiki.debian.org/InstallingDebianOn/Asus/T100TA and finally I only get the dmesg traces: sst-acpi 80860F28:00: No matching ASoC machine driver found intel-sst-acpi 80860F28:00: No matching machine driver found From the 'dsdt.dsl' I can see: Device (I2C2) { Name (_ADR, Zero) // _ADR: Address Name (_HID, "80860F41" /* Intel Baytrail I2C Host Controller */) // _HID: Hardware ID Name (_CID, "80860F41" /* Intel Baytrail I2C Host Controller */) // _CID: Compatible ID Name (_DEP, Package (0x01) // _DEP: Dependencies { PEPD }) Name (_DDN, "Intel(R) I2C Controller #2 - 80860F42") // _DDN: DOS Device Name Name (_UID, 0x02) // _UID: Unique ID Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x00000000, // Address Base 0x00001000, // Address Length _Y12) Interrupt (ResourceConsumer, Level, ActiveLow, Exclusive, ,, ) { 0x00000021, } FixedDMA (0x0012, 0x0002, Width32bit, ) FixedDMA (0x0013, 0x0003, Width32bit, ) }) Method (_HRV, 0, NotSerialized) // _HRV: Hardware Revision { Return (SOCS) /* \SOCS */ } Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings { CreateDWordField (RBUF, \_SB.I2C2._Y12._BAS, B0BA) // _BAS: Base Address CreateDWordField (RBUF, \_SB.I2C2._Y12._LEN, B0LN) // _LEN: Length Store (I20A, B0BA) /* \_SB_.I2C2._CRS.B0BA */ Store (I20L, B0LN) /* \_SB_.I2C2._CRS.B0LN */ Return (RBUF) /* \_SB_.I2C2.RBUF */ } Method (_STA, 0, NotSerialized) // _STA: Status { If (LOr (LEqual (I20A, Zero), LEqual (L22D, One))) { Return (Zero) } Return (0x0F) } Method (_PS3, 0, NotSerialized) // _PS3: Power State 3 { Or (PSAT, 0x03, PSAT) /* \_SB_.I2C2.PSAT */ Or (PSAT, Zero, PSAT) /* \_SB_.I2C2.PSAT */ } Method (_PS0, 0, NotSerialized) // _PS0: Power State 0 { And (PSAT, 0xFFFFFFFC, PSAT) /* \_SB_.I2C2.PSAT */ Or (PSAT, Zero, PSAT) /* \_SB_.I2C2.PSAT */ } OperationRegion (KEYS, SystemMemory, I21A, 0x0100) Field (KEYS, DWordAcc, NoLock, WriteAsZeros) { Offset (0x84), PSAT, 32 } Device (RTEK) { Name (_ADR, Zero) // _ADR: Address Name (_HID, "INTCCFFD") // _HID: Hardware ID Name (_CID, "INTCCFFD") // _CID: Compatible ID Name (_DDN, "RTEK Codec Controller ") // _DDN: DOS Device Name Name (_UID, 0x02) // _UID: Unique ID Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings { Name (SBUF, ResourceTemplate () { I2cSerialBus (0x001C, ControllerInitiated, 0x00061A80, AddressingMode7Bit, "\\_SB.I2C2", 0x00, ResourceConsumer, , ) GpioInt (Edge, ActiveBoth, SharedAndWake, PullNone, 0x0000, "\\_SB.GPO2", 0x00, ResourceConsumer, , ) { // Pin list 0x000E } GpioInt (Edge, ActiveBoth, SharedAndWake, PullNone, 0x0000, "\\_SB.GPO0", 0x00, ResourceConsumer, , ) { // Pin list 0x0003 } GpioInt (Edge, ActiveBoth, SharedAndWake, PullNone, 0x0000, "\\_SB.GPO0", 0x00, ResourceConsumer, , ) { // Pin list 0x0000 } GpioIo (Shared, PullDefault, 0x0000, 0x0000, IoRestrictionInputOnly, "\\_SB.GPO2", 0x00, ResourceConsumer, , ) { // Pin list 0x000E } GpioIo (Shared, PullDefault, 0x0000, 0x0000, IoRestrictionInputOnly, "\\_SB.GPO0", 0x00, ResourceConsumer, , ) { // Pin list 0x0003, 0x0000 } }) Return (SBUF) /* \_SB_.I2C2.RTEK._CRS.SBUF */ } What am I missing? I suppose I need some changes in the kernel sources but I don't know where to start. Any help is welcome Regards, Jorge Este mensaje se dirige exclusivamente a su destinatario y puede contener información privilegiada o CONFIDENCIAL. Si no es vd. el destinatario indicado, queda notificado de que la utilización, divulgación y/o copia sin autorización está prohibida en virtud de la legislación vigente. Si ha recibido este mensaje por error, le rogamos que nos lo comunique inmediatamente por esta misma vía y proceda a su destrucción. This message is intended exclusively for its addressee and may contain information that is CONFIDENTIAL and protected by professional privilege. If you are not the intended recipient you are hereby notified that any dissemination, copy or disclosure of this communication is strictly prohibited by law. If this message has been received in error, please immediately notify us via e-mail and delete it.

3 10

[alsa-devel] [PATCH] ASoC: sigmadsp: Add check for return value of i2c_master_send
by pascal.huerst＠gmail.com 26 Nov '15

26 Nov '15

From: Pascal Huerst <pascal.huerst(a)gmail.com> i2c_master_send returns the number of bytes transmitted, which leads to an error in the firmware download function. Check for the return value and only return it directly, if it is an actual error number. Signed-off-by: Pascal Huerst <pascal.huerst(a)gmail.com> --- sound/soc/codecs/sigmadsp-i2c.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/sigmadsp-i2c.c b/sound/soc/codecs/sigmadsp-i2c.c index 21ca3a5..d374c18 100644 --- a/sound/soc/codecs/sigmadsp-i2c.c +++ b/sound/soc/codecs/sigmadsp-i2c.c @@ -31,7 +31,10 @@ static int sigmadsp_write_i2c(void *control_data, kfree(buf); - return ret; + if (ret < 0) + return ret; + + return 0; } static int sigmadsp_read_i2c(void *control_data, -- 2.4.3

2 1

Re: [alsa-devel] ASoC: hdac-hdmi: Add hdmi driver
by Dan Carpenter 26 Nov '15

26 Nov '15

Hello Subhransu S. Prusty, The patch 18382ead3640: "ASoC: hdac-hdmi: Add hdmi driver" from Nov 10, 2015, leads to the following static checker warning: sound/soc/codecs/hdac_hdmi.c:416 hdac_hdmi_parse_and_map_nid() warn: unsigned 'hdac->num_nodes' is never less than zero. sound/soc/codecs/hdac_hdmi.c 409 static int hdac_hdmi_parse_and_map_nid(struct hdac_ext_device *edev) 410 { 411 hda_nid_t nid; 412 int i; 413 struct hdac_device *hdac = &edev->hdac; 414 struct hdac_hdmi_priv *hdmi = edev->private_data; 415 int cvt_nid = 0, pin_nid = 0; 416 417 hdac->num_nodes = snd_hdac_get_sub_nodes(hdac, hdac->afg, &nid); 418 if (!nid || hdac->num_nodes < 0) { ^^^^^^^^^^^^^^^^^^^ snd_hdac_get_sub_nodes() never returns negatives. (We can't create a static checker warning for this because it's impossible to know if the author is planning to add error returns later). It returns zero if not found so maybe that was intended intsead? 419 dev_warn(&hdac->dev, "HDMI: failed to get afg sub nodes\n"); 420 return -EINVAL; 421 } regards, dan carpenter

1 0

[alsa-devel] [PATCH] ASoC: rsnd: tidyup semantics of rsnd_ssi_record_error()
by Kuninori Morimoto 26 Nov '15

26 Nov '15

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> rsnd_ssi_record_error() should recorde error, but it clears error too. this patch fixes up semantic of rsnd_ssi_record_error that it records error but doesn't clear error. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/sh/rcar/ssi.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c index dd693c0..5b97ae8 100644 --- a/sound/soc/sh/rcar/ssi.c +++ b/sound/soc/sh/rcar/ssi.c @@ -395,13 +395,9 @@ static u32 rsnd_ssi_record_error(struct rsnd_ssi *ssi) u32 status = rsnd_ssi_status_get(mod); /* under/over flow error */ - if (status & (UIRQ | OIRQ)) { + if (status & (UIRQ | OIRQ)) ssi->err++; - /* clear error status */ - rsnd_ssi_status_clear(mod); - } - return status; } @@ -536,6 +532,7 @@ static void __rsnd_ssi_interrupt(struct rsnd_mod *mod, rsnd_mod_name(mod), rsnd_mod_id(mod)); } + rsnd_ssi_status_clear(mod); rsnd_ssi_interrupt_out: spin_unlock(&priv->lock); -- 1.9.1

1 0

[alsa-devel] [PATCH] ASoC: rsnd: tidyup semantics of rsnd_src_record_error()
by Kuninori Morimoto 26 Nov '15

26 Nov '15

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> rsnd_src_error_record() should recorde error, but it clears error too. this patch fixes up semantic of rsnd_src_error_record that it records error but doesn't clear error. And this patch renames rsnd_src_error_clear() to rsnd_src_status_clear() rsnd_src_error_record() to rsnd_src_record_error() Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/sh/rcar/src.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/sound/soc/sh/rcar/src.c b/sound/soc/sh/rcar/src.c index c103aa7..6d93c4e 100644 --- a/sound/soc/sh/rcar/src.c +++ b/sound/soc/sh/rcar/src.c @@ -300,7 +300,7 @@ static void rsnd_src_irq_ctrol(struct rsnd_mod *mod, int enable) rsnd_mod_bset(mod, SCU_SYS_INT_EN1, sys_int_mask, sys_int_val); } -static void rsnd_src_error_clear(struct rsnd_mod *mod) +static void rsnd_src_status_clear(struct rsnd_mod *mod) { u32 val = OUF_SRC(rsnd_mod_id(mod)); @@ -308,7 +308,7 @@ static void rsnd_src_error_clear(struct rsnd_mod *mod) rsnd_mod_bset(mod, SCU_SYS_STATUS1, val, val); } -static bool rsnd_src_error_record(struct rsnd_mod *mod) +static bool rsnd_src_record_error(struct rsnd_mod *mod) { struct rsnd_src *src = rsnd_mod_to_src(mod); u32 val0, val1; @@ -332,9 +332,6 @@ static bool rsnd_src_error_record(struct rsnd_mod *mod) ret = true; } - /* clear error static */ - rsnd_src_error_clear(mod); - return ret; } @@ -383,7 +380,7 @@ static int rsnd_src_init(struct rsnd_mod *mod, rsnd_src_set_convert_rate(io, mod); - rsnd_src_error_clear(mod); + rsnd_src_status_clear(mod); rsnd_src_irq_enable(mod); @@ -434,7 +431,7 @@ static void __rsnd_src_interrupt(struct rsnd_mod *mod, if (!rsnd_io_is_working(io)) goto rsnd_src_interrupt_out; - if (rsnd_src_error_record(mod)) { + if (rsnd_src_record_error(mod)) { dev_dbg(dev, "%s[%d] restart\n", rsnd_mod_name(mod), rsnd_mod_id(mod)); @@ -450,7 +447,9 @@ static void __rsnd_src_interrupt(struct rsnd_mod *mod, rsnd_mod_name(mod), rsnd_mod_id(mod)); } + rsnd_src_status_clear(mod); rsnd_src_interrupt_out: + spin_unlock(&priv->lock); } -- 1.9.1

1 0

[alsa-devel] [PATCH] ASoC: rt5645: Add dmi_system_id "Google Terra"
by Bard Liao 26 Nov '15

26 Nov '15

Add platform specific data for Terra project. Signed-off-by: Luke_Yin(a)asus.com <Luke_Yin(a)asus.com> Signed-off-by: Bard Liao <bardliao(a)realtek.com> --- sound/soc/codecs/rt5645.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 2c4f06f..7b140cc 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -3572,6 +3572,13 @@ static const struct dmi_system_id dmi_platform_intel_braswell[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Wizpig"), }, }, + { + .ident = "Google Terra", + .callback = strago_quirk_cb, + .matches = { + DMI_MATCH(DMI_PRODUCT_NAME, "Terra"), + }, + }, { } }; -- 1.8.1.1.439.g50a6b54

2 4

[alsa-devel] [PATCH v2] ASoC: hdac_hdmi: convert num_nodes to int
by Sudip Mukherjee 26 Nov '15

26 Nov '15

All uses of num_nodes are considering it as a signed integer and that is very much clear when we try to save the error value in it and later try to compare it with less than 0. Signed-off-by: Sudip Mukherjee <sudip(a)vectorindia.org> --- include/sound/hdaudio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h index e2b712c..c5fad14 100644 --- a/include/sound/hdaudio.h +++ b/include/sound/hdaudio.h @@ -71,7 +71,7 @@ struct hdac_device { unsigned int flags, unsigned int *res); /* widgets */ - unsigned int num_nodes; + int num_nodes; hda_nid_t start_nid, end_nid; /* misc flags */ -- 1.9.1

2 1

Re: [alsa-devel] [PATCH] ASoC: rcar: remove unused variable
by Mark Brown 26 Nov '15

26 Nov '15

On Wed, Nov 25, 2015 at 11:54:06PM +0000, Kuninori Morimoto wrote: > It is possible to remove this patch from topic/rcar, > and, apply it to topic/pcm-list ? > ccae40fa973f5b0eec5d5ad27e81c5a2b95f7b7c > (" ASoC: rcar: remove unused variable") I did that already.

2 1