September 2014 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [v3 00/11] ASoC: Intel: sst - add the merrifield IPC driver
by Subhransu S. Prusty 01 Sep '14

01 Sep '14

This path series adds the Merrifield IPC driver which is used to load and manage the DSP along with sending and receiving IPCs for PCM and compressed audio. Changes in v3: * First patch is splitted into multiple patches * Now download fw during device resume * Removed runtime reference counting from driver context * Using dedicated functions instead ioctl * Addressed review comments Subhransu S. Prusty (8): ASoC: Intel: mrfld - add the dsp sst driver ASoC: Intel: mrfld - Add DSP load and management ASoC: Intel: sst - add pcm ops handling ASoC: Intel: sst: Add IPC handling ASoC: Intel: sst: add stream operations ASoC: Intel: sst: Add some helper functions ASoC: Intel: sst: Add makefile and kconfig changes ASoC: mfld-compress: Use dedicated function instead of ioctl Vinod Koul (3): ASoC: Intel: sst: add power management handling ASoC: Intel: sst: load firmware using async callback ASoC: Intel: sst - add compressed ops handling arch/x86/include/asm/platform_sst_audio.h | 33 + sound/soc/intel/Kconfig | 4 + sound/soc/intel/Makefile | 3 + sound/soc/intel/sst-mfld-platform-compress.c | 38 +- sound/soc/intel/sst-mfld-platform.h | 27 +- sound/soc/intel/sst/Makefile | 3 + sound/soc/intel/sst/sst.c | 576 ++++++++++++++++ sound/soc/intel/sst/sst.h | 654 ++++++++++++++++++ sound/soc/intel/sst/sst_drv_interface.c | 784 +++++++++++++++++++++ sound/soc/intel/sst/sst_ipc.c | 368 ++++++++++ sound/soc/intel/sst/sst_loader.c | 975 +++++++++++++++++++++++++++ sound/soc/intel/sst/sst_pvt.c | 207 ++++++ sound/soc/intel/sst/sst_stream.c | 526 +++++++++++++++ 13 files changed, 4179 insertions(+), 19 deletions(-) create mode 100644 sound/soc/intel/sst/Makefile create mode 100644 sound/soc/intel/sst/sst.c create mode 100644 sound/soc/intel/sst/sst.h create mode 100644 sound/soc/intel/sst/sst_drv_interface.c create mode 100644 sound/soc/intel/sst/sst_ipc.c create mode 100644 sound/soc/intel/sst/sst_loader.c create mode 100644 sound/soc/intel/sst/sst_pvt.c create mode 100644 sound/soc/intel/sst/sst_stream.c -- 1.9.0

2 24

Re: [alsa-devel] [v3 01/11] ASoC: Intel: mrfld - add the dsp sst driver
by Mark Brown 01 Sep '14

01 Sep '14

On Mon, Sep 01, 2014 at 04:07:55PM +0530, Subhransu S. Prusty wrote: > On Wed, Aug 27, 2014 at 08:40:21PM +0100, Mark Brown wrote: > > On Thu, Aug 21, 2014 at 06:20:40PM +0530, Subhransu S. Prusty wrote: > > > +static inline unsigned int sst_assign_pvt_id(struct intel_sst_drv *sst_drv_ctx) > > > +{ > > > + unsigned int local; > > > + > > > + spin_lock(&sst_drv_ctx->block_lock); > > > + sst_drv_ctx->pvt_id++; > > > + if (sst_drv_ctx->pvt_id > MAX_BLOCKS) > > > + sst_drv_ctx->pvt_id = 1; > > > + local = sst_drv_ctx->pvt_id; > > > + spin_unlock(&sst_drv_ctx->block_lock); > > > + return local; > > > +} > > The comments about overflow continue to apply here. > Vinod has already replied to you regarding this, below is a snippet from > the conversation earlier. Is there anything else we need to address? Yes, and as I said I just don't buy that argument. It's code that has fairly clear problems on inspection, saying "we've not hit the problem yet" isn't particularly persuasive. Something like a new firmware could easily trigger problems.

1 0

[alsa-devel] [PATCH -next] ASoC: es8328: fix error return code in es8328_codec_probe()
by weiyj_lk＠163.com 01 Sep '14

01 Sep '14

From: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> --- sound/soc/codecs/es8328.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/es8328.c b/sound/soc/codecs/es8328.c index 7a9f65a..3ff7870 100644 --- a/sound/soc/codecs/es8328.c +++ b/sound/soc/codecs/es8328.c @@ -665,6 +665,7 @@ static int es8328_codec_probe(struct snd_soc_codec *codec) es8328->clk = devm_clk_get(codec->dev, NULL); if (IS_ERR(es8328->clk)) { dev_err(codec->dev, "codec clock missing or invalid\n"); + ret = PTR_ERR(es8328->clk); goto clk_fail; }

2 1

[alsa-devel] [PATCH] ASoC: tlv320aic31xx: Correct interface register 2 variable name
by Peter Ujfalusi 01 Sep '14

01 Sep '14

Rename iface_reg3 to iface_reg2 since this variable is actually used for interface register 2. Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)ti.com> --- sound/soc/codecs/tlv320aic31xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/tlv320aic31xx.c b/sound/soc/codecs/tlv320aic31xx.c index 0f64c7890eed..9f9d23b94c22 100644 --- a/sound/soc/codecs/tlv320aic31xx.c +++ b/sound/soc/codecs/tlv320aic31xx.c @@ -813,7 +813,7 @@ static int aic31xx_set_dai_fmt(struct snd_soc_dai *codec_dai, { struct snd_soc_codec *codec = codec_dai->codec; u8 iface_reg1 = 0; - u8 iface_reg3 = 0; + u8 iface_reg2 = 0; u8 dsp_a_val = 0; dev_dbg(codec->dev, "## %s: fmt = 0x%x\n", __func__, fmt); @@ -838,7 +838,7 @@ static int aic31xx_set_dai_fmt(struct snd_soc_dai *codec_dai, /* NOTE: BCLKINV bit value 1 equas NB and 0 equals IB */ switch (fmt & SND_SOC_DAIFMT_INV_MASK) { case SND_SOC_DAIFMT_NB_NF: - iface_reg3 |= AIC31XX_BCLKINV_MASK; + iface_reg2 |= AIC31XX_BCLKINV_MASK; break; case SND_SOC_DAIFMT_IB_NF: break; @@ -870,7 +870,7 @@ static int aic31xx_set_dai_fmt(struct snd_soc_dai *codec_dai, dsp_a_val); snd_soc_update_bits(codec, AIC31XX_IFACE2, AIC31XX_BCLKINV_MASK, - iface_reg3); + iface_reg2); return 0; } -- 2.0.4

2 1

[alsa-devel] [PATCH v5 0/2] mfd: arizona: add support for INn_MODE register control
by Inha Song 01 Sep '14

01 Sep '14

This patch series add support for INn_MODE register control using platform data. Each input signal path can be configurated either as a Analogue or Digital using the INn_MODE registers. Changes for v5 - Change to use of_property_for_each_u32 Changes for v4 - Update document content for more clarity Changes for v3 - Change to use of_property_read_u32_array - Fix a few typos - Update commit message Changes for v2 - Change to support - Update commit message - Update document content for more clarity Inha Song (2): mfd: arizona: Add support for INn_Mode register control mfd: arizona: Update DT binding to support INn_MODE init_data Documentation/devicetree/bindings/mfd/arizona.txt | 7 +++++++ drivers/mfd/arizona-core.c | 13 +++++++++++++ 2 files changed, 20 insertions(+) -- 2.0.0.390.gcb682f8

3 6

[alsa-devel] [PATCHv2 0/2] ASoC: simple-card: Fix bug about DT node's refcount
by Xiubo Li 01 Sep '14

01 Sep '14

Change for v2: - Just rebased to the next branch newest head. Xiubo Li (2): ASoC: simple-card: Fix bug of forgetting decrement DT node's refcount ASoC: simple-card: Fix bug of wrong decrement DT node's refcount sound/soc/generic/simple-card.c | 53 ++++++++++++++++++++++------------------- 1 file changed, 29 insertions(+), 24 deletions(-) -- 1.8.4

3 6