July 2014 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] pcm: route: Use get/put labels for all 3 byte formats
by Takashi Iwai 21 Jul '14

21 Jul '14

So far, use_getput flag is set only when the src or dest format is 24bit physical width. But, also 18 and 20 bit physical width formats should set the flag, too. This patch makes the check broader to cover all 3 bytes formats. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- src/pcm/pcm_route.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/pcm/pcm_route.c b/src/pcm/pcm_route.c index 2f0be38b1906..72c198cb25d2 100644 --- a/src/pcm/pcm_route.c +++ b/src/pcm/pcm_route.c @@ -644,8 +644,10 @@ static int snd_pcm_route_hw_params(snd_pcm_t *pcm, snd_pcm_hw_params_t * params) } if (err < 0) return err; - route->params.use_getput = snd_pcm_format_physical_width(src_format) == 24 || - snd_pcm_format_physical_width(dst_format) == 24; + /* 3 bytes formats? */ + route->params.use_getput = + (snd_pcm_format_physical_width(src_format) + 7) / 3 == 3 || + (snd_pcm_format_physical_width(dst_format) + 7) / 3 == 3; route->params.get_idx = snd_pcm_linear_get_index(src_format, SND_PCM_FORMAT_S16); route->params.put_idx = snd_pcm_linear_put32_index(SND_PCM_FORMAT_S32, dst_format); route->params.conv_idx = snd_pcm_linear_convert_index(src_format, dst_format); -- 2.0.1

1 0

[alsa-devel] Fwd: USB MIDI Specification Update Proposal
by David Henningsson 21 Jul '14

21 Jul '14

Forwarding this in case anyone is interested in influencing this standard somehow, to make sure they don't do anything problematic for us...? Are we interested? // David -------- Original Message -------- Subject: USB MIDI Specification Update Proposal Date: 15 Jul 2014 19:41:23 -0400 From: MMA/IASIG Announcements <info(a)midi.org> To: July 15, 2014 Greetings, The MIDI Manufacturers Association ("MMA") Technical Standards Board ("TSB") has formed a working group to update the USB Class Specification for MIDI Devices. The original version 1.0 specification was published in 1999 by the USB Implementors Forum (USB-IF). It has been implemented in hundreds (thousands?) of devices from many different manufacturers, and all of the major operating systems include "class drivers" that allow MIDI devices to connect by USB without the user needing to install a driver. Meanwhile, the technology and the environment around MIDI and USB have changed: * Processors are faster, and USB itself is faster * Many music devices are equipped with USB ports for MIDI, and some of those can operate at faster than MIDI-DIN speed (typically via custom USB drivers) * Popular mobile systems now also support MIDI via USB, but do not allow manufacturers to install custom drivers * Mobile has low power requirements Given all of these factors, we think the USB-MIDI Specification could benefit from an update. We do not propose a major overhaul or any change of basic architecture, but rather a minor update that we expect to label as a version 1.1. The update will be done in collaboration with the USB-IF. Components of the proposed Version 1.1 Update that we plan to discuss include: * Additional Device Attributes * Bandwidth Descriptors * Add Interrupt Mode * Transfer Non-MIDI Data / Meta Event * Product Identification (Logos) We would like all commercial manufacturers of USB MIDI hardware and software to join us in this effort. If you would like to comment, ask questions, voice an opinion or suggestion, or simply have early access to the specification, please join the MMA and subscribe to the working group email mailing list. Regards, Mike Kent, WG Chair (Roland Corp.) Tom White, President/CEO, MMA ------------------------------------------------------------------------ (C) 2014 MIDI Manufacturers Association Incorporated.

2 3

[alsa-devel] [PATCH] ASoC: samsung: remove MACH_SMDKC100
by Kukjin Kim 21 Jul '14

21 Jul '14

This removes MACH_SMDKC100 because of no more support for SMDKC100. Reported-by: Paul Bolle <pebolle(a)tiscali.nl> Signed-off-by: Kukjin Kim <kgene.kim(a)samsung.com> Cc: Mark Brown <broonie(a)linaro.org> --- sound/soc/samsung/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig index 753b8c9..29459d9 100644 --- a/sound/soc/samsung/Kconfig +++ b/sound/soc/samsung/Kconfig @@ -63,7 +63,7 @@ config SND_SOC_SAMSUNG_JIVE_WM8750 config SND_SOC_SAMSUNG_SMDK_WM8580 tristate "SoC I2S Audio support for WM8580 on SMDK" - depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDK6440 || MACH_SMDK6450 || MACH_SMDKV210 || MACH_SMDKC110) + depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDK6440 || MACH_SMDK6450 || MACH_SMDKV210 || MACH_SMDKC110) depends on REGMAP_I2C select SND_SOC_WM8580 select SND_SAMSUNG_I2S @@ -146,7 +146,7 @@ config SND_SOC_SAMSUNG_RX1950_UDA1380 config SND_SOC_SAMSUNG_SMDK_WM9713 tristate "SoC AC97 Audio support for SMDK with WM9713" - depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110) + depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKV210 || MACH_SMDKC110) select SND_SOC_WM9713 select SND_SAMSUNG_AC97 help -- 1.8.2.1.339.g52a3e01

2 1

[alsa-devel] [PATCH alsa-lib v2] pcm: Fill sw_params proto field
by Takashi Iwai 21 Jul '14

21 Jul '14

Fill the new proto field introduced to sw_params with the current PCM protocol version. This makes tstamp_type evaluated properly in the kernel. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- v1->v2: rearrange proto and tstamp_type fields include/sound/asound.h | 4 ++-- src/pcm/pcm.c | 1 + src/pcm/pcm_params.c | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/sound/asound.h b/include/sound/asound.h index 552f41bd1ca9..c819df421434 100644 --- a/include/sound/asound.h +++ b/include/sound/asound.h @@ -386,8 +386,8 @@ struct snd_pcm_sw_params { snd_pcm_uframes_t silence_threshold; /* min distance from noise for silence filling */ snd_pcm_uframes_t silence_size; /* silence block size */ snd_pcm_uframes_t boundary; /* pointers wrap point */ - unsigned int tstamp_type; /* timestamp type */ - int pads; /* alignment, reserved */ + unsigned int proto; /* protocol version */ + unsigned int tstamp_type; /* timestamp type (req. proto >= 2.0.12) */ unsigned char reserved[56]; /* reserved for future */ }; diff --git a/src/pcm/pcm.c b/src/pcm/pcm.c index 89844430bf35..1399a5b2e671 100644 --- a/src/pcm/pcm.c +++ b/src/pcm/pcm.c @@ -5610,6 +5610,7 @@ int snd_pcm_sw_params_current(snd_pcm_t *pcm, snd_pcm_sw_params_t *params) SNDMSG("PCM not set up"); return -EIO; } + params->proto = SNDRV_PCM_VERSION; params->tstamp_mode = pcm->tstamp_mode; params->tstamp_type = pcm->tstamp_type; params->period_step = pcm->period_step; diff --git a/src/pcm/pcm_params.c b/src/pcm/pcm_params.c index 4adbefae0530..6e57904e445b 100644 --- a/src/pcm/pcm_params.c +++ b/src/pcm/pcm_params.c @@ -2257,6 +2257,7 @@ static int snd_pcm_sw_params_default(snd_pcm_t *pcm, snd_pcm_sw_params_t *params { assert(pcm && params); assert(pcm->setup); + params->proto = SNDRV_PCM_VERSION; params->tstamp_mode = SND_PCM_TSTAMP_NONE; params->tstamp_type = pcm->tstamp_type; params->period_step = 1; -- 2.0.1

1 0

[alsa-devel] [PATCH v2 1/2] ALSA: pcm: Introduce protocol version field to sw_params
by Takashi Iwai 21 Jul '14

21 Jul '14

For controlling the new fields more strictly, add sw_params.proto field indicating the protocol version of the user-space. User-space should fill the SNDRV_PCM_VERSION value it's built with, then kernel can know whether the new fields should be evaluated or not. And now tstamp_type field is evaluated only when the valid value is set there. This avoids the wrong override of tstamp_type to zero, which is SNDRV_PCM_TSTAMP_TYPE_GETTIMEOFDAY. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- v1->v2: rearrange the order of proto and tstamp_type fields include/uapi/sound/asound.h | 4 ++-- sound/core/pcm_native.c | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h index a7e062f91f39..32168f7ffce3 100644 --- a/include/uapi/sound/asound.h +++ b/include/uapi/sound/asound.h @@ -391,8 +391,8 @@ struct snd_pcm_sw_params { snd_pcm_uframes_t silence_threshold; /* min distance from noise for silence filling */ snd_pcm_uframes_t silence_size; /* silence block size */ snd_pcm_uframes_t boundary; /* pointers wrap point */ - unsigned int tstamp_type; /* timestamp type */ - int pads; /* alignment, reserved */ + unsigned int proto; /* protocol version */ + unsigned int tstamp_type; /* timestamp type (req. proto >= 2.0.12) */ unsigned char reserved[56]; /* reserved for future */ }; diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index 81dedc381efd..8cd2f930ad0b 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -543,7 +543,8 @@ static int snd_pcm_sw_params(struct snd_pcm_substream *substream, if (params->tstamp_mode > SNDRV_PCM_TSTAMP_LAST) return -EINVAL; - if (params->tstamp_type > SNDRV_PCM_TSTAMP_TYPE_LAST) + if (params->proto >= SNDRV_PROTOCOL_VERSION(2, 0, 12) && + params->tstamp_type > SNDRV_PCM_TSTAMP_TYPE_LAST) return -EINVAL; if (params->avail_min == 0) return -EINVAL; @@ -559,7 +560,8 @@ static int snd_pcm_sw_params(struct snd_pcm_substream *substream, err = 0; snd_pcm_stream_lock_irq(substream); runtime->tstamp_mode = params->tstamp_mode; - runtime->tstamp_type = params->tstamp_type; + if (params->proto >= SNDRV_PROTOCOL_VERSION(2, 0, 12)) + runtime->tstamp_type = params->tstamp_type; runtime->period_step = params->period_step; runtime->control->avail_min = params->avail_min; runtime->start_threshold = params->start_threshold; -- 2.0.1

1 1

[alsa-devel] about ALSA subdevice
by lei.ge＠freescale.com 21 Jul '14

21 Jul '14

Dear ALSA-devel members, I want to add subdevices to our ASoC drivers, for example: card 0: imxesai [imxesai], device 0: imxesai PCM [imxesai PCM] Subdevices: 3/4 Subdevice #0: subdevice #0 Subdevice #1: subdevice #1 Subdevice #2: subdevice #2 Subdevice #3: subdevice #3 I saw BCM2835 use 8 subdevices in sound/arm/, but it is not standard ASoC driver. What should I do if I want to add subdevices in standard ASoC driver? Can anyone show me an example? Thanks! Ge Lei 2014-7-21

1 0

[alsa-devel] [PATCH] ALSA: pcm: Introduce protocol version field to sw_params
by Takashi Iwai 21 Jul '14

21 Jul '14

For controlling the new fields more strictly, add sw_params.proto field indicating the protocol version of the user-space. User-space should fill the SNDRV_PCM_VERSION value it's built with, then kernel can know whether the new fields should be evaluated or not. And now tstamp_type field is evaluated only when the valid value is set there. This avoids the wrong override of tstamp_type to zero, which is SNDRV_PCM_TSTAMP_TYPE_GETTIMEOFDAY. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- include/uapi/sound/asound.h | 4 ++-- sound/core/pcm_native.c | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h index a7e062f91f39..c9fd199b9330 100644 --- a/include/uapi/sound/asound.h +++ b/include/uapi/sound/asound.h @@ -391,8 +391,8 @@ struct snd_pcm_sw_params { snd_pcm_uframes_t silence_threshold; /* min distance from noise for silence filling */ snd_pcm_uframes_t silence_size; /* silence block size */ snd_pcm_uframes_t boundary; /* pointers wrap point */ - unsigned int tstamp_type; /* timestamp type */ - int pads; /* alignment, reserved */ + unsigned int tstamp_type; /* timestamp type (req. proto >= 2.0.12) */ + unsigned int proto; /* protocol version */ unsigned char reserved[56]; /* reserved for future */ }; diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index 81dedc381efd..8cd2f930ad0b 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -543,7 +543,8 @@ static int snd_pcm_sw_params(struct snd_pcm_substream *substream, if (params->tstamp_mode > SNDRV_PCM_TSTAMP_LAST) return -EINVAL; - if (params->tstamp_type > SNDRV_PCM_TSTAMP_TYPE_LAST) + if (params->proto >= SNDRV_PROTOCOL_VERSION(2, 0, 12) && + params->tstamp_type > SNDRV_PCM_TSTAMP_TYPE_LAST) return -EINVAL; if (params->avail_min == 0) return -EINVAL; @@ -559,7 +560,8 @@ static int snd_pcm_sw_params(struct snd_pcm_substream *substream, err = 0; snd_pcm_stream_lock_irq(substream); runtime->tstamp_mode = params->tstamp_mode; - runtime->tstamp_type = params->tstamp_type; + if (params->proto >= SNDRV_PROTOCOL_VERSION(2, 0, 12)) + runtime->tstamp_type = params->tstamp_type; runtime->period_step = params->period_step; runtime->control->avail_min = params->avail_min; runtime->start_threshold = params->start_threshold; -- 2.0.1

2 2

[alsa-devel] [PATCH -next] ASoC: samsung: Fix return value check in s3c24xx_iis_dev_probe()
by weiyj_lk＠163.com 20 Jul '14

20 Jul '14

From: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Also remove redundant return value check of platform_get_resource(). Signed-off-by: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> --- sound/soc/samsung/s3c24xx-i2s.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/samsung/s3c24xx-i2s.c b/sound/soc/samsung/s3c24xx-i2s.c index e87d9a2..36dbc17 100644 --- a/sound/soc/samsung/s3c24xx-i2s.c +++ b/sound/soc/samsung/s3c24xx-i2s.c @@ -456,13 +456,9 @@ static int s3c24xx_iis_dev_probe(struct platform_device *pdev) struct resource *res; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(&pdev->dev, "Can't get IO resource.\n"); - return -ENOENT; - } s3c24xx_i2s.regs = devm_ioremap_resource(&pdev->dev, res); - if (s3c24xx_i2s.regs == NULL) - return -ENXIO; + if (IS_ERR(s3c24xx_i2s.regs)) + return PTR_ERR(s3c24xx_i2s.regs); s3c24xx_i2s_pcm_stereo_out.dma_addr = res->start + S3C2410_IISFIFO; s3c24xx_i2s_pcm_stereo_in.dma_addr = res->start + S3C2410_IISFIFO;

1 0

[alsa-devel] mpd + emu 0404 USB automatic sample rate
by Killer{R} 19 Jul '14

19 Jul '14

Hello alsa-devel, I'm trying to build bit-perfect music playback box using Olinuxino board and EMU 0404 USB sound card running MPD. I have wide collection of lossless songs with different sampling rates - from 44100 to 192000. I set MPD config to play sound via correct alsa device and it works, however whenever I start play song with different sampling rate - MPD (or ALSA?) 'forgets' to switch sampling rate frequency and I hear buzzing sound instead of music. If I run alsamixer and manually switch there sampling rate - it plays OK until I select song with again different sampling rate. It seems I'm not first with such a problem, here is same complain with a workadound: http://murga-linux.com/puppy/viewtopic.php?p=745547#745547 Currently I'm running sunxi Linux kernel: 3.4.90, but same bug reproduced when I used Raspberry PI with kernel 3.6.11 ALSA's version: cat /proc/asound/version Advanced Linux Sound Architecture Driver Version 1.0.25. Seems I was able to fix this on my system, but not sure if this fix is correct, here is diff: --- quirks.c Fri Jul 18 01:20:16 2014 +++ quirks.c Sun Jul 20 00:20:49 2014 @@ -723,7 +723,8 @@ static void set_format_emu_quirk(struct * by playback substream */ if (subs->direction == SNDRV_PCM_STREAM_PLAYBACK) { - if (subs->stream->substream[SNDRV_PCM_STREAM_CAPTURE].interface != -1) + if (subs->stream->substream[SNDRV_PCM_STREAM_CAPTURE].interface != -1 && + subs->stream->substream[SNDRV_PCM_STREAM_CAPTURE].running) return; } -- Best regards, Killer{R} mailto:support@killprog.com

1 0

[alsa-devel] Question on fe_dai_open
by gsantosh＠codeaurora.org 19 Jul '14

19 Jul '14

Hi All, In the following function dpcm_fe_dai_open Why the code is proceeding further if dpcm_path_get returns zero, if dpcm_path_get returns zero implies there is no vaild path setup. technically we should return from the function when there is no valid path setup, still we proceed further de-referencing the pointer at the exit of this function through dpcm_path_put(&list); please let me know why we are not returning when dpcm_path_get returns zero. static int dpcm_fe_dai_open(struct snd_pcm_substream *fe_substream) { .... if (dpcm_path_get(fe, stream, &list) <= 0) { dev_dbg(fe->dev, "ASoC: %s no valid %s route\n", fe->dai_link->name, stream ? "capture" : "playback"); /*we need to return if there is no vaild paths available*/ } .... dpcm_path_put(&list); } Regards Santosh M G

1 1