May 2014 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 1/2] mfd: mc13xxx: Do not use platform data with devicetree
by Alexander Shiyan 09 May '14

09 May '14

This patch removes platform data usage for codec and touchscreen when driver is used with devicetree. This fixes possible "null pointer dereference" error if DTS uses "fsl,mc13xxx-uses-codec" or "fsl,mc13xxx-uses-touch" options. Signed-off-by: Alexander Shiyan <shc_work(a)mail.ru> --- drivers/mfd/mc13xxx-core.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c index 06e64b6..2ed22d7 100644 --- a/drivers/mfd/mc13xxx-core.c +++ b/drivers/mfd/mc13xxx-core.c @@ -673,17 +673,9 @@ int mc13xxx_common_init(struct device *dev) if (mc13xxx->flags & MC13XXX_USE_ADC) mc13xxx_add_subdevice(mc13xxx, "%s-adc"); - if (mc13xxx->flags & MC13XXX_USE_CODEC) - mc13xxx_add_subdevice_pdata(mc13xxx, "%s-codec", - pdata->codec, sizeof(*pdata->codec)); - if (mc13xxx->flags & MC13XXX_USE_RTC) mc13xxx_add_subdevice(mc13xxx, "%s-rtc"); - if (mc13xxx->flags & MC13XXX_USE_TOUCHSCREEN) - mc13xxx_add_subdevice_pdata(mc13xxx, "%s-ts", - &pdata->touch, sizeof(pdata->touch)); - if (pdata) { mc13xxx_add_subdevice_pdata(mc13xxx, "%s-regulator", &pdata->regulators, sizeof(pdata->regulators)); @@ -691,10 +683,20 @@ int mc13xxx_common_init(struct device *dev) pdata->leds, sizeof(*pdata->leds)); mc13xxx_add_subdevice_pdata(mc13xxx, "%s-pwrbutton", pdata->buttons, sizeof(*pdata->buttons)); + if (mc13xxx->flags & MC13XXX_USE_CODEC) + mc13xxx_add_subdevice_pdata(mc13xxx, "%s-codec", + pdata->codec, sizeof(*pdata->codec)); + if (mc13xxx->flags & MC13XXX_USE_TOUCHSCREEN) + mc13xxx_add_subdevice_pdata(mc13xxx, "%s-ts", + &pdata->touch, sizeof(pdata->touch)); } else { mc13xxx_add_subdevice(mc13xxx, "%s-regulator"); mc13xxx_add_subdevice(mc13xxx, "%s-led"); mc13xxx_add_subdevice(mc13xxx, "%s-pwrbutton"); + if (mc13xxx->flags & MC13XXX_USE_CODEC) + mc13xxx_add_subdevice(mc13xxx, "%s-codec"); + if (mc13xxx->flags & MC13XXX_USE_TOUCHSCREEN) + mc13xxx_add_subdevice(mc13xxx, "%s-ts"); } return 0; -- 1.8.3.2

2 1

[alsa-devel] Sound issue in omap-twl4030
by Chaitral Purkar 09 May '14

09 May '14

Hello, I am working on enabling audio support on a customized board which is similar to zoom2. I am not able to hear any sound (with aplay) except two click/pop sounds (at start and at end). I have ported Ubuntu kernel 3.7.10 on this board which has OMAP3530. On this board, I have TPS65930 chip which has a speaker connected over PreDriv.L and PreDriv.R. I have incorporated the changes suggested on http://mailman.alsa-project.org/pipermail/alsa-devel/2012-December/058119.h… and updated sound/soc/omap/omap-twl4030.c, sound/soc/codecs/twl4030.c and board-file under arch/arm/mach-omap2/. When I try to play audio, ubuntu@arm:~$ aplay -v test.wav Playing WAVE 'test.wav' : Signed 16 bit Little Endian, Rate 44100 Hz, Stereo ALSA <-> PulseAudio PCM I/O Plugin Its setup is: stream : PLAYBACK access : RW_INTERLEAVED format : S16_LE subformat : STD channels : 2 rate : 44100 exact rate : 44100 (44100/1) msbits : 16 buffer_size : 22050 period_size : 5512 period_time : 125000 tstamp_mode : NONE period_step : 1 avail_min : 5512 period_event : 0 start_threshold : 22050 stop_threshold : 22050 silence_threshold: 0 silence_size : 0 boundary : 1445068800 ubuntu@arm:~$ However, no audio comes out from speaker. dmesg shows following- [ 1613.446319] omap-dma-engine omap-dma-engine: allocating channel for 33 [ 1613.502471] clock: dpll1_ck: set rate: locking rate to 600000000. [ 1613.502502] clock: configuring DPLL dpll1_ck for low-power bypass [ 1613.502563] clock: dpll1_ck transition to 'bypassed' in 0 loops [ 1613.502624] clock: locking DPLL dpll1_ck [ 1613.502777] clock: dpll1_ck transition to 'locked' in 94 loops [ 1613.822082] clock: dpll1_ck: set rate: locking rate to 500000000. [ 1613.822113] clock: configuring DPLL dpll1_ck for low-power bypass [ 1613.822143] clock: dpll1_ck transition to 'bypassed' in 0 loops [ 1613.822174] clock: locking DPLL dpll1_ck [ 1613.822326] clock: dpll1_ck transition to 'locked' in 29 loops [ 1614.126739] clock: dpll1_ck: set rate: locking rate to 250000000. [ 1614.126770] clock: configuring DPLL dpll1_ck for low-power bypass [ 1614.126800] clock: dpll1_ck transition to 'bypassed' in 0 loops [ 1614.126831] clock: locking DPLL dpll1_ck [ 1614.127014] clock: dpll1_ck transition to 'locked' in 34 loops [ 1614.783264] clock: dpll1_ck: set rate: locking rate to 125000000. [ 1614.783294] clock: configuring DPLL dpll1_ck for low-power bypass [ 1614.783325] clock: dpll1_ck transition to 'bypassed' in 0 loops [ 1614.783355] clock: locking DPLL dpll1_ck [ 1614.783538] clock: dpll1_ck transition to 'locked' in 58 loops [ 1617.033203] omap-dma-engine omap-dma-engine: freeing channel for 33 I have following struct defined in the board file and not using device tree support. static struct omap_tw4030_pdata omap_twl4030_audio_data = { .voice_connected = false, .custom_routing = true, .has_predriv = OMAP_TWL4030_LEFT | OMAP_TWL4030_RIGHT, }; Also, I have set the amixer controls. Please find the file attached herewith. However, I am still not able hear sound. Can anybody please provide any pointer in this regard. Thanks in advance. Regards, Chaitral Purkar DISCLAIMER ========== This e-mail may contain privileged and confidential information which is the property of Persistent Systems Ltd. It is intended only for the use of the individual or entity to which it is addressed. If you are not the intended recipient, you are not authorized to read, retain, copy, print, distribute or use this message. If you have received this communication in error, please notify the sender and delete all copies of this message. Persistent Systems Ltd. does not accept any liability for virus infected mails.

1 0

[alsa-devel] [PATCH] ALSA: hda - add headset mic detect quirks for three Dell laptops
by Hui Wang 09 May '14

09 May '14

When we plug a 3-ring headset on the Dell machines (VID: 0x10ec0255, SID: 0x1028065c; VID: 0x10ec0255, SID: 0x10280680; VID: 0x10ec0292, SID: 0x10280684), the headset mic can't be detected, after apply this patch, the headset mic can work well. And on the machine with SID 0x10280684, and the Lineout and external microphone should be routed to docking, this patch also fix this problem. BugLink: https://bugs.launchpad.net/bugs/1297581 Cc: David Henningsson <david.henningsson(a)canonical.com> Cc: stable(a)vger.kernel.org Signed-off-by: Hui Wang <hui.wang(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index b60de0d..385b003 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4705,6 +4705,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x0653, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0657, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0658, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x065c, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x065f, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0662, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0667, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), @@ -4713,6 +4714,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x0674, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x067e, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x067f, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x0680, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x0684, "Dell", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x15cc, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x15cd, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x164a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), -- 1.8.1.2

2 1

Re: [alsa-devel] [PATCH] ASoC: Intel: Build Medfield compressed ops
by Koul, Vinod 09 May '14

09 May '14

On 9 May 2014 04:01, Mark Brown <broonie(a)kernel.org> wrote: > > From: Mark Brown <broonie(a)linaro.org> > > Since commit 4b68b4e1c564 (ASoC: Intel: split the pcm and compress to > different files) the compressed ops haven't been built causing link > failures on allyesconfig and making the driver unbuildable. Add the > object to the Makefile to fix that. > Thanks looks like makefile patch missed this. I will fix and resend the series next week when I am back > Signed-off-by: Mark Brown <broonie(a)linaro.org> Acked-by Vinod Koul <vinod.koul(a)intel.com> > --- > sound/soc/intel/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/Makefile b/sound/soc/intel/Makefile > index 5d3fb6f35a19..0db4e2f336dc 100644 > --- a/sound/soc/intel/Makefile > +++ b/sound/soc/intel/Makefile > @@ -2,7 +2,7 @@ > snd-soc-sst-dsp-objs := sst-dsp.o sst-firmware.o > snd-soc-sst-acpi-objs := sst-acpi.o > > -snd-soc-sst-mfld-platform-objs := sst-mfld-platform-pcm.o > +snd-soc-sst-mfld-platform-objs := sst-mfld-platform-pcm.o sst-mfld-platform-compress.o > snd-soc-mfld-machine-objs := mfld_machine.o > > obj-$(CONFIG_SND_SST_MFLD_PLATFORM) += snd-soc-sst-mfld-platform.o > -- > 2.0.0.rc2 >

1 0

[alsa-devel] [PATCH] ASoC: Intel: Build Medfield compressed ops
by Mark Brown 09 May '14

09 May '14

From: Mark Brown <broonie(a)linaro.org> Since commit 4b68b4e1c564 (ASoC: Intel: split the pcm and compress to different files) the compressed ops haven't been built causing link failures on allyesconfig and making the driver unbuildable. Add the object to the Makefile to fix that. Signed-off-by: Mark Brown <broonie(a)linaro.org> --- sound/soc/intel/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/Makefile b/sound/soc/intel/Makefile index 5d3fb6f35a19..0db4e2f336dc 100644 --- a/sound/soc/intel/Makefile +++ b/sound/soc/intel/Makefile @@ -2,7 +2,7 @@ snd-soc-sst-dsp-objs := sst-dsp.o sst-firmware.o snd-soc-sst-acpi-objs := sst-acpi.o -snd-soc-sst-mfld-platform-objs := sst-mfld-platform-pcm.o +snd-soc-sst-mfld-platform-objs := sst-mfld-platform-pcm.o sst-mfld-platform-compress.o snd-soc-mfld-machine-objs := mfld_machine.o obj-$(CONFIG_SND_SST_MFLD_PLATFORM) += snd-soc-sst-mfld-platform.o -- 2.0.0.rc2

1 0

[alsa-devel] [PATCH] rawmidi.c Set a name for a newly allocated rawmidi substream
by Ralf Beck 08 May '14

08 May '14

Rationale: Bitwig Studio (and possibly other rawmidi clients) enumerate the Midi I/Os by substream names. With the current rawmidi implementation, the name is an empty string and only the USB mididriver changes it to a meaningful value after allocation. This patch sets a default substream name of the form "somename x-y-z" --- linux-source-3.13.0/sound/core/rawmidi.c.orig 2014-05-06 20:25:33.683081389 +0200 +++ linux-source-3.13.0/sound/core/rawmidi.c 2014-05-06 17:42:35.058097185 +0200 @@ -34,6 +34,7 @@ #include <sound/control.h> #include <sound/minors.h> #include <sound/initval.h> +#include <linux/string.h> MODULE_AUTHOR("Jaroslav Kysela <perex(a)perex.cz>"); MODULE_DESCRIPTION("Midlevel RawMidi code for ALSA."); @@ -1420,6 +1421,8 @@ static int snd_rawmidi_alloc_substreams( substream->number = idx; substream->rmidi = rmidi; substream->pstr = stream; + snprintf(substream->name, sizeof(substream->name), + "%s %d-%d-%d", rmidi->id, rmidi->card->number, rmidi->device, idx); list_add_tail(&substream->list, &stream->substreams); stream->substream_count++; }

2 3

[alsa-devel] [PATCH]: snd_seq_virmidi.c do not use running status for virmidi raw input
by Ralf Beck 08 May '14

08 May '14

Rationale: Not every rawmidi alsa client (e.q. Bitwig) support running status on input. There is also no need for running status inside a computer. This patch disables the removal of the status byte when decoding snd_midi_event structures to a rawmidi bytestream --- sound/core/seq/seq_virmidi.c.orig 2014-05-07 19:30:44.175914670 +0200 +++ sound/core/seq/seq_virmidi.c 2014-05-07 19:33:38.931906859 +0200 @@ -212,6 +212,7 @@ static int snd_virmidi_input_open(struct kfree(vmidi); return -ENOMEM; } + vmidi->parser->nostat = 1; vmidi->seq_mode = rdev->seq_mode; vmidi->client = rdev->client; vmidi->port = rdev->port;

2 3

[alsa-devel] [PATCH v2 0/8] ASoC: Intel: rework the mfld platform driver
by Vinod Koul 08 May '14

08 May '14

This patch series reworks and reformats the existing platform driver we use. This is stepping support for seconds series of patches which will support Merrifield platform with DPCM based implementation Not much logical changes in code except adding drain support for compressed audio. Most is mere modularization of the existing code Fixes in v2: - add two more patches - fix makefile addition is 4th patch - dropped name change in platform ops patch Vinod Koul (8): ASoC: Intel: remove FSF snail mail address ASoc: Intel: rename sst-mfld-platform.c ASoC: Intel: mark sst_set_stream_status as non static ASoC: Intel: split the pcm and compress to different files ASoC: Intel: remove unused sst-mfld platform dais ASoC: Intel: add drain_notify support ASoC: Intel: remove codec memeber from codec structs ASoC: Intel: move component registration blob sound/soc/intel/Makefile | 14 +- sound/soc/intel/sst-mfld-dsp.h | 8 - sound/soc/intel/sst-mfld-platform-compress.c | 237 +++++++++++++++++++ ...sst-mfld-platform.c => sst-mfld-platform-pcm.c} | 250 +------------------- sound/soc/intel/sst-mfld-platform.h | 11 +- 5 files changed, 263 insertions(+), 257 deletions(-) create mode 100644 sound/soc/intel/sst-mfld-platform-compress.c rename sound/soc/intel/{sst-mfld-platform.c => sst-mfld-platform-pcm.c} (67%)

3 11

[alsa-devel] [PATCH 0/7] ARM: shmobile: swtich audio settings to new style, and remove compatibility code from driver
by Kuninori Morimoto 08 May '14

08 May '14

Hi Simon, Mark Now, Linux v3.15-rc1 was released. 1) - 5) remove old style audio settings from platform, and 6) - 7) remove compatibility (= old style) code from driver. These are based on v3.15-rc1 Simon, can you please create v3.15-rc1 base branch/tag for Mark ? Kuninori Morimoto (7): 1) ARM: shmobile: r8a7778: remove old style audio clock 2) ARM: shmobile: r8a7790: remove old style audio clock 3) ARM: shmobile: bockw: remove old style audio clock 4) ARM: shmobile: bockw: switch to use dai info for R-Car sound 5) ARM: shmobile: lager: switch to use dai info for R-Car sound 6) ASoC: rsnd: remove old clock style support 7) ASoC: rsnd: remove compatibility code arch/arm/mach-shmobile/board-bockw.c | 63 +++++++++++++++++++---------- arch/arm/mach-shmobile/board-lager.c | 17 +++++--- arch/arm/mach-shmobile/clock-r8a7778.c | 22 +++++----- arch/arm/mach-shmobile/clock-r8a7790.c | 24 +++++------ include/sound/rcar_snd.h | 22 ++-------- sound/soc/sh/rcar/adg.c | 39 ++---------------- sound/soc/sh/rcar/core.c | 54 +++++-------------------- sound/soc/sh/rcar/rsnd.h | 3 -- sound/soc/sh/rcar/src.c | 69 ++++++++++---------------------- sound/soc/sh/rcar/ssi.c | 51 +---------------------- 10 files changed, 111 insertions(+), 253 deletions(-) Best regards --- Kuninori Morimoto

4 17

[alsa-devel] [PATCH 1/2] ASoC: rt5645: Fix a serious typo
by Oder Chiou 08 May '14

08 May '14

The patch corrects a serious typo in struct reg_default. Signed-off-by: Oder Chiou <oder_chiou(a)realtek.com> --- sound/soc/codecs/rt5645.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 6db6f81..30410eb 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -50,10 +50,10 @@ static const struct regmap_range_cfg rt5645_ranges[] = { static const struct reg_default init_list[] = { {RT5645_PR_BASE + 0x3d, 0x3600}, - {RT5645_PR_BASE + 0x1c, 0xfd20); - {RT5645_PR_BASE + 0x20, 0x611f); - {RT5645_PR_BASE + 0x21, 0x4040); - {RT5645_PR_BASE + 0x23, 0x0004); + {RT5645_PR_BASE + 0x1c, 0xfd20}, + {RT5645_PR_BASE + 0x20, 0x611f}, + {RT5645_PR_BASE + 0x21, 0x4040}, + {RT5645_PR_BASE + 0x23, 0x0004}, }; #define RT5645_INIT_REG_LEN ARRAY_SIZE(init_list) -- 1.8.1.1.439.g50a6b54

2 2