March 2014 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] Xonar DG backports
by Clemens Ladisch 05 Mar '14

05 Mar '14

Hi Roman, I backporting the bugfixes in your patches to the stable kernels. However, I'm unable to see what was changed to enable the headphone outputs. What particular thing did the old driver wrong? Regards, Clemens

2 1

[alsa-devel] Audio-Bug
by Silver Death 05 Mar '14

05 Mar '14

Hi there, many people have this bug: https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/1200925 I would fix it, but I have no knowledge in C and about the kernel internal. I also didn't found any documentation which I could use to translate the datasheet into the source file. So I gentle ask you, if you could as a maintainer fix this bug or at least give me some information/instruction/documentation. Thanks in advance. With best regards, Simon

1 0

Re: [alsa-devel] Question on compress offload framework memory corruption
by Banajit Goswami 05 Mar '14

05 Mar '14

Hi Liam, > On Thu, Dec 19, 2013 at 10:55:08AM +0000, Mark Brown wrote: > > On Wed, Dec 18, 2013 at 01:17:51PM -0000, gsantosh(a)codeaurora.org wrote: > > > Hi, > > > > > > I have following questions in the compressed offload framework API. > > > > > > static int soc_compr_set_params_fe(struct snd_compr_stream *cstream, > > > struct snd_compr_params *params) { ... > > > hw_params = kzalloc(sizeof(*hw_params), GFP_KERNEL); > > > if (hw_params == NULL) > > > return -ENOMEM; > > > /*1st question is, what is the use of above allocated memory I do > > > not see this being used in this function*/ > > > > The code you're quoting there isn't in mainline. I've also added > > Vinod to the CCs, you probably want to include him in any discussion > > of the compressed API. > > That's right, this is from DPCM compressed updated done by Liam, so he is > the best person to comment on this bit, and somehow his address in CC has > gone bad, i have added him in to list > But yes looking at the source, i agree that two are interlinked. > I guess we need to poupulate the hw_params and then use that to copy, that > would be the right thing to do here and yes this is not correct and not > sure how this is working... Continuing the discussion on the "memcpy" function in Santosh's 2nd question- > > > memcpy(&fe->dpcm[fe_substream->stream].hw_params, params, > > > sizeof(struct snd_pcm_hw_params)); > > > > > > /* 2nd question is > > > in above memcpy there is parameter mismatch > > > &fe->dpcm[fe_substream->stream].hw_params is of structure type struct > > > snd_pcm_hw_params > > > > > > params argument is of the structure type struct snd_compr_params > > > the definition of the two structures are different, how this is > > > working? > > > this will over right the destination with junk value which will return > > > in error when this memory is accessed, after memcpy this cpu_dai > > > hw_params > > > returing with EINVAL error, please explain why this is done this way. > > > */ I can see that a later version of the patch adds the function soc_compr_set_params_fe() at- http://permalink.gmane.org/gmane.linux.alsa.devel/117716 with the below code replaces the "memcpy" function with a "memset"- + /* + * Create an empty hw_params for the BE as the machine driver must + * fix this up to match DSP decoder and ASRC configuration. + * I.e. machine driver fixup for compressed BE is mandatory. + */ + memset(&fe->dpcm[fe_substream->stream].hw_params, 0, + sizeof(struct snd_pcm_hw_params)); It's evident that the code relies on machine driver fixup function to populate the parameters of hw_params before propagating those to back-end. I think rather than that, like Vinod also mentioned, the hw_params should have been populated with individual parameters which are relevant. Let me know your comment on this. Thanks, Banajit The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

2 1

[alsa-devel] Update patch for codecs alias name for Dell
by Kailang 05 Mar '14

05 Mar '14

Hi Takashi, Dell assigned more codecs for alias name. I update in attach patch. Thanks. Kailang

3 7

[alsa-devel] [PATCH v5 0/7] ASoC: add CSR SiRFSoC sound drivers
by RongJun Ying 05 Mar '14

05 Mar '14

From: Rongjun Ying <rongjun.ying(a)csr.com> This patchset adds CSR SiRFSoC sound drivers including: 1. The SiRF internal audio codec driver 2. The SiRF audio port driver 3. The SiRF internal audio card driver 4. The SiRF I2S controller driver 5. The SiRF hdmi card driver 6. The SiRF USP controller(DSP mode) driver 7. The SiRF bt-sco card driver -v5: 1. Drop all inlines. 2. Reordering the Kconfig and Makefile 3. Remove the sirf_audio_codec_reg_bits struct, use the new controls instead it. 4. Add some SND_SOC_DAPM_OUT_DRV instead of HP and SPK enable driver 5. Add audio codec clock supply instead of adc event callback 6. Fixed playback and capture can't concurrent work bug. Rongjun Ying (7): ASoC: sirf: Add SiRF internal audio codec driver ASoC: sirf: Add SiRF audio port driver is used by SiRF internal audio codec ASoC: sirf: Add SiRF audio card ASoC: sirf: Add SiRF I2S driver ASoC: sirf: Add hdmi card ASoC: sirf: Add usp driver which is used by dsp mode ASoC: sirf: Add bt-sco card .../devicetree/bindings/sound/sirf-audio-codec.txt | 17 + .../devicetree/bindings/sound/sirf-audio-port.txt | 20 + .../devicetree/bindings/sound/sirf-audio.txt | 41 ++ .../devicetree/bindings/sound/sirf-bt-sco.txt | 18 + .../devicetree/bindings/sound/sirf-hdmi.txt | 15 + .../devicetree/bindings/sound/sirf-i2s.txt | 27 + .../devicetree/bindings/sound/sirf-usp.txt | 27 + sound/soc/Kconfig | 1 + sound/soc/Makefile | 1 + sound/soc/codecs/Kconfig | 6 +- sound/soc/codecs/Makefile | 2 + sound/soc/codecs/sirf-audio-codec.c | 534 ++++++++++++++++++++ sound/soc/codecs/sirf-audio-codec.h | 75 +++ sound/soc/sirf/Kconfig | 34 ++ sound/soc/sirf/Makefile | 13 + sound/soc/sirf/sirf-audio-port.c | 194 +++++++ sound/soc/sirf/sirf-audio-port.h | 62 +++ sound/soc/sirf/sirf-audio.c | 156 ++++++ sound/soc/sirf/sirf-bt-sco.c | 99 ++++ sound/soc/sirf/sirf-hdmi.c | 98 ++++ sound/soc/sirf/sirf-i2s.c | 434 ++++++++++++++++ sound/soc/sirf/sirf-i2s.h | 88 ++++ sound/soc/sirf/sirf-usp.c | 448 ++++++++++++++++ sound/soc/sirf/sirf-usp.h | 282 +++++++++++ 24 files changed, 2691 insertions(+), 1 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/sirf-audio-codec.txt create mode 100644 Documentation/devicetree/bindings/sound/sirf-audio-port.txt create mode 100644 Documentation/devicetree/bindings/sound/sirf-audio.txt create mode 100644 Documentation/devicetree/bindings/sound/sirf-bt-sco.txt create mode 100644 Documentation/devicetree/bindings/sound/sirf-hdmi.txt create mode 100644 Documentation/devicetree/bindings/sound/sirf-i2s.txt create mode 100644 Documentation/devicetree/bindings/sound/sirf-usp.txt create mode 100644 sound/soc/codecs/sirf-audio-codec.c create mode 100644 sound/soc/codecs/sirf-audio-codec.h create mode 100644 sound/soc/sirf/Kconfig create mode 100644 sound/soc/sirf/Makefile create mode 100644 sound/soc/sirf/sirf-audio-port.c create mode 100644 sound/soc/sirf/sirf-audio-port.h create mode 100644 sound/soc/sirf/sirf-audio.c create mode 100644 sound/soc/sirf/sirf-bt-sco.c create mode 100644 sound/soc/sirf/sirf-hdmi.c create mode 100644 sound/soc/sirf/sirf-i2s.c create mode 100644 sound/soc/sirf/sirf-i2s.h create mode 100644 sound/soc/sirf/sirf-usp.c create mode 100644 sound/soc/sirf/sirf-usp.h -- 1.7.5.4

2 8

[alsa-devel] [PATCH 00/15] ASoC: fsl-ssi: Driver cleanup
by Markus Pargmann 05 Mar '14

05 Mar '14

Hi, Here is a series of cleanups for the fsl-ssi driver. It would be great if someone with PPC hardware and this fsl-ssi unit could please test this series. I am not sure if the regmap patch works as expected on PPC as well. I tested this series on imx53 quick starter board and a custom board. Both with SSI as I2S slave. Regards, Markus Markus Pargmann (15): ASoC: fsl-ssi: Use regmap ASoC: fsl-ssi: Remove fsl_ssi_setup ASoC: fsl-ssi: Move debugging to seperate file ASoC: fsl-ssi: Use dev_name for DAI driver struct ASoC: fsl-ssi: Move imx-specific probe to seperate function ASoC: fsl-ssi: Remove useless DMA code ASoC: fsl-ssi: baud clock error handling ASoC: fsl-ssi: Cleanup probe function ASoC: fsl-ssi: Remove unnecessary variables from ssi_private ASoC: fsl-ssi: reorder and document fsl_ssi_private ASoC: fsl-ssi: Fix register values when disabling ASoC: fsl-ssi: Only enable baudclk when used ASoC: fsl-ssi: Set default dai-fmts ASoC: fsl-ssi: Transmit enable synchronization ASoC: fsl-ssi: Update binding documentation .../devicetree/bindings/sound/fsl,ssi.txt | 21 +- sound/soc/fsl/Kconfig | 1 + sound/soc/fsl/Makefile | 2 + sound/soc/fsl/fsl_ssi.c | 1167 ++++++++------------ sound/soc/fsl/fsl_ssi.h | 112 +- sound/soc/fsl/fsl_ssi_dbg.c | 163 +++ 6 files changed, 750 insertions(+), 716 deletions(-) create mode 100644 sound/soc/fsl/fsl_ssi_dbg.c -- 1.8.5.3

4 21

[alsa-devel] [PATCH 00/10] Simplify the code of TDM slot setting
by Xiubo Li 05 Mar '14

05 Mar '14

Xiubo Li (10): ASoC: core: Add snd_soc_dai_set_tdm_slot_xlate(). ASoC: fsl-utils: Add fsl_asoc_of_xlate_tdm_slot_mask() support. ASoC: fsl-esai: Add .of_xlate_tdm_slot_mask() support. ASoC: fsl-ssi: Add .of_xlate_tdm_slot_mask() support. ASoC: imx-ssi: Add .of_xlate_tdm_slot_mask() support. ASoC: simple-card: Use snd_soc_dai_set_tdm_slot_xlate() ASoC: blackfin: bf5xx-ad1836: Use snd_soc_dai_set_tdm_slot_xlate() ASoC: blackfin: bf5xx-ad193x: Use snd_soc_dai_set_tdm_slot_xlate() ASoC: fsl: eukrea-tlv320: Use snd_soc_dai_set_tdm_slot_xlate() ASoC: fsl: wm1133-ev1: Use snd_soc_dai_set_tdm_slot_xlate() include/sound/soc-dai.h | 3 +++ sound/soc/blackfin/bf5xx-ad1836.c | 2 +- sound/soc/blackfin/bf5xx-ad193x.c | 4 ++-- sound/soc/fsl/Kconfig | 3 +++ sound/soc/fsl/eukrea-tlv320.c | 2 +- sound/soc/fsl/fsl_esai.c | 2 ++ sound/soc/fsl/fsl_ssi.c | 2 ++ sound/soc/fsl/fsl_utils.c | 27 +++++++++++++++++++++++++++ sound/soc/fsl/fsl_utils.h | 4 +++- sound/soc/fsl/imx-ssi.c | 2 ++ sound/soc/fsl/wm1133-ev1.c | 11 +---------- sound/soc/generic/simple-card.c | 7 +++---- sound/soc/soc-core.c | 33 ++++++++++++++++++++++++++++----- 13 files changed, 78 insertions(+), 24 deletions(-) -- 1.8.4

4 14

[alsa-devel] [PATCH] ASoC: simple-card: tidyup cpu/codec dai_fmt settings for non-DT
by Kuninori Morimoto 05 Mar '14

05 Mar '14

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> 30d0341e7da0c012f64fb290dd1153360fb49a8d (ASoC: simple-card: simplify the daifmt code) simplify cpu/codec dai_fmt which consists from dai specific format + common format. But, it didn't care about non-DT case. This patch fixes it Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/generic/simple-card.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c index 034a2b7..7cabcc5 100644 --- a/sound/soc/generic/simple-card.c +++ b/sound/soc/generic/simple-card.c @@ -307,6 +307,9 @@ static int asoc_simple_card_probe(struct platform_device *pdev) sizeof(priv->cpu_dai)); memcpy(&priv->codec_dai, &cinfo->codec_dai, sizeof(priv->codec_dai)); + + priv->cpu_dai.fmt |= cinfo->daifmt; + priv->codec_dai.fmt |= cinfo->daifmt; } /* -- 1.7.9.5

2 1

[alsa-devel] [PATCH v4-resend 0/7] ASoC: add CSR SiRFSoC sound drivers
by RongJun Ying 05 Mar '14

05 Mar '14

From: Rongjun Ying <rongjun.ying(a)csr.com> This patchset adds CSR SiRFSoC sound drivers including: 1. The SiRF internal audio codec driver 2. The SiRF audio port driver 3. The SiRF internal audio card driver 4. The SiRF I2S controller driver 5. The SiRF hdmi card driver 6. The SiRF USP controller(DSP mode) driver 7. The SiRF bt-sco card driver -v4: 1. Use the generic dmaengine pcm codes instead of sirf pcm driver. 2. Add TLV information into internal audio codec driver. 3. Use the MMIO regmap instead of custom read and write callbacks. 4. Remove spin_lock. 5. Change some variable names. 6. The SiRF internal audio driver split into codec, port. 7. Add binding documents. Rongjun Ying (7): ASoC: sirf: Add SiRF internal audio codec driver ASoC: sirf: Add SiRF audio port driver is used by SiRF internal audio codec ASoC: sirf: Add SiRF audio card ASoC: sirf: Add SiRF I2S driver ASoC: sirf: Add hdmi card ASoC: sirf: Add usp driver which is used by dsp mode ASoC: sirf: Add bt-sco card .../devicetree/bindings/sound/sirf-audio-codec.txt | 17 + .../devicetree/bindings/sound/sirf-audio-port.txt | 20 + .../devicetree/bindings/sound/sirf-audio.txt | 41 ++ .../devicetree/bindings/sound/sirf-bt-sco.txt | 18 + .../devicetree/bindings/sound/sirf-hdmi.txt | 15 + .../devicetree/bindings/sound/sirf-i2s.txt | 27 + .../devicetree/bindings/sound/sirf-usp.txt | 27 + sound/soc/Kconfig | 1 + sound/soc/Makefile | 1 + sound/soc/codecs/Kconfig | 4 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/sirf-audio-codec.c | 585 ++++++++++++++++++++ sound/soc/codecs/sirf-audio-codec.h | 75 +++ sound/soc/sirf/Kconfig | 34 ++ sound/soc/sirf/Makefile | 13 + sound/soc/sirf/sirf-audio-port.c | 194 +++++++ sound/soc/sirf/sirf-audio-port.h | 62 ++ sound/soc/sirf/sirf-audio.c | 156 ++++++ sound/soc/sirf/sirf-bt-sco.c | 99 ++++ sound/soc/sirf/sirf-hdmi.c | 98 ++++ sound/soc/sirf/sirf-i2s.c | 438 +++++++++++++++ sound/soc/sirf/sirf-i2s.h | 88 +++ sound/soc/sirf/sirf-usp.c | 448 +++++++++++++++ sound/soc/sirf/sirf-usp.h | 282 ++++++++++ 24 files changed, 2745 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/sirf-audio-codec.txt create mode 100644 Documentation/devicetree/bindings/sound/sirf-audio-port.txt create mode 100644 Documentation/devicetree/bindings/sound/sirf-audio.txt create mode 100644 Documentation/devicetree/bindings/sound/sirf-bt-sco.txt create mode 100644 Documentation/devicetree/bindings/sound/sirf-hdmi.txt create mode 100644 Documentation/devicetree/bindings/sound/sirf-i2s.txt create mode 100644 Documentation/devicetree/bindings/sound/sirf-usp.txt create mode 100644 sound/soc/codecs/sirf-audio-codec.c create mode 100644 sound/soc/codecs/sirf-audio-codec.h create mode 100644 sound/soc/sirf/Kconfig create mode 100644 sound/soc/sirf/Makefile create mode 100644 sound/soc/sirf/sirf-audio-port.c create mode 100644 sound/soc/sirf/sirf-audio-port.h create mode 100644 sound/soc/sirf/sirf-audio.c create mode 100644 sound/soc/sirf/sirf-bt-sco.c create mode 100644 sound/soc/sirf/sirf-hdmi.c create mode 100644 sound/soc/sirf/sirf-i2s.c create mode 100644 sound/soc/sirf/sirf-i2s.h create mode 100644 sound/soc/sirf/sirf-usp.c create mode 100644 sound/soc/sirf/sirf-usp.h -- 1.7.5.4

4 18

[alsa-devel] [PATCH] ASoC: pcm: free path list before exiting from error conditions
by Patrick Lai 05 Mar '14

05 Mar '14

dpcm_path_get() allocates dynamic memory to hold path list. Corresponding dpcm_path_put() must be called to free the memory. dpcm_path_put() is not called under several error conditions. This leads to memory leak. Signed-off-by: Patrick Lai <plai(a)codeaurora.org> --- sound/soc/soc-pcm.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index 47e1ce7..28522bd 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -1989,6 +1989,7 @@ int soc_dpcm_runtime_update(struct snd_soc_card *card) paths = dpcm_path_get(fe, SNDRV_PCM_STREAM_PLAYBACK, &list); if (paths < 0) { + dpcm_path_put(&list); dev_warn(fe->dev, "ASoC: %s no valid %s path\n", fe->dai_link->name, "playback"); mutex_unlock(&card->mutex); @@ -2018,6 +2019,7 @@ capture: paths = dpcm_path_get(fe, SNDRV_PCM_STREAM_CAPTURE, &list); if (paths < 0) { + dpcm_path_put(&list); dev_warn(fe->dev, "ASoC: %s no valid %s path\n", fe->dai_link->name, "capture"); mutex_unlock(&card->mutex); @@ -2082,6 +2084,7 @@ static int dpcm_fe_dai_open(struct snd_pcm_substream *fe_substream) fe->dpcm[stream].runtime = fe_substream->runtime; if (dpcm_path_get(fe, stream, &list) <= 0) { + dpcm_path_put(&list); dev_dbg(fe->dev, "ASoC: %s no valid %s route\n", fe->dai_link->name, stream ? "capture" : "playback"); } -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation

2 1