January 2014 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [RFC PATCH] ALSA: hda - Detect codecs on Intel DZ77SL-50K
by David Henningsson 22 Jan '14

22 Jan '14

From: Niraj <kulkarniniraj(a)rediffmail.com> Apparently this board seems to need some extra initialization before a proper codec probe value can be read. BugLink: https://bugs.launchpad.net/bugs/1155202 Signed-off-by: David Henningsson <david.henningsson(a)canonical.com> --- sound/pci/hda/hda_intel.c | 6 ++++++ 1 file changed, 6 insertions(+) Hi Takashi, Here's a patch from Niraj, which has found this code below to make audio work on the Intel DZ77SL-50K board. Without it, no codecs will be detected. I'm not sure if you like it this way or if you want me or Niraj to change anything, or debug further. Or maybe add a new quirk for this particular device? diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index fa2879a..2bf46e9 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1306,6 +1306,12 @@ static void azx_init_chip(struct azx *chip, int full_reset) /* reset controller */ azx_reset(chip, full_reset); + if (!chip->codec_mask) { + azx_writel(chip, GCTL, 0x100); + while(azx_readl(chip, GCTL) != 0x0); + azx_writel(chip, GCTL, 0x1); + azx_reset(chip, full_reset); + } /* initialize interrupts */ azx_int_clear(chip); -- 1.7.9.5

2 3

[alsa-devel] [PATCH v2] ASoC: wm_adsp: Add debug print to note that the DSP has shutdown
by Charles Keepax 22 Jan '14

22 Jan '14

It can be useful for debugging purposes to see at what point the DSP has powered down, so add a message to inform us of this. Signed-off-by: Charles Keepax <ckeepax(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/wm_adsp.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c index 4fbcab6..90d7baf 100644 --- a/sound/soc/codecs/wm_adsp.c +++ b/sound/soc/codecs/wm_adsp.c @@ -1637,6 +1637,8 @@ int wm_adsp2_event(struct snd_soc_dapm_widget *w, list_del(&alg_region->list); kfree(alg_region); } + + adsp_dbg(dsp, "Shutdown complete\n"); break; default: -- 1.7.2.5

2 1

[alsa-devel] [PATCH 0/7] ASoC: Samsung: Fix build errors and warnings
by Sachin Kamat 22 Jan '14

22 Jan '14

This series attempts to fix several build errors and warnings that came up while building for deifferent Samsung defconfigs. Some of these could possibly be applied to stable kernels as well (like patch 2 & 6). This series is based on latest linux-next and is build tested on various Samsung configs. Sachin Kamat (7): ASoC: Samsung: Fix build regressions due to gpio re-org ASoC: Samsung: s3c-i2s-v2: Fix build error ASoC: Samsung: h1940_uda1380: Remove unused variable ASoC: Samsung: h1940_uda1380: Fix build warning ASoC: Samsung: rx1950_uda1380: Remove unused variable ASoC: Samsung: smdk_wm8994: Fix build error ASoC: Samsung: smdk_wm8994: Fix unused variable warning sound/soc/samsung/h1940_uda1380.c | 4 ++-- sound/soc/samsung/neo1973_wm8753.c | 1 + sound/soc/samsung/rx1950_uda1380.c | 2 +- sound/soc/samsung/s3c-i2s-v2.c | 6 +++--- sound/soc/samsung/s3c2412-i2s.c | 2 ++ sound/soc/samsung/s3c24xx-i2s.c | 2 ++ sound/soc/samsung/smartq_wm8987.c | 1 + sound/soc/samsung/smdk_wm8994.c | 12 ++++++------ 8 files changed, 18 insertions(+), 12 deletions(-) -- 1.7.9.5

4 12

[alsa-devel] [PATCH] ASoC: wm8804: Allow control of master clock divider in PLL generation
by Daniel Matuschek 22 Jan '14

22 Jan '14

WM8804 can run with PLL frequencies of 256xfs and 128xfs for most sample rates. At 192kHz only 128xfs is supported. The existing driver selects 128xfs automatically for some lower samples rates. By using an additional mclk_div divider, it is now possible to control the behaviour. This allows using 256xfs PLL frequency on all sample rates up to 96kHz. It should allow lower jitter and better signal quality. The behavior has to be controlled by the sound card driver, because some sample frequency share the same setting. e.g. 192kHz and 96kHz use 24.576MHz master clock. The only difference is the MCLK divider. Signed-off-by: Daniel Matuschek <daniel(a)matuschek.net> --- sound/soc/codecs/wm8804.c | 17 ++++++++++++++--- sound/soc/codecs/wm8804.h | 4 ++++ 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/wm8804.c b/sound/soc/codecs/wm8804.c index 1704b1e..4619bf8 100644 --- a/sound/soc/codecs/wm8804.c +++ b/sound/soc/codecs/wm8804.c @@ -63,6 +63,7 @@ struct wm8804_priv { struct regmap *regmap; struct regulator_bulk_data supplies[WM8804_NUM_SUPPLIES]; struct notifier_block disable_nb[WM8804_NUM_SUPPLIES]; + int mclk_div; }; static int txsrc_get(struct snd_kcontrol *kcontrol, @@ -318,7 +319,7 @@ static struct { #define FIXED_PLL_SIZE ((1ULL << 22) * 10) static int pll_factors(struct pll_div *pll_div, unsigned int target, - unsigned int source) + unsigned int source, unsigned int mclk_div) { u64 Kpart; unsigned long int K, Ndiv, Nmod, tmp; @@ -330,7 +331,8 @@ static int pll_factors(struct pll_div *pll_div, unsigned int target, */ for (i = 0; i < ARRAY_SIZE(post_table); i++) { tmp = target * post_table[i].div; - if (tmp >= 90000000 && tmp <= 100000000) { + if ((tmp >= 90000000 && tmp <= 100000000) && + (mclk_div == post_table[i].mclkdiv)) { pll_div->freqmode = post_table[i].freqmode; pll_div->mclkdiv = post_table[i].mclkdiv; target *= post_table[i].div; @@ -387,8 +389,12 @@ static int wm8804_set_pll(struct snd_soc_dai *dai, int pll_id, } else { int ret; struct pll_div pll_div; + struct wm8804_priv *wm8804; - ret = pll_factors(&pll_div, freq_out, freq_in); + wm8804 = snd_soc_codec_get_drvdata(codec); + + ret = pll_factors(&pll_div, freq_out, freq_in, + wm8804->mclk_div); if (ret) return ret; @@ -452,6 +458,7 @@ static int wm8804_set_clkdiv(struct snd_soc_dai *dai, int div_id, int div) { struct snd_soc_codec *codec; + struct wm8804_priv *wm8804; codec = dai->codec; switch (div_id) { @@ -459,6 +466,10 @@ static int wm8804_set_clkdiv(struct snd_soc_dai *dai, snd_soc_update_bits(codec, WM8804_PLL5, 0x30, (div & 0x3) << 4); break; + case WM8804_MCLK_DIV: + wm8804 = snd_soc_codec_get_drvdata(codec); + wm8804->mclk_div = div; + break; default: dev_err(dai->dev, "Unknown clock divider: %d\n", div_id); return -EINVAL; diff --git a/sound/soc/codecs/wm8804.h b/sound/soc/codecs/wm8804.h index 8ec14f5..e72d4f4 100644 --- a/sound/soc/codecs/wm8804.h +++ b/sound/soc/codecs/wm8804.h @@ -57,5 +57,9 @@ #define WM8804_CLKOUT_SRC_OSCCLK 4 #define WM8804_CLKOUT_DIV 1 +#define WM8804_MCLK_DIV 2 + +#define WM8804_MCLKDIV_256FS 0 +#define WM8804_MCLKDIV_128FS 1 #endif /* _WM8804_H */ -- 1.7.9.5

6 9

[alsa-devel] Got headphone out working via hda-verb setting on MacPro1, 1
by Nicolai Beuermann 22 Jan '14

22 Jan '14

Hello, hda-analyzer told me to write a note to this list when settings are successful. My setup: MacPro 1,1 Kernel 3.10.17 (gentoo sources) ALSA k3.10.17 Had to set /usr/bin/hda-verb /dev/snd/hwC0D0 0x18 SET_PIN_WIDGET_CONTROL 0xc1 to get the headphone out at the front working. Wrote a bit (in german) about it: http://www.nico-beuermann.de/blogging/archives/117-Hier-gibt-es-was-auf-die… regards Nicolai Beuermann -- mailto: mail(a)nico-beuermann.de online: http://www.nico-beuermann.de GnuPG Fingerabdruck: 56DA 4E32 3A4A 52AC B769 DFC2 BF3E 9805 09BB 4259

2 1

[alsa-devel] [PATCH v2 0/4] ASoC: tlv320aic32x4: DT support
by Markus Pargmann 22 Jan '14

22 Jan '14

Hi, The series adds basic DT support for the TI tlv320aic32x4 codec. v2 adds a new patch to support regulators. The codec now decides on the given regulators if LDO for AVDD should be enabled. 'ti,ldo-enable' was removed. Regards, Markus Changes in v2: - Regulator support - Fix documentation for gpio property Markus Pargmann (4): ASoC: tlv320aic32x4: Use signed int mixer controls ASoC: tlv320aic32x4: DT support ASoC: tlv320aic32x4: Support for master clock ASoC: tlv320aic32x4: Support for regulators .../devicetree/bindings/sound/tlv320aic32x4.txt | 28 +++++ sound/soc/codecs/tlv320aic32x4.c | 126 +++++++++++++++++++-- 2 files changed, 144 insertions(+), 10 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/tlv320aic32x4.txt -- 1.8.5.2

3 8

[alsa-devel] [PATCH] ALSA: cs46xx: Fix memory leak at destructor
by Takashi Iwai 22 Jan '14

22 Jan '14

The release of module object itself was forgotten. Spotted by COVERIY CID 1162828. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/cs46xx/cs46xx_lib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/cs46xx/cs46xx_lib.c b/sound/pci/cs46xx/cs46xx_lib.c index f18e5878f58b..062398ec5335 100644 --- a/sound/pci/cs46xx/cs46xx_lib.c +++ b/sound/pci/cs46xx/cs46xx_lib.c @@ -369,6 +369,7 @@ static void free_module_desc(struct dsp_module_desc *module) kfree(module->segments[i].data); kfree(module->segments); } + kfree(module); } /* firmware binary format: -- 1.8.5.2

1 0

[alsa-devel] [PATCH] alsa-utils: fix timespec to msec conversion
by Olivier Langlois 22 Jan '14

22 Jan '14

There is 1M nsec in a msec. Signed-off-by: Olivier Langlois <olivier(a)trillion01.com> --- aplay/aplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aplay/aplay.c b/aplay/aplay.c index 69e8bda..33a8ed5 100644 --- a/aplay/aplay.c +++ b/aplay/aplay.c @@ -1509,7 +1509,7 @@ static void xrun(void) timermsub(&now, &tstamp, &diff); fprintf(stderr, _("%s!!! (at least %.3f ms long)\n"), stream == SND_PCM_STREAM_PLAYBACK ? _("underrun") : _("overrun"), - diff.tv_sec * 1000 + diff.tv_nsec / 10000000.0); + diff.tv_sec * 1000 + diff.tv_nsec / 1000000.0); #else fprintf(stderr, "%s !!!\n", _("underrun")); #endif -- 1.8.5.3

2 1

[alsa-devel] [PATCH - my module 1/1] control_hw: fix potential memory leak
by vanyacpp＠gmail.com 22 Jan '14

22 Jan '14

From: Ivan Sorokin <vanyacpp(a)gmail.com> Signed-off-by: Ivan Sorokin <vanyacpp(a)gmail.com> diff --git a/src/control/control_hw.c b/src/control/control_hw.c index 148097f..dfc9dcd 100644 --- a/src/control/control_hw.c +++ b/src/control/control_hw.c @@ -240,8 +240,10 @@ static int snd_ctl_hw_elem_tlv(snd_ctl_t *handle, int op_flag, return -errno; } if (op_flag == 0) { - if (xtlv->tlv[1] + 2 * sizeof(unsigned int) > tlv_size) + if (xtlv->tlv[1] + 2 * sizeof(unsigned int) > tlv_size) { + free(xtlv); return -EFAULT; + } memcpy(tlv, xtlv->tlv, xtlv->tlv[1] + 2 * sizeof(unsigned int)); } free(xtlv); -- 1.8.1.2

2 1

[alsa-devel] [ISSUE] crackles and clicks
by Eric F 22 Jan '14

22 Jan '14

Hello, I tried my DAC (Tenor TE8802 chipset) in USB on Archlinux (LTS 3.10.26). I can hear regularly crackles ans clicks. I've tried all available USB ports, other kernels (3.12.6, 3.12.7), other distro (ubuntu), without luck... The DAC is Teac UD-H01. here is lsusb verbose : http://ix.io/9Q4 Feel free to ask for more precisions, I'll give you all you need. I thank you very much. Eric

4 6