July 2013 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] Question about WM8904 regcache
by Bo Shen 12 Jul '13

12 Jul '13

Hi Mark, I am sorry to disturb you. On our EK board, it use wm8904 codec. When I enable the audio, and use alsa utils aplay to test, I meet the following issue. The audio can not playback, it show the following error. ---8>--- #aplay 44.1k_16bit_stereo.wav Playing WAVE '44.1k_16bit_stereo.wav' : Signed 16 bit Little Endian, Rate 44100 Hz, Stereo aplay: pcm_write:1737: write error: Input/output error ---<8--- After check the register, they are not be configured correctly. When read from debug file system, found the cache_dirty always Y before playback and also failed playback. I try to add the following two line in wm8904_set_bias_level into "case SND_SOC_BIAS_ON", it doesn't work. ---8>--- @@ -1832,9 +1834,12 @@ static int wm8904_set_bias_level(struct snd_soc_codec *codec, switch (level) { case SND_SOC_BIAS_ON: + regcache_cache_only(wm8904->regmap, false); + regcache_sync(wm8904->regmap); break; ---<8--- However, If I comment the regcache_cache_only(wm8904->regmap, true) as following, then it play OK. ---8>--- @@ -2232,7 +2239,7 @@ static int wm8904_i2c_probe(struct i2c_client *i2c, WM8904_POBCTRL, 0); /* Can leave the device powered off until we need it */ - regcache_cache_only(wm8904->regmap, true); + // regcache_cache_only(wm8904->regmap, true); ---<8--- So, any clue for this issue? Thanks. Best Regards, Bo Shen

2 3

[alsa-devel] [PATCH] ASoC: wm8978: enable symmetric rates
by Kuninori Morimoto 12 Jul '13

12 Jul '13

wm8978 needs .symmetric_rates = 1. The playback/capture will be strange without this patch when it used asymmetric rate in same time Tested-by: Yusuke Goda <yusuke.goda.sx(a)renesas.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/codecs/wm8978.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/wm8978.c b/sound/soc/codecs/wm8978.c index 029f31c..d8fc531 100644 --- a/sound/soc/codecs/wm8978.c +++ b/sound/soc/codecs/wm8978.c @@ -921,6 +921,7 @@ static struct snd_soc_dai_driver wm8978_dai = { .formats = WM8978_FORMATS, }, .ops = &wm8978_dai_ops, + .symmetric_rates = 1, }; static int wm8978_suspend(struct snd_soc_codec *codec) -- 1.7.9.5

2 1

[alsa-devel] [PATCH 0/5] ASoC: add simple-card DT support
by Kuninori Morimoto 12 Jul '13

12 Jul '13

Hi Mark, Simon These patches add DT support on simple-card driver. #1 patch adds new snd_soc_of_parse_daifmt() function on soc-core.c and #5 patch will use it. #2 - #5 patches are based on mark/topic/fsi branch >> Simon #2, #3 patches modify sh-arm platform settings. please check it Kuninori Morimoto (5): ASoC: add snd_soc_of_parse_daifmt() ASoC: simple-card: use struct device pointer for dev_xxx() ASoC: simple-card: add asoc_simple_dai_set for initializing ASoC: simple-card: remove pointless struct asoc_simple_dai_init_info ASoC: simple-card: add Device Tree support .../devicetree/bindings/sound/simple-card.txt | 53 ++++++++ arch/arm/mach-shmobile/board-ap4evb.c | 19 +-- arch/arm/mach-shmobile/board-armadillo800eva.c | 18 +-- arch/arm/mach-shmobile/board-kzm9g.c | 12 +- arch/arm/mach-shmobile/board-mackerel.c | 19 +-- arch/sh/boards/mach-ecovec24/setup.c | 11 +- arch/sh/boards/mach-se/7724/setup.c | 13 +- include/sound/simple_card.h | 11 +- include/sound/soc.h | 2 + sound/soc/generic/simple-card.c | 132 ++++++++++++++++---- sound/soc/soc-core.c | 115 +++++++++++++++++ 11 files changed, 307 insertions(+), 98 deletions(-) Best regards --- Kuninori Morimoto

6 110

[alsa-devel] [PATCH v2 0/4] ASoC: Regression fix for OMAP in DT boot (3.11)
by Peter Ujfalusi 11 Jul '13

11 Jul '13

Hi, Changes since v1: - Drop the change in dmaengine_pcm.h - Use .filter_data to store the DMA channel name - omap-pcm: checks if the DAI is probed via DT and uses decides which method to use to request the DMA channel - Dropped the cleanup patch for omap-dmic from the series I will send another series with cleanups later I just noticed in mainline kernel (pre 3.11-rc1) that OMAP4 audio is not probing anymore. This is because OMAP4 also moved to DT only mode (3.10 DT boot was fine). The issue underneath is that we can not use platform_get_resource_byname() for DMA resources when booted with devicetree. In case of DT boot we can use the DMA name to request the channel. Due to technical issues OMAP can not be moved to generic dmaengine pcm as other SoCs did. Mark: can you queue this series for 3.11? Thank you. Regards, Peter --- Peter Ujfalusi (4): ASoC: omap-pcm: Request the DMA channel differently when DT is involved ASoC: omap-mcpdm: Do not use platform_get_resource_byname() for DMA ASoC: omap-dmic: Do not use platform_get_resource_byname() for DMA ASoC: omap-mcbsp: Use different method for DMA request when booted with DT sound/soc/omap/mcbsp.c | 39 ++++++++++++++++++++++----------------- sound/soc/omap/omap-dmic.c | 11 +---------- sound/soc/omap/omap-mcpdm.c | 16 ++-------------- sound/soc/omap/omap-pcm.c | 17 ++++++++++++++--- 4 files changed, 39 insertions(+), 44 deletions(-) -- 1.8.2.1

3 8

[alsa-devel] [PATCH 1/1] ASoC: Samsung: Fix a trivial typo in audss documentation
by Sachin Kamat 11 Jul '13

11 Jul '13

Fixed a trivial typo. Signed-off-by: Sachin Kamat <sachin.kamat(a)linaro.org> --- .../devicetree/bindings/clock/clk-exynos-audss.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/clock/clk-exynos-audss.txt b/Documentation/devicetree/bindings/clock/clk-exynos-audss.txt index a120180..75e2e19 100644 --- a/Documentation/devicetree/bindings/clock/clk-exynos-audss.txt +++ b/Documentation/devicetree/bindings/clock/clk-exynos-audss.txt @@ -2,7 +2,7 @@ The Samsung Audio Subsystem clock controller generates and supplies clocks to Audio Subsystem block available in the S5PV210 and Exynos SoCs. The clock -binding described here is applicable to all SoC's in Exynos family. +binding described here is applicable to all SoCs in Exynos family. Required Properties: -- 1.7.9.5

2 2

Re: [alsa-devel] [PATCH 45/50] sound: usb: usx2y: spin_lock in complete() cleanup
by Takashi Iwai 11 Jul '13

11 Jul '13

At Thu, 11 Jul 2013 22:13:35 +0800, Ming Lei wrote: > > On Thu, Jul 11, 2013 at 9:50 PM, Takashi Iwai <tiwai(a)suse.de> wrote: > > At Thu, 11 Jul 2013 17:08:30 +0400, > > Sergei Shtylyov wrote: > >> > >> On 11-07-2013 13:06, Ming Lei wrote: > >> > >> > Complete() will be run with interrupt enabled, so change to > >> > spin_lock_irqsave(). > >> > >> Changelog doesn't match the patch. > > > > Yep, but moreover... > > > >> > Cc: Jaroslav Kysela <perex(a)perex.cz> > >> > Cc: Takashi Iwai <tiwai(a)suse.de> > >> > Cc: alsa-devel(a)alsa-project.org > >> > Signed-off-by: Ming Lei <ming.lei(a)canonical.com> > >> > --- > >> > sound/usb/usx2y/usbusx2yaudio.c | 4 ++++ > >> > 1 file changed, 4 insertions(+) > >> > >> > diff --git a/sound/usb/usx2y/usbusx2yaudio.c b/sound/usb/usx2y/usbusx2yaudio.c > >> > index 4967fe9..e2ee893 100644 > >> > --- a/sound/usb/usx2y/usbusx2yaudio.c > >> > +++ b/sound/usb/usx2y/usbusx2yaudio.c > >> > @@ -273,7 +273,11 @@ static void usX2Y_clients_stop(struct usX2Ydev *usX2Y) > >> > struct snd_usX2Y_substream *subs = usX2Y->subs[s]; > >> > if (subs) { > >> > if (atomic_read(&subs->state) >= state_PRERUNNING) { > >> > + unsigned long flags; > >> > + > >> > + local_irq_save(flags); > >> > snd_pcm_stop(subs->pcm_substream, SNDRV_PCM_STATE_XRUN); > >> > + local_irq_restore(flags); > >> > } > > > > ... actually this snd_pcm_stop() call should have been covered by > > snd_pcm_stream_lock(). Maybe it'd be enough to have a single patch > > together with the change, i.e. wrapping with > > snd_pcm_stream_lock_irqsave(). > > Please use snd_pcm_stream_lock_irqsave() so that I can avoid sending > out similar patch later, :-) > > > > > I'll prepare the patch for 3.11 independently from your patch series, > > so please drop this one. > > OK, thanks for dealing with that. > > > > > > > BTW, the word "cleanup" in the subject is inappropriate. This is > > rather a fix together with the core change. > > It is a cleanup since the patchset only addresses lock problem which > is caused by the tasklet conversion. Well, the conversion to irqsave() is needed for the future drop of irq_save() in the caller, right? Then this isn't a cleanup but a preparation for movement ahead. > > And, I wonder whether we can take a safer approach. When the caller > > condition changed, we often introduced either a different ops > > (e.g. ioctl case) or a flag for the new condition, at least during the > > transition period. > > Interrupt is't enabled until all current drivers are cleaned up, so it is really > safe, please see patch [2]. OK. > > Last but not least, is a conversion to tasklet really preferred? > > tasklet is rather an obsoleted infrastructure nowadays, and people > > don't recommend to use it any longer, AFAIK. > > We discussed the problem in the below link previously[1], Steven > and Thomas suggested to use threaded irq handler, but which > may degrade USB mass storage performance, so we have to > take tasklet now until we rewrite transport part of USB mass storage > driver. > > Also the conversion[2] has avoided the tasklet spin lock problem > already. OK, good to know. thanks, Takashi > [1], http://marc.info/?t=137079119200001&r=1&w=2 > [2], http://marc.info/?l=linux-usb&m=137286326726326&w=2 > > Thanks, > -- > Ming Lei >

1 0

Re: [alsa-devel] [PATCH 44/50] sound: usb: caiaq: spin_lock in complete() cleanup
by Daniel Mack 11 Jul '13

11 Jul '13

On 11.07.2013 11:06, Ming Lei wrote: > Complete() will be run with interrupt enabled, so change to > spin_lock_irqsave(). > > Cc: Daniel Mack <zonque(a)gmail.com> > Cc: Jaroslav Kysela <perex(a)perex.cz> > Cc: Takashi Iwai <tiwai(a)suse.de> > Cc: alsa-devel(a)alsa-project.org > Signed-off-by: Ming Lei <ming.lei(a)canonical.com> Sound right to me, thanks. Acked-by: Daniel Mack <zonque(a)gmail.com> > --- > sound/usb/caiaq/audio.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/sound/usb/caiaq/audio.c b/sound/usb/caiaq/audio.c > index 7103b09..e5675ab 100644 > --- a/sound/usb/caiaq/audio.c > +++ b/sound/usb/caiaq/audio.c > @@ -672,10 +672,11 @@ static void read_completed(struct urb *urb) > offset += len; > > if (len > 0) { > - spin_lock(&cdev->spinlock); > + unsigned long flags; > + spin_lock_irqsave(&cdev->spinlock, flags); > fill_out_urb(cdev, out, &out->iso_frame_desc[outframe]); > read_in_urb(cdev, urb, &urb->iso_frame_desc[frame]); > - spin_unlock(&cdev->spinlock); > + spin_unlock_irqrestore(&cdev->spinlock, flags); > check_for_elapsed_periods(cdev, cdev->sub_playback); > check_for_elapsed_periods(cdev, cdev->sub_capture); > send_it = 1; >

1 0

Re: [alsa-devel] [PATCH 45/50] sound: usb: usx2y: spin_lock in complete() cleanup
by Takashi Iwai 11 Jul '13

11 Jul '13

At Thu, 11 Jul 2013 17:08:30 +0400, Sergei Shtylyov wrote: > > On 11-07-2013 13:06, Ming Lei wrote: > > > Complete() will be run with interrupt enabled, so change to > > spin_lock_irqsave(). > > Changelog doesn't match the patch. Yep, but moreover... > > Cc: Jaroslav Kysela <perex(a)perex.cz> > > Cc: Takashi Iwai <tiwai(a)suse.de> > > Cc: alsa-devel(a)alsa-project.org > > Signed-off-by: Ming Lei <ming.lei(a)canonical.com> > > --- > > sound/usb/usx2y/usbusx2yaudio.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > diff --git a/sound/usb/usx2y/usbusx2yaudio.c b/sound/usb/usx2y/usbusx2yaudio.c > > index 4967fe9..e2ee893 100644 > > --- a/sound/usb/usx2y/usbusx2yaudio.c > > +++ b/sound/usb/usx2y/usbusx2yaudio.c > > @@ -273,7 +273,11 @@ static void usX2Y_clients_stop(struct usX2Ydev *usX2Y) > > struct snd_usX2Y_substream *subs = usX2Y->subs[s]; > > if (subs) { > > if (atomic_read(&subs->state) >= state_PRERUNNING) { > > + unsigned long flags; > > + > > + local_irq_save(flags); > > snd_pcm_stop(subs->pcm_substream, SNDRV_PCM_STATE_XRUN); > > + local_irq_restore(flags); > > } ... actually this snd_pcm_stop() call should have been covered by snd_pcm_stream_lock(). Maybe it'd be enough to have a single patch together with the change, i.e. wrapping with snd_pcm_stream_lock_irqsave(). I'll prepare the patch for 3.11 independently from your patch series, so please drop this one. BTW, the word "cleanup" in the subject is inappropriate. This is rather a fix together with the core change. And, I wonder whether we can take a safer approach. When the caller condition changed, we often introduced either a different ops (e.g. ioctl case) or a flag for the new condition, at least during the transition period. Last but not least, is a conversion to tasklet really preferred? tasklet is rather an obsoleted infrastructure nowadays, and people don't recommend to use it any longer, AFAIK. thanks, Takashi

1 0

Re: [alsa-devel] [PATCH 36/50] media: usb: em28xx: spin_lock in complete() cleanup
by Devin Heitmueller 11 Jul '13

11 Jul '13

On Thu, Jul 11, 2013 at 5:05 AM, Ming Lei <ming.lei(a)canonical.com> wrote: > Complete() will be run with interrupt enabled, so change to > spin_lock_irqsave(). > > Cc: Mauro Carvalho Chehab <mchehab(a)redhat.com> > Cc: linux-media(a)vger.kernel.org > Signed-off-by: Ming Lei <ming.lei(a)canonical.com> > --- > drivers/media/usb/em28xx/em28xx-core.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/usb/em28xx/em28xx-core.c b/drivers/media/usb/em28xx/em28xx-core.c > index fc157af..0d698f9 100644 > --- a/drivers/media/usb/em28xx/em28xx-core.c > +++ b/drivers/media/usb/em28xx/em28xx-core.c > @@ -941,6 +941,7 @@ static void em28xx_irq_callback(struct urb *urb) > { > struct em28xx *dev = urb->context; > int i; > + unsigned long flags; > > switch (urb->status) { > case 0: /* success */ > @@ -956,9 +957,9 @@ static void em28xx_irq_callback(struct urb *urb) > } > > /* Copy data from URB */ > - spin_lock(&dev->slock); > + spin_lock_irqsave(&dev->slock, flags); > dev->usb_ctl.urb_data_copy(dev, urb); > - spin_unlock(&dev->slock); > + spin_unlock_irqrestore(&dev->slock, flags); > > /* Reset urb buffers */ > for (i = 0; i < urb->number_of_packets; i++) { > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html I actually stumbled across this a couple of weeks ago, and have had an identical patch running in a local dev tree. Reviewed-by: Devin Heitmueller <dheitmueller(a)kernellabs.com> Tested-by: Devin Heitmueller <dheitmueller(a)kernellabs.com> -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com

1 0

[alsa-devel] [PATCH 0/6] ASoC: Regression fix for OMAP in DT boot (3.11)
by Peter Ujfalusi 11 Jul '13

11 Jul '13

Hi, I just noticed in mainline kernel (pre 3.11-rc1) that OMAP4 audio is not probing anymore. This is because OMAP4 also moved to DT only mode (3.10 DT boot was fine). The issue underneath is that we can not use platform_get_resource_byname() for DMA resources when booted with devicetree. In case of DT boot we can use the DMA name to request the channel. Due to technical issues OMAP can not be moved to generic dmaengine pcm as other SoCs did. Mark: can you queue this series for 3.11? Thank you. Regards, Peter --- Peter Ujfalusi (6): ASoC: dmaengine_pcm: Add dma_name to snd_dmaengine_dai_dma_data ASoC: omap-pcm: Request the DMA channel by name when dma_name is set for the dai ASoC: omap-mcpdm: Do not use platform_get_resource_byname() for DMA ASoC: omap-dmic: Do not use platform_get_resource_byname() for DMA ASoC: omap-mcbsp: Use different method for DMA request when booted with DT ASoC: omap-dmic: Cleanup the probe function include/sound/dmaengine_pcm.h | 1 + sound/soc/omap/mcbsp.c | 39 ++++++++++++++++++++++----------------- sound/soc/omap/omap-dmic.c | 35 ++++++++++------------------------- sound/soc/omap/omap-mcpdm.c | 16 ++-------------- sound/soc/omap/omap-pcm.c | 16 +++++++++++++--- 5 files changed, 48 insertions(+), 59 deletions(-) -- 1.8.2.1

2 10