July 2013 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 1/2] ASoC: fsl: fsl_ssi: Use devm_ functions
by Fabio Estevam 17 Jul '13

17 Jul '13

From: Fabio Estevam <fabio.estevam(a)freescale.com> Using devm_ functions can make the code cleaner and smaller. Signed-off-by: Fabio Estevam <fabio.estevam(a)freescale.com> --- sound/soc/fsl/fsl_ssi.c | 38 ++++++++++---------------------------- 1 file changed, 10 insertions(+), 28 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 2f2d837..ab8d462 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -680,7 +680,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) /* The DAI name is the last part of the full name of the node. */ p = strrchr(np->full_name, '/') + 1; - ssi_private = kzalloc(sizeof(struct fsl_ssi_private) + strlen(p), + ssi_private = devm_kzalloc(&pdev->dev, sizeof(*ssi_private) + strlen(p), GFP_KERNEL); if (!ssi_private) { dev_err(&pdev->dev, "could not allocate DAI object\n"); @@ -698,26 +698,24 @@ static int fsl_ssi_probe(struct platform_device *pdev) ret = of_address_to_resource(np, 0, &res); if (ret) { dev_err(&pdev->dev, "could not determine device resources\n"); - goto error_kmalloc; + return ret; } ssi_private->ssi = of_iomap(np, 0); if (!ssi_private->ssi) { dev_err(&pdev->dev, "could not map device resources\n"); - ret = -ENOMEM; - goto error_kmalloc; + return -ENOMEM; } ssi_private->ssi_phys = res.start; ssi_private->irq = irq_of_parse_and_map(np, 0); if (ssi_private->irq == NO_IRQ) { dev_err(&pdev->dev, "no irq for node %s\n", np->full_name); - ret = -ENXIO; - goto error_iomap; + return -ENXIO; } /* The 'name' should not have any slashes in it. */ - ret = request_irq(ssi_private->irq, fsl_ssi_isr, 0, ssi_private->name, - ssi_private); + ret = devm_request_irq(&pdev->dev, ssi_private->irq, fsl_ssi_isr, 0, + ssi_private->name, ssi_private); if (ret < 0) { dev_err(&pdev->dev, "could not claim irq %u\n", ssi_private->irq); goto error_irqmap; @@ -739,11 +737,11 @@ static int fsl_ssi_probe(struct platform_device *pdev) u32 dma_events[2]; ssi_private->ssi_on_imx = true; - ssi_private->clk = clk_get(&pdev->dev, NULL); + ssi_private->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(ssi_private->clk)) { ret = PTR_ERR(ssi_private->clk); dev_err(&pdev->dev, "could not get clock: %d\n", ret); - goto error_irq; + goto error_irqmap; } clk_prepare_enable(ssi_private->clk); @@ -794,7 +792,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) if (ret) { dev_err(&pdev->dev, "could not create sysfs %s file\n", ssi_private->dev_attr.attr.name); - goto error_irq; + goto error_clk; } /* Register with ASoC */ @@ -857,23 +855,12 @@ error_dev: device_remove_file(&pdev->dev, dev_attr); error_clk: - if (ssi_private->ssi_on_imx) { + if (ssi_private->ssi_on_imx) clk_disable_unprepare(ssi_private->clk); - clk_put(ssi_private->clk); - } - -error_irq: - free_irq(ssi_private->irq, ssi_private); error_irqmap: irq_dispose_mapping(ssi_private->irq); -error_iomap: - iounmap(ssi_private->ssi); - -error_kmalloc: - kfree(ssi_private); - return ret; } @@ -886,15 +873,10 @@ static int fsl_ssi_remove(struct platform_device *pdev) if (ssi_private->ssi_on_imx) { imx_pcm_dma_exit(pdev); clk_disable_unprepare(ssi_private->clk); - clk_put(ssi_private->clk); } snd_soc_unregister_component(&pdev->dev); device_remove_file(&pdev->dev, &ssi_private->dev_attr); - - free_irq(ssi_private->irq, ssi_private); irq_dispose_mapping(ssi_private->irq); - - kfree(ssi_private); dev_set_drvdata(&pdev->dev, NULL); return 0; -- 1.8.1.2

2 2

[alsa-devel] Connecting two Codecs to the same CPU DAI
by Daniel Mack 17 Jul '13

17 Jul '13

Hi Mark, Liam, I'm trying to find a sane solution for systems that have multiple Codecs connected to the same CPU DAI. An example would be a codec that receives the same I2S stream as a S/PDIF transceiver, and which is in fact connected to the very same bus in hardware. Currently, I'm setting up two DAI links in such cases, and userspace has to open both subdevices and issue hw_params calls to each of them in order to set up the hardware correctly. This is cumbersome of course, and I wonder how the core could be augmented in order to handle such cases correctly. Ideally, it should only expose one PCM interface and handle a list of Codecs in the back. Or am I unaware of an existing feature? Thanks, Daniel

2 7

[alsa-devel] [BUG] 3.10.[01] modprobe snd-... hangs
by Philipp Matthias Hahn 17 Jul '13

17 Jul '13

Hello, My x86_64 systems has some trouble loading some ALSA snd-* modules since the upgrade to 3.10.[01]: Several automatic modprobe calls hang, but loading snd-intel-hda and snd-audio-usb by hand still works. # ps axf 460 ? S 0:00 \_ [kworker/u8:3] 1087 ? S 0:00 | \_ [kworker/u8:3] 1092 ? S 0:00 | \_ /sbin/modprobe -q -- snd-seq-client-14 ... 1071 ? S 0:00 sh -c /sbin/modprobe --ignore-install snd && { /sbin/modprobe --quiet snd 1080 ? D 0:00 \_ /sbin/modprobe --quiet snd-seq 1115 ? S 0:00 sh -c /sbin/modprobe --ignore-install snd-rawmidi && { /sbin/modprobe --q 1154 ? S 0:00 \_ /sbin/modprobe --quiet snd-seq-midi 1119 ? S 0:00 sh -c /sbin/modprobe --ignore-install snd-rawmidi && { /sbin/modprobe --q 1148 ? S 0:00 \_ /sbin/modprobe --quiet snd-seq-midi In /var/log/daemon.log I find the following messages: Jul 15 19:58:44 scout udevd[912]: timeout: killing '/sbin/modprobe -b usb:vFC08p0101d0250dc00dsc00dp00ic01isc01ip00in00' [1044] Jul 15 19:58:56 scout udevd[912]: '/sbin/modprobe -b usb:vFC08p0101d0250dc00dsc00dp00ic01isc01ip00in00' [1044] terminated by signal 9 (Killed) Jul 15 19:58:56 scout udevd[919]: timeout: killing '/sbin/modprobe -b pci:v000010DEd0000026Csv00001462sd00007350bc04sc03i00' [1051] Jul 15 19:58:56 scout udevd[914]: timeout: killing '/sbin/modprobe -b usb:vFC08p0101d0250dc00dsc00dp00ic01isc03ip00in01' [1045] Jul 15 19:58:56 scout udevd[919]: '/sbin/modprobe -b pci:v000010DEd0000026Csv00001462sd00007350bc04sc03i00' [1051] terminated by signal 9 (Killed) Jul 15 19:58:56 scout udevd[914]: '/sbin/modprobe -b usb:vFC08p0101d0250dc00dsc00dp00ic01isc03ip00in01' [1045] terminated by signal 9 (Killed) This is a Debian sid system # modprobe -V kmod version 9 # echo t >/proc/sysrq-trigger produces too much output to include the modprobe processes. I already stopped most processes, but that is not enough. # cat /proc/1092/syscall 175 0x7effcad92000 0xafe8 0x7effca9c2f88 0x7effca6ea3aa 0x0 0x0 0x7fff3e3de648 0x7effca6eef8a # cat /proc/1080/syscall 175 0x7fe01b25e000 0xafe8 0x7fe01ae8ef88 0x7fe01abb63aa 0x3 0x0 0x7fffba8cc748 0x7fe01abbaf8a # cat /proc/1154/syscall 175 0x7fc157a7b000 0xafe8 0x7fc1576abf88 0x7fc1573d33aa 0x3 0x0 0x7fff05809e58 0x7fc1573d7f8a # cat /proc/1148/syscall 175 0x7fc7159d5000 0xafe8 0x7fc715605f88 0x7fc71532d3aa 0x3 0x0 0x7fff47a1f3c8 0x7fc715331f8a Is this a know bug or has someone seen similar problems? # cat /proc/modules ip6table_filter 1575 0 - Live 0xffffffffa0893000 ip6_tables 13784 1 ip6table_filter, Live 0xffffffffa088b000 ebtable_nat 1887 0 - Live 0xffffffffa0887000 ebtables 19917 1 ebtable_nat, Live 0xffffffffa087e000 snd_usb_audio 124196 0 - Live 0xffffffffa0851000 snd_usbmidi_lib 16982 1 snd_usb_audio, Live 0xffffffffa0848000 rfcomm 28731 10 - Live 0xffffffffa083a000 bnep 9786 2 - Live 0xffffffffa0833000 snd_hda_codec_realtek 37669 1 - Live 0xffffffffa0823000 snd_hda_intel 31432 0 - Live 0xffffffffa0814000 snd_hda_codec 140669 2 snd_hda_codec_realtek,snd_hda_intel, Live 0xffffffffa07e2000 snd_hwdep 5627 2 snd_usb_audio,snd_hda_codec, Live 0xffffffffa07dd000 iptable_filter 1618 1 - Live 0xffffffffa07d9000 xt_owner 1326 1 - Live 0xffffffffa07d5000 ip_tables 13390 1 iptable_filter, Live 0xffffffffa07cd000 x_tables 18433 6 ip6table_filter,ip6_tables,ebtables,iptable_filter,xt_owner,ip_tables, Live 0xffffffffa07c3000 cpufreq_conservative 7015 0 - Live 0xffffffffa07bd000 cpufreq_ondemand 8945 0 - Live 0xffffffffa07b6000 cpufreq_powersave 1010 0 - Live 0xffffffffa07b2000 cpufreq_userspace 2136 0 - Live 0xffffffffa07ae000 binfmt_misc 6479 1 - Live 0xffffffffa07a9000 bridge 74378 0 - Live 0xffffffffa078d000 stp 1908 1 bridge, Live 0xffffffffa0789000 llc 4485 2 bridge,stp, Live 0xffffffffa0784000 deflate 1873 0 - Live 0xffffffffa0780000 ctr 3633 0 - Live 0xffffffffa077c000 twofish_generic 5715 0 - Live 0xffffffffa0777000 twofish_x86_64_3way 19885 0 - Live 0xffffffffa076f000 twofish_x86_64 5503 1 twofish_x86_64_3way, Live 0xffffffffa076a000 twofish_common 13133 3 twofish_generic,twofish_x86_64_3way,twofish_x86_64, Live 0xffffffffa0763000 camellia_generic 18308 0 - Live 0xffffffffa075b000 camellia_x86_64 45885 0 - Live 0xffffffffa074b000 serpent_sse2_x86_64 44963 0 - Live 0xffffffffa073d000 serpent_generic 21243 1 serpent_sse2_x86_64, Live 0xffffffffa0734000 ablk_helper 2284 1 serpent_sse2_x86_64, Live 0xffffffffa0730000 cryptd 7992 1 ablk_helper, Live 0xffffffffa072a000 xts 2958 3 twofish_x86_64_3way,camellia_x86_64,serpent_sse2_x86_64, Live 0xffffffffa0726000 lrw 3584 3 twofish_x86_64_3way,camellia_x86_64,serpent_sse2_x86_64, Live 0xffffffffa0722000 gf128mul 6580 2 xts,lrw, Live 0xffffffffa071d000 glue_helper 4810 3 twofish_x86_64_3way,camellia_x86_64,serpent_sse2_x86_64, Live 0xffffffffa0718000 blowfish_generic 3194 0 - Live 0xffffffffa0714000 blowfish_x86_64 14084 0 - Live 0xffffffffa070d000 blowfish_common 6425 2 blowfish_generic,blowfish_x86_64, Live 0xffffffffa0708000 cast5_generic 10378 0 - Live 0xffffffffa0702000 cast_common 5351 1 cast5_generic, Live 0xffffffffa06fd000 des_generic 16147 0 - Live 0xffffffffa06f6000 cmac 2460 0 - Live 0xffffffffa06f2000 xcbc 2423 0 - Live 0xffffffffa06ee000 rmd160 7552 0 - Live 0xffffffffa06e9000 nfsd 208660 2 - Live 0xffffffffa06a8000 auth_rpcgss 39179 1 nfsd, Live 0xffffffffa0698000 oid_registry 2490 1 auth_rpcgss, Live 0xffffffffa0694000 nfs_acl 2285 1 nfsd, Live 0xffffffffa0690000 sha512_generic 5023 0 - Live 0xffffffffa068b000 nfs 127233 0 - Live 0xffffffffa065b000 lockd 57962 2 nfsd,nfs, Live 0xffffffffa0645000 fscache 34198 1 nfs, Live 0xffffffffa0636000 sha1_ssse3 9266 0 - Live 0xffffffffa0630000 sha1_generic 2064 1 sha1_ssse3, Live 0xffffffffa062c000 sunrpc 185043 6 nfsd,auth_rpcgss,nfs_acl,nfs,lockd, Live 0xffffffffa05ea000 md5 1803 0 - Live 0xffffffffa05e6000 crypto_null 2624 0 - Live 0xffffffffa05e2000 af_key 25880 0 - Live 0xffffffffa05d6000 xfrm_algo 6101 1 af_key, Live 0xffffffffa05d1000 ves1820 5159 1 - Live 0xffffffffa05cc000 btusb 14810 0 - Live 0xffffffffa05bc000 bluetooth 183572 24 rfcomm,bnep,btusb, Live 0xffffffffa054a000 stv0297 6493 1 - Live 0xffffffffa052f000 snd_rawmidi 17913 1 snd_usbmidi_lib, Live 0xffffffffa0525000 snd_pcm_oss 32083 0 - Live 0xffffffffa0518000 snd_mixer_oss 12485 1 snd_pcm_oss, Live 0xffffffffa0510000 snd_pcm 73594 4 snd_usb_audio,snd_hda_intel,snd_hda_codec,snd_pcm_oss, Live 0xffffffffa04f5000 snd_page_alloc 7172 2 snd_hda_intel,snd_pcm, Live 0xffffffffa04f0000 dvb_ttpci 93699 0 - Live 0xffffffffa04d1000 saa7146_vv 26567 1 dvb_ttpci, Live 0xffffffffa04c5000 videobuf_dma_sg 8015 1 saa7146_vv, Live 0xffffffffa04bf000 videobuf_core 15578 2 saa7146_vv,videobuf_dma_sg, Live 0xffffffffa04b7000 v4l2_common 7907 1 saa7146_vv, Live 0xffffffffa04b1000 budget_ci 21012 0 - Live 0xffffffffa04a7000 videodev 97317 2 saa7146_vv,v4l2_common, Live 0xffffffffa0486000 budget_core 7679 1 budget_ci, Live 0xffffffffa0481000 ttpci_eeprom 1985 2 dvb_ttpci,budget_core, Live 0xffffffffa0479000 saa7146 11356 4 dvb_ttpci,saa7146_vv,budget_ci,budget_core, Live 0xffffffffa046b000 rc_core 13478 2 budget_ci, Live 0xffffffffa044a000 dvb_core 68839 3 dvb_ttpci,budget_ci,budget_core, Live 0xffffffffa0431000 snd_seq_oss 33717 1 - Loading 0xffffffffa041b000 snd_seq_midi_event 5740 1 snd_seq_oss, Live 0xffffffffa0416000 snd_seq 44232 2 snd_seq_oss,snd_seq_midi_event, Live 0xffffffffa0404000 snd_seq_device 5560 3 snd_rawmidi,snd_seq_oss,snd_seq, Live 0xffffffffa03ff000 snd_timer 17417 2 snd_pcm,snd_seq, Live 0xffffffffa03f6000 snd 58793 14 snd_usb_audio,snd_usbmidi_lib,snd_hda_codec_realtek,snd_hda_intel,snd_hda_codec,snd_hwdep,snd_rawmidi,snd_pcm_oss,snd_mixer_oss,snd_pcm,snd_seq_oss,snd_seq,snd_seq_device,snd_timer, Live 0xffffffffa03df000 pcspkr 1926 0 - Live 0xffffffffa03db000 psmouse 52563 0 - Live 0xffffffffa03c6000 serio_raw 4517 0 - Live 0xffffffffa03c1000 soundcore 5811 1 snd, Live 0xffffffffa03b7000 evdev 8465 0 - Live 0xffffffffa039d000 kvm_intel 122108 0 - Live 0xffffffffa0351000 kvm 342589 1 kvm_intel, Live 0xffffffffa0271000 usb_storage 46166 0 - Live 0xffffffffa025c000 fuse 65800 1 - Live 0xffffffffa0243000 ecryptfs 80646 0 - Live 0xffffffffa0227000 cbc 2574 0 - Live 0xffffffffa0223000 sha256_ssse3 16172 2 - Live 0xffffffffa021c000 sha256_generic 9882 1 sha256_ssse3, Live 0xffffffffa0216000 hmac 2673 1 - Live 0xffffffffa0212000 encrypted_keys 9378 1 ecryptfs, Live 0xffffffffa020b000 autofs4 20984 2 - Live 0xffffffffa0200000 ext4 434295 5 - Live 0xffffffffa0173000 crc16 1541 2 bluetooth,ext4, Live 0xffffffffa016f000 jbd2 83146 1 ext4, Live 0xffffffffa0150000 btrfs 682625 1 - Live 0xffffffffa008b000 crc32c 1610 1 - Live 0xffffffffa0087000 libcrc32c 1147 1 btrfs, Live 0xffffffffa0083000 xor 11190 1 btrfs, Live 0xffffffffa007d000 zlib_deflate 18739 2 deflate,btrfs, Live 0xffffffffa0075000 raid6_pq 92000 1 btrfs, Live 0xffffffffa005a000 nbd 8786 0 - Live 0xffffffffa0053000 firewire_ohci 27516 0 - Live 0xffffffffa0048000 firewire_core 49041 1 firewire_ohci, Live 0xffffffffa0035000 crc_itu_t 1565 1 firewire_core, Live 0xffffffffa0031000 forcedeth 50647 0 - Live 0xffffffffa001e000 floppy 53437 0 - Live 0xffffffffa0009000 ohci_hcd 18001 0 - Live 0xffffffffa0000000 BYtE Philipp -- / / (_)__ __ ____ __ Philipp Hahn / /__/ / _ \/ // /\ \/ / /____/_/_//_/\_,_/ /_/\_\ pmhahn(a)pmhahn.de

7 10

[alsa-devel] [PATCH v2] ASoC: sgtl5000: defer the probe if clock is not found
by Shawn Guo 16 Jul '13

16 Jul '13

It's not always the case that clock is already available when sgtl5000 get probed at the first time, e.g. the clock is provided by CPU DAI which may be probed after sgtl5000. So let's defer the probe when devm_clk_get() call fails and give it chance to try later. It fixes the regression on imx28 since commit 9e13f34 (ASoC: sgtl5000: Let the codec acquire its clock). [ 1.927637] sgtl5000 0-000a: Failed to get mclock: -2 [ 1.934280] sgtl5000: probe of 0-000a failed with error -2 [ 1.945906] mxs-sgtl5000 sound.13: ASoC: CODEC (null) not registered [ 1.953787] mxs-sgtl5000 sound.13: snd_soc_register_card failed (-517) [ 1.960865] platform sound.13: Driver mxs-sgtl5000 requests probe deferral Signed-off-by: Shawn Guo <shawn.guo(a)linaro.org> --- Changes since v1: * Not use ternary operator. Mark, I'm still not going to fix this regression during -rc at clock core level with the risk of breaking clock API users and being yelled by clock maintainer. Shawn sound/soc/codecs/sgtl5000.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index d441559..f5ec35b 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -1527,6 +1527,9 @@ static int sgtl5000_i2c_probe(struct i2c_client *client, if (IS_ERR(sgtl5000->mclk)) { ret = PTR_ERR(sgtl5000->mclk); dev_err(&client->dev, "Failed to get mclock: %d\n", ret); + /* Defer the probe to see if the clk will be provided later */ + if (ret == -ENOENT) + return -EPROBE_DEFER; return ret; } -- 1.7.9.5

2 2

[alsa-devel] [PATCH] ASoC: tegra: fix compile warning in AC'97 driver
by Stephen Warren 16 Jul '13

16 Jul '13

From: Stephen Warren <swarren(a)nvidia.com> This fixes the following by deleting dead code: sound/soc/tegra/tegra20_ac97.c: In function ‘tegra20_ac97_platform_probe’: sound/soc/tegra/tegra20_ac97.c:435:1: warning: label ‘err_unregister_pcm’ defined but not used [-Wunused-label] Signed-off-by: Stephen Warren <swarren(a)nvidia.com> --- sound/soc/tegra/tegra20_ac97.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/tegra/tegra20_ac97.c b/sound/soc/tegra/tegra20_ac97.c index e58233f..87b845f 100644 --- a/sound/soc/tegra/tegra20_ac97.c +++ b/sound/soc/tegra/tegra20_ac97.c @@ -432,8 +432,6 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev) return 0; -err_unregister_pcm: - tegra_pcm_platform_unregister(&pdev->dev); err_unregister_component: snd_soc_unregister_component(&pdev->dev); err_asoc_utils_fini: -- 1.8.1.5

2 1

[alsa-devel] [PATCH] ASoc: tegra: Remove unneeded mach-type.h incldues
by Mark Brown 16 Jul '13

16 Jul '13

From: Mark Brown <broonie(a)linaro.org> Signed-off-by: Mark Brown <broonie(a)linaro.org> --- sound/soc/tegra/tegra_alc5632.c | 2 -- sound/soc/tegra/tegra_wm8753.c | 2 -- sound/soc/tegra/trimslice.c | 2 -- 3 files changed, 6 deletions(-) diff --git a/sound/soc/tegra/tegra_alc5632.c b/sound/soc/tegra/tegra_alc5632.c index 48d05d9..c61ea3a 100644 --- a/sound/soc/tegra/tegra_alc5632.c +++ b/sound/soc/tegra/tegra_alc5632.c @@ -13,8 +13,6 @@ * published by the Free Software Foundation. */ -#include <asm/mach-types.h> - #include <linux/module.h> #include <linux/platform_device.h> #include <linux/slab.h> diff --git a/sound/soc/tegra/tegra_wm8753.c b/sound/soc/tegra/tegra_wm8753.c index f87fc53..8e774d1 100644 --- a/sound/soc/tegra/tegra_wm8753.c +++ b/sound/soc/tegra/tegra_wm8753.c @@ -28,8 +28,6 @@ * */ -#include <asm/mach-types.h> - #include <linux/module.h> #include <linux/platform_device.h> #include <linux/slab.h> diff --git a/sound/soc/tegra/trimslice.c b/sound/soc/tegra/trimslice.c index 05c68aa..734bfcd 100644 --- a/sound/soc/tegra/trimslice.c +++ b/sound/soc/tegra/trimslice.c @@ -24,8 +24,6 @@ * */ -#include <asm/mach-types.h> - #include <linux/module.h> #include <linux/of.h> #include <linux/platform_device.h> -- 1.8.3.2

2 1

[alsa-devel] [PATCH] ASoC: tegra_alc5632: Remove unused mach-types.h include
by Mark Brown 16 Jul '13

16 Jul '13

From: Mark Brown <broonie(a)linaro.org> Reported-by: Stephen Rothwell <sfr(a)canb.auug.org.au> Signed-off-by: Mark Brown <broonie(a)linaro.org> --- sound/soc/tegra/tegra_alc5632.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/tegra/tegra_alc5632.c b/sound/soc/tegra/tegra_alc5632.c index 48d05d9..c61ea3a 100644 --- a/sound/soc/tegra/tegra_alc5632.c +++ b/sound/soc/tegra/tegra_alc5632.c @@ -13,8 +13,6 @@ * published by the Free Software Foundation. */ -#include <asm/mach-types.h> - #include <linux/module.h> #include <linux/platform_device.h> #include <linux/slab.h> -- 1.8.3.2

2 2

[alsa-devel] [PATCH 0/10] snd_pcm_stop() lock fixes
by Takashi Iwai 16 Jul '13

16 Jul '13

Hi, while reviewing another patch series, I stumbled on the snd_pcm_lock() call in an unlocked context. Then I started looking through the whole tree, and found a bunch of drivers doing it wrong, too. So here is a patch series to fix them. [PATCH 01/10] ALSA: asihpi: Fix unlocked snd_pcm_stop() call [PATCH 02/10] ALSA: atiixp: Fix unlocked snd_pcm_stop() call [PATCH 03/10] ALSA: 6fire: Fix unlocked snd_pcm_stop() call [PATCH 04/10] ALSA: ua101: Fix unlocked snd_pcm_stop() call [PATCH 05/10] ALSA: usx2y: Fix unlocked snd_pcm_stop() call [PATCH 06/10] ALSA: pxa2xx: Fix unlocked snd_pcm_stop() call [PATCH 07/10] ASoC: atmel: Fix unlocked snd_pcm_stop() call [PATCH 08/10] ASoC: s6000: Fix unlocked snd_pcm_stop() call [PATCH 09/10] [media] saa7134: Fix unlocked snd_pcm_stop() call [PATCH 10/10] staging: line6: Fix unlocked snd_pcm_stop() call Takashi

6 22

[alsa-devel] snd_pcm_delay issue - How to debug?
by Sander Jansen 16 Jul '13

16 Jul '13

Hi, I'm seeing an issue where snd_pcm_delay is returning bogus values (usually a lot larger than in actuality) in that it ultimately affects the progress timer in my audio player. Both are HDA based audio cards, though one connects to the HDMI output and while the other connects to analog out. I'm suspecting I'm seeing a driver bug since I only start noticing the issue since a few kernel releases ago (though not sure which one started it). How can i best debug this issue and find out the cause. Thanks, Sander

1 0

[alsa-devel] [PATCH] ASoC: imx-sgtl5000: fix error return code in imx_sgtl5000_probe()
by Wei Yongjun 16 Jul '13

16 Jul '13

From: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> --- sound/soc/fsl/imx-sgtl5000.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c index 7a8bc12..25f310d 100644 --- a/sound/soc/fsl/imx-sgtl5000.c +++ b/sound/soc/fsl/imx-sgtl5000.c @@ -129,8 +129,10 @@ static int imx_sgtl5000_probe(struct platform_device *pdev) } data->codec_clk = devm_clk_get(&codec_dev->dev, NULL); - if (IS_ERR(data->codec_clk)) + if (IS_ERR(data->codec_clk)) { + ret = PTR_ERR(data->codec_clk); goto fail; + } data->clk_frequency = clk_get_rate(data->codec_clk);

3 2