June 2013 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: adav80x: Select SND_SOC_ADAV80X if SND_SOC_I2C_AND_SPI
by Axel Lin 10 Jun '13

10 Jun '13

This driver is useless if both SPI and I2C are not configured. Thus don't build this driver if both SPI and I2C are not configured. This patch silences below build warning if both SPI and I2C are not configured. CC sound/soc/codecs/adav80x.o sound/soc/codecs/adav80x.c:842:12: warning: 'adav80x_bus_probe' defined but not used [-Wunused-function] sound/soc/codecs/adav80x.c:863:12: warning: 'adav80x_bus_remove' defined but not used [-Wunused-function] Signed-off-by: Axel Lin <axel.lin(a)ingics.com> --- sound/soc/codecs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index c90d298..6234900 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -19,7 +19,7 @@ config SND_SOC_ALL_CODECS select SND_SOC_AD1980 if SND_SOC_AC97_BUS select SND_SOC_AD73311 select SND_SOC_ADAU1373 if I2C - select SND_SOC_ADAV80X + select SND_SOC_ADAV80X if SND_SOC_I2C_AND_SPI select SND_SOC_ADS117X select SND_SOC_AK4104 if SPI_MASTER select SND_SOC_AK4535 if I2C -- 1.8.1.2

3 2

[alsa-devel] ASoC: ssm2518: bug in ssm2518_set_tdm_slot
by Axel Lin 10 Jun '13

10 Jun '13

ASoC: ssm2518: bug in ssm2518_set_tdm_slot The code in ssm2518_set_tdm_slot looks wrong: if (tx_mask == 0 || tx_mask != 0) return -EINVAL; So ssm2518_set_tdm_slot() always returns error.

2 1

[alsa-devel] [PATCH 0/4] ASoC: codecs: some more improvements for adau1701
by Daniel Mack 10 Jun '13

10 Jun '13

Here are some more patches that I worked on while bootstrapping a new audio device featuring an ADAU1701 DSP. Daniel Mack (4): ASoC: codecs: adau1701: factor out firmware reset ASoC: codecs: adau1701: allow configuration of PLL mode pins ASoC: codecs: adau1701: switch to direct regmap API usage ASoC: codecs: adau1701: add support for pin muxing .../devicetree/bindings/sound/adi,adau1701.txt | 17 ++ sound/soc/codecs/adau1701.c | 255 ++++++++++++++++++--- sound/soc/codecs/adau1701.h | 4 + 3 files changed, 238 insertions(+), 38 deletions(-) -- 1.8.1.4

3 9

[alsa-devel] [PATCH] ASoC: wm8962: Restore device state after reset in runtime resume
by Mark Brown 10 Jun '13

10 Jun '13

After the device has been reset we need to repeat the same initialisation we do on probe to make sure that the device is in a known state. Signed-off-by: Mark Brown <broonie(a)linaro.org> --- sound/soc/codecs/wm8962.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c index d56dd86..32c2c47 100644 --- a/sound/soc/codecs/wm8962.c +++ b/sound/soc/codecs/wm8962.c @@ -3723,6 +3723,21 @@ static int wm8962_runtime_resume(struct device *dev) wm8962_reset(wm8962); + /* SYSCLK defaults to on; make sure it is off so we can safely + * write to registers if the device is declocked. + */ + regmap_update_bits(wm8962->regmap, WM8962_CLOCKING2, + WM8962_SYSCLK_ENA, 0); + + /* Ensure we have soft control over all registers */ + regmap_update_bits(wm8962->regmap, WM8962_CLOCKING2, + WM8962_CLKREG_OVD, WM8962_CLKREG_OVD); + + /* Ensure that the oscillator and PLLs are disabled */ + regmap_update_bits(wm8962->regmap, WM8962_PLL2, + WM8962_OSC_ENA | WM8962_PLL2_ENA | WM8962_PLL3_ENA, + 0); + regcache_sync(wm8962->regmap); return 0; -- 1.7.10.4

4 4

[alsa-devel] [PATCH] ASoC: Add Kconfig and Makefile to support SPEAr audio driver
by Rajeev Kumar 10 Jun '13

10 Jun '13

This patch adds Kconfig and Makefile to support SPEAr Audio driver. Signed-off-by: Rajeev Kumar <rajeev-dlh.kumar(a)st.com> --- sound/soc/Kconfig | 1 + sound/soc/Makefile | 1 + sound/soc/spear/Kconfig | 39 +++++++++++++++++++++++++++++++++++++++ sound/soc/spear/Makefile | 7 +++++++ 4 files changed, 48 insertions(+), 0 deletions(-) create mode 100644 sound/soc/spear/Kconfig create mode 100644 sound/soc/spear/Makefile diff --git a/sound/soc/Kconfig b/sound/soc/Kconfig index 5da8ca7..c6d98e2 100644 --- a/sound/soc/Kconfig +++ b/sound/soc/Kconfig @@ -47,6 +47,7 @@ source "sound/soc/pxa/Kconfig" source "sound/soc/samsung/Kconfig" source "sound/soc/s6000/Kconfig" source "sound/soc/sh/Kconfig" +source "sound/soc/spear/Kconfig" source "sound/soc/tegra/Kconfig" source "sound/soc/txx9/Kconfig" source "sound/soc/ux500/Kconfig" diff --git a/sound/soc/Makefile b/sound/soc/Makefile index 99f32f7..b86bf5a 100644 --- a/sound/soc/Makefile +++ b/sound/soc/Makefile @@ -25,6 +25,7 @@ obj-$(CONFIG_SND_SOC) += pxa/ obj-$(CONFIG_SND_SOC) += samsung/ obj-$(CONFIG_SND_SOC) += s6000/ obj-$(CONFIG_SND_SOC) += sh/ +obj-$(CONFIG_SND_SOC) += spear/ obj-$(CONFIG_SND_SOC) += tegra/ obj-$(CONFIG_SND_SOC) += txx9/ obj-$(CONFIG_SND_SOC) += ux500/ diff --git a/sound/soc/spear/Kconfig b/sound/soc/spear/Kconfig new file mode 100644 index 0000000..3b7cdad --- /dev/null +++ b/sound/soc/spear/Kconfig @@ -0,0 +1,39 @@ +config SND_SPEAR_EVM + tristate "SoC Audio support for SPEAr EVM" + select SND_DESIGNWARE_I2S + select SND_SOC_STA529 + select SND_SPEAR_SOC + help + Say Y if you want to add support for SoC audio on SPEAr + platform + +config SND_SPEAR1340_EVM + tristate "SoC Audio support for SPEAr1340 EVM" + select SND_DESIGNWARE_I2S + select SND_SOC_STA529 + select SND_SPEAR_SPDIF_OUT + select SND_SPEAR_SPDIF_IN + select SND_SOC_SPDIF + select SND_SPEAR_SOC + help + Say Y if you want to add support for SoC audio on SPEAr1340 + platform + +config SND_SPEAR_SOC + tristate "SoC Audio for the ST chip" + depends on SND_DESIGNWARE_I2S || SND_SPEAR_SPDIF_OUT || \ + SND_SPEAR_SPDIF_IN + help + Say Y or M if you want to add support for any of the audio + controllers (I2S/SPDIF). You will also need to select + the audio interface codecs to support below. + +config SND_SPEAR_SPDIF_OUT + tristate "SPEAr SPDIF Out Device Driver" + help + Say Y or M if you want to add support for SPDIF OUT driver. + +config SND_SPEAR_SPDIF_IN + tristate "SPEAr SPDIF IN Device Driver" + help + Say Y or M if you want to add support for SPDIF IN driver. diff --git a/sound/soc/spear/Makefile b/sound/soc/spear/Makefile new file mode 100644 index 0000000..b365126 --- /dev/null +++ b/sound/soc/spear/Makefile @@ -0,0 +1,7 @@ +# SPEAR Platform Support +obj-$(CONFIG_SND_SPEAR_SOC) += spear_pcm.o +obj-$(CONFIG_SND_SPEAR_SPDIF_IN) += spdif_in.o +obj-$(CONFIG_SND_SPEAR_SPDIF_OUT) += spdif_out.o + +# SPEAR Machine Support +obj-$(CONFIG_SND_SPEAR_EVM) += spear_evb.o -- 1.6.0.2

2 1

Re: [alsa-devel] [PATCH 12/15] ASoC: spear: Convert to use devm_ioremap_resource
by Sachin Kamat 10 Jun '13

10 Jun '13

On 10 June 2013 17:05, Tushar Behera <tushar.behera(a)linaro.org> wrote: > Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()") > introduced devm_ioremap_resource() and deprecated the use of > devm_request_and_ioremap(). This patch does a little more than just conversion. May that change could be mentioned here. > > Signed-off-by: Tushar Behera <tushar.behera(a)linaro.org> > CC: alsa-devel(a)alsa-project.org > CC: Liam Girdwood <lgirdwood(a)gmail.com> > CC: Mark Brown <broonie(a)kernel.org> > --- > sound/soc/spear/spdif_out.c | 20 +++++--------------- > 1 file changed, 5 insertions(+), 15 deletions(-) > > diff --git a/sound/soc/spear/spdif_out.c b/sound/soc/spear/spdif_out.c > index 4bde512..896ee7f 100644 > --- a/sound/soc/spear/spdif_out.c > +++ b/sound/soc/spear/spdif_out.c > @@ -282,27 +282,17 @@ static int spdif_out_probe(struct platform_device *pdev) > struct resource *res; > int ret; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) > - return -EINVAL; > - > - if (!devm_request_mem_region(&pdev->dev, res->start, > - resource_size(res), pdev->name)) { > - dev_warn(&pdev->dev, "Failed to get memory resourse\n"); > - return -ENOENT; > - } > - > host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL); > if (!host) { > dev_warn(&pdev->dev, "kzalloc fail\n"); > return -ENOMEM; > } > > - host->io_base = devm_request_and_ioremap(&pdev->dev, res->start, > - resource_size(res)); > - if (!host->io_base) { > - dev_warn(&pdev->dev, "ioremap failed\n"); > - return -ENOMEM; > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + host->io_base = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(host->io_base)) { > + dev_warn(&pdev->dev, "devm_ioremap_resource failed\n"); This print is not needed as devm_ioremap_resource prints its own messages. > + return PTR_ERR(host->io_base); > } > > host->clk = devm_clk_get(&pdev->dev, NULL); > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- With warm regards, Sachin

1 0

[alsa-devel] Missing Kconfig and Makefile for SPEAr platform
by Rajeev kumar 10 Jun '13

10 Jun '13

Hello Mark, The Makefile and Kconfig is missing for SPEAr platform. Please find below the link of circulated patch for the same. http://mailman.alsa-project.org/pipermail/alsa-devel/2012-June/052872.html Please update. Thanks and Best Regards Rajeev

2 1

Re: [alsa-devel] [PATCH] ASoC: dmaengine: add runtime status checking in dmaengine_pcm_dma_complete
by Mark Brown 10 Jun '13

10 Jun '13

On Sat, Jun 08, 2013 at 04:34:02PM +0800, Qiao Zhou wrote: > This call back only takes substream as parameter. In case that a > wrong/fake interrupt of other drivers triggers this call back, like > a careless/bad design, then it panics in audio driver. Can we add > such checking and give a warning log rather than to let the system > die directly. Could you consider it? Why not fix the problem in the paths that do the teardown instead?

1 0

[alsa-devel] Codec driver gets probed prior to the machine driver
by Fabio Estevam 10 Jun '13

10 Jun '13

Hi, When running linux-next 20130607 on a mx6qsabrelite I see that the audio drivers fail to probe. Added some printk's to better illustrate the problem: mmcblk0: mmc0:b5a1 SD04G 3.69 GiB **** reading the chip ID sgtl5000: probe of 0-000a failed with error -5 ****** enabling the codec clock imx-sgtl5000 sound.13: ASoC: CODEC (null) not registered imx-sgtl5000 sound.13: snd_soc_register_card failed (-517) platform sound.13: Driver imx-sgtl5000 requests probe defer The problem here is that the codec driver (sgtl5000) is being probed prior to the machine driver (imx-sgtl5000). The reading of the chip ID fails because at this point in time there is no codec clock, which is turned on by imx-sgtl5000. Running 3.10-rc4, the order of the events is as expected: imx-sgtl5000 is called first and sgtl5000 is called later. In this case the probe works as usual. Tried doing a bisect, but this was not succesful due to several bisect breakages (build issues and non-booting kernels) on its way. Would anyone have some suggestion as to why the codec driver is getting probed first? Thanks, Fabio Estevam

3 3

[alsa-devel] Device enumeration
by Robert Billing 10 Jun '13

10 Jun '13

I am currently developing a package to play theatrical sound effects, which has two play channels that I want to be able to attach to two different ALSA devices. To allow the users, who are theatre directors and are *not* technical to do this I am trying to provide a drop-down list of play devices. I can get the raw devices by parsing either the output from aplay -L, or from /proc/asound. The problem comes with devices defined in .asoundrc. I have this in .asoundrc on the development system: pcm.speakers { type pulse device alsa_output.pci-0000_02_06.0.analog-stereo } ctl.speakers { type pulse device alsa_output.pci-0000_02_06.0.analog-stereo } pcm.cans { type pulse device alsa_output.pci-0000_00_1f.5.analog-stereo } ctl.cans { type pulse device alsa_output.pci-0000_00_1f.5.analog-stereo } This works and it is possible to play to the devices "cans" or "speakers" to get output on headphones and speakers respectively, but these names don't appear in the output from aplay. What I need is some clean way of getting a list of the aliases. This package will have to be capable of being installed on any Linux system without needing to edit configuration files manually. However if some tool or some part of the installation process has edited a configuration file I want the aliases to appear in my list of devices. What is the right way to do this? -- Robert Billing, Phone/fax +44 (0) 1344-772849 bob(a)tnglwood.demon.co.uk Tanglewood, 64, Pinehill Road, Crowthorne, Berks, RG45 7JR

1 0