May 2013 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH V2] ASoC: sgtl5000: Fix VAG_POWER enabling/disabling order
by Marek Vasut 04 Jun '13

04 Jun '13

The VAG_POWER must be enabled after all other bits in CHIP_ANA_POWER and disabled before any other bit in CHIP_ANA_POWER. See the SGTL5000 datasheet (Table 31, BIT 7, page 42-43). Failing to follow this order will result in ugly loud "POP" noise at the end of playback. To achieve such order, use the _PRE and _POST DAPM widgets to trigger the power_vag_event, where the event type check has to be fixed accordingly as well. Signed-off-by: Marek Vasut <marex(a)denx.de> Cc: Dong Aisheng <dong.aisheng(a)linaro.org> Cc: Eric Nelson <eric.nelson(a)boundarydevices.com> Cc: Fabio Estevam <fabio.estevam(a)freescale.com> Cc: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/sgtl5000.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) V2: Remove that mdelay/msleep regression diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 92bbfec..1994f01 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -151,12 +151,12 @@ static int power_vag_event(struct snd_soc_dapm_widget *w, struct snd_kcontrol *kcontrol, int event) { switch (event) { - case SND_SOC_DAPM_PRE_PMU: + case SND_SOC_DAPM_POST_PMU: snd_soc_update_bits(w->codec, SGTL5000_CHIP_ANA_POWER, SGTL5000_VAG_POWERUP, SGTL5000_VAG_POWERUP); break; - case SND_SOC_DAPM_POST_PMD: + case SND_SOC_DAPM_PRE_PMD: snd_soc_update_bits(w->codec, SGTL5000_CHIP_ANA_POWER, SGTL5000_VAG_POWERUP, 0); msleep(400); @@ -217,12 +217,11 @@ static const struct snd_soc_dapm_widget sgtl5000_dapm_widgets[] = { 0, SGTL5000_CHIP_DIG_POWER, 1, 0), - SND_SOC_DAPM_SUPPLY("VAG_POWER", SGTL5000_CHIP_ANA_POWER, 7, 0, - power_vag_event, - SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMD), - SND_SOC_DAPM_ADC("ADC", "Capture", SGTL5000_CHIP_ANA_POWER, 1, 0), SND_SOC_DAPM_DAC("DAC", "Playback", SGTL5000_CHIP_ANA_POWER, 3, 0), + + SND_SOC_DAPM_PRE("VAG_POWER_PRE", power_vag_event), + SND_SOC_DAPM_POST("VAG_POWER_POST", power_vag_event), }; /* routes for sgtl5000 */ @@ -230,16 +229,13 @@ static const struct snd_soc_dapm_route sgtl5000_dapm_routes[] = { {"Capture Mux", "LINE_IN", "LINE_IN"}, /* line_in --> adc_mux */ {"Capture Mux", "MIC_IN", "MIC_IN"}, /* mic_in --> adc_mux */ - {"ADC", NULL, "VAG_POWER"}, {"ADC", NULL, "Capture Mux"}, /* adc_mux --> adc */ {"AIFOUT", NULL, "ADC"}, /* adc --> i2s_out */ - {"DAC", NULL, "VAG_POWER"}, {"DAC", NULL, "AIFIN"}, /* i2s-->dac,skip audio mux */ {"Headphone Mux", "DAC", "DAC"}, /* dac --> hp_mux */ {"LO", NULL, "DAC"}, /* dac --> line_out */ - {"LINE_IN", NULL, "VAG_POWER"}, {"Headphone Mux", "LINE_IN", "LINE_IN"},/* line_in --> hp_mux */ {"HP", NULL, "Headphone Mux"}, /* hp_mux --> hp */ -- 1.7.10.4

2 1

[alsa-devel] [PATCH] ASoC: omap-hdmi-codec: make the driver common for other SoCs
by Barry Song 04 Jun '13

04 Jun '13

to support HDMI on CSR SiRFprimaII and atlasVI, we need one more HDMI pseudo codec, rather than add a new driver, we can make omap HDMI codec common for other SoCs as well. then the omap-hdmi codec becomes a generic HDMI pseudo- codec as HDMI audio features depend on HDMI specification not on SoCs. Cc: Ricardo Neri <ricardo.neri(a)ti.com> Signed-off-by: Barry Song <Baohua.Song(a)csr.com> --- sound/soc/codecs/Kconfig | 4 ++-- sound/soc/codecs/Makefile | 4 ++-- sound/soc/codecs/{omap-hdmi.c => hdmi.c} | 26 +++++++++++++------------- sound/soc/omap/omap-hdmi-card.c | 2 +- 4 files changed, 18 insertions(+), 18 deletions(-) rename sound/soc/codecs/{omap-hdmi.c => hdmi.c} (69%) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 2f45f00..d8c4f3d 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -53,7 +53,7 @@ config SND_SOC_ALL_CODECS select SND_SOC_MAX9877 if I2C select SND_SOC_MC13783 if MFD_MC13XXX select SND_SOC_ML26124 if I2C - select SND_SOC_OMAP_HDMI_CODEC if OMAP4_DSS_HDMI + select SND_SOC_HDMI_CODEC select SND_SOC_PCM3008 select SND_SOC_RT5631 if I2C select SND_SOC_SGTL5000 if I2C @@ -287,7 +287,7 @@ config SND_SOC_MAX98095 config SND_SOC_MAX9850 tristate -config SND_SOC_OMAP_HDMI_CODEC +config SND_SOC_HDMI_CODEC tristate config SND_SOC_PCM3008 diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile index b9e41c9..49ff127 100644 --- a/sound/soc/codecs/Makefile +++ b/sound/soc/codecs/Makefile @@ -41,7 +41,7 @@ snd-soc-max98095-objs := max98095.o snd-soc-max9850-objs := max9850.o snd-soc-mc13783-objs := mc13783.o snd-soc-ml26124-objs := ml26124.o -snd-soc-omap-hdmi-codec-objs := omap-hdmi.o +snd-soc-hdmi-codec-objs := hdmi.o snd-soc-pcm3008-objs := pcm3008.o snd-soc-rt5631-objs := rt5631.o snd-soc-sgtl5000-objs := sgtl5000.o @@ -168,7 +168,7 @@ obj-$(CONFIG_SND_SOC_MAX98095) += snd-soc-max98095.o obj-$(CONFIG_SND_SOC_MAX9850) += snd-soc-max9850.o obj-$(CONFIG_SND_SOC_MC13783) += snd-soc-mc13783.o obj-$(CONFIG_SND_SOC_ML26124) += snd-soc-ml26124.o -obj-$(CONFIG_SND_SOC_OMAP_HDMI_CODEC) += snd-soc-omap-hdmi-codec.o +obj-$(CONFIG_SND_SOC_HDMI_CODEC) += snd-soc-hdmi-codec.o obj-$(CONFIG_SND_SOC_PCM3008) += snd-soc-pcm3008.o obj-$(CONFIG_SND_SOC_RT5631) += snd-soc-rt5631.o obj-$(CONFIG_SND_SOC_SGTL5000) += snd-soc-sgtl5000.o diff --git a/sound/soc/codecs/omap-hdmi.c b/sound/soc/codecs/hdmi.c similarity index 69% rename from sound/soc/codecs/omap-hdmi.c rename to sound/soc/codecs/hdmi.c index 529d064..2bcae2b 100644 --- a/sound/soc/codecs/omap-hdmi.c +++ b/sound/soc/codecs/hdmi.c @@ -1,5 +1,5 @@ /* - * ALSA SoC codec driver for HDMI audio on OMAP processors. + * ALSA SoC codec driver for HDMI audio codecs. * Copyright (C) 2012 Texas Instruments Incorporated - http://www.ti.com/ * Author: Ricardo Neri <ricardo.neri(a)ti.com> * @@ -23,10 +23,10 @@ #define DRV_NAME "hdmi-audio-codec" -static struct snd_soc_codec_driver omap_hdmi_codec; +static struct snd_soc_codec_driver hdmi_codec; -static struct snd_soc_dai_driver omap_hdmi_codec_dai = { - .name = "omap-hdmi-hifi", +static struct snd_soc_dai_driver hdmi_codec_dai = { + .name = "hdmi-hifi", .playback = { .channels_min = 2, .channels_max = 8, @@ -39,31 +39,31 @@ static struct snd_soc_dai_driver omap_hdmi_codec_dai = { }, }; -static int omap_hdmi_codec_probe(struct platform_device *pdev) +static int hdmi_codec_probe(struct platform_device *pdev) { - return snd_soc_register_codec(&pdev->dev, &omap_hdmi_codec, - &omap_hdmi_codec_dai, 1); + return snd_soc_register_codec(&pdev->dev, &hdmi_codec, + &hdmi_codec_dai, 1); } -static int omap_hdmi_codec_remove(struct platform_device *pdev) +static int hdmi_codec_remove(struct platform_device *pdev) { snd_soc_unregister_codec(&pdev->dev); return 0; } -static struct platform_driver omap_hdmi_codec_driver = { +static struct platform_driver hdmi_codec_driver = { .driver = { .name = DRV_NAME, .owner = THIS_MODULE, }, - .probe = omap_hdmi_codec_probe, - .remove = omap_hdmi_codec_remove, + .probe = hdmi_codec_probe, + .remove = hdmi_codec_remove, }; -module_platform_driver(omap_hdmi_codec_driver); +module_platform_driver(hdmi_codec_driver); MODULE_AUTHOR("Ricardo Neri <ricardo.neri(a)ti.com>"); -MODULE_DESCRIPTION("ASoC OMAP HDMI codec driver"); +MODULE_DESCRIPTION("ASoC generic HDMI codec driver"); MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:" DRV_NAME); diff --git a/sound/soc/omap/omap-hdmi-card.c b/sound/soc/omap/omap-hdmi-card.c index d4eaa92..7e66e9c 100644 --- a/sound/soc/omap/omap-hdmi-card.c +++ b/sound/soc/omap/omap-hdmi-card.c @@ -35,7 +35,7 @@ static struct snd_soc_dai_link omap_hdmi_dai = { .cpu_dai_name = "omap-hdmi-audio-dai", .platform_name = "omap-pcm-audio", .codec_name = "hdmi-audio-codec", - .codec_dai_name = "omap-hdmi-hifi", + .codec_dai_name = "hdmi-hifi", }; static struct snd_soc_card snd_soc_omap_hdmi = { -- 1.8.2.3

2 1

[alsa-devel] dsnoop memory leak
by Иван Больсунов 04 Jun '13

04 Jun '13

Since alsa bug tracker does not work for me for weeks, I have to report bug here. Sorry if it a wrong place. So, to reproduce memory leak (Alsa lib used v.1.0.27), you have to use next asound.conf: pcm_slave.myslave { pcm "hw:0,0" } pcm.mysnoop { type dsnoop ipc_key 1024 slave myslave } Then you simply do: snd_pcm_open(&pcm_handle, "mysnoop", SND_PCM_STREAM_CAPTURE, SND_PCM_NONBLOCK); snd_pcm_close(pcm_handle); snd_config_update_free_global(); Valgrind will show something like this: ==7889== ==7889== HEAP SUMMARY: ==7889== in use at exit: 15,854 bytes in 871 blocks ==7889== total heap usage: 333,212 allocs, 332,341 frees, 11,695,490 bytes allocated ==7889== ==7889== 15,834 (6,264 direct, 9,570 indirect) bytes in 174 blocks are definitely lost in loss record 6 of 6 ==7889== at 0x4027CBF: calloc (vg_replace_malloc.c:566) ==7889== by 0x406B416: _snd_config_make (in /usr/lib/libasound.so.2.0.0) ==7889== by 0x406C69C: snd_config_make (in /usr/lib/libasound.so.2.0.0) ==7889== by 0x406C861: snd_config_make_compound (in /usr/lib/libasound.so.2.0.0) ==7889== by 0x406D00C: _snd_config_copy (in /usr/lib/libasound.so.2.0.0) ==7889== by 0x406F112: snd_config_walk (in /usr/lib/libasound.so.2.0.0) ==7889== by 0x406FE04: snd_config_copy (in /usr/lib/libasound.so.2.0.0) ==7889== by 0x4070370: snd_config_expand (in /usr/lib/libasound.so.2.0.0) ==7889== by 0x407107E: snd_config_search_definition (in /usr/lib/libasound.so.2.0.0) ==7889== by 0x40D2C22: _snd_pcm_direct_get_slave_ipc_offset (in /usr/lib/libasound.so.2.0.0) ==7889== by 0x40D68A2: snd1_pcm_direct_parse_open_conf (in /usr/lib/libasound.so.2.0.0) ==7889== by 0x40D28CA: _snd_pcm_dsnoop_open (in /usr/lib/libasound.so.2.0.0) ==7889== by 0x40909C4: snd_pcm_open_conf (in /usr/lib/libasound.so.2.0.0) ==7889== by 0x4091036: snd_pcm_open_noupdate (in /usr/lib/libasound.so.2.0.0) ==7889== by 0x804873D: main (in /home/blah/al/a.out) ==7889== ==7889== LEAK SUMMARY: ==7889== definitely lost: 6,264 bytes in 174 blocks ==7889== indirectly lost: 9,570 bytes in 696 blocks ==7889== possibly lost: 0 bytes in 0 blocks ==7889== still reachable: 20 bytes in 1 blocks ==7889== suppressed: 0 bytes in 0 blocks ==7889== Reachable blocks (those to which a pointer was found) are not shown. ==7889== To see them, rerun with: --leak-check=full --show-reachable=yes ==7889== ==7889== For counts of detected and suppressed errors, rerun with: -v ==7889== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)

2 1

[alsa-devel] regression: from 3.8 to 3.9: headphones output no sound on Intel HDA, codec VIA VT1802
by Alex Riesen 04 Jun '13

04 Jun '13

Hi, I just noticed (use the headphones rarely) that the headphones on this System76 Lemur Ultra (lemu4) stopped working. There is absolutely no output. I tried reverting all changes to patch_via.c since v3.8, and have the sound back, but there wasn't much to revert: Revert "ALSA: hda - Rearrange INPUT_PIN_ATTR_*" Revert "ALSA: hda - Use generic parser for VIA codec driver" Revert "ALSA: hda - Enable parsing the independent HP mode as default for VIA codecs" Revert "ALSA: hda/via - Fix wrong checks of power state bits" Revert "ALSA: hda - Fix phantom jacks on VT1708" Revert "ALSA: hda - detect jacks on VT1708 even when no streams are active" Revert "ALSA: hda - Use generic array for loopback list management" and one change (which I indeed suspect) is large: the use of generic parser. The problem is also present in 3.10-rc1. The output of alsa-info.sh attached, for 3.8.12 and 3.9.2 respectively. Regards, Alex Riesen

2 30

[alsa-devel] [PATCH 1/1] ASoC: davinci-mcasp: Remove redundant use of of_match_ptr macro
by Sachin Kamat 03 Jun '13

03 Jun '13

'mcasp_dt_ids' is always compiled in. Hence of_match_ptr is not necessary. Signed-off-by: Sachin Kamat <sachin.kamat(a)linaro.org> --- sound/soc/davinci/davinci-mcasp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c index 56ecfc7..94f1e46 100644 --- a/sound/soc/davinci/davinci-mcasp.c +++ b/sound/soc/davinci/davinci-mcasp.c @@ -1023,7 +1023,7 @@ static struct snd_platform_data *davinci_mcasp_set_pdata_from_of( struct device_node *np = pdev->dev.of_node; struct snd_platform_data *pdata = NULL; const struct of_device_id *match = - of_match_device(of_match_ptr(mcasp_dt_ids), &pdev->dev); + of_match_device(mcasp_dt_ids, &pdev->dev); const u32 *of_serial_dir32; u8 *of_serial_dir; @@ -1256,7 +1256,7 @@ static struct platform_driver davinci_mcasp_driver = { .driver = { .name = "davinci-mcasp", .owner = THIS_MODULE, - .of_match_table = of_match_ptr(mcasp_dt_ids), + .of_match_table = mcasp_dt_ids, }, }; -- 1.7.9.5

2 1

[alsa-devel] No headphone control for ALC892 on Zotac Motherboard D2550ITXS-B-E
by Halim Sahin 03 Jun '13

03 Jun '13

Hi, Attached is output of alsa-info. Updated to Alsa-driver 1.0.25 running with 2.6.34 kernel. Frontpanel of my case has mic and headphone output connectors. front mic works but no headphones. Card works except headphones Can you please help? -- Halim Sahin E-Mail: halim.sahin (at) t-online.de

3 5

[alsa-devel] aplay lists both Playback and Capture devices
by Fabio Estevam 02 Jun '13

02 Jun '13

Hi, When running 'aplay -l' and 'arecord -l' I see the following output on a mx28evk running a 3.10-rc kernel: /$ aplay -l **** List of PLAYBACK Hardware Devices **** card 0: mxssgtl5000 [mxs_sgtl5000], device 0: Playback sgtl5000-0 [] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: mxssgtl5000 [mxs_sgtl5000], device 1: Capture sgtl5000-1 [] Subdevices: 1/1 Subdevice #0: subdevice #0 $ arecord -l **** List of CAPTURE Hardware Devices **** card 0: mxssgtl5000 [mxs_sgtl5000], device 0: Playback sgtl5000-0 [] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: mxssgtl5000 [mxs_sgtl5000], device 1: Capture sgtl5000-1 [] Subdevices: 1/1 Subdevice #0: subdevice #0 I would expect to see only the Playback entry in aplay and only the Record entry in arecord. Is there anything I should change in sound/soc/mxs/mxs-sgtl5000.c in order to get the correct outputs? Regards, Fabio Estevam

4 11

[alsa-devel] [PATCH 1/2] dma: Add a PAUSE_RESUME capability
by Lars-Peter Clausen 01 Jun '13

01 Jun '13

Add a capability which allows dmaengine consumers to query whether a dmaengine controller supports the DMA_PAUSE and DMA_RESUME commands. Sometimes a user of the dmaengine API needs to know in advance if a channel will support pause/resume. E.g. in ALSA the information whether it is possible to pause/resume a audio stream or whether it is necessary to abort and restart the stream is communicated to userspace so it can act accordingly. Signed-off-by: Lars-Peter Clausen <lars(a)metafoo.de> --- include/linux/dmaengine.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index 96d3e4a..ad98dfb 100644 --- a/include/linux/dmaengine.h +++ b/include/linux/dmaengine.h @@ -74,6 +74,7 @@ enum dma_transaction_type { DMA_SLAVE, DMA_CYCLIC, DMA_INTERLEAVE, + DMA_PAUSE_RESUME, /* last transaction type for creation of the capabilities mask */ DMA_TX_TYPE_END, }; -- 1.8.0

3 3

[alsa-devel] [PATCH 1/2] ASoC: wm8994: fix the codec state machine
by Vinod Koul 01 Jun '13

01 Jun '13

few places the mic_detecting is not updated correctly when state changes, causing jack detection to go wrong Signed-off-by: Vinod Koul <vinod.koul(a)intel.com> --- sound/soc/codecs/wm8994.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c index 49b2b00..43f82d2 100644 --- a/sound/soc/codecs/wm8994.c +++ b/sound/soc/codecs/wm8994.c @@ -3547,6 +3547,7 @@ static void wm8958_mic_id(void *data, u16 status) snd_soc_jack_report(wm8994->micdet[0].jack, 0, wm8994->btn_mask | SND_JACK_HEADSET); + wm8994->mic_detecting = true; return; } @@ -3672,7 +3673,7 @@ static irqreturn_t wm1811_jackdet_irq(int irq, void *data) snd_soc_update_bits(codec, WM1811_JACKDET_CTRL, WM1811_JACKDET_DB, WM1811_JACKDET_DB); - wm8994->mic_detecting = false; + wm8994->mic_detecting = true; wm8994->jack_mic = false; snd_soc_update_bits(codec, WM8958_MIC_DETECT_1, WM8958_MICD_ENA, 0); @@ -3696,6 +3697,7 @@ static irqreturn_t wm1811_jackdet_irq(int irq, void *data) /* Since we only report deltas force an update, ensures we * avoid bootstrapping issues with the core. */ snd_soc_jack_report(wm8994->micdet[0].jack, 0, 0); + wm8994->mic_detecting = true; pm_runtime_put(codec->dev); return IRQ_HANDLED; -- 1.7.0.4

2 3

[alsa-devel] [PATCH] ASoC: sgtl5000: Do not read registers prior to turning on the supplies
by Fabio Estevam 31 May '13

31 May '13

Commit b871f1ad (ASoC: sgtl5000: Read SGTL5000_CHIP_ID in i2c_probe()) placed the code for reading the codec revision prior to turning on the power supplies. Even though this works on some systems that always have the codec power supplies enabled, this is not correct, so revert this commit. Signed-off-by: Fabio Estevam <fabio.estevam(a)freescale.com> --- sound/soc/codecs/sgtl5000.c | 39 +++++++++++++++------------------------ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 1c3b20f..788af6c 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -1275,7 +1275,7 @@ static int sgtl5000_replace_vddd_with_ldo(struct snd_soc_codec *codec) static int sgtl5000_enable_regulators(struct snd_soc_codec *codec) { - int reg; + u16 reg; int ret; int rev; int i; @@ -1303,17 +1303,23 @@ static int sgtl5000_enable_regulators(struct snd_soc_codec *codec) /* wait for all power rails bring up */ udelay(10); - /* - * workaround for revision 0x11 and later, - * roll back to use internal LDO - */ - - ret = regmap_read(sgtl5000->regmap, SGTL5000_CHIP_ID, &reg); - if (ret) + /* read chip information */ + reg = snd_soc_read(codec, SGTL5000_CHIP_ID); + if (((reg & SGTL5000_PARTID_MASK) >> SGTL5000_PARTID_SHIFT) != + SGTL5000_PARTID_PART_ID) { + dev_err(codec->dev, + "Device with ID register %x is not a sgtl5000\n", reg); + ret = -ENODEV; goto err_regulator_disable; + } rev = (reg & SGTL5000_REVID_MASK) >> SGTL5000_REVID_SHIFT; + dev_info(codec->dev, "sgtl5000 revision 0x%x\n", rev); + /* + * workaround for revision 0x11 and later, + * roll back to use internal LDO + */ if (external_vddd && rev >= 0x11) { /* disable all regulator first */ regulator_bulk_disable(ARRAY_SIZE(sgtl5000->supplies), @@ -1497,7 +1503,7 @@ static int sgtl5000_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id) { struct sgtl5000_priv *sgtl5000; - int ret, reg, rev; + int ret; sgtl5000 = devm_kzalloc(&client->dev, sizeof(struct sgtl5000_priv), GFP_KERNEL); @@ -1511,21 +1517,6 @@ static int sgtl5000_i2c_probe(struct i2c_client *client, return ret; } - /* read chip information */ - ret = regmap_read(sgtl5000->regmap, SGTL5000_CHIP_ID, &reg); - if (ret) - return ret; - - if (((reg & SGTL5000_PARTID_MASK) >> SGTL5000_PARTID_SHIFT) != - SGTL5000_PARTID_PART_ID) { - dev_err(&client->dev, - "Device with ID register %x is not a sgtl5000\n", reg); - return -ENODEV; - } - - rev = (reg & SGTL5000_REVID_MASK) >> SGTL5000_REVID_SHIFT; - dev_info(&client->dev, "sgtl5000 revision 0x%x\n", rev); - i2c_set_clientdata(client, sgtl5000); /* Ensure sgtl5000 will start with sane register values */ -- 1.8.1.2

5 8