May 2013 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] [PATCH v5 2/2] ASoC: sgtl5000: Fix driver probe after reset
by Fabio Estevam 10 May '13

10 May '13

Hi Matt, On Fri, May 10, 2013 at 2:14 PM, Matt Sealey <matt(a)genesi-usa.com> wrote: > Hi Fabio! > > Is there any way to make that failure a little less of a "failure" or > even a warning, since the message below; > >> sgtl5000 0-000a: Using internal LDO instead of VDDD > > Pretty much covers that VDDD was not supplied. I would consider that > you would want to say "VDDD wasn't supplied" in the sense that it is > optional and not give in pdata or dt, and then remark that the LDO was > actually configured.. I don't like it when my kernels boot up and spit > out high numbered errno's for the sake of a completely optional entry > in the design vs. missing and still optional entry in the device tree. Yes, I plan to clean the sgtl5000 log messages. I agree that it is currently too noisy. Will do it after Mark applies this series. Regards, Fabio Estevam

1 0

Re: [alsa-devel] [RFC 42/42] sound/soc/kirkwood: don't check resource with devm_ioremap_resource
by Mark Brown 10 May '13

10 May '13

On Fri, May 10, 2013 at 10:17:27AM +0200, Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com>

1 0

Re: [alsa-devel] [RFC 41/42] sound/soc/fsl: don't check resource with devm_ioremap_resource
by Mark Brown 10 May '13

10 May '13

On Fri, May 10, 2013 at 10:17:26AM +0200, Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com>

1 0

[alsa-devel] [PATCH v3] ASoC: sgtl5000: Fix driver probe after reset
by Fabio Estevam 10 May '13

10 May '13

sgtl5000 codec does not have a reset line, nor a reset command in software. After a 'reboot' command in Linux or after pressing the system's reset button the sgtl5000 driver fails to probe: sgtl5000 0-000a: Device with ID register ffff is not a sgtl5000 sgtl5000 0-000a: ASoC: failed to probe CODEC -19 imx-sgtl5000 sound.12: ASoC: failed to instantiate card -19 imx-sgtl5000 sound.12: snd_soc_register_card failed (-19) As the sgtl5000 codec did not go through a real reset, we cannot rely on the sgtl5000_reg_defaults table, since these are only valid after a clean power-on reset. Fix this issue by explicitly reading all the sgtl5000 registers and filling sgtl5000_reg_defaults with such values. Signed-off-by: Fabio Estevam <fabio.estevam(a)freescale.com> --- Changes since v2: - Do not use reg_defaults_raw as it is not the correct purpose - Manually build sgtl5000_reg_default - Improve commitlog Changes since v1: - Remove sgtl5000_reg_defaults array - Do not use num_reg_defaults_raw sound/soc/codecs/sgtl5000.c | 58 ++++++++++++++++++++++++------------------- 1 file changed, 33 insertions(+), 25 deletions(-) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 327b443..311dfb5 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -35,31 +35,7 @@ #define SGTL5000_MAX_REG_OFFSET 0x013A /* default value of sgtl5000 registers */ -static const struct reg_default sgtl5000_reg_defaults[] = { - { SGTL5000_CHIP_CLK_CTRL, 0x0008 }, - { SGTL5000_CHIP_I2S_CTRL, 0x0010 }, - { SGTL5000_CHIP_SSS_CTRL, 0x0008 }, - { SGTL5000_CHIP_DAC_VOL, 0x3c3c }, - { SGTL5000_CHIP_PAD_STRENGTH, 0x015f }, - { SGTL5000_CHIP_ANA_HP_CTRL, 0x1818 }, - { SGTL5000_CHIP_ANA_CTRL, 0x0111 }, - { SGTL5000_CHIP_LINE_OUT_VOL, 0x0404 }, - { SGTL5000_CHIP_ANA_POWER, 0x7060 }, - { SGTL5000_CHIP_PLL_CTRL, 0x5000 }, - { SGTL5000_DAP_BASS_ENHANCE, 0x0040 }, - { SGTL5000_DAP_BASS_ENHANCE_CTRL, 0x051f }, - { SGTL5000_DAP_SURROUND, 0x0040 }, - { SGTL5000_DAP_EQ_BASS_BAND0, 0x002f }, - { SGTL5000_DAP_EQ_BASS_BAND1, 0x002f }, - { SGTL5000_DAP_EQ_BASS_BAND2, 0x002f }, - { SGTL5000_DAP_EQ_BASS_BAND3, 0x002f }, - { SGTL5000_DAP_EQ_BASS_BAND4, 0x002f }, - { SGTL5000_DAP_MAIN_CHAN, 0x8000 }, - { SGTL5000_DAP_AVC_CTRL, 0x0510 }, - { SGTL5000_DAP_AVC_THRESHOLD, 0x1473 }, - { SGTL5000_DAP_AVC_ATTACK, 0x0028 }, - { SGTL5000_DAP_AVC_DECAY, 0x0050 }, -}; +static struct reg_default sgtl5000_reg_defaults[SGTL5000_MAX_REG_OFFSET + 1]; /* regulator supplies for sgtl5000, VDDD is an optional external supply */ enum sgtl5000_regulator_supplies { @@ -1355,6 +1331,33 @@ err_regulator_free: } +/* + * Read all the sgtl5000 registers to fill the cache, as + * we cannot rely on a pre-defined table containing the + * power-on reset values of the registers as done in most + * of the other codec drivers. + * + * We follow this approach here because sgtl5000 does not have + * a reset line, nor a reset command in software, and this way + * we can guarantee that we always have sane register values + * stored in the reg_defaults table after a reset + */ +static int sgtl5000_fill_cache(struct snd_soc_codec *codec) +{ + int i, reg, ret; + struct sgtl5000_priv *sgtl5000 = snd_soc_codec_get_drvdata(codec); + + for (i = 0; i < SGTL5000_MAX_REG_OFFSET; i += 2) { + ret = regmap_read(sgtl5000->regmap, i, &reg); + if (ret < 0) + return ret; + sgtl5000_reg_defaults[i].reg = i; + sgtl5000_reg_defaults[i].def = reg; + } + + return 0; +} + static int sgtl5000_probe(struct snd_soc_codec *codec) { int ret; @@ -1377,6 +1380,11 @@ static int sgtl5000_probe(struct snd_soc_codec *codec) if (ret) goto err; + /* Build the reg_defaults manually by reading the registers */ + ret = sgtl5000_fill_cache(codec); + if (ret) + goto err; + /* enable small pop, introduce 400ms delay in turning off */ snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, -- 1.7.9.5

4 4

Re: [alsa-devel] [PATCH v2] ASoC: sgtl5000: Fix driver probe after reset
by Mark Brown 10 May '13

10 May '13

On Thu, May 09, 2013 at 12:08:38PM -0500, Matt Sealey wrote: > match a reset chip powered on for the first time. What we should > actually be doing is dumping these into the chip as the first thing we > do at probe, and then they DO become the reasonable defaults. Yes, this is eactly what I keep saying :/ > The fix is keep using cache/regmaps or whatever, but it definitely > would be an absolute requirement to reset the codec manually by > putting in all the right register values before using the cache, which You don't need to disable the cache at any point.

1 0

[alsa-devel] TLV question - ranges not in volume order
by David Henningsson 10 May '13

10 May '13

Hi, I recently came across a strange ASoC volume control. In this case, the values are not in volume order, i e, the control is declared something like below. I believe the numbers correctly match the hardware. However alsamixer seems not to handle this "reordering" correctly. My question is if this is something that should be fixed in alsamixer (or possibly alsa-lib?), or does one need to write some kind of mapping table in the kernel, just to make something come in volume order to userspace? Any TLV documentation on what TLVs are valid and invalid is also welcome :-) static const unsigned int tlv[] = { TLV_DB_RANGE_HEAD(8), 0, 0, TLV_DB_SCALE_ITEM(-100, 0, 1), 1, 1, TLV_DB_SCALE_ITEM(400, 0, 0), 2, 2, TLV_DB_SCALE_ITEM(200, 0, 0), 3, 3, TLV_DB_SCALE_ITEM(1000, 0, 0), 4, 4, TLV_DB_SCALE_ITEM(0, 0, 0), 5, 5, TLV_DB_SCALE_ITEM(800, 0, 0), 6, 6, TLV_DB_SCALE_ITEM(600, 0, 0), 7, 7, TLV_DB_SCALE_ITEM(1200, 0, 0), }; -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic

4 6

Re: [alsa-devel] [RFC PATCH 1/3] drm/915: Add private api for power well usage
by Daniel Vetter 10 May '13

10 May '13

Hi all, Three things: 1. Any reason public mailing lists (intel-gfx, alsa-devel) aren't cc'ed? Afaics no secret stuff is being discussed here ... Please resend the patches with mailings lists cc'ed. 2. On a quick read of the hda driver stuff I don't think the power well enable/disable places are at the right spot: We force the power well on whenever the hda codec is used, but we must only do that when we want to output audio to external screens. And since that state transition can only really happen due to a modeset change on the gfx side I don't think we need any autosuspend delays either. The use-case I'm thinking of is media playback with just the panel enabled: In that case we can switch off the power well on the display side, and I don't think the power well is required for audio play back on the integrated speakerrs/headphone-jack either. 3. The moduel depencies seem to still not work out dynamically, at least I think we still have a hard chain between hda-intel and i915.ko (just with one thing in between now). Cheers, Daniel On Thu, May 9, 2013 at 9:23 AM, Wang, Xingchao <xingchao.wang(a)intel.com> wrote: > Hi All, > > This is a newer version patchset for power well feature implementation. > > I will send out a document later to describe the design, especially for David and Takashi as they could not see Bspec > so it maybe a bit confuse. Meanwhile Liam will send out a meeting request for discussion, welcome Daniel, Paulo, Jesse to join us. > > Basically, here's the latest working status on my side: > > I tested the power well feature on Haswell ULT board, there's only one eDP port used. > Without this patch and we enabled power well feature, gfx driver will shutdown power well, audio driver will crash. > Applied this patch, display audio driver will request power well on before initialize the card. In gfx side, it will enable power well. > > Also power_save feature in audio side should be enabled, I set "5" second to let codec enter suspend when free for 5s long. > Audio controller driver detects all codecs are suspended it will release power well and suspend too. Gfx driver will receive the request and shut down power well. > > If user trigger some audio operations(cat codec# info), audio controller driver will request power well again... > > If gfx side decided to disable power well now, while audio is in use, power well would be kept on. > > Generally audio drvier will request power well on need and release it immediately after suspend. Gfx should make decision at his side. > > The new introduced module "hda-i915" has dependency on i915, only built in when i915 enabled. So it's safe for call. > This module was based on David's original patch, which added pm_suspend/resume callback for hdmi codec. As the codecs and controller are both depending on powerwell, > and codec *must* already on power so I moved the power well request/release to controller side and changed the module name to "hda-i915". > David, would you like me to add you as author for the second patch? :) > > For non-Haswell platform, power well is no need atm. If the module is built in and gfx will reject power well request at its side, so it's safe too. > > thanks > --xingchao > > >> -----Original Message----- >> From: Wang Xingchao [mailto:xingchao.wang@linux.intel.com] >> Sent: Thursday, May 09, 2013 3:01 PM >> To: david.henningsson(a)canonical.com; Girdwood, Liam R; tiwai(a)suse.de; >> daniel(a)ffwll.ch >> Cc: Barnes, Jesse; Li, Jocelyn; Lin, Mengdong; Wang, Xingchao; Zanoni, Paulo R; >> Wang Xingchao >> Subject: [RFC PATCH 1/3] drm/915: Add private api for power well usage >> >> Haswell Display audio depends on power well in graphic side, it should request >> power well before use it and release power well after use. >> I915 will not shutdown power well if it detects audio is using. >> This patch protects display audio crash for Intel Haswell mobile >> C3 stepping board. >> >> Signed-off-by: Wang Xingchao <xingchao.wang(a)linux.intel.com> >> --- >> drivers/gpu/drm/i915/intel_pm.c | 127 >> ++++++++++++++++++++++++++++++++++++--- >> include/drm/audio_drm.h | 39 ++++++++++++ >> 2 files changed, 159 insertions(+), 7 deletions(-) create mode 100644 >> include/drm/audio_drm.h >> >> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c >> index 2557926..cba753e 100644 >> --- a/drivers/gpu/drm/i915/intel_pm.c >> +++ b/drivers/gpu/drm/i915/intel_pm.c >> @@ -4298,18 +4298,12 @@ bool intel_using_power_well(struct drm_device >> *dev) >> return true; >> } >> >> -void intel_set_power_well(struct drm_device *dev, bool enable) >> +void set_power_well(struct drm_device *dev, bool enable) >> { >> struct drm_i915_private *dev_priv = dev->dev_private; >> bool is_enabled, enable_requested; >> uint32_t tmp; >> >> - if (!HAS_POWER_WELL(dev)) >> - return; >> - >> - if (!i915_disable_power_well && !enable) >> - return; >> - >> tmp = I915_READ(HSW_PWR_WELL_DRIVER); >> is_enabled = tmp & HSW_PWR_WELL_STATE; >> enable_requested = tmp & HSW_PWR_WELL_ENABLE; @@ -4332,6 >> +4326,125 @@ void intel_set_power_well(struct drm_device *dev, bool >> enable) >> } >> } >> >> +/* Global drm_device for display audio drvier usage */ static struct >> +drm_device *power_well_device; >> +/* Lock protecting power well setting */ >> +DEFINE_SPINLOCK(powerwell_lock); static bool i915_power_well_using; >> + >> +struct power_well { >> + int user_cnt; >> + struct list_head power_well_list; >> +}; >> + >> +static struct power_well hsw_power = { >> + .user_cnt = 0, >> + .power_well_list = LIST_HEAD_INIT(hsw_power.power_well_list), >> +}; >> + >> +struct power_well_user { >> + char name[16]; >> + struct list_head list; >> +}; >> + >> +void i915_request_power_well(const char *name) { >> + struct power_well_user *user; >> + >> + DRM_DEBUG_KMS("request power well for %s\n", name); >> + spin_lock_irq(&powerwell_lock); >> + if (!power_well_device) >> + goto out; >> + >> + if (!IS_HASWELL(power_well_device)) >> + goto out; >> + >> + list_for_each_entry(user, &hsw_power.power_well_list, list) { >> + if (!strcmp(user->name, name)) { >> + goto out; >> + } >> + } >> + >> + user = kzalloc(sizeof(*user), GFP_KERNEL); >> + if (user == NULL) { >> + goto out; >> + } >> + strcpy(user->name, name); >> + >> + list_add(&user->list, &hsw_power.power_well_list); >> + hsw_power.user_cnt++; >> + >> + if (hsw_power.user_cnt == 1) { >> + set_power_well(power_well_device, true); >> + DRM_DEBUG_KMS("%s set power well on\n", user->name); >> + } >> +out: >> + spin_unlock_irq(&powerwell_lock); >> + return; >> +} >> +EXPORT_SYMBOL_GPL(i915_request_power_well); >> + >> +void i915_release_power_well(const char *name) { >> + struct power_well_user *user; >> + >> + DRM_DEBUG_KMS("release power well from %s\n", name); >> + spin_lock_irq(&powerwell_lock); >> + if (!power_well_device) >> + goto out; >> + >> + if (!IS_HASWELL(power_well_device)) >> + goto out; >> + >> + list_for_each_entry(user, &hsw_power.power_well_list, list) { >> + if (!strcmp(user->name, name)) { >> + list_del(&user->list); >> + hsw_power.user_cnt--; >> + DRM_DEBUG_KMS("Releaseing power well:%s, user_cnt:%d, >> i915 using:%d\n", >> + user->name, hsw_power.user_cnt, >> i915_power_well_using); >> + if (!hsw_power.user_cnt && !i915_power_well_using) >> + set_power_well(power_well_device, false); >> + goto out; >> + } >> + } >> + >> + DRM_DEBUG_KMS("power well %s doesnot exist\n", name); >> +out: >> + spin_unlock_irq(&powerwell_lock); >> + return; >> +} >> +EXPORT_SYMBOL_GPL(i915_release_power_well); >> + >> +/* TODO: Call this when i915 module unload */ void >> +remove_power_well(void) { >> + spin_lock_irq(&powerwell_lock); >> + i915_power_well_using = false; >> + power_well_device = NULL; >> + spin_unlock_irq(&powerwell_lock); >> +} >> + >> +void intel_set_power_well(struct drm_device *dev, bool enable) { >> + if (!HAS_POWER_WELL(dev)) >> + return; >> + >> + spin_lock_irq(&powerwell_lock); >> + power_well_device = dev; >> + i915_power_well_using = enable; >> + if (!enable && hsw_power.user_cnt) { >> + DRM_DEBUG_KMS("Display audio power well busy using now\n"); >> + goto out; >> + } >> + >> + if (!i915_disable_power_well && !enable) >> + goto out; >> + set_power_well(dev, enable); >> +out: >> + spin_unlock_irq(&powerwell_lock); >> + return; >> +} >> + >> /* >> * Starting with Haswell, we have a "Power Down Well" that can be turned off >> * when not needed anymore. We have 4 registers that can request the >> power well diff --git a/include/drm/audio_drm.h b/include/drm/audio_drm.h >> new file mode 100644 index 0000000..215295f >> --- /dev/null >> +++ b/include/drm/audio_drm.h >> @@ -0,0 +1,39 @@ >> +/************************************************************** >> ******** >> +**** >> + * >> + * Copyright 2013 Intel Inc. >> + * All Rights Reserved. >> + * >> + * Permission is hereby granted, free of charge, to any person >> +obtaining a >> + * copy of this software and associated documentation files (the >> + * "Software"), to deal in the Software without restriction, including >> + * without limitation the rights to use, copy, modify, merge, publish, >> + * distribute, sub license, and/or sell copies of the Software, and to >> + * permit persons to whom the Software is furnished to do so, subject >> +to >> + * the following conditions: >> + * >> + * The above copyright notice and this permission notice (including the >> + * next paragraph) shall be included in all copies or substantial >> +portions >> + * of the Software. >> + * >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, >> +EXPRESS OR >> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF >> +MERCHANTABILITY, >> + * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO >> EVENT >> +SHALL >> + * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE >> FOR >> +ANY CLAIM, >> + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, >> TORT >> +OR >> + * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE >> SOFTWARE >> +OR THE >> + * USE OR OTHER DEALINGS IN THE SOFTWARE. >> + * >> + * >> + >> +*************************************************************** >> ******** >> +***/ >> +/* >> + * Authors: >> + * Wang Xingchao <xingchao.wang(a)intel.com> */ >> + >> +#ifndef _AUDIO_DRM_H_ >> +#define _AUDIO_DRM_H_ >> + >> +extern void i915_request_power_well(const char *name); extern void >> +i915_release_power_well(const char *name); >> + >> +#endif /* _AUDIO_DRM_H_ */ >> -- >> 1.7.9.5 > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

4 5

[alsa-devel] [PATCH v4] ASoC: sgtl5000: Fix driver probe after reset
by Fabio Estevam 10 May '13

10 May '13

From: Fabio Estevam <fabio.estevam(a)freescale.com> After a 'reboot' command in Linux or after pressing the system's reset button the sgtl5000 driver fails to probe: sgtl5000 0-000a: Device with ID register ffff is not a sgtl5000 sgtl5000 0-000a: ASoC: failed to probe CODEC -19 imx-sgtl5000 sound.12: ASoC: failed to instantiate card -19 imx-sgtl5000 sound.12: snd_soc_register_card failed (-19) sgtl5000 codec does not have a reset line, nor a reset command in software, so after a system reset the codec does not contain the default register values from sgtl5000_reg_defaults[] anymore, as these are only valid after a power-on-reset cycle. Fix this issue by explicitly reading all the reset register values from sgtl5000_reg_defaults[] and writing them back into sgtl5000 to ensure a sane state. Signed-off-by: Fabio Estevam <fabio.estevam(a)freescale.com> --- Changes since v3: - Read sgtl5000_reg_defaults and write these values into sgtl5000 Changes since v2: - Do not use reg_defaults_raw as it is not the correct purpose - Manually build sgtl5000_reg_default - Improve commitlog Changes since v1: - Remove sgtl5000_reg_defaults array - Do not use num_reg_defaults_raw sound/soc/codecs/sgtl5000.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 327b443..be23fce 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -1474,6 +1474,31 @@ static const struct regmap_config sgtl5000_regmap = { .num_reg_defaults = ARRAY_SIZE(sgtl5000_reg_defaults), }; +/* + * Write all the default values from sgtl5000_reg_defaults[] array into the + * sgtl5000 registers, to make sure we always start with the sane registers + * values as stated in the datasheet. + * + * Since sgtl5000 does not have a reset line, nor a reset command in software, + * we follow this approach to guarantee we always start from the default values + * and avoid problems like, not being able to probe after an audio playback + * followed by a system reset or a 'reboot' command in Linux + */ +static int sgtl5000_fill_defaults(struct sgtl5000_priv *sgtl5000) +{ + int i, ret, val, index; + + for (i = 0; i < ARRAY_SIZE(sgtl5000_reg_defaults); i++) { + val = sgtl5000_reg_defaults[i].def; + index = sgtl5000_reg_defaults[i].reg; + ret = regmap_write(sgtl5000->regmap, index, val); + if (ret) + return ret; + } + + return 0; +} + static int sgtl5000_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id) { @@ -1494,6 +1519,11 @@ static int sgtl5000_i2c_probe(struct i2c_client *client, i2c_set_clientdata(client, sgtl5000); + /* Ensure sgtl5000 will start with sane register values */ + ret = sgtl5000_fill_defaults(sgtl5000); + if (ret) + return ret; + ret = snd_soc_register_codec(&client->dev, &sgtl5000_driver, &sgtl5000_dai, 1); return ret; -- 1.7.9.5

2 1

Re: [alsa-devel] BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'
by Alan Stern 09 May '13

09 May '13

On Wed, 8 May 2013, Joe Rayhawk wrote: > For what it's worth, the following -stable patch > > "ALSA: USB: adjust for changed 3.8 USB API" > c75c5ab575af7db707689cdbb5a5c458e9a034bb > > fixes the discontinuous playback on period sizes between 139 and 192, > but the discontinuous playback on period sizes between 48 and 138 has > been replaced by rather worse kernel blocking and kernel errors: > > jrayhawk@richardiv:~$ sudo tail -F -n 0 /var/log/kern.log & > [1] 4490 > jrayhawk@richardiv:~$ time perl -e 'print pack "H*", "00FF" x 2048' | aplay --period-size=192 -r 48000 -f S16_LE -c2 -D hw:0,0 > Playing raw data 'stdin' : Signed 16 bit Little Endian, Rate 48000 Hz, Stereo > > real 0m0.053s > user 0m0.008s > sys 0m0.000s > jrayhawk@richardiv:~$ time perl -e 'print pack "H*", "00FF" x 2048' | aplay --period-size=48 -r 48000 -f S16_LE -c2 -D hw:0,0 > Playing raw data 'stdin' : Signed 16 bit Little Endian, Rate 48000 Hz, Stereo > May 8 17:01:56 richardiv kernel: [ 1680.923474] cannot submit urb (err = -18) > May 8 17:01:56 richardiv kernel: [ 1680.924472] cannot submit urb (err = -18) > > real 0m10.023s > user 0m0.008s > sys 0m0.004s I don't know if you want to investigate this in any detail. If you do, please post a usbmon trace of a failed playback. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe alsa-devel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

1 0

[alsa-devel] [PATCH v2] ASoC: sgtl5000: Fix driver probe after reset
by Fabio Estevam 09 May '13

09 May '13

From: Fabio Estevam <fabio.estevam(a)freescale.com> sgtl5000 codec does not have a reset line, nor a reset command in software. After a 'reboot' command in Linux or after pressing the system's reset button the sgtl5000 driver fails to probe: sgtl5000 0-000a: Device with ID register ffff is not a sgtl5000 sgtl5000 0-000a: ASoC: failed to probe CODEC -19 imx-sgtl5000 sound.12: ASoC: failed to instantiate card -19 imx-sgtl5000 sound.12: snd_soc_register_card failed (-19) As the sgtl5000 codec did not go through a real reset, we cannot rely on the sgtl5000_reg_defaults array, since these are only valid after a clean power-on reset. To fix this issue, use 'num_reg_defaults_raw' which tells the regcache driver to actually read the codec registers and then fill the cache with these values. Signed-off-by: Fabio Estevam <fabio.estevam(a)freescale.com> --- Changes since v1: - Remove sgtl5000_reg_defaults array - Do not use num_reg_defaults_raw sound/soc/codecs/sgtl5000.c | 30 +----------------------------- 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 327b443..fa342f7 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -34,33 +34,6 @@ #define SGTL5000_DAP_REG_OFFSET 0x0100 #define SGTL5000_MAX_REG_OFFSET 0x013A -/* default value of sgtl5000 registers */ -static const struct reg_default sgtl5000_reg_defaults[] = { - { SGTL5000_CHIP_CLK_CTRL, 0x0008 }, - { SGTL5000_CHIP_I2S_CTRL, 0x0010 }, - { SGTL5000_CHIP_SSS_CTRL, 0x0008 }, - { SGTL5000_CHIP_DAC_VOL, 0x3c3c }, - { SGTL5000_CHIP_PAD_STRENGTH, 0x015f }, - { SGTL5000_CHIP_ANA_HP_CTRL, 0x1818 }, - { SGTL5000_CHIP_ANA_CTRL, 0x0111 }, - { SGTL5000_CHIP_LINE_OUT_VOL, 0x0404 }, - { SGTL5000_CHIP_ANA_POWER, 0x7060 }, - { SGTL5000_CHIP_PLL_CTRL, 0x5000 }, - { SGTL5000_DAP_BASS_ENHANCE, 0x0040 }, - { SGTL5000_DAP_BASS_ENHANCE_CTRL, 0x051f }, - { SGTL5000_DAP_SURROUND, 0x0040 }, - { SGTL5000_DAP_EQ_BASS_BAND0, 0x002f }, - { SGTL5000_DAP_EQ_BASS_BAND1, 0x002f }, - { SGTL5000_DAP_EQ_BASS_BAND2, 0x002f }, - { SGTL5000_DAP_EQ_BASS_BAND3, 0x002f }, - { SGTL5000_DAP_EQ_BASS_BAND4, 0x002f }, - { SGTL5000_DAP_MAIN_CHAN, 0x8000 }, - { SGTL5000_DAP_AVC_CTRL, 0x0510 }, - { SGTL5000_DAP_AVC_THRESHOLD, 0x1473 }, - { SGTL5000_DAP_AVC_ATTACK, 0x0028 }, - { SGTL5000_DAP_AVC_DECAY, 0x0050 }, -}; - /* regulator supplies for sgtl5000, VDDD is an optional external supply */ enum sgtl5000_regulator_supplies { VDDA, @@ -1470,8 +1443,7 @@ static const struct regmap_config sgtl5000_regmap = { .readable_reg = sgtl5000_readable, .cache_type = REGCACHE_RBTREE, - .reg_defaults = sgtl5000_reg_defaults, - .num_reg_defaults = ARRAY_SIZE(sgtl5000_reg_defaults), + .num_reg_defaults_raw = SGTL5000_MAX_REG_OFFSET, }; static int sgtl5000_i2c_probe(struct i2c_client *client, -- 1.7.9.5

2 1